June 2009 - Wine-Devel - list.winehq.org

Re: wine compatible logo needed
by Metody Stefanov June 24, 2009

June 24, 2009

Thanks for all the responses. Yes, I intend to specify the wine version and the linux distro used. I had in mind something like this for the manual: "System Requirements: [...] Hardware stuff [...] Operating system: Windows XP SP2 or later. [WORKS WITH WINE LOGO GOES HERE] wine* 1.1.24 (or should I use just 1.1?) " And then, a footnote: "Works with wine 1.1.24, openSuSe 11.1 linux, see Appendix A "Technical notes/Descriptions" (Have to come up with a better name) for more information" And then in the appendix, a small description of what wine is, something along the lines of : [wine official logo] wine: Application compatibility layer that allows running software designed for windows on other OSses. Follows a list of OSes that are supported (resp. architectures etc.) and then a note that wine is work in progress so experience with later/previous versions may vary (will think of a better way to put it). Thoughts? Cheers, Metody Stefanov (PS sorry for the distorted first post (and this one if it turns bad as well). PC I'm using at the moment has a strictly no-linux, no-other soft policy, only Microsoft pre-installed stuff. Outlook Express in this case...)

2 1

Is there any way to debug driver?
by Guan, Xiao-Feng June 24, 2009

June 24, 2009

Hello, I'm AMD driver developer and would like to ask a question. This issue blocks us from making a better driver for WINE. Recently we have difficulty in debugging our driver with WINE. We used to start wine-pthread in gdb to debug the applications. Or else we cannot break into our driver. However, now we cannot build this executable any more in wine-1.1.23 or git repository. I wonder if there is any other method to get all symbols right in gdb. As we can see that, from version 1.1.23, all application fails to start on AMD card. We are going to investigate why it happens. If it is necessary, Would you please let us know a little more about the changes of this version? Thanks & regards. Guan Xiaofeng OpenGL Software Engineer, Graphic Product Group Shanghai R&D Center, AMD Cop. Xiao-Feng.Guan(a)amd.com <mailto:Xiao-Feng.Guan(a)amd.com> Tel 86 021 61601838 ext 25746

9 14

Re: wine-patches Digest, Vol 47, Issue 188
by Ricardo Filipe June 23, 2009

June 23, 2009

2009/6/23 Pavel Procházka <pavelvonlostice(a)seznam.cz> > hello > I want to ask you if i should resend the patch in correct form, sorry for > the last patch. > Thank you for answer > do not send "normal" messages to wine-patches. send those to wine-devel, wine-patches is for messages with attached patches only. yes, you should resend your patches with the corrections and suggestions stefan and james gave you. put (resend) or (try 2) on the subject. you should avoid resending more than 2 or 3 times a week, unless you've cleared with julliard. regards.

1 0

wine compatible logo needed
by Metody Stefanov June 23, 2009

June 23, 2009

Long story short - I've developed a small piece of software for the local govt, and it appears to work out-of-the-box under wine (openSuse 11.1). Since now I'm writing the user/admin manuals (heh, a nice way to discover some bugs BTW - "If you click this, this happens... oh wait, last time it did, now it doesn't"), I was wondering if there is an official "100% wine compatible" logo - you know, something like the "Designed for Windows" that most hardware manifacturers put on their boxes. Or any other standartized method of mentioning the fact that the software works under wine out of the box. Cheers, M. Stefanov.

6 6

Re: Pavel Procházka's commit
by James Mckenzie June 23, 2009

June 23, 2009

Pavel Procházka <pavelvonlostice(a)seznam.cz> wrote about Pavel Procházka's commit > Needs a more descriptive title here. Need to state what module/file the patch affects. One patch per patch message. Order them in the manner they should be installed and mark with [n/x] where n is the patch number and x is the number of patch files. Need to use spacing for your patches OR follow the pattern in use in the file. Tab stops are HIGHLY discouraged. Add test cases, if needed, to demonstrate what you are attempting to do is what Windows(TM) does with the same inputs. James McKenzie

1 0

Re: advapi32: Add-some-flesh-to-LsaLookupNames2
by Paul Vriens June 23, 2009

June 23, 2009

Louis. Lenders wrote: > Hi, this is enough added to make several .net 2.0 apps and .net 3.0 installer happy. > Patches based on patches from Aric that somehow never made it in, so i simplified it in the sense that only 1 name in the names array is handled for now. Next patch are some tests > Hi Louis, Indentation is a bit off here: + if (count != 1) + { + return STATUS_NONE_MAPPED; + } -- Cheers, Paul.

1 0

Fwd: [Wine] Bigpond Media Downloader works with Wine
by Austin English June 23, 2009

June 23, 2009

On Tue, Jun 23, 2009 at 4:38 AM, mgray<wineforum-user(a)winehq.org> wrote: > Hi there, > > This is my first EVER linux-based post (scary!). Just to say I switched to linux (Xubuntu 9.04) yesterday from XP, and have got everything that HAD to be exe working, including Bigpond Media Downloader. Bigpond is an Australian communications network, who also sell songs, movies, etc. They have a media downloader specifically for their files, which was making me a bit nervous - it's only available for Mac and Microsoft OSs. But I used Wine, and it works totally fine. If a complete newb like me can get it to work, anybody can. 'If a complete newb like me can get it to work, anybody can.' :-) -- -Austin

1 0

Re: [2/3] ole32: Implement CoGetContextToken.
by Rob Shearman June 23, 2009

June 23, 2009

2009/6/23 Hans Leidekker <hans(a)codeweavers.com>: > @@ -228,6 +232,7 @@ static void COM_TlsDestroy(void) > if (info->errorinfo) IErrorInfo_Release(info->errorinfo); > if (info->state) IUnknown_Release(info->state); > if (info->spy) IUnknown_Release(info->spy); > + if (info->context_token) IUnknown_Release((IUnknown *)info->context_token); > HeapFree(GetProcessHeap(), 0, info); > NtCurrentTeb()->ReservedForOle = NULL; > } Why not change the type of info->context_token to be IObjContext* or IUnknown* instead of ULONG_PTR? It shouldn't change the memory layout of the oletls structure and it will eliminate the need of these types of casts. -- Rob Shearman

1 0

RE: [comctl32] Test request
by Ge van Geldorp June 23, 2009

June 23, 2009

> From: Nikolay Sivov <bunglehead(a)gmail.com> > > I've just prepared some simple MRU tests and I need test them on various native platfoms - > tested only on xp sp2 so this one could be skipped. > > Could somebody do it? Your tests pass on my W2K, XP, W2K3, Vista and W2K8 machines, but I get crashes which were not there before on NT4 Workstation and NT4 Server (both SP6). I haven't investigated further, I could probably determine the test case that crashes if needed. Ge.

3 5

Translation statistics page errors
by Paul Chitescu June 23, 2009

June 23, 2009

While trying to identify missing translations: http://source.winehq.org/transl/resource.php?lang=009%3A01&resfile=dlls%2Fs… Got: Wine translations > English (US) > dlls/shell32 > STRINGTABLE #11 (strings 160..175) Dump of STRINGTABLE #11 (strings 160..175) Warning: assert() [function.assert]: Assertion failed in /home/winehq/opt/git-tools/transl/php/lib_res.php on line 343 Warning: assert() [function.assert]: Assertion failed in /home/winehq/opt/git-tools/transl/php/lib_res.php on line 343 Resource not found in *.res file

1 0

Re: urlmon: [Patch 1] Implement CreateZoneEnumerator, GetZoneAt, DestroyZoneEnumerator [try 3]
by Jacek Caban June 22, 2009

June 22, 2009

Hi Detlef, Detlef Riekenberg wrote: > This time, we don't care about dwEnum. > That value is returned from CreateZoneEnumerator and > checked only in GetZoneAt and DestroyZoneEnumerator. > > Windows has only the Zones "0" upto "4" since IE4.0 > and no UI to add or remove a Zone. > Did you test what happens if you add zone registries manually via regedit? Thanks, Jacek

1 0

Appinstall update
by Austin English June 22, 2009

June 22, 2009

Howdy, James has asked me to send y'all an update on my Summer of Code project, Appinstall. I've got a dozen or so app tests committed already, and several more that I'm putting the final touches on. I just finished a wrapper script to make it easy to test daily, and have begun uploading results to http://www.austinenglish.com/logs/. The logs are a bit verbose, so I've committed a fix to make the sha1sum silent on success, which should cut down the noise a lot. To get a quick look, just check summary.txt daily, which will complain if there are any failing tests or 'TODO_FIXED', the equivalent of todo_wine passing (while testing applications I often find bugs, so I've written the tests to automatically check for those bugs and report if they're fixed). The tests should now be run daily on my machine, searching for regressions and bugs that have been fixed. I've also added a couple example test scripts, to make it easier for those unfamiliar with AutoHotKey to write tests for their favorite applications. (http://winezeug.googlecode.com/svn/trunk/appinstall/examples/) Source is available on winezeug: http://code.google.com/p/winezeug/ http://winezeug.googlecode.com/svn/trunk/appinstall/ -- -Austin

1 0

Re: [PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.
by Paul Vriens June 22, 2009

June 22, 2009

Jacek Caban wrote: > --- > dlls/mshtml/dispex.c | 2 ++ > dlls/mshtml/htmllocation.c | 2 +- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/omnavigator.c | 2 +- > dlls/mshtml/tests/dom.c | 36 ++++++++++++++++++++++++++++++------ > 5 files changed, 36 insertions(+), 8 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Thanks for looking into the IE8 test failures. This piece however doesn't look correct: +static void _test_disp2(unsigned line, IUnknown *unk, const IID *diid, const IID *diid2) +{ + IID iid; + + if(_test_get_dispid(line, unk, &iid)) + ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || broken(IsEqualGUID(&iid, diid)), + "unexpected guid %s\n", dbgstr_guid(&iid)); You are comparing twice against diid. -- Cheers, Paul.

2 1

Wine translation statistics sources
by Mikołaj Zalewski June 22, 2009

June 22, 2009

Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my server is a bit broken and I can't run the scripts from cron but have remember to do it manually from a different computer. I have plans to fix it, but in the mean time, as some people may want fresh data, I have finished the changes I've been working on and uploaded the sources. It should be very easy to run them on ones machine and check the tree one has on disk - there is a README with explanations. The archive is available at http://www.mikolaj.zalewski.pl/dl/wine-transl.tgz . It is the latest version that adds support for dumping/diffing dialogs. Mikolaj Zalewski

8 17

Problems with ~/.wine/dosdevices symlinks on samba servers
by Dan Kegel June 22, 2009

June 22, 2009

According to http://groups.google.com/group/Google-Labs-Picasa-for-Linux/browse_thread/t… a user is having trouble because the symlinks in ~/.wine/dosdevices don't work when on a Samba share. It's unfortunate at this late date to realize that one of the key choices Wine made isn't compatible with the cifs/samba combination... but I guess nobody expected home directories to be served with that network filesystem. If this turns out to be a real problem, what are our options? The first thing that comes to mind is to notice the problem and fall back to underscore instead of colon somehow...

2 3

Re: [PATCH 1/4] jscript: Added implementation of Date constructor with more then one argument
by Alexandre Julliard June 22, 2009

June 22, 2009

Piotr Caban <piotr.caban(a)gmail.com> writes: > @@ -221,6 +253,62 @@ static inline DOUBLE week_day(DOUBLE time) > return ret; > } > > +static inline DOUBLE convert_time(int year, SYSTEMTIME st) > +{ > + DOUBLE time; > + int set_week_day; > + > + time = time_from_year(year); > + time += (DOUBLE)day_from_month(st.wMonth-1, in_leap_year(time)) * MS_PER_DAY; > + > + set_week_day = st.wDayOfWeek-week_day(time); > + if(set_week_day < 0) > + set_week_day += 7; > + time += set_week_day * MS_PER_DAY; > + > + time += (DOUBLE)(st.wDay-1) * 7 * MS_PER_DAY; > + if(month_from_time(time) != st.wMonth-1) > + time -= 7 * MS_PER_DAY; > + > + time += st.wHour * MS_PER_HOUR; > + time += st.wMinute * MS_PER_MINUTE; > + > + return time; > +} You should use SystemTimeToFileTime or some similar function, no need to reinvent the wheel. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Test patch
by Austin English June 22, 2009

June 22, 2009

On Sat, Jun 20, 2009 at 9:37 PM, Joshua Reisenauer<kd7tck(a)gmail.com> wrote: > I am sending this test patch to see if I used the correct formatting. I > would like feedback on what the wine dev community likes and doesn't like in > patches. For example do you prefer .txt or .patch? .txt please, much easier to read in browser. Please avoid tabs. Many of the changes you made aren't needed, aren't appropriate. E.g., 'etc.' is right, 'etc...' is not (unless that's a British thing I don't know about). Some of the places you capitalized aren't needed. The 'patch file' listed in the README should be deleted, since it's no longer provided. -- -Austin

2 1

Re: Pavel Procházka's commit
by Stefan Dösinger June 22, 2009

June 22, 2009

Hi, Please send one patch per email. If you have 3 patches, like in this case, please send 3 emails All the patches have trailing whitespaces in some places, and mix tabs and 4-space indentation. Please avoid trailing whitespaces and use 4 spaces for indentation everywhere. In the test: Please define BACKBUFFERCOUNT somewhere close or in TestMultibuffering I recommend to perform one flip, then check the colors, perform another flip and check again. Flipping an arbitrary amount of times and then checking the colors once makes it hard to see what is going on. The 15 flips may also by chance sum up to a no-op or lead to a wrong conclusion. > + if(!StartMultibuffering()) > + { > + skip("An error when initializing multibuffering!, skipping . . . \n"); > + return; > + } I recommend not to skip the D3D tests if the multibuffering test fails to initialize for some reason(ie, remove the return) > +LPDIRECTDRAW lpDD = NULL; The rest of the test uses IDirectDraw *DD instead of LPDIRECTDRAW for COM interfaces The infinite amount of back buffers patch: We currently don't have a test for this, but msdn says that d3d8 and d3d9 have this limit on the amount of backbuffers. If you remove it from wined3d, please add the verification to d3d8.dll and d3d9.dll to make sure they still enforce this limit. Or write a d3d9 test to prove msdn wrong. There is already a test for swapchains in dlls/d3d9/tests/device.c, test_swapchain(). It should be fairly easy to test a too high backbuffer count there. The third patch(_Present relevant to windows implementation Making multibuffering working well when flip): > back = *((IWineD3DSurfaceImpl *)This->backBuffer[0]); /*this value can not be pointer*/ I don't like this, this copies too much data. Please just backup the fields you need > { >- HDC tmp; > - tmp = front->hDC; > - front->hDC = back->hDC; > - back->hDC = tmp; > + front->hDC = back.hDC; > } This will leave this code: { front->hDC = back.hDC; } Since you're not declaring any local variable any longer, please remove the {}

1 0

W-related helper functions for our tests
by Paul Vriens June 22, 2009

June 22, 2009

Hi, I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one compares a W with an A-string. Ideas, remarks, suggestions? -- Cheers, Paul.

4 5

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Hans Leidekker June 21, 2009

June 21, 2009

Hi Dan, > +/* Dummy thread just to initialize an MTA for the benefit of custom action DLLs */ > +static HANDLE dummy_thread_event = NULL; > +static HANDLE dummy_thread_handle = NULL; > + > +DWORD WINAPI dummy_thread_proc(void *arg) It appears that calling CreateThread in DLL_PROCESS_ATTACH can cause deadlocks: http://blogs.msdn.com/mgrier/archive/2005/06/21/431378.aspx It might work if you move it to somewhere near ACTION_CallDllFunction, and wait for the thread to start up, but this remains a hack of course. Another blog explains that inheritance of an existing MTA is just a side effect of starting the custom action in a different process, one that happens to have initialized an MTA already. -Hans

2 2

disabled mail on bouncing bugzilla accounts
by Jan Zerebecki June 21, 2009

June 21, 2009

Thanks to Jeff Zaroyko, who went through the bounce mail, I just disabled sending bug mail to a few bugzilla accounts. Anyone who is affected by this and has fixed his mail reception can ask an bugzilla admin to enable it again (e.g. by mailing me directly). Jan

1 0

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Austin English June 21, 2009

June 21, 2009

On Sat, Jun 20, 2009 at 11:23 PM, Dan Kegel<dank(a)kegel.com> wrote: > This gets Photoshop CS4 installer to start up. > Per the suggestion in > http://bugs.winehq.org/show_bug.cgi?id=18070#c6 > > I am not worthy... +DWORD WINAPI dummy_thread_proc(void *arg) +{ + DWORD dwWaitResult; + + CoInitializeEx(0, COINIT_MULTITHREADED); + + // Just wait forever for DLL to be unloaded. Dan, you of all people should know, no C++ ;-). -- -Austin

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Henri Verbeet June 21, 2009

June 21, 2009

2009/6/20 Gerald Pfeifer <gerald(a)pfeifer.com>: > This makes it more clear that ! applies to the overall condition, > not just to the first part which is then and-ed. > I happened to have the same patch. Note that this does fix a real bug, ! has higher precedence than &.

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Kai Blin June 20, 2009

June 20, 2009

On Saturday 20 June 2009 17:17:53 Gerald Pfeifer wrote: Hi Gerald, not really about this patch in specific, but would you mind sticking to the established practice of prefixing your patches with the area of wine you're affecting? That makes it easier to skim the wine-patches list for the dlls I know and care about. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Fix error checking in dlls/ddraw/executebuffer.c
by Paul Vriens June 20, 2009

June 20, 2009

Gerald Pfeifer wrote: > I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that > the below is the actual intention of this code (to ensure we are > in range). > > Gerald > > ChangeLog: > Fix error checking in IDirect3DExecuteBufferImpl_Execute(). > > diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c > index 73e0657..6d6d304 100644 > --- a/dlls/ddraw/executebuffer.c > +++ b/dlls/ddraw/executebuffer.c > @@ -249,7 +249,7 @@ IDirect3DExecuteBufferImpl_Execute(IDirect3DExecuteBufferImpl *This, > > TRACE("(%08x,%08x)\n", ci->u1.dlstLightStateType, ci->u2.dwArg[0]); > > - if (!ci->u1.dlstLightStateType && (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > + if (!ci->u1.dlstLightStateType || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > ERR("Unexpected Light State Type\n"); Would: if ((ci->u1.dlstLightStateType < D3DLIGHTSTATE_MATERIAL) || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) be easier to read? (Matter of taste I guess). -- Cheers, Paul.

2 1