June 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 5/5] wininet: Test gzip encoded read.
by Paul Vriens June 1, 2009

June 1, 2009

Jacek Caban wrote: > --- > dlls/wininet/tests/http.c | 107 > ++++++++++++++++++++++++++++++++++---------- > 1 files changed, 82 insertions(+), 25 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, This patch introduces test failures on all platforms: 1 failure with IE7 1 new failure with IE8 (there was 1 with IE8 before this patch) 5 failures with IE6 Could you have a look (test.winehq.org)? -- Cheers, Paul.

2 1

Patchwatcher not reporting failures?
by Austin English June 1, 2009

June 1, 2009

Testing patchwatcher with a patch that simply removes two todo_wine's should've caused some failures. Indeed, looking at the log: cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec cred.c:328: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:328: Test failed: expected NULL credentials but got 0x11d4d0 it did. But patchwatcher shows an 'OK'. Can you take a look? -- -Austin

3 2

gdiplus: GdipDrawString
by Stephan Rose June 1, 2009

June 1, 2009

Ok was playing a bit with DrawString on sunday trying to get string alignments to work. I've got horizontal alignments working by simply setting drawcoord.right which currently is left uninitialized and then passing DT_CENTER and DT_RIGHT as needed to DrawTextW. So far, that worked. However, I can't do that for vertical alignments because the code manually does the line breaking and therefore draws each line individually. So my question is, why? Why aren't we letting DrawTextW do the line breaking and just letting it draw with the appropriate rect? Is the linebreaking different? Or does DrawTextW not have the proper support for rotations? As it stands right now, if necessary, I can easily enough calculate the offsets myself for doing horizontal alignments instead of using DT_CENTER and DT_RIGHT. But for vertical, this is a bit problematic. I don't know how many lines of text there are going to be until the text has already been drawn. Kind of a prerequisite for vertical alignment however. That means that if I just want to brute force it, I'd have to duplicate the drawing loop and once only have it measure the string / count lines. That then allows me to calculate the proper offset and I could then just rerun the thing again with the new position and it'd work. A bit more better solution would be to store the line break info in a small array (indices into the string should do that tell me where each line ends) to simply the drawing loop. That would require a dynamic array though which brings me to another question, what should I use? is stuff like std::vector ok or should I use something else? If of course there's a way we can just have DrawTextW handle the line breaking, I don't even need to care about any of the above. Can then just calculate the proper bounding rect and hand all the issues off to DrawTextW. Thoughts? Thanks, Stephan

2 1

Regular users right on bugzilla
by Jerome Leclanche June 1, 2009

June 1, 2009

Since there's been some discussion about bugzilla recently... Is there any reason regular users aren't allowed to change keywords, component and dependencies on bugs they don't own on Bugzilla? Maybe marking as duplicate as well. I don't think it'd do any harm to allow those rights to every registered user. Cheers Jerome -- J. Leclanche / Adys

6 7

Re: [2/3] kernel32: fix QueryFullProcessImageNameW for output buffer being null
by Alexandre Julliard June 1, 2009

June 1, 2009

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -3155,6 +3155,12 @@ > NTSTATUS status; > DWORD needed; > > + if(!lpExeName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > + This is not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so process.c && touch process.ok process.c:1670: Test failed: Expected GetLastError() to be 122 (ERROR_INSUFFICIENT_BUFFER) is 87 make[2]: *** [process.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Its Alive! Patchwatcher is reborn.
by Zachary Goldberg June 1, 2009

June 1, 2009

All, As you may have noticed in the last WWN I have been working on getting patchwatcher back up on a rather nice server whose cpu time is graciously donated by STWing (stwing.org) I've got it running at the moment at http://winepatch.stwing.upenn.edu/results2/ There are still many, many kinks to be worked out before I would use this as reliable and/or before I even think about enabling sending to patch authors. But if you're curious thats where the results are going and will likely be in the future. -Zach p.s. Kudos to Dan Kegel for a great walkthrough in the PW readme.txt, and of course for putting patchwatcher together in the first place!

4 4

Installing ActivePython screws up PATH in Wine?
by Dan Kegel June 1, 2009

June 1, 2009

In Wine, I can happily install mingw and add it to the global PATH by editing the registry key PATH in [System\\CurrentControlSet\\Control\\Session Manager\\Environment] However, once I install ActivePython, something gets screwed up, and from then on, 'PATH' in CMD says PATH="C:\Python26\";;C:\Python26\; even if I remove that bit from that registry key and add other directories. Anyone know what the heck is going on?

2 1

Re: Changing default severity in Bugzilla to Normal
by James Mckenzie May 31, 2009

May 31, 2009

Austin English wrote about Re: Changing default severity in Bugzilla to Normal > >On Thu, May 28, 2009 at 1:40 PM, Ken Sharp <kennybobs(a)o2.co.uk> wrote: >> "It seems the default severity, enhancement, invites people to select a >> REALLY >> SEVERE sounding level instead. I suggest changing the default severity to >> normal in the hopes of cutting down on the yelling." >> http://bugs.winehq.org/show_bug.cgi?id=13363 >> >> Any thoughts on this? >> >> >> > >+1 > +1 James McKenzie

3 2