July 2009 - Wine-Devel - list.winehq.org

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov July 2, 2009

July 2, 2009

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > + if (*pcbProvName > INT_MAX) > + *pcbProvName = INT_MAX; In which way WideCharToMultiByte is broken? It always helps to provide an explanation and if possible a test case. -- Dmitry.

2 1

Re: user32: Add a test for BM_SETSTYLE, make it pass under Wine.
by Paul Vriens July 2, 2009

July 2, 2009

Dmitry Timoshkov wrote: > --- > dlls/user32/button.c | 14 ++++++- > dlls/user32/tests/msg.c | 86 ++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 83 insertions(+), 17 deletions(-) > Hi Dmitry, These new tests introduce some failure on Win98/WinMe. Could you have a look? -- Cheers, Paul.

1 0

Wine64: Down to 68 test failures!
by Austin English July 2, 2009

July 2, 2009

For those of you that don't follow http://test.winehq.org/, AJ and others 64-bit work has brought down the failures to 68: http://test.winehq.org/data/fb0275dd3148a098967f5959adb57ebe41a4383e/index_… Down quite a bit from over 100 about 6 months ago. There's still a lot of work to do, of course. If you've got a 64-bit machine, give your favorite area of the wine tree a try in 64-bit mode and fix some test failures/compiler warnings. -- -Austin

1 0

Re: regedit: Implement open last key at startup [try 3]
by Michael Karcher July 2, 2009

July 2, 2009

Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: > Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key(HWND hwndTV, BOOL bget) This looks to me like the "boolean parameter to change behaviour" antipattern. I think you did it to avoid duplication of the wsz... constants for the registry path and the key name. Make them global variables (still static, so file local), and make two functions out of it. Open the key only for READ access if you want to load. Why do you copy the result of GetItemFullPath? Why don't you free the result of GetItemFullPath? Finally, I think Paul Vriens was wrong on omitting the RegCloseKey. While you really don't have to close predefined keys like HKEY_CURRENT_USER, you do have to close HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. Regards, Michael Karcher

2 2

Re: regedit: Implement open last key at startup [try 2]
by Paul Vriens July 2, 2009

July 2, 2009

Vladimir Pankratov wrote: > Hello. > > Open last key at startup. > > Changed files: > regedit/childwin.c > > Thanks. > > > ------------------------------------------------------------------------ > > Hi Vladimir, Please use a constant instead of hardcoded 260 as suggested by Andre'. You also should be using the RegCreate variant of the function as this key does not yet exist. There is no need for the RegCloseKey as you are opening a predefined one. -- Cheers, Paul.

2 1

Re: Minor fix for include/bits1_5.idl
by Gerald Pfeifer July 2, 2009

July 2, 2009

Strike that, I must have misread the documentation. Only thing I am wondering is do we really need the (unsigned long) here? If anyone has a pointer to clear documentation that would be nice; what I found so far leaves some questions open... Gerald On Sun, 28 Jun 2009, Gerald Pfeifer wrote: > The generated file include/bits1_5.h is the same before and after this > patch, yet somehow the original form strikes me as a bit odd at best... > > Gerald > > > ChangeLog: > Fix prototype for GetReplyData(). > > diff --git a/include/bits1_5.idl b/include/bits1_5.idl > index 274a7de..29520e2 100644 > --- a/include/bits1_5.idl > +++ b/include/bits1_5.idl > @@ -39,7 +39,7 @@ interface IBackgroundCopyJob2 : IBackgroundCopyJob > } BG_JOB_REPLY_PROGRESS; > > HRESULT GetReplyProgress([in, out] BG_JOB_REPLY_PROGRESS *progress); > - HRESULT GetReplyData([out, size_is( , (unsigned long) *pLength)] byte **pBuffer, > + HRESULT GetReplyData([out, size_is((unsigned long) *pLength)] byte **pBuffer, > [in, out, unique] UINT64 *pLength); > HRESULT SetReplyFileName([unique] LPCWSTR filename); > HRESULT GetReplyFileName([out] LPWSTR *pFilename);

2 1

Re: AppDB test results in Spanish
by Susan Cragin July 2, 2009

July 2, 2009

>>> Who feels like translating some test results? >>> >>> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI… >I mean someone actually replace that entry with a translated version. >I could do it via Google Translate, but I'd rather someone who *knows* >Spanish replace it with a REAL translation :) I read Spanish. Here's my take. I got as far as the load menu and one quick race. In "race" mode the videos don't work, and other modes also fail. Many things. All this was configured with Windows Vista settings. That can prove anything. No more to say. (Or, that goes without saying.)

3 2

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Alexandre Julliard July 2, 2009

July 2, 2009

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > Last time I submitted this (pretty trivial) patch, it got ignored. What makes you think this is necessary? Did you test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

AppDB test results in Spanish
by Ben Klein July 2, 2009

July 2, 2009

Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI…

3 3

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Nicolas Le Cam July 2, 2009

July 2, 2009

Le 2 juillet 2009 09:29, Frédéric Delanoy<frederic.delanoy(a)gmail.com> a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

1 0

Re: winex11.drv: Move clipboard handling to a separate thread
by Alexandre Julliard July 2, 2009

July 2, 2009

Yuri Khan <yurivkhan(a)gmail.com> writes: > This patch achieves this by creating an auxiliary thread that will run > in the same process that puts data on the clipboard and handle X > selection messages. That looks quite inefficient, especially since you create a new thread every time. You should limit this to the cases where it's really necessary, using clipboard from command line apps is a very uncommon operation. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by James Mckenzie July 2, 2009

July 2, 2009

> >You probably want a separate code path in shellpath.c for the Mac. I >don't think XDG works there. > Can check, but make sure you do not use ObjC code. AJ will reject. Also pass to me, and I will add/test it. James McKenzie

1 0

Re: [PATCH 5/6] urlmon: Added user agent tests.
by Paul Vriens July 1, 2009

July 1, 2009

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 84 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 82 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, The addition of these new tests led to a Coverity warning (#947) as your using str2 in your tests. str2 is checked for NULL earlier on but only skips a few tests now if it's indeed NULL. The question is, should we just add a return after the skip() or get rid of the whole checking for NULL. (The str2 checking was not added by you btw). -- Cheers, Paul.

2 1

RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by Joerg-Cyril.Hoehle＠t-systems.com July 1, 2009

July 1, 2009

Hi, http://bugs.winehq.org/show_bug.cgi?id=19028 winecfg on Mac OSX (10.5.6 and .7) does not link "My Videos" etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead. What a pity! Mac OSX uses directories named Documents/, Pictures/, Videos/, Music/ -- even in the German locale. The Finder GUI provides localized names. Unlike XDG/Gnome there are no crazy hacks at session begin to rename directories based on the session's locale. I don't know how earlier releases of Mac OSX behave, i.e. whether these directories have always been present. Does anyone know a reference? I located the relevant places that would need a patch: dlls/shell32/shellpath.c:_SHCreateSymbolicLinks and possibly dlls/shell32/xdg.c:XDG_UserDirLookup However, some design issues are unclear to me, hence prevent me from writing a patch: - In what order to add the Mac check? - When to check for a folder named "My Documents" (MS-Windows non-localized name in English locale, possibly translated), and when for "Documents" (MacOS constant name)? - Use XDG on the Mac or not? (if linked in, e.g. possibly when compiled via MacPorts, which pulls in a zillion libraries. Apple does not provide libfreedesktop.) Thanks for your comments, Jörg Höhle

3 2

Re: msctf: fully clear the Variant before setting it.
by Huw Davies July 1, 2009

July 1, 2009

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetValue(ITfCompartment *iface, > if (!pvarValue) > return E_INVALIDARG; > > + memset(pvarValue,0,sizeof(VARIANT)); > pvarValue->n1.n2.vt = VT_EMPTY; > if (!This->variant.n1.n2.vt == VT_EMPTY) > hr = VariantCopy(pvarValue,&This->variant); > This looks wrong; there's something strange going on here. Note also there's VariantInit() which is a cleaner way to set vt to VT_EMPTY. Huw.

1 0

Re: regedit: Open last key at startup
by Alexandre Julliard July 1, 2009

July 1, 2009

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > Hi all. > > Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Alexandre Julliard July 1, 2009

July 1, 2009

Brent Roman <brent(a)mbari.org> writes: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. You reformatted the whole function, don't do that. Also please add a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

regression: loader: Reserve some more memory to cover the native ole32 addresses.
by Markus Amsler July 1, 2009

July 1, 2009

commit 8d833ee2e7a1d8b82e2dccf51e0cbc20742a0833 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 25 14:19:09 2009 +0200 loader: Reserve some more memory to cover the native ole32 addresses. After this commit WoW with mesa/r500 falls back to indirect rendering. libGL tries to mmap 256M for the framebuffer but that fails with > libGL error: drmMap of framebuffer failed (Cannot allocate memory) Markus

1 0

Standard dialogs size & translation
by Frédéric Delanoy July 1, 2009

July 1, 2009

Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying "WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES" However, e.g. in the standard "File Open" dialog, the standard size of some labels (e.g. "File name") is too small for a correct translation, and only the start of the message is shown (which is obviously wrong). I could manage to get correct translated version by modifying "internal" sizes (while keeping the total size of the dialog the same). Does the warning only apply to all localized versions, or just for the English one? What are the potential problems if a dialog is slightly adapted to fit a particular language? Frédéric

2 1

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.
by Paul Vriens July 1, 2009

July 1, 2009

Hans Leidekker wrote: > Passes on win2k3, vista and the win7 release candidate. > Hi Hans, These are the results on Win95: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 864: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1361: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10017: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10082: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20001: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20932: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20949: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 50227: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 50229: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 54936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 win98: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 NT4: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 W2K: mlang.c:2002: Test failed: 855: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 XP: mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 870: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20423: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20880: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20905: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21025: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 28593: expected S_OK, got 0x00000001 Would using IsValidCodePage() be helpful here? -- Cheers, Paul.

3 7

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Paul Vriens July 1, 2009

July 1, 2009

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where windows > would return an HMENU. Specifically, when the relevant windows dwStyle > mask did not include WS_SYSMENU, wine would return nil, but windows > would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. > > After applying the patch, compilations complete without (internal) > errors. It is allow possible to download binaries to > the microcontroller via the TI Flash Emulator Tool under linux > as this hardware appears to the linux kernel 2.6.30 as a serial > port. (Yea!) > > I've been using the app heavily for a couple days now without problems. > In fact, it runs faster and uses much less memory under Wine than > Win4Lin or VMplayer! Very nice. > > I do not subscribe to this list, so please email me directly if you have > any questions or concerns. > > - brent > > mailto:brent(a)mbari.org http://www.mbari.org/~brent > > > > ------------------------------------------------------------------------ > > Hi Brent, No comments on the real content of the patch other than you most likely will need to write one or more testcases to show your patch is correct. Please stick to the indentation and style of the file (surrounding code): - 4 space indentation instead of 2 space - curly brackets on separate lines - there are some tabs in this piece of the code, while you're at it you could change it to use 4 spaces instead. -- Cheers, Paul.

1 0

Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Andrew Eikum July 1, 2009

July 1, 2009

Attached to this email is a rough implementation of the main GDI+ containers functions. It performs correctly in a few simple tests I ran on it, but it's not quite ready to send off to wine-patches. I'd like to get some feedback here, since I'm certain that I'm doing some things wrong. I'm wondering about two things specifically. Since the vast majority of my programming experience has been with object oriented languages, I'm not used to how to do things in C. First, where should the utility functions and variables go? Right now, they're just thrown in above the functions I'm working on. It seems messy to me to have, for example, low and high (which need to be renamed) declared where they are. Do they belong there (or, rather, near the top of graphics.c like some other utility functions), or should they be placed elsewhere? Second, I implemented a simple linked list to manage the stack of GpGraphics objects. I would imagine that there's some standard way of doing stacks, rather than creating a simple one with utility functions as I have here. Can someone point me in the direction of the proper way to do stacks like this in C? Finally, while the code's still rough and needs cleaning up, correctness checking, using Windows types and const properly, etc., am I doing anything glaringly wrong? As I mentioned, it works as expected in the tests I've done, so I can't be too far off the mark :) Thanks for taking a look, Andrew Patch attached. Also available at: http://www.brightnightgames.com/wine/gdipcontainers.patch --- dlls/gdiplus/graphics.c | 125 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 119 insertions(+), 6 deletions(-)

3 2

re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Dan Kegel July 1, 2009

July 1, 2009

Andrew asked: > I would imagine that there's some standard way of doing stacks See http://source.winehq.org/source/include/wine/list.h > Finally, while the code's still rough and needs cleaning up, > correctness checking, using Windows types and const properly, etc., am > I doing anything glaringly wrong? You didn't start by writing conformance tests, perhaps. - Dan

1 0