July 2009 - Wine-Devel - list.winehq.org

Try #2: user32: Windows test request (cursors/icons)
by Daniel Santos July 6, 2009

July 6, 2009

Thanks again for testing this for me, Paul. I have modified the tests so that they should pass and I've skipped tests on win9x that I suspect are causing the blue screens (personally, I doubt it's due to VMware). I moved the new test functions to the top of the file, but I didn't remove the comments. I can shorten them if preferred, but I personally prefer to have functions well documented. So if you or anybody else could test this again for me, I would greatly appreciate it. Thanks! Daniel --- On Fri, 7/3/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: user32: Windows test request (cursors/icons) > To: daniel.santos(a)pobox.com > Cc: wine-devel(a)winehq.org > Date: Friday, July 3, 2009, 3:44 PM > Daniel Santos wrote: > > I don't have access to a working windows machine right > now and would appreciate if somebody can run these tests > against XP, vista and/or 9x. > > > > Thanks! > > Daniel > > > Hi Daniel, > > Tested on XP Professional SP3: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > NT4 Server SP6a: > > cursoricon.c:1363: Test failed: DestroyCursor returned 1, > expected FALSE. > cursoricon.c:1363: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1402 (0x57a). > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: DestroyIcon returned 1, > expected FALSE. > cursoricon.c:1369: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 7 > failures), 0 skipped. > > W2K Professional SP4: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > W2K3 SE SP2: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 554 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > Vista Ultimate - SP2: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 11 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > I get a blue screen on Win95 and Win98 (VMware issue?) !! > > Some remarks on your patch: > > - Please move the new functions to the top so you don't > have to forward declare them. > - The level of comments for the 2 added functions is > something we usually expect for implementations, not for > tests ;) > > -- Cheers, > > Paul. >

2 1

"make test" redux
by Dan Kegel July 6, 2009

July 6, 2009

We've had a test suite for six or so years now, and we keep getting closer to having it pass reliably, but we're still not quite there. I see from http://test.winehq.org that fifteen tests fail on at least one machine. There are several bugs that only cause make test to fail if you run them with WINEDEBUG=warn+heap, but those seem just as important to me. On my own machine, here are the bugs related to make test failures: http://bugs.winehq.org/show_bug.cgi?id=12925 http://bugs.winehq.org/show_bug.cgi?id=14078 http://bugs.winehq.org/show_bug.cgi?id=17414 http://bugs.winehq.org/show_bug.cgi?id=17518 http://bugs.winehq.org/show_bug.cgi?id=19183 I submitted a patch to fix http://bugs.winehq.org/show_bug.cgi?id=17518 but it'd be nice to get some love on the others. - Dan

3 3

Using tracing for tests on Wine
by Paul Vriens July 6, 2009

July 6, 2009

Hi, I've always had a patch in my local repo that runs runtest with the '-v' flag instead if '-q' as I'm not always interested in just the failures. Having '-q' for runtest basically means that I didn't find a way to override things. WINETEST_DEBUG=<number> doesn't work when I do a 'make <test>.ok' as the debug flag will be overwritten by runtest. What would be the best approach here: - Make '-v' the real default like it is on Windows? I've sent a patch for this a long time ago but didn't receive any feedback nor was I too interested in getting that in. (See attached) - If WINETEST_DEBUG is set it will always override the '-q' or '-v' flag for runtest? - Get rid of the '-v' and '-q' altogether in runtest? Other suggestions? -- Cheers, Paul. diff --git a/dlls/Maketest.rules.in b/dlls/Maketest.rules.in index a7095a5..25ff681 100644 --- a/dlls/Maketest.rules.in +++ b/dlls/Maketest.rules.in @@ -15,7 +15,7 @@ DEFS = $(EXTRADEFS) MODULE = $(TESTDLL:%.dll=%)_test.exe TESTRESULTS = $(CTESTS:.c=.ok) TESTPROGRAM = $(MODULE)$(DLLEXT) -RUNTESTFLAGS = -q -P wine -M $(TESTDLL) -T $(TOPOBJDIR) -p $(TESTPROGRAM) +RUNTESTFLAGS = -v -P wine -M $(TESTDLL) -T $(TOPOBJDIR) -p $(TESTPROGRAM) C_SRCS = $(CTESTS) ALL_LIBS = $(IMPORTS:%=-l%) $(EXTRALIBS) $(LDFLAGS) $(LIBS)

1 0

Building problems on Intel Mac.
by Zheng Che July 6, 2009

July 6, 2009

Screenshot attached.

4 3

New winetricks 20090705: new verb shockwave; updated xvid and firefox
by Dan Kegel July 6, 2009

July 6, 2009

Another <insert time period here>, another winetricks. The only interesting change is the addition of shockwave, and maybe the update to firefox 3.5. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL.) Semi-interesting changes since 20090607: ------------------------------------------------------------------------ r546 | daniel.r.kegel | 2009-07-05 18:09:13 -0700 (Sun, 05 Jul 2009) | 3 lines Updated firefox, xvid; added shockwave; bumped version to 20090705 ------------------------------------------------------------------------ r521 | austinenglish | 2009-06-24 16:37:21 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: ignore 194 exit code from ie6 ------------------------------------------------------------------------ r520 | austinenglish | 2009-06-24 15:19:26 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: fix download function's renaming files when using wget ------------------------------------------------------------------------ r519 | austinenglish | 2009-06-24 15:17:34 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: fix DiVX download link

1 0

Re: cryptdlg: Translate "CPS" (Certification Practice Statement) to Lithuanian and add a comment to English resource
by Juan Lang July 6, 2009

July 6, 2009

Hi Aurimas, - IDS_CPS "CPS" + IDS_CPS "SVN" /* Sertifikavimo Veiklos Nuostatos */ I'm not sure this is a good idea. In common usage, acronyms are not translated. In this case, the acronym CPS is part of a standard, RFC2527, so it doesn't seem like a good idea to abbreviate the translated name to a new acronym that isn't anywhere except this dialog. As another example, here's Frédéric Delanoy's recent update of the same string in French (with apologies for the mangled encoding): + IDS_CPS "Ã‰noncÃ© des pratiques de certification (CPS)" That is, the text is translated, but the acronym is not. This seems like a better approach to me. Regards, --Juan

1 0

Re: [1/3] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Vincent Povirk July 5, 2009

July 5, 2009

+ sts = GdipCloneMatrix(container->worldtrans, &newTrans); + if(sts != Ok) + return sts; + + sts = GdipCloneRegion(container->clip, &newClip); + if(sts != Ok) + return sts; This leaks a matrix if GdipCloneRegion fails. -- Vincent Povirk

1 0

Re: server/fd.c: Prevent using uninitialized pointers
by Henri Verbeet July 5, 2009

July 5, 2009

2009/6/30 Daniel Santos <javatroubadour(a)yahoo.com>: > Some pointers are getting used prior to initialization. It would appear that the current compilers are initializing them to zero or we've been lucky. > No, the C standard specifies that these are initialized to NULL, since they have static storage duration.

4 5

Testing modal property sheets
by Nikolay Sivov July 5, 2009

July 5, 2009

Hi. Some time ago I tried to fix bug http://bugs.winehq.org/show_bug.cgi?id=16876 . It's about wrong return codes of PropertySheet call. The question is about a proper way of testing this. I tried to exit just after creation in PSCB_INITIALIZED handler, it looks like it shows a problem, but I'm not sure is it a correct way or not. I'd like to see some advices about that Thanks. rom 56c14340af9ac298bde22cf207fca7c8ae95957c Mon Sep 17 00:00:00 2001 From: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat, 23 May 2009 19:21:08 +0400 Subject: Some propsheet tests --- dlls/comctl32/tests/propsheet.c | 128 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 128 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/tests/propsheet.c b/dlls/comctl32/tests/propsheet.c index 4164f68..37b89fd 100644 --- a/dlls/comctl32/tests/propsheet.c +++ b/dlls/comctl32/tests/propsheet.c @@ -199,9 +199,137 @@ static void test_disableowner(void) DestroyWindow(parent); } +#define PSM_PRESSBUTTON_CALLBACK(id) \ +static int CALLBACK psm_pressbutton_callback_##id (HWND hwnd, UINT msg, LPARAM lparam) \ +{\ + switch(msg)\ + {\ + case PSCB_INITIALIZED:\ + {\ + PostMessage(NULL, PSM_PRESSBUTTON, PSBTN_##id, (LPARAM)0);\ + return FALSE;\ + }\ + }\ + return FALSE;\ +} + +PSM_PRESSBUTTON_CALLBACK(OK) +PSM_PRESSBUTTON_CALLBACK(CANCEL) +PSM_PRESSBUTTON_CALLBACK(APPLYNOW) +PSM_PRESSBUTTON_CALLBACK(BACK) +PSM_PRESSBUTTON_CALLBACK(FINISH) +PSM_PRESSBUTTON_CALLBACK(HELP) +PSM_PRESSBUTTON_CALLBACK(NEXT) + +static void test_singlepressbutton(INT id, INT expected, BOOL modal, BOOL todo, int line) +{ + HPROPSHEETPAGE hpsp[1]; + PROPSHEETPAGEA psp; + PROPSHEETHEADERA psh; + HWND hdlg; + INT ret; + DWORD r; + + memset(&psp, 0, sizeof(psp)); + psp.dwSize = sizeof(psp); + psp.dwFlags = 0; + psp.hInstance = GetModuleHandleW(NULL); + U(psp).pszTemplate = "prop_page1"; + U2(psp).pszIcon = NULL; + psp.pfnDlgProc = NULL; + psp.lParam = 0; + + hpsp[0] = CreatePropertySheetPageA(&psp); + + memset(&psh, 0, sizeof(psh)); + psh.dwSize = sizeof(psh); + psh.pszCaption = "test caption"; + psh.nPages = 1; + U3(psh).phpage = hpsp; + + if (modal) + { + /* modal sheet */ + psh.dwFlags = PSH_USECALLBACK; + psh.hwndParent = NULL; + switch(id) + { + case PSBTN_BACK: + psh.pfnCallback = psm_pressbutton_callback_BACK; + break; + case PSBTN_NEXT: + psh.pfnCallback = psm_pressbutton_callback_NEXT; + break; + case PSBTN_FINISH: + psh.pfnCallback = psm_pressbutton_callback_FINISH; + break; + case PSBTN_OK: + psh.pfnCallback = psm_pressbutton_callback_OK; + break; + case PSBTN_APPLYNOW: + psh.pfnCallback = psm_pressbutton_callback_APPLYNOW; + break; + case PSBTN_CANCEL: + psh.pfnCallback = psm_pressbutton_callback_CANCEL; + break; + case PSBTN_HELP: + psh.pfnCallback = psm_pressbutton_callback_HELP; + break; + } + + ret = PropertySheetA(&psh); + if (todo) + { + todo_wine ok_(__FILE__, line)(ret == expected, "Expected %d result, got %d\n", expected, ret); + } + else + ok_(__FILE__, line)(ret == expected, "Expected %d result, got %d\n", expected, ret); + } + else + { + /* modeless sheet */ + psh.dwFlags = PSH_MODELESS; + psh.hwndParent = GetDesktopWindow(); + + hdlg = (HWND)PropertySheetA(&psh); + ok(IsWindow(hdlg), "Expected dialog handle, got %p\n", hdlg); + + SendMessage(hdlg, PSM_PRESSBUTTON, PSBTN_FINISH, 0); + ok(IsWindow(hdlg), "Expected dialog handle, got %p\n", hdlg); + r = SendMessage(hdlg, PSM_GETRESULT, 0, 0); + if (todo) + { + todo_wine ok_(__FILE__, line)(r == expected, "Expected %d result, got %d\n", expected, r); + } + else + ok_(__FILE__, line)(r == expected, "Expected %d result, got %d\n", expected, r); + + DestroyWindow(hdlg); + } +} + +static void test_psmpressbutton(void) +{ + test_singlepressbutton(PSBTN_BACK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_BACK, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_OK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_OK, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_HELP, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_HELP, IDOK, FALSE, FALSE, __LINE__); +} + START_TEST(propsheet) { test_title(); test_nopage(); test_disableowner(); + test_psmpressbutton(); } -- 1.5.6.5 >From 370b1938ce218b8be93d463267ff23adf33097bd Mon Sep 17 00:00:00 2001 From: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat, 23 May 2009 19:34:54 +0400 Subject: Fix PropertySheet return value for modal sheets --- dlls/comctl32/propsheet.c | 5 +---- dlls/comctl32/tests/propsheet.c | 14 +++++++------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/dlls/comctl32/propsheet.c b/dlls/comctl32/propsheet.c index 44151e4..7d337bd 100644 --- a/dlls/comctl32/propsheet.c +++ b/dlls/comctl32/propsheet.c @@ -1703,7 +1703,7 @@ static BOOL PROPSHEET_Finish(HWND hwndDlg) if (msgResult != 0) return FALSE; - if (psInfo->result == 0) + if (psInfo->result == 0 && psInfo->isModeless) psInfo->result = IDOK; if (psInfo->isModeless) psInfo->activeValid = FALSE; @@ -2742,10 +2742,7 @@ static INT do_loop(const PropSheetInfo *psInfo) } if(ret == 0) - { PostQuitMessage(msg.wParam); - ret = -1; - } if(ret != -1) ret = psInfo->result; diff --git a/dlls/comctl32/tests/propsheet.c b/dlls/comctl32/tests/propsheet.c index 37b89fd..b7a97cd 100644 --- a/dlls/comctl32/tests/propsheet.c +++ b/dlls/comctl32/tests/propsheet.c @@ -310,19 +310,19 @@ static void test_singlepressbutton(INT id, INT expected, BOOL modal, BOOL todo, static void test_psmpressbutton(void) { - test_singlepressbutton(PSBTN_BACK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_BACK, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_BACK, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_NEXT, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_NEXT, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_FINISH, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_FINISH, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_OK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_OK, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_OK, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_CANCEL, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_APPLYNOW, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_HELP, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_HELP, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_HELP, IDOK, FALSE, FALSE, __LINE__); } -- 1.5.6.5

1 0

Re: [cryptui] Show the select store text when browsing stores
by Aurimas Fišeras July 5, 2009

July 5, 2009

On 07/05/2009 04:08 PM, Paul Vriens wrote: > Hi, > > We at least see the text now. Selecting is possible but doesn't work > (regression?). > > Changelog > Show the select store text when browsing stores > > > ------------------------------------------------------------------------ > > > + selectInfo.pwszText = LoadStringW(hInstance, IDC_STORE_TEXT, > + storeText, sizeof(storeText) / sizeof(storeText[0])); LoadStringW returns int, not string! LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) / sizeof(storeText[0])); selectInfo.pwszText = storeText;

2 3

AcceptEx Proposal
by Mike Kaplinskiy July 5, 2009

July 5, 2009

I have been thinking about the correct way to implement AcceptEx, and I was looking for comments about the approach. Note I know all of these cases will require tests, I'm just listing them for problems someone might see. Wineserver changes: - add an async* to the socket structure to track this socket's request on the listening socket's queue. (set = null on accept) - Can anything do anything wrong while trying to remove the async when the accepting socket is closed before the accept event is received? (removing another socket's async request) - When/how should we handle setting this (create a new request type (that queues & sets), create a new request type (that just sets) or somehow splice into sock_queue_async? - my vote for first, as much as I hate it) - change accept_socket to use two sockets instead of returning the accepted socket - Problem: we have to destroy the fd of the old socket. Can anything queue async reads/writes before the overlapped acceptex returns? Do we care that the fd of a socket object gets switched (you lose internal state, but I don't think you can have a lot of state on an unbound socket) - Deferred sockets are a pain: 2 clients attempt to connect->accept->defer->acceptex=which socket does it return? Also if this order happens, and we have to destroy the fd as above, would the application possibly care? - need to implement SO_UPDATE_ACCEPT_CONTEXT and have accept() call it right after getting an accept. - if we close the listener socket, what happens to sockets waiting for clients on the accepting socket? Can we reuse these sockets? ws2 changes: - exactly the same as the previous attempt, just using the above requests - more strict checks are needed on the second acceptex socket (need to check family, bound state) - accept: a = create_socket(), accept_socket(listener, a), ioctl)SO_UPDATE_ACCEPT_CONTEXT, a, &listener); I just started looking at wineserver, so don't be surprised if something above doesn't make sense. Mike.

2 2

Howto put a new rpm package on sourceforge ?
by marco July 5, 2009

July 5, 2009

Hi all, I make the mandriva packages and put them on sourceforge. But sourceforge changed there layout and now I can not longer find the button to add new releases or to manage them? Anyone know where they are ? The sourgeforge wiki is taking about a admin button on the summary page, but it is not visible when I log in. Can someone help me ? kind regards, Marco Meijer

3 4

16-bit Code on MacOSX Leopard/XCode 3.1
by James McKenzie July 5, 2009

July 5, 2009

I know that this was disabled, but what happens when I try to run a 16 bit app? Here is what happened when I tried to build 1.1.25 with XCode 3.1 today: checking whether 16-bit code can be built correctly... no configure: error: Xcode 3.x cannot build 16-bit code correctly. Use --disable-win16 if you don't need 16-bit support. ***** Error: Can't build wine Great catch, BTW. James McKenzie

3 3

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by James McKenzie July 4, 2009

July 4, 2009

Christoph von Wittich wrote: As Dmitry wrote about this, I will add the comment that this does not look like the proper way to fix this problem. The proper way is to keep the pointer from overflowing in the first place and that would be to place a check where it is set and updated to either go negative (which should not be allowed) or to be incremented past INT_MAX. This can be implemented in several different ways, and since I have not looked at the code, I could not make a proper suggestion but would suggest that the pointer be checked before incrementing and after setting. James McKenzie

1 0

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by James McKenzie July 4, 2009

July 4, 2009

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where > windows would return an HMENU. Specifically, when the relevant > windows dwStyle mask did not include WS_SYSMENU, wine would return > nil, but windows would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. You rewrote the entire function, there is no need to do this. Please use the same formatting as the rest of the code. Add new variables to the bottom of the list, you imbedded one or more. Since the rest of the function uses four spaces, use them. Avoid the use of tabs, some editors spread them to four spaces, some two and yet others eight. Makes the code look sloppy and is very hard to read. Can you provide test cases, other than 'use this program to prove it works'? The idea is to replicate Windows API functionality and some programs rely on certain functionality working in a very specific manner. If you build to the program, you might break others. Also, if you have left out some function, please insert c style notes stating this. Makes it easier to find where certain code pieces go at a later time. James McKenzie

1 0

A tiny GetSystemMetrics question
by Nikolay Sivov July 4, 2009

July 4, 2009

Hi. Trying to fix some ListView bugs I've found that on native (XP SP2) system this call: --- GetSystemMetrics(SM_CXICONSPACING) --- doesn't return the value specified in appearance -> advanced settings of Display properties sheet. I've got 75 value for both cx and cy while I have set it to 43 in dialog box. This look weird for me. Does anybody know what is the reason of this behavior? P.S. Yes, I'm using default 96 dpi on this XP box (if it does matter).

2 2

Re: [PATCH 3/5] d3d9/tests: Add a small test for having multiple device active at the same time.
by Paul Vriens July 3, 2009

July 3, 2009

Henri Verbeet wrote: > This is essentially the situation that caused problems with reusing the > initial GL context. > --- > dlls/d3d9/tests/device.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 65 insertions(+), 0 deletions(-) > Hi Henri, > + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd1, > + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device1); > + ok(SUCCEEDED(hr), "Failed to create a device, hr %#x\n", hr); This one seems to fail on a lot of boxes, currently only VMware and ATI so it seems. NVIDIA and Intel seem to be fine though (for now as only a few tests are in). Is D3DERR_NOTAVAILABLE an acceptable error? If so than the ok() message can be easily extended (maybe with an extra skip() message?). Could you have a look? -- Cheers, Paul.

2 1

user32: Windows test request (cursors/icons)
by Daniel Santos July 3, 2009

July 3, 2009

I don't have access to a working windows machine right now and would appreciate if somebody can run these tests against XP, vista and/or 9x. Thanks! Daniel

2 1

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Nikolay Sivov July 3, 2009

July 3, 2009

Andrew Eikum wrote: > --- > dlls/gdiplus/gdiplus_private.h | 3 + > dlls/gdiplus/graphics.c | 154 ++++++++++++++++++++++++++++++++++++++-- > include/gdiplusflat.h | 1 + > 3 files changed, 152 insertions(+), 6 deletions(-) > This looks wrong for me cause I don't think you could pass container id created with one Graphics to Graphics.EndContainer() of another. I've just checked it and it doesn't return any error code, but generated container ids aren't the same when you call BeginContainer() for e.g. two objects as sequent steps. It looks like on native these value are module unique, some kind of handle table needed. This kills the first problem I described - passing strange value to another Graphics. Also note that Save()/Restore() functionality uses the same stack with container calls (at least msdn tells us that), for that Save/Restore we already have a test: --- static void test_save_restore(void) .... /* The same state value should never be returned twice. */ todo_wine check_no_duplicates(state_log); .... --- It clearly says that no duplicates allowed, even after multiple object deletion - it checks for values returned during the whole test.

3 7

Re: kernel32: Compile .mc files to resources as independent files.
by Paul Vriens July 3, 2009

July 3, 2009

Hi, kernel32 translations don't show up at the translation page anymore. Do we need to teach wrc to deal with rc files being one level lower (nls directory?) or what is needed to correct this? (Before this patch the page basically showed if there was a translation or not and not whether the content was correct) -- Cheers, Paul.

2 1

Patch feedback (GetProductInfo)
by Alexander Nicolaysen Sørnes July 3, 2009

July 3, 2009

Hello, Could someone give me a hint as to what is wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html They only adds some defines plus a stub, so hopefully there isn't that much I can have done wrong :) Alexander N. Sørnes

2 2

Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.
by Paul Vriens July 3, 2009

July 3, 2009

Rein Klazes wrote: > fixes bug #19079 > > The application of this bug report subclasses the window proc of the file > dialog. It does not return the result in the DWLP_MSGRESULT dialog > property but the return code of the window proc. Tests are provided to > show correct behaviour in all cases, subclassed or not. > --- > dlls/comdlg32/filedlg.c | 8 ++-- > dlls/comdlg32/tests/filedlg.c | 112 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 116 insertions(+), 4 deletions(-) > Hi Rein, This one introduced extra test failures on Vista. On 1 Vista box and W2K8 the test times out (crashes?). Could you have a look. -- Cheers, Paul.

2 2

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Vincent Povirk July 3, 2009

July 3, 2009

>+static GpStatus init_container(GraphicsContainerItem** container, >+ GDIPCONST GpGraphics* graphics){ >+ GpStatus sts; >+ >+ if(!container || !graphics) >+ return InvalidParameter; Since this is an internal function and you know container and graphics will always be non-NULL when you call it, you don't need to make this check. >+ sts = GdipDeleteMatrix(graphics->worldtrans); >+ if(sts != Ok) >+ return sts; >+ >+ sts = GdipCloneMatrix(container->worldtrans, &graphics->worldtrans); >+ if(sts != Ok) >+ return sts; If the delete succeeds but the clone fails, you'll have a Graphics with a deleted world transform. You should allocate the objects you need before freeing those attached to the Graphics. I think that in this case you could get away with copying pointers rather than creating new objects, and you can assume the delete functions succeed. Since the container is about to be destroyed, you would need to make sure the attached matrix and region are not destroyed with it. >+ /* did not find a matching container */ >+ if(&container->entry == &graphics->containers) >+ return Ok; That's a little strange, even though the test shows it's not an error. Personally, I would throw in a WARN for this case. I assume you meant to mark this as [1/2] and the test as [2/2]. This looks good to me. It's almost at the point where I can't predict whether it will be accepted (as opposed to being sure it won't), but Alexandre nailed me once for doing a similar "delete before allocating the replacement" thing. So I assume he cares about that. -- Vincent Povirk

1 0

Re: [1/2] gdiplus/tests: Test cases for GdipBeginContainer2
by Vincent Povirk July 3, 2009

July 3, 2009

+ GdipGetClipBounds(graphics, &clip); + win_skip(/*fabs(defClip[0] - clip.X) < 0.0001 && + fabs(defClip[1] - clip.Y) < 0.0001 && + fabs(defClip[2] - clip.Width) < 0.0001 && + fabs(defClip[3] - clip.Height) < 0.0001,*/ + "Expected Clipping Rectangle to be restored to [%f, %f, %f, %f], got [%f, %f, %f, %f]\n", + defClip[0], defClip[1], defClip[2], defClip[3], + clip.X, clip.Y, clip.Width, clip.Height); Unconditional win_skip (or skip) does not make sense. skip indicates that some tests have been skipped, but this is not the case here. If that fails on Windows, you should fix it. -- Vincent Povirk

1 0

Appdb flight simulation sub category
by Keith Muir July 2, 2009

July 2, 2009

Hi, Any chance of a games> simulation> flight simulation sub category? Regards, Keith

4 4

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov July 2, 2009

July 2, 2009

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > + if (*pcbProvName > INT_MAX) > + *pcbProvName = INT_MAX; In which way WideCharToMultiByte is broken? It always helps to provide an explanation and if possible a test case. -- Dmitry.

2 1

Re: user32: Add a test for BM_SETSTYLE, make it pass under Wine.
by Paul Vriens July 2, 2009

July 2, 2009

Dmitry Timoshkov wrote: > --- > dlls/user32/button.c | 14 ++++++- > dlls/user32/tests/msg.c | 86 ++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 83 insertions(+), 17 deletions(-) > Hi Dmitry, These new tests introduce some failure on Win98/WinMe. Could you have a look? -- Cheers, Paul.

1 0

Wine64: Down to 68 test failures!
by Austin English July 2, 2009

July 2, 2009

For those of you that don't follow http://test.winehq.org/, AJ and others 64-bit work has brought down the failures to 68: http://test.winehq.org/data/fb0275dd3148a098967f5959adb57ebe41a4383e/index_… Down quite a bit from over 100 about 6 months ago. There's still a lot of work to do, of course. If you've got a 64-bit machine, give your favorite area of the wine tree a try in 64-bit mode and fix some test failures/compiler warnings. -- -Austin

1 0

Re: regedit: Implement open last key at startup [try 3]
by Michael Karcher July 2, 2009

July 2, 2009

Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: > Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key(HWND hwndTV, BOOL bget) This looks to me like the "boolean parameter to change behaviour" antipattern. I think you did it to avoid duplication of the wsz... constants for the registry path and the key name. Make them global variables (still static, so file local), and make two functions out of it. Open the key only for READ access if you want to load. Why do you copy the result of GetItemFullPath? Why don't you free the result of GetItemFullPath? Finally, I think Paul Vriens was wrong on omitting the RegCloseKey. While you really don't have to close predefined keys like HKEY_CURRENT_USER, you do have to close HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. Regards, Michael Karcher

2 2

Re: regedit: Implement open last key at startup [try 2]
by Paul Vriens July 2, 2009

July 2, 2009

Vladimir Pankratov wrote: > Hello. > > Open last key at startup. > > Changed files: > regedit/childwin.c > > Thanks. > > > ------------------------------------------------------------------------ > > Hi Vladimir, Please use a constant instead of hardcoded 260 as suggested by Andre'. You also should be using the RegCreate variant of the function as this key does not yet exist. There is no need for the RegCloseKey as you are opening a predefined one. -- Cheers, Paul.

2 1

Re: Minor fix for include/bits1_5.idl
by Gerald Pfeifer July 2, 2009

July 2, 2009

Strike that, I must have misread the documentation. Only thing I am wondering is do we really need the (unsigned long) here? If anyone has a pointer to clear documentation that would be nice; what I found so far leaves some questions open... Gerald On Sun, 28 Jun 2009, Gerald Pfeifer wrote: > The generated file include/bits1_5.h is the same before and after this > patch, yet somehow the original form strikes me as a bit odd at best... > > Gerald > > > ChangeLog: > Fix prototype for GetReplyData(). > > diff --git a/include/bits1_5.idl b/include/bits1_5.idl > index 274a7de..29520e2 100644 > --- a/include/bits1_5.idl > +++ b/include/bits1_5.idl > @@ -39,7 +39,7 @@ interface IBackgroundCopyJob2 : IBackgroundCopyJob > } BG_JOB_REPLY_PROGRESS; > > HRESULT GetReplyProgress([in, out] BG_JOB_REPLY_PROGRESS *progress); > - HRESULT GetReplyData([out, size_is( , (unsigned long) *pLength)] byte **pBuffer, > + HRESULT GetReplyData([out, size_is((unsigned long) *pLength)] byte **pBuffer, > [in, out, unique] UINT64 *pLength); > HRESULT SetReplyFileName([unique] LPCWSTR filename); > HRESULT GetReplyFileName([out] LPWSTR *pFilename);

2 1

Re: AppDB test results in Spanish
by Susan Cragin July 2, 2009

July 2, 2009

>>> Who feels like translating some test results? >>> >>> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI… >I mean someone actually replace that entry with a translated version. >I could do it via Google Translate, but I'd rather someone who *knows* >Spanish replace it with a REAL translation :) I read Spanish. Here's my take. I got as far as the load menu and one quick race. In "race" mode the videos don't work, and other modes also fail. Many things. All this was configured with Windows Vista settings. That can prove anything. No more to say. (Or, that goes without saying.)

3 2

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Alexandre Julliard July 2, 2009

July 2, 2009

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > Last time I submitted this (pretty trivial) patch, it got ignored. What makes you think this is necessary? Did you test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

AppDB test results in Spanish
by Ben Klein July 2, 2009

July 2, 2009

Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI…

3 3

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Nicolas Le Cam July 2, 2009

July 2, 2009

Le 2 juillet 2009 09:29, Frédéric Delanoy<frederic.delanoy(a)gmail.com> a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

1 0

Re: winex11.drv: Move clipboard handling to a separate thread
by Alexandre Julliard July 2, 2009

July 2, 2009

Yuri Khan <yurivkhan(a)gmail.com> writes: > This patch achieves this by creating an auxiliary thread that will run > in the same process that puts data on the clipboard and handle X > selection messages. That looks quite inefficient, especially since you create a new thread every time. You should limit this to the cases where it's really necessary, using clipboard from command line apps is a very uncommon operation. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by James Mckenzie July 2, 2009

July 2, 2009

> >You probably want a separate code path in shellpath.c for the Mac. I >don't think XDG works there. > Can check, but make sure you do not use ObjC code. AJ will reject. Also pass to me, and I will add/test it. James McKenzie

1 0

Re: [PATCH 5/6] urlmon: Added user agent tests.
by Paul Vriens July 1, 2009

July 1, 2009

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 84 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 82 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, The addition of these new tests led to a Coverity warning (#947) as your using str2 in your tests. str2 is checked for NULL earlier on but only skips a few tests now if it's indeed NULL. The question is, should we just add a return after the skip() or get rid of the whole checking for NULL. (The str2 checking was not added by you btw). -- Cheers, Paul.

2 1

RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by Joerg-Cyril.Hoehle＠t-systems.com July 1, 2009

July 1, 2009

Hi, http://bugs.winehq.org/show_bug.cgi?id=19028 winecfg on Mac OSX (10.5.6 and .7) does not link "My Videos" etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead. What a pity! Mac OSX uses directories named Documents/, Pictures/, Videos/, Music/ -- even in the German locale. The Finder GUI provides localized names. Unlike XDG/Gnome there are no crazy hacks at session begin to rename directories based on the session's locale. I don't know how earlier releases of Mac OSX behave, i.e. whether these directories have always been present. Does anyone know a reference? I located the relevant places that would need a patch: dlls/shell32/shellpath.c:_SHCreateSymbolicLinks and possibly dlls/shell32/xdg.c:XDG_UserDirLookup However, some design issues are unclear to me, hence prevent me from writing a patch: - In what order to add the Mac check? - When to check for a folder named "My Documents" (MS-Windows non-localized name in English locale, possibly translated), and when for "Documents" (MacOS constant name)? - Use XDG on the Mac or not? (if linked in, e.g. possibly when compiled via MacPorts, which pulls in a zillion libraries. Apple does not provide libfreedesktop.) Thanks for your comments, Jörg Höhle

3 2

Re: msctf: fully clear the Variant before setting it.
by Huw Davies July 1, 2009

July 1, 2009

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetValue(ITfCompartment *iface, > if (!pvarValue) > return E_INVALIDARG; > > + memset(pvarValue,0,sizeof(VARIANT)); > pvarValue->n1.n2.vt = VT_EMPTY; > if (!This->variant.n1.n2.vt == VT_EMPTY) > hr = VariantCopy(pvarValue,&This->variant); > This looks wrong; there's something strange going on here. Note also there's VariantInit() which is a cleaner way to set vt to VT_EMPTY. Huw.

1 0

Re: regedit: Open last key at startup
by Alexandre Julliard July 1, 2009

July 1, 2009

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > Hi all. > > Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Alexandre Julliard July 1, 2009

July 1, 2009

Brent Roman <brent(a)mbari.org> writes: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. You reformatted the whole function, don't do that. Also please add a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

regression: loader: Reserve some more memory to cover the native ole32 addresses.
by Markus Amsler July 1, 2009

July 1, 2009

commit 8d833ee2e7a1d8b82e2dccf51e0cbc20742a0833 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 25 14:19:09 2009 +0200 loader: Reserve some more memory to cover the native ole32 addresses. After this commit WoW with mesa/r500 falls back to indirect rendering. libGL tries to mmap 256M for the framebuffer but that fails with > libGL error: drmMap of framebuffer failed (Cannot allocate memory) Markus

1 0

Standard dialogs size & translation
by Frédéric Delanoy July 1, 2009

July 1, 2009

Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying "WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES" However, e.g. in the standard "File Open" dialog, the standard size of some labels (e.g. "File name") is too small for a correct translation, and only the start of the message is shown (which is obviously wrong). I could manage to get correct translated version by modifying "internal" sizes (while keeping the total size of the dialog the same). Does the warning only apply to all localized versions, or just for the English one? What are the potential problems if a dialog is slightly adapted to fit a particular language? Frédéric

2 1

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.
by Paul Vriens July 1, 2009

July 1, 2009

Hans Leidekker wrote: > Passes on win2k3, vista and the win7 release candidate. > Hi Hans, These are the results on Win95: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 864: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1361: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10017: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10082: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20001: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20932: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20949: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 50227: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 50229: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 54936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 win98: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 NT4: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 W2K: mlang.c:2002: Test failed: 855: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 XP: mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 870: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20423: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20880: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20905: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21025: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 28593: expected S_OK, got 0x00000001 Would using IsValidCodePage() be helpful here? -- Cheers, Paul.

3 7

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Paul Vriens July 1, 2009

July 1, 2009

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where windows > would return an HMENU. Specifically, when the relevant windows dwStyle > mask did not include WS_SYSMENU, wine would return nil, but windows > would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. > > After applying the patch, compilations complete without (internal) > errors. It is allow possible to download binaries to > the microcontroller via the TI Flash Emulator Tool under linux > as this hardware appears to the linux kernel 2.6.30 as a serial > port. (Yea!) > > I've been using the app heavily for a couple days now without problems. > In fact, it runs faster and uses much less memory under Wine than > Win4Lin or VMplayer! Very nice. > > I do not subscribe to this list, so please email me directly if you have > any questions or concerns. > > - brent > > mailto:brent(a)mbari.org http://www.mbari.org/~brent > > > > ------------------------------------------------------------------------ > > Hi Brent, No comments on the real content of the patch other than you most likely will need to write one or more testcases to show your patch is correct. Please stick to the indentation and style of the file (surrounding code): - 4 space indentation instead of 2 space - curly brackets on separate lines - there are some tabs in this piece of the code, while you're at it you could change it to use 4 spaces instead. -- Cheers, Paul.

1 0

Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Andrew Eikum July 1, 2009

July 1, 2009

Attached to this email is a rough implementation of the main GDI+ containers functions. It performs correctly in a few simple tests I ran on it, but it's not quite ready to send off to wine-patches. I'd like to get some feedback here, since I'm certain that I'm doing some things wrong. I'm wondering about two things specifically. Since the vast majority of my programming experience has been with object oriented languages, I'm not used to how to do things in C. First, where should the utility functions and variables go? Right now, they're just thrown in above the functions I'm working on. It seems messy to me to have, for example, low and high (which need to be renamed) declared where they are. Do they belong there (or, rather, near the top of graphics.c like some other utility functions), or should they be placed elsewhere? Second, I implemented a simple linked list to manage the stack of GpGraphics objects. I would imagine that there's some standard way of doing stacks, rather than creating a simple one with utility functions as I have here. Can someone point me in the direction of the proper way to do stacks like this in C? Finally, while the code's still rough and needs cleaning up, correctness checking, using Windows types and const properly, etc., am I doing anything glaringly wrong? As I mentioned, it works as expected in the tests I've done, so I can't be too far off the mark :) Thanks for taking a look, Andrew Patch attached. Also available at: http://www.brightnightgames.com/wine/gdipcontainers.patch --- dlls/gdiplus/graphics.c | 125 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 119 insertions(+), 6 deletions(-)

3 2

re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Dan Kegel July 1, 2009

July 1, 2009

Andrew asked: > I would imagine that there's some standard way of doing stacks See http://source.winehq.org/source/include/wine/list.h > Finally, while the code's still rough and needs cleaning up, > correctness checking, using Windows types and const properly, etc., am > I doing anything glaringly wrong? You didn't start by writing conformance tests, perhaps. - Dan

1 0