July 2009 - Wine-Devel - list.winehq.org

Re: regedit: Open last key at startup
by Alexandre Julliard July 1, 2009

July 1, 2009

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > Hi all. > > Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Alexandre Julliard July 1, 2009

July 1, 2009

Brent Roman <brent(a)mbari.org> writes: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. You reformatted the whole function, don't do that. Also please add a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

regression: loader: Reserve some more memory to cover the native ole32 addresses.
by Markus Amsler July 1, 2009

July 1, 2009

commit 8d833ee2e7a1d8b82e2dccf51e0cbc20742a0833 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 25 14:19:09 2009 +0200 loader: Reserve some more memory to cover the native ole32 addresses. After this commit WoW with mesa/r500 falls back to indirect rendering. libGL tries to mmap 256M for the framebuffer but that fails with > libGL error: drmMap of framebuffer failed (Cannot allocate memory) Markus

1 0

Standard dialogs size & translation
by Frédéric Delanoy July 1, 2009

July 1, 2009

Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying "WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES" However, e.g. in the standard "File Open" dialog, the standard size of some labels (e.g. "File name") is too small for a correct translation, and only the start of the message is shown (which is obviously wrong). I could manage to get correct translated version by modifying "internal" sizes (while keeping the total size of the dialog the same). Does the warning only apply to all localized versions, or just for the English one? What are the potential problems if a dialog is slightly adapted to fit a particular language? Frédéric

2 1

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.
by Paul Vriens July 1, 2009

July 1, 2009

Hans Leidekker wrote: > Passes on win2k3, vista and the win7 release candidate. > Hi Hans, These are the results on Win95: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 864: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1361: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10017: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10082: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20001: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20932: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20949: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 50227: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 50229: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 54936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 win98: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 NT4: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 W2K: mlang.c:2002: Test failed: 855: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 XP: mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 870: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20423: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20880: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20905: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21025: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 28593: expected S_OK, got 0x00000001 Would using IsValidCodePage() be helpful here? -- Cheers, Paul.

3 7

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Paul Vriens July 1, 2009

July 1, 2009

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where windows > would return an HMENU. Specifically, when the relevant windows dwStyle > mask did not include WS_SYSMENU, wine would return nil, but windows > would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. > > After applying the patch, compilations complete without (internal) > errors. It is allow possible to download binaries to > the microcontroller via the TI Flash Emulator Tool under linux > as this hardware appears to the linux kernel 2.6.30 as a serial > port. (Yea!) > > I've been using the app heavily for a couple days now without problems. > In fact, it runs faster and uses much less memory under Wine than > Win4Lin or VMplayer! Very nice. > > I do not subscribe to this list, so please email me directly if you have > any questions or concerns. > > - brent > > mailto:brent(a)mbari.org http://www.mbari.org/~brent > > > > ------------------------------------------------------------------------ > > Hi Brent, No comments on the real content of the patch other than you most likely will need to write one or more testcases to show your patch is correct. Please stick to the indentation and style of the file (surrounding code): - 4 space indentation instead of 2 space - curly brackets on separate lines - there are some tabs in this piece of the code, while you're at it you could change it to use 4 spaces instead. -- Cheers, Paul.

1 0

Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Andrew Eikum July 1, 2009

July 1, 2009

Attached to this email is a rough implementation of the main GDI+ containers functions. It performs correctly in a few simple tests I ran on it, but it's not quite ready to send off to wine-patches. I'd like to get some feedback here, since I'm certain that I'm doing some things wrong. I'm wondering about two things specifically. Since the vast majority of my programming experience has been with object oriented languages, I'm not used to how to do things in C. First, where should the utility functions and variables go? Right now, they're just thrown in above the functions I'm working on. It seems messy to me to have, for example, low and high (which need to be renamed) declared where they are. Do they belong there (or, rather, near the top of graphics.c like some other utility functions), or should they be placed elsewhere? Second, I implemented a simple linked list to manage the stack of GpGraphics objects. I would imagine that there's some standard way of doing stacks, rather than creating a simple one with utility functions as I have here. Can someone point me in the direction of the proper way to do stacks like this in C? Finally, while the code's still rough and needs cleaning up, correctness checking, using Windows types and const properly, etc., am I doing anything glaringly wrong? As I mentioned, it works as expected in the tests I've done, so I can't be too far off the mark :) Thanks for taking a look, Andrew Patch attached. Also available at: http://www.brightnightgames.com/wine/gdipcontainers.patch --- dlls/gdiplus/graphics.c | 125 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 119 insertions(+), 6 deletions(-)

3 2

re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Dan Kegel June 30, 2009

June 30, 2009

Andrew asked: > I would imagine that there's some standard way of doing stacks See http://source.winehq.org/source/include/wine/list.h > Finally, while the code's still rough and needs cleaning up, > correctness checking, using Windows types and const properly, etc., am > I doing anything glaringly wrong? You didn't start by writing conformance tests, perhaps. - Dan

1 0