August 2009 - Wine-Devel - list.winehq.org

Missing libxml2 -> msxml3 compilation error
by Francois Gouget Aug. 31, 2009

Aug. 31, 2009

It turns out I was missing libxml2 in one of my environments and this lead to the following compilation error: $ gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -g -O2 -o dispex.o dispex.c dispex.c:49: field `tid' has incomplete type dispex.c:76: `LAST_tid' undeclared here (not in a function) dispex.c:115: parameter `tid' has incomplete type ... The problem is that tid_t is defined by msxml_private.h in a section enclosed in an #ifdef HAVE_LIBXML2. But it's then used in dispex.c regardless of HAVE_LIBXML2. So should tid_t always be defined or should the relevant portions of dispex.c be enclosed in an #ifdef HAVE_LIBXML2? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: RFC: Fixing kernel32:locale tests on Vista and higher
by Greg Geldorp Aug. 30, 2009

Aug. 30, 2009

From: Reece Dunn > Does anyone understand what these are doing and (in a general sense) > what the changes to Vista are? When you specify the MAP_FOLDCZONE flag, FoldStringW() on Vista will try to return a "simple" presentation for the Unicode characters. For example, if you pass in 0x01c7 ("LATIN CAPITAL LETTER LJ", L and J combined into a single Unicode character, see http://www.fileformat.info/info/unicode/char/01c7/index.htm) then FoldStringW() will return two characters: the letter L (0x004c) and the letter J (0x004a). Versions prior to Vista simply returned the exact same code that you passed in for all codes < 0xf900. Flag MAP_EXPAND_LIGATURES does something similar for ligatures. > I suppose the main questions to ask are: > 1/ are there applications that depend on the pre-Vista locale rules? > 2/ are the Linux/*BSD/Mac/OpenSolaris (or glibc, uLibc, ...) locale > rules *compatible* with Windows? > > I haven't seen anything on the locale changes for Vista breaking > anything except the Wine tests. As a result, it should (in theory) be > possible to use the native version. This would then remove the need > for Wine to copy the Microsoft locale tables. Right. But that wouldn't fix the current tests. Ge.

1 0

Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt Aug. 30, 2009

Aug. 30, 2009

This is the result of running cppcheck 1.35 with the --all parm against the august 27th Git tree: [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of bounds [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of bounds [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of character ({). Can't process file. [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer overrun [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun [../wine-git/server/file.c:235]: (possible error) Buffer overrun [../wine-git/tools/fnt2bdf.c:656]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:303]: (error) Memory leak: file_lens [../wine-git/tools/makedep.c:337]: (error) Resource leak: file [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map Chris

7 7

re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation
by Dan Kegel Aug. 30, 2009

Aug. 30, 2009

It'd be cool if you mentioned what this patch series does for users. Does it fix some app that's broken? You probably need to include conformance tests for the new functions you implement. You may find that the maintainer is very picky about changes to wineserver. Don't be discouraged if your patch series isn't accepted at first, just keep improving it, addressing the issues people raise, and resubmitting.

1 0

Re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation
by Mike Kaplinskiy Aug. 29, 2009

Aug. 29, 2009

On Sat, Aug 29, 2009 at 1:51 AM, shanmukha sainath addepalli<sainath.addepalli(a)gmail.com> wrote: > > Hi, > > These are the series of patches for SwitchDesktop and > OpenInputDesktop API implementation in user32.dll > > SwitchDesktop API when called switches to another desktop and makes > it active. > > First patch is the implementation of SwitchDesktop API in > user32/win.c.This function calls the Declaration handler for the > switchdesktop. > > Change Log: Implemented SwitchDesktop API > > --- > Regards > Sainath A > > Sainath, Some comments (note these are general, I don't actually know the functions you're implementing): - You shouldn't mix tabs and spaces in your patches (match the format of the file). - The wine tree has to compile after every patch (the reason is regression testing). You can split this queue up into two parts - first implement OpenInputDesktop, then SwitchDesktop (or the other way around) - to have 4 patches: 1 - add open_input_desktop server request, 2 - implement OpenInputDesktop, 3 - add switch_desktop server request, 4 - implement SwitchDesktop. - You don't have to pass the calling thread's tid to the server - the server has a global called current which is the thread * object that made the request. - You seem to sometimes return error codes from the server, but changing things nonetheless. Something seems off about that. Also you sometimes just do return; without setting an error code. - I'm not quite sure what you're doing in close_desktop. - Code: Don't do if (!(... == ...)), just use if (... != ...). If you break; in either case of the if, do it outside the if. You don't need to check &desktop_ops != NULL. - Don't use HTML emails, most people don't like those. Mike.

1 0

Re: write initial italian translation
by James Mckenzie Aug. 29, 2009

Aug. 29, 2009

> >Here's the initial italian translation for write. Again, this is not acceptable. The input file should be /dev/null with the difference against your file. You are running a difference against the en_US.rc file after renaming it. Please correct and resubmit. This is the same problem that was pointed out to you with your prior rejected translations. James McKenzie

1 0

Re: wordpad - initial italian translation
by James Mckenzie Aug. 29, 2009

Aug. 29, 2009

> >Here's the initial italian translation for wordpad. This is STILL WRONG! You are not listening. If this is an initial translation, the input file should be /dev/null, not en_US.rc which is what you are using. Please correct and resubmit. James McKenzie

1 0

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by Henri Verbeet Aug. 29, 2009

Aug. 29, 2009

2009/8/29 Riccardo Loti <contez(a)gmail.com>: > P.S.: For some reason the previous mail attachment showed up empty in the > archives list, even if sent mail is correct, and using Thunderbird I prefer > not to paste it int he message body. Sorry for double sending. > The archives are a bit flawed, and created a separate mail for the attachment: http://www.winehq.org/pipermail/wine-patches/2009-August/077889.html The mail itself looked ok.

1 0

Re: [PATCH 1/3] dpwsockx: Stub implementation
by Stefan Dösinger Aug. 29, 2009

Aug. 29, 2009

Yay, Dplay work! A few suggestions though: >From patch 1: > +static HRESULT WINAPI DPWSCB_GetCaps( LPDPSP_GETCAPSDATA data ) > +{ > + TRACE( "(%d,%p,0x%08x,%p)\n", > + data->idPlayer, data->lpCaps, data->dwFlags, data->lpISP ); >+ return DP_OK; > +} Is there any reason this one writes a TRACE instread of a FIXME? I noticed that patch 3 implements it, perhaps you missed this when separating the patches? > +static HRESULT WINAPI DPWSCB_Open( LPDPSP_OPENDATA data ) > +{ > + FIXME( "(%u,%p,%p,%u,0x%08x,0x%08x) stub\n", > + data->bCreate, data->lpSPMessageHeader, data->lpISP, > + data->bReturnStatus, data->dwOpenFlags, data->dwSessionFlags ); > + return DP_OK; > +} Why does it return DP_OK while most other stubs return an error? Patch 2: > + /* Initialize internal data */ > + ZeroMemory( &dpwsData, sizeof(DPWS_DATA) ); I think memset(&dpwsData, 0, sizeof(DPWS_DATA)) is preferred over ZeroMemory. Patch 3: Where do the values like dwMaxLocalPlayers = 65536 come from? Since most functions are still stubs its hard to see where it comes from? Does native dpwsockx have the same limits? (If it does, that's a solid reason for using the same limits)

2 1

Re: configure: Detect and use tools executable extensions for makefiles. (try2)
by John Klehm Aug. 29, 2009

Aug. 29, 2009

On Fri, Aug 28, 2009 at 3:13 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: > (used sed to get the EXEEXT from the wine-tools/Make.rules file) > > When compiling Wine on windows, the non-script tools will have an .exe > extension, but the makefile rules assumed that the tools never have an > extention, so try to incorrectly remake the tools when they are already > built. > Is this patch solving the same thing that this one did? http://www.winehq.org/pipermail/wine-cvs/2009-August/058936.html

2 1

Re: progress of sound update -- REVISED
by Susan Cragin Aug. 29, 2009

Aug. 29, 2009

>>Why do you need to install esound? >ALSA has shipped with "dmix" by default since shortly after 1.0 was >released, though I think Ubuntu's pulse config can screw with it even >after pulseaudio is removed. I'd forgotten about dmix, it's been so long. Good old dmix and dsnoop (which is what I need for incoming sound). I THINK MAYBE dmix works and dsnoop does not, because it's listed when I open Audacity. I'll have to give it a try. However, without installing esound, I don't see "dmix" and "dsnoop" but I do see "default." And "default" freezes. Perhaps that's them, and they just don't work?

2 1

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt Aug. 28, 2009

Aug. 28, 2009

Mike Kaplinskiy wrote: > On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> This is the result of running cppcheck 1.35 with the --all parm against >> the august 27th Git tree: >> >> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of >> bounds >> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of >> bounds >> > > False positive, apparently the numbers are hardcoded as: > 72 char msg[128]; > 88 msg[10 + 3 * 16] = ' '; // = 58<127 > 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 > > >> [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null >> pointer dereference: rgfInOut >> > > It doesn't like the ternary operator? These lines are TRACE lines with > one of the args being ``rgfInOut ? *rgfInOut : 0''. False positive. > > >> [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of >> character ({). Can't process file. >> [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer >> overrun >> > > 739 char defaultpcmname[256]; > 745 sprintf(defaultpcmname, "default"); > > Something is wrong with cppcheck... False positive. > > >> [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer >> overrun >> > > Not checking those - i don't even pretend to understand how modern > graphics works. > > >> [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun >> > > So...it picks > 1455 char name[32]; > 1458 sprintf(name, "/dev/mixer"); > > as an error, but not: > > 1460 sprintf(name, "/dev/mixer%d", i); > > False positive. > > >> [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer >> dereference: dmW >> > > This one is actually a bug, the null check is below this line. All the > callers check for nulls, though. > > >> [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer >> dereference: hWndCreated >> > > Also a bug, and a very real one. Coincidentally, the null check on the > next line is also wrong (should be if (!*hWndCreated) ) > > >> [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun >> > > More of sprintf with just a string nonsense. False positive. > > >> [../wine-git/server/file.c:235]: (possible error) Buffer overrun >> > > Also sprintf nonsense, but slightly more dangerous. The buffer is > declared with [16] and the string is of length 14+1, so a few more > bytes wouldn't hurt. :) > >> Chris >> >> > > If someone could send patches for the few bugs that would be nice. > > Chris - cppcheck is clearly crazy about sprintf's and ternary > operators. You might want to report that. > > Mike. > > > Mike While yes the hard coded one above is a false positive... I would argue its still a bug that probably needs to get fixed... chris

5 6

Recent ntdll performance information patches
by Steven Edwards Aug. 28, 2009

Aug. 28, 2009

Since the last few rounds of patches to NtQuerySystemInformation I am now getting this error when trying to build with llvm-gcc from the latest Xcode nt.c: In function ‘NtQuerySystemInformation’: nt.c:1012: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liIdleTime’ nt.c:1013: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liKernelTime’ nt.c:1014: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liUserTime’ -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [PATCH 6/7] ws2_32: implement AcceptEx
by Juan Lang Aug. 28, 2009

Aug. 28, 2009

Hi Mike, I have one minor nit on this patch: + if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); Please don't check if (wsa->read) is NULL before calling HeapFree. HeapFree already does the correct thing given NULL, and we had a bunch of patches to remove checks like this. --Juan

2 1

WINE and the LSB, or installations Picasa style
by Joe Dluzen Aug. 28, 2009

Aug. 28, 2009

Hello all, any updates on the progress of compiling WINE against the LSB? I know Dan was attempting to here http://www.mail-archive.com/wine-devel(a)winehq.org/msg47916.html but there's been no recent updates. Or, does anyone have any tips or tutorials or best practices to deploy a self contained WINE installation, e.g. Picasa style? Thanks, j

1 0

Re: progress of sound update -- REVISED
by Susan Cragin Aug. 28, 2009

Aug. 28, 2009

Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound -------- Why do you need to install esound? I don't know. I've taken it for granted that some kind of mixer is needed. Perhaps because I don't use the default sound card, the on-board card. Maybe I don't need esound at all. Or maybe if I could permanently make my Creative X-fi card the default. Right now, to do that, I have to revert back to the alsa-utils from Jaunty and use asoundconf set-default-card. (The newest alsa-utils does not include this handy tool.) -------- sudo nano /etc/pulse/client.conf autospawn = no Then every time your computer starts, run killall pulseaudio in terminal first. (Because the Startup Applications menu doesn't really work.) -------- Painful bug in Ubuntu. Yet another reason why I stay away from it at all costs :) What do you use? -------- I trained and ran Dragon NaturallySpeaking without a problem. Excellent news! Yeah. I read somewhere that Ubuntu has made pulseaudio removable partly because of this very program, which of course is a great assistance to people with mild RSI, who can use a keyboard for some things, but tire easily when entering large amounts of text.

2 1

Re: netapi32/tests: Add acceptable error codes for Win7
by André Hentschel Aug. 28, 2009

Aug. 28, 2009

adding "|| RPC_S_SERVER_UNAVAILABLE" is surely not what you wanted, i think you mean "|| rc == RPC_S_SERVER_UNAVAILABLE" -- Best Regards, André Hentschel

2 1

Re: progress of sound update -- REVISED
by Susan Cragin Aug. 28, 2009

Aug. 28, 2009

Change -- The program I test with is Dragon NaturallySpeaking. Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound sudo nano /etc/pulse/client.conf autospawn = no Then every time your computer starts, run killall pulseaudio in terminal first. (Because the Startup Applications menu doesn't really work.) I trained and ran Dragon NaturallySpeaking without a problem. I also tried oss yesterday, and that seemed to be working again, too. I usually follow the above directions but do not install esound or kill pulseaudio and then run the wine app with padsp. If anyone has any different experiences with today's karmic updates, I would be interested to hear about them. Susan

2 1

progress of sound update
by Susan Cragin Aug. 28, 2009

Aug. 28, 2009

Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound sudo nano /etc/pulse/client.conf autospawn = no Then every time your computer starts, run killall pulseaudio in terminal first. (Because the Startup Applications menu doesn't really work.) I trained and ran pulseaudio without a problem. I also tried oss yesterday, and that seemed to be working again, too. I usually follow the above directions but do not install esound or kill pulseaudio and then run the wine app with padsp. If anyone has any different experiences with today's karmic updates, I would be interested to hear about them. Susan

1 0

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt Aug. 28, 2009

Aug. 28, 2009

James McKenzie wrote: > chris ahrendt wrote: > >> ----- Original Message ---- >> From: Ben Klein <shacklein(a)gmail.com> >> To: chris ahrendt <celticht32(a)yahoo.com> >> Cc: wine-devel(a)winehq.org >> Sent: Thursday, August 27, 2009 10:06:56 PM >> Subject: Re: Weekly cppcheck run against Aug 27 Git Tree >> >> 2009/8/28 chris ahrendt <celticht32(a)yahoo.com>: >> >> >>> Mike Kaplinskiy wrote: >>> >>> >>>> On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: >>>> >>>> >>>> >>>>> This is the result of running cppcheck 1.35 with the --all parm against >>>>> the august 27th Git tree: >>>>> >>>>> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of >>>>> bounds >>>>> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of >>>>> bounds >>>>> >>>>> >>>>> >>>> False positive, apparently the numbers are hardcoded as: >>>> 72 char msg[128]; >>>> 88 msg[10 + 3 * 16] = ' '; // = 58<127 >>>> 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 >>>> >>>> >>> Mike While yes the hard coded one above is a false positive... I would >>> argue its still a bug that probably needs to get fixed... >>> >>> >> >> >>> I don't follow this logic. How is it a bug (in Wine) exactly? >>> >>> >> I thought one of the programming standards was the fact you don't hard code values IE 10+3*16... >> it should probably be : >> >> msg_blank = 10+3*16; // These go into header files >> msg_length = 128; // This goes into header file >> >> char msg[msg_length]; >> memset(msg, 0, sizeof(msg)); >> memset(msg, ' ', msg_blank); // or it could even be msg[msg_blank] = ' '; if only position 58 needs to be a ' ' , but I prefer the first method. >> >> does pretty much the same thing except for one point. >> Whatever is in the local stack at the point of assigning the msg buffer will be still there unless you initialise it to null. >> >> >> > I like your logic, but why not just do this: > > msg_blank= 58; > msg_yada_yada=75; > msg_length=128; > > This sets all of the variables using plain values and then they can be > updated as necessary. > > James McKenzie > > > > > same thing =D Chris

1 0

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt Aug. 28, 2009

Aug. 28, 2009

Mike Kaplinskiy wrote: > On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> This is the result of running cppcheck 1.35 with the --all parm against >> the august 27th Git tree: >> >> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of >> bounds >> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of >> bounds >> > > False positive, apparently the numbers are hardcoded as: > 72 char msg[128]; > 88 msg[10 + 3 * 16] = ' '; // = 58<127 > 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 > > >> [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null >> pointer dereference: rgfInOut >> > > It doesn't like the ternary operator? These lines are TRACE lines with > one of the args being ``rgfInOut ? *rgfInOut : 0''. False positive. > > >> [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of >> character ({). Can't process file. >> [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer >> overrun >> > > 739 char defaultpcmname[256]; > 745 sprintf(defaultpcmname, "default"); > > Something is wrong with cppcheck... False positive. > > >> [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer >> overrun >> > > Not checking those - i don't even pretend to understand how modern > graphics works. > > >> [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun >> > > So...it picks > 1455 char name[32]; > 1458 sprintf(name, "/dev/mixer"); > > as an error, but not: > > 1460 sprintf(name, "/dev/mixer%d", i); > > False positive. > > >> [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer >> dereference: dmW >> > > This one is actually a bug, the null check is below this line. All the > callers check for nulls, though. > > >> [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer >> dereference: hWndCreated >> > > Also a bug, and a very real one. Coincidentally, the null check on the > next line is also wrong (should be if (!*hWndCreated) ) > > >> [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun >> > > More of sprintf with just a string nonsense. False positive. > > >> [../wine-git/server/file.c:235]: (possible error) Buffer overrun >> > > Also sprintf nonsense, but slightly more dangerous. The buffer is > declared with [16] and the string is of length 14+1, so a few more > bytes wouldn't hurt. :) > >> Chris >> >> > > If someone could send patches for the few bugs that would be nice. > > Chris - cppcheck is clearly crazy about sprintf's and ternary > operators. You might want to report that. > > Mike. > > > Sending the report now. chris

1 0

submitted AppDB links to bugzilla not working anymore?
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 27, 2009

Aug. 27, 2009

Hi, Several recent link proposals between AppDB and Buzilla acknowledged by "The bug link you submitted between Bug NNN and XYZ has been accepted." have nevertheless produced no visible bug # in AppDB nor "Show Apps affected" in Bugzilla. E.g. Bug #19773 among others. Did some recent changes to the server break that functionality? BTW, a few month ago, I was pleased to see that some links were automatically(?) created when the bug subject had the format app-name: blabla That was a useful idea! Regards, Jörg Höhle

3 3

RE: [2/2] shell32: Remove todo_wine from some tests [try 2]
by First Store Aug. 27, 2009

Aug. 27, 2009

My domain never subscribed to this, please quit sending me these. -----Original Message----- From: wine-patches-bounces(a)winehq.org [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of Vladimir Pankratov Sent: Thursday, August 27, 2009 10:22 AM To: wine-patches(a)winehq.org Subject: [2/2] shell32: Remove todo_wine from some tests [try 2] Hello all. Also resend this patch. Removed todo_wine from some tests. changed files: dlls/shel32/tests/shfileop.c Thanks.

1 0

Re: [2/2] shell32: Remove todo_wine from some tests [try 2]
by Juan Lang Aug. 27, 2009

Aug. 27, 2009

Hi Vladimir, you can't do this in two separate patches like this. After the first patch is applied, the tests fail, and that's not allowed. You should combine the fix and removing todo_wine into a single patch. Thanks, --Juan

1 0

[RFC] Adding an OpenAL DLL thunk
by Chris Robinson Aug. 27, 2009

Aug. 27, 2009

Attached is a set of patches that adds an openal32.dll thunk, allowing an app using OpenAL to use the system's lib instead of Creative's software driver. The advantages of using the system lib include: * It avoids the unnecessary step through DirectSound, instead going right to ALSA, OSS, or whichever is supported by the system implementation. This also allows for a DSound->OpenAL wrapper, since OpenAL won't create a circular dependency by using DSound. * It can provide more options and features, including surround sound (where Creative's software driver only does stereo), depending on the implementation. * It integrates better with the system, as Wine apps will use the same OpenAL configuration used by native apps. If necessary, the Windows DLL can still be used by adding an openal32 override with installing the Windows redistributable. However, more recent versions of the Unix/Linux OpenAL have been much better compatibility-wise than the old 0.0.8 version, as it is actually a fork of the LGPL Windows version. This patch set does not support OSX's OpenAL, but it should be simple enough to add for anyone familiar with handling frameworks in configure.ac. An incomplete list of games that use OpenAL, for testing, can be found here: http://connect.creativelabs.com/openal/OpenAL%20Wiki/Games.aspx Comments and questions are welcome.

5 9