August 2009 - Wine-Devel - list.winehq.org

Re: configure: Detect and use tools executable extensions for makefiles.
by Steven Edwards Aug. 27, 2009

Aug. 27, 2009

On Wed, Aug 26, 2009 at 2:21 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: > When compiling Wine on windows, the non-script tools will have an .exe > extension, but the makefiles assumed that the tools never have an > extention. Naturally this caused problems with the build, causing it to > fail on Windows. > > Please re-run autoconf to update the configure script. > --- > Make.rules.in | 21 +++++++++++---------- > configure.ac | 9 +++++++++ > 2 files changed, 20 insertions(+), 10 deletions(-) I've never had a problem building most of Wine with cygwin or msys+mingw before. Is this new behaviour? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 6

Re: [PATCH 3/3] gdiplus: Implement GdipIsVisibleRect
by Henri Verbeet Aug. 27, 2009

Aug. 27, 2009

2009/8/27 Andrew Eikum <aeikum(a)codeweavers.com>: > +GpStatus WINGDIPAPI GdipIsVisibleRectI(GpGraphics *graphics, INT x, INT y, INT width, INT height, BOOL *result) > +{ > + TRACE("(%p %d %d %d %d %p)\n", graphics, x, y, width, height, result); > + > + if(!graphics || !result) > + return InvalidParameter; > + > + if(graphics->busy) > + return ObjectBusy; > + > + return GdipIsVisibleRect(graphics, (REAL)x, (REAL)y, (REAL)width, (REAL)height, result); > +} Same comment as for yesterday's patches, these checks are redundant because GdipIsVisibleRect() already does them.

1 0

Re: [4/6] mapi32: Implement MAPIInitialize, Logon, Logoff, LogonEx, Uninitialize
by Henri Verbeet Aug. 27, 2009

Aug. 27, 2009

2009/8/26 Owen Rudge <orudge(a)codeweavers.com>: > --- > dlls/mapi32/mapi32_main.c | 93 > +++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 86 insertions(+), 7 deletions(-) > > Is there any special reason for not loading the function pointers at dll init?

1 0

Re: reg initial italian translation
by James McKenzie Aug. 27, 2009

Aug. 27, 2009

Davide Pizzetti wrote: > Here's the initial italian translation for reg. Hope it works now > > If this were truly a new translation the input file would be a/dev/null This is not the case in your patches. Are you trying to update existing code? This goes for all of your initial translation attempts. James McKenzie

1 0

Re: mshtml: Make create_nsstream() static.
by Jacek Caban Aug. 26, 2009

Aug. 26, 2009

Hi Francois, It should be completely removed as it's not used anymore. Also nsIStringInputStream may be removed. I've sent a patch, thanks for catching it. Jacek

1 0

Re: dxdiag: add basic commandline parsing (try 2)
by Jacek Caban Aug. 26, 2009

Aug. 26, 2009

Hi Austin, Austin English wrote: > Please apply after the first dxdiag patch (unicode-ify). Based on a > patch by Dan Kegel. > > case 'w': + opt_given = TRUE; + while (isalpha(*s) || *s == ':') + You can't use isalpha on WCHAR. Use isalphaW instead. Jacek

2 1

new winetricks 20090826: new verbs vc2005express, psdk2003, mono24
by Dan Kegel Aug. 26, 2009

Aug. 26, 2009

Another fortnight, another winetricks. Main changes are: new verbs vc2005express, psdk2003, mono24 plus some bug fixes. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20090815: r653 | daniel.r.kegel | 2009-08-23 18:19:41 -0700 (Sun, 23 Aug 2009) | 4 lines Work around possible wine bug in openwatcom installer in silent install to turn on 16 bit tools installation. Promote openwatcom to non-broken secton of winetricks again. ------------------------------------------------------------------------ r652 | daniel.r.kegel | 2009-08-23 08:24:44 -0700 (Sun, 23 Aug 2009) | 7 lines Add missing checksums. Warn people that vista sdk doesn't install yet. Fix hang in vc2005express verb introduced in last change Added missing verbs in winetrickstest Demoted a few verbs to broken list ------------------------------------------------------------------------ r651 | daniel.r.kegel | 2009-08-22 17:46:56 -0700 (Sat, 22 Aug 2009) | 5 lines vc2005express: 1) remove single quote in description that broke gui menu 2) add warning about mt.exe 3) wait until install (almost) finishes ------------------------------------------------------------------------ r650 | austinenglish | 2009-08-22 15:23:30 -0700 (Sat, 22 Aug 2009) | 2 lines winetricks: add OpenWatcom bug link ------------------------------------------------------------------------ r649 | daniel.r.kegel | 2009-08-22 13:34:25 -0700 (Sat, 22 Aug 2009) | 2 lines Added new verbs vcexpress2005, psdk2003, and psdkvista ------------------------------------------------------------------------ r647 | austinenglish | 2009-08-21 18:36:11 -0700 (Fri, 21 Aug 2009) | 2 lines winetricks: OpenWatcom's silent install is broken ------------------------------------------------------------------------ r646 | daniel.r.kegel | 2009-08-21 12:48:58 -0700 (Fri, 21 Aug 2009) | 3 lines Bump version to 20090821 ------------------------------------------------------------------------ r645 | daniel.r.kegel | 2009-08-18 12:05:53 -0700 (Tue, 18 Aug 2009) | 3 lines Added cygwin (whee!) ------------------------------------------------------------------------ r642 | daniel.r.kegel | 2009-08-16 15:56:44 -0700 (Sun, 16 Aug 2009) | 3 lines Only show GUI warnings if run without args. ------------------------------------------------------------------------ r639 | daniel.r.kegel | 2009-08-15 22:49:55 -0700 (Sat, 15 Aug 2009) | 3 lines Add mono24 Also remove one obsolete comment in mono22

1 0

Re: dxdiag: add basic command line parsing
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/26 Austin English <austinenglish(a)gmail.com>: > Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. > It probably doesn't make much of a difference for command line parsing, but I think you want to make dxdiag explicitly unicode from the start (new programs in general, really). It also seems to me that this patch doesn't do a whole lot in practice.

3 3

Re: wined3d: delete meaningless UNIX GL driver version parsing
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/26 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > Please excuse my previous patch. It was against 1.1.27. Here it is against 1.1.28. > Ah, those were the times when I patched areas nobody else would touch ;-) > This one does happen to apply, but please send patches against current git in the future. I'm not entirely sure if this is better than just fixing the code, but if Roderick and Stefan think it's a good idea it's probably worth a try.

1 0

Re: libs/port: Use the gcc interlocked code also for pcc
by Alexandre Julliard Aug. 26, 2009

Aug. 26, 2009

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -24,7 +24,7 @@ > > #ifdef __i386__ > > -#ifdef __GNUC__ > +#if defined(__GNUC__) || defined(__PCC__) A better way would be to make this case the default, it's not all that gcc-specific. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d10core/tests: Add acceptable error code for Win7
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/26 Ge van Geldorp <ggeldorp(a)vmware.com>: > hr = IDXGIFactory_EnumAdapters(factory, 0, &adapter); > - ok(SUCCEEDED(hr), "EnumAdapters failed, hr %#x\n", hr); > + ok(SUCCEEDED(hr) || hr == DXGI_ERROR_NOT_FOUND, "EnumAdapters failed, hr %#x\n", hr); Is that in a VM? It's fine to skip the test if there are no adapters, but I don't think that's supposed to happen on real hardware.

1 0

Re: wrc: Fix a memory leak on output file name (Smatch)
by Alexandre Julliard Aug. 26, 2009

Aug. 26, 2009

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > The memory is released just thereafter (process end), but this is a leak anyway It's not a leak. There's no point in wasting time freeing memory in main(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg - italian translation update
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > - LTEXT "Wine puÃ² simulare diverse versioni e stili di Windows per ogni applicazione", > + LTEXT "Wine può simulare diverse versioni e stili di Windows per ogni applicazione", Looks like you messed up the encoding of the original file somehow. Probably interpreted utf-8 as ISO 8859-1.

1 0

Re: [PATCH 1/2] gdiplus: Implement GdipIsVisibleRegionPoint
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/25 Andrew Eikum <aeikum(a)codeweavers.com>: > +GpStatus WINGDIPAPI GdipIsVisibleRegionPointI(GpRegion* region, INT x, INT y, GpGraphics *graphics, BOOL *res) > +{ > + TRACE("(%p, %d, %d, %p, %p)\n", region, x, y, graphics, res); > + > + if(!region || !res) > + return InvalidParameter; It's a bit redundant to do that check twice. Shouldn't hurt much though.

1 0

Re: oleview initial italian translation
by Henri Verbeet Aug. 26, 2009

Aug. 26, 2009

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > @@ -1,6 +1,6 @@ > /* > - * OleView (En.rc) > - * English Language Support > + * OleView (It.rc) > + * Italian Language Support > * > * Copyright 2006 Piotr Caban > * That doesn't look right. How did you create these patches?

1 0

Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)
by Paul Chitescu Aug. 26, 2009

Aug. 26, 2009

On Tuesday 25 August 2009 19:27:23 Kirill Smelkov wrote: > Signed-off-by: Kirill Smelkov <kirr(a)mns.spb.ru> > --- > fonts/.gitignore | 58 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 58 > insertions(+), 0 deletions(-) > > diff --git a/fonts/.gitignore b/fonts/.gitignore > index a857f0d..523a9a4 100644 > --- a/fonts/.gitignore > +++ b/fonts/.gitignore > @@ -37,3 +37,61 @@ > /vgasysg.fon > /vgasysr.fon > /vgasyst.fon > + > +courier-1250-96-13.fnt [...] > +system-950-96-16.fnt Git knows shell glob patterns so why not just a line: *.fnt http://www.kernel.org/pub/software/scm/git/docs/gitignore.html

2 1

Re: tools/wine.inf: fix New Zealand DST
by Dmitry Timoshkov Aug. 26, 2009

Aug. 26, 2009

"Austin English" <austinenglish(a)gmail.com> wrote: > Reported in wine-users. Two points: 1. These data are auto generated. 2. Existing data for New Zealand Standard Time,"TZI" do match what XP SP3 has, a new one doesn't. -- Dmitry.

2 2

about video memory detection in wine
by Sun, Sunny Aug. 25, 2009

Aug. 25, 2009

Hi You are using the hardcoded method to get the vidmem now (in function IWineD3DImpl_FillGLCaps), first you call glGetString(GL_RENDERER) to get the GPU renderer string, and then you use this string to set the vidmem in your code. Unfortunately you don't get all of the ATI GPU's string now, for our workstation GPU, the string is always like "ATI FireGL V8700", so you don't recognize this GPU and consider it as ATI_RADEON_9500, then 64MB is set which doesn't support 1280x1024 resolution (Out of adapter memory). I think you can first detect GL_ATI_meminfo in glGetString(GL_EXTENSIONS); if GL_ATI_meminfo exists, then you can use glGetIntegerv(GL_VBO_FREE_MEMORY_ATI, param) to get the current free video memory, you can see more info at: http://www.opengl.org/registry/specs/ATI/meminfo.txt if GL_ATI_meminfo doesn't exist, you can fall back to the original method. Please tell me if you have any questions. Regards, Sunny, Sun

7 20

Re: [1/5] user32:edit Use a dialog mode after receiving WM_GETDLGCODE message.
by Juan Lang Aug. 25, 2009

Aug. 25, 2009

Hi Sergey, one very minor comment on this patch: + len = SendMessage(hwEdit, WM_GETTEXTLENGTH, 0, 0); + ok(13 == len, "expected 11, got %d\n", len); Nit: you mean "expected 13", not 11. The same is true for every instance where 13 is the expected length. --Juan

1 0

Re: shdocvw.inf: add default registry key HKCU, "Software\Microsoft\Internet Explorer\Settings
by Alexandre Julliard Aug. 25, 2009

Aug. 25, 2009

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > @@ -142,6 +142,7 @@ HKLM,"Software\Microsoft\Windows\CurrentVersion\URL\Prefixes","www",,"http://" > [Settings.Reg] > HKCU,"Software\Microsoft\Internet Explorer\Main","Start Page",2,"http://www.winehq.org" > HKCU,"Software\Microsoft\Internet Explorer\Main","Search Page",2,"http://www.google.com" > +HKCU,"Software\Microsoft\Internet Explorer\Settings",,,"" This will create an empty value that doesn't exist on Windows. Please create a proper value instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mapi32/tests: Skip tests if no default email client is installed
by Eric Pouech Aug. 25, 2009

Aug. 25, 2009

+static BOOL HaveDefaultMailClient() this should be +static BOOL HaveDefaultMailClient(void) A+ -- Eric Pouech

1 0

Re: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior
by Alexandre Julliard Aug. 25, 2009

Aug. 25, 2009

Jeff Zaroyko <jeffzaroyko(a)gmail.com> writes: > This fixes bug 15181, test included - passes on Windows 95, 2003, XP, > 2008, Vista and Windows 7 beta that I've tested. > > From 52ff2d29ba9fbffbe8da46a7523338e8b946bbcd Mon Sep 17 00:00:00 2001 > From: Jeff Zaroyko <jeffz(a)jeffz.name> > Date: Sun, 23 Aug 2009 12:38:17 +1000 > Subject: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior > > As a Profile entry and under Control Panel\International sLanguage is not > LOCALE_SLANGUAGE but instead appears to be LOCALE_SABBREVLANGNAME. > > I've verified this is the case for 95, XP, 2003, 2008, Vista and Win 7. > > With the sLanguage override set GetLocaleInfo for LOCALE_SLANGUAGE still > returns the LOCALE_SLANGUAGE string and not the "override", which suggests > that the Control Panel\International sLanguage override should be ignored > by GetLocaleInfo for LOCALE_SLANGUAGE. You shouldn't need any special casing for this, just change the existing mappings to use the appropriate value. -- Alexandre Julliard julliard(a)winehq.org

2 2

Build failure on current git
by Stefan Leichter Aug. 24, 2009

Aug. 24, 2009

Hello, building current git fails for me with: make: Entering directory `/usr/src/wine/wine-build/dlls/winemp3.acm' ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -shared ../../../wine-git/dlls/winemp3.acm/winemp3.acm.spec mpegl3.o -o winemp3.acm.so -lwinmm -luser32 -lkernel32 ../../libs/port/libwine_port.a -lmpg123 mpegl3.o: In function `mp3_horse': /usr/src/wine/wine-build/dlls/winemp3.acm/../../../wine-git/dlls/winemp3.acm/mpegl3.c:153: undefined reference to `mpg123_feed' collect2: ld returned 1 exit status winegcc: ccache failed make: *** [winemp3.acm.so] Fehler 2 make: Leaving directory `/usr/src/wine/wine-build/dlls/winemp3.acm' sle(a)sle3:/usr/src/wine/wine-build$ dpkg --list | grep mpg123 ii libmpg123-0 1.4.3-4 MPEG layer 1/2/3 audio decoder -- runtime li ii libmpg123-dev 1.4.3-4 MPEG layer 1/2/3 audio decoder -- developmen ii mpg321 0.2.10.6 mpg123 clone that doesn't use floating point

2 1

Re: Build failure on current git
by Robert Förster Aug. 24, 2009

Aug. 24, 2009

according to the mpg123 NEWS file mpg123_feed was introduced with 1.5.0 if this is actually the lowest version to compile with, it should be checked by ./configure if possible. linking against system libmpg123 does have other issues however. im building a 32 bit wine on a 64 bit box here and i have installed a 32 bit libary of libmpg123 of course, however: mpegl3.o: In function `MPEG3_Reset': mpegl3.c:(.text+0xca): undefined reference to `mpg123_feedseek' the symbol is actually mpg123_feedseek_64 (which seems to be the case on a pure 32 bit box too according to one reporter) mpg123_findseek is correct for 64 bit however as there isn't mpg123_findseek_64 in my 64 bit libary.

1 0

winemp3.acm: link to system libmpg123.so
by Robert Förster Aug. 24, 2009

Aug. 24, 2009

im getting undefined references to mpg123_feedseek. im on amd64, building a 32 bit wine, so of course i have a 32 bit lib of mpg123 around, which however seems to export mpg123_feedseek_64 instead. could that be covered too please? (i have reports that this is happening on plain x86 boxes too.) Robert

1 0