August 2009 - Wine-Devel - list.winehq.org

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by James Mckenzie Aug. 21, 2009

Aug. 21, 2009

Rico: Which patch is the correct one? Please send it in with (try 3). James McKenzie -----Original Message----- >From: Rico Schüller <kgbricola(a)web.de> >Sent: Aug 21, 2009 9:16 AM >To: wine-patches(a)winehq.org >Subject: Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc. > >Am 21.08.2009 17:46, schrieb Rico Schüller: >> --- >> dlls/d3d10/d3d10_private.h | 3 ++- >> dlls/d3d10/effect.c | 25 ++++++++++++++++++------- >> 2 files changed, 20 insertions(+), 8 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> >> >Hi, > >the previous patch was wrong, take this one instead of the other one. > >Rico >

1 0

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by Rico Schüller Aug. 21, 2009

Aug. 21, 2009

Am 21.08.2009 17:46, schrieb Rico Schüller: > --- > dlls/d3d10/d3d10_private.h | 3 ++- > dlls/d3d10/effect.c | 25 ++++++++++++++++++------- > 2 files changed, 20 insertions(+), 8 deletions(-) > > > ------------------------------------------------------------------------ > > > Hi, the previous patch was wrong, take this one instead of the other one. Rico

1 0

Bug for beginners
by Alexandros Dermenakis Aug. 21, 2009

Aug. 21, 2009

Hi all, I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. thank you

5 6

Re: Bug for beginners
by James Mckenzie Aug. 21, 2009

Aug. 21, 2009

>On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum ><andrew(a)brightnightgames.com>wrote: > >> Alexandros Dermenakis wrote: >> >>> Hi all, >>> >>> I studied the wine developer's guide and went a bit through the code. I >>> would like a suggestion, a bug to start understanding better the structure >>> of wine and familiarize myself with it in order to be able to contribute >>> more in the future. >>> >>> thank you >>> >>> >> Hi Alexandros, >> >> When I began working on Wine, I found that the easiest way for me was to >> implement parts of Wine that have no implementation yet. Implementing new >> functions means you don't have to worry about breaking old tests or >> re-arranging and understanding someone else's code. It also gives you the >> opportunity to write new tests from the ground up, so you get used to >> exactly what the unit tests are for and how they work. >> >> Look around in Wine for functions that are labeled with FIXMEs indicating >> that they are stubs, or look in the .spec files for functions declared as >> stubs. Find a function that has an easy to understand purpose: a very clear >> input and output. Then, write unit tests in that DLL's test suite that >> prove all of the important features of that function. Run your tests on an >> actual Windows OS (look into "crosstests") and verify that they are correct. >> Finally, implement that function in Wine to make it also pass your tests. >> >> If you want a suggestion for where to look for small stubs, take a look at >> gdi32 and gdiplus. I know they still have some smallish, unimplemented or >> half-implemented functions. If graphics don't interest you, there are >> plenty of stubs elsewhere. >> >> Once you've got the hang of how the unit tests work (I mean it, the test >> cases are the most important part of getting patches into Wine), try looking >> into bugs on WineHQ until you find one you think you might be able to >> handle. Then gear up for the most fun you'll ever have reading pages and >> pages debug logs :) >> >> No matter where you begin your work, remember that Wine is a difficult >> project to work on. Because even very subtle changes can cause breakages in >> seemingly unrelated parts of Wine, the standard for patches is very high. >> You will need to prove that your patch is correct using the test suites. >> No provable tests means it's not getting in. >> >> Good luck and thanks for your interest, >> Andrew >> >> >> >As I understand from Wine's policies, functions should only be implemented >if an application requires them. If that's correct, a random search for >stubs isn't a good idea, because the follow up question would be "which >application requires this function?". > One idea is to look at Bugzilla for a problem report that exists because a specific function does not exist. For instance, I have been working on a bug with EM_FORMATRANGE and trying to update the fix included to work with the current Wine version as several programs rely on the ability to change fonts in specific windows. I have a working fix for 0.9.59 and my time was and continues to be diverted to other efforts, not necessarily this fix. However, I would like assistance in moving the patch forward and into Wine. There are other bug reports where the fix is 'hacky' and needs to be cleaned up so, in many cases a conformance/compliance test is all that is needed. This would be a great place to start where you can look at the current Wine code base, what someone came up with as a fix and what needs to make the fix workable. You don't have to look for an application that requires a certain function that works in a specific manner. James McKenzie

1 0

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]
by Alexandre Julliard Aug. 21, 2009

Aug. 21, 2009

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,32 +1713,35 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR buffer[MAX_PATH], xlpFile[MAX_PATH]; > - LPWSTR space, s; > + LPWSTR space; > > - LPWSTR beg = wszApplicationName/*sei_tmp.lpFile*/; > - for(s=beg; (space=strchrW(s, ' ')); s=space+1) { > - int idx = space-sei_tmp.lpFile; > - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); > + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); > + space = buffer + strlenW(buffer); > + do Searching from the end doesn't look right. This would need a test case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: mshtml: Implement IHTMLStyle get/put wordSpacing
by Jacek Caban Aug. 21, 2009

Aug. 21, 2009

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLStyle get/put wordSpacing static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v) { - HTMLStyle *This = HTMLSTYLE_THIS(iface); - FIXME("(%p)->(v%d)\n", This, V_VT(&v)); - return E_NOTIMPL; + HTMLStyle *This = HTMLSTYLE_THIS(iface); + TRACE("(%p)->(v%d)\n", This, V_VT(&v)); + return set_nsstyle_attr_var(This->nsstyle, STYLEID_WORD_SPACING, &v, 0); The indention here is wrong. + hres = IHTMLStyle_get_wordSpacing(style, &v); + ok(hres == S_OK, "get_wordSpacing: %08x\n", hres); + ok(!strcmp_wa(V_BSTR(&v), "10px"), "expected 10px = %s\n", wine_dbgstr_w(V_BSTR(&v))); + VariantClear(&v); Please add a test for V_VT(&v) == VT_BSTR. Jacek

1 0

Re: kernel32: test GetPrivateProfileString with empty string as key and section
by Michael Stefaniuc Aug. 21, 2009

Aug. 21, 2009

Hello Stefan, Stefan Leichter wrote: > Problem spotted from Claudio Fontana on wine-devel > > tested on Win2K > diff -ruw wine-git/dlls/kernel32/tests/profile.c wine-build/dlls/kernel32/tests/profile.c > --- wine-git/dlls/kernel32/tests/profile.c 2009-06-04 19:00:09.000000000 +0200 > +++ wine-build/dlls/kernel32/tests/profile.c 2009-08-16 23:03:37.000000000 +0200 > @@ -41,6 +41,13 @@ > UINT result9x; > }; > > +static const char *debugstr_w(LPCWSTR str) you don't need to add a local debugstr_w implementation anymore. Alexandre added wine_dbgstr_w() to test.h two days ago with commit ee868cce5b412b103ff167deb59c3d5237363199. > +{ > + static char buf[1024]; > + WideCharToMultiByte(CP_ACP, 0, str, -1, buf, sizeof(buf), NULL, NULL); > + return buf; > +} > + > static void test_profile_int(void) > { > struct _profileInt profileInt[]={ bye michael

1 0

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
by Alexandre Julliard Aug. 20, 2009

Aug. 20, 2009

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > TRACE("socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n", > s, level, optname, optval, *optlen); > > + /* Some apps sign-extend the level, so mask off the higher-order bits */ > + level &= 0x0000ffff; There can be several other ways to handle this, it needs test cases to determine which way Windows is using. -- Alexandre Julliard julliard(a)winehq.org

3 5

re: old patch enabling visible icons in some applications
by Dan Kegel Aug. 20, 2009

Aug. 20, 2009

trueflyingsheep wrote: > why didn't it make it into the release? Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it. Thanks! - Dan

6 7

Re: [PATCH 02/12] windowscodecs: Add IWICStream_InitializeFromMemory implementation [try 2]
by Alexandre Julliard Aug. 20, 2009

Aug. 20, 2009

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + * > + * Used by IWICStream_InitializeFromMemory > + * This interface is windowscodecs private only which > + * is why we don't need to implement QueryInterface and AddRef Don't do that, implement it properly even if that code is not used at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.
by Alexandre Julliard Aug. 20, 2009

Aug. 20, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) > return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); > } > > +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) > +{ > + return (IXMLDOMNode*)&This->lpVtbl; > +} That wrapper doesn't follow any established naming convention, and doesn't seem quite necessary. The standard way is to simply cast to the interface type. If you really want a wrapper it should be called something like IXMLDOMNode_from_impl. -- Alexandre Julliard julliard(a)winehq.org

2 3

GSoC - Wine/Gstreamer
by Trevor Davenport Aug. 20, 2009

Aug. 20, 2009

Hi, I wanted to send a mail to the list and basically state what the status of all this is and what my plans are for the future. For those unfamiliar with what i was doing, I was trying to enable using gstreamer elements as directshow filter to expand the quartz functionality available. At the start of the program I was not very familiar with quartz so it took a fair amount of learning to get up to speed with it. The basic ability to use a gstreamer element is mostly there. More work is needed to finish up a few aspects of it though. The source commited to my github repo does expose one working element if you have the gstreamer mp3 plugin installed. A little bit more work is needed to map more formats so that more elements can be exposed. I had hoped to do this before the program deadline but it just ended up not being possible. But i plan to keep working on this. I'd like to see it commited if possible. My plans are essentially the following: * expand the format mapping so most audio elements (ones that operate on one input and one output) can be exposed * add to the quartz filter registry * clean up anything I can find (i am sure there is a leak or two, etc) * finish build setup - configure option and library finding issue (seems to pickup 64bit version on 64bit system...which won't work...) * start patch review More long term I want to start more general quartz work. Implementing some of the currently unimplemented features such as dynamic pin reconnection would help. I want to do this as well as start cleaning up a few areas I found while trying to find what was happening. I also want to continue working on this to allow more elements, specifically the demuxers from gstreamer which should be able to the take the place of avisplitter and mpegsplitter but have more features. I didn't get as far as i had wanted to due to how much I had to learn about directshow and time was constantly a issue. Nothing really uses the new filter currently expect my little test mp3 player, which is also available in the github repo (just search for tdaven, both the wine and the test programs are in my personal repo). It seems the quartz dsound element sometimes (i've had it often) does not mix well when using alsa as the audio driver over pulseaudio. If it sounds extremely slow this is the cause. I've not tracked down exactly what is going on in this case, but using raw alsa or something else has never demonstrated the issue. Took me a good while to find this was the cause though. If there are any questions I'd be glad to answer whatever. Cheers, Trevor Davenport

1 0

Re: winemp3.acm: link to system libmpg123.so
by Alex Villacís Lasso Aug. 20, 2009

Aug. 20, 2009

Aric Stewart escribió: > --- > configure.ac | 12 + > dlls/winemp3.acm/Makefile.in | 11 +- > dlls/winemp3.acm/common.c | 261 ------- > dlls/winemp3.acm/dct64_i386.c | 329 -------- > dlls/winemp3.acm/decode_i386.c | 164 ---- > dlls/winemp3.acm/huffman.h | 346 --------- > dlls/winemp3.acm/interface.c | 254 ------- > dlls/winemp3.acm/l2tables.h | 175 ----- > dlls/winemp3.acm/layer1.c | 159 ---- > dlls/winemp3.acm/layer2.c | 301 -------- > dlls/winemp3.acm/layer3.c | 1613 > ---------------------------------------- > dlls/winemp3.acm/mpegl3.c | 119 ++-- > dlls/winemp3.acm/mpg123.h | 166 ---- > dlls/winemp3.acm/mpglib.h | 69 -- > dlls/winemp3.acm/tabinit.c | 95 --- > 15 files changed, 81 insertions(+), 3993 deletions(-) > delete mode 100644 dlls/winemp3.acm/common.c > delete mode 100644 dlls/winemp3.acm/dct64_i386.c > delete mode 100644 dlls/winemp3.acm/decode_i386.c > delete mode 100644 dlls/winemp3.acm/huffman.h > delete mode 100644 dlls/winemp3.acm/interface.c > delete mode 100644 dlls/winemp3.acm/l2tables.h > delete mode 100644 dlls/winemp3.acm/layer1.c > delete mode 100644 dlls/winemp3.acm/layer2.c > delete mode 100644 dlls/winemp3.acm/layer3.c > delete mode 100644 dlls/winemp3.acm/mpg123.h > delete mode 100644 dlls/winemp3.acm/mpglib.h > delete mode 100644 dlls/winemp3.acm/tabinit.c > > > ------------------------------------------------------------------------ > > The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame. -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

7 12

Re: [2/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban Aug. 20, 2009

Aug. 20, 2009

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement > + else if( IsEqualGUID( riid, &IID_IDispatch ) || + IsEqualGUID( riid, &IID_IDispatchEx ) ) + { + xmlnode *node = impl_from_IXMLDOMNode( This->node ); + + dispex_query_interface(&node->dispex, riid, ppvObject); + + return *ppvObject ? S_OK : E_NOINTERFACE; + } This should be handled by node's QueryInterface implementation. + + xmlnode = impl_from_IXMLDOMNode( This->node ); It's not about your code as you follow msxml3 design, but this is ugly and it shouldn't be needed. + init_dispex(&xmlnode->dispex, (IUnknown*)&This->lpVtbl, &domelem_dispex); init_dispex is first called in create_basic_node, so you initialize it second time here. IMO msxml3 object inheritance needs serious design changes and it would be better to do it before adding IDispatchEx support for node implementations. I will send a few first patches. Thanks, Jacek

1 0

Re: wined3d: have SetAutoGenFilterType call glHint
by Henri Verbeet Aug. 20, 2009

Aug. 20, 2009

2009/8/20 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > This fixes bug #11167. It depends on my previous patch. > > One unclear issue about glHint() is the scope. > What textures does it affect? When? > > An alternative would be, as Stefan Dösinger puts it: "just check if > the app ever sets two contradicting filter types" but I don't know how > "global" the effect of glHint() is (per UNIX process, per .exe, > per GL context, per active texture, per ...)? > > Another alternative would be to replace SetAutoGen with just a FIXME > to at least get rid of the bogus >>>>>> glTexParameter call. > This isn't quite correct. The hint indeed applies to the entire context, and you should map the linear filter to GL_NICEST. We should probably generate mipmaps explicitly with glGenerateMipmapEXT() if the FBO extension is available.

1 0

Request for test on at least one Windows box
by Juan Lang Aug. 19, 2009

Aug. 19, 2009

Hi all, could someone with the ability to build and run a test on Windows run the attached test for me? I have a fix for bug 19760, but I'd just like to double check that it's correct before sending it in (and I don't have access to Windows at the moment.) Please copy the list on the reply so not too many people end up doing it. Cheers, --Juan

2 2

Wine Development Stats
by André Hentschel Aug. 19, 2009

Aug. 19, 2009

Hi, inspired by "Linux Kernel Development: How Fast it is Going, Who is Doing It, What They are Doing, and Who is Sponsoring It: An August 2009 Update" (http://www.linuxfoundation.org/publications/whowriteslinux.pdf) i thought we might do a similar analyse of the wine tree. I attach a first overview made with gitdm, the tool they used, too. Is there some interest to do a similar PDF? -- Best Regards, André Hentschel

2 1

Re: ole32: On big endian machines, copy strings to little endian order without mucking with the map they're stored in (try 2)
by Alexandre Julliard Aug. 19, 2009

Aug. 19, 2009

Juan Lang <juan.lang(a)gmail.com> writes: > +#ifdef WORDS_BIGENDIAN > +/* Returns a byte-swapped copy of str, to be freed with HeapFree(). */ > +static LPWSTR PropertyStorage_StringToLE(LPCWSTR str, size_t len) > +{ > + LPWSTR leStr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + if (leStr) > + { > + memcpy(leStr, str, len * sizeof(WCHAR)); > + PropertyStorage_ByteSwapString(leStr, len); > + } > + return leStr; > +} > +#else > +#define PropertyStorage_StringToLE(s, l) (LPWSTR)(s) > +#endif You are still casting away const... -- Alexandre Julliard julliard(a)winehq.org

2 2

GSoC 2009 Final evaluations due
by Kai Blin Aug. 19, 2009

Aug. 19, 2009

Hi folks, GSoC 2009 is wrapping up and the final evaluations are due. So far only one student and no mentors have filled out the surveys, so please take your time and take care of that soon. The results are due on Monday, but I'd prefer if I had some room to deal with any issues coming up, so please try to get the surveys in as soon as possible. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [1/3] WineD3D: Use a sane default refresh rate
by Henri Verbeet Aug. 19, 2009

Aug. 19, 2009

2009/8/19 Stefan Dösinger <stefan(a)codeweavers.com>: > and its value(=0) is not sane MSDN seems to disagree. "The value of 0 indicates an adapter default."

2 4

Re: winelib include problem
by Maarten Lankhorst Aug. 19, 2009

Aug. 19, 2009

Hi Jesse, Jesse Allen schreef: > Maartan, > > In a patch committed on 10 Jul 2008, includes: Add video mixing > renderer header, it included a construct that autogenerates this piece > of code for strmif.h > > " > typedef struct tagVMRGUID { > GUID *pGUID; > GUID GUID; > } VMRGUID; > " > > Unfortunately any C++ file that includes that header seems to miscompile. > > " > #include <strmif.h> > " > > produces with wineg++ > > In file included from blarg.c:1: > /home/jesse/build/wine/include/strmif.h:8972: error: declaration of > 'GUID tagVMRGUID::GUID' > /home/jesse/build/wine/include/guiddef.h:31: error: changes meaning of > 'GUID' from 'typedef struct _GUID GUID' > winegcc: g++ failed > > > This is also a problem in the DXSDK when compiling with g++, I > suppose. This is explained here: > http://home.clara.net/raoulgough/vidmodem/dshow.html > > I tried patching the vmrender.idl similar to this: > " > typedef struct tagVMRGUID > { > #if defined(__cplusplus) > GUID *pGUID, ::GUID; > #else > GUID *pGUID, GUID; > #endif > } VMRGUID; > " > Judging by that link you sent me, shouldn't it be: typedef struct tagVMRGUID { #if defined(__cplusplus) ::GUID *pGUID, GUID; #else GUID *pGUID, GUID; #endif } VMRGUID; Or am i reading that link wrong? > But no go. It still produces the same problem. Obviously you can't > have the ::GUID prefixed and work on gcc as much as you can have the > GUID GUID in g++. But I think we will need it, otherwise I will just > have to hack the strmif.h everytime. > > Can you take a look at the problem? I think we will want this to work > for winelib on g++ as it's pretty well dependent. > Main problem is of course the msvc compiler doesn't have that problem, but if that ifdef works perhaps it's possible to have it like that. Cheers, Maarten.

2 3

Re: [PATCH 5/5] wined3d: Hide WINED3DFMT_R16G16B16A16_UNORM again.
by Stefan Dösinger Aug. 19, 2009

Aug. 19, 2009

Am Wednesday 19 August 2009 10:55:39 schrieb Henri Verbeet: > This format is broken on some cards. Hide it until we figure out a reliable > way to deal with it. Didn't you consider breaking something the best way to get the driver fixed? :-) Fwiw, I reported this to linux-bugs(a)nvidia.com, together with a testcase. No reply yet. Feel free to disable it if there are too many issues though, but maybe add a comment why it is disabled.

1 0

Re: (resend, 2nd) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [2nd]
by Alexandre Julliard Aug. 19, 2009

Aug. 19, 2009

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,28 +1713,29 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR buffer[MAX_PATH], xlpFile[MAX_PATH]; > - LPWSTR space, s; > + LPWSTR space; > > - LPWSTR beg = wszApplicationName/*sei_tmp.lpFile*/; > - for(s=beg; (space=strchrW(s, ' ')); s=space+1) { > - int idx = space-sei_tmp.lpFile; > - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); > + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); > + while((space=strchrW(buffer, ' '))) > + { > + int idx = space-buffer; > buffer[idx] = '\0'; This will break the loop since you don't reset the buffer contents. Also the indentation is messed up, please fix your editor setup. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/18] d3dx9: Add shader assembler private definitions
by Vincent Povirk Aug. 18, 2009

Aug. 18, 2009

Don't send patches that only add unused code. On Sun, Aug 16, 2009 at 12:50 PM, Matteo Bruni<matteo.mystral(a)gmail.com> wrote: > This is a long patch series that implements the D3D shader assembler > and D3DXAssembleShader function. The first part has already passed a > couple of rounds of review in wine-devel. > > > > -- Vincent Povirk

4 6

Re: [PATCH 1/3] tools/widl: A structure containing a BOGUS_ARRAY should be a BOGUS_STRUCT.
by Alexandre Julliard Aug. 18, 2009

Aug. 18, 2009

Huw Davies <huw(a)codeweavers.com> writes: > @@ -280,9 +282,10 @@ unsigned char get_struct_fc(const type_t *type) > if (get_enum_fc(t) == RPC_FC_ENUM16) > return RPC_FC_BOGUS_STRUCT; > break; > - case TGT_POINTER: > case TGT_ARRAY: > - if (get_pointer_fc(t, field->attrs, FALSE) == RPC_FC_RP || pointer_size != 4) > + if(get_array_fc(t) == RPC_FC_BOGUS_ARRAY) return RPC_FC_BOGUS_STRUCT; > + case TGT_POINTER: > + if(get_pointer_fc(t, field->attrs, FALSE) == RPC_FC_RP || pointer_size != 4) This doesn't seem to match the midl behavior. For instance in the server.idl test puints_t becomes a bogus struct, but it's a simple struct with midl. -- Alexandre Julliard julliard(a)winehq.org

1 0