August 2009 - Wine-Devel - list.winehq.org

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file
by Henri Verbeet Aug. 12, 2009

Aug. 12, 2009

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > This is the first of a series of patches to implement the IImageList > interface into comctl32, introduced in comctl32 v6. > > This first patch splits the routines for loading v6 of comctl32 > (requiring a side-by-side manifest) out of the listview tests and into a > general file, so that it can be used by the imagelist tests too. > I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compilation.

6 9

Re: [2/2] msxml3: IXMLDOMElement doesnt support IObjectIdentity
by Jacek Caban Aug. 12, 2009

Aug. 12, 2009

Alistair Leslie-Hughes wrote: > Hi, > This is just to silence a noisy fixme. > > Changelog: > msxml3: IXMLDOMElement doesnt support IObjectIdentity It's an interface used by jscript engine, so it would be better to silence it for all object that implements IDispatch. I'd suggest to move it to dispex_query_interface. Jacek

1 0

Re: [1/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban Aug. 12, 2009

Aug. 12, 2009

Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement @@ -46,6 +47,9 @@ typedef struct _domelem LONG ref; IUnknown *node_unk; IXMLDOMNode *node; + + /* IDispatchEx */ + DispatchEx dispex; } domelem; It would be probably better to add DispatchEx to node object. Then other node types will reuse it (initializing with different data). See how it's done in mshtml. Jacek

1 0

Re: shdocvw: Implement OleInPlaceObject InPlaceDeactivate
by Jacek Caban Aug. 12, 2009

Aug. 12, 2009

Alistair Leslie-Hughes wrote: > Hi, > This fixes bug http://bugs.winehq.org/show_bug.cgi?id=18531 > > > Changelog: > shdocvw: Implement OleInPlaceObject InPlaceDeactivate It's not an implementation, but a bit better stub. Please leave the FIXME message. Jacek

1 0

Re: [3/5] comctl32/treeview: Make tests not depend from each other, replace some magics with macros
by Paul Vriens Aug. 12, 2009

Aug. 12, 2009

Nikolay Sivov wrote: > Currently tests are dependent which makes it impossible to change only one, > could be possible actually, but not always. Anyway separate tests are better. > > Changelog: > - Make test not depend from each other, replace some magics with macros > Hi Nikolay, Looks like this one introduced 1 failure on several boxes (XP, W2K3, Vista and W2K8) and 1 more on Vista boxes: http://test.winehq.org/data/tests/comctl32:treeview.html Could you have a look? -- Cheers, Paul.

2 2

Re: includes: Make vmrender.idl C++ friendly
by Maarten Lankhorst Aug. 11, 2009

Aug. 11, 2009

Hi Austin, Austin English schreef: > On Tue, Aug 11, 2009 at 12:56 PM, Maarten > Lankhorst<m.b.lankhorst(a)gmail.com> wrote: > >> C++ doesn't like: GUID GUID; which is valid in C, so replace with struct >> _GUID GUID; >> > > > FYI, you're e-mail is messed up in the patch: > From: Maarten Lankhorst <mlankhorst(a)patser.(none)> > > I think AJ's scripts may prefer the patch e-mail to the sender's e-mail. > afaict it has never been a problem in the past, aj has always used sender for me Cheers, Maarten

1 0

convert a testcase into a unittest (bug #19666)
by Stefan Leichter Aug. 11, 2009

Aug. 11, 2009

Hi, i got a testcase that exhibits bug #19666. Now i'm looking for a way to integrate the testcase into the testsuite. The testcase needs a program (currently c:\ShellExecuteClient.exe) that must be called without parameters. Therefore i can not use eg. shell32_test.exe itself. I'm searching for a way to build/bundle ShellExecuteClient.exe with shell32_test.exe. Can ShellExecuteClient.exe be integrated as wine-lib binary in the testsuite? Please give me comments, suggestions, solutions Bye Stefan

1 0

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/11 Owen Rudge <orudge(a)codeweavers.com>: > +static const IImageListVtbl ImageListImpl_Vtbl = { > + ImageListImpl_QueryInterface, > + ImageListImpl_AddRef, > + ImageListImpl_Release > +}; You can't do that, you need to at least implement stubs for the other methods.

2 2

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)
by Eric Pouech Aug. 11, 2009

Aug. 11, 2009

Juan Lang a écrit : > Uses %u rather than %d, based on Henri's feedback. > --Juan > > ------------------------------------------------------------------------ > > Hi Juan don't you miss a break statement (or a more likely a return 0) at the end of the block ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: ws2_32(8/8): Implement getsockopt(SOL_IRLMP, IRLMP_ENUMDEVICES)
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

Isn't getsockopt() supposed to write the size of the data actually written to optlen?

2 1

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/11 Juan Lang <juan.lang(a)gmail.com>: > + sprintf( win->irdaServiceName, "LSAP-SEL%d", uin->sir_lsap_sel ); I have no idea if this can even be an issue in practice, but "uin->sir_lsap_sel" is unsigned.

2 1

Re: Assigning a bug to myself
by James Mckenzie Aug. 11, 2009

Aug. 11, 2009

>--- On Mon, 10/8/09, Ben Klein <shacklein(a)gmail.com> wrote: > >> 2009/8/10 Alexandros Dermenakis >> <alderfc7(a)gmail.com>: >> > Hi, >> > >> > I 'm now ready to start debugging wine so I'd like to >> try solving a bug. Do I >> > need to assign a bug to myself or I just start solving >> it? If I have to assign >> > it how can I do that? >> > >> > I created a bug zilla account >> >> You don't need to assign bugs to yourself. I believe this >> was covered >> in another thread. Once you have a patch to fix a bug, send >> it to >> wine-patches, following the "submitting patches" guide. >> Then, if it is >> accepted and committed, the appropriate bug can be marked >> "FIXED". > >To avoid duplication of effort (though quite unlikely among the wine community), it is probably appropriate to >stick a comment on the specific bug to that effect and put yourself to the CC:. This way, others know you >are working on it, and you get to read about others' insight to the problem if they choose to write to >comment. (this has essentially the same effect as having the bug formally assigned to oneself, without the >management/administration overhead). It is a good idea to get the bug assigned to one's self and not to rely on the use of comments. Of course, if you abandon the bug because you cannot complete the fix, it is a good idea to get the bug unassigned and leave a comment as to the status of the bug fix. > >Most bugs' status are eventually and officially closed by AJ anyway :-). ALL Wine bugs are closed by AJ after confirming that the fix is in a specific release of Wine. He has reserved this to himself. Wine Web Site bugs are closed by the person who incorporated fixes into the code for the web site. James McKenzie

1 0

Help with test
by Alistair Leslie-Hughes Aug. 11, 2009

Aug. 11, 2009

Hi, I been trying to fix this bug, and have patch that works. http://bugs.winehq.org/show_bug.cgi?id=11325 The only thing is that the test case I've written fails under wine but work under Windows XP. The issue is, when using a stylesheet we can do something like <xsl:apply-templates select='document("C:\temp\ss.xsl"/bottle/etc)' />. which attempts to load a document and extracts information from it. In windows this works fine, but the linux libxsl library doesn't know about 'c:\' syntax. To get around this issue we overload the input for libxml, and handle windows file paths. (patch attached) The problem is I've attempted to reproduce this scenario as a test, but have missed something. Can someone have a look to see what I might of overlooked? Best Regards Alistair Leslie-Hughes

1 0

Re: hhctrl.ocx: Handle NULL param
by Paul Chitescu Aug. 11, 2009

Aug. 11, 2009

This is a quite ugly patch, adds unnecessary wstring copying. Why not: wsprintfW(buf, url_format, full_path, (index && index[0] == '/') ? empty : slash, index);

1 1

Re: removes 1024 mb from geforce gtx 260 and adds 896mb instead directx patch
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/10 James Carthew <jcarthew(a)gmail.com>: > From 3fc1812db11e6468b9774f597993c292f36873b7 Mon Sep 17 00:00:00 2001 > From: Your Name <you(a)email.com> > Date: Mon, 10 Aug 2009 12:11:31 +0930 > Subject: [PATCH] removes 1024mb from geforce 260 gtx and adds 896mb instead to directx.c > to match real geforce 260gtx cards. Please use a proper name, e-mail address and subject.

1 0

Re: [6/6] comctl32: Add stubs for image list functions introduced in Vista
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +@ stdcall HIMAGELIST_QueryInterface(long long long) ... > +@ stdcall ImageList_CoCreateInstance(long long long long) These should all be pointers. > + FIXME("STUB: %s %p %s %p\n",debugstr_guid(rclsid), punkOuter, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; You have some trailing white space here. Also, the white space in the FIXME is somewhat inconsistent. Personally, I'd say the wording in the comments and the parameter naming is closer to MSDN than I'd be comfortable with.

1 0

Re: [5/6] comctl32/tests: Add basic test for IImageList using SHGetImageList
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +static BOOL test_shell_imagelist(void) ... > + test_shell_imagelist(); It's a bit pointless to add a return value if it's always going to be TRUE, and you're ignoring it anyway.

1 0

Re: [2/6] include: Define interface for comctl32 v6 (IImageList)
by Henri Verbeet Aug. 11, 2009

Aug. 11, 2009

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +cpp_quote("#define ILIF_ALPHA 0x00000001") > You don't need cpp_quote here, you can just do something like "const UINT ILIF_ALPHA = 1;" > +interface IImageList : IUnknown ... > +}; While valid, you don't need the ; here.

1 0

Wine and XShm support
by Roderick Colenbrander Aug. 11, 2009

Aug. 11, 2009

Hi, As of Wine 1.1.27, XShm support was added for the creation of DIBSECTIONs in winex11.drv. The use of XShm more closely matches to the Windows behavior and can also bring more performance. An Nvidia developer noticed this change in the ChangeLog and we both wondered why even more XShm code was added in this time because XShm has lost its use due to the emergence of EXA-like display drivers. Modern drivers disable a large amount of hardware acceleration when using XShm because they can't create the pixmaps in video memory since the client owns the memory. This could decrease performance quite a bit for most applications if they aren't hit by dibsection back-and-forth copying bottlenecks. XRender for instance falls back to software rendering for non-video memory based pixmaps. I would perhaps suggest that we should perhaps drop XShm support (or at least add a registry key for it and disable it perhaps on 'modern drivers'). What do you guys think? Regards, Roderick Colenbrander

6 8

winetricks, dotnet3 and winsxs
by Hin-Tak Leung Aug. 11, 2009

Aug. 11, 2009

Hiya, I have tried playing with the new dotnet3 functionality. Actually even with a clean new wineprefix I haven't been able to get dotnet3 finishing installing - it hangs for a lonh time doing nothing much but the last it does is ngen. the process table shows nothing extra. killing all and rerun gives the option to repair (or uninstall) and this is the tail end of it: -------------- icrosoft (R) CLR Native Image Generator - Version 2.0.50727.42 Copyright (C) Microsoft Corporation 1998-2002. All rights reserved. fixme:imm:ImmDisableIME (-1): stub err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoRevokeClassObject called from wrong apartment, should be called from d8000000d9 Microsoft (R) CLR Native Image Generator - Version 2.0.50727.42 Copyright (C) Microsoft Corporation 1998-2002. All rights reserved. Note: command 'wine /home/Hin-Tak/.winetrickscache/dotnet30/dotnetfx3.exe' returned status 67. Aborting. Warning: Missing charsets in String to FontSet conversion Warning: Unable to load any usable fontset --------------------- On my good old 'everything' wine prefix, running dotnet2 (which is called by dotnet3) has the effect of *removing* the MSVCRT80 winsxs from winsxs and breaks a lot of things - and I had to copy them back from the alternative clean install. Why does it do that? The last part (missing charset) seems to be some harmless thing winetrick does - instead of gtk it calls good old xlib message to pop up a message; I haven't looked at why.

2 2

GSoC 2009 final week of coding started
by Kai Blin Aug. 11, 2009

Aug. 11, 2009

Hi GSoC students, hi mentors, just a little heads up that the final week of coding for GSoC started on Monday. The program timeline suggests that you start with writing documentation and tests now, but check with what your mentors think you should work on. Firm "pencils down" date is next Monday. Also see http://socghop.appspot.com/document/show/program/google/gsoc2009/timeline for the timeline. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Assigning a bug to myself
by Alexandros Dermenakis Aug. 10, 2009

Aug. 10, 2009

Hi, I 'm now ready to start debugging wine so I'd like to try solving a bug. Do I need to assign a bug to myself or I just start solving it? If I have to assign it how can I do that? I created a bug zilla account

6 6

How to test cryptui's dialogs?
by Aurimas Fišeras Aug. 10, 2009

Aug. 10, 2009

Hello, I've finished translating cryptui's resources, checked control sizes with resource editor and adjusted them where it was needed. But how can I run cryptui's wizards and other dialogs to confirm that everything else is translated correctly?

6 21

The next Wine Bug Day will be this Sunday, August 16
by Scott Ritchie Aug. 10, 2009

Aug. 10, 2009

Wine Bug Day is a chance to help the Wine developers focus on Wine development by doing some of the QA work for them. We make sure bugs are still there in the latest Wine so they don't have to. If you'd like to get involved and maybe even have a bit of fun triaging bugs with a group of people, check out the wiki page at http://wiki.winehq.org/BugDay The wiki page has some suggestions for easy bugs to target, such as bugs in your favorite application and bugs with a free testable download. Our goal for this Bug Day will be to continue on the success of the first: http://yokozar.org/blog/archives/107 -- last time we hit over 70 bugs, and this time I'm betting we can top 100. I (and others) will be in the IRC channel during bug day fielding all your questions, so please feel free to join in and rock some bugs :) Thanks, Scott Ritchie

1 0

Re: kernel32/nls/winerr: Add Russian translation [try 3]
by Dmitry Timoshkov Aug. 10, 2009

Aug. 10, 2009

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc I think it's been said enough about your "translation". I'm not going to spend more time commenting on it, I hope Alexandre will ignore all future attempts as well. -- Dmitry.

4 9