August 2009 - Wine-Devel - list.winehq.org

AppDB isn't working
by Igor Tarasov Aug. 10, 2009

Aug. 10, 2009

AppDB displays only decorations and navigation - no content on all pages. Maybe this is due to recent commits? -- Igor

4 4

D3D shader assembler (round 2)
by Matteo Bruni Aug. 10, 2009

Aug. 10, 2009

I'm sending a new version of the shader assembler, which tries to address the caveats and suggestions previously given by Henri Verbeet (http://www.winehq.org/pipermail/wine-devel/2009-July/077428.html for reference) and has a few other changes, such as making the parser reentrant and matching more faithfully native behavior in handling errors in shader programs. One point of discussion could be the internal transformations done to shaders version 1.x and 2.x, towards a sm 3.0-type representation. This is not really necessary for the assembler (which could naively keep the original instruction opcode and register type), but I think it can be useful looking at a reuse of the bytecode writer in the shader compiler: this way the compiler could be somewhat simplified, having to deal just with sm 3.0 registers and conventions, while it would be writer's responsibility to convert to the destination format (e.g. transforming some mov to texcoord in <= ps 1.3). Anyway, if this is not considered useful, it could be removed. As usual, reviews, comments and suggestions are much appreciated. Regards, Matteo Bruni.

3 2

backward binary compatibility of winelib
by Андрей Пономаренко Aug. 9, 2009

Aug. 9, 2009

Hello, I'm from Institute for System Programming of Russian Academy of Sciences and we are developing a free lightweight tool for checking backward/forward binary compatibility of shared C/C++ libraries in OS Linux. It checks interface signatures and data type definitions in two library versions (headers and shared objects) and searches ABI changes that may lead to incompatibility. We have released 1.2 version of this tool and we'd like you to consider its usefulness for your project. The wiki-page with the latest release of binary compatibility checker is http://ispras.linux-foundation.org/index.php/ABI_compliance_checker Andrey Ponomarenko

2 1

re: cppcheck run against 1.27
by Dan Kegel Aug. 9, 2009

Aug. 9, 2009

Chris wrote: >... >[../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >deallocated pointer: fd - This just means your freeing an already freed >resource... This is more of a warning than anything Double frees are serious errors... double closes not so much. I don't see either on that line, though...? - Dan

1 1

.net 3.5 installer happy already?!
by Dan Kegel Aug. 9, 2009

Aug. 9, 2009

After the recent success with the .net 3.0 installer, I decided to try .net 3.5: $ wget http://download.microsoft.com/download/7/0/3/703455ee-a747-4cc8-bd3e-98a615… $ sha1sum dotNetFx35setup.exe b0ca05c12ebb9a3610206bad7f219e02b7873cbd dotNetFx35setup.exe $ rm -rf ~/.wine $ sh winetricks dotnet20 $ wine dotNetFx35setup.exe And surprise, although there was a crash dialog about printfilterpipelinesvc, the installer reported that it finished ok! I have no idea if the installed runtime actually works, and there are a ton of log messages after installation finishes. (Presumably the .net optimization service?) But it's nice to have gotten this far. - Dan p.s. A few of the common warnings at random: Could not load type 'System.DateTimeOffset' from assembly 'mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. while compiling method token 0x6000723 fixme:shell:URL_ParseUrl failed to parse L"System.ServiceModel" Could not load file or assembly 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. Exception from HRESULT: 0x80070002 while compiling method token 0x60001bc Error compiling System.ServiceModel.Web, Version=3.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35: Could not find or load a type. (Exception from HRESULT: 0x80131522) fixme:shell:URL_ParseUrl failed to parse L"System.ServiceModel" Warning: System.IO.FileNotFoundException: Could not load file or assembly 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. Exception from HRESULT: 0x80070002 File name: 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' WRN: Assembly binding logging is turned OFF. To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. Note: There is some performance penalty associated with assembly bind failure logging. To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

1 0

Re: wine-devel Digest, Vol 49, Issue 21
by chris ahrendt Aug. 9, 2009

Aug. 9, 2009

> > Subject: > re: cppcheck run against 1.27 > From: > Dan Kegel <dank(a)kegel.com> > Date: > Sat, 8 Aug 2009 15:53:25 -0700 > To: > wine-devel(a)winehq.org > > To: > wine-devel(a)winehq.org > > > Chris wrote: > >> ... >> [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >> deallocated pointer: fd - This just means your freeing an already freed >> resource... This is more of a warning than anything >> > > Double frees are serious errors... double closes not so much. > I don't see either on that line, though...? > - Dan > I can run it with the --all option to see if it gives any clarification Chris

1 0

Building inkscape for Windows using mingw under wine
by Dan Kegel Aug. 8, 2009

Aug. 8, 2009

http://bugs.winehq.org/show_bug.cgi?id=19615 shows that wine is very nearly in good enough shape to run the fetch-all-the-libs-and-sources script with cygwin, and run the inkscape win32 build system, and pop out a working inkscape.exe. We're just one little leak away from full success, I think. If you ask me, that's pretty cool. - Dan

1 2

dotnet30 and winetricks
by Dan Kegel Aug. 8, 2009

Aug. 8, 2009

Thanks to AF and Hans (and Codeweavers), there's now a short recipe for installing .net 30. I've added it to winetricks. Give it a shot and let me know if it works for you...

3 3

cppcheck run against 1.27
by chris ahrendt Aug. 8, 2009

Aug. 8, 2009

[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map Latest Check against the 1.27 Tree Chris

3 2

Re: cppcheck run against 1.27
by chris ahrendt Aug. 8, 2009

Aug. 8, 2009

Marcus Meissner wrote: > On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: > >> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> > > I do not fully understand the code (keep fd open to have to lock > existing?), but it is in a fatal exit path. > >> [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp >> [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd >> > > Fix submitted, seem necessary. > > >> [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens >> > > Fix submitted, but program is shortlived. > > >> [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >> deallocated pointer: fd >> > > I do not understand what it mislikes about it. I think the detection > is wrong. > > >> [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd >> > > Fix submitted. Small issue though. > > >> [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map >> > > Fix submitted. Small issue though. > > Ciao, Marcus > > > here is what its checking for : Standard checks that are always used * out of bounds * Using 'memfunc' on class * Using 'memfunc' on struct that contains a 'std::classname' * Class Base which is inherited by class Derived does not have a virtual destructor * Mismatching allocation and deallocation: varname * Memory leak <http://en.wikipedia.org/wiki/Memory_leak>: varname * Resource leak <http://en.wikipedia.org/wiki/Resource_leak>: varname * Deallocating a deallocated pointer: varname * Using 'varname' after it is deallocated / released * The given size sz is mismatching * Invalid radix in call to strtol <http://en.wikipedia.org/wiki/Strtol> or strtoul. Must be 0 or 2-36 * Overlapping data buffer varname * Unsigned division. The result will be wrong. * Unusual pointer arithmetic * Returning pointer to local array variable * Same iterator is used with both container1 and container2 * Dangerous usage of erase * After push_back or push_front, the iterator 'iterator_name' may be invalid * Wrong assignment of an auto-variable to an effective parameter of a function * Return of the address of an auto-variable * Division by zero * STL <http://en.wikipedia.org/wiki/Standard_Template_Library>: check usage of iterators after erase, as erase invalidates the iterator * STL: check usage of iterators and pointers after push_back and push_front. If using a vector the iterator or pointer may become invalid. * STL: Range checks with iterators should use != instead of < I have not run it with the following : Extra checks that you enable with "--all" These checks are not part of the standard checking because they produce false positives. * Array index out of bounds * Buffer overrun * Dangerous usage of strncat <http://en.wikipedia.org/wiki/Strcat>, possible buffer overrun * Memory leak: varname * The size argument is given as a char constant Extra checks that you enable with "--style" * The class 'classname' has no constructor * Member variable not initialized in the constructor 'classname::varname' * Unused private function 'classname::funcname' * 'operator=' should return something * C-style pointer casting * Redundant condition. It is safe to deallocate a NULL pointer * Redundant condition. The remove function in the STL will not do anything if element doesn't exist * Found redundant if condition - 'if (condition);' * struct or union member 'structname::varname' is never used * Function parameter 'parname' is passed by value. It could be passed by reference instead. * Redundant code: Found a statement that begins with type constant * Warning - using char variable as array index * Warning - using char variable in bit operation * Condition is always truefalse Checks that are enabled when both "--all" and "--style" is given * Warning: Division with signed and unsigned operators When giving "--unused-functions" * The function 'funcname' is never used I am going to start running with the --all flag going forward. So the leak with fd cppcheck thinks that you have an exit path that will leave the fd allocated still without freeing the resource. [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd so this exits without freeing the resource. [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd - This just means your freeing an already freed resource... This is more of a warning than anything Chris

1 0

re: DxDiag Demo Patch
by Dan Kegel Aug. 8, 2009

Aug. 8, 2009

Henri wrote: > However, what really needs clarification is the copyright status of this. The web page about the project http://kegel.com/wine/sweng/2009/ makes it clear that the work had to be LGPL, and the students were fine with that. The final presentation about that code, http://kegel.com/wine/sweng/2009/dxdiag_presentation.ppt says "Features: ... Now free and open source Previous implementation was owned by Microsoft Could not ship with Wine" so they understood that they were writing free software that would ship with wine. The authors, according to that presentation, are Allen Hair, Brian Nguyen, David Woo, David Hwang, Linh Pham, and Edward Chang. I'm pretty sure it's ok to merge. - Dan

1 0

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput
by Vitaliy Margolen Aug. 8, 2009

Aug. 8, 2009

Andrew Eikum wrote: > --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy.

2 2

Crash in riched20 caused by cryptui
by Juan Lang Aug. 7, 2009

Aug. 7, 2009

Hi Dylan, I wonder if you might be able to shed insight into this. cryptui uses riched20 to display some text, and inserting an icon into a richedit control causes a crash: Assertion failed: (~para->member.para.nFlags & MEPF_REWRAP), function ME_GetCursorCoordinates, file caret.c, line 183. If I comment out the assertion, the icon gets displayed, a little offset from where I expected it, but no other crashes appear. I'm inserting the icon with: IRichEditOle_InsertObject(richEditOle, &reObject); (in cryptui's main.c.) The call stack isn't all that interesting, so I followed the call flow a little by hand. IRichEditOle_InsertObject is a wrapper that calls IRichEditOle_fnInsertObject. This calls ME_InsertOLEFromCursor, which calls ME_InternalInsertTextFromCursor. This calls ME_InsertRunAtCursor. ME_InsertRunAtCursor sets the MEPF_REWRAP flag: cursor->pPara->member.para.nFlags |= MEPF_REWRAP; which, I believe, is what leads to the assertion. Might you shed some insight into what the assertion is protecting against, or better yet how I might avoid it? If you have any interest in looking at it, I can send you a small .c file with instructions on how to reproduce the crash. Thanks, --Juan

1 0

Re: winemp3: a fix for security alert CVE-2006-1655
by Juan Lang Aug. 7, 2009

Aug. 7, 2009

Hi Aric, I'm not trying to correct you here, I just don't understand a comment, so I'm asking for clarification: + int idx; + if(sfb > 21) return; /* similarity fix related to CVE-2006-1655 */ What is a "similarity fix"? Or did you mean "similar to fix for CVE..." instead? Thanks, --Juan

2 2

Re: [3/3] user32/tests: Add tests for SendInput with unicode
by Dmitry Timoshkov Aug. 7, 2009

Aug. 7, 2009

"Andrew Eikum" <aeikum(a)codeweavers.com> wrote: > --- > dlls/user32/tests/input.c | 210 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 210 insertions(+), 0 deletions(-) It would be more natural and would simplify the code to add these tests to msg.c. Also, please try to avoid names like g_keyStatus, lastKeyDown, UnicodeWndProc and similar. key_status, last_key_down, unicode_wnd_proc look much more readable. -- Dmitry.

2 1

Re: secur32: Implement QueryContextAttributes for SECPKG_ATTR_CONNECTION_INFO
by Henri Verbeet Aug. 7, 2009

Aug. 7, 2009

2009/8/7 Juan Lang <juan.lang(a)gmail.com>: >+ return SEC_E_UNSUPPORTED_FUNCTION; Is this return value intentional?

2 1

Re: [PATCH 3/5] wined3d: Merge the context->current_rt check for rendertarget readback with the code above.
by Stefan Dösinger Aug. 7, 2009

Aug. 7, 2009

Am Friday 07 August 2009 08:51:20 schrieb Henri Verbeet: > - * 3) lastActiveRenderTarget != target && oldTid != newTid: > - * This is tricky. We have to get a context with the old drawable I don't see anything wrong with this patch in particular(so go ahead and apply it), but I am wondering how the case of switching the render target from a new thread works with the new TLS-based context management. My guess is that the problem is not applicable any longer, since there isn't really such a thing as thread switching any more. Its just a new render target for the other thread. Is that right? Or are there any other considerations for this case? Now it hurts that I didn't write a test for this special case when I fixed it a while ago - I don't even remember which game triggered it - maybe Age of Empires 3, but I am not sure.

2 1

Re: comctl32: fix pressed button theming
by Dmitry Timoshkov Aug. 7, 2009

Aug. 7, 2009

"André Hentschel" <nerv(a)dawncrow.de> wrote: > --- a/dlls/comctl32/theme_button.c > +++ b/dlls/comctl32/theme_button.c > @@ -30,8 +30,22 @@ > #include "uxtheme.h" > #include "tmschema.h" > #include "comctl32.h" > +#include "wine/winuser16.h" I very much doubt that win16 apps have an idea about theming, or BM_SETSTATE16 is supposed to be handled by comctl32. -- Dmitry.

1 0

Re: [lostwages] Set about page to use h3 instead of h2 as text is too large
by Yuri Khan Aug. 7, 2009

Aug. 7, 2009

On Thu, Aug 6, 2009 at 19:50, Scott Ritchie<scott(a)open-vote.org> wrote: > -<h2>Open Source and User Driven</h2> > +<h3>Open Source and User Driven</h3> Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS.

2 1

Request for vista testing
by Mike Kaplinskiy Aug. 7, 2009

Aug. 7, 2009

Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike.

1 0

Re: kernel32/nls/winerr: Add Russian translation [try 2]
by Dmitry Timoshkov Aug. 7, 2009

Aug. 7, 2009

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Thanks for suggestions. > > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc Please stop. This is not a translation. I'd suggest to stop accepting your other "translations" and patches as well. -- Dmitry.

1 0

Re: [1/2] shdocvw: Added support for IAdviseSink (resend)
by Alistair Leslie-Hughes Aug. 6, 2009

Aug. 6, 2009

Hi, Could I get some feedback on this patch please? Best Regards Alistair Leslie-Hughes Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: Added support for IAdviseSink > > Best Regards > Alistair Leslie-Hughes > >

2 1

Re: [6/8] WineD3D: Return a different success value if D3D is not available
by Henri Verbeet Aug. 6, 2009

Aug. 6, 2009

Aside from the fact that you can't know WineDirect3DCreate() failed because of a lack of OpenGL without looking at its implementation, I liked the create flags approach better.

2 7

Re: kernel32/nls/winerror: Add Russian translation
by Frédéric Delanoy Aug. 6, 2009

Aug. 6, 2009

2009/8/6 Vladimir Pankratov <scriptkid(a)mail.ru>: > Hello all. > > Added Russian translation. > > Changed files: > > dlls/kernel32/nls/winerror_rus.mc > dlls/kernel32/Makefile.in > > Thanks. Message id 1221 is missing. File changed/created is winerr_rus.mc, not winerror_rus.mc BTW

1 1

Re: kernel32: Revise SetThreadIdealProcessor to return success.
by Alexandre Julliard Aug. 6, 2009

Aug. 6, 2009

Andrew Nguyen <arethusa26(a)gmail.com> writes: > The image deblurring tool in bug 19548 tries to use > SetThreadIdealProcessor on multi-core systems and checks the result of > the call, which causes the application to fail. Simply reporting > success in this case allows the application to run, and is perfectly > harmless. It breaks the tests. -- Alexandre Julliard julliard(a)winehq.org

1 0