September 2009 - Wine-Devel

Re: CPPCheck Sept 8 GIT
by Marcus Meissner Sept. 9, 2009

Sept. 9, 2009

On Tue, Sep 08, 2009 at 07:21:03PM -0700, chris ahrendt wrote: > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) > Deallocating a deallocated pointer: stream2 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource > leak: stream3 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource > leak: stream4 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) > Memory leak: mem > [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource > leak: old_cwd > [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd > [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource > leak: fd_cwd > [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible > error) Array index out of bounds > [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:146]: (error) Resource > leak: mixer > [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:208]: (error) Resource > leak: mixer These were committed yesterday ... Did you run before the large commit or afterwards? Ciao, marcus

1 0

Re: [ntdll, cmd] Implement file attributes with xattr on mac and linux (fixes bug 15679)
by Kai Blin Sept. 8, 2009

Sept. 8, 2009

On Tuesday 08 September 2009 16:11:06 Dan Kegel wrote: > This patch uses filesystem extended attributes in > a way compatible with Samba 3 to store the win32 attribute bits. > It builds and runs on mac and linux, passes tests on linux and vista, > and should be easy-ish to port to solaris (though who knows > what xattr solaris' native cifs server uses, hopefully it's the > same as what samba 3 does). As JRA already replied with more Samba3-specific things, just a word about the Samba4 handling. In the last months, we've been working on getting more and more features of Samba3 and Samba4 use the same codebase or at least behave the same way. There's a good chance that both implementations will converge to one sort of behavior, so if we get that implemented we should be fine. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER
by Nicholas LaRoche Sept. 8, 2009

Sept. 8, 2009

I ran into a bug last week regarding the lack of SIO_GET_EXTENSION_FUNCTION_POINTER support in WSAIoctl. Are there any outstanding issues preventing it's implementation? Perhaps if anyone has worked in this area, are there any things I should look out for when trying to implement it? At first glance it looks like returning an arbitrary pointer may prove tricky since wine likes to relocate DLLs to unpredictable addresses at runtime. (i.e. kernel32.dll is not predictably mapped to a single address as with Windows XP; turning off ASR for the current shell has no effect) -Nick

2 5

Re: [3/3]msctf/tests: test ITfThreadMgr::AssociateFocus
by Paul Vriens Sept. 8, 2009

Sept. 8, 2009

On 09/01/2009 02:08 PM, Aric Stewart wrote: > --- > dlls/msctf/tests/inputprocessor.c | 141 > ++++++++++++++++++++++++++++++++++++- > 1 files changed, 139 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, This one introduced some test failures on Vista and higher. Could you have a look? -- Cheers, Paul.

2 1

Re: [wined3d][1/3] Allow infinity count of backbuffers in IWineD3DDeviceImpl_CreateSwapChain()
by Henri Verbeet Sept. 8, 2009

Sept. 8, 2009

- Please don't use TCHAR etc. in Wine. - You still didn't prove you need to copy the data for each backbuffer. - You still have whitespace errors.

1 0

[RFC] Implement file attributes with xattr on mac and linux (fixes bug 15679)
by Dan Kegel Sept. 8, 2009

Sept. 8, 2009

Builds and runs on mac and linux, passes tests on linux and vista. Fixes http://bugs.winehq.org/show_bug.cgi?id=15679 It's worth discussing a bit before posting to wine-patches. This patch uses filesystem extended attributes to store the win32 attribute bits. These are available fairly widely finally - I think current Linux, Mac, and Solaris all support some form of extended attributes. Because the extended attribute API varies somewhat wildly between operating systems, I went whole-hog and used autoconf to detect the differences between the api on linux and macosx. Somebody else should be able to add solaris support without much difficulty if this is approved. The convention chosen is that the win32 file attributes are stored as a four digit hex number in the extended attribute named user.wine.attr. (The 'user' prefix is suggested by http://www.freedesktop.org/wiki/CommonExtendedAttributes .) For backwards compatibility, if a native file lacks extended attributes; it is reported as having ARCHIVE attribute. Likewise, if a file just has the ARCHIVE attribute set, there is no native extended attribute. Here's an example: touch foo.dat wine cmd /c attrib -a foo.dat xattr -l foo.dat This outputs user.wine.attr: 0000 i.e. because the file has anything but the default attribute, we store the entire win32 attribute bitmask in the extended attribute. Another example: touch bar.dat wine cmd /c attrib +s bar.dat xattr -l bar.dat This outputs user.wine.attr: 0024 or ARCHIVE | SYSTEM. This convention should be thought over carefully before we go with it. I also considered using individual xattrs for each attribute bit, but discarded that idea as adding overhead and complexity without any obvious payoff. Finally, the implementation of attrib in cmd is lame -- it only handles two arguments. It's enough for the moment, but the real attrib can handle multiple attribute flags, and we should support that sometime. So, what do folks think? - Dan

2 1

Re: wined3d: Fix vendor detection when using an Intel X4500HD
by Austin English Sept. 8, 2009

Sept. 8, 2009

On Mon, Sep 7, 2009 at 11:52 PM, Jaime Rave<jaimerave(a)gmail.com> wrote: > This patch fix the fixme: > > fixme:d3d_caps:wined3d_guess_vendor Received unrecognized GL_VENDOR > "Tungsten Graphics, Inc". Returning VENDOR_WINE. > > > > Forgot the patch. -- -Austin

1 0

Re: msvcrt: dont overwrite the standard streams (with test, try 5)
by Eric Pouech Sept. 7, 2009

Sept. 7, 2009

André Hentschel a écrit : > Some Apps e.g. mingw-apps use lpReserved2 to pass some data to the child-process, this data starts with 4 Byte of Zeros(unsinged 0) to tell msvcrt not to read that as an inherit-block. > Hi André a couple of comments to your patch > See also Bug 18479 > --- > dlls/msvcrt/file.c | 2 +- > dlls/msvcrt/tests/Makefile.in | 2 +- > dlls/msvcrt/tests/file.c | 50 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 52 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c > index 6671f2f..8f63e8d 100644 > --- a/dlls/msvcrt/file.c > +++ b/dlls/msvcrt/file.c > @@ -349,7 +349,7 @@ void msvcrt_init_io(void) > InitializeCriticalSection(&MSVCRT_file_cs); > MSVCRT_file_cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": MSVCRT_file_cs"); > GetStartupInfoA(&si); > - if (si.cbReserved2 != 0 && si.lpReserved2 != NULL) > + if (si.cbReserved2 != 0 && si.lpReserved2 != NULL && *(unsigned*)si.lpReserved2) > IMO, we should also test that cbReserved2 is >= sizeof(unsigned) otherwise we'd be in trouble > { > char* wxflag_ptr; > HANDLE* handle_ptr; > diff --git a/dlls/msvcrt/tests/Makefile.in b/dlls/msvcrt/tests/Makefile.in > index 74199e1..8c71971 100644 > --- a/dlls/msvcrt/tests/Makefile.in > +++ b/dlls/msvcrt/tests/Makefile.in > @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = msvcrt.dll > APPMODE = -mno-cygwin > -IMPORTS = kernel32 > +IMPORTS = kernel32 user32 > you should do it without user32. instead of doing this > + while (MsgWaitForMultipleObjects( 1, &proc.hProcess, FALSE, INFINITE, QS_ALLINPUT ) != 0) > + { > + while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg); > + } > you could simply wait for the child process to terminate A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Re: [5/5] WineD3D: Use GL_ATI_meminfo if available
by Henri Verbeet Sept. 7, 2009

Sept. 7, 2009

2009/9/5 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* All GL_ATI_meminfo enums return 4 ints, even the (undocumented) > + * GL_TOTAL_PHYSICAL_MEMORY_ATI one, which returns {mem, 0, 0, 0} */ > + GLint mem[4]; > + /* Returns the vidmem in KB */ > + glGetIntegerv(GL_TOTAL_PHYSICAL_MEMORY_ATI, mem); > + checkGLcall("glGetIntegerv(GL_TOTAL_PHYSICAL_MEMORY_ATI, mem)"); > + > + /* The first driver version that supports ATI_meminfo doesn't implement > + * GL_TOTAL_PHYSICAL_MEMORY_ATI - catch this situation as adviced by AMD > + */ > + if(mem[0] < 65536) If the implementation doesn't recognise "GL_TOTAL_PHYSICAL_MEMORY_ATI" you're testing uninitialized memory here. I hope AMD didn't actually advice you to code it like that.

3 4

Finding IDB_VIEW_SMALL_COLOR
by Joel Holdsworth Sept. 7, 2009

Sept. 7, 2009

Hi All, Does anyone know what DLL the image 32-bit version the standard image list IDB_VIEW_SMALL_COLOR is stored in in Windows? You can see some of it in this screenshot: http://www.airwebreathe.org.uk/IDB_VIEW_SMALL_COLOR.png. I might expect it to be in comctl32.dll with the other common image lists... but it's not - only the old 4-bit version of the image. Does anyone know where the 32-bit one is? Thanks Joel

3 3

Re: ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD
by James McKenzie Sept. 6, 2009

Sept. 6, 2009

Stephan Rose wrote: > Sets up DDPixelFormat for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM formats. > > Fixes errors in the game http://www.alawar.com/game/tikibar/ that keep it from running due missing pixel format conversions of the above bump map formats. Stephan: You have trailing spaces in the break; line. Please remove them. James McKenzie + DDPixelFormat->u5.dwLuminanceAlphaBitMask = 0x000000FF; + break; + case WINED3DFMT_R16G16_SNORM:

1 0

Re: [4/5] WineD3D: Add GL_ATI_meminfo to the extension table
by Henri Verbeet Sept. 6, 2009

Sept. 6, 2009

2009/9/5 Stefan Dösinger <stefan(a)codeweavers.com>: > So far ATI hasn't updated the extension spec, but the code works nevertheless, > and I don't have any problem with using this functionality if available. > The implication is that when someone implements ATI_meminfo as documented in the actual spec it won't work properly with Wine. I don't think we really want to go there. I'm also not sure it's even possible to introduce additional tokens into already published extensions, so I expect this will need a new extension anyway.

1 0

Re: ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD
by Henri Verbeet Sept. 6, 2009

Sept. 6, 2009

2009/9/3 Stephan Rose <kermos(a)somrek.net>: > + case WINED3DFMT_R8G8B8A8_SNORM: > + DDPixelFormat->dwFlags = DDPF_BUMPDUDV; > + DDPixelFormat->dwFourCC = 0; > + DDPixelFormat->u1.dwBumpBitCount = 32; > + DDPixelFormat->u2.dwBumpDuBitMask = 0xFF000000; > + DDPixelFormat->u3.dwBumpDvBitMask = 0x00FF0000; > + DDPixelFormat->u4.dwBumpLuminanceBitMask = 0x0000FF00; > + DDPixelFormat->u5.dwLuminanceAlphaBitMask = 0x000000FF; > + break; > + case WINED3DFMT_R16G16_SNORM: > + DDPixelFormat->dwFlags = DDPF_BUMPDUDV; > + DDPixelFormat->dwFourCC = 0; > + DDPixelFormat->u1.dwBumpBitCount = 32; > + DDPixelFormat->u2.dwBumpDuBitMask = 0xFFFF0000; > + DDPixelFormat->u3.dwBumpDvBitMask = 0x0000FFFF; > + DDPixelFormat->u4.dwBumpLuminanceBitMask = 0x00000000; > + DDPixelFormat->u5.dwLuminanceAlphaBitMask = 0x00000000; > + break; I think you have the masks backwards. You also have some trailing spaces in there.

1 0

Re: [PATCH 0/3] Make GetAsyncKeyState really Async (now it checks current window only)
by Tom Wickline Sept. 6, 2009

Sept. 6, 2009

You forgot the patch :) 2009/9/6 Rafał Miłecki <zajec5(a)gmail.com> > Hi, > > This patchset fixes bug #5623 [1]. I've tested this with EasyUO app > and other random apps run in the same wineserver. > > I've run tests in user32 to check for regressions, no changes. I've > checked compilation & user32's test after applying each patch. > > Hope everything is alright with this patchset. > > [1] http://bugs.winehq.org/show_bug.cgi?id=5623 > > -- > Rafał Miłecki > > >

2 1

Re: Game Engine
by Ben Klein Sept. 6, 2009

Sept. 6, 2009

2009/9/6 Keith Muir <keith.muir(a)blueyonder.co.uk>: > My understanding is that all Total War games work off the Rome Total War > engine and you are correct the wine project under no circumstances should it > focus on individual applications. That said if there is a game engine which > several games use in this case fixing the problems the engine has will fix > multiple games. So the justification is there. Also I am the maintainer for > Medieval II and no it doest work well. > Patches are welcome, but it's very unlikely that the main development team will be able to spend time/effort fixing problems for a single game (or series of games). If coding for Wine is not your forte, there are other things you can do to try to get bugs fixed. At the very least, if there are no relevant reports on bugs.winehq.org, you can report the bugs. If the games are toggling between Garbage and Silver, then regression tests would be useful.

2 1

re: winex11: fix Steam color regression
by Dan Kegel Sept. 6, 2009

Sept. 6, 2009

wineconsole also became invisible with that regression. Your patch fixes it, thank goodness.

2 1

Game Engine
by Keith Muir Sept. 5, 2009

Sept. 5, 2009

Hi, The Total war engine continues to bounce between garbage and silver never rising above that level given the installed user base would it be worth devoting more time to fixing the problems wine has with this? as of 1.29 its freezing and unusable. Wine project has to prioritize but success drives the project when people hear they can now do this or that that they couldn't before everyone is inspired its a virtuous circle. Regards, Keith

2 1

Re: Is Wine printing on MacOSX?
by James Mckenzie Sept. 4, 2009

Sept. 4, 2009

On Fri, Sep 4, Roderick Colenbrander <thunderbird2k(a)gmail.com> > >On Fri, Sep 4, 2009 at 7:04 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: >> On Wed, Sep 2, 2009 at 12:15 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: >>> Hi, >>> >>> although wine in MacOSX works generally good enough (see test.winehq.org about >>> release 1.1.28), I recently visited the print menu in notepad and wordpad to >>> see whether printing would work (in order to complete the FAQ). >>> >>> All that happened is that the printer ejected a blank page. >>> >> >> Don't expect printing to work in wordpad for now. The EM_FORMATRANGE >> message is used in wordpad to do printing, and that isn't implemented >> yet. >> >> I think notepad should work though, since it is using ExtTextOut. >> >> >> > >I have been able to print from Wine apps in OSX though I'm still >having some issues which I did not investigate yet. The issue is that >when I print from my app which uses non-standard fonts with some >integral / summation symbols that those symbols are lost during the >printing and that a 'square' is shown instead. I don't see this issue >on Linux. > Interesting. I was going to comment that the EM_FORMATRANGE problem may be the cause, but this may be due to the CUPS implementation or some other reason on the Mac. Unfortunately, my only printer, which was an inkjet, would have cost as much to repair as it would to buy a new one. I guess it may be time to buy another, but this time its going to be a laser, not ink. James McKenzie

2 1

CPP Run for Sept 3
by chris ahrendt Sept. 4, 2009

Sept. 4, 2009

[../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [../wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [../wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [../wine-git/dlls/wineoss.drv/mmaux.c:150]: (error) Resource leak: mixer [../wine-git/dlls/wineoss.drv/mmaux.c:211]: (error) Resource leak: mixer [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [../wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [../wine-git/tools/makedep.c:953]: (error) Resource leak: file [../wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [../wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [../wine-git/tools/winedump/msmangle.c:164]: (error) Memory leak: function_name [../wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map Chris

2 1

Re: winebrowser: Fix broken handling of DDE type XTYP_EXECUTE
by Paul Chitescu Sept. 4, 2009

Sept. 4, 2009

On Wednesday 02 September 2009 04:15:22 Peter Dons Tychsen wrote: > XTYPE_EXECUTE DDE transaction for winebrowser is broken. > The handler currently expects a MultiByte character input, which is > wrong. > > The handler is win-unicode, and will always receive such strings. > The encoding of the string can be seen in WDML_BuildExecuteCommand(). > > This fixes programs which use DDE to show a web-link via winebrowser, > e.g. the "Last Chaos" web-installer: > http://lastchaos.aeriagames.com/download > > Thanks, > > /pedro This has been talked about before and an even safer solution was refused: http://www.mail-archive.com/wine-devel(a)winehq.org/msg50183.html http://www.mail-archive.com/wine-devel(a)winehq.org/msg50224.html Unfortunately there is no equivalent in Windows of what Wine does. Windows seems to pass around ATOMs as either ANSI (Win 9x, ME) or UCS-2 (NT3x, NT4) or UTF-16 (2000+) depending on version. Wine tries to do it at runtime depending on the Windows version it emulates - and that is per process. ANSI programs actually succeed in starting winebrowser because they send MBCS to it.

1 0

Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 4, 2009

Sept. 4, 2009

Hi, although wine in MacOSX works generally good enough (see test.winehq.org about release 1.1.28), I recently visited the print menu in notepad and wordpad to see whether printing would work (in order to complete the FAQ). All that happened is that the printer ejected a blank page. Was anyone more successful than me at printing? - My printer appears in Notepad's and Wordpad's menus, so that's a start. - The page size and portrait/landscape selection dialogue appears. - The OSX printer status shows something is happening. - However the printer only ejects a blank page. - The console shows no particular log line. o Do my troubles arise from the fact that I compile Wine only with standard MacOS libraries? E.g. liblcms (color management) is missing from my system (but no error message signals that it would have been used at run-time). o Should I have tried a "real" app instead of (fake) notepad? Using Mac OS X 10.5.7 and wine compiled myself (see Wiki.winehq.org about how). Regards, Jörg Höhle

3 2

Re: urlmon: Add test for IsValidURL [try 2]
by Vladimir Pankratov Sept. 4, 2009

Sept. 4, 2009

Hello all. What do you think about this? What's wrong in this patch? Any comments? Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > Now test shows error codes and tests exact code. > > Thanks Jacek. > > changed files: > dlls/urlmon/tests/misc.c > > Thanks. > > > > > ------------------------------------------------------------------------ > > diff -u -r a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/misc.c > --- a/dlls/urlmon/tests/misc.c 2009-08-21 23:34:16.000000000 +0500 > +++ b/dlls/urlmon/tests/misc.c 2009-09-01 18:53:08.000000000 +0500 > @@ -1326,6 +1326,44 @@ > IBindCtx_Release(bctx); > } > > +static void test_IsValidURL(void) > +{ > + HRESULT hr; > + int i; > + static const WCHAR good_urls[][100] = { > + {'f','i','l','e',':','/','/','c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'h','t','t','p',':','/','/','w','w','w','.','w','i','n','e','h','q','.','o','r','g',0}, > + {'h','t','t','p','s',':','/','/','s','e','c','u','r','e','.','h','o','s','t','.','d','o','m',0}, > + {'f','t','p',':','/','/','s','o','u','r','c','e','f','o','r','g','e','.','o','r','g',0}, > + {'c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'m','k',0}, > + {'h','t','t','p','s',0} > + }; > + static const WCHAR bad_urls[][100] = { > + {'w','i','n','e','h','q','.','o','r','g',0}, > + {'l','o','c','a','l','h','o','s','t',0}, > + {'t','e','s','t',0}, > + {'1','2','7','.','0','.','0','.','1',0}, > + {'b','o','o','t','.','i','n','i',0} > + }; > + > + hr = IsValidURL(NULL, 0, 10); > + > + ok(hr == E_INVALIDARG, "IsValidURL should fail, expected E_INVALIDARG, got %08x.\n", hr); > + > + for(i = 0; i < sizeof(good_urls)/sizeof(good_urls[0]); i++) > + { > + hr = IsValidURL(NULL, good_urls[i], 0); > + ok(hr == S_OK, "URL %s must be valid, expected S_OK, got %08x.\n", wine_dbgstr_w(good_urls[i]), hr); > + } > + > + for(i = 0; i < sizeof(bad_urls)/sizeof(bad_urls[0]); i++) > + { > + hr = IsValidURL(NULL, bad_urls[i], 0); > + ok(hr == S_FALSE, "URL %s must be invalid, expected S_FALSE, got %08x.\n", wine_dbgstr_w(bad_urls[i]), hr); > + } > +} > + > START_TEST(misc) > { > OleInitialize(NULL); > @@ -1345,6 +1383,7 @@ > test_UrlMkGetSessionOption(); > test_user_agent(); > test_MkParseDisplayNameEx(); > + todo_wine test_IsValidURL(); > > OleUninitialize(); > }

2 1

Re: gdi32/tests: Add test for SelectClipRgn in metafile
by Dmitry Timoshkov Sept. 4, 2009

Sept. 4, 2009

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + hdc = CreateEnhMetaFileA(0, NULL, NULL, NULL); > + > + SetRect(&rc_sclip, 100, 100, GetSystemMetrics(SM_CXSCREEN), GetSystemMetrics(SM_CYSCREEN)); > + hrgn = CreateRectRgn(rc_sclip.left, rc_sclip.top, rc_sclip.right, rc_sclip.bottom); > + SelectClipRgn(hdc, hrgn); > + GetClipBox(hdc, &rc_res); > + todo_wine ok(EqualRect(&rc_res, &rc_sclip), > + "expected rc_res (%d, %d) - (%d, %d), got (%d, %d) - (%d, %d)\n", > + rc_sclip.left, rc_sclip.top, rc_sclip.right, rc_sclip.bottom, > + rc_res.left, rc_res.top, rc_res.right, rc_res.bottom); > + > + CloseEnhMetaFile(hdc); > + DeleteObject(hrgn); You are leaking a metafile here. -- Dmitry.

1 0

font-shape/font-query related regression in wine 1.1.28
by Hin-Tak Leung Sept. 3, 2009

Sept. 3, 2009

My favourite mono/.net application dies with 'Style Regular isn't supported by font Tahoma' in 1.1.28. I did a git bisect and commit 0b9ba054f6c8a2d96c898e7325087f56a6224644 Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Aug 12 19:19:32 2009 +0200 was the entry that breaks, but just reversing it in 1.1.28 does not fix the problem - i.e. more problematic commits later?; however, replacing the wine-shipped tahoma fonts with those from Vista does cure the problem; so does simply deleting them from $WINEPREFIX/drive_c/windows/fonts (and allow substitution from system fonts happen, I think). I don't know why a german translation would affect my environment (LANG=en_GB.utf8) and setting LANG=C does not fix the problem. In any case, the correct fix is probably working out what vista-shipped tahoma does which differs from wine-shipped tahoma? Anybody has any thought on this issue?

3 4

New winetricks 20090902: new verbs vc2005trial, python26
by Dan Kegel Sept. 3, 2009

Sept. 3, 2009

Another week, another winetricks. The only interesting changes are new verbs vc2005trial and python26. These are only of interest to developers. vc2005trial is the 180 day Team Server edition of Visual C++ 2005. The winetricks verb for this is a bit odd - it prompts you for your password so it can mount the volume before installation. If you have a better idea, please let me know. I haven't done a KDE version of the prompt; patches welcome. I also haven't implemented -q for this; it's hard to figure out, even with hints (see the comments). If anyone wants to tackle it, be my guest, I'd love to have unattended install working. The python26 verb includes pywin32, since that was needed by the script I was trying to run (the gyp self-test). Most people will just use Linux python, but when you're running a win32-specific python script, the windows python interpreter comes in pretty handy. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Thanks to Austin English for various patches and assistance.

2 3

re: Wine t-shirts?
by Dan Kegel Sept. 2, 2009

Sept. 2, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.
by Dylan Smith Sept. 2, 2009

Sept. 2, 2009

On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych <khodych(a)gmail.com> wrote: > @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey) > ME_SendRequestResize(editor, FALSE); > return TRUE; > case VK_RETURN: > + if (editor->bDialogMode) > + { > + DWORD dwStyle; > + > + if (ctrl_is_down) > + return TRUE; > + > + dwStyle = GetWindowLongW(editor->hWnd, GWL_STYLE); > + if (!(dwStyle & ES_WANTRETURN)) > + { > + DWORD dw; > + dw = SendMessageW(editor->hwndParent, DM_GETDEFID, 0, 0); > + if (HIWORD(dw) == DC_HASDEFID) > + { > + HWND hwDefCtrl = GetDlgItem(editor->hwndParent, LOWORD(dw)); > + if (hwDefCtrl) > + { > + SendMessageW(editor->hwndParent, WM_NEXTDLGCTL, (WPARAM)hwDefCtrl, (LPARAM)TRUE); > + PostMessageW(hwDefCtrl, WM_KEYDOWN, VK_RETURN, 0); > + } > + } > + return TRUE; > + } > + } > + > if (editor->styleFlags & ES_MULTILINE) > { > ME_Cursor cursor = editor->pCursors[0]; 1. editor->hWnd may be NULL for windowless richedit controls, but you code doesn't seem to take that into consideration. 2. The style flags that you get from GetWindowLongW should probably come from the cached values in editor->styleFlags. 3. Is there any need for storing the hwndParent in editor. Couldn't the value be obtained by using GetWindowLongW using GWL_HWNDPARENT after making sure that editor->hWnd is non-NULL (i.e. windowed mode).

2 3

Re: [PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.
by Stefan Dösinger Sept. 2, 2009

Sept. 2, 2009

Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet: > + GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB, > GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); + > checkGLcall("glGetProgramivARB()"); > + if (!native) WARN("Program exceeds native resource limits.\n"); > + } shouldn't that be a FIXME? The most likely reasons for this are either that we advertise incorrect caps, or our privately added code breaks the limits, or that the driver is broken. In the first two cases we can do something, and in the other case we might want to report the issue to the driver devs That said, I haven't seen a GL implementation yet that successfully compiles and SW-emulates a program that exceeds the limits.

2 2

Re: gdiplus/tests: Fix test on Win7
by Vincent Povirk Sept. 2, 2009

Sept. 2, 2009

- gdiplusStartupInput.GdiplusVersion = 2; + gdiplusStartupInput.GdiplusVersion = 42; Could you please test the intermediate versions to determine what's supported? You could use a loop to determine the highest supported version (making sure the return is UnsupportedGdiplusVersion if it's not Ok) followed by a test that the highest supported version is between 1 and some constant. In fact, knowing the supported version would be helpful in any case, and it would be nice to have a trace() printing it. On Wed, Sep 2, 2009 at 5:16 AM, Ge van Geldorp<ggeldorp(a)vmware.com> wrote: > Changelog: > gdiplus/tests: Fix test on Win7 > > --- > dlls/gdiplus/tests/pen.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > > > > -- Vincent Povirk

1 1

Re: [PATCH 1/3] jscript: Added to_primitive on hosting objects test.
by Alexandre Julliard Sept. 2, 2009

Sept. 2, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/tests/run.c | 32 ++++++++++++++++++++++++++++---- > 1 files changed, 28 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:216: Test failed: V_VT(pvarRes) = 63784 make[2]: *** [run.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

cpp check run monday Aug 31
by chris ahrendt Sept. 2, 2009

Sept. 2, 2009

I ran CPP check against the monday git tree using the latest CPP check off their git tree. here is the result : [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:320]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:340]: (error) Division by zero [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:842]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:843]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:863]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:337]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:218]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:219]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:240]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:241]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:150]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:211]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 [/home/cahrendt/wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/makedep.c:953]: (error) Resource leak: file [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/msmangle.c:164]: (possible error) Memory leak: function_name [/home/cahrendt/wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map chris

3 3

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English Sept. 1, 2009

Sept. 1, 2009

On Tue, Sep 1, 2009 at 3:23 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..8ced1d6 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..bff1571 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > > > > > > Works for PPC. -- -Austin

1 0

Re: [PATCH 09/10] mshtml: Added function object tests.
by Paul Vriens Sept. 1, 2009

Sept. 1, 2009

Jacek Caban wrote: > --- > dlls/mshtml/tests/script.c | 99 > +++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 98 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Looks like this patch introduced test failures on IE6 and IE7 (only? as a box with IE5 succeeded and IE8 seems ok as well). Could you have a look? -- Cheers, Paul.

2 1

Re: urlmon: Add test for IsValidURL
by Jacek Caban Sept. 1, 2009

Sept. 1, 2009

Hi Vladimir, Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > changed files: > dlls/urlmon/tests/misc.c + { + hr = IsValidURL(NULL, bad_urls[i], 0); + ok(hr != S_OK, "URL %s must be invalid\n", wine_dbgstr_w(bad_urls[i])); It would be better to test the exact error code here. Jacek

1 0

Re: [PATCH 1/7] dpwsockx: Stub implementation
by Henri Verbeet Sept. 1, 2009

Sept. 1, 2009

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > --- > dlls/dpwsockx/Makefile.in | 2 +- > dlls/dpwsockx/dpwsockx_main.c | 164 ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 163 insertions(+), 3 deletions(-) > This patch seems to assume the application will never pass NULL for "data", is that safe to assume? If applications aren't allowed to pass NULL it's ok to crash, although it might make your life simpler if it isn't inside a TRACE/FIXME.

2 1

Re: [PATCH 4/4] openal32: Add thunks for EFX functions
by Henri Verbeet Sept. 1, 2009

Sept. 1, 2009

I suppose 32-bit reads are atomic on x86, provided the variable is aligned correctly, but shouldn't access to CurrentCtx technically be synchronized?

2 1

Re: shlwapi: Implement stubs for missing functions required by IE6
by Dmitry Timoshkov Aug. 31, 2009

Aug. 31, 2009

"Owen Rudge" <orudge(a)codeweavers.com> wrote: > +HRESULT WINAPI IUnknown_UIActivateIO(IUnknown *lpUnknown, BOOL fActivate, LPMSG lpMsg) > +HRESULT WINAPI SHCreatePropertyBagOnRegKey (HKEY hKey, LPCWSTR pszSubKey, > + DWORD grfMode, REFIID riid, void **ppv) > +HRESULT WINAPI SHGetViewStatePropertyBag(LPCITEMIDLIST pidl, LPWSTR lpszBagName, > +INT WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *fileTime, DWORD *flags, > +INT WINAPI SHFormatDateTimeA(const FILETIME UNALIGNED *fileTime, DWORD *flags, It's better to send separate patches for each of the APIs and avoid hungarian notation as much as possible -- Dmitry.

1 0

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by James Mckenzie Aug. 31, 2009

Aug. 31, 2009

> >Fixed a small typing error in the italian translation of clock.exe in >the property menu label (Properietà -> Proprietà). >Compiled and tested correctly on Ubuntu 9.04 64bit. > >(My first patch I send, so please be kind for any error, I'll be happy >to correct it if pointed to, thanks) > >P.S.: For some reason the previous mail attachment showed up empty in >the archives list, even if sent mail is correct, and using Thunderbird I >prefer not to paste it int he message body. Sorry for double sending. Riccardo: Please look at the processed mail message before sending to make sure that your patch is an attachment and not bound in-line. Thunderbird likes to do this to text attachments, so you might want to change the extension to .patch or .diff so Thunderbird will not do this. I did not have this problem with using git when git was configured per the GitWine page on the Wiki. James McKenzie

2 4

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English Aug. 31, 2009

Aug. 31, 2009

On Mon, Aug 31, 2009 at 3:02 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..5f40f71 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..c2bc431 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } These all work fine on PPC. > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } Still got a warning here. -- -Austin

1 0