September 2009 - Wine-Devel

re: Wine t-shirts?
by Dan Kegel Sept. 2, 2009

Sept. 2, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.
by Dylan Smith Sept. 2, 2009

Sept. 2, 2009

On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych <khodych(a)gmail.com> wrote: > @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey) > ME_SendRequestResize(editor, FALSE); > return TRUE; > case VK_RETURN: > + if (editor->bDialogMode) > + { > + DWORD dwStyle; > + > + if (ctrl_is_down) > + return TRUE; > + > + dwStyle = GetWindowLongW(editor->hWnd, GWL_STYLE); > + if (!(dwStyle & ES_WANTRETURN)) > + { > + DWORD dw; > + dw = SendMessageW(editor->hwndParent, DM_GETDEFID, 0, 0); > + if (HIWORD(dw) == DC_HASDEFID) > + { > + HWND hwDefCtrl = GetDlgItem(editor->hwndParent, LOWORD(dw)); > + if (hwDefCtrl) > + { > + SendMessageW(editor->hwndParent, WM_NEXTDLGCTL, (WPARAM)hwDefCtrl, (LPARAM)TRUE); > + PostMessageW(hwDefCtrl, WM_KEYDOWN, VK_RETURN, 0); > + } > + } > + return TRUE; > + } > + } > + > if (editor->styleFlags & ES_MULTILINE) > { > ME_Cursor cursor = editor->pCursors[0]; 1. editor->hWnd may be NULL for windowless richedit controls, but you code doesn't seem to take that into consideration. 2. The style flags that you get from GetWindowLongW should probably come from the cached values in editor->styleFlags. 3. Is there any need for storing the hwndParent in editor. Couldn't the value be obtained by using GetWindowLongW using GWL_HWNDPARENT after making sure that editor->hWnd is non-NULL (i.e. windowed mode).

2 3

Re: [PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.
by Stefan Dösinger Sept. 2, 2009

Sept. 2, 2009

Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet: > + GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB, > GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); + > checkGLcall("glGetProgramivARB()"); > + if (!native) WARN("Program exceeds native resource limits.\n"); > + } shouldn't that be a FIXME? The most likely reasons for this are either that we advertise incorrect caps, or our privately added code breaks the limits, or that the driver is broken. In the first two cases we can do something, and in the other case we might want to report the issue to the driver devs That said, I haven't seen a GL implementation yet that successfully compiles and SW-emulates a program that exceeds the limits.

2 2

Re: gdiplus/tests: Fix test on Win7
by Vincent Povirk Sept. 2, 2009

Sept. 2, 2009

- gdiplusStartupInput.GdiplusVersion = 2; + gdiplusStartupInput.GdiplusVersion = 42; Could you please test the intermediate versions to determine what's supported? You could use a loop to determine the highest supported version (making sure the return is UnsupportedGdiplusVersion if it's not Ok) followed by a test that the highest supported version is between 1 and some constant. In fact, knowing the supported version would be helpful in any case, and it would be nice to have a trace() printing it. On Wed, Sep 2, 2009 at 5:16 AM, Ge van Geldorp<ggeldorp(a)vmware.com> wrote: > Changelog: > gdiplus/tests: Fix test on Win7 > > --- > dlls/gdiplus/tests/pen.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > > > > -- Vincent Povirk

1 1

Re: [PATCH 1/3] jscript: Added to_primitive on hosting objects test.
by Alexandre Julliard Sept. 2, 2009

Sept. 2, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/tests/run.c | 32 ++++++++++++++++++++++++++++---- > 1 files changed, 28 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:216: Test failed: V_VT(pvarRes) = 63784 make[2]: *** [run.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

cpp check run monday Aug 31
by chris ahrendt Sept. 2, 2009

Sept. 2, 2009

I ran CPP check against the monday git tree using the latest CPP check off their git tree. here is the result : [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:320]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:340]: (error) Division by zero [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:842]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:843]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:863]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:337]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:218]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:219]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:240]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:241]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:150]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:211]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 [/home/cahrendt/wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/makedep.c:953]: (error) Resource leak: file [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/msmangle.c:164]: (possible error) Memory leak: function_name [/home/cahrendt/wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map chris

3 3

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English Sept. 1, 2009

Sept. 1, 2009

On Tue, Sep 1, 2009 at 3:23 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..8ced1d6 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..bff1571 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > > > > > > Works for PPC. -- -Austin

1 0

Re: [PATCH 09/10] mshtml: Added function object tests.
by Paul Vriens Sept. 1, 2009

Sept. 1, 2009

Jacek Caban wrote: > --- > dlls/mshtml/tests/script.c | 99 > +++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 98 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Looks like this patch introduced test failures on IE6 and IE7 (only? as a box with IE5 succeeded and IE8 seems ok as well). Could you have a look? -- Cheers, Paul.

2 1

Re: urlmon: Add test for IsValidURL
by Jacek Caban Sept. 1, 2009

Sept. 1, 2009

Hi Vladimir, Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > changed files: > dlls/urlmon/tests/misc.c + { + hr = IsValidURL(NULL, bad_urls[i], 0); + ok(hr != S_OK, "URL %s must be invalid\n", wine_dbgstr_w(bad_urls[i])); It would be better to test the exact error code here. Jacek

1 0

Re: [PATCH 1/7] dpwsockx: Stub implementation
by Henri Verbeet Sept. 1, 2009

Sept. 1, 2009

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > --- > dlls/dpwsockx/Makefile.in | 2 +- > dlls/dpwsockx/dpwsockx_main.c | 164 ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 163 insertions(+), 3 deletions(-) > This patch seems to assume the application will never pass NULL for "data", is that safe to assume? If applications aren't allowed to pass NULL it's ok to crash, although it might make your life simpler if it isn't inside a TRACE/FIXME.

2 1

Re: [PATCH 4/4] openal32: Add thunks for EFX functions
by Henri Verbeet Sept. 1, 2009

Sept. 1, 2009

I suppose 32-bit reads are atomic on x86, provided the variable is aligned correctly, but shouldn't access to CurrentCtx technically be synchronized?

2 1

Re: shlwapi: Implement stubs for missing functions required by IE6
by Dmitry Timoshkov Aug. 31, 2009

Aug. 31, 2009

"Owen Rudge" <orudge(a)codeweavers.com> wrote: > +HRESULT WINAPI IUnknown_UIActivateIO(IUnknown *lpUnknown, BOOL fActivate, LPMSG lpMsg) > +HRESULT WINAPI SHCreatePropertyBagOnRegKey (HKEY hKey, LPCWSTR pszSubKey, > + DWORD grfMode, REFIID riid, void **ppv) > +HRESULT WINAPI SHGetViewStatePropertyBag(LPCITEMIDLIST pidl, LPWSTR lpszBagName, > +INT WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *fileTime, DWORD *flags, > +INT WINAPI SHFormatDateTimeA(const FILETIME UNALIGNED *fileTime, DWORD *flags, It's better to send separate patches for each of the APIs and avoid hungarian notation as much as possible -- Dmitry.

1 0

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by James Mckenzie Aug. 31, 2009

Aug. 31, 2009

> >Fixed a small typing error in the italian translation of clock.exe in >the property menu label (Properietà -> Proprietà). >Compiled and tested correctly on Ubuntu 9.04 64bit. > >(My first patch I send, so please be kind for any error, I'll be happy >to correct it if pointed to, thanks) > >P.S.: For some reason the previous mail attachment showed up empty in >the archives list, even if sent mail is correct, and using Thunderbird I >prefer not to paste it int he message body. Sorry for double sending. Riccardo: Please look at the processed mail message before sending to make sure that your patch is an attachment and not bound in-line. Thunderbird likes to do this to text attachments, so you might want to change the extension to .patch or .diff so Thunderbird will not do this. I did not have this problem with using git when git was configured per the GitWine page on the Wiki. James McKenzie

2 4

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English Aug. 31, 2009

Aug. 31, 2009

On Mon, Aug 31, 2009 at 3:02 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..5f40f71 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..c2bc431 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } These all work fine on PPC. > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } Still got a warning here. -- -Austin

1 0