September 2009 - Wine-Devel

Re: [try 3] comctl32: Implement highlighting (marquee) selection support in listview
by Nikolay Sivov Sept. 21, 2009

Sept. 21, 2009

Owen Rudge wrote: > Minor update, rename some potentially confusing comments/variables. > > --- > dlls/comctl32/listview.c | 135 > ++++++++++++++++++++++++++++++++++++++++----- > 1 files changed, 120 insertions(+), 15 deletions(-) + /* Draw focus rect if highlighting */ + if (infoPtr->bHighlighting) + DrawFocusRect(hdc, &infoPtr->marqueeRect); + :). Now we have 3 different names for a single thing.

2 1

Re: mshtml / shdocv / urlmon tests hanging?
by Dan Kegel Sept. 21, 2009

Sept. 21, 2009

Without. Thanks, I'll rerun tonight. On Sep 21, 2009 8:05 AM, "Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: On 09/21/2009 04:32 PM, Dan Kegel wrote: > > Doing a full test with my xattr patches, I saw hangs > ... With or without Gecko installed? -- Cheers, Paul.

1 0

Re: [try 2] comctl32: Implement highlighting (marquee) selection support in listview
by Nikolay Sivov Sept. 21, 2009

Sept. 21, 2009

Owen Rudge wrote: > This patch adds support for selecting multiple items in a > multi-selection listview using the mouse (by dragging and > highlighting). It has been reimplemented in a more efficient manner > compared to the previous patches. > > --- > dlls/comctl32/listview.c | 135 > ++++++++++++++++++++++++++++++++++++++++----- > 1 files changed, 120 insertions(+), 15 deletions(-) Hi again. Didn't test it actually but it looks definitely better without extra cycles and state caching, thanks for that. I suggest another simple naming improvement: you're mixing different things in comments and naming, it looks confusing now. --- + BOOL bHighlighting; + RECT highlightRect; --- I suggest something like marqueeRect name here cause item itself has a state flag called LVIS_DROPHILITED which has nothing to do with this rectangle obviously. --- + /* Cancel out the old focus rectangle and draw the new one */ + LISTVIEW_InvalidateRect(infoPtr, &infoPtr->highlightRect); --- Focus rectangle is an item focus bounds in current naming, so comment is a bit confusing here. --- + /* Draw focus rect if highlighting */ + if (infoPtr->bHighlighting) + DrawFocusRect(hdc, &infoPtr->highlightRect); ... + /* Remove the focus rectangle */ + if (infoPtr->bHighlighting) + LISTVIEW_InvalidateRect(infoPtr, &infoPtr->highlightRect); --- Same here, it isn't a focus rectangle. Regards.

2 1

mshtml / shdocv / urlmon tests hanging?
by Dan Kegel Sept. 21, 2009

Sept. 21, 2009

Doing a full test with my xattr patches, I saw hangs on about seven tests, all in mshtml , shdocv, and urlmon. While doing a baseline test run without my xattr patches, I noticed that mshtml / dom tests were still hanging. Has anybody else seen these tests hang lately?

2 1

Re: oledb32: Implement CanConvert.
by Marcus Meissner Sept. 21, 2009

Sept. 21, 2009

On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > --- > dlls/oledb32/convert.c | 231 +++++++++++++++++++++++++++++++++++++++++- > dlls/oledb32/tests/convert.c | 10 -- > 2 files changed, 228 insertions(+), 13 deletions(-) > diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c > index 458abb5..a2385f0 100644 > --- a/dlls/oledb32/convert.c > +++ b/dlls/oledb32/convert.c > @@ -126,13 +126,238 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface, > return E_NOTIMPL; > } > > +static inline WORD get_dbtype_class(DBTYPE type) > +{ > + switch(type) > + { > + case DBTYPE_I2: > + case DBTYPE_R4: > + case DBTYPE_R8: > + case DBTYPE_I1: > + case DBTYPE_UI1: > + case DBTYPE_UI2: > + return DBTYPE_I2; > + > + case DBTYPE_I4: > + case DBTYPE_UI4: > + return DBTYPE_I4; > + > + case DBTYPE_I8: > + case DBTYPE_UI8: > + return DBTYPE_I8; > + > + case DBTYPE_BSTR: > + case DBTYPE_STR: > + case DBTYPE_WSTR: > + return DBTYPE_BSTR; > + > + case DBTYPE_DBDATE: > + case DBTYPE_DBTIME: > + case DBTYPE_DBTIMESTAMP: > + return DBTYPE_DBDATE; > + } > + return type; > +} > + > +/* Many src types will convert to this group of dst types */ > +static inline BOOL common_class(WORD dst_class) > +{ > + switch(dst_class) > + { > + case DBTYPE_EMPTY: > + case DBTYPE_NULL: > + case DBTYPE_I2: > + case DBTYPE_I4: > + case DBTYPE_BSTR: > + case DBTYPE_BOOL: > + case DBTYPE_VARIANT: > + case DBTYPE_I8: > + case DBTYPE_CY: > + case DBTYPE_DECIMAL: > + case DBTYPE_NUMERIC: > + return TRUE; > + } > + return FALSE; > +} > + > +static inline BOOL array_type(DBTYPE type) > +{ > + return (type >= DBTYPE_I2 && type <= DBTYPE_UI4); > +} > + > static HRESULT WINAPI convert_CanConvert(IDataConvert* iface, > - DBTYPE wSrcType, DBTYPE wDstType) > + DBTYPE src_type, DBTYPE dst_type) > { > convert *This = impl_from_IDataConvert(iface); > - FIXME("(%p)->(%d, %d): stub\n", This, wSrcType, wDstType); > + DBTYPE src_base_type = src_type & 0x1ff; > + DBTYPE dst_base_type = dst_type & 0x1ff; > + WORD dst_class = get_dbtype_class(dst_base_type); > > - return E_NOTIMPL; > + TRACE("(%p)->(%d, %d)\n", This, src_type, dst_type); > + > + if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return S_FALSE; I think this needs brackets... Ciao, Marcus

3 3

Wine in Tango
by Joel Holdsworth Sept. 21, 2009

Sept. 21, 2009

Hi All, If anyone's interested I've published a working version of my Tango graphics for wine to Gitorious... http://gitorious.org/wine-tango/wine-tango clone: git clone git://gitorious.org/wine-tango/wine-tango.git branch: public-beta-1 This branch features Roderick Colenbrander's as-yet unmerged XRender patches, some patches from me for 32-bit support in the areas of icons, image lists and toolbars, and a partial set of patches to apply the tango graphics for shell32, user32 and comdlg32. Graphics for other apps/dlls are excluded, as well as the few tests I've produced. The work is most clear to see if you open a file dialog, or a message box. The full set of Tango graphics can be seen here: http://www.airwebreathe.org.uk/wine-icon/ . There are still a few graphical things to fix: dxdiag, certwatermark.bmp. Comments and criticisms are welcome! Best Regards Joel Holdsworth

9 15

Re: cppcheck Sept 18
by James Mckenzie Sept. 20, 2009

Sept. 20, 2009

-----Original Message----- >From: Henri Verbeet <hverbeet(a)gmail.com> >Sent: Sep 20, 2009 12:19 PM >To: Pauli Nieminen <suokkos(a)gmail.com> >Cc: wine-devel(a)winehq.org, Joris Huizer <joris_huizer(a)yahoo.com> >Subject: Re: cppcheck Sept 18 > >2009/9/20 Pauli Nieminen <suokkos(a)gmail.com> >> >> On Sat, Sep 19, 2009 at 1:59 PM, Joris Huizer <joris_huizer(a)yahoo.com> wrote: >>> >>> [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible >>> error) Array index out of bounds >>> >>> This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), >>> and it found an array: >>> int ca[5]; >>> >> int ca[5]; >> has only entries up to ca[4] (0-4) so to me it looks like bug. >> >Not quite. For one, the ca[5] that's being used here isn't the local >variable ca[5], but the field ca[1] of the cs_t structure. The >expression is used as a way to calculate the size of a cs_t structure >with 5 elements. > But what is the real size of ca[]? Is it five, fifty or five-hundred? Maybe that is why the cppcheck is declaring it out-of-bounds. James McKenzie

2 1

Re: [PATCH 4/6] d3d9: Limit "NumSimultaneousRTs" to 4.
by Stefan Dösinger Sept. 20, 2009

Sept. 20, 2009

Am Sunday 20 September 2009 20:09:25 schrieb Henri Verbeet: > pCaps->MaxVertexShaderConst = min(D3D9_MAX_VERTEX_SHADER_CONSTANTF, > pCaps->MaxVertexShaderConst); + pCaps->NumSimultaneousRTs = > min(D3D9_MAX_SIMULTANEOUS_RENDERTARGETS, pCaps->NumSimultaneousRTs); } I think you also have to make sure RTs > 3 can't be used in SetRenderTarget and GetRenderTarget

1 0

cppcheck Sept 18
by Joris Huizer Sept. 20, 2009

Sept. 20, 2009

[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd These two are false positives, as the process ends (calling exit(1) [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), and it found an array: int ca[5]; [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 That is a bug, sent a patch HTH, Joris

4 3

Re: dlls/comctl32/tests/tab.c: Transform CheckSize from a macro to a function.
by Nikolay Sivov Sept. 20, 2009

Sept. 20, 2009

Gerald Pfeifer wrote: > This not only avoids a 12+ line macro, it also sheds a couple of > compiler warnings with GCC 4.4 (though not the forthcoming 4.5). > > Gerald > > > ChangeLog: > Transform CheckSize from a macro to a function. > Hi, Gerald. This patch breaks line trace for tests. You should pass __LINE__ to your helper to work this as before.

1 0

Re: cppcheck Sept 18
by James Mckenzie Sept. 20, 2009

Sept. 20, 2009

>[/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible >error) Array index out of bounds > >This one is a false positive, it uses FIELD_OFFSET(cs_t, ca[5]), >and it found an array: >int ca[5]; > Actually, if this is a zero offset array, this is out of bounds. It might be better to extend ca by one and eliminate the possibility of the overflow and it only uses one more int worth of space... James McKenzie

1 0

porting winetricks to windows
by Dan Kegel Sept. 19, 2009

Sept. 19, 2009

Part of my http://wiki.winehq.org/UnitTestSuites effort is to make it easy to write scripts that automate the building of windows apps on wine or windows interchangably. After a while of writing special purpose tool-install-scripts that would work on either wine or windows, I realized that I really just wanted winetricks to be my tool install script, and that it should run on windows. i.e. if you want firefox on windows or wine, you should be able to do "sh winetricks -q firefox" and have it appear. Likewise, if you happen to need the Windows 7 SDK for something you're building, you should be able to say "sh winetricks -q psdkwin7" and have it appear, no questions asked. (Assuming on windows that you have cygwin installed, of course.) So I'm starting to make that happen. Firefox works, psdkwin7 is not quite working, and lots of verbs that run windows apps still need their paths converted, but it shouldn't be hard to get your favorite verb working in both OS's now.

4 5

Re: Add dxdiag help message box
by Brian Nguyen Sept. 19, 2009

Sept. 19, 2009

Hm, okay. I just wanted to test the waters here; I'll rework this to use a function that loads a string from a resource file. Does the help message itself look okay? I just used the message provided by the native dxdiag app, but I could rework it if there are issues with copyright or wine conventions. On Thu, Sep 17, 2009 at 6:34 AM, Henri Verbeet <hverbeet(a)...<http://www.nabble.com/user/SendEmail.jtp?type=post&post=25500104&i=0>> wrote: > 2009/9/17 Brian Nguyen <*mtxcoll*@...<http://www.nabble.com/user/SendEmail.jtp?type=post&post=25500104&i=1>>: >> +/* Thread-safe function for converting to wide char strings at runtime */ >> +LPWSTR PrintWide(LPWSTR buf, size_t len, const char *s) >> +{ >> + size_t i; >> + for (i = 0; i < len && *s != '\0'; i++, s++) { >> + buf[i] = *s; >> + } >> + return buf; >> +} > That doesn't do what you want, you should use MultiByteToWideChar() to > convert to WCHAR. However, I don't think you want to hardcode the > strings in the first place, you should load them from the resources so > they can be translated. Also, functions like that which are only used > in the current file should be static. Thanks for taking this on! -- -Austin -- Brian Nguyen mtxcoll(a)gmail.com

3 7

Fwd: Wine in Tango
by Reece Dunn Sept. 19, 2009

Sept. 19, 2009

---------- Forwarded message ---------- From: Reece Dunn <msclrhd(a)googlemail.com> Date: 2009/9/19 Subject: Re: Wine in Tango To: Henri Verbeet <hverbeet(a)gmail.com> 2009/9/19 Henri Verbeet <hverbeet(a)gmail.com>: > 2009/9/19 Joel Holdsworth <joel(a)airwebreathe.org.uk>: >> On Sat, 2009-09-19 at 21:43 +0200, Henri Verbeet wrote: >>> 2009/9/19 Vitaliy Margolen <wine-devel(a)kievinfo.com>: >>> > - The European stop sign is not known/used in US. It has no meaning to most >>> > people. >>> Actually, assuming you mean >>> http://www.airwebreathe.org.uk/wine-icon/oic_hand-48.png, that's not a >>> stop sign in Europe either. It generally means "no entry", and I was >>> under the impression it's used in that way in the US as well. Not that >>> that makes it any more appropriate as an "error" sign. (Doesn't gnome >>> use that one as well though? I guess that would at least make it >>> recognizable to some people.) >> >> It's the dialog error icon from the Tango base set. Does that carry any >> weight? maybe... maybe not. It seemed clear enough to me though. >> > Possibly, consistency is generally a good thing. I can't say I pay a > whole lot of attention to the icons in messageboxes, but I could see > how this one wouldn't be entirely clear on its own to a new user. The > color red probably does more to convey the message "error" than the > sign. The error icon needs to be recognisable as well (aside from colour) for people with red-green colour blindness. A no entry sign doesn't really make sense here (although, it is the correct image from a tango perspective). Tango does have an unofficial (X) 'traditional' version (ref: http://commons.wikimedia.org/wiki/Tango_icons) so it would probably be better to use that instead. Not sure what the Oxygen icon looks like. ==== On the whole, these icons are a major improvement. Well done. Q: For the small 16x16 icons, why do some have the wine glass and some don't (for the ones that have a wine glass on the larger versions)? - Reece

1 0

Re: [(try 3) 3/3] opengl32/tests: Improve test for wglMakeCurrent.
by Paul Vriens Sept. 19, 2009

Sept. 19, 2009

On 09/19/2009 12:29 PM, Rico Schüller wrote: > --- > dlls/opengl32/tests/opengl.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > > + ret = wglMakeCurrent( NULL, NULL ); + ok( !ret, "wglMakeCurrent failed\n" ); shouldn't that message read "wglMakeCurrent succeeded" ? If you are testing the last error it's usually a good idea to set the last error before the call (aka "SetLastError(0xdeadbeef)"). -- Cheers, Paul.

4 4

Re: winex11: add alternative header
by Steven Edwards Sept. 19, 2009

Sept. 19, 2009

2009/9/18 André Hentschel <nerv(a)dawncrow.de>: > this is my first patch to autoconf-stuff, please tell me if i did something wrong > see also Bug 20070 I expect It should actually not look like the following > #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H > #include <X11/extensions/xf86vmode.h> > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H) > +#include <X11/extensions/xf86vmproto.h> > #endif and instead like this: #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H #include <X11/extensions/xf86vmode.h> #endif #ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H #include <X11/extensions/xf86vmproto.h> #endif Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 2

[bugzilla] donate to sponsoring bug
by sacchi antonio Sept. 19, 2009

Sept. 19, 2009

This idea was born because I'm not a developer but I want to help Wine, this is not a perfect idea, help me to make it better! Maybe this button will appear only on very few bugs/projects (2-3 max?) and money could go directly to Wine and after bug/project will be released/fixed money could go to people. Now Alexandre decides if a patch will be included or not, so I think he will have the task of deciding also money issue. Sorry for my english.. S.A. 2009/9/16 Tom Wickline <twickline(a)gmail.com>: > Hello, > > You could have the money go into the general WPF or WCF "Wine Conference > Fund" > But the problem is if say I donate $50.00 who's to say the bug I donate to > will be resolved > any time soon? Paypal only allows refunds up to 60 days, so how would you go > about a refund > if the bug wasn't fixed in say a year or more? > > I think it would be hard to keep everyone happy, because as soon as people > donate to a bug > their going to expect something in return. And a refund most likely if the > bug isn't fixed. > > Tom > > 2009/9/16 Nicklas Börjesson <Nicklas.Borjesson(a)ws.se> >> >> I suppose that this only will appear on some bugs and disregarding that >> people might put off fixing bugs waiting for it to become a "pay-bug". >> Who's going to get the money? It seems quite common that people share >> credit on fixing bugs, should we burden Alexandre with the task of deciding >> that? >> Wouldn't this rather be on "projects", than bugs? The bug mentioned feels >> more like a "project". >> >> //Nicklas >> >> -----Original Message----- >> From: wine-devel-bounces(a)winehq.org on behalf of sacchi antonio >> Sent: Wed 2009-09-16 11:47 >> To: wine-devel(a)winehq.org >> Subject: [bugzilla] donate to sponsoring bug >> >> hello all. >> I'm new here but I'd like to suggest something, >> what do you think about this? >> http://img29.imageshack.us/img29/2940/wined.png >> >> Maybe it will be good for old/hard bugs? >> >> Thanks >> >> >> > > > > -- > http://www.wine-reviews.net/ > http://bordeauxgroup.com/ >

3 2

Add jscript component to Bugzilla?
by Ken Sharp Sept. 19, 2009

Sept. 19, 2009

Any chance someone could add a jscript component to Bugzilla? It's used a decent amount to warrant it...

1 1

Re: [Bug 19523] winmm: Multiple waveOutOpen calls on single device supported by Windows, not Wine
by Ken Thomases Sept. 19, 2009

Sept. 19, 2009

Taking this conversation out of the bug, since it seems I opened the bug in error and it should be closed. On Sep 19, 2009, at 2:29 AM, wine-bugs(a)winehq.org wrote: > http://bugs.winehq.org/show_bug.cgi?id=19523 > > --- Comment #3 from Eric Pouech <eric.pouech(a)orange.fr> 2009-09-19 > 02:28:51 --- > of course, there is... OK, in that case: a) that's good to know; and b) thanks for setting me straight. I might quibble with "of course", though. ;) > let's take the wave out driver interface as example: > > DWORD WINAPI wodMessage(UINT wDevID, UINT wMsg, DWORD_PTR dwUser, > DWORD_PTR dwParam1, DWORD_PTR dwParam2); > > in case wMsg in WODM_OPEN, dwUser is expected to be a pointer to a > DWORD, that > the driver is supposed to filled with a unique instance ID (to > identify the > stream) > > in other (subsequent) messages, winmm passes in dwUser the unique ID > defined by > the driver at WODM_OPEN time > > winmm correctly supports this scheme (see MMDRV_Open in dlls/winmm/ > lolvldrv.c) No offense, but looking at MMDRV_Open, it's clear as mud to me that dwDriverInstance has this meaning and corresponds to dwUser. Is there any documentation of the low-level driver interface? > but, none of the wine drivers correctly initialize the dwUser while > processing > the various XXXX_OPEN messages Does that mean this functionality is untested? Thanks again, Ken

3 3

Re: [(try 3) 1/3] wined3d: Don't call wglMakeCurrent(NULL, NULL) in context_set_current() if the current context is NULL.
by Rico Schüller Sept. 19, 2009

Sept. 19, 2009

Am 19.09.2009 12:29, schrieb Rico Schüller: > Hi, > > this patch series fixes a bug which happens on windows with wined3d. > There a second call to wglMakeCurrent(NULL, NULL) fails, which will in > one case result in an early return in context_set_current(), which > doesn't set the the current context to NULL in such a case, but frees > the variable. So on the next call to context_set_current() (e.g. from > WineD3D_CreateFakeGLContext()) the memory in old->... could be some > other random memory and the app could crash. > > try 3 improvements: > - try 2 had the wrong test patch (3/3), so this time with the correct one > > try 2 improvements: > - moved the check from winex11.drv to gdi32 (because we don't need any > X11 functionality) > - order of patches changed > > The first patch fixes the behaviour in wined3d. The second one adds > the fix in gdi32 to change the behaviour to the one on xp. The third > patch adds a test case to opengl32/tests. > > Cheers > Rico > > --- > dlls/wined3d/context.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > > I have to add some more tests. I'll resend a better version of the patch set. Cheers Rico

1 0

cppcheck Sept 18
by chris ahrendt Sept. 18, 2009

Sept. 18, 2009

[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 chris

1 0

Re: clock: fix license in Swedish resources
by Austin English Sept. 18, 2009

Sept. 18, 2009

2009/9/15 Austin English <austinenglish(a)gmail.com>: > Wine is LGPL, not GPL. Also, convert to UTF-8. > > -- > -Austin Something wrong with these two patches? -- -Austin

1 0

WineHQ Scheduled Downtime
by Jeremy Newman Sept. 18, 2009

Sept. 18, 2009

WineHQ.org will be going off-line today starting at 14:30 US Central time. At this time we are performing hardware upgrades and maintenance. The system will be off-line from 20 minutes up to an hour. Services Affected: * WineHQ.org website * Bugzilla * Forums * AppDB * mailing lists * GIT and CVS -Newman

1 0

Re: [PATCH 1/3] winex11.drv: Check the current context in X11DRV_wglMakeCurrent().
by Roderick Colenbrander Sept. 18, 2009

Sept. 18, 2009

Hi, I'm not sure if we should skip the glXMakeCurrent(null, null) call in GLX as in case of GLX it doesn't hurt. Second I'm not sure if we need to put the SetLastError code in winex11 or in gdi32/opengl.c. I think it should be in there as we don't need any X11 info. Roderick 2009/9/18 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this patch series fixes a bug which happens on windows with wined3d. There a > second call to wglMakeCurrent(NULL, NULL) fails, which will in one case > result in an early return in context_set_current(), which doesn't set the > the current context to NULL in such a case, but frees the variable. So on > the next call to context_set_current() (e.g. from > WineD3D_CreateFakeGLContext()) the memory in old->... could be some other > random memory and the app could crash. > > The first patch adds a fix for winex11.drv to change the behaviour to the > one on xp. The second patch adds a test case to opengl32/tests. And the > third one fixes the behaviour in wined3d. > > Cheers > Rico > > --- > dlls/winex11.drv/opengl.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > > > > >

2 1

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)
by Paul Vriens Sept. 18, 2009

Sept. 18, 2009

On 09/18/2009 01:42 PM, Markus Stockhausen wrote: > Hi, > > as I was encouraged to resent the patch from last week in git format I > hope it will be better this time. > > Best regards > > > ------------------------------------------------------------------------ > > Hi Markus, After reading this patch again, it seems to me it's not a 100% correct. There is a slight difference in passing hdcSrc as NULL compared to retrieving dcSrc via get_dc_ptr. The actual test sets hdcSrc to NULL, so the corresponding test in the implementation should be: if (!hdcSrc) return FALSE; dcSrc = get_dc_ptr ( hdcSrc ); Now, I don't know whether get_dc_ptr can fail but that's a different matter. -- Cheers, Paul.

2 3