September 2009 - Wine-Devel

Re: ddraw: complete recognition of pixelformat 19: X8L8V8U8
by Stefan Dösinger Sept. 14, 2009

Sept. 14, 2009

Am Monday 14 September 2009 17:28:13 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > the argument for including this code is based on symmetry: Every place in > the Wine source tree (incl. ddraw, d3d9, wined3d) that handles L6V5U5 also > handles X8L8V8U8 -- except for these two places. So I closed the gap. > > This fixes > err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 19 > Please see bug #16559 for further discussion. > > Being based on the symmetry argument means this patch is completely > independent on possible missing conversions between D3DFMT and WINED3DFMT > codes somewhere in Wine. I would not eliminate that possibility. The above > error message that used to mention Pixelformats 62/63/64 nowadays mentions > 19/64/69/70. > > Regards, > Jörg Höhle The patch seems ok to me

1 0

Re: ntdll: Do not accept device control requests with invalid and/or incompatible handles
by Alexandre Julliard Sept. 14, 2009

Sept. 14, 2009

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > +static void test_device_control(void) > +{ > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + > + /* Try using a bugus handle for I/O control */ > + HANDLE handle = (HANDLE)0xdeadbeef; > + status = pNtDeviceIoControlFile(handle, NULL, NULL, NULL, &io, IOCTL_SERIAL_SET_BAUD_RATE, NULL, 0, NULL, 0); > + ok(status == STATUS_INVALID_HANDLE, "Expected %08X, got %08X\n", STATUS_INVALID_HANDLE, status); > + > + /* Try using an valid (but wrong) handle for I/O control */ > + handle = GetStdHandle(STD_INPUT_HANDLE); > + status = pNtDeviceIoControlFile(handle, NULL, NULL, NULL, &io, IOCTL_SERIAL_SET_BAUD_RATE, NULL, 0, NULL, 0); > + ok(status == STATUS_INVALID_HANDLE, "Expected %08X, got %08X\n", STATUS_INVALID_HANDLE, status); GetStdHandle returns a console handle which is not a valid ntdll handle, so you are not testing what you think. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 14, 2009

Sept. 14, 2009

Hi, Stefan Dösinger wrote: >>All that happened [with notepad] is that the printer ejected a blank page. >Printing from notepad works fine for me on both Linux and OSX, fwiw Saving to file instead of printing, notepad generated a .ps file. Reading this into Apple's preview shows the text. Converting to pdf, then viewing also shows the text. Printing this prints a blank page! So either Apple does not like the PS generated by Wine, or only the printer, or that's a problem with fonts or whatever else. I'm using a PPC driver for an old Lexmark Z33 printer that prints documents from TextEdit and Safari perfectly. I still need to test a wine application other than notepad. BTW, the page footer says "Page &p": &p is not substituted by notepad. Is this a known bug in notepad or Wine's printer driver? Regards, Jörg Höhle.

1 0

Re: [3/5] comctl32/dpa: Implement DPA_SaveStream() with tests
by Vitaliy Margolen Sept. 14, 2009

Sept. 14, 2009

Nikolay Sivov wrote: > Changelog: > - Implement DPA_SaveStream() with tests > > + streamData.dwSize = curr_pos.QuadPart - initial_pos.QuadPart; > + streamData.dwData2 = 1; > + streamData.dwItems = streamInfo.iPos;// + 1; c++ comment. > +#if 0 > + /* crashes on XP */ > + hRes = pDPA_SaveStream(NULL, CB_Save, pStm, NULL); > + expect(E_INVALIDARG, hRes); > + > + hRes = pDPA_SaveStream(dpa, CB_Save, NULL, NULL); > + expect(E_INVALIDARG, hRes); > +#endif Don't use #if 0 / #endif in tests. Use if (0){} instead. This will guarantee that code will still compile. Vitaliy.

2 1

Re: include: Add missing definitions in af_irda.h. (try 2)
by Alexandre Julliard Sept. 13, 2009

Sept. 13, 2009

Thomas Trummer <th.trummer(a)gmail.com> writes: > @@ -97,4 +100,159 @@ typedef struct _SOCKADDR_IRDA > #define LmCharSetISO_8859_9 0x09 > #define LmCharSetUNICODE 0xff > > +#define SIO_LAZY_DISCOVERY _IOR('t', 127, ULONG) > + > +#define WINDOWS_AF_IRDA 26 > +#define WINDOWS_PF_IRDA WINDOWS_AF_IRDA > + > +#define WCE_AF_IRDA 22 > +#define WCE_PF_IRDA WCE_AF_IRDA > + > +#ifndef AF_IRDA > +#define AF_IRDA WINDOWS_AF_IRDA > +#endif > + > +#ifndef PF_IRDA > +#define PF_IRDA AF_IRDA > +#endif > + > +#define IRDA_PROTO_SOCK_STREAM 1 You need a WS prefix on all definitions that can conflict with Unix. -- Alexandre Julliard julliard(a)winehq.org

4 4

Sept 11 with tools and tests removed
by chris ahrendt Sept. 13, 2009

Sept. 13, 2009

Here is the run for Friday Sept. 11 with the tools and the tests directory results removed. [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 Chris

6 11

Re: wined3d: Add Intel GMA 4500MHD
by Stefan Dösinger Sept. 13, 2009

Sept. 13, 2009

Am Sunday 13 September 2009 08:15:19 schrieb Jaime Rave: > More information about Intel cards: > http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip >sets + || strstr(gl_renderer, "Intel®")) I don't know if it is safe check for the ®. I think its not part of the standard ASCII character set, so there might be codepage issues. I don't think its necessary to check for it anyway, I think "Intel" is good enough. (In which case we might change the "Intel(R)" and "Intel Inc." checks as well) + if (strstr(gl_renderer, "GM45")) + { + /* GMA 4500MHD. These can take up to 2048MB */ + *vidmem = 512; + return CARD_INTEL_GM45; + } + You are adding trailing whitespace in the last line(I think Alexandre's commit scripts fiter that out though)

1 0

Re: wined3d: Add Intel GMA 4500MHD
by Roderick Colenbrander Sept. 13, 2009

Sept. 13, 2009

Just one minor thing make sure the right email address is configured in your git repository, so that the correct email address is set in the patch Roderick On Sun, Sep 13, 2009 at 8:15 AM, Jaime Rave <jaimerave(a)ubuntu-co.com> wrote: > More information about Intel > cards: http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip… > > > >

1 0

Re: [ntdll] Add test for NtQueryDirectoryFile [try 2]
by James McKenzie Sept. 12, 2009

Sept. 12, 2009

Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > Changes since first try: > 1) fixed issues Paul found (wasn't setting hidden attribute, wasn't > cleaning up on failure) > 2) actually test reported file attributes > Dan: It looks like your original patch was approved by AJ in commit 398a8ea1fec599cfd6442e3b8bba620431cf53b7 You might want to run a diff against the current git. James McKenzie

2 1

Re: DDraw: Add a few missing WINAPIs
by Henri Verbeet Sept. 12, 2009

Sept. 12, 2009

2009/9/12 Stefan Dösinger <stefan(a)codeweavers.com>: > I wonder how this worked in the past, and why the compiler didn't complain. It's pretty simple really, these functions don't need WINAPI because they're ddraw internal functions "cleverly" disguised as vtable methods. IIRC it's actually harmful to add WINAPI to these on OS X due to some obscure compiler bug.

2 1

re: fixing ReadDirectoryChangesW()
by Dan Kegel Sept. 12, 2009

Sept. 12, 2009

Michael Pujos wrote: > I'm willing to resubmit this patch with updated tests > against current Wine, but before I procceed > I need to be sure it won't be rejected simply because it changes the protocol. Server changes are tricky to get in. You have to be patient and persistent. I think your best next move is to file a bug describing the problem (and give the URL for the app it affects for you, if possible), and submit just the tests first (with appropriate todo_wine lines where wine gets it wrong currently). All that is useful, and a good first step towards getting the bug fixed. Thanks! - Dan

3 2

Re: DDraw: Add a few missing WINAPIs
by Stefan Dösinger Sept. 12, 2009

Sept. 12, 2009

Am Saturday 12 September 2009 23:41:00 schrieb Stefan Dösinger: > Am Saturday 12 September 2009 23:25:56 schrieb Stefan Dösinger: > > Oops: forgot the patch: Er, never mind that patch - those functions aren't used directly in the vtable. There are the FPUSetup and FPUPreserve wrappers around them, so the default calling convention is ok.

1 0

RE: Help with a native Windows test program needed (CreateFileW).
by Markus Stockhausen Sept. 12, 2009

Sept. 12, 2009

Sorry for the the wrong feedback. As I have limited possibilites creating executables on Windows I relied on Thomas executable for the tests. Maybe you can post a corrected version. It is not my intention to confuse someone. Im just trying to narrow down my initial analysis. The last write access to the malicous memory address before the application dump comes from CreateFileW. Best regards. -------- Weitergeleitete Nachricht -------- Von: wine-bugs(a)winehq.org An: mst(a)collogia.de Betreff: [Bug 9575] IBExpert need windows native ole32.dll to run Datum: Sat, 12 Sep 2009 05:18:49 -0500 http://bugs.winehq.org/show_bug.cgi?id=9575 --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> 2009-09-12 05:18:42 --- There's no such behavior. The test is broken.

2 5

Re: [ntdll] Add test for NtQueryDirectoryFile
by Paul Vriens Sept. 12, 2009

Sept. 12, 2009

On 09/12/2009 02:18 AM, Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > [Paul, could you test it on your box to make sure it's ok there?] Hi Dan, No failures on my NT4+ boxes (32bit). One thing I noticed is that you don't cleanup in some of the failure cases which would leave that temporary directory around. -- Cheers, Paul.

1 2

Help with a native Windows test program needed (CreateFileW).
by Markus Stockhausen Sept. 12, 2009

Sept. 12, 2009

Hi, as I have no Windows machine and cannot test this. I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) Return the result of second call. I expect it to be a valid handle on Windows whereas Wine will return an invalid handle. Thanks in advance. Markus

2 3

RE: Help with a native Windows test program needed (CreateFileW)
by Greg Geldorp Sept. 11, 2009

Sept. 11, 2009

Hi Markus, > From: Markus Stockhausen <markus.stockhausen(a)collogia.de> > > as I have no Windows machine and cannot test this: I'm in need for > someone who can build a small exe that gives further hints to my > observations in bug #9575. The following is needed: > > call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) > call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) > > Return the result of second call. I expect it to be a valid handle on > Windows whereas Wine will return an invalid handle. This test program: int main(int argc, char *argv[]) { HANDLE File1, File2; File1 = CreateFileW(L"test.dat", GENERIC_READ, 0, NULL, CREATE_ALWAYS, 0, NULL); File2 = CreateFileW(L"test.dat", GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL); printf("File1 0x%x File2 0x%x error %u\n", File1, File2, GetLastError()); return 0; } returns this result on Windows 2008: File1 0x10 File2 0xffffffff error 32 so the second CreateFile fails on Windows too, with ERROR_SHARING_VIOLATION. Ge.

1 0

RFC: registry keys of serial ports
by Stefan Leichter Sept. 11, 2009

Sept. 11, 2009

Hi, i like to know what modifikations the attached patch needs to go into git. More things need to be done in this area. I know of: - more registry keys [1] - remove the registry keys when a serial port disappears (USB) - the links in the dosdevice directory needs to be created Patches for the items above will be created, when the current patch went into git References: 1 http://www.winehq.org/pipermail/wine-patches/2009-April/071999.html - http://www.winehq.org/pipermail/wine-devel/2009-April/074476.html -- Stefan

3 5

Help with a native Windows test program needed (CreateFileW)
by Markus Stockhausen Sept. 11, 2009

Sept. 11, 2009

Hi, as I have no Windows machine and cannot test this: I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) Return the result of second call. I expect it to be a valid handle on Windows whereas Wine will return an invalid handle. Thanks in advance. Markus

2 1

fixing ReadDirectoryChangesW()
by Michael Pujos Sept. 11, 2009

Sept. 11, 2009

A few months ago I wrote a patch that addressed the following issues with ReadDirectoryChangesW(): "1. move and rename of files and directories in a monitored directory are not notified 2. the current implementation allow to only get one change (FILE_NOTIFY_INFORMATION structure) at a time. No change is actually lost but the calling application using ReadDirectoryChangesW() expect to retrieve all changes since the last call. With the current implementation it would only get the first and would have to call ReadDirectoryChangesW() again to get the other. With this patch , it gets all notification (as many consecutive FILE_NOTIFY_INFORMATION structs) since the last call to ReadDirectoryChangesW(). These move operations are implemented by this patch and conform to what win32 does: - Moving a directory or a file inside the monitored directory. A FILE_NOTIFY_INFORMATION structure with action FILE_ACTION_ADDED is returned - Moving a directory or a file out of the monitored directory. A FILE_NOTIFY_INFORMATION structure with action FILE_ACTION_REMOVED is returned - Renaming a directory or a file in the monitored directory. Two consecutive FILE_NOTIFY_INFORMATION structures with actions FILE_ACTION_RENAMED_OLD_NAME and FILE_ACTION_RENAMED_NEW_NAME are returned within the same reply. This can actually be done because issue 2 above is corrected." This old patch can be found here: http://bubbleguuum.free.fr/0001-server-implement-move-rename-change-notific… This patch modify the server protocol in server_protocol.h from struct read_change_reply { struct reply_header __header; int action; /* VARARG(name,string); */ }; to: struct read_change_reply { struct reply_header __header; int action_count; /* VARARG(name,string); */ }; I'm willing to resubmit this patch with updated tests against current Wine, but before I procceed I need to be sure it won't be rejected simply because it changes the protocol.

1 0

Re: [PATCH 2/4] mshtml: Added http loading test.
by Paul Vriens Sept. 11, 2009

Sept. 11, 2009

On 09/02/2009 12:27 PM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 270 > +++++++++++++++++++++++++++++-------------- > 1 files changed, 182 insertions(+), 88 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Looks like this one introduced 2 test failures on some boxes, I couldn't find a common denominator though. The failures happen on IE6, IE7 and IE8 on different platforms (NT4 and higher). There are however also IE8 boxes without failures. The failures seem to be triggered by the "test_download(FALSE, FALSE, FALSE);" on line 4026. Could you have a look? (Some other failures happen on ME and lower but I'll investigate those). -- Cheers, Paul.

2 1

Re: [ntdll] Add tests for NtQueryInformationFile
by Paul Vriens Sept. 11, 2009

Sept. 11, 2009

On 09/09/2009 02:41 PM, Dan Kegel wrote: > Alexandre said I should break up the big xattr patch, > so here are just the NtQueryInformationFile tests, > improved a bit. Once these are in I'll submit the > NtQueryDirectoryFile tests. > > Passes on both Wine and Vista. > > > ------------------------------------------------------------------------ > > Hi Dan, This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are already chasing these failures. Weird that it doesn't fail on your Vista box. That remark "whoops, vista doesn't implement this one?\n" should probably be changed. It also looks like Vista/Win7 has either 2 or 4 failures (most likely related to indexing being disabled, if so that could also happen on other platforms). Not sure if we should explicitly check for attributes being 2020, ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED or just check as I did. -- Cheers, Paul.

2 4

Mirror Space
by Marty Cannon Sept. 11, 2009

Sept. 11, 2009

Hey guys, Since the wine.budgetdedicated.com server was down all weekend, I thought I'd offer an additional mirror location. I currently mirror several major linux distributions, and would love to contribute to something as valuable to the community as the wine project is. My site currently runs around 3500GB per month, so a few hundred GB worth of transfer shouldn't make much difference. I've never set up an apt mirror, but with some instruction and googling, I bet I can do it. At the very least, I can mirror the package archive just incase the main site goes down. Let me know how I can help. -Marty Cannon amarillolinux.com

6 12

Fixing the user32/dde tests on Win9x/WinMe
by Paul Vriens Sept. 11, 2009

Sept. 11, 2009

Hi, DdeInitializeW is not implemented on the mentioned platforms but it's not just a matter of skipping some tests when that W-function is found to be not implemented. Any idea what the best way would be to fix these tests? -- Cheers, Paul.

1 0

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer
by Roderick Colenbrander Sept. 11, 2009

Sept. 11, 2009

Recently Nikolay Sivov wrote some tests for this call. His tests didn't make it in yet but I think those should enter and then based on those results changes should be made. Roderick On Thu, Sep 10, 2009 at 10:56 PM, Markus Stockhausen <markus.stockhausen(a)collogia.de> wrote: > Hi, > > http://bugs.winehq.org/show_bug.cgi?id=18041 reveals a bug where > GdiAlphaBlend will crash in Teamviewer application when a NULL pointer > is handed over. The attached check fixes that behaviour. > > Tanks in advance. > > Markus > > > > >

4 7

Status of LoadLibrary and .so
by Joe Dluzen Sept. 10, 2009

Sept. 10, 2009

Hi all, back a few years ago it didn't: http://www.winehq.org/pipermail/wine-devel/2003-July/018498.html Does anyone know of the status of LoadLibrary and a .so? Can it load directly or is there a workaround that does not involve multiple processes and some sort of IPC? thanks, Joe

3 2