September 2009 - Wine-Devel

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 20, 2010

Oct. 20, 2010

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Re: Use GCC's -Wlogical-op if possible
by Austin English Sept. 19, 2010

Sept. 19, 2010

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard Aug. 17, 2010

Aug. 17, 2010

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: tools/widl: Split expr_int_const off from expr
by Rob Shearman Dec. 21, 2009

Dec. 21, 2009

2009/6/28 Gerald Pfeifer <gerald(a)pfeifer.com>: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c2f1abc..01aa060 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -622,56 +633,54 @@ m_expr: { $$ = make_expr(EXPR_VOID); } > | expr > ; > > -expr: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > - | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > +expr: expr_int_const > | aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, $1); } > + | '-' aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, -($2)); } This is covered by the production for the binary minus operator that already exists, so I'm not sure what you're trying to achieve here. > | tFALSE { $$ = make_exprl(EXPR_TRUEFALSE, 0); } > - | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > | tTRUE { $$ = make_exprl(EXPR_TRUEFALSE, 1); } > | aSTRING { $$ = make_exprs(EXPR_STRLIT, $1); } > | aWSTRING { $$ = make_exprs(EXPR_WSTRLIT, $1); } > - | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } > | expr '?' expr ':' expr { $$ = make_expr3(EXPR_COND, $1, $3, $5); } > | expr LOGICALOR expr { $$ = make_expr2(EXPR_LOGOR, $1, $3); } > | expr LOGICALAND expr { $$ = make_expr2(EXPR_LOGAND, $1, $3); } > - | expr '|' expr { $$ = make_expr2(EXPR_OR , $1, $3); } > - | expr '^' expr { $$ = make_expr2(EXPR_XOR, $1, $3); } > - | expr '&' expr { $$ = make_expr2(EXPR_AND, $1, $3); } > | expr EQUALITY expr { $$ = make_expr2(EXPR_EQUALITY, $1, $3); } > | expr INEQUALITY expr { $$ = make_expr2(EXPR_INEQUALITY, $1, $3); } > | expr '>' expr { $$ = make_expr2(EXPR_GTR, $1, $3); } > | expr '<' expr { $$ = make_expr2(EXPR_LESS, $1, $3); } > | expr GREATEREQUAL expr { $$ = make_expr2(EXPR_GTREQL, $1, $3); } > | expr LESSEQUAL expr { $$ = make_expr2(EXPR_LESSEQL, $1, $3); } > - | expr SHL expr { $$ = make_expr2(EXPR_SHL, $1, $3); } > - | expr SHR expr { $$ = make_expr2(EXPR_SHR, $1, $3); } > - | expr '+' expr { $$ = make_expr2(EXPR_ADD, $1, $3); } > - | expr '-' expr { $$ = make_expr2(EXPR_SUB, $1, $3); } > - | expr '%' expr { $$ = make_expr2(EXPR_MOD, $1, $3); } > - | expr '*' expr { $$ = make_expr2(EXPR_MUL, $1, $3); } > - | expr '/' expr { $$ = make_expr2(EXPR_DIV, $1, $3); } > | '!' expr { $$ = make_expr1(EXPR_LOGNOT, $2); } > - | '~' expr { $$ = make_expr1(EXPR_NOT, $2); } > - | '+' expr %prec POS { $$ = make_expr1(EXPR_POS, $2); } > - | '-' expr %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > | '&' expr %prec ADDRESSOF { $$ = make_expr1(EXPR_ADDRESSOF, $2); } > | '*' expr %prec PPTR { $$ = make_expr1(EXPR_PPTR, $2); } > | expr MEMBERPTR aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, make_expr1(EXPR_PPTR, $1), make_exprs(EXPR_IDENTIFIER, $3)); } > | expr '.' aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, $1, make_exprs(EXPR_IDENTIFIER, $3)); } > | '(' type ')' expr %prec CAST { $$ = make_exprt(EXPR_CAST, $2, $4); } > - | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > | expr '[' expr ']' { $$ = make_expr2(EXPR_ARRAY, $1, $3); } > - | '(' expr ')' { $$ = $2; } > ; > > expr_list_int_const: expr_int_const { $$ = append_expr( NULL, $1 ); } > | expr_list_int_const ',' expr_int_const { $$ = append_expr( $1, $3 ); } > ; > > -expr_int_const: expr { $$ = $1; > - if (!$$->is_const) > - error_loc("expression is not an integer constant\n"); > - } > +expr_int_const: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > + | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > + | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > + | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } aIDENTIFIER isn't necessarily a constant expression. > + | '~' expr_int_const { $$ = make_expr1(EXPR_NOT, $2); } > + | '+' expr_int_const %prec POS { $$ = make_expr1(EXPR_POS, $2); } > + | '-' expr_int_const %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > + | expr_int_const SHL expr_int_const { $$ = make_expr2(EXPR_SHL, $1, $3); } > + | expr_int_const SHR expr_int_const { $$ = make_expr2(EXPR_SHR, $1, $3); } > + | expr_int_const '+' expr_int_const { $$ = make_expr2(EXPR_ADD, $1, $3); } > + | expr_int_const '-' expr_int_const { $$ = make_expr2(EXPR_SUB, $1, $3); } > + | expr_int_const '%' expr_int_const { $$ = make_expr2(EXPR_MOD, $1, $3); } > + | expr_int_const '*' expr_int_const { $$ = make_expr2(EXPR_MUL, $1, $3); } > + | expr_int_const '/' expr_int_const { $$ = make_expr2(EXPR_DIV, $1, $3); } > + | expr_int_const '|' expr_int_const { $$ = make_expr2(EXPR_OR , $1, $3); } > + | expr_int_const '^' expr_int_const { $$ = make_expr2(EXPR_XOR, $1, $3); } > + | expr_int_const '&' expr_int_const { $$ = make_expr2(EXPR_AND, $1, $3); } Using "expr_int_const" instead of "expr" here prevents a many forms of expressions from being parsed. > + | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > + | '(' expr ')' { $$ = $2; } > ; > > expr_const: expr { $$ = $1; It looks like you'll have to find another way of fixing the issue you are trying to fix. -- Rob Shearman

3 2

meaning of "Hardware" field in bugzilla?
by Dan Kegel Dec. 12, 2009

Dec. 12, 2009

Does "mac" mean "powerpc mac only"? I rather thought it meant "apple macintosh", regardless of cpu. I ask because Austin has just gone through and changed lots of "mac" bugs to "pc" even though the bugs were on Intel macs, which just seems wrong.

8 8

Towards leveraging app build and unit tests as a way to test wine
by Dan Kegel Oct. 18, 2009

Oct. 18, 2009

Wine is far enough along that it ought to be able to build and run unit test suites from apps like Inkscape, Firefox, and OpenOffice, so I'm trying to write scripts that download and build various apps unattended, and eventually run their own test suites. The scripts are written to run equally well on Windows and Wine. This is hard to do without something like Cygwin or Autohotkey; I'm using Cygwin for my scripts out of personal preference. I already did a build script for Inkscape using mingw; http://kegel.com/wine/inkscape-download-and-build.sh.txt Now I'm tackling Firefox. So far the script installs Visual C++ 2005 Express and the 2003 platform SDK; see http://kegel.com/wine/vc2005x.sh.txt Next step: grabbing firefox source and building. I'm also filing bugs as I go; 19673 Microsoft Platform Installer 2003 fails to install 19668 cmd /c doesn't wait for result before exiting? 19636 Vista SDK installer fails in "Microsoft VC Redist 2008" subinstaller 19615 Can't compile Inkscape with mingw on wine: fd leak? 19581 Visual Studio 2005: "cl : Command line error D8022 : cannot open 'foo.rsp' "; foo.rsp was created with FILE_ATTRIBUTE_TEMPORARY 19502 Visual Studio 2005 SP1 install seems to fail While one doesn't really need to build the apps under Wine to run their test suites, it's a pain to have to compile them on one system and ship them over to another. And supporting building might have a nice benefit: if it's easy to develop for Windows on Wine, more Windows developers might bother to test their apps on Wine. So I think it's worth the extra effort. - Dan

5 16

search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by Dan Kegel Oct. 18, 2009

Oct. 18, 2009

See http://bugs.winehq.org/show_bug.cgi?id=14980 Essentially, to run Office 2007, you have to set an override for riched20. Since Office installs a new, spiffier version of riched20 in its own private directory, and expects to find it there, isn't it a bug that we don't let it have it? Sounds like it's time to write a conformance test... sure would be nice if that override wasn't needed.

9 26

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit
by Henri Verbeet Oct. 10, 2009

Oct. 10, 2009

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > +typedef struct tagDPSP_MSG_HEADER > +{ > + DWORD size; /* size & 0x000FFFFF, token & 0xFFF00000 */ > + SOCKADDR_IN SockAddr; > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER; > + It seems you're sending this over the network, so you should make sure it's correctly packed, and take the byte order into account.

3 11

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()
by Juan Lang Oct. 8, 2009

Oct. 8, 2009

Hi Dan, > This is a bit different from the code I posted earlier; > following Samba's example, it combines the > fd and filename cases into a single function, Since you don't actually use the fd in your patch, I think it's preferred style not to include it for now. Also, +void DIR_set_attributes(int fd, DWORD attributes) +{ + /* Unimplemented. Wine does not yet store win32 file attributes. */ (snip) + + /* Try to save attributes. We don't care too much if it doesn't work. */ + DIR_set_attributes(fd, info->FileAttributes); Adding a no-op part of the patch is a bit ugly. Removing it allows you to focus on one thing in this patch, rewriting querying the file attributes. You re-add setting them later. (Thanks for working on this, by the way.) --Juan

2 4

Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
by Johan Gill Oct. 8, 2009

Oct. 8, 2009

On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill <johan.gill(a)gmail.com> wrote: > This patch fixes bug 17215. Since the patch was seemingly dropped, I made > some test improvements and resubmit it. > > The tests pass on Windows XP, and of course Wine. > > Suggested changelog: > In DirectDraw fullscreen mode, make sure the fullscreen window is resized > when the display mode changes > > Johan Gill > > Since I heard nothing on this, I make a request here /Johan Gill

2 5

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing
by Dmitry Timoshkov Oct. 1, 2009

Oct. 1, 2009

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hicon); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETICON, (WPARAM)hicon, 0); > + todo_wine ok_sequence(WmSetIconErrStaticSeq, "STM_SETICON on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ENHMETAFILE, (LPARAM)hemf); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); You should use SendMessageA instead of SendMessageW to make the test run under Win9x as well. Testing the return value of SendMessage would be also helpful. -- Dmitry.

3 3

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime
by Paul Vriens Oct. 1, 2009

Oct. 1, 2009

On 09/29/2009 12:36 PM, Nikolay Sivov wrote: > Changelog: > - be sure we have a single view calendar for hittesting > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1002: Test failed: Expected 10000, got 10002 I fixed it on my NT4 box by checking the point more to the left (see attached). I somehow doubt it's the correct fix though. Aren't these tests with more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? -- Cheers, Paul.

2 5

Modifying Subsystem in Winelib executables
by Greg Geldorp Sept. 30, 2009

Sept. 30, 2009

To fix one of the tests (shell32:shlexec) I'd like to copy the test executable and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files, get the IMAGE_DOS_HEADER, follow it to the IMAGE_NT_HEADERS and just patch the OptionalHeaders.Subsystem field. My limited understanding of the structure of Winelib executables makes doing the same for testing on Wine quite a bit harder. I assume there's still a IMAGE_NT_HEADERS structure in there somewhere and with some research I'll probably be able to locate it in Linux ELF Winelib executables. What I'm wondering about is how big the can of worms I'm trying to open is? Is the encapsulation of PE headers in "native" executables the same for all OSes supported by Wine? Is changing a PE header field in (a copy of) a Winelib executable doomed to fail or is it a walk in the park? Ge.

4 5

firefox build success on visual c++ 2005 on wine!
by Dan Kegel Sept. 30, 2009

Sept. 30, 2009

Moo hoo ha ha ha! Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, the firefox build procedure runs all the way through to the end (at least in release mode; debug builds still fail). Here's a log showing the whole build: http://kegel.com/wine/log.txt And, if AJ likes my hidden attribute patch, 'cc' will start working on Cygwin, making it easier to just try building random Unix apps on cygwin on wine. We're getting closer and closer to a world in which we can use random application http://wiki.winehq.org/UnitTestSuites as regression tests for wine. (It'd be cool if we could get buildbot working *on wine*; see http://bugs.winehq.org/show_bug.cgi?id=13844 Then we could make wine-powered buildbots for a bunch of open source projects without having to fiddle around porting their buildbot configs to invoke wine. - Dan

2 2

Re: [2/5] WineD3D: Start replacing dxVersion with create flags
by Stefan Dösinger Sept. 30, 2009

Sept. 30, 2009

Am 30.09.2009 um 16:22 schrieb Henri Verbeet: >> I prefer that all d3d version specific behaviors in wined3d(ie, >> those that >> can't be handled by the client lib alone) are controlled by one >> wined3d >> parameter. I don't feel strongly about this though. I could as well >> make >> them a parameter of CreateVertexBuffer if you prefer this. >> > I think it might make more sense there, although I suppose there's > something to say for keeping the differences centralised as well. Are the patches ok with you in that case? Otherwise I'll just fix bug 19365 with the old dxVersion hack and implement whatever properly designed setup you prefer the next time I have a few hours to kill (read: On my 16 hour flight to the google mentor summit later next month) > Is there any reason you're not sending these mails to wine-devel as > well? Apparently because the "reply" button in Apple Mail doesn't do the same as the "reply" button in kmail. Apparently because there's no "reply to mailing list" either.

2 2

Re: [1/2] richedit: Added test to show that handle to parent is cached.
by Paul Vriens Sept. 30, 2009

Sept. 30, 2009

On 09/30/2009 03:56 PM, Dylan Smith wrote: > --- > dlls/riched20/tests/editor.c | 26 ++++++++++++++++++++++++++ > 1 files changed, 26 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Dylan, Could you change SetWindowLongPtrW to the A-variant to cope with 9x/Me? -- Cheers, Paul.

1 0

Re: ws2_32: Ignore EINTR poll result code in WS_select
by Alexandre Julliard Sept. 30, 2009

Sept. 30, 2009

Dmitriy Anisimkov <anisimkov(a)ada-ru.org> writes: > Changelog: > - Ignore EINTR result code from poll call in WS_select. Your timeout computation is still wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: sti [2/2]: add stubs for the IStillImageW interface
by Alexandre Julliard Sept. 30, 2009

Sept. 30, 2009

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static const struct IUnknownVtbl internal_unk_vtbl = > +{ > + Internal_QueryInterface, > + Internal_AddRef, > + Internal_Release > +}; > + > +static const struct IStillImageWVtbl stillimagew_vtbl = > +{ > + stillimagew_QueryInterface, > + stillimagew_AddRef, > + stillimagew_Release, > + stillimagew_Initialize, > + stillimagew_GetDeviceList, > + stillimagew_GetDeviceInfo, > + stillimagew_CreateDevice, > + stillimagew_GetDeviceValue, > + stillimagew_SetDeviceValue, > + stillimagew_GetSTILaunchInformation, > + stillimagew_RegisterLaunchApplication, > + stillimagew_UnregisterLaunchApplication, > + stillimagew_EnableHwNotifications, > + stillimagew_GetHwNotificationState, > + stillimagew_RefreshDeviceBus, > + stillimagew_LaunchApplicationForDevice, > + stillimagew_SetupDeviceParameters, > + stillimagew_WriteToErrorLog > +}; You don't really need a separate vtbl for IUnknown. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wininet(2/7): Separate loading libssl from loading libcrypto
by Alexandre Julliard Sept. 30, 2009

Sept. 30, 2009

Juan Lang <juan.lang(a)gmail.com> writes: > This is a step toward relieving lock serialization, as the two > libraries can be loaded independently. (There is no lock yet, though, > and this still crashes in utorrent. Fixes in the next two patches.) There's no reason to invent such complicated locking mechanisms. Just put the whole thing inside a critical section and be done with it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/5] WineD3D: Add a create flag for addref in GetPrivateData
by Henri Verbeet Sept. 30, 2009

Sept. 30, 2009

2009/9/30 Stefan Dösinger <stefan(a)codeweavers.com>: > This is hard to implement in the client lib - it would require to remove the > AddRef from wined3d altogether, and pass the priv data flags to the client, > and then AddRef in d3d8, d3d9 and dxgi/d3d10. I can't use a Release in ddraw > because we're calling application code here which might break if the app's > AddRef() implementation is broken. Handling the AddRef in d3d8/9/10 is a lot > of work because those libs don't have any IDirect3D*Resource base class that > could do this in a central place. I'm not sure why you'd need an entire baseclass, an utility function (which is how it's done in wined3d!) should do just fine. > +const UINT WINED3DCREATE_GET_PRIV_DATA_NO_ADDREFF = 0x00000004; There should only be a single 'F' in ADDREF.

1 0

Re: [2/5] WineD3D: Start replacing dxVersion with create flags
by Henri Verbeet Sept. 30, 2009

Sept. 30, 2009

2009/9/30 Stefan Dösinger <stefan(a)codeweavers.com>: > Is there a real reason this (and the flag from the next patch) has to be set on the wined3d object? If there is, I think WINED3D_CREATE_BUFFER_NO_CONVERSION and WINED3D_CREATE_BUFFER_STATIC_FORMAT would be more appropriate names.

1 0

Re: [comctl32/tests] Fix a test failure on several platforms
by Paul Vriens Sept. 30, 2009

Sept. 30, 2009

On 09/30/2009 02:21 PM, Paul Vriens wrote: > Hi, > > Positioning the point test a bit to the left makes this test succeed on > more boxes. > > (Maybe we should add MCHT_TITLEYEAR to the possible outcomes but I'm not > too sure about that). > > Changelog > Fix a test failure on several platforms > Just checked some other test failures on an XP. This one has more issues but also shows MCHT_TITLEMONTH for the test changed in this patch. Now I'm pretty convinced the fix is not correct, but I stand corrected. -- Cheers, Paul.

1 0

Compile error on current Git
by Paul Vriens Sept. 30, 2009

Sept. 30, 2009

Hi, Anyone else seeing this: make[2]: Entering directory `/wine/wine-git/dlls/system.drv16' ccache gcc -m32 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Wcast-qual -Wlogical-op -o system.o system.c ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./system.drv16.spec system.o -Wb,--subsystem,win16 -o system.drv16.so -lkernel32 ../../libs/port/libwine_port.a system.o: In function `call_timer_proc16': system.c:(.text+0x54a): undefined reference to `NtCurrentTeb' collect2: ld returned 1 exit status winegcc: ccache failed make[2]: *** [system.drv16.so] Error 2 make[2]: Leaving directory `/wine/wine-git/dlls/system.drv16' make[1]: *** [system.drv16] Error 2 (Fedora 11, gcc 4.4.1) -- Cheers, Paul.

2 2

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER
by Paul Vriens Sept. 30, 2009

Sept. 30, 2009

On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: > --- > dlls/ws2_32/tests/sock.c | 46 +++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 37 insertions(+), 9 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Mike, This one has introduced a test failure on Win98 and WinMe. Could you have a look? Let me know if you want me to run extra tests on these boxes. -- Cheers, Paul.

2 2

Re: ddraw: set dwBackBufferCount=0 in CreateSurface for backbuffer
by Stefan Dösinger Sept. 29, 2009

Sept. 29, 2009

Am 29.09.2009 um 15:09 schrieb Markus Stockhausen: > Sorry for the incomplete topic of my first mail. > > <patch.diff> The patch looks ok to me

1 0

Re: wininet(1/3): Only initialize SSL_CTX once
by Hans Leidekker Sept. 29, 2009

Sept. 29, 2009

Hi Juan, > These patches collectively fix bug 18364, which was a crash in OpenSSL > in a multithreaded app (utorrent.exe.) The bug reporter sees long delays between torrents starting up after applying these patches, which makes we wonder if the ssl lock effectively serializes secure https requests? Would patch 1 and 3 not be sufficient to fix the utorrent crash? -Hans

2 1

Re: set caps.dwBackBufferCount=0 for backbuffer surface
by Paul Vriens Sept. 29, 2009

Sept. 29, 2009

On 09/29/2009 03:01 PM, Markus Stockhausen wrote: > > > ------------------------------------------------------------------------ > > Hi Markus, Please stick to the coding style of the file, or at least the surrounding code (implementation and test). -- Cheers, Paul.

2 2

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)
by Nikolay Sivov Sept. 29, 2009

Sept. 29, 2009

Could you please add a test for that?

2 1

Re: wininet: Handle finding ftp files in subdirectories and using wildcards.
by Detlef Riekenberg Sept. 29, 2009

Sept. 29, 2009

On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: > + if (lpszSearchPath) > + HeapFree(GetProcessHeap(), 0, lpszSearchPath); > + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef

1 0

Re: ole32/tests: guard ReleaseStgMedium with SUCCEEDED
by Alexandre Julliard Sept. 29, 2009

Sept. 29, 2009

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > @@ -1401,7 +1405,7 @@ static void test_getdatahere(void) > hr = IDataObject_GetDataHere(get, &fmt, &med); > ok(hr == S_OK, "got %08x\n", hr); > ok(med.tymed == TYMED_HGLOBAL, "got %x\n", med.tymed); > - ReleaseStgMedium(&med); > + if(SUCCEEDED(hr)) ReleaseStgMedium(&med); I don't think that's correct for the GetDataHere case, it's allocated by the caller. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server(4/5): Setting a process's affinity sets all of its threads' affinities too
by Alexandre Julliard Sept. 29, 2009

Sept. 29, 2009

Juan Lang <juan.lang(a)gmail.com> writes: > +static void set_process_affinity( struct process *process, affinity_t affinity ) > +{ > + struct thread *thread; > + > + process->affinity = affinity; > + > + suspend_process( process ); > + LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread, proc_entry ) > + { > + set_thread_affinity( thread, affinity ); > + } > + resume_process( process ); Why are you suspending the process? -- Alexandre Julliard julliard(a)winehq.org

1 0

help with dwBackBufferCount in backbuffer surfaces needed
by Markus Stockhausen Sept. 29, 2009

Sept. 29, 2009

Hi, currently I'm investigating bug 1660 and hopefully I found the reason for the misbehaviour. The only problem is, that I do not know what results I have to expect in windows. So it would be very helpful if someone can execute the attached testcase in a native environment so that I can fix the error condition and send in the final patch. The idea is that backbuffer surfaces have dwBackBufferCount=0 in Windows but on Wine they get the same count as the primary surface. The test will fail in Windows and Wine to get the results in both cases. The result will show like this: dsurface.c:1264: Test failed: backbuffer surface has dwBackBufferCount==2 Thanks for your help in advance. Markus

4 4

Re: [PATCH 10/10] add tests for SHOpenRegStream2A and SHCreateMemStream
by Alexandre Julliard Sept. 29, 2009

Sept. 29, 2009

Peter Oberndorfer <kumbayo84(a)arcor.de> writes: > +#define test_streamsize(stream, size) \ > +{ \ > + STATSTG stat; \ > + HRESULT result; \ > + result = IStream_Stat(stream, &stat, STATFLAG_NONAME); \ > + ok(result == S_OK, "IStream::Stat failed %08x\n", result); \ > + ok(stat.cbSize.QuadPart == size, "Stat size wrong\n"); \ > +} > + > +#define test_value_type(name, wantedtype) \ > +{ \ > + LONG retval; \ > + DWORD type; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, &type, NULL, NULL); \ > + ok(retval == ERROR_SUCCESS, "RegQueryValueExA should succeed, error %d\n", retval); \ > + ok(type == wantedtype, "type of key wrong. wanted %d, got %d\n", wantedtype, type); \ > +} > + > +#define test_value_not_exist(name) \ > +{ \ > + LONG retval; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, NULL, NULL, NULL); \ > + ok(retval == ERROR_FILE_NOT_FOUND, "RegQueryValueExA returned wrong error %d\n", retval); \ > +} > + > +/* older versions (Win98) seem broken, they do not delete the key on close when it is empty */ > +#define test_value_type_broken(name, wantedtype) \ > +{ \ > + LONG retval; \ > + DWORD type; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, &type, NULL, NULL); \ > + ok(retval == ERROR_SUCCESS, "RegQueryValueExA should succeed, error %d\n", retval); \ > + ok(type == wantedtype || broken(type != wantedtype), "type of key wrong. wanted %d, got %d\n", wantedtype, type); \ > +} > + > +#define test_value_not_exist_broken(name) \ > +{ \ > + LONG retval; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, NULL, NULL, NULL); \ > + ok((retval == ERROR_FILE_NOT_FOUND) || broken(retval == ERROR_SUCCESS), \ > + "RegQueryValueExA returned wrong error %d\n", retval); \ > +} Please avoid hiding the code inside macros. When you have only a couple of lines just spell things out explicitly. For larger things write an inline function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 02/15] comctl32/monthcal: Make tests not depend from each other
by Paul Vriens Sept. 29, 2009

Sept. 29, 2009

On 09/27/2009 07:51 PM, Nikolay Sivov wrote: > Changelog: > - Inependent tests are always better and more scalable. > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one seems (there were more for monthcal.c) to have introduced 2 test failures on a lot of boxes. The only reason I see (from the logs on test.winehq.org) is that the failing boxes don't run the English locale. Any idea? -- Cheers, Paul.

2 1

RFC: Sharing a wineprefix
by Paul Chitescu Sept. 29, 2009

Sept. 29, 2009

Hi people! I know this has been talked about again and again and no satisfactory solution (generic, safe, somehow simple) has been found for all. This proposal aims to solve a common scenario with minimum of changes in Wine, in particular remaining compatible with existing installations. It doesn't solve all problems but a quite pressing one: have a bunch of programs installed just once and used by several users. The idea is to have two categories of users: - The Administrator: - Is the owner of the WINEPREFIX, just like now - R/W access to the prefix - Can install and uninstall programs - Exclusive lock, no other user can run in the same prefix at the same time - All others are restricted users: - R/O access to the prefix (including the machine Registry) - They can only write to their profile (including the user Registry) - Can install programs only to their profile if the installer supports so - Cannot run wine in that prefix while the Administrator runs it - Multiple restricted users can run in the same prefix at once UNIX access rights and/or symlinks will be used to: - Make sure other users cannot write to the prefix - Each user has a Wine visible path to his profile directory - Each user can create a new profile directory - or, subject to policy, the Administrator may create (but no need to populate) them in advance Required changes I've identified so far: - The R/W lock to the prefix - wineserver -k as admin should terminate all users' instances - wineserver needs to be able to load Registry hives R/O - wineboot needs to be able to create just the user's profile and ignore pending renames for restricted users - Report to application the detected type of user: Administrator / Restricted - Some winecfg settings need to be migrated from HKCU to HKLM so the admin can enforce sane values or provide proper defaults or because they are logically per prefix - The user Registry hive and the temporary directory for the restricted users need to be stored in their profile directory Advantages: - Not much coding required, less chances to introduce bugs - Will not break existing installations - No trust is required between users, only to Administrator - Each user runs its own wineserver, there is no communication between them - Solves the most common requests from users - Required step to a more complete (but dangerous) extension Disadvantages: - Single admin user - The Administrator cannot run concurrently with other users - To install or remove programs all users need to shutdown their Wine - A restricted user cannot promote to Admin just to do one action (but of course he can su, wineserver -k others, run as Administrator) - Some programs (although not many, most need just to install) need to run as Administrator - After a Wine upgrade the Administrator needs to upgrade the prefix too - All users share the view of the dosdevices (can be moved to the profile dir if we really want to) - Users cannot install programs (except some) or fonts - Doesn't allow non-simultaneous usage of the prefix by different Admins Opinions? Comments? Votes? Although most changes are not complex there is much work and this needs some political decision to proceed to actual coding.

5 5

programs: add extrac32 tool
by Kirill K. Smirnov Sept. 29, 2009

Sept. 29, 2009

Hi, +int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ extrac32 is a console application, isn't it? Why not wmain() instead? And get rid of rather complex ParseCmdLine(). + if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK) ExtCabCallback, 0 )) + WINE_FIXME( "Can not extract cab file:%s!!!\n", wine_dbgstr_w( pszCabFile ) ); This is an error, not a FIXME + if(!argv) + { + WINE_FIXME("Error!Can not get cmd line\n" ); + return 0; + } not a FIXME + if (argc < 2) + { + WINE_FIXME( "No options\n" ); + return 1; + } not a FIXME + if (fArgc != 1) + WINE_FIXME( "Invalid usage for /C flag - two filenames expected\n" ); not a FIXME -- Kirill

2 1

Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().
by Henri Verbeet Sept. 28, 2009

Sept. 28, 2009

> static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index) > { > - FIXME("iface %p, index %u stub!\n", iface, index); > + struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface; > > - return NULL; > + TRACE("iface %p, index %u\n", iface, index); > + > + if(index >= This->member_count) return NULL; > + > + return This->members[index].name; > } You can't do this yet, it needs to work for types created by parse_fx10_type() as well. The same goes for patches 7-11. Patches 1-5 look ok to me, and can stand on their own.

2 1

Review Request: Patch to selectively bind to interfaces while still allowing broadcast packets
by Erich Hoover Sept. 28, 2009

Sept. 28, 2009

Attached is a patch I have been working to fix Bug #7929 (C&C 3 network does not work). This patch replaces interface-specific bind requests (on UDP datagrams only) with a global bind and stores the interface index. The patch then uses IP_PKTINFO to set the outgoing interface and filter incoming packets based on interface (checking against the stored interface index from the initial bind). Additionally, the patch peeks at packets in "select" and asynchronous I/O operations to ensure that spurious wakeups do not occur when a packet comes in from the wrong interface. I intend to split the patch into the following pieces: 1) UDP broadcast tests (used for making sure everything works) 2) The "bare essentials" (storing and retrieving the interface index, and setting/filtering the interface) 3) Ensure "select" does not wake up on packets with an interface mismatch 4) Ensure Async WSARecv does not wake up on packets with an interface mismatch 5) Ensure Async ReadFile does not wake up on packets with an interface mismatch I would greatly appreciate any comments people have on this patch. Thanks so much! Erich Hoover ehoover(a)mines.edu

1 0

Re: [PATCH 3/4] mshtml: Add helper function get_url_components
by Detlef Riekenberg Sept. 28, 2009

Sept. 28, 2009

On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW > *url) > +{ > + const WCHAR *doc_url; > + if(!InternetCrackUrlW(doc_url, 0, 0, url)) { > + FIXME("InternetCrackUrlW failed\n"); Such a FIXME does not help to find the reason. Dumping doc_url helps, but might add personal data to the log -- By by ... Detlef

2 1

Patch for [Bug 14222] RpcBindingSetAuthInfo(Ex) fails with RPC_C_AUTHN_GSS_NEGOTIATE
by Stefan Kuhr Sept. 28, 2009

Sept. 28, 2009

Hello everyone, please find attached a patch for Bug 14222. IIRC I sent a similar patch a year ago or so and never received feedback why it was rejected. Austin encouraged me to send it again, so please if it is unacceptable, let me know why. The patch will make RPC clients work that are written for Windows 2000 (and later), where the negotiate provider performs an automatic fallback to NTLM, if Kerberos is not possible, both in workgroup and domain scenarios. Currently, Wine doesn't have a negotiate and a Kerberos provider. This patch allows clients requesting Negotiate to get the NTLM provider and will still work, even if one day negotiate and Kerberos providers will be added to Wine. Cheers, -- Stefan

1 0

Re: comctl32/tests: Fix monthcal test on NT4
by Greg Geldorp Sept. 28, 2009

Sept. 28, 2009

Hi Nikolay, > Ge van Geldorp wrote: > > Changelog: > > comctl32/tests: Fix monthcal test on NT4 > Hi, Ge. > > This one interfere with a mine, sent yesterday: > > http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html > > Could you wait a bit? I hope this could fix some failures. Sure. I'll resend after your patch is in (if my fix is still needed). Ge.

2 1

Re: d3d9: Don't release the parent device before destroying its children
by Henri Verbeet Sept. 28, 2009

Sept. 28, 2009

2009/9/28 Allan Tong <actong88(a)gmail.com>: > I assume this was done to avoid referencing freed memory, but I'm not > sure if there was any other reason for this. > Not referencing potentially freed memory was the only reason. > Note that this patch only changes d3d9. > Could you write one for d3d8 as well? Otherwise I'll send one tomorrow.

2 1

Re: ole32/tests: fix clipboard tests on Windows
by Alexandre Julliard Sept. 28, 2009

Sept. 28, 2009

"Ge van Geldorp" <ggeldorp(a)vmware.com> writes: > @@ -417,18 +417,23 @@ static HRESULT DataObjectImpl_CreateComplex(LPDATAOBJECT *lplpdataobj) > InitFormatEtc(obj->fmtetc[1], cf_stream, TYMED_ISTREAM); > InitFormatEtc(obj->fmtetc[2], cf_storage, TYMED_ISTORAGE); > InitFormatEtc(obj->fmtetc[3], cf_another, TYMED_ISTORAGE|TYMED_ISTREAM|TYMED_HGLOBAL); > - memset(&dm, 0, sizeof(dm)); > - dm.dmSize = sizeof(dm); > - dm.dmDriverExtra = 0; > - lstrcpyW(dm.dmDeviceName, device_name); > - obj->fmtetc[3].ptd = HeapAlloc(GetProcessHeap(), 0, FIELD_OFFSET(DVTARGETDEVICE, tdData) + sizeof(device_name) + dm.dmSize + dm.dmDriverExtra); > - obj->fmtetc[3].ptd->tdSize = FIELD_OFFSET(DVTARGETDEVICE, tdData) + sizeof(device_name) + dm.dmSize + dm.dmDriverExtra; > - obj->fmtetc[3].ptd->tdDriverNameOffset = FIELD_OFFSET(DVTARGETDEVICE, tdData); > - obj->fmtetc[3].ptd->tdDeviceNameOffset = 0; > - obj->fmtetc[3].ptd->tdPortNameOffset = 0; > - obj->fmtetc[3].ptd->tdExtDevmodeOffset = obj->fmtetc[3].ptd->tdDriverNameOffset + sizeof(device_name); > - lstrcpyW((WCHAR*)obj->fmtetc[3].ptd->tdData, device_name); > - memcpy(obj->fmtetc[3].ptd->tdData + sizeof(device_name), &dm, dm.dmSize + dm.dmDriverExtra); > + if (! broken(TRUE)) /* Windows messes up ptd when doing OleGetClipboard() */ > + { If that case is really unconditionally broken on Windows it doesn't make sense to test it at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 12/12] d3d10/tests: Add test_effect_constant_buffer_type test.
by Henri Verbeet Sept. 28, 2009

Sept. 28, 2009

2009/9/28 Rico Schüller <kgbricola(a)web.de>: > + ID3D10Effect* effect; I'd prefer it if that was written as "ID3D10Effect *effect;" > + ok(SUCCEEDED(hr), "ID3D10EffectType::GetDesc failed!\n"); Please print the actual error code as well. > + ok(type_desc.Elements == 0, "Elements is %i, expected 0\n", type_desc.Elements); > + ok(type_desc.Members == 2, "Members is %i, expected 2\n", type_desc.Members); > + ok(type_desc.Rows == 0, "Rows is %i, expected 0\n", type_desc.Rows); > + ok(type_desc.Columns == 0, "Columns is %i, expected 0\n", type_desc.Columns); These are unsigned variables. > + string = type->lpVtbl->GetMemberName(type, 0); > + ok(strcmp(string, "f1") == 0, "GetMemberName(0) is \"%s\", expected \"f1\"\n", string); You should probably use wine_dbgstr_a() for this.

1 0