September 2009 - Wine-Devel

Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 4, 2009

Sept. 4, 2009

Hi, although wine in MacOSX works generally good enough (see test.winehq.org about release 1.1.28), I recently visited the print menu in notepad and wordpad to see whether printing would work (in order to complete the FAQ). All that happened is that the printer ejected a blank page. Was anyone more successful than me at printing? - My printer appears in Notepad's and Wordpad's menus, so that's a start. - The page size and portrait/landscape selection dialogue appears. - The OSX printer status shows something is happening. - However the printer only ejects a blank page. - The console shows no particular log line. o Do my troubles arise from the fact that I compile Wine only with standard MacOS libraries? E.g. liblcms (color management) is missing from my system (but no error message signals that it would have been used at run-time). o Should I have tried a "real" app instead of (fake) notepad? Using Mac OS X 10.5.7 and wine compiled myself (see Wiki.winehq.org about how). Regards, Jörg Höhle

3 2

Re: urlmon: Add test for IsValidURL [try 2]
by Vladimir Pankratov Sept. 4, 2009

Sept. 4, 2009

Hello all. What do you think about this? What's wrong in this patch? Any comments? Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > Now test shows error codes and tests exact code. > > Thanks Jacek. > > changed files: > dlls/urlmon/tests/misc.c > > Thanks. > > > > > ------------------------------------------------------------------------ > > diff -u -r a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/misc.c > --- a/dlls/urlmon/tests/misc.c 2009-08-21 23:34:16.000000000 +0500 > +++ b/dlls/urlmon/tests/misc.c 2009-09-01 18:53:08.000000000 +0500 > @@ -1326,6 +1326,44 @@ > IBindCtx_Release(bctx); > } > > +static void test_IsValidURL(void) > +{ > + HRESULT hr; > + int i; > + static const WCHAR good_urls[][100] = { > + {'f','i','l','e',':','/','/','c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'h','t','t','p',':','/','/','w','w','w','.','w','i','n','e','h','q','.','o','r','g',0}, > + {'h','t','t','p','s',':','/','/','s','e','c','u','r','e','.','h','o','s','t','.','d','o','m',0}, > + {'f','t','p',':','/','/','s','o','u','r','c','e','f','o','r','g','e','.','o','r','g',0}, > + {'c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'m','k',0}, > + {'h','t','t','p','s',0} > + }; > + static const WCHAR bad_urls[][100] = { > + {'w','i','n','e','h','q','.','o','r','g',0}, > + {'l','o','c','a','l','h','o','s','t',0}, > + {'t','e','s','t',0}, > + {'1','2','7','.','0','.','0','.','1',0}, > + {'b','o','o','t','.','i','n','i',0} > + }; > + > + hr = IsValidURL(NULL, 0, 10); > + > + ok(hr == E_INVALIDARG, "IsValidURL should fail, expected E_INVALIDARG, got %08x.\n", hr); > + > + for(i = 0; i < sizeof(good_urls)/sizeof(good_urls[0]); i++) > + { > + hr = IsValidURL(NULL, good_urls[i], 0); > + ok(hr == S_OK, "URL %s must be valid, expected S_OK, got %08x.\n", wine_dbgstr_w(good_urls[i]), hr); > + } > + > + for(i = 0; i < sizeof(bad_urls)/sizeof(bad_urls[0]); i++) > + { > + hr = IsValidURL(NULL, bad_urls[i], 0); > + ok(hr == S_FALSE, "URL %s must be invalid, expected S_FALSE, got %08x.\n", wine_dbgstr_w(bad_urls[i]), hr); > + } > +} > + > START_TEST(misc) > { > OleInitialize(NULL); > @@ -1345,6 +1383,7 @@ > test_UrlMkGetSessionOption(); > test_user_agent(); > test_MkParseDisplayNameEx(); > + todo_wine test_IsValidURL(); > > OleUninitialize(); > }

2 1

Re: gdi32/tests: Add test for SelectClipRgn in metafile
by Dmitry Timoshkov Sept. 4, 2009

Sept. 4, 2009

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + hdc = CreateEnhMetaFileA(0, NULL, NULL, NULL); > + > + SetRect(&rc_sclip, 100, 100, GetSystemMetrics(SM_CXSCREEN), GetSystemMetrics(SM_CYSCREEN)); > + hrgn = CreateRectRgn(rc_sclip.left, rc_sclip.top, rc_sclip.right, rc_sclip.bottom); > + SelectClipRgn(hdc, hrgn); > + GetClipBox(hdc, &rc_res); > + todo_wine ok(EqualRect(&rc_res, &rc_sclip), > + "expected rc_res (%d, %d) - (%d, %d), got (%d, %d) - (%d, %d)\n", > + rc_sclip.left, rc_sclip.top, rc_sclip.right, rc_sclip.bottom, > + rc_res.left, rc_res.top, rc_res.right, rc_res.bottom); > + > + CloseEnhMetaFile(hdc); > + DeleteObject(hrgn); You are leaking a metafile here. -- Dmitry.

1 0

font-shape/font-query related regression in wine 1.1.28
by Hin-Tak Leung Sept. 4, 2009

Sept. 4, 2009

My favourite mono/.net application dies with 'Style Regular isn't supported by font Tahoma' in 1.1.28. I did a git bisect and commit 0b9ba054f6c8a2d96c898e7325087f56a6224644 Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Aug 12 19:19:32 2009 +0200 was the entry that breaks, but just reversing it in 1.1.28 does not fix the problem - i.e. more problematic commits later?; however, replacing the wine-shipped tahoma fonts with those from Vista does cure the problem; so does simply deleting them from $WINEPREFIX/drive_c/windows/fonts (and allow substitution from system fonts happen, I think). I don't know why a german translation would affect my environment (LANG=en_GB.utf8) and setting LANG=C does not fix the problem. In any case, the correct fix is probably working out what vista-shipped tahoma does which differs from wine-shipped tahoma? Anybody has any thought on this issue?

3 4

New winetricks 20090902: new verbs vc2005trial, python26
by Dan Kegel Sept. 3, 2009

Sept. 3, 2009

Another week, another winetricks. The only interesting changes are new verbs vc2005trial and python26. These are only of interest to developers. vc2005trial is the 180 day Team Server edition of Visual C++ 2005. The winetricks verb for this is a bit odd - it prompts you for your password so it can mount the volume before installation. If you have a better idea, please let me know. I haven't done a KDE version of the prompt; patches welcome. I also haven't implemented -q for this; it's hard to figure out, even with hints (see the comments). If anyone wants to tackle it, be my guest, I'd love to have unattended install working. The python26 verb includes pywin32, since that was needed by the script I was trying to run (the gyp self-test). Most people will just use Linux python, but when you're running a win32-specific python script, the windows python interpreter comes in pretty handy. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Thanks to Austin English for various patches and assistance.

2 3

re: Wine t-shirts?
by Dan Kegel Sept. 3, 2009

Sept. 3, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.
by Dylan Smith Sept. 2, 2009

Sept. 2, 2009

On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych <khodych(a)gmail.com> wrote: > @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey) > ME_SendRequestResize(editor, FALSE); > return TRUE; > case VK_RETURN: > + if (editor->bDialogMode) > + { > + DWORD dwStyle; > + > + if (ctrl_is_down) > + return TRUE; > + > + dwStyle = GetWindowLongW(editor->hWnd, GWL_STYLE); > + if (!(dwStyle & ES_WANTRETURN)) > + { > + DWORD dw; > + dw = SendMessageW(editor->hwndParent, DM_GETDEFID, 0, 0); > + if (HIWORD(dw) == DC_HASDEFID) > + { > + HWND hwDefCtrl = GetDlgItem(editor->hwndParent, LOWORD(dw)); > + if (hwDefCtrl) > + { > + SendMessageW(editor->hwndParent, WM_NEXTDLGCTL, (WPARAM)hwDefCtrl, (LPARAM)TRUE); > + PostMessageW(hwDefCtrl, WM_KEYDOWN, VK_RETURN, 0); > + } > + } > + return TRUE; > + } > + } > + > if (editor->styleFlags & ES_MULTILINE) > { > ME_Cursor cursor = editor->pCursors[0]; 1. editor->hWnd may be NULL for windowless richedit controls, but you code doesn't seem to take that into consideration. 2. The style flags that you get from GetWindowLongW should probably come from the cached values in editor->styleFlags. 3. Is there any need for storing the hwndParent in editor. Couldn't the value be obtained by using GetWindowLongW using GWL_HWNDPARENT after making sure that editor->hWnd is non-NULL (i.e. windowed mode).

2 3

Re: [PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.
by Stefan Dösinger Sept. 2, 2009

Sept. 2, 2009

Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet: > + GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB, > GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); + > checkGLcall("glGetProgramivARB()"); > + if (!native) WARN("Program exceeds native resource limits.\n"); > + } shouldn't that be a FIXME? The most likely reasons for this are either that we advertise incorrect caps, or our privately added code breaks the limits, or that the driver is broken. In the first two cases we can do something, and in the other case we might want to report the issue to the driver devs That said, I haven't seen a GL implementation yet that successfully compiles and SW-emulates a program that exceeds the limits.

2 2

Re: gdiplus/tests: Fix test on Win7
by Vincent Povirk Sept. 2, 2009

Sept. 2, 2009

- gdiplusStartupInput.GdiplusVersion = 2; + gdiplusStartupInput.GdiplusVersion = 42; Could you please test the intermediate versions to determine what's supported? You could use a loop to determine the highest supported version (making sure the return is UnsupportedGdiplusVersion if it's not Ok) followed by a test that the highest supported version is between 1 and some constant. In fact, knowing the supported version would be helpful in any case, and it would be nice to have a trace() printing it. On Wed, Sep 2, 2009 at 5:16 AM, Ge van Geldorp<ggeldorp(a)vmware.com> wrote: > Changelog: > gdiplus/tests: Fix test on Win7 > > --- > dlls/gdiplus/tests/pen.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > > > > -- Vincent Povirk

1 1

Re: [PATCH 1/3] jscript: Added to_primitive on hosting objects test.
by Alexandre Julliard Sept. 2, 2009

Sept. 2, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/tests/run.c | 32 ++++++++++++++++++++++++++++---- > 1 files changed, 28 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:216: Test failed: V_VT(pvarRes) = 63784 make[2]: *** [run.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0