September 2009 - Wine-Devel

Re: user32: Add check for the need to redraw static control after STM_SETIMAGE and STM_SETICON
by Nikolay Sivov Sept. 28, 2009

Sept. 28, 2009

Ilya Shpigor wrote: > Hi, > > This patch fix the redrawing static controls after the processing STM_SETIMAGE > and STM_SETICON messages with errors. > --- + if ((style & SS_TYPEMASK) != SS_ICON) return (HICON)-1; ... + if ((style & SS_TYPEMASK) != SS_BITMAP) return (HBITMAP)-1; ... + if ((style & SS_TYPEMASK) != SS_ENHMETAFILE) return (HENHMETAFILE)-1; --- Add tests for that please (MSDN tells about 0 return value on error).

3 3

Re: comctl32/tests: Fix monthcal test on NT4
by Nikolay Sivov Sept. 28, 2009

Sept. 28, 2009

Ge van Geldorp wrote: > Ignore MCHT_TITLEBK, title elements might be adjacent without any > background in between. > > Changelog: > comctl32/tests: Fix monthcal test on NT4 > > --- > dlls/comctl32/tests/monthcal.c | 17 +++++++++-------- > 1 files changed, 9 insertions(+), 8 deletions(-) > Hi, Ge. This one interfere with a mine, sent yesterday: http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html Could you wait a bit? I hope this could fix some failures.

1 0

Running 13 months locales
by Nikolay Sivov Sept. 27, 2009

Sept. 27, 2009

Hi. Working on monthcal control I've realized that some locales could have 13 months calendars. How could I guess that I'm running such locale? After a brief look I didn't find anything useful in GetLocaleInfo().

3 5

Re: newbie question
by James Mckenzie Sept. 27, 2009

Sept. 27, 2009

>Hello All, > >can somebody tell weather it is possible to run NT service on Wine, >especially written in Delphi VCL(TService) > Services do not natively run on Wine startup. You have to start them and then leave at least one window open. If your service depends on direct hardware access or the use of any special device driver, it will not work in Wine as it does not recreate all of the functionality of Windows. You are welcome to attempt to try and run your service under Wine and advise what happened. James McKenzie

3 2

New version of UUID lookup tool
by Mikołaj Zalewski Sept. 27, 2009

Sept. 27, 2009

Hi, I had little time to work on Wine lately, but recently I could work a bit on my UUID database. The new version retrieves the identifier name after __declspec(uuid) macros and is available as an online app on AppEngine at http://mikolajapp.appspot.com/uuid/ . The offline version with the source code is available at http://www.mikolaj.zalewski.pl/dl/uuid2.tgz . Mikołaj

1 0

Re: programs: add extrac32 tool
by Nikolay Sivov Sept. 27, 2009

Sept. 27, 2009

Andrey Turkin wrote: > > Taken from Etersoft git tree with some small fixes (code style, > constness etc) and minimal /C mode support required to fix bug 18097. > --- > configure.ac | 1 + > programs/extrac32/Makefile.in | 16 ++ > programs/extrac32/extrac32.c | 423 > +++++++++++++++++++++++++++++++++++++++++ > programs/extrac32/parsecmd.c | 100 ++++++++++ > 4 files changed, 540 insertions(+), 0 deletions(-) > create mode 100644 programs/extrac32/Makefile.in > create mode 100644 programs/extrac32/extrac32.c > create mode 100644 programs/extrac32/parsecmd.c Hi, Andrey. The first spotted: --- +int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ ... + UINT j = 0; --- This initializer looks redundant --- +LPWSTR* ParseCmdline( LPCWSTR cmdline, int *argc ) + BOOL bQuote = FALSE; ... + i = j = k = z = nQuotes = 0; --- This is redundant for i and nQuotes at least.

1 0

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx
by Vitaliy Margolen Sept. 27, 2009

Sept. 27, 2009

Wilfried Pasquazzo wrote: > Best regards, > > Subject: Make DrawIconEx 2 additional tests (now passes all tests) > Subject: Make DrawIconEx pass a test You should really combine these 2 patches. You are modifying the same exact code and breaking it between patches (for some programs). Vitaliy.

1 0

"itune developement statues"
by Zhong Jiang Sept. 27, 2009

Sept. 27, 2009

Hi, I'm writing for the itunes progress and I've seen that the progress is rather on the negative side so I want to inquire on statues and is there anyway that I can help to further this progress.

1 0

Appinstall now supports standalone testing
by Austin English Sept. 27, 2009

Sept. 27, 2009

Howdy all, I've tweaked appinstall slightly so that anyone can run it without needing an ssh webserver to host the files. Simply do: $ wget http://winezeug.googlecode.com/svn/trunk/appinstall/appinstall.sh $ sh appinstall.sh That will download all the programs and run the tests. The results will be stored in `cwd`/appinstall-$date. Subsequent test runs of course will have the downloads cached, so they'll be much quicker. A couple things to note: you can change the tag name by doing: $ sh appinstall.sh tagname The result directory will then be `cwd`/appinstall-tagname. Lastly, you can override the version of wine used with: $ WINE=~/wine-git/wine sh appinstall.sh So now you have no excuse not to test your dangerous patches before sending to wine-patches ;-). -- -Austin

1 0

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx
by Juan Lang Sept. 26, 2009

Sept. 26, 2009

Hi Wilfried, minor comment on this patch: hBitTemp = SelectObject( hMemDC, hXorBits ); + + UINT bltFlag = 0; C89 doesn't allow you to mix code and declarations like this. You'll have to declare bltFlag at the top of the block. --Juan

1 0