September 2009 - Wine-Devel

Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE
by Detlef Riekenberg Sept. 26, 2009

Sept. 26, 2009

On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote: > * sti: test behavior of creation with the A/W functions versus > STI_VERSION_FLAG_UNICODE Using the name "sti_tests" is bad. The short "sti" is enough. You forgot the license notice We usually cast the result of GetProcAddress() as (void *). That is not perfect, but much better to read. -- By by ... Detlef

1 0

Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation
by Detlef Riekenberg Sept. 26, 2009

Sept. 26, 2009

On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > + todo_wine ok(SUCCEEDED(hres), "get_hash failed: 0x%08x\n", > hres); > + if(SUCCEEDED(hres)){ > + if(str_pass) > + ok(strcmp_wa_null(str, exp) == 0, "expected retrieved > hash to be L\"%s\", was: %s\n", exp, wine_dbgstr_w(str)); > + else > + todo_wine ok(strcmp_wa_null(str, exp) == 0, "expected > retrieved hash to be L\"%s\", was: %s\n", exp, wine_dbgstr_w(str)); > + } > +} > + Your Patch is hard to read. Please split the long lines (3 parts are easy) The whole patch can be split in smaller patches. > +static void perform_test(const struct location_test* test) In the case of a test failure or a crash, there is no chance to know, which test-set failed. A suffix (protocol name or line number) at the start of every ok() can be used to make the normal output as silent as possible. Using a trace before you call perform_tests() works also. That produce a bit noise in the result file, but the test binary is smaller. -- By by ... Detlef

1 0

Re: kernel32: check parameter of CheckRemoteDebuggerPresent with tests
by Alexandre Julliard Sept. 26, 2009

Sept. 26, 2009

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + SetLastError(0xdeadbeef); > + bret = pCheckRemoteDebuggerPresent(INVALID_HANDLE_VALUE,NULL); > + ok(!bret , "expected CheckRemoteDebuggerPresent to fail\n"); > + ok(ERROR_INVALID_PARAMETER == GetLastError(), > + "expected error ERROR_INVALID_PARAMETER, got %d/%x\n",GetLastError(), GetLastError()); It doesn't make sense to pass INVALID_HANDLE_VALUE as a process handle, it's only for files. You probably want GetCurrentProcess(). -- Alexandre Julliard julliard(a)winehq.org

1 0

cppcheck sept 18 redux
by chris ahrendt Sept. 26, 2009

Sept. 26, 2009

False positive ticket created for: [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 what about the others? or the suggestion of adding an additional int to the array? chris

11 25

re: [3/6] ntdll: Move logic which computes file attributes to new function DIR_get_attributes() (take 4)
by Dan Kegel Sept. 25, 2009

Sept. 25, 2009

Hi Alexandre, thanks for committing the tests and cmd changes. What's left before the DIR_get_attribute change is up to snuff?

2 1

Ignore EINTR poll result code in WS_select
by Dmitriy Anisimkov Sept. 25, 2009

Sept. 25, 2009

Dear Wine Developers, Looks like such ignorance is usual practice in wine. I just need to ignore EINTR in one more place. Otherwise our client application is bad working in Wine.

4 4

Re: jscript: Update German translation
by Stefan Leichter Sept. 25, 2009

Sept. 25, 2009

Am Friday 25 September 2009 17:37:24 schrieb André Hentschel: > --- > dlls/jscript/jscript_De.rc | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) + IDS_JSCRIPT_EXPECTED "JScript bjekt erwartet" looks like you miss an "O" -- Stefan

1 0

Re: [4/7] comctl32/updown: Show that UDS_SETBUDDYINT switching doesn't affect behaviour for already created control
by Paul Vriens Sept. 25, 2009

Sept. 25, 2009

On 09/20/2009 10:02 PM, Nikolay Sivov wrote: >> From 8981901ce08501229487a1fcd2d430490cb66823 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov<bunglehead(a)gmail.com> > Date: Sun, 20 Sep 2009 02:52:39 +0400 > Subject: Tests to show that UDS_SETBUDDYINT switching doesn't affect behaviour for already created control > > --- > dlls/comctl32/tests/updown.c | 59 ++++++++++++++++++++++++++++++++++++----- > 1 files changed, 51 insertions(+), 8 deletions(-) > Hi Nikolay, This one (and also "[5/7] comctl32/updown: Fix control behaviour for UDS_SETBUDDYINT style") add some tests that use UDM_GETPOS32 and/or UDM_SETPOS32. These are only available as of 5.80. We are already skipping tests in updown because of this, but not these new ones yet. Any idea about the cleanest approach? -- Cheers, Paul.

2 3

Wine-Tango Updates
by Joel Holdsworth Sept. 25, 2009

Sept. 25, 2009

Hi All, Thanks to those of you who made comments about my Tango icon set. I've thought carefully about all the comments I've received, and I'm most of the way through the issues raised. I've revised idb_std_large.bmp, idb_std_small.bmp, floppy.ico, mycomputer.ico, netdrive.ico, netdrive2.ico, shortcut.ico, dxdiag, notepad, and wordpad. I still have one or two icons that I haven't yet touched: mydocs.ico, certwatermark.bmp, oic_hand.ico, iexplore, but I thought I'd share what I have while it's fresh in people's minds. Take a look http://www.airwebreathe.org.uk/wine-icon/ Let me know if you have more comments. Best Regards Joel

4 3

[bugzilla] donate to sponsoring bug
by sacchi antonio Sept. 25, 2009

Sept. 25, 2009

hello all. I'm new here but I'd like to suggest something, what do you think about this? http://img29.imageshack.us/img29/2940/wined.png Maybe it will be good for old/hard bugs? Thanks

6 9