January 2010 - Wine-Devel - list.winehq.org

Re: wmc: Fix symbol was not declared and using plain integer as NULL pointer sparse warnings.
by Jacek Caban Jan. 21, 2010

Jan. 21, 2010

Hi Rob, On 1/21/10 12:57 PM, Rob Shearman wrote: > --- > tools/wmc/wmc.c | 8 +++++--- > tools/wmc/wmc.h | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > --- a/tools/wmc/wmc.h +++ b/tools/wmc/wmc.h @@ -65,7 +65,7 @@ extern node_t *nodehead; extern lan_blk_t *lanblockhead; int mcy_lex(void); -FILE *yyin; +extern FILE *yyin; It looks like it worked before your patch only because it's used only in wmc.c, which means that it probably should be static. Thanks, Jacek

2 2

Re: cmd: Added cmd.exe tests.
by Paul Vriens Jan. 21, 2010

Jan. 21, 2010

On 01/20/2010 06:35 PM, Jacek Caban wrote: > --- > programs/cmd/tests/Makefile.in | 14 ++ > programs/cmd/tests/batch.c | 286 ++++++++++++++++++++++++++++++++++ > programs/cmd/tests/rsrc.rc | 23 +++ > programs/cmd/tests/test_echo.cmd | 9 + > programs/cmd/tests/test_echo.cmd.out | 21 +++ > 5 files changed, 353 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/Makefile.in > create mode 100644 programs/cmd/tests/batch.c > create mode 100644 programs/cmd/tests/rsrc.rc > create mode 100644 programs/cmd/tests/test_echo.cmd > create mode 100644 programs/cmd/tests/test_echo.cmd.out > Hi Jacek, Is the intention to have these being part of winetest? I do think more makefile magic (Dan's old patches?) is needed to get this actually to compile, not? -- Cheers, Paul.

2 1

Some Wine development statistics
by Paul Vriens Jan. 21, 2010

Jan. 21, 2010

Hi, Just found this: http://gitstats.sourceforge.net/examples/wine/index.html -- Cheers, Paul.

1 0

Re: [PATCH] user32/tests: check that SetCursorPos doesn't call hooks.
by Nicolas Le Cam Jan. 21, 2010

Jan. 21, 2010

2010/1/21 Lauri Kenttä <lauri.kentta(a)gmail.com>: > SetCursorPos should not call mouse low-level hooks. > --- > dlls/user32/tests/input.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c > index 7713ff6..a5dba06 100644 > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -1198,6 +1198,7 @@ static void test_keynames(void) > > static POINT pt_old, pt_new; > static BOOL clipped; > +static int hook_proc2_call_times; > #define STEP 3 > > static LRESULT CALLBACK hook_proc1( int code, WPARAM wparam, LPARAM lparam ) > @@ -1231,6 +1232,8 @@ static LRESULT CALLBACK hook_proc2( int code, WPARAM wparam, LPARAM lparam ) > MSLLHOOKSTRUCT *hook = (MSLLHOOKSTRUCT *)lparam; > POINT pt; > > + ++hook_proc2_call_times; > + > if (code == HC_ACTION) > { > ok(hook->pt.x == pt_new.x && hook->pt.y == pt_new.y, > @@ -1281,6 +1284,7 @@ static void test_mouse_ll_hook(void) > HHOOK hook1, hook2; > POINT pt_org, pt; > RECT rc; > + int hook_proc2_call_times_old; > > GetCursorPos(&pt_org); > hwnd = CreateWindow("static", "Title", WS_OVERLAPPEDWINDOW | WS_VISIBLE, > @@ -1347,6 +1351,18 @@ static void test_mouse_ll_hook(void) > GetCursorPos(&pt); > ok(pt.x == pt_new.x && pt.y == pt_new.y, "Position changed: (%d,%d)\n", pt.x, pt.y); > > + /* Check that SetCursorPos doesn't call hooks. > + * Check twice: first moving to old coordinates, then to new. */ > + SetCursorPos(10, 10); > + > + hook_proc2_call_times_old = hook_proc2_call_times; > + SetCursorPos(10, 10); > + ok(hook_proc2_call_times_old == hook_proc2_call_times, "Hooks called\n"); > + > + hook_proc2_call_times_old = hook_proc2_call_times; > + SetCursorPos(20, 20); > + ok(hook_proc2_call_times_old == hook_proc2_call_times, "Hooks called\n"); > + > UnhookWindowsHookEx(hook2); > done: > DestroyWindow(hwnd); > -- > 1.6.6 > > > > Hi Lauri, What about resetting hook_proc2_call_times to 0 before calling SetCursorPos and just checking if it has changed ? Also other static variables used in hook procs aren't prefixed, this is more trivial but everyone is encouraged to follow current code style of the file. -- Nicolas Le Cam

2 1

Re: gdi32: Add OEM charset for processing in TranslateCharsetInfo
by Dmitry Timoshkov Jan. 21, 2010

Jan. 21, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > Some details about this patch: > > The getting charset through the GetTextCharset works with mistakes for OEM > charset. The problem exist in SelectObject where the gdi font is created from > the logical font. Wine try to get information about the charset in this gdi > font creation through TranslateCharsetInfo, but don't able to do it. This > function works with predefined array of supported charsets and code pages. > OEM charset is absent in this array. > > Full list of this array in MSDN: > http://msdn.microsoft.com/en-us/library/dd317754%28VS.85%29.aspx > > This patch add the necessary items to this array. Then you need to add an extensive set of tests for TranslateCharsetInfo() to confirm that it's the source of the problem. Somehow I doubt that this is a correct place for the fix. -- Dmitry.

1 0

example code appending files with w32api broken?
by Hin-Tak Leung Jan. 21, 2010

Jan. 21, 2010

I needed a WIN32 API based file-appending solution to fix a bug (http://bugs.winehq.org/show_bug.cgi?id=21394) and using the example code http://msdn.microsoft.com/en-us/library/aa363778%28VS.85%29.aspx as reference, I have got a somewhat working solution, except if I follow the code, the WriteFile part for appending fails. Then I have cross-gcc compiling that example source code standard-alone, and the resulting executable won't append under wine cmd either. So it looks like either the example code is wrong, or wine's implementation of WriteFile() is a bit broken sometimes. I have determined the ReadFile succceeds and the SetFilePointer() also work) So I have two questions - (1) can somebody tell if there is something obviously wrong with the example, (2) can somebody say if it is because wine is not working e.g. SetPointer doesn't work? On a general question: what's the policy of patches based on MSDN example code like this? I mean, assuming the example does the job, it is quite difficult to write file-appending code which isn't quite similiar to that.

2 5

Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
by Nikolay Sivov Jan. 20, 2010

Jan. 20, 2010

On 1/20/2010 23:46, Andrew Eikum wrote: > --- > dlls/wininet/internet.c | 6 ++++++ > dlls/wininet/tests/internet.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+), 0 deletions(-) > Please mark patches with (tryX) in subject and specify a difference from previous try next time. It's really hard to follow identically named mails without a single line of details.

1 0

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)
by Paul Vriens Jan. 20, 2010

Jan. 20, 2010

On 01/11/2010 09:47 PM, Peter Dons Tychsen wrote: > Try 3 of this patch: > > - Moved check to server. > - Removed handling of error code translation after input from AJ. > > Thanks, > > /pedro > > Hi Peter, This patch has introduced test failures on NT4 and below (tested locally): http://test.winehq.org/data/tests/user32:win.html The callback is entered several times on NT4 (only once on XP) so it seems. The test crashes on Win98 btw. Could you have a look? You can use the winetestbot (https://winetestbot.geldorp.nl/) to check the failures on NT4. I can assist with Win9x testing if needed. I'm busy setting up a local winetestbot that includes Win95, Win98 and WinMe. -- Cheers, Paul.

2 2

Re: oleaut32: do not crash in logging if string is NULL
by Alexandre Julliard Jan. 20, 2010

Jan. 20, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -68,10 +68,16 @@ typedef struct _marshal_state { > > /* used in the olerelay code to avoid having the L"" stuff added by debugstr_w */ > static char *relaystr(WCHAR *in) { > - char *tmp = (char *)debugstr_w(in); > - tmp += 2; > - tmp[strlen(tmp)-1] = '\0'; > - return tmp; > + static char szNull[] = "<NULL>"; > + if (in) > + { > + char *tmp = (char *)debugstr_w(in); > + tmp += 2; > + tmp[strlen(tmp)-1] = '\0'; > + return tmp; > + } > + else > + return szNull; > } This should never happen. Places that can get a null pointer should use the standard debugstr_w. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: kernel32/tests: do not compare handle with zero directly (Smatch)
by Dan Carpenter Jan. 20, 2010

Jan. 20, 2010

Sorry, I'm not on the list. - ok( file != 0, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); + ok( !!file, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); Smatch sees those as equivelent. (The new version does at least http://repo.or.cz/w/smatch.git) There is a wine_checker.sh script in smatch_scripts so you can quickly test individual files. I just pushed a change to make wine_checker.sh find the smatch binary so you may want to pull the most recent changes. /path/to/smatch_scripts/wine_checker.sh dlls/kernel32/tests/virtual.c Michael said it could be either real bug or a false positive. I sort of decided it was a false positive and pushed a change to fix that. Now if "file" gets 1) reassigned 2) incremented/decremented 3) passed to a function like this: fuction(&file); it stops being called a filehandle. (Unless it gets reassigned another file handle obviously). Hope that is Ok. The check only prints a warning if something is _definitely_ a file handle and it gets compared to zero. I could easily change it to print a message if something is _possibly_ a file handle and gets compared against zero. Like this: if (x) file = CreateFile(); else file = some_func(); if (file) // <- complain I know smatch has been abandonware for a long time, but I hope to do better now. regards, dan carpenter

1 2

WINEDEBUG=+relay: why unicode arguments printed in form L"\0412\044b" and not L"\x412\x44b"? 044b sure not octal
by Илья Басин Jan. 20, 2010

Jan. 20, 2010

/////////////////////////// #include <windows.h> int main() { MessageBoxExW(NULL, L"\x412\x44b \x434\x435\x439\x441\x442\x432\x438\x442\x435\x43b\x44c\x43d\x43e \x445\x43e\x442\x438\x442\x435 \x443\x434\x430\x43b\x438\x442\x44c \"\x43f\x440\x438\x43f\x430\x440\x43a\x43e\x432\x430\x43d\x43d\x44b\x435\" \x43f\x438\x441\x44c\x43c\x430?\r\r\x410\x442\x440\x438\x431\x443\x442 \x41f\x430\x440", L"The Bat! Voyager", 0x00012133, 0x00000019); } /////////////////////////// # WINEDEBUG=+relay wine msgbox.exe 2>&1 | grep "MessageBoxExW" 0009:Call user32.MessageBoxExW(00000000,0040a028 L"\0412\044b \0434\0435\0439\0441\0442\0432\0438\0442\0435\043b\044c\043d\043e \0445\043e\0442\0438\0442\0435 \0443\0434\0430\043b\0438\0442\044c \"\043f\0440\0438\043f\0430\0440\043a\043e\0432\0430\043d\043d\044b\0435\" \043f\0438\0441\044c\043c\0430?\r\r\0410\0442\0440\0438\0431\0443\0442 \041f\0430\0440",0040a000 L"The Bat! Voyager",00012133,00000019) ret=0040101c 0009:Ret user32.MessageBoxExW() retval=00000000 ret=0040101c

2 1

Re: [PATCH 4/5] wined3d: Don't use the depth range clipping hack when we have ARB_depth_clamp.
by Chris Robinson Jan. 20, 2010

Jan. 20, 2010

On Tuesday 19 January 2010 2:52:28 pm Henri Verbeet wrote: > ARB_depth_clamp should give pretty much the desired behaviour by clamping > instead of clipping depth values outside the depth range. I think you need to make sure glEnable(GL_DEPTH_CLAMP) gets called in state_clipping if you're going to bypass the depth range hack with it. Currently it's only called if WINED3DRS_CLIPPING is off.

3 8

valgrind run called on account of rain
by Dan Kegel Jan. 20, 2010

Jan. 20, 2010

Today's scheduled match between Valgrind and Wine was called on account of rain. The roofers think they found where the water was coming in, and the rainstorm can't last forever; I'm hoping to turn the Valgrind build machine on again later this week. Once it dries out :-)

4 4

Re: [PATCH 3/5] wined3d: Don't use the depth range clipping hack when minZ and maxZ are equal.
by Stefan Dösinger Jan. 20, 2010

Jan. 20, 2010

Am 19.01.2010 um 23:52 schrieb Henri Verbeet: > - if (!stateblock->device->untransformed) > + if (!stateblock->device->untransformed && minZ != maxZ) My tests show that this is not needed, at least in d3d8 and d3d9. My (unsent) tests show that if you pass MinZ == MaxZ SetViewport adjusts one of them to make sure they're apart by at least 0.001. If the parameters are < 0.999 maxZ is incremented by 0.001, otherwise minZ is set to 0.999. (If my memory serves me right) That said, I will be busy the next 2 weeks at university, so don't expect the test and a fix for SetViewport in in that time. Plus, I still haven't ported my tests to ddraw, which may behave differently. If it helps your work feel free to put the patch in in the meantime, although obviously it would be better to skip it to avoid forgetting about it later.

1 0

re: Usage of libxml2 for several modules
by Dan Kegel Jan. 19, 2010

Jan. 19, 2010

http://xmlsoft.org/threads.html says it's only a problem if the same document is being parsed by both threads. The trouble scenario seems unlikely, offhand.

4 7

Re: [6/10] winemapi: Add MAPIInitialize implementation.
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Nguyen <arethusa26(a)gmail.com> writes: > This seemed to be the easiest and most trivial way to allow > MAPIInitialize to succeed in the tests, which will be added in the > next several patches. That doesn't seem right. The tests should be able to work without an extended provider. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in > index ba8f662..66a756f 100644 > --- a/dlls/wininet/tests/Makefile.in > +++ b/dlls/wininet/tests/Makefile.in > @@ -10,6 +10,7 @@ CTESTS = \ > generated.c \ > http.c \ > internet.c \ > + option.c \ This can go with the other internet tests in internet.c, there's no need for a new file. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/6] ws2_32: convert wsa errors to ntstatus in overlapped callbacks
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -542,6 +542,35 @@ static inline DWORD NtStatusToWSAError( const DWORD status ) > return wserr; > } > > +/* most ws2 overlapped functions return an ntstatus-based error code */ > +static inline NTSTATUS WSAErrorToNtStatus( const DWORD error ) > +{ In general conversions should go status->error, not the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Fix the Ctrl+Break processing
by Dmitry Timoshkov Jan. 19, 2010

Jan. 19, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > + /* Ctrl+Break processing */ > + if ((e->state & ControlMask) && > + (e->keycode == 0x7F)) > + return VK_CANCEL; It's always a good idea to provide some details. Like: pressing the Pause/Break key alone produces VK_PAUSE vkey, while pressing Ctrl+Pause/Break produces VK_CANCEL under Windows, but not under Wine. Ilya, it's better to use a keysym instead of keycode, and add an explanation in the source as well as in the patch comment. -- Dmitry.

1 0

Ubuntu survey
by sacchi antonio Jan. 18, 2010

Jan. 18, 2010

This is a survey for the apps that users would like to see in upcoming version of Ubuntu: what do you think?? ubuntuforums.org/showthread.php?t=1381221 www.surveymonkey.com/s/GFVQP62 P.S. Please suggest AutoCAD :-D

2 1

Re: [1/2] msi: Support retrieving rows from join tables.
by James Hawkins Jan. 18, 2010

Jan. 18, 2010

On Mon, Jan 18, 2010 at 4:09 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/msi/join.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > Tests please? Thanks, James

1 0

Arwinss
by Aleksey Bragin Jan. 18, 2010

Jan. 18, 2010

Hello, I would like to present my project here too, because I think this information will be interesting for Wine developers. At least, I have not seen anyone gone that far using Wine code. I came up with an idea to create an alternative Win32 subsystem, which would be targeted to NT-alike OSes: Windows NT family and of course ReactOS, based on Wine as much as possible. Detailed presentation with explanations is attached, along with links to some more information. Briefly, what I did: gdi32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. user32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. What about Wineserver, you would ask? SERVER_START_REQ and related macros are rewritten to perform a syscall to win32k.sys (more about win32k.sys below). Server protocol is the same, but of course many requests aren't need. winex11.drv - this is the one if you want X Server to be your interface. This is unchanged Wine source code, again compiled inside a ReactOS source tree into a PE DLL winent.drv - an alternative user/gdi driver, which mostly forwards all calls into a kernel mode graphics engine located in win32k.sys (which is compatible with Windows video drivers, so all acceleration could be used). win32k.sys - kernelmode counterpart of the new Win32 subsystem, contains graphics engine, user server which is based on a small part of platform-independent Wineserver source code adapted to kernelmode, and a simple window manager which calculates visible regions for windows and manages window showing/hiding. All other parts are used from the host OS (be it Windows, or ReactOS). The most funny thing is that this subsystem actually started to work! (I attached a few screenshots in the presentation). There are still some bugs making Arwinss not really usable at the moment, but I'm inviting all developers to participate and help me bring it to a fully usable condition, so that it supports at least all apps which Wine supports plus those which Wine doesn't support due to problems in other parts. The presentation: (links to source code and further information are in the presentation) http://www.reactos.org/media/docs/2010/arwinss.pdf With the best regards, Aleksey Bragin.

1 0

Re: sti: add launch application registry
by Alexandre Julliard Jan. 18, 2010

Jan. 18, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -387,6 +387,7 @@ HKLM,%CurrentVersion%\Controls Folder\PowerCfg,"LastID",,"5" > HKLM,%CurrentVersion%\RunServices,"winemenubuilder",2,"%11%\winemenubuilder.exe -a -r" > HKLM,%CurrentVersion%\Setup,"BootDir",,"%30%" > HKLM,%CurrentVersion%\Setup,"SharedDir",,"%25%" > +HKLM,%CurrentVersion%\StillImage\Registered Applications Unless there's an app that requires the empty key, you should create it as needed from the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

winetestbot changes
by Greg Geldorp Jan. 18, 2010

Jan. 18, 2010

A couple of changes to the test bot: - Maximize number of powered on VMs (Paul Vriens) - Make tag prefix for test.winehq.org submissions configurable (Paul Vriens) - Add support for VMs on multiple hosts, add Windows 95/95B/98/98SE VMs - Make the "File" field on the "Submit job" page accept longer file names - Add feedback page Ge.

1 0

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name (supercedes first patch)
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

Hi Uwe, On 01/17/2010 03:56 PM, Uwe Bonnes wrote: > + if (hFile != INVALID_HANDLE_VALUE) > + { > + CloseHandle( hFile ); > + DeleteFileA("test/"); > + } Indentation is a bit off here (probably because you are mixing tabs and spaces). The rest of your patch also mixes tabs and spaces. This file mostly uses spaces so please do that as well. FWIW, the file that is created doesn't have the slash. -- Cheers, Paul.

1 0