January 2010 - Wine-Devel - list.winehq.org

re:CPP Check Runs Clean but found these Style Issues on Latest Git...
by Dan Kegel Jan. 17, 2010

Jan. 17, 2010

You have some false positives, e.g. dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used That function is indeed used in dlls/gdi32/enhmfdrv/init.c; the struct EMFDRV_Funcs is initialized with it. I guess cppcheck doesn't grok function pointers yet? - Dan

1 0

CPP Check Runs Clean but found these Style Issues on Latest Git...
by chris ahrendt Jan. 17, 2010

Jan. 17, 2010

Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore them from now on. Here they are: File Line Style Problem dlls/dnsapi/ns_name.c 1 The function dns_ns_name_skip' is never used The function dns_ns_name_uncompress' is never used dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used The function EMFDRV_OffsetViewportOrg' is never used The function EMFDRV_OffsetWindowOrg' is never used The function EMFDRV_ScaleViewportExt' is never used The function EMFDRV_ScaleWindowExt' is never used The function EMFDRV_SetMapMode' is never used The function EMFDRV_SetViewportExt' is never used The function EMFDRV_SetViewportOrg' is never used The function EMFDRV_SetWindowExt' is never used The function EMFDRV_SetWindowOrg' is never used The function EMFDRV_SetWorldTransform' is never used dlls/gdi32/mfdrv/dc.c 1 The function MFDRV_AbortPath' is never used The function MFDRV_BeginPath' is never used The function MFDRV_CloseFigure' is never used The function MFDRV_EndPath' is never used The function MFDRV_ExcludeClipRect' is never used The function MFDRV_FillPath' is never used The function MFDRV_FlattenPath' is never used The function MFDRV_IntersectClipRect' is never used The function MFDRV_OffsetClipRgn' is never used The function MFDRV_RestoreDC' is never used The function MFDRV_SaveDC' is never used The function MFDRV_SelectClipPath' is never used The function MFDRV_SetBkMode' is never used The function MFDRV_SetMapperFlags' is never used The function MFDRV_SetPolyFillMode' is never used The function MFDRV_SetRelAbs' is never used The function MFDRV_SetROP2' is never used The function MFDRV_SetStretchBltMode' is never used The function MFDRV_SetTextAlign' is never used The function MFDRV_SetTextCharacterExtra' is never used The function MFDRV_SetTextJustification' is never used The function MFDRV_StrokeAndFillPath' is never used The function MFDRV_StrokePath' is never used The function MFDRV_WidenPath' is never used dlls/rpcrt4/rpc_transport.c 1 The function RpcNetworkIsProtseqValidA' is never used dlls/rpcrt4/rpc_transport.c 700 The scope of the variable b_handle can be reduced dlls/wininet/cookie.c 1 The function IsDomainLegalCookieDomainW' is never used dlls/wininet/cookie.c 225 The scope of the variable len can be reduced dlls/wininet/dialogs.c 132 The scope of the variable q can be reduced dlls/wininet/dialogs.c 181 The scope of the variable u_len can be reduced dlls/wininet/ftp.c 359 The scope of the variable nResCode can be reduced dlls/wininet/ftp.c 1261 The scope of the variable retval can be reduced dlls/wininet/http.c 1 The function IsHostInProxyBypassList' is never used dlls/wininet/http.c 750 The scope of the variable userlen can be reduced dlls/wininet/http.c 751 The scope of the variable passlen can be reduced dlls/wininet/http.c 3355 The scope of the variable lpszCookies can be reduced dlls/wininet/http.c 3365 The scope of the variable cnt can be reduced dlls/wininet/http.c 3868 The scope of the variable headerlen can be reduced dlls/wininet/internet.c 1 The function DllMain' is never used dlls/wininet/internet.c 1464 The scope of the variable lpszNetLoc can be reduced dlls/wininet/internet.c 2712 The scope of the variable len can be reduced dlls/wininet/internet.c 2714 The scope of the variable status can be reduced dlls/wininet/urlcache.c 1 The function CreateUrlCacheContainerA' is never used The function CreateUrlCacheContainerW' is never used The function DeleteUrlCacheContainerA' is never used The function DeleteUrlCacheContainerW' is never used The function FindFirstUrlCacheContainerA' is never used The function FindFirstUrlCacheContainerW' is never used The function FindNextUrlCacheContainerA' is never used The function FindNextUrlCacheContainerW' is never used The function FreeUrlCacheSpaceA' is never used The function FreeUrlCacheSpaceW' is never used The function RegisterUrlCacheNotification' is never used dlls/wininet/urlcache.c 155 struct or union member _URLCACHE_HEADER::dwBlocksInUse' is never used dlls/wininet/urlcache.c 159 struct or union member _URLCACHE_HEADER::dwUnknown4' is never used dlls/wininet/urlcache.c 160 struct or union member _URLCACHE_HEADER::dwUnknown5' is never used dlls/wininet/urlcache.c 161 struct or union member _URLCACHE_HEADER::dwUnknown6' is never used dlls/wininet/urlcache.c 164 struct or union member _URLCACHE_HEADER::Unknown8' is never used dlls/wininet/urlcache.c 673 The scope of the variable error can be reduced dlls/wininet/urlcache.c 2190 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2438 The scope of the variable len can be reduced dlls/wininet/urlcache.c 2731 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2733 The scope of the variable len can be reduced libs/port/spawn.c 39 The scope of the variable wret can be reduced libs/wpp/ppl.yy.c 393 struct or union member yy_trans_info::yy_verify' is never used libs/wpp/ppl.yy.c 394 struct or union member yy_trans_info::yy_nxt' is never used libs/wpp/ppl.yy.c 3942 The scope of the variable new_alloc can be reduced libs/wpp/ppl.yy.c 4152 The scope of the variable new_alloc can be reduced libs/wpp/ppy.tab.c 265 struct or union member YYSTYPE::iptr' is never used libs/wpp/preproc.c 321 The scope of the variable len can be reduced loader/preloader.c 1 The function __bb_init_func' is never used The function __stack_chk_fail_local' is never used The function __stack_chk_fail' is never used The function wld_start' is never used tools/widl/client.c 80 The scope of the variable method_count can be reduced tools/widl/header.c 717 The scope of the variable first_iface can be reduced tools/widl/header.c 803 The scope of the variable first_iface can be reduced tools/widl/parser.tab.c 432 struct or union member YYSTYPE::array_dims' is never used tools/widl/parser.tab.c 439 struct or union member YYSTYPE::func_list' is never used tools/widl/parser.yy.c 388 struct or union member yy_trans_info::yy_verify' is never used tools/widl/parser.yy.c 389 struct or union member yy_trans_info::yy_nxt' is never used tools/widl/proxy.c 591 The scope of the variable first_func can be reduced tools/winebuild/import.c 227 The scope of the variable i can be reduced tools/winebuild/parser.c 913 The scope of the variable i can be reduced tools/winebuild/res32.c 281 The scope of the variable i can be reduced tools/winebuild/res32.c 600 The scope of the variable err can be reduced Chris

2 1

Re: [PATCH] mmdevapi: Add some basic tests for property store
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

On 01/17/2010 02:11 PM, Maarten Lankhorst wrote: > +static void test_propertystore(IPropertyStore *store) > +{ > +} Is that one supposed to be empty ? -- Cheers, Paul.

2 1

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

On 01/17/2010 01:27 PM, Uwe Bonnes wrote: > > CreateFile with an illegal character in the name fail on all systems beside > NT4 and wine when ordered to create the file. No test errors on my mchines > and the winetestbot (Job 319) If creating the file succeeds you should close the handle and delete the file. -- Cheers, Paul.

1 0

Re: sti: add launch application registry
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

On 01/17/2010 10:09 AM, Damjan Jovanovic wrote: > + else > + skip("No StiCreateInstanceW function\n"); Shouldn't that be a win_skip() ? Why don't you do something like: if (!pStiCreateInstanceW) { win_skip("No StiCreateInstanceW function\n"); return; } That way you also get rid of one level of indentation for the big block. -- Cheers, Paul.

1 0

Winetest: What to do if NT4 behaves other then W2k and up
by Uwe Bonnes Jan. 17, 2010

Jan. 17, 2010

Wine Bug 21292 shows a problem with CreateFileA("bla/n", GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL) All winebot systems beside WNT4WSSP6 return ERROR_INVALID_NAME 123L, while wine and NT4 happily open the file. How to proceed? === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === file.c:875: Test failed: CreateFileA failed on nonexist.ent/, hFile 000000B4, err=0, should be 123 === W2KPROSP4 (Windows 2000 Professional SP4) === No test failures found === WXPPROSP3 (XP Professional SP3 (English, IE6)) === No test failures found === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === No test failures found === WVISTAADM (Windows Vista (English, IE7)) === No test failures found === W2K8SE (Server 2008 Standard Edition) === No test failures found -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX (resend) (1/7)
by Alexandre Julliard Jan. 17, 2010

Jan. 17, 2010

Austin English <austinenglish(a)gmail.com> writes: > Subject: [PATCH 1/7] include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX Don't do that. Fix the includes order in the files that fail to compile. -- Alexandre Julliard julliard(a)winehq.org

1 0

Unable to connect to #winehackers
by James Mckenzie Jan. 17, 2010

Jan. 17, 2010

All: I have been trying to connect to #winehackers from my Mac using Conversation. However, this is not working as I am not receiving the welcome screen from irc.freenode.net. Anyone else experiencing this problem and have a workaround. I would really like to get onto winehackers to discuss the patch I've been working on. James McKenzie

3 2

Re: Unable to connect to #winehackers
by James Mckenzie Jan. 17, 2010

Jan. 17, 2010

>Hi James, > >> I have been trying to connect to #winehackers from my Mac using Conversation. However, this is not working as I am not receiving the welcome screen from irc.freenode.net. > >There's possibly some issue with Freenode, as is not uncommon. Have you >tried connecting to any particular Freenode server manually? I seem to >be on "lindbohm.freenode.net", and it's working fine. > Owen: Thank you. However sending /msg nickserv help caused the program to crash. Also when I attempt to connect to winehackers I don't get the chat window. I will ask another MacOSX developer what he is using these days. James McKenzie

3 2

Code review request, fix for PATH setting bug 21322
by Dan Kegel Jan. 16, 2010

Jan. 16, 2010

I was surprised to find that Wine didn't handle system-wide and user-local PATH together properly. The bug and a proposed fix are at http://bugs.winehq.org/show_bug.cgi?id=21322 Could someone review the patch before I risk sending it to wine-patches? I think it's clean, but my luck hasn't been good lately. Thanks, Dan

2 1

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OS X
by Nikolay Sivov Jan. 15, 2010

Jan. 15, 2010

On 1/16/2010 02:12, Austin English wrote: > See bug 21320. > LIST_FOR_EACH_SAFE is inconsistent after your patch. Also I think a shorter variant something like WLIST_... is preferable, but it's a subject of discussion.

2 1

Usage of libxml2 for several modules
by Nikolay Sivov Jan. 15, 2010

Jan. 15, 2010

I'm thinking about implementing xmllite library - its interface is almost the same as xmlTextReader/Writer from libxml2 so it's potentially a thin wrapper, and it's good. The problem is that libxml2 is not reentrant. This isn't a problem for xmllite itself, cause it's not thread safe too, but: we already have a msxml3 module that loads libxml2. If let's say a process with 2 threads use msxml3 for first and xmllite for second then it's not safe anymore, cause both modules use the same libxml2 instance. If I'm right then only solution is to link to libxml2 statically from each module. Is it an acceptable way? P.S. having a separate copy of libxml2 allows to tweak its namespace support (I believe there's some discussions of that problem in bugzilla).

1 0

GSoC D3DX9 work
by Tony Wasserka Jan. 15, 2010

Jan. 15, 2010

Hi everyone, I probably should've written this mail a few months earlier, but I had hoped that I'd get some spare time to work on Wine stuff. But to face reality, I'm having A-levels-like graduation (abitur in Germany) in the comming months. I have to prepare a skilled work until the end of january, put a great bunch of learning for the basic course exams and another one for the abitur exams themselves. The past months weren't any relaxing either. It's not that I was overstrained with school and about to get a burn-out or something, but I just lack the time and/or often motivation to work on the d3dx9 dll. This mail is basically for searching for someone to integrate the texture, mesh and font. The font code may be the easiest to integrate (or at least to understand), the texture stuff is the most profitable (as most games which use d3dx require its texture loading functions) and.. the mesh code is at least useful for the DX SDK samples (although these have yet other problems in Wine ranging from incomplete dx10 support over certain unicode functions to the incompatible msvc++ runtime). I know this may sound like "here, I hacked together some code, now anyone do the dirty work and integrate it, write tests, etc...", but especially concerning the visual tests, I think I'd spend my time better on other stuff than writing visual tests for stuff of which I'm pretty certain about that it works fine (ofc I see a point in tests though, but visual tests are a double-edged sword in that regard). I do have numerous tests for the non-visual part, and some functions don't even need visual tests. Especially the texture code consists basically of a) the file loading routines b) pixel format conversion c) filtering, where a, b and c are needed by only one function and d) functions which call that one function with some fancy magic behing (e.g. compability checks, auto-mipmap generation, combining file loading and conversion, etc). So if the one function (D3DXLoadSurfaceFromMemory) is implemented, things will get a lot easier (it actually is already partially implemented by me). So - if anyone is interested in working with my code (CC'd this to David - maybe you are? If not, never mind), I'd be willing to help that one with understanding the code and to explain what still needs to be done, and how I think things should be done (I still have a meanwhile quite compact list of TODOs). The code can be accessed at http://repo.or.cz/w/wine/d3dx9TW.git (in the "Merge" branch, sorry for ****ing up branching there, was my first public repo) and at http://code.google.com/p/google-summer-of-code-2009-wine/downloads/list (a more compact and organized one). Note that I'm not sure whether the code there is up-to-date, I might still have some patches on my hard disk which improve things. But the code there gives a pretty good insight in what's all this about, in case really anyone steps up I'll provide him with the most up-to-date work of mine. If there's anything anyone might want to ask, just answer this mail or contact me directly on irc at #winehackers, my nick is BigBrain and I'm around quite often. Best regards, Tony Wasserka

1 0

Legal issues with wine development
by Benjamin Zink Jan. 15, 2010

Jan. 15, 2010

Hello, I understand you aren't allowed to look at the source code. The question I have is are you allowed to look at the headers and is an API that's auto generated from the source ok to look at? http://www.cppdoc.com/ has a javadoc style mfc api auto generated from the mfc source. Is this an ok thing to look at? Thank you, Benjamin Zink

3 2

Re: [2/3] user32/tests: Add test for EM_GETIMESTATUS and EM_SETIMESTATUS.
by Paul Vriens Jan. 15, 2010

Jan. 15, 2010

On 01/15/2010 02:22 PM, Kusanagi Kouichi wrote: > Signed-off-by: Kusanagi Kouichi<slash(a)ac.auone-net.jp> > --- > dlls/user32/tests/Makefile.in | 2 +- > dlls/user32/tests/edit.c | 59 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+), 1 deletions(-) > Hi Kusanagi, These tests fail on Vista+ so it seems: https://winetestbot.geldorp.nl/JobDetails.pl?Key=309 -- Cheers, Paul.

1 0

Re: msvcrt/tests: add some demangle tests
by Christian Costa Jan. 15, 2010

Jan. 15, 2010

Maybe you can do it for ?swprintf@@YAHPA_WIPB_WZZ as well... André Hentschel a écrit : > somehow regarding http://source.winehq.org/patches/data/57476 > --- > dlls/msvcrt/tests/cpp.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrt/tests/cpp.c b/dlls/msvcrt/tests/cpp.c > index 106ef73..a75883d 100644 > --- a/dlls/msvcrt/tests/cpp.c > +++ b/dlls/msvcrt/tests/cpp.c > @@ -1034,6 +1034,9 @@ static void test_demangle(void) > /* 113 */ {"?f(a)T@@QAEHQAY1BE(a)BO@$$CBD(a)Z", "public: int __thiscall T::f(char const (* const)[20][30])"}, > /* 114 */ {"??0?$Foo(a)U?$vector_c(a)H$00$01$0?1$0A@$0A@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@@mpl(a)boost@@@@QAE(a)XZ", > "public: __thiscall Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647> >::Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647> >(void)"}, > +/* 115 */ {"?swprintf@@YAHPAGIPBGZZ", "int __cdecl swprintf(unsigned short *,unsigned int,unsigned short const *,...)"}, > +/* 116 */ {"?vswprintf@@YAHPAGIPBGPAD(a)Z", "int __cdecl vswprintf(unsigned short *,unsigned int,unsigned short const *,char *)"}, > +/* 117 */ {"?vswprintf@@YAHPA_WIPB_WPAD(a)Z", "int __cdecl vswprintf(wchar_t *,unsigned int,wchar_t const *,char *)"}, > > }; > int i, num_test = (sizeof(test)/sizeof(test[0])); >

1 0

Re: [2/3] user32/tests: Add test for EM_GETIMESTATUS and EM_SETIMESTATUS.
by Nikolay Sivov Jan. 15, 2010

Jan. 15, 2010

On 1/15/2010 16:22, Kusanagi Kouichi wrote: > + > + imc = ImmGetContext(hwEdit); > + if (!imc) > + { > + trace("ImmGetContext failed.\n"); > + DestroyWindow(hwEdit); > + return; > + } > + > Hi. A minor correction needed here - should be win_skip(), not just trace() with something like "not implemented", not just failed.

1 0

MFC42.dll implementation
by Benjamin Zink Jan. 15, 2010

Jan. 15, 2010

Hello, I was thinking about starting a wine implementation of mfc42.dll and was wondering if anyone had already started or had some tips on where to start. Thank you, Benjamin Zink

2 1

Re: [PATCH 1/4] jscript: Added implementation of Array.reverse
by Jacek Caban Jan. 15, 2010

Jan. 15, 2010

Hi Piotr, On 1/15/10 1:17 AM, Piotr Caban wrote: > --- > dlls/jscript/array.c | 37 +++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 26 ++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+), 2 deletions(-) > > > + if(hres1 == DISP_E_UNKNOWNNAME) + jsdisp_delete_idx(jsthis, l); + else + jsdisp_propput_idx(jsthis, l,&v1, ei, sp); + + if(hres2 == DISP_E_UNKNOWNNAME) + jsdisp_delete_idx(jsthis, k); + else + jsdisp_propput_idx(jsthis, k,&v2, ei, sp); You should check error codes of these calls. Jacek

1 0

Re: kernel32/tests: do not compare handle with zero directly (Smatch)
by Michael Stefaniuc Jan. 14, 2010

Jan. 14, 2010

Andre, this is actually a false positive in the file_handles Smatch script. Or a valid bug requiring an other solution; depending on the point of view. On 01/14/2010 11:09 PM, André Hentschel wrote: > --- > dlls/kernel32/tests/virtual.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c > index 5187a97..2931374 100644 > --- a/dlls/kernel32/tests/virtual.c > +++ b/dlls/kernel32/tests/virtual.c > @@ -583,7 +583,7 @@ static void test_MapViewOfFile(void) > name = "Foo"; file is used as a HFILE before this line and should be checked against INVALID_HANDLE_VALUE and not NULL. > file = CreateFileMapping( INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, 4096, name ); file is now a normal HANDLE and should be checked against NULL. > } > - ok( file != 0, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); This is ok. > + ok( !!file, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); The real fix is either for me to mark it as a false positives. Or to make file a HFILE and use an other HANDLE variable for the mmap. > SetLastError(0xdeadbeef); > mapping = OpenFileMapping( FILE_MAP_READ, FALSE, name ); bye michael

1 0

Re: ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime
by Alexandre Julliard Jan. 14, 2010

Jan. 14, 2010

Erich Hoover <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > Description: > The attached patch implements ExSystemTimeToLocalTime and > ExLocalTimeToSystemTime (Bug #19395), which are necessary to allow the > Sentinel Protection service to load (the Sentinel Protection service > is required by the full version of ZEMAX). Without the patch the > service will crash every time Wine loads, slowing down the launching > of all applications. > Changelog: > ntoskrnl: Implement ExSystemTimeToLocalTime and ExLocalTimeToSystemTime. You most likely want to use RtlSystemTimeToLocalTime etc. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] Implement OleCreatePropertyFrame (try 2)
by Geoffrey Hausheer Jan. 14, 2010

Jan. 14, 2010

On Wed, Jan 13, 2010 at 10:38 PM, Piotr Caban wrote: > Hi, > > There're still some things that needs to be changed. Thank you for the continued feedback. > > In pixels_to_dialog_units: > + *basex = ((float)size.cx/26+1)/2; > > + *x_pixels = MulDiv(*x_pixels, 4, *basex); > I proposed doing the computations on floats so the dialog size is more > accurate. If it was working for you correctly than it's probably better > to keep it the way I proposed. The cast in the patch you've sent doesn't > change anything. > If there are reasons to make the computations on integers it's better to > use GdiGetCharDimensions function. My understanding is that your method is to get the average font width. I have no idea if that is similar to how MapDialogRect works, so I have no idea if it more correct or not. So I haven't any idea if the accuracy of using float is really more accurate with respect to Windows or not. Looking through the dialog code in user32, GetDialogBaseUnits just returns the value of GdiGetCharDimensions (which isn't right here), so I don't see a better way than to use a heuristic. > > I think that pixels_to_dialog_units function should be deleted and it's > code move to OleCreatePropertyFrameIndirect. It was originally meant to implement the inverse of MapDialogRect. Now that it is precomputing the base units, it probably doesn't make sense in its current form. > > + /* This was expected to work but didn't: > + * LONG baseunits = GetDialogBaseUnits(); > + * basex = LOWORD(baseunits); > + * basey = HIWORD(baseunits); > + */ > This comment is not correct. GetDialogBaseUnits is somehow strange and > should be avoided. The comment is correct in that it is how MSDN says it should work, but it obviously doesn't. I think it is valuable to make it clear that there is a reason for the heuristic. > > About PropertyPageSite interface: > You have implemented AddRef and Release functions but you don't really > care about reference counter. The object should be freed when the > counter reaches 0. Well, I didn't implement proper COM objects because I didn't see the need. Memory is allocated and freed in OlePropertyFrameIndirect. But COM objects must present AddRef/Release functions, so I have them. Is the preference here to build the proper COM object and allocate/free individually, or can I implement the AddRef/Release functions as stubs (which is basically what they are now) > > +typedef struct { > + struct { > + DLGTEMPLATE dlg; > + WORD menu; > + WORD class; > + WORD caption; > + WORD font; > + } dialog; > + OLEPropertyPageSite pps; > + IPropertyPage *propPage; > +} OLEPropertyFrame; > You don't need font field. But I do need the WORD to be present, as MSDN clearly states that you must reserve 4 WORDS after the DLGTEMPLATE. Since its general use is for 'font' I figured I'd name it properly. If it is really bothersome, I could call it 'reserved' or something equivalent. I probably won't get to this for several days. My development computer will be out of commission for a while. Thanks again, .Geoff

1 0

Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"
by Vincent Cadet Jan. 14, 2010

Jan. 14, 2010

Hi peoople. A couple of months ago, I submitted a patch I wrote to add a backlink to the previous version in WineHQ announcement page. As it has still no been applied I am sending it again here. It actually adds a few (6) lines of PHP code to the web site's template, include/plugins/announce.php . I ahve also submitted this patch into WineHQ bugzilla ( http://bugs.winehq.org/show_bug.cgi?id=19355 ). May I ask for comments about this patch? Thanks a lot in advance, Vince C.

3 4

Re: Wine AppDB xmlexport script
by Austin English Jan. 14, 2010

Jan. 14, 2010

On Tue, Jan 12, 2010 at 8:17 AM, John Brezerk <brezerk(a)gmail.com> wrote: > Hi to All. > > I'd like to present php scripts ( attached xmlexport.tar.gz ) which make > possible for third party applications to query appdb database. > After processing user requests, script generates xml view. > Originally this script was created for q4wine ( > http://q4wine.brezblock.org.ua/ ) project. Neat! There's been talk about doing something like this for a while, but no one's taken the initiative to do it. However, I don't think you'll have much luck getting it in the AppDB's source repository, without having a discussion on wine-devel about it first. > It's licese is GPL v3. Is there any chance of a different license? Wine is currently LGPL 2.1, it'd be nice to have the same license, if possible... -- -Austin

5 4

Re: [PATCH] Implement OleCreatePropertyFrame (try 2)
by Piotr Caban Jan. 14, 2010

Jan. 14, 2010

Hi, There're still some things that needs to be changed. In prop_sheet_proc: + case WM_DESTROY: + { + OLEPropertyFrame *opf = (OLEPropertyFrame *)GetWindowLongPtrW(hwnd, DWLP_USER); + if(opf) { + IPropertyPage_Show(opf->propPage, SW_HIDE); + IPropertyPage_Deactivate(opf->propPage); + SetWindowLongPtrW(hwnd, DWLP_USER, (LONG)NULL); + } + } there's no break/return In pixels_to_dialog_units: + *basex = ((float)size.cx/26+1)/2; + *x_pixels = MulDiv(*x_pixels, 4, *basex); I proposed doing the computations on floats so the dialog size is more accurate. If it was working for you correctly than it's probably better to keep it the way I proposed. The cast in the patch you've sent doesn't change anything. If there are reasons to make the computations on integers it's better to use GdiGetCharDimensions function. I think that pixels_to_dialog_units function should be deleted and it's code move to OleCreatePropertyFrameIndirect. + /* This was expected to work but didn't: + * LONG baseunits = GetDialogBaseUnits(); + * basex = LOWORD(baseunits); + * basey = HIWORD(baseunits); + */ This comment is not correct. GetDialogBaseUnits is somehow strange and should be avoided. About PropertyPageSite interface: You have implemented AddRef and Release functions but you don't really care about reference counter. The object should be freed when the counter reaches 0. +typedef struct { + struct { + DLGTEMPLATE dlg; + WORD menu; + WORD class; + WORD caption; + WORD font; + } dialog; + OLEPropertyPageSite pps; + IPropertyPage *propPage; +} OLEPropertyFrame; You don't need font field. Cheers, Piotr

1 0