January 2010 - Wine-Devel - list.winehq.org

Re: gdi32: Use the LOGFONT charset field on OEM font creation
by Dmitry Timoshkov Jan. 6, 2010

Jan. 6, 2010

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > Some explanation for this patch: > > The fsCsb is bitfield that is used as boolean value. If this is false the > DEFAULT_CHARSET is using and the real charset is choosen through the current > ANSI codepage. But this is mistake in case of the OEM charset. A real fix would be to add "Terminal" font to Wine. -- Dmitry.

2 2

Re: ole32/tests: remove a test, as it fails or hangs on Vista+
by Paul Vriens Jan. 6, 2010

Jan. 6, 2010

On 01/05/2010 08:05 PM, André Hentschel wrote: > vista and 2k8: fails > w7: timeout > --- > dlls/ole32/tests/clipboard.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c > index 626d244..4a9e234 100644 > --- a/dlls/ole32/tests/clipboard.c > +++ b/dlls/ole32/tests/clipboard.c > @@ -1186,6 +1186,7 @@ static void test_flushed_getdata(void) > "got %08x\n", hr); > if(SUCCEEDED(hr)) ReleaseStgMedium(&med); > > +#if 0 /* broken on Vista+ */ > InitFormatEtc(fmt, cf_another, 0xffff); > memset(&dm, 0, sizeof(dm)); > dm.dmSize = sizeof(dm); > @@ -1204,6 +1205,7 @@ static void test_flushed_getdata(void) > ok(hr == S_OK, "got %08x\n", hr); > ok(med.tymed == TYMED_ISTORAGE, "got %x\n", med.tymed); > if(SUCCEEDED(hr)) ReleaseStgMedium(&med); > +#endif > > HeapFree(GetProcessHeap(), 0, fmt.ptd); > The test doesn't fail or hang on all Vista+ boxes though. There have been several attempts to fix these failures but I'm not sure just removing them is the best option. Apart from that I think "if (0)" is preferred over "#if 0". -- Cheers, Paul.

1 0

The (Casual) Game Support Report in Wine (Jan 2009)
by Reece Dunn Jan. 6, 2010

Jan. 6, 2010

Hi, With Dan reporting on the success of Visual C++ 2005, I thought I would post my findings of various casual (and other) games. In general, my observations are that: 1/ the games themselves tend to work very well (and have done for a long while now thanks to the great work CodeWeavers did in getting DirectDraw and Direct3D working); 2/ the major issues appear to be in the application launchers used by different game providers (most of which are in the current wine implementation of the IE browser ActiveX control); 3/ the success varies from provider to provider, but the same tricks usually work for a given provider; 4/ a game is usually distributed by more than one provider, so you should be able to find a provider that works with wine that distributes the game; 5/ the recent Xrender support has provided major improvements to games (to the point where Azgard Defense is actually playable :D). Oberon Media Oberon Media have two versions of their game launcher. The older one renders with the buttons drawn, but the text and links are not functional; installing IE6 causes the text to render and the links to work, but when registering the games, you cannot enter any text in the text fields and there is no visible cursor. The newer launcher (which has a different UI) causes an SEH exception; I suspect that this is due to tightened DRM in the launcher. In addition to this, entering the details directly into the registry doesn't appear to work any more (and in the newer versions of the launcher, a different mechanism is used). Verdict: Rubbish! PopCap Games The PopCap games launcher works without problems out of the box. I haven't tried registering/buying a game through their launcher interface, though. Verdict: Flawless Blizzard Entertainment I have successfully installed and registered Warcraft III (and the expansion), StarCraft and Diablo II using the installer/launcher from the download version. StarCraft and Diablo II work flawlessly; WarCraft III crashes at random points (usually when transitioning between parts of a scenario). Verdict: Almost-but-not-quite Flawless Big Fish Games These use a special downloader client that makes extensive use of IE to provide its functionality. Although this does not currently work with wine out of the box, it works flawlessly in IE6 (using winetricks to install) -- the games download (although the download animation button background does blink), launch and you can successfully register/purchase them from the Big Fish Games UI. NOTE: Using IE7 results in a crash when starting the Big Fish Games launcher, and I have not yet been able to get IE8 installing/working properly from winetricks (using the IE7 recipe). Verdict: Excellent Awem Studios The Awem Studios game launcher works flawlessly in a clean wine prefix (only gecko is needed). The games launch and you can even register/purchase the games from within the Awem game launcher. Verdict: Flawless YoudaGames The launcher used by YoudaGames does not work in wine out of the box, but requires IE6. I haven't tried registering/purchasing any of their games yet, so I don't know how well this works. Verdict: Excellent - Reece

2 3

visual c++ 2005 success
by Dan Kegel Jan. 5, 2010

Jan. 5, 2010

Well, golly. Now that Rob has fixed the /Zi bug, Visual C++ 2005 seems to be building small apps pretty well. There are three or so gotchas to be aware of: 1) apps like gyp's unit test won't be able to build until you've run the IDE once so it can register itself 2) you have to install winbind or /Zi will still be broken 3) the first run of a devenv /Zi build will hang after starting the pdb service; you have to kill it to recovert. Further runs (until reboot) will work fine. See http://bugs.winehq.org/show_bug.cgi?id=21259 for a nice script to demonstrate the latter problem. Oh, and you can't create projects; our ie implementation isn't good enough to run the wizard yet. But you can use projects that were created earlier.

1 0

valgrind progress: only 426 errors left?!
by Dan Kegel Jan. 5, 2010

Jan. 5, 2010

Rob Shearman's commit, http://source.winehq.org/git/wine.git/?a=commit;h=9dc584d0a2cae7cfb4816fe98… seems to have caused a spectacular improvement in jscript/tests/run.c's leakage: LEAK SUMMARY: - definitely lost: NNN bytes in 19,001 blocks + definitely lost: NNN bytes in 4 blocks woot! The stats are now 1 Invalid free/ delete / delete[] 1 Use of uninitialised value of size 4 2 Source and destination overlap in memcpy 3 Syscall param writev 6 Invalid write of size 4 7 Invalid read of size 2 8 Invalid write of size 1 22 Invalid read of size 4 41 Conditional jump or move depends on uninitialised value 335 XXX bytes in XXX blocks are definitely lost total: 426 Amazing progress for December. I'll be happy if in January we cut the error count by 10% down to 380... There were two runs today; http://kegel.com/wine/valgrind/logs/2010-01-04-06.56 covered last Thursday's git, http://kegel.com/wine/valgrind/logs/2010-01-04-10.14 was fresh. Also: I'm deleting really old valgrind logs to avoid going over quota.

1 1

Re: [PATCH 1/2] msi: queue dynamically allocated strings in cond.y
by James Hawkins Jan. 5, 2010

Jan. 5, 2010

On Sat, Jan 2, 2010 at 10:36 AM, Nathan Gallaher <ngallaher(a)deepthought.org> wrote: > > +struct cond_mem { + struct list entry; + void *ptr; +}; + +static void cond_free( void *info, void *ptr ) +{ + COND_input *cond = (COND_input*) info; + struct cond_mem *mem, *safety; + + LIST_FOR_EACH_ENTRY_SAFE( mem, safety, &cond->mem, struct cond_mem, entry ) + { + if( mem->ptr == ptr ) + { + msi_free( mem->ptr ); + list_remove( &(mem->entry) ); + msi_free( mem ); + return; + } + } + ERR("Error freeing %p\n", ptr); +} This won't fly. cond_free needs to be an O(1) operation, like your original patch. -- James Hawkins

2 4

Re: [tools]winetest: fix child-result coloring and counting
by Paul Vriens Jan. 5, 2010

Jan. 5, 2010

On 01/04/2010 08:50 PM, André Hentschel wrote: > You can see wrong coloring e.g. here http://test.winehq.org/data/f74e312bf81032c46bd2ce080a5f6a33c7ac3ee3/wine_a… > Also the counting is wrong, that unit test is shown in the summary with 2 errors, but only has 1 > This patch fixes the issue. The totalize of those variables is already made in the "offline" software > --- > winetest/dissect | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/winetest/dissect b/winetest/dissect > index 16cc118..ce90bda 100755 > --- a/winetest/dissect > +++ b/winetest/dissect > @@ -252,9 +252,9 @@ while (<IN>) { > } elsif (/^(.*$unit.*: (\d+) tests executed $(\d+) marked as todo, (\d+) failures?$, (\d+) skipped\.)\r?$/) { > $lines++; > $total += $2; > - $todo += $3; > - $failed += $4; > - $skipped += $5; > + $todo = $3; > + $failed = $4; > + $skipped = $5; > chomp; > s/\r+$//; > my $class = "test result"; Hi André, That log also shows "server: 1 failures in child process". I'm not a 100% sure but from the looks of it this is that one/1 failure mentioned in that last line: server: 120 tests executed (1 marked as todo, 1 failure), 0 skipped. If I'm correct it does mean that we have 2 failures and 1 todo. (cc-ing AJ as he wrote that winetest_wait_child_process() thingy). -- Cheers, Paul.

3 6

Re: dmloader: Fix a possible null dereference
by Paul Vriens Jan. 5, 2010

Jan. 5, 2010

On 01/05/2010 02:18 PM, David Adam wrote: > Hello > > This patch fixes the bug 13986 > > A+ > > David > Searc > Hi David, + hr = CoInitialize(NULL); + if ( FAILED(hr) ) + { + skip("CoInitializeEx failed.\n"); + return; + } The skip() message doesn't match the actual function called. + hr = CoCreateInstance(&CLSID_DirectMusicLoader, NULL, CLSCTX_INPROC, &IID_IDirectMusicLoader8, (void**)&loader); + if (FAILED(hr)) + { + skip("CoCreateInstance failed.\n"); + return; + } Your mixing tabs and spaces here. Shouldn't 'loader' be released on return? -- Cheers, Paul.

1 0

Re: Revert "dsound: Remove refcounting in classfactory."
by Alexandre Julliard Jan. 5, 2010

Jan. 5, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > This reverts commit 1b94450f789791908a370f16e125087b84f35bcb. > > See bug 21196 Again, when sending a revert you need to include a justification for why it must be reverted. Referencing a bug is not good enough, the git log must be understandable on its own. Also I don't see anything in that bug related to ref counting. -- Alexandre Julliard julliard(a)winehq.org

2 1

Version test crashing
by Stefan Dösinger Jan. 5, 2010

Jan. 5, 2010

Hi, Since a few days my nightly cxtest runs show crashes in the version:info test: http://test.winehq.org/data/f74e312bf81032c46bd2ce080a5f6a33c7ac3ee3/wine_s… (Ubuntu 8.10, 64 bit build) Test.winehq.org has more results, for this wine build I am seeing 3 more timeouts(most likely because the crash error message wasn't ack'ed, so the process didn't exit). I don't know when this started, but I think it was somewhen mid-december. If needed I can run a regression test. The test runs in a clean wine prefix - my modified cxtest script cleans everything up, runs winetest, cleans up again, then runs a bunch of games and writes down the performance. Cheers, Stefan

2 2

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.
by Alexandre Julliard Jan. 5, 2010

Jan. 5, 2010

Rico Schüller <kgbricola(a)web.de> writes: > +static void d3d10_null_effect_variable_init(struct d3d10_effect_variable *v, struct ID3D10EffectVariableVtbl *vtbl) > +{ > + v->vtbl = vtbl; > + v->buffer = &null_local_buffer; > + v->type = &null_type; > +} > + > +void d3d10_null_effect_variable_init_all() > +{ > + d3d10_null_effect_variable_init(&null_local_buffer, (ID3D10EffectVariableVtbl *)&d3d10_effect_constant_buffer_vtbl); > + d3d10_null_effect_variable_init(&null_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_variable_vtbl); > + d3d10_null_effect_variable_init(&null_scalar_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_scalar_variable_vtbl); > + d3d10_null_effect_variable_init(&null_vector_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_vector_variable_vtbl); > + d3d10_null_effect_variable_init(&null_matrix_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_matrix_variable_vtbl); > + d3d10_null_effect_variable_init(&null_string_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_string_variable_vtbl); > + d3d10_null_effect_variable_init(&null_shader_resource_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_shader_resource_variable_vtbl); > + d3d10_null_effect_variable_init(&null_render_target_view_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_render_target_view_variable_vtbl); > + d3d10_null_effect_variable_init(&null_depth_stencil_view_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_depth_stencil_view_variable_vtbl); > + d3d10_null_effect_variable_init(&null_shader_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_shader_variable_vtbl); > + d3d10_null_effect_variable_init(&null_blend_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_blend_variable_vtbl); > + d3d10_null_effect_variable_init(&null_depth_stencil_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_depth_stencil_variable_vtbl); > + d3d10_null_effect_variable_init(&null_rasterizer_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_rasterizer_variable_vtbl); > + d3d10_null_effect_variable_init(&null_sampler_variable, (ID3D10EffectVariableVtbl *)&d3d10_effect_sampler_variable_vtbl); > +} > + That's not much of an improvement, static initialization is nicer. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/5] WineD3D: Call the non-wrapped GLfinish in the PBO test
by Henri Verbeet Jan. 5, 2010

Jan. 5, 2010

2010/1/4 Stefan Dösinger <stefan(a)codeweavers.com>: > In this case you can just release the GL lock, although the call is just an OS X hack in the first place.

1 0

Re: shell32: Initialize the APPBARDATA struct to avoid use of uninitialized memory in SHAppBarMessage.
by Paul Vriens Jan. 5, 2010

Jan. 5, 2010

On 01/05/2010 02:47 AM, James Hawkins wrote: > --- > dlls/shell32/tests/appbar.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Hi James, Both Vincent and I tried something along those lines but AJ's response was: "That's just hiding the problem, an app can pass the same structure." and "We need to define a platform-independent struct for marshalling that data across processes anyway, we can't blindly send the structure." Vincent also mentioned http://bugs.winehq.org/show_bug.cgi?id=20982 -- Cheers, Paul.

1 0

Tango Icon Questions
by Joel Holdsworth Jan. 4, 2010

Jan. 4, 2010

Ok, We seem to have two questions that need to be resolved before the tango icons can be merged. First: The SVGs. A little background on how I make the icon set: The icon set has been assembled from different sources of artwork. Some my own, some from other people, so there's a certain amount of variation in the formats that I've received. In every case, I have had to do a certain amount of work to produce the 9 or 10 sub-images of an ico. Rather like fonts, in icon art, the size of a pixel is significant relative to the size of graphical elements. This effect is particularly pronounced at the smaller sizes: 16x16 and 22x22. At smaller sizes, manual intervention in the vector artwork becomes increasingly necessary. Graphical elements have to be tweaked to align to pixel boundaries or resized, rearranged, or removed altogether. Low colour depths pose further problems. In 8-bit icons we only have 1-bit transparency. Drop shadows must be removed, and the icon must be adjusted in a raster editor to remove jagginess in the boundaries. These are exported as PNGs, and in some cases I kept the GIMP xcf.bz2s. 4-bit icons are still harder. Here the icon has to be so radically adjusted, that the original SVG really only forms a template for a piece of pixel art. I tend to do this work with the wine glass hidden in the SVG rendering, and then overlay a pre-rendered wine glass. Again, these are expored as PNGs, and in most cases I kept the GIMP xcf.bz2s. In an ideal world, we would have one SVG source file, which would be versioned in Git, which we would render to different sizes and depths as part of the build process. I hope you can see how this would be impractical because of the amount of manual raster work that has been needed. The only build scripts that I have are scripts that automatically compile my PNGs into ICOs, but this step wouldn't really help the project much, because the PNG is no less a binary blob than the ICO. To further compound the issue, I've found 2 bugs in icotool that cause it to create ICOs that are formatted incorrectly, and cause Wine to misbehave. For my ICO scripts I wrote a simple tool called "fix-icon" which tweaks the files, to correct the 2 types of problem. I've tried to contact the author of icotool about this, but as yet haven't got a response. So in conclusion, I think the best thing would be for me to tidy my icons project folder, and submit that to git or wine-pub-ftp. I think we need to accept that some images are PNG, some SVG and some XCF.BZ2, depending on the original source, and I don't think we can do automated render steps as part of the build. The other question is about attribution. By now, ALL the icons have had some input from me in one way or another; they're all a derivative work. I'm planning to just submit the icons in the current round, as shown on the website: http://www.airwebreathe.org.uk/wine-icon/ - no bitmaps this round, just shell32.dll, user32.dll, and Programs icons. The sources of these are: * Tango Base - Public Domain * Scott Ritchie - oic_winlogo.ico - the Wine Glass * Jakub Steiner - oic_bang.ico - GPLd, but I have an e-mail of him agreeing to relicense * Ulisse Perusin - winemine - GPLd, but have e-mail agreeing a relicense. * Joel Holdsworth - my original work - LGPLd. What would be the best way for us to attribute these? I guess we need to do things properly with regard to licensing, but I think the authors are all quite easy-going. Any thoughts Thanks Joel

1 0

Re: Patch feedback requested for OleCreatePropertyFrame()
by Geoffrey Hausheer Jan. 4, 2010

Jan. 4, 2010

On Mon, Jan 4, 2010 at 9:06 AM, Wolfram Sang wrote: >> task. There doesn't appear to be anything in this code that would be >> patent encumbered, but the code itself certainly falls under >> Hidenori's copyright which he has effectively revoked permission to >> use. > > Strictly speaking, this is not possible. Although IANAL, this code is LGPL, > so he can't revoke permission for this version of the code. He can ask to > not use it, and this wish can be granted. You still should be allowed to > pick it up. Next question is then, if a modified version will be picked up > (still respecting the author's wish)? Or how much modifications are needed? > Geez, such things are never trivial :( > Well, I put the LGPL header on the code. I thought I had that right since the code was posted to wine-patches Anyhow, the legal side isn't really relevant. The question is what Alexandre will accept as far as it goes. The current code is certainly copyright by Hienori, and since I couldn't contact him, I must assume he doesn't want any of it in Wine. Thus my assumption is that I need to rewrite the entire thing, if we want to obey his wishes (which I do). However, my hope was that I could use the knowledge I gained from his implementation to do it myself. As I'm already biased by that knowledge, if that won't be allowed, then I can't do the work at all.

2 1

Re: Patch feedback requested for OleCreatePropertyFrame()
by Geoffrey Hausheer Jan. 4, 2010

Jan. 4, 2010

On Mon, Jan 4, 2010 at 4:39 AM, John Klehm wrote: > On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies <huw(a)codeweavers.com> wrote: >> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote: >>> I found a patch from 2001 written by TAKESHIMA Hidenori that >>> was posted to wine-patches >>> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html) >>> but never committed. >> >> Actually it was commited (2843934af5515c7f2b8370324aa98d3964a40324) >> but was then removed (140e7222e0d7ce76068cddc64c68105c2e569257) at >> his request. >> > > In case anyone was just slightly less curious than me about it: > http://www.winehq.org/wwn/122#Quartz.dll%20Removal > Thanks for turning that up. I did look through the archives to see what hapened, but aparently not hard enough. So now the only solution appears to be to rewrite the code from scratch. The question is, can I do that now that I've looked over his code? It does turn this from a simple fix to a much more daunting task. There doesn't appear to be anything in this code that would be patent encumbered, but the code itself certainly falls under Hidenori's copyright which he has effectively revoked permission to use. .Geoff

2 1

Re: [PATCH] Revert "dsound: Only initialize one guid for capture and renderer."
by Alexandre Julliard Jan. 4, 2010

Jan. 4, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > This reverts commit b474649e0e9491f938f1daec74cdca01343dd97e. Please explain why. -- Alexandre Julliard julliard(a)winehq.org

2 1

Patch feedback requested for OleCreatePropertyFrame()
by Geoffrey Hausheer Jan. 4, 2010

Jan. 4, 2010

Some software I'm using is configured via an OleCreatePropertyFrame call which isn't implemented in Wine (ticket #16564). I can use winetricks + dcom98 to get it working, but would prefer not to need that. I found a patch from 2001 written by TAKESHIMA Hidenori that was posted to wine-patches (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html) but never committed. I cleaned up the patch to compile against current Git and am including it here for inspection. I can't find any documentation on why it wasn't included at that time, and haven't done any Wine development for a long time, so I'm not sure what it will take to get it included. I have tested it, and it works pretty much fine for me (not quite as pretty as the dcom menu, but it is functional). I'd be happy to write a test for it if I had any idea how to do that, but I'm not sure where to begin for a function like this. Anyhow, I'm open to feedback on what should be done before I submit the patch for inclusion FYI: I was unable to find a currently valid email address for Takeshima .Geoff

4 3

RE: WineTestBot changes
by Greg Geldorp Jan. 4, 2010

Jan. 4, 2010

> > I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows > > executables you can now also submit patch files to the bot. The bot will > > apply the patch files to a clean git tree, cross-compile the test and run the > > test on Windows VMs. You'll also be able to download the cross-compiled test > > executable to test it on different Windows machines. > > I've had to reverse this change for now as it causes major problems. Fixed the problem (race condition which didn't show up on my uniprocessor test system but became very visible on the multiprocessor production system) and reinstated the change. You can submit patches to the bot again. Ge.

1 0

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends
by Paul Vriens Jan. 3, 2010

Jan. 3, 2010

On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote: > This patch depends on Detlef Riekenberg's patch from June 2008 and > expects it to have been applied: > http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html > > It was not committed due to bug 14085: > http://bugs.winehq.org/show_bug.cgi?id=14085 Can't you just submit that initial test framework with the 3 imports (if all 3 are indeed needed)? The bug will of course not be closed but at least some of your work could be committed. -- Cheers, Paul.

4 3

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > + dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; > What does this '2' mean?

2 4

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. A test required for this - let's say check that an ownerdata listview send LVN_GETDISPINFO before text update and the same thing for callback text (don't remember now maybe similar tests are already in).

3 3

Re: comctl32: Get the test in the correct format
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:47, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) You don't need this. Conversion is done next lines if needed: --- if (isW) bSame = (lstrcmpW(dispInfo.item.pszText, pszText) == 0); else { LPWSTR tmp = textdupTtoW(pszText, FALSE); bSame = (lstrcmpW(dispInfo.item.pszText, tmp) == 0); textfreeT(tmp, FALSE); } ---

2 1

[rfc] initial conformance test for programs/cmd
by Dan Kegel Jan. 2, 2010

Jan. 2, 2010

How's this look? I've only tested it lightly, but it should be pretty close; with this, "make test" ought to recurse down into programs/cmd/tests and run the cmd tests, too. Shortcomings: - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround - I think I can turn on echo again in tests/*.cmd, that was another workaround - I have yet to add a way to specify that a test is todo_wine Feedback welcome. I'll try to submit something tomorrow that takes care of the above known issues and any issues anyone else points out. (I'm actually kind of amazed the build machinery changes work, I didn't really take the time to understand all of the gears and pulleys.)

3 3

merge wine-website's Todo
by Thomas Heckel Jan. 2, 2010

Jan. 2, 2010

Hi, the last days I had some free time and tried to make some cleanups to the wiki. I mainly worked on the pages related to quality assurance because my little contributions was to Austin's AppInstall which is on this topic. I hope this way I can contribute to the project. At the moment I stumbled over this old page at the website: http://www.winehq.org/status/todo It seems to me this would be a good candidate to be merged into wiki too. What do you think? Bye -- Thomas Heckel

2 1