January 2010 - Wine-Devel - list.winehq.org

Re: ukrainian-credui
by Paul Vriens Jan. 25, 2010

Jan. 25, 2010

On 01/24/2010 09:23 PM, гор Хакер wrote: > ukrainian-credui > Hi, If you send a second (or higher) revision of a patch please mark it as such. For example "(Try x)" at the end. This makes it easier to discard older ones. This one supersedes the one that didn't have the pragma for example. A nicer subject would be appreciated as well. "ukrainian-credui" suggests it's a translation but why not say something like "Adding Ukrainian translations to credui" or "Fixed ...". I'm not sure if our automated patch watcher (http://source.winehq.org/patches/) can cope with non-ascii characters in the "From:" field but your patches don't show up over there. Have a look at http://wiki.winehq.org/SubmittingPatches. Your email address for this mail is different from the generated one in the patch attached to that email and the names are again different from the copyright name in the file itself. -- Cheers, Paul.

4 4

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection
by Dmitry Timoshkov Jan. 25, 2010

Jan. 25, 2010

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > The current code misdetects both Windows XP and Wine as Win9x and skips > some tests due to this. The SetParent tests were not passing on XP, so > this patch also removes the tests that fail on XP SP3. These should be 2 separate patches. And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_… SetParent tests pass under XP just fine. -- Dmitry.

3 6

Re: [PATCH 1/4] [Include]: push/pop pack fixes on 64 bit platforms
by Alexandre Julliard Jan. 25, 2010

Jan. 25, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > diff --git a/include/commctrl.h b/include/commctrl.h > index 27bd745..c841d51 100644 > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -2245,7 +2245,9 @@ static const WCHAR WC_PAGESCROLLERW[] = { 'S','y','s','P','a','g','e','r',0 }; > #define PGN_SCROLL (PGN_FIRST-1) > #define PGN_CALCSIZE (PGN_FIRST-2) > > +#ifdef _WIN32 > #include <pshpack1.h> > +#endif That's broken, testing _WIN32 is not useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Add support for EXT_gpu_shader4 provided sampling functions with explicit derivatives.
by Stefan Dösinger Jan. 25, 2010

Jan. 25, 2010

Am 24.01.2010 um 21:16 schrieb Henri Verbeet: > if(texrect) { > if(lod) { > sample_function->name = projected ? "texture2DRectProjLod" : "texture2DRectLod"; > - } else if(grad) { > - sample_function->name = projected ? "texture2DRectProjGradARB" : "texture2DRectGradARB"; > - } else { > + } > + else if (grad) > + { > + if (gl_info->supported[EXT_GPU_SHADER4]) > + sample_function->name = projected ? "texture2DRectProjGrad" : "texture2DRectGrad"; > + else if (gl_info->supported[ARB_SHADER_TEXTURE_LOD]) > + sample_function->name = projected ? "texture2DRectProjGradARB" : "texture2DRectGradARB"; > + else > + { > + FIXME("Unsupported RECT grad function.\n"); > + sample_function->name = "unsupported2DRectGrad"; > + } > + } > + else > + { > sample_function->name = projected ? "texture2DRectProj" : "texture2DRect"; > } > } else { I think these if constructs in shader_glsl_get_sample_function are becoming ugly with more and more possibilities added. Isn't there a nicer way, like a table that is either searched, or a multi-dimensional array to look up the end result?

2 1

Re: Fix use of uninitialized variable in dlls/advapi32/tests/eventlog.c
by Paul Vriens Jan. 25, 2010

Jan. 25, 2010

On 01/25/2010 12:21 PM, Vladimir Pankratov wrote: > Hello all. > > Fix use of uninitialized variable in dlls/advapi32/tests/eventlog.c > > changed files: > dlls/advapi32/tests/eventlog.c > > Thanks. > This is the same patch as you've sent a month ago. This doesn't happen on a clean .wine as there we would never reach this test. The fix should be in the implementation, as initializing 'needed' would only hide the problem. What I'm saying is that an app doesn't need to initialize 'needed' before calling ReadEventLogA. -- Cheers, Paul.

1 0

shell32: SHELL_execute() tries to extract program name and arguments from SHELLEXECUTEINFOW.lpFile
by Илья Басин Jan. 25, 2010

Jan. 25, 2010

At first sight there's a strange behavior in SHELL_execute() (read ShellExecuteEx() ): at tries to extract program path and arguments from SHELLEXECUTEINFOW.lpFile, if it's unquoted. http://source.winehq.org/source/dlls/shell32/shlexec.c?v=wine-1.1.37#L1709 On WinXP at least ShellExecuteExA() doesn't do it/ haven't yet tested with ShellExecuteExW(). This is harmful when you have 2 documents like "C:\aaa.txt" and "C:\aaa.txt bbb.txt" Found an old thread about this, but it seems abandoned. http://www.mail-archive.com/wine-devel(a)winehq.org/msg57246.html

1 0

strsafe.h?
by Dan Kegel Jan. 25, 2010

Jan. 25, 2010

http://msdn.microsoft.com/en-us/library/bb288454.aspx encourages people to use the functions in strsafe.h. (They're inline by default, and optionally available as a static library.) Neither Wine nor mingw currently ship this header. There are a few copies floating around, though: http://baseutils.googlecode.com/svn/trunk/str_strsafe.h http://github.com/janneke/gub/blob/76e5823756ea1eda37542808a82d784df4a20ee2… And then there's the massively more complete one from the mingw-w64 project: http://mingw-w64.svn.sourceforge.net/viewvc/mingw-w64/trunk/mingw-w64-heade… Can we just use that one directly? - Dan

1 0

Re: [PATCH 1/2] ws2_32: use ntstatus in overlapped functions (try 3)
by Mike Kaplinskiy Jan. 24, 2010

Jan. 24, 2010

On Fri, Jan 22, 2010 at 6:46 PM, Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> wrote: > Also some style fixes. Sorry for the fuss over this :) > --- > dlls/ws2_32/socket.c | 45 ++++++++++++++++++++++++++++++++++----------- > 1 files changed, 34 insertions(+), 11 deletions(-) > Don't even look at this patch, didn't mean to send it (yet). Mike.

1 0

Re: winex11.drv: Added missing mouse position clipping. (try 2)
by Lauri Kenttä Jan. 24, 2010

Jan. 24, 2010

> The SetCursorPos() calls hooks on Wine because Wine has big issue - it doesn't filter pointer move messages that were caused by Wine itself. The first patch (http://source.winehq.org/patches/data/57569) tries to address exactly this. I think XWarpCursor is not a problem, as the event comes asynchronously with some delay. So my patch fixes the easier but worse case, calling hooks directly from SetCursorPos. What's wrong with this, why is it wrong, and do you have a better idea? What else causes Wine to produce extra messages? Also, is there a reason why I shouldn't write a test for this to make the issue better known? >> I'm aware that my version causes hooks to be called with clipped coordinates on mouse move, when they should in that case be called with the unclipped ones. > This particular change will break all games using dinput when mouse pointer goes outside of virtual desktop. (This was the elaboration I was asking for.) I didn't know that, and I don't have any such games. Feel free to reject the patch, I'll rewrite it without this bug and in smaller chunks. (It would be helpful if the first two patches were also either accepted or rejected.) >> returns unclipped coordinates from GetCursorPos > This is what native will do inside hook handler. Add some tests. That's not true. (See below.) >> and even sends incorrect WM_* messages. > Tests please. I've attached a program that outputs coordinates from hookproc and wndproc, both the passed ones and the ones from GetCursorPos. If you try it, you can see that Wine has the following bugs: - incorrect coordinates in some WM:s - incorrect coordinates in some hook calls - incorrect coordinates and missing WM:s after clipping - extra hook calls on SetCursorPos, even if the pos doesn't change - extra WM_MOUSEMOVE after zero-length moves - some other extra hook calls and WM:s due to XWarpPointer The next snippets show the WM bug and how GetCursorPos works inside hook handlers. This first one is from Win2k8 Server. First, the pointer is at (34,34) and clipping is set to (30,30)-(40,40). Then the program calls mouse_event(MOUSEEVENTF_LEFTUP | MOUSEEVENTF_MOVE, 0, 6, 0, 0). 11: hookproc: WM_MOUSEMOVE: (34,40), get = (34,34), injected = 1 11: hookproc: WM_LBUTTONUP: (34,39), get = (34,39), injected = 1 11: wndproc: WM_MOUSEMOVE: (34,39), get = (34,39) 11: wndproc: WM_LBUTTONUP: (34,39), get = (34,39) As you can see, the correct order would be: - call hooks for moving, return old pos from GetCursorPos - clip and store the new position - send the move message using the new position - call hooks and send the button message, both using the clipped position Compare to current Wine output: 11: hookproc: WM_MOUSEMOVE: (34,40), get = (34,34), injected = 1 11: hookproc: WM_LBUTTONUP: (34,40), get = (34,39), injected = 1 11: hookproc: WM_MOUSEMOVE: (34,39), get = (34,39), injected = 0 11: wndproc: WM_MOUSEMOVE: (34,40), get = (34,39) 11: wndproc: WM_LBUTTONUP: (34,40), get = (34,39) 11: wndproc: WM_MOUSEMOVE: (34,39), get = (34,39) Aside of the extra move caused by XWarpPointer, the second hook and both injected messages have incorrect (unclipped) coordinates. > What exactly is wrong with [border scrolling]? Many games (for example, Baldur's Gate) check for mouse coordinates. If the pointer is outside the virtual desktop, Wine gives negative coordinates and the game doesn't scroll left/up, because x != 0 and y != 0. The same thing happens to right/bottom, of course. Correct clipping fixes it. > Who said that Wine should keep the pointer inside virtual desktop? Ok, I'll not do it. But don't you think it's a bit confusing if the pointer moves freely but the program thinks it's clipped to an area? My apologies for bringing up something that is actually none of my business, but I think you should pay more attention to the way you write your comments. First, even small positive comments are considered psychologically very important, but you have given none. Second, most of your negative feedback has only stated that the patches are bad and wrong, often without giving much details or any better ideas. That is, the comments haven't been very constructive. Currently your messages look a bit like "f*** off, noob", which hopefully is not what you had in mind. Anyway, this is certainly not a good way to encourage spending time to Wine development. Some (luckily not me) would take it badly and just rm -rf wine-git and never try again, even if they could be a great help with some guidance. So let's all be nice to each other, and everyone will be happier. -- Lauri Kenttä

4 6

Re: [PATCH 2/8] d3d10: Parse shaders in parse_fx10_local_variable().
by Rico Schüller Jan. 24, 2010

Jan. 24, 2010

Am 24.01.2010 11:22, schrieb Rico Schüller: > --- > dlls/d3d10/effect.c | 37 +++++++++++++++++++++++++++++++++---- > 1 files changed, 33 insertions(+), 4 deletions(-) > > > > > This patch has a bug in it, it doesn't check the return value. Please don't apply it, I'll send an improved version.

1 0

errno-ntstatus conversion
by Mike Kaplinskiy Jan. 24, 2010

Jan. 24, 2010

There are many places where we need to do a conversion between the unix errno and the windows ntstatus (and then sometimes to dos errors). Here are some that I found: http://source.winehq.org/source/server/file.c#L582 http://source.winehq.org/source/server/sock.c#L702 http://source.winehq.org/source/dlls/wininet/netconnection.c#L512 http://source.winehq.org/source/dlls/winhttp/net.c#L153 http://source.winehq.org/source/dlls/ntdll/file.c#L312 Would it be a good idea to perhaps create an include file for both the server and the dlls to convert unix error codes to status/winsock error codes? The reason for 2 functions is winsock error codes do not actually map to any status code, they seem to be there to make porting easier (ie STATUS_CONNECTION_RESET maps to ERROR_CONNECTION_RESET). Does this seem reasonable, or should we just keep duplicating the conversion code everywhere? I have not checked whether there are places that have different statuses for the same unix error, but presumably we can pick a reasonable default and just have special cases within the module. This is coming from some conversion within the server. The server should not return wsa-based error codes in its error events list, and just use wsa conversion when sending window messages. Mike.

1 0

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.
by Austin English Jan. 23, 2010

Jan. 23, 2010

On Sat, Jan 23, 2010 at 9:24 AM, Terry <tbos(a)verizon.net> wrote: Forgot the patch. -- -Austin

1 0

cygwin, perl, wine, rebase, and ReBaseImage()
by Dan Kegel Jan. 22, 2010

Jan. 22, 2010

While building chromium with visual c++ 2005 on wine, step 'webcore_bindings_sources' tries to run WebCore/bindings/scripts/generate-bindings.pl, and sometimes it fails with 13 [main] perl 29 C:\chromium\src\third_party\cygwin\bin\perl.exe: *** fatal error - unable to remap C:\chromium\src\third_party\cygwin\lib\perl5\5.10\i686-cygwin\auto\List\Util\Util.dll to same address as parent(0x1350000) != 0x52760000^M 14 [main] perl 74 fork: child 29 - died waiting for dll loading, errno 11^M http://www.tishler.net/jason/software/rebase/rebase-2.2.README indicates that cygwin's fork() relies on everything mapping to the same address in the child. (Gulp.) This is an occasional problem even on Windows; the usual advice is to run cygwin's rebaseall (carefully). Sure enough, running wine c:\\cygwin\\bin\ash c:\\cygwin\\bin\\rebaseall seems to have solved the problem. Or maybe I just got lucky. Cygwin's rebase command has its own implementation of ReBaseImage(), so it doesn't matter that Wine's is a stub. (Gee, maybe we should ask Ralf sometime if he's willing to relicense it from gpl. We'd have to translate it from C++ to C, too.) - Dan

1 0

comctl32 listview notification assert
by Aric Stewart Jan. 22, 2010

Jan. 22, 2010

Hello, I am seeing something in listview.c that really make me feel like there is something really wrong going on. So maybe it is something I am having a lack of understanding in. I have an application that is sending 'A' style notification codes to the listview header. Specifically I am seeing an HDN_ITEMCHANGEDA. In the listview code the first thing HDN_ITEMCHANGEDA and HDN_ITEMCHANGEDW does is notify_forward_header. notify_forward_header does not understand HDN_ITEMCHANGEDA and then asserts. It looks straight forward to add the A versions of the notifications to that case statement. But often when something looks that straight forward there is something more underlying it. Especailly since this looks like something we would be seeing a lot of if it was as much of an issue as it appears. does anyone have a deeper understanding of the listview code that would help me figure out what is going on. Or maybe just tell me that I am over thinking it and it really is as easy of a fix as it looks. thanks! -aric

1 0

Re: shell32: Dynamically load an ordinal only export.
by Alexandre Julliard Jan. 22, 2010

Jan. 22, 2010

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/shell32/tests/shlfileop.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) This shouldn't be needed, import by ordinal works just fine. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: winmm: Add a bunch of new mmio tests which discover some bugs in mmio handling.
by Alexandre Julliard Jan. 22, 2010

Jan. 22, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -45,6 +45,20 @@ static DWORD RIFF_buf[] = > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 > }; > > +#define expect_buf_offset(_hmmio, _off) \ > +do \ > +{ \ > + MMIOINFO _mmio; \ > + LONG _ret; \ > + memset(&_mmio, 0, sizeof(_mmio)); \ > + _ret = mmioGetInfo((_hmmio), &_mmio, 0); \ > + ok(_ret == MMSYSERR_NOERROR, "mmioGetInfo error %u\n", _ret); \ > + ok(_mmio.lBufOffset == 0, "expected 0, got %d\n", _mmio.lBufOffset); \ > + _ret = mmioSeek((_hmmio), 0, SEEK_CUR); \ > + ok(_ret == (_off), "expected %d, got %d\n", (_off), _ret); \ > +} \ > +while (0) Please avoid such multi-line macros, define a function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] ws2_32: use ntstatus in overlapped functions (try 2)
by Alexandre Julliard Jan. 22, 2010

Jan. 22, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > Also some style fixes and move case 0 to the top - it's the most likely Nothing says that likely cases have to be at the top, and anyway 0 is probably the least likely of all (and should in fact never happen). -- Alexandre Julliard julliard(a)winehq.org

1 0

"Mockba to Berlin" game - mouse not clicking
by Pavel Troller Jan. 22, 2010

Jan. 22, 2010

Hi! My son bought a game DVD bound to a youngster's magazine. It contains a 5 years old game by Monte Cristo Multimedia, called "Mockba to Berlin". We were trying this game with wine 1.1.36. The game PERFECTLY installs and then PERFECTLY launches, going through all the initial screens and videos. It then renders a primary menu on the screen, allowing to start a new game, load a save, perform some settings, etc. The mouse cursor is fully functional, the hovered item gets brightened and an explanatory text appears, which tells, what the particular item is for. BUT: The mouse buttons are DEAD. All. I cannot left-click, right-click, mid-click, simply nothing. It' very frustrating, it looks that just ONE CLICK remains to start the game, but you can't do it! There is no console output related to the problem, just some warnings from the GL renederer, which seem harmless. There is no AppDB entry for this game (we didn't found any), so we cannot follow any hints, how to solve the problem. The game was tested on 3 different machines but with the same wine installation. The results were identical. Are there any general tips, what we can try to solve the problem ? With regards, Pavel

4 5

Re: [2/2] xmllite/reader: Basic input object creation on IXmlReader::SetInput()
by Paul Vriens Jan. 22, 2010

Jan. 22, 2010

On 01/21/2010 07:08 PM, Nikolay Sivov wrote: > This patch depends on previously sent, forget it properly, sorry. > Basic input object creation on IXmlReader::SetInput() > > > > Hi Nikolay, This one doesn't apply cleanly on top of: "xmllite/tests: Test query for supported interface sequence while creating IXmlReaderInput instance" -- Cheers, Paul.

2 1

Re: [PATCH 4/5] xmllite/tests: Add basic test structure for IXmlReader
by Paul Vriens Jan. 22, 2010

Jan. 22, 2010

On 01/18/2010 10:28 PM, Nikolay Sivov wrote: > Add basic test structure for IXmlReader > Hi Nikolay, This one crashes on Vista without a servicepack at: + IXmlReader_Release(reader); +} All the calls before that one look ok (they produce the expected output). I guess "vista without an SP" can be considered broken(), but how do deal with that? -- Cheers, Paul.

3 10

Re: [PATCH 3/3] jscript: Add error handling to Array.reverse
by Paul Vriens Jan. 22, 2010

Jan. 22, 2010

Hi Piotr, On 01/20/2010 05:23 PM, Piotr Caban wrote: > + if(FAILED(hres1)) > + return hres1; > + > hres2 = jsdisp_propget_idx(jsthis, l,&v2, ei, sp); > + if(FAILED(hres2)) { > + VariantClear(&v1); > + return hres2; > + } > > if(hres1 == DISP_E_UNKNOWNNAME) > - jsdisp_delete_idx(jsthis, l); > + hres1 = jsdisp_delete_idx(jsthis, l); Coverity (CID 1022) correctly spotted that the last if() will never be reached as we are now bailing out on a FAILED(hres1). Could you have a look? The same is true (me thinks) for hres2 but Coverity doesn't complain about that one, strange? -- Cheers, Paul.

1 0

RFC: dwarf merge patch
by André Hentschel Jan. 21, 2010

Jan. 21, 2010

Hi, I made a patch to merge code from ntdll/signal_x86_64.c to dbghelp/dwarf.c The operator DW_OP_deref_size needs to read different sizes of variables from memory into a fixed size variable. Now i am not sure if my solution is the smallest and easiest one, so i would be happy for every comment on this. http://www.winehq.org/pipermail/wine-patches/2010-January/083899.html -- Best Regards, André Hentschel

2 3

Fwd: [user32/tests] Don't crash on Win9x/WinMe
by Peter Dons Tychsen Jan. 21, 2010

Jan. 21, 2010

Forgot wine-devel, >>I'm lost here as TrackPopupMenu() is not called in a loop. It's only called once. So which API function are you referring to? I was referring to the "loop" we got into on NT4 where the proc handler would be re-entered again and again. My idea was that if this happened on 9x as well, then this we could cause a crash. Apparently this is not the case. Thanks, /pedro

1 0

Re: winex11.drv: Added missing mouse position clipping. (try 2)
by Vitaliy Margolen Jan. 21, 2010

Jan. 21, 2010

Lauri Kenttä wrote: > When the cursor position is clipped with ClipCursor, the cursor should be > confined to that area. This patch fixes cursor position clipping in > X11DRV_ClipCursor, X11DRV_GetCursorPos, X11DRV_SetCursorPos and > X11DRV_send_mouse_input and makes the mouse warp to the new position if > moved outside the clip rect. > > The previous try fixed only clipping (not warping) and only in > GetCursorPos, but the problem wasn't that small after all. > --- > dlls/winex11.drv/mouse.c | 52 > ++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 41 insertions(+), 11 deletions(-) > You changing way too many things without a single test. Lots of those areas you touch will break oh so many apps. For starters write some tests and verify what you doing is correct. You should be able to write tests for all injected messages (send_mouse_event). If you can't make an automated test, write a visual test for the rest and send to wine-devel. Especially pay attention to all messages sent, and order of calling hook, sending messages, modifying values returned from GetCursorPos(). You breaking that. And don't try to keep pointer inside Wine's window - this won't get past AJ. Vitaliy.

2 2

Re: [user32/tests] Don't crash on Win9x/WinMe
by Peter Dons Tychsen Jan. 21, 2010

Jan. 21, 2010

> It took a while but I found the culprit. The crash is most likely because > the window is (about to be) destroyed. > > The only thing left to do is to fix the 211 test failures on NT4. > > I fixed a typo while at it and used a define instead of a magic value. > > > Are you sure this is the right fix? Is this crash not caused by the loop, and not the actual call to the menu? Other test-cases call the same API without this problem. /pedro

2 3

Re: wmc: Fix symbol was not declared and using plain integer as NULL pointer sparse warnings.
by Jacek Caban Jan. 21, 2010

Jan. 21, 2010

Hi Rob, On 1/21/10 12:57 PM, Rob Shearman wrote: > --- > tools/wmc/wmc.c | 8 +++++--- > tools/wmc/wmc.h | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > --- a/tools/wmc/wmc.h +++ b/tools/wmc/wmc.h @@ -65,7 +65,7 @@ extern node_t *nodehead; extern lan_blk_t *lanblockhead; int mcy_lex(void); -FILE *yyin; +extern FILE *yyin; It looks like it worked before your patch only because it's used only in wmc.c, which means that it probably should be static. Thanks, Jacek

2 2

Re: cmd: Added cmd.exe tests.
by Paul Vriens Jan. 21, 2010

Jan. 21, 2010

On 01/20/2010 06:35 PM, Jacek Caban wrote: > --- > programs/cmd/tests/Makefile.in | 14 ++ > programs/cmd/tests/batch.c | 286 ++++++++++++++++++++++++++++++++++ > programs/cmd/tests/rsrc.rc | 23 +++ > programs/cmd/tests/test_echo.cmd | 9 + > programs/cmd/tests/test_echo.cmd.out | 21 +++ > 5 files changed, 353 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/Makefile.in > create mode 100644 programs/cmd/tests/batch.c > create mode 100644 programs/cmd/tests/rsrc.rc > create mode 100644 programs/cmd/tests/test_echo.cmd > create mode 100644 programs/cmd/tests/test_echo.cmd.out > Hi Jacek, Is the intention to have these being part of winetest? I do think more makefile magic (Dan's old patches?) is needed to get this actually to compile, not? -- Cheers, Paul.

2 1

Some Wine development statistics
by Paul Vriens Jan. 21, 2010

Jan. 21, 2010

Hi, Just found this: http://gitstats.sourceforge.net/examples/wine/index.html -- Cheers, Paul.

1 0

Re: [PATCH] user32/tests: check that SetCursorPos doesn't call hooks.
by Nicolas Le Cam Jan. 21, 2010

Jan. 21, 2010

2010/1/21 Lauri Kenttä <lauri.kentta(a)gmail.com>: > SetCursorPos should not call mouse low-level hooks. > --- > dlls/user32/tests/input.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c > index 7713ff6..a5dba06 100644 > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -1198,6 +1198,7 @@ static void test_keynames(void) > > static POINT pt_old, pt_new; > static BOOL clipped; > +static int hook_proc2_call_times; > #define STEP 3 > > static LRESULT CALLBACK hook_proc1( int code, WPARAM wparam, LPARAM lparam ) > @@ -1231,6 +1232,8 @@ static LRESULT CALLBACK hook_proc2( int code, WPARAM wparam, LPARAM lparam ) > MSLLHOOKSTRUCT *hook = (MSLLHOOKSTRUCT *)lparam; > POINT pt; > > + ++hook_proc2_call_times; > + > if (code == HC_ACTION) > { > ok(hook->pt.x == pt_new.x && hook->pt.y == pt_new.y, > @@ -1281,6 +1284,7 @@ static void test_mouse_ll_hook(void) > HHOOK hook1, hook2; > POINT pt_org, pt; > RECT rc; > + int hook_proc2_call_times_old; > > GetCursorPos(&pt_org); > hwnd = CreateWindow("static", "Title", WS_OVERLAPPEDWINDOW | WS_VISIBLE, > @@ -1347,6 +1351,18 @@ static void test_mouse_ll_hook(void) > GetCursorPos(&pt); > ok(pt.x == pt_new.x && pt.y == pt_new.y, "Position changed: (%d,%d)\n", pt.x, pt.y); > > + /* Check that SetCursorPos doesn't call hooks. > + * Check twice: first moving to old coordinates, then to new. */ > + SetCursorPos(10, 10); > + > + hook_proc2_call_times_old = hook_proc2_call_times; > + SetCursorPos(10, 10); > + ok(hook_proc2_call_times_old == hook_proc2_call_times, "Hooks called\n"); > + > + hook_proc2_call_times_old = hook_proc2_call_times; > + SetCursorPos(20, 20); > + ok(hook_proc2_call_times_old == hook_proc2_call_times, "Hooks called\n"); > + > UnhookWindowsHookEx(hook2); > done: > DestroyWindow(hwnd); > -- > 1.6.6 > > > > Hi Lauri, What about resetting hook_proc2_call_times to 0 before calling SetCursorPos and just checking if it has changed ? Also other static variables used in hook procs aren't prefixed, this is more trivial but everyone is encouraged to follow current code style of the file. -- Nicolas Le Cam

2 1

Re: gdi32: Add OEM charset for processing in TranslateCharsetInfo
by Dmitry Timoshkov Jan. 21, 2010

Jan. 21, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > Some details about this patch: > > The getting charset through the GetTextCharset works with mistakes for OEM > charset. The problem exist in SelectObject where the gdi font is created from > the logical font. Wine try to get information about the charset in this gdi > font creation through TranslateCharsetInfo, but don't able to do it. This > function works with predefined array of supported charsets and code pages. > OEM charset is absent in this array. > > Full list of this array in MSDN: > http://msdn.microsoft.com/en-us/library/dd317754%28VS.85%29.aspx > > This patch add the necessary items to this array. Then you need to add an extensive set of tests for TranslateCharsetInfo() to confirm that it's the source of the problem. Somehow I doubt that this is a correct place for the fix. -- Dmitry.

1 0

example code appending files with w32api broken?
by Hin-Tak Leung Jan. 21, 2010

Jan. 21, 2010

I needed a WIN32 API based file-appending solution to fix a bug (http://bugs.winehq.org/show_bug.cgi?id=21394) and using the example code http://msdn.microsoft.com/en-us/library/aa363778%28VS.85%29.aspx as reference, I have got a somewhat working solution, except if I follow the code, the WriteFile part for appending fails. Then I have cross-gcc compiling that example source code standard-alone, and the resulting executable won't append under wine cmd either. So it looks like either the example code is wrong, or wine's implementation of WriteFile() is a bit broken sometimes. I have determined the ReadFile succceeds and the SetFilePointer() also work) So I have two questions - (1) can somebody tell if there is something obviously wrong with the example, (2) can somebody say if it is because wine is not working e.g. SetPointer doesn't work? On a general question: what's the policy of patches based on MSDN example code like this? I mean, assuming the example does the job, it is quite difficult to write file-appending code which isn't quite similiar to that.

2 5

Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
by Nikolay Sivov Jan. 20, 2010

Jan. 20, 2010

On 1/20/2010 23:46, Andrew Eikum wrote: > --- > dlls/wininet/internet.c | 6 ++++++ > dlls/wininet/tests/internet.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+), 0 deletions(-) > Please mark patches with (tryX) in subject and specify a difference from previous try next time. It's really hard to follow identically named mails without a single line of details.

1 0

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)
by Paul Vriens Jan. 20, 2010

Jan. 20, 2010

On 01/11/2010 09:47 PM, Peter Dons Tychsen wrote: > Try 3 of this patch: > > - Moved check to server. > - Removed handling of error code translation after input from AJ. > > Thanks, > > /pedro > > Hi Peter, This patch has introduced test failures on NT4 and below (tested locally): http://test.winehq.org/data/tests/user32:win.html The callback is entered several times on NT4 (only once on XP) so it seems. The test crashes on Win98 btw. Could you have a look? You can use the winetestbot (https://winetestbot.geldorp.nl/) to check the failures on NT4. I can assist with Win9x testing if needed. I'm busy setting up a local winetestbot that includes Win95, Win98 and WinMe. -- Cheers, Paul.

2 2

Re: oleaut32: do not crash in logging if string is NULL
by Alexandre Julliard Jan. 20, 2010

Jan. 20, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -68,10 +68,16 @@ typedef struct _marshal_state { > > /* used in the olerelay code to avoid having the L"" stuff added by debugstr_w */ > static char *relaystr(WCHAR *in) { > - char *tmp = (char *)debugstr_w(in); > - tmp += 2; > - tmp[strlen(tmp)-1] = '\0'; > - return tmp; > + static char szNull[] = "<NULL>"; > + if (in) > + { > + char *tmp = (char *)debugstr_w(in); > + tmp += 2; > + tmp[strlen(tmp)-1] = '\0'; > + return tmp; > + } > + else > + return szNull; > } This should never happen. Places that can get a null pointer should use the standard debugstr_w. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: kernel32/tests: do not compare handle with zero directly (Smatch)
by Dan Carpenter Jan. 20, 2010

Jan. 20, 2010

Sorry, I'm not on the list. - ok( file != 0, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); + ok( !!file, "CreateFileMapping PAGE_READWRITE error %u\n", GetLastError() ); Smatch sees those as equivelent. (The new version does at least http://repo.or.cz/w/smatch.git) There is a wine_checker.sh script in smatch_scripts so you can quickly test individual files. I just pushed a change to make wine_checker.sh find the smatch binary so you may want to pull the most recent changes. /path/to/smatch_scripts/wine_checker.sh dlls/kernel32/tests/virtual.c Michael said it could be either real bug or a false positive. I sort of decided it was a false positive and pushed a change to fix that. Now if "file" gets 1) reassigned 2) incremented/decremented 3) passed to a function like this: fuction(&file); it stops being called a filehandle. (Unless it gets reassigned another file handle obviously). Hope that is Ok. The check only prints a warning if something is _definitely_ a file handle and it gets compared to zero. I could easily change it to print a message if something is _possibly_ a file handle and gets compared against zero. Like this: if (x) file = CreateFile(); else file = some_func(); if (file) // <- complain I know smatch has been abandonware for a long time, but I hope to do better now. regards, dan carpenter

1 2

WINEDEBUG=+relay: why unicode arguments printed in form L"\0412\044b" and not L"\x412\x44b"? 044b sure not octal
by Илья Басин Jan. 20, 2010

Jan. 20, 2010

/////////////////////////// #include <windows.h> int main() { MessageBoxExW(NULL, L"\x412\x44b \x434\x435\x439\x441\x442\x432\x438\x442\x435\x43b\x44c\x43d\x43e \x445\x43e\x442\x438\x442\x435 \x443\x434\x430\x43b\x438\x442\x44c \"\x43f\x440\x438\x43f\x430\x440\x43a\x43e\x432\x430\x43d\x43d\x44b\x435\" \x43f\x438\x441\x44c\x43c\x430?\r\r\x410\x442\x440\x438\x431\x443\x442 \x41f\x430\x440", L"The Bat! Voyager", 0x00012133, 0x00000019); } /////////////////////////// # WINEDEBUG=+relay wine msgbox.exe 2>&1 | grep "MessageBoxExW" 0009:Call user32.MessageBoxExW(00000000,0040a028 L"\0412\044b \0434\0435\0439\0441\0442\0432\0438\0442\0435\043b\044c\043d\043e \0445\043e\0442\0438\0442\0435 \0443\0434\0430\043b\0438\0442\044c \"\043f\0440\0438\043f\0430\0440\043a\043e\0432\0430\043d\043d\044b\0435\" \043f\0438\0441\044c\043c\0430?\r\r\0410\0442\0440\0438\0431\0443\0442 \041f\0430\0440",0040a000 L"The Bat! Voyager",00012133,00000019) ret=0040101c 0009:Ret user32.MessageBoxExW() retval=00000000 ret=0040101c

2 1

Re: [PATCH 4/5] wined3d: Don't use the depth range clipping hack when we have ARB_depth_clamp.
by Chris Robinson Jan. 20, 2010

Jan. 20, 2010

On Tuesday 19 January 2010 2:52:28 pm Henri Verbeet wrote: > ARB_depth_clamp should give pretty much the desired behaviour by clamping > instead of clipping depth values outside the depth range. I think you need to make sure glEnable(GL_DEPTH_CLAMP) gets called in state_clipping if you're going to bypass the depth range hack with it. Currently it's only called if WINED3DRS_CLIPPING is off.

3 8

valgrind run called on account of rain
by Dan Kegel Jan. 20, 2010

Jan. 20, 2010

Today's scheduled match between Valgrind and Wine was called on account of rain. The roofers think they found where the water was coming in, and the rainstorm can't last forever; I'm hoping to turn the Valgrind build machine on again later this week. Once it dries out :-)

4 4

Re: [PATCH 3/5] wined3d: Don't use the depth range clipping hack when minZ and maxZ are equal.
by Stefan Dösinger Jan. 20, 2010

Jan. 20, 2010

Am 19.01.2010 um 23:52 schrieb Henri Verbeet: > - if (!stateblock->device->untransformed) > + if (!stateblock->device->untransformed && minZ != maxZ) My tests show that this is not needed, at least in d3d8 and d3d9. My (unsent) tests show that if you pass MinZ == MaxZ SetViewport adjusts one of them to make sure they're apart by at least 0.001. If the parameters are < 0.999 maxZ is incremented by 0.001, otherwise minZ is set to 0.999. (If my memory serves me right) That said, I will be busy the next 2 weeks at university, so don't expect the test and a fix for SetViewport in in that time. Plus, I still haven't ported my tests to ddraw, which may behave differently. If it helps your work feel free to put the patch in in the meantime, although obviously it would be better to skip it to avoid forgetting about it later.

1 0

re: Usage of libxml2 for several modules
by Dan Kegel Jan. 19, 2010

Jan. 19, 2010

http://xmlsoft.org/threads.html says it's only a problem if the same document is being parsed by both threads. The trouble scenario seems unlikely, offhand.

4 7

Re: [6/10] winemapi: Add MAPIInitialize implementation.
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Nguyen <arethusa26(a)gmail.com> writes: > This seemed to be the easiest and most trivial way to allow > MAPIInitialize to succeed in the tests, which will be added in the > next several patches. That doesn't seem right. The tests should be able to work without an extended provider. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in > index ba8f662..66a756f 100644 > --- a/dlls/wininet/tests/Makefile.in > +++ b/dlls/wininet/tests/Makefile.in > @@ -10,6 +10,7 @@ CTESTS = \ > generated.c \ > http.c \ > internet.c \ > + option.c \ This can go with the other internet tests in internet.c, there's no need for a new file. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/6] ws2_32: convert wsa errors to ntstatus in overlapped callbacks
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -542,6 +542,35 @@ static inline DWORD NtStatusToWSAError( const DWORD status ) > return wserr; > } > > +/* most ws2 overlapped functions return an ntstatus-based error code */ > +static inline NTSTATUS WSAErrorToNtStatus( const DWORD error ) > +{ In general conversions should go status->error, not the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Fix the Ctrl+Break processing
by Dmitry Timoshkov Jan. 19, 2010

Jan. 19, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > + /* Ctrl+Break processing */ > + if ((e->state & ControlMask) && > + (e->keycode == 0x7F)) > + return VK_CANCEL; It's always a good idea to provide some details. Like: pressing the Pause/Break key alone produces VK_PAUSE vkey, while pressing Ctrl+Pause/Break produces VK_CANCEL under Windows, but not under Wine. Ilya, it's better to use a keysym instead of keycode, and add an explanation in the source as well as in the patch comment. -- Dmitry.

1 0

Ubuntu survey
by sacchi antonio Jan. 18, 2010

Jan. 18, 2010

This is a survey for the apps that users would like to see in upcoming version of Ubuntu: what do you think?? ubuntuforums.org/showthread.php?t=1381221 www.surveymonkey.com/s/GFVQP62 P.S. Please suggest AutoCAD :-D

2 1

Re: [1/2] msi: Support retrieving rows from join tables.
by James Hawkins Jan. 18, 2010

Jan. 18, 2010

On Mon, Jan 18, 2010 at 4:09 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/msi/join.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > Tests please? Thanks, James

1 0

Arwinss
by Aleksey Bragin Jan. 18, 2010

Jan. 18, 2010

Hello, I would like to present my project here too, because I think this information will be interesting for Wine developers. At least, I have not seen anyone gone that far using Wine code. I came up with an idea to create an alternative Win32 subsystem, which would be targeted to NT-alike OSes: Windows NT family and of course ReactOS, based on Wine as much as possible. Detailed presentation with explanations is attached, along with links to some more information. Briefly, what I did: gdi32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. user32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. What about Wineserver, you would ask? SERVER_START_REQ and related macros are rewritten to perform a syscall to win32k.sys (more about win32k.sys below). Server protocol is the same, but of course many requests aren't need. winex11.drv - this is the one if you want X Server to be your interface. This is unchanged Wine source code, again compiled inside a ReactOS source tree into a PE DLL winent.drv - an alternative user/gdi driver, which mostly forwards all calls into a kernel mode graphics engine located in win32k.sys (which is compatible with Windows video drivers, so all acceleration could be used). win32k.sys - kernelmode counterpart of the new Win32 subsystem, contains graphics engine, user server which is based on a small part of platform-independent Wineserver source code adapted to kernelmode, and a simple window manager which calculates visible regions for windows and manages window showing/hiding. All other parts are used from the host OS (be it Windows, or ReactOS). The most funny thing is that this subsystem actually started to work! (I attached a few screenshots in the presentation). There are still some bugs making Arwinss not really usable at the moment, but I'm inviting all developers to participate and help me bring it to a fully usable condition, so that it supports at least all apps which Wine supports plus those which Wine doesn't support due to problems in other parts. The presentation: (links to source code and further information are in the presentation) http://www.reactos.org/media/docs/2010/arwinss.pdf With the best regards, Aleksey Bragin.

1 0

Re: sti: add launch application registry
by Alexandre Julliard Jan. 18, 2010

Jan. 18, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -387,6 +387,7 @@ HKLM,%CurrentVersion%\Controls Folder\PowerCfg,"LastID",,"5" > HKLM,%CurrentVersion%\RunServices,"winemenubuilder",2,"%11%\winemenubuilder.exe -a -r" > HKLM,%CurrentVersion%\Setup,"BootDir",,"%30%" > HKLM,%CurrentVersion%\Setup,"SharedDir",,"%25%" > +HKLM,%CurrentVersion%\StillImage\Registered Applications Unless there's an app that requires the empty key, you should create it as needed from the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

winetestbot changes
by Greg Geldorp Jan. 18, 2010

Jan. 18, 2010

A couple of changes to the test bot: - Maximize number of powered on VMs (Paul Vriens) - Make tag prefix for test.winehq.org submissions configurable (Paul Vriens) - Add support for VMs on multiple hosts, add Windows 95/95B/98/98SE VMs - Make the "File" field on the "Submit job" page accept longer file names - Add feedback page Ge.

1 0

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name (supercedes first patch)
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

Hi Uwe, On 01/17/2010 03:56 PM, Uwe Bonnes wrote: > + if (hFile != INVALID_HANDLE_VALUE) > + { > + CloseHandle( hFile ); > + DeleteFileA("test/"); > + } Indentation is a bit off here (probably because you are mixing tabs and spaces). The rest of your patch also mixes tabs and spaces. This file mostly uses spaces so please do that as well. FWIW, the file that is created doesn't have the slash. -- Cheers, Paul.

1 0