January 2010 - Wine-Devel - list.winehq.org

Re: [6/10] winemapi: Add MAPIInitialize implementation.
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Nguyen <arethusa26(a)gmail.com> writes: > This seemed to be the easiest and most trivial way to allow > MAPIInitialize to succeed in the tests, which will be added in the > next several patches. That doesn't seem right. The tests should be able to work without an extended provider. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/5] wininet: Add Internet{Set, Query}Option tests, implement POLICY option
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in > index ba8f662..66a756f 100644 > --- a/dlls/wininet/tests/Makefile.in > +++ b/dlls/wininet/tests/Makefile.in > @@ -10,6 +10,7 @@ CTESTS = \ > generated.c \ > http.c \ > internet.c \ > + option.c \ This can go with the other internet tests in internet.c, there's no need for a new file. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/6] ws2_32: convert wsa errors to ntstatus in overlapped callbacks
by Alexandre Julliard Jan. 19, 2010

Jan. 19, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -542,6 +542,35 @@ static inline DWORD NtStatusToWSAError( const DWORD status ) > return wserr; > } > > +/* most ws2 overlapped functions return an ntstatus-based error code */ > +static inline NTSTATUS WSAErrorToNtStatus( const DWORD error ) > +{ In general conversions should go status->error, not the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Fix the Ctrl+Break processing
by Dmitry Timoshkov Jan. 19, 2010

Jan. 19, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > + /* Ctrl+Break processing */ > + if ((e->state & ControlMask) && > + (e->keycode == 0x7F)) > + return VK_CANCEL; It's always a good idea to provide some details. Like: pressing the Pause/Break key alone produces VK_PAUSE vkey, while pressing Ctrl+Pause/Break produces VK_CANCEL under Windows, but not under Wine. Ilya, it's better to use a keysym instead of keycode, and add an explanation in the source as well as in the patch comment. -- Dmitry.

1 0

Ubuntu survey
by sacchi antonio Jan. 18, 2010

Jan. 18, 2010

This is a survey for the apps that users would like to see in upcoming version of Ubuntu: what do you think?? ubuntuforums.org/showthread.php?t=1381221 www.surveymonkey.com/s/GFVQP62 P.S. Please suggest AutoCAD :-D

2 1

Re: [1/2] msi: Support retrieving rows from join tables.
by James Hawkins Jan. 18, 2010

Jan. 18, 2010

On Mon, Jan 18, 2010 at 4:09 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/msi/join.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > Tests please? Thanks, James

1 0

Arwinss
by Aleksey Bragin Jan. 18, 2010

Jan. 18, 2010

Hello, I would like to present my project here too, because I think this information will be interesting for Wine developers. At least, I have not seen anyone gone that far using Wine code. I came up with an idea to create an alternative Win32 subsystem, which would be targeted to NT-alike OSes: Windows NT family and of course ReactOS, based on Wine as much as possible. Detailed presentation with explanations is attached, along with links to some more information. Briefly, what I did: gdi32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. user32.dll - source code is nearly unmodified from Wine, but compiled in ReactOS tree, into a real PE DLL. What about Wineserver, you would ask? SERVER_START_REQ and related macros are rewritten to perform a syscall to win32k.sys (more about win32k.sys below). Server protocol is the same, but of course many requests aren't need. winex11.drv - this is the one if you want X Server to be your interface. This is unchanged Wine source code, again compiled inside a ReactOS source tree into a PE DLL winent.drv - an alternative user/gdi driver, which mostly forwards all calls into a kernel mode graphics engine located in win32k.sys (which is compatible with Windows video drivers, so all acceleration could be used). win32k.sys - kernelmode counterpart of the new Win32 subsystem, contains graphics engine, user server which is based on a small part of platform-independent Wineserver source code adapted to kernelmode, and a simple window manager which calculates visible regions for windows and manages window showing/hiding. All other parts are used from the host OS (be it Windows, or ReactOS). The most funny thing is that this subsystem actually started to work! (I attached a few screenshots in the presentation). There are still some bugs making Arwinss not really usable at the moment, but I'm inviting all developers to participate and help me bring it to a fully usable condition, so that it supports at least all apps which Wine supports plus those which Wine doesn't support due to problems in other parts. The presentation: (links to source code and further information are in the presentation) http://www.reactos.org/media/docs/2010/arwinss.pdf With the best regards, Aleksey Bragin.

1 0

Re: sti: add launch application registry
by Alexandre Julliard Jan. 18, 2010

Jan. 18, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -387,6 +387,7 @@ HKLM,%CurrentVersion%\Controls Folder\PowerCfg,"LastID",,"5" > HKLM,%CurrentVersion%\RunServices,"winemenubuilder",2,"%11%\winemenubuilder.exe -a -r" > HKLM,%CurrentVersion%\Setup,"BootDir",,"%30%" > HKLM,%CurrentVersion%\Setup,"SharedDir",,"%25%" > +HKLM,%CurrentVersion%\StillImage\Registered Applications Unless there's an app that requires the empty key, you should create it as needed from the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

winetestbot changes
by Greg Geldorp Jan. 18, 2010

Jan. 18, 2010

A couple of changes to the test bot: - Maximize number of powered on VMs (Paul Vriens) - Make tag prefix for test.winehq.org submissions configurable (Paul Vriens) - Add support for VMs on multiple hosts, add Windows 95/95B/98/98SE VMs - Make the "File" field on the "Submit job" page accept longer file names - Add feedback page Ge.

1 0

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name (supercedes first patch)
by Paul Vriens Jan. 17, 2010

Jan. 17, 2010

Hi Uwe, On 01/17/2010 03:56 PM, Uwe Bonnes wrote: > + if (hFile != INVALID_HANDLE_VALUE) > + { > + CloseHandle( hFile ); > + DeleteFileA("test/"); > + } Indentation is a bit off here (probably because you are mixing tabs and spaces). The rest of your patch also mixes tabs and spaces. This file mostly uses spaces so please do that as well. FWIW, the file that is created doesn't have the slash. -- Cheers, Paul.

1 0