January 2010 - Wine-Devel - list.winehq.org

Re: Patch feedback requested for OleCreatePropertyFrame()
by Geoffrey Hausheer Jan. 4, 2010

Jan. 4, 2010

On Mon, Jan 4, 2010 at 4:39 AM, John Klehm wrote: > On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies <huw(a)codeweavers.com> wrote: >> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote: >>> I found a patch from 2001 written by TAKESHIMA Hidenori that >>> was posted to wine-patches >>> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html) >>> but never committed. >> >> Actually it was commited (2843934af5515c7f2b8370324aa98d3964a40324) >> but was then removed (140e7222e0d7ce76068cddc64c68105c2e569257) at >> his request. >> > > In case anyone was just slightly less curious than me about it: > http://www.winehq.org/wwn/122#Quartz.dll%20Removal > Thanks for turning that up. I did look through the archives to see what hapened, but aparently not hard enough. So now the only solution appears to be to rewrite the code from scratch. The question is, can I do that now that I've looked over his code? It does turn this from a simple fix to a much more daunting task. There doesn't appear to be anything in this code that would be patent encumbered, but the code itself certainly falls under Hidenori's copyright which he has effectively revoked permission to use. .Geoff

2 1

Re: [PATCH] Revert "dsound: Only initialize one guid for capture and renderer."
by Alexandre Julliard Jan. 4, 2010

Jan. 4, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > This reverts commit b474649e0e9491f938f1daec74cdca01343dd97e. Please explain why. -- Alexandre Julliard julliard(a)winehq.org

2 1

Patch feedback requested for OleCreatePropertyFrame()
by Geoffrey Hausheer Jan. 4, 2010

Jan. 4, 2010

Some software I'm using is configured via an OleCreatePropertyFrame call which isn't implemented in Wine (ticket #16564). I can use winetricks + dcom98 to get it working, but would prefer not to need that. I found a patch from 2001 written by TAKESHIMA Hidenori that was posted to wine-patches (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html) but never committed. I cleaned up the patch to compile against current Git and am including it here for inspection. I can't find any documentation on why it wasn't included at that time, and haven't done any Wine development for a long time, so I'm not sure what it will take to get it included. I have tested it, and it works pretty much fine for me (not quite as pretty as the dcom menu, but it is functional). I'd be happy to write a test for it if I had any idea how to do that, but I'm not sure where to begin for a function like this. Anyhow, I'm open to feedback on what should be done before I submit the patch for inclusion FYI: I was unable to find a currently valid email address for Takeshima .Geoff

4 3

RE: WineTestBot changes
by Greg Geldorp Jan. 4, 2010

Jan. 4, 2010

> > I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows > > executables you can now also submit patch files to the bot. The bot will > > apply the patch files to a clean git tree, cross-compile the test and run the > > test on Windows VMs. You'll also be able to download the cross-compiled test > > executable to test it on different Windows machines. > > I've had to reverse this change for now as it causes major problems. Fixed the problem (race condition which didn't show up on my uniprocessor test system but became very visible on the multiprocessor production system) and reinstated the change. You can submit patches to the bot again. Ge.

1 0

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends
by Paul Vriens Jan. 3, 2010

Jan. 3, 2010

On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote: > This patch depends on Detlef Riekenberg's patch from June 2008 and > expects it to have been applied: > http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html > > It was not committed due to bug 14085: > http://bugs.winehq.org/show_bug.cgi?id=14085 Can't you just submit that initial test framework with the 3 imports (if all 3 are indeed needed)? The bug will of course not be closed but at least some of your work could be committed. -- Cheers, Paul.

4 3

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > + dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; > What does this '2' mean?

2 4

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. A test required for this - let's say check that an ownerdata listview send LVN_GETDISPINFO before text update and the same thing for callback text (don't remember now maybe similar tests are already in).

3 3

Re: comctl32: Get the test in the correct format
by Nikolay Sivov Jan. 2, 2010

Jan. 2, 2010

On 1/2/2010 12:47, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) You don't need this. Conversion is done next lines if needed: --- if (isW) bSame = (lstrcmpW(dispInfo.item.pszText, pszText) == 0); else { LPWSTR tmp = textdupTtoW(pszText, FALSE); bSame = (lstrcmpW(dispInfo.item.pszText, tmp) == 0); textfreeT(tmp, FALSE); } ---

2 1

[rfc] initial conformance test for programs/cmd
by Dan Kegel Jan. 2, 2010

Jan. 2, 2010

How's this look? I've only tested it lightly, but it should be pretty close; with this, "make test" ought to recurse down into programs/cmd/tests and run the cmd tests, too. Shortcomings: - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround - I think I can turn on echo again in tests/*.cmd, that was another workaround - I have yet to add a way to specify that a test is todo_wine Feedback welcome. I'll try to submit something tomorrow that takes care of the above known issues and any issues anyone else points out. (I'm actually kind of amazed the build machinery changes work, I didn't really take the time to understand all of the gears and pulleys.)

3 3

merge wine-website's Todo
by Thomas Heckel Jan. 2, 2010

Jan. 2, 2010

Hi, the last days I had some free time and tried to make some cleanups to the wiki. I mainly worked on the pages related to quality assurance because my little contributions was to Austin's AppInstall which is on this topic. I hope this way I can contribute to the project. At the moment I stumbled over this old page at the website: http://www.winehq.org/status/todo It seems to me this would be a good candidate to be merged into wiki too. What do you think? Bye -- Thomas Heckel

2 1