October 2010 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

CD-ROM ioctl support on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com June 6, 2011

June 6, 2011

Hi, what's the state of CD-ROM support on the Mac? ntdll/cdrom.c contains quite a few #ifdef apple. I'm asking because the mcicda currently uses these ioctl: 1. READ_RAW 2. READ_TOC 3. READ_Q -> POSITION MCICDA could be changed to avoid the third one entirely -- when using the dsound output. Would that be enough to use mcicda on MacOS to play music? Thanks for your help, Jörg Höhle

2 3

Two enhancement requests for winetricks
by Dan Kegel Feb. 21, 2011

Feb. 21, 2011

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

USB Device Support
by James Mckenzie Feb. 19, 2011

Feb. 19, 2011

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang Jan. 8, 2011

Jan. 8, 2011

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard Dec. 11, 2010

Dec. 11, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

First contact
by Andréas LIVET Nov. 3, 2010

Nov. 3, 2010

Hi all wine developers, I read this mailing list for about one year I guess but I think I never send a message. Because until this Monday, I was a spectator, now I wanna become an "actor", I want to learn how to hack wine :). I don't have a lot of time, 1 hour/week, maybe more, but I just want to fix some bugs, if I find some, and maybe more in the future. I'll take my time. For info, I'm a video game developers for 2 years, so I'm a C++ programmer, I know nothing about C (except what I know from the C++) and even if I'm using exclusively linux (ubuntu) for 3/4 years at home, I'm not comfortable with the POSIX development environment... Not that I'm a fan of Visual C++/Visual Assist but I always use those tools (at school and then at work) and wanted to learn something else. I decided to start with a game (Paraworld, but it could be anything) which can't load a level : when I hit the start game button, I got the loading screen, the music etc. but nothing append. The mouse is still reacting, the music still playing but nothing is loading. There is nothing in the trace too, so I tried with the "WINEDEBUG=+relay", error!! I ended quickly with a log > 300Mo before seeing the main menu! I've seen that there is a patch which allows user to control when debug trace will be display, but I don't know how to find it. I found this page : http://www.mail-archive.com/wine-devel(a)winehq.org/msg05542.html But I can't find the archive (the patch file), is there a place where we could download patches? Maybe my question is very simple, but I'm a beginner so be indulgent, please :). Other question, is there a way with winedbg to "pause" program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. This is possible with VCC, maybe it's not with winedbg? Anyway, thank you for your time, and I want to congratulate all the wine developers for their amazing work, win is getting better and better everyday thanks to you, Andréas --Not sent from an iPhone.

3 7

Re: [PATCH 4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO.
by testbot＠testbot.winehq.org Oct. 31, 2010

Oct. 31, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20). sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20).

1 0

up for a quick challenge? "Test Drive Unlimited 2" open beta this weekend only...
by Dan Kegel Oct. 31, 2010

Oct. 31, 2010

and installs ok with dotnet20... but it's stuck on "Checking files, please wait". http://appdb.winehq.org/objectManager.php?sClass=version&iId=21811 http://en.wikipedia.org/wiki/Test_Drive_Unlimited_2 (Wikipedia says it will require .net 3.5, ugh.) While it's sitting, it outputs stuff like fixme:thread:NtQueryInformationThread info class 16 not supported yet fixme:ole:Context_CC_ContextCallback (0x4956060/0x4956064)->(0x79f277a5, 0x2a7e4e8, {d7174f82-36b8-4aa8-800a-e963ab2dfab9}, 2, (nil)) fixme:thread:NtQueryInformationThread info class 16 not supported yet I guess the next step is to look at the packets on the wire on windows and see if it's getting stuck trying to phone home...

1 0

Re: comctl32/treeview: Make item data layout partially compatible with native one
by testbot＠testbot.winehq.org Oct. 31, 2010

Oct. 31, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6609 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === No test summary line found === W2KPROSP4 (32 bit treeview) === No test summary line found

1 0

Purist keyword?
by Austin English Oct. 31, 2010

Oct. 31, 2010

I see quite a few people filing bugs that are only exposed when bundled native dlls are removed. I think it would be good to be able to group these bugs, perhaps with a 'purist' keyword. Anyone opposed?

5 6

RFC: quartz: Don't block indefinitely when pausing after end of stream
by Vladimir Panteleev Oct. 31, 2010

Oct. 31, 2010

The attached patch attempts to fix http://bugs.winehq.org/show_bug.cgi?id=24869 , but due to my limited knowledge of DirectShow I'm not certain about its correctness. Can anyone point out if there's anything wrong with it?

1 0

Re: Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken.
by Vitaliy Margolen Oct. 31, 2010

Oct. 31, 2010

On 10/30/2010 06:12 AM, Sami Aario wrote: > Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken. > > From: Sami Aario <saempy(a)hima.(none)> Your e-mail isn't set correctly in git configuration. > dlls/ntdll/nt.c | 63 ++++++++++++++++++++++++++++++++++++++++ > include/wine/server_protocol.h | 18 +++++++++++- > server/protocol.def | 6 ++++ > server/request.h | 5 +++ > server/token.c | 36 +++++++++++++++++++++++ > server/trace.c | 10 ++++++ Please don't include changes to automatically generated files (server_protocol.h, request.h, trace.c). > + SERVER_START_REQ( set_token_sid ) > + { > + SID *sid = ((TOKEN_OWNER *)TokenInformation)->Owner; > + WORD size; > + > + if (sid) size = RtlLengthRequiredSid(sid->SubAuthorityCount); > + else size = 0; > + > + TRACE("size=%d\n", size); > + > + req->handle = wine_server_obj_handle( TokenHandle ); > + req->which_sid = TokenInformationClass; > + wine_server_add_data( req, sid, size ); > + ret = wine_server_call( req ); > + } > + SERVER_END_REQ; Please get everything outside of SERVER_START_REQ()/SERVER_END_REQ except actual wine_server function calls and handling of returned result(s). Some functions can do their own server calls and you will have a deadlock. > + case TokenOwner: > + free( token->user ); > + token->user = NULL; > + > + if (sid_len) > + token->user = memdup( sid, sid_len ); > + break; This is wrong, you can't clear token user - it always have to be set, or you risking an assert in get_token_sid. Which means you have to validate the data user passes in. Vitaliy.

1 0

re: Purist keyword?
by Dan Kegel Oct. 30, 2010

Oct. 30, 2010

The keyword might be useful for a pragmatist looking for bugs to fix, who didn't want to fix bugs masked by a bundled native DLL. I don't know how many such people there are, though. Best to wait until somebody says they need the keyword before we add it... until then, we can just use the word 'purist' in the body of the bug as we've started doing.

1 0

re: WINE Performance and Evernote 4.0 Windows Client
by Dan Kegel Oct. 30, 2010

Oct. 30, 2010

Hi Martin, > http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks for letting us know. Looking at that thread, your message, and the appdb entry http://appdb.winehq.org/objectManager.php?sClass=version&iId=21775 it looks like people are reporting four or so problems: - autoupdate doesn't work - pdf preview hangs or is slow - switching notebooks is slow - clicking on menu is slow It would probably help to have Wine bug reports at http://bugs.winehq.org for each individual problem, with clear instructions for non-Evernote users on how to reproduce them. (I'd file a couple myself, but I don't have time to experiment at the moment.) - Dan

1 0

ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel
by David Adam Oct. 30, 2010

Oct. 30, 2010

Any problem with this patch? A+ David

1 0

WINE Performance and Evernote 4.0 Windows Client
by Martin Packer Oct. 30, 2010

Oct. 30, 2010

Evernote are in the process of releasing 4.0 of their Windows client. This is completely rewritten to avoid the use of things that would stop it running under WINE. (This WASN'T their target - it was more about device drivers that had been problematic.) It runs reasonably well on the latest WINE. However it runs slowly (in a way it doesn't under "real" Windows) and also the autoupdater doesn't seem to work. Is anyone here willing to work with them and us to help it run faster? (I haven't got commitment from Evernote to make changes but I have got their attention now.) :-) Hopefully you can see this thread on the Evernote bulletin board: http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks, Martin Martin Packer, Mainframe Performance Consultant, zChampion Worldwide Banking Center of Excellence, IBM +44-7802-245-584 email: martin_packer(a)uk.ibm.com Twitter / Facebook IDs: MartinPacker Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

1 0

Linux kernel and game performance?
by Dan Kegel Oct. 29, 2010

Oct. 29, 2010

Hey folks, I've run into two web sites that claim that the Linux kernel causes performance problems in particular games (see below). Anybody know of others? And has anybody found concrete improvements in performance of a particular app (other than an audio workstation app) from using a realtime kernel? Thanks! - Dan First: http://wiki.archlinux.org/index.php/World_of_Warcraft#Kernel_Timing_Bug says in a section dated September 2008: "If you are having problems with choppy video every 15 seconds or so, it is related to the kernel scheduler... to fix, add CONFIG_SCHED_DEBUG=y to your kernel config, then set kernel.sched_features=21 kernel.sched_batch_wakeup_granularity_ns=25000000 kernel.sched_min_granularity_ns=4000000 in /etc/sysctl.cfg." Yikes. Any truth to that rumor? Second: http://hisouten.koumakan.jp/wiki/Linux_support#Resolved_bugs says "The game runs too slowly Symptoms: Instead of running at about 60-62fps, like the game is supposed to, it'll run closer to 53fps. This is not ideal. The bug: This is a Linux timing issue. The game runs a secondary timing thread with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms and sends events to the main thread to tell it that a new frame is needed. On Linux the necessary timing accuracy is not available, so it wavers between 16ms and 20ms. The fix: I hacked around this by setting the timer period to 14ms. This leads to a steady 62-63fps. Which is close enough for use, really. For a constant 60fps turn on vsync in your video drivers."

4 5

Re: Windows Installer change in behaviour Wine 1.3.5.
by James Mckenzie Oct. 29, 2010

Oct. 29, 2010

Damian Dixon <damian.dixon(a)gmail.com> wrote: {Please send replies only to the Wine Devel mailing list.} > >I have installed my application under Wine 1.3.5 however with this version >of Wine the registry is not updated by the installer. Name of application, Linux distribution please. Also please file a bug report, if one does not exist. > >The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as >it has worked before with older versions of Wine. > Looks like a regression to me. However, 1.3.6 is about to be released (maybe today.) Would have been great to catch this. James McKenzie

1 0

Re: [3/3] gdi32: Make AddFontToList return a pointer to first loaded face.
by Alexandre Julliard Oct. 29, 2010

Oct. 29, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 35 ++++++++++++++++++++--------------- > 1 files changed, 20 insertions(+), 15 deletions(-) You are lucky, it turns out that I screwed up and committed your original patch by mistake ;-) But I still don't see why you are returning that pointer, could you please send the code that makes use of this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Crash bug in Wine 1.3.5 in advapi32/service.c
by Damian Dixon Oct. 29, 2010

Oct. 29, 2010

Hi, In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the lpservicestatus is not checked to see if the value is NULL. This causes a crash in an application that has worked before under wine. My naive change is: if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData, sizeof(SERVICE_STATUS)) ; Regards Damian

2 1

Windows Installer change in behaviour Wine 1.3.5.
by Damian Dixon Oct. 29, 2010

Oct. 29, 2010

Hi, I have installed my application under Wine 1.3.5 however with this version of Wine the registry is not updated by the installer. The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as it has worked before with older versions of Wine. I've not had the time to investigate but thought someone my be interested. Regards Damian

1 0

Re: [4/5] msxml3: Add XSLPattern nodeType() method
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6591 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === WVISTAADM (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PRO (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (64 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1

1 0

Re: [5/5] msxml3: Implement XSLPattern collection methods
by Alexandre Julliard Oct. 29, 2010

Oct. 29, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > From d7dfd1e50a295c9bae15f83ed418cfa5f0890d58 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <amartinson(a)codeweavers.com> > Date: Thu, 28 Oct 2010 20:22:22 -0500 > Subject: [PATCH 8/8] msxml3: Implement XSLPattern collection methods > To: wine-patches <wine-patches(a)winehq.org> This one causes some scary warnings: bison -p xslpattern_ -o xslpattern.tab.c -d xslpattern.y xslpattern.y: conflicts: 14 shift/reduce, 42 reduce/reduce xslpattern.y:298.31-42: warning: rule useless in parser due to conflicts: PrimaryExpr: FunctionCall -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] include: Better distinguish ARM's endianess
by Paul Chitescu Oct. 29, 2010

Oct. 29, 2010

On Friday 29 October 2010 05:34:31 pm André Hentschel wrote: > --- > include/basetsd.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 6ce0102..aa6e86d 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -291,7 +291,11 @@ typedef ULONG_PTR KAFFINITY, *PKAFFINITY; > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS > -#elif defined(__arm__) > +#elif defined(__ARMEB__) > +# define WORDS_BIGENDIAN > +# define BITFIELDS_BIGENDIAN > +# undef ALLOW_UNALIGNED_ACCESS > +#elif defined(__ARMEL__) > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS Not relevant just here but please note that in little endian ARM the hardware coprocessor compatible double type is cross endian (octets are: 5 6 7 8=MSB 1=LSB 2 3 4) while big endian is normal (8=MSB 7 6 5 4 3 2 1=LSB). The processor swaps octets in the 32 bit halves of the type but not the halves themselves. On Linuxes compiled for FP emulator the above octet order is used. If soft floats are used the usual little endian is used on doubles too. Not sure what the WinCE ABI does.

1 0

Re: [PATCH 2/3] wer: Add stubs for WerReportCreate + WerReportCloseHandle
by Alexandre Julliard Oct. 29, 2010

Oct. 29, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -2,6 +2,7 @@ MODULE = wer.dll > IMPORTLIB = wer > > C_SRCS = \ > - main.c > + main.c \ > + report.c I don't think we need multiple source files at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msxml3: Add error code definitions (resend)
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6586 Your paranoid android. === WVISTAADM (32 bit domdoc) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by Greg Geldorp Oct. 29, 2010

Oct. 29, 2010

Hi Chip, > From: Charles Davis > > On 10/27/10 8:43 PM, (Marvin) wrote: > > === WINEBUILD (build) === > > Failure running script in VM: Exceeded timeout limit of 300 sec > > Huh? I've never seen that happen before. I can't tell why my patch would > cause this. Ge? Your thoughts? Your patch contained a change to the configure script. Because of that, the bot rebuilt a lot of stuff. Rebuilding a lot of stuff takes time and caused the timeout limit to be exceeded. I've adjusted the build script to handle changes to configure better. Greg.

1 0

Re: [1/3] msxml3: Add a function to validate a tree against a schema cache (try 2)
by Nikolay Sivov Oct. 29, 2010

Oct. 29, 2010

On 10/29/2010 10:27, Adam Martinson wrote: > + #if LIBXML_VERSION>= 20621 > + xmlSchemaSetValidStructuredErrors(svctx, validate_serror, NULL); > + #endif I think a common and preferable way is to add configure define and check for presence of this call.

1 0

Re: advapi32: Implement EnumServicesStatusExA/W.
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6585 Your paranoid android. === WINEBUILD (build) === Performing reconfig in include dir Making build dependencies Making test executable Performing reconfig in include dir Making build dependencies Making test executable

1 0

Re: [PATCH] kernel32/tests: Fix the mixed-case short path test to actually test something.
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6579 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

1 0

Re: [1/4] msxml3/tests: Some encoding switching tests
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6578 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

2 1

Re: [PATCH 3/3] wer/tests: Add initial tests for WerReportCreate + WerReportCloseHandle
by testbot＠testbot.winehq.org Oct. 29, 2010

Oct. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6575 Your paranoid android. === WINEBUILD (build) === Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable

1 0

Re: [2/4] msxml3: add a function to validate a tree against a schema cache (resend)
by Alexandre Julliard Oct. 28, 2010

Oct. 28, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/schema.c | 75 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+), 0 deletions(-) This doesn't build on Leopard (libxml 2.6.16): ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm Undefined symbols: "_xmlSchemaSetValidStructuredErrors", referenced from: _SchemaCache_validate_tree in schema.o ld: symbol(s) not found -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: usp10/tests: update test_ScriptStringXtoCP_CPtoX to test both rtl and ltr characters
by testbot＠testbot.winehq.org Oct. 28, 2010

Oct. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6574 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

1 0

Sane.ds units
by Yaron Shahrabani Oct. 28, 2010

Oct. 28, 2010

Can someone please explain the units in the twain module (sane.ds)? There are: px - pixels b - ? (bytes) dpi - dots per inch mm - milimeters % - percent ns - ? (nanosecond) I will add comments to the file so it will be clearer for other translators, thanks! Yaron Shahrabani <Hebrew translator>

2 2

Re: (resend)[3/4]winegstreamer: add gstreamer mp3 transform filter
by Alexandre Julliard Oct. 28, 2010

Oct. 28, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/winegstreamer/gst_guids.h | 1 + > dlls/winegstreamer/gst_private.h | 1 + > dlls/winegstreamer/gsttffilter.c | 125 > ++++++++++++++++++++++++++++++++++++++ > dlls/winegstreamer/main.c | 35 +++++++++++ > 4 files changed, 162 insertions(+), 0 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M qedit.dll -T ../../.. -p qedit_test.exe.so ../../../../wine/dlls/qedit/tests/mediadet.c && touch mediadet.ok mediadet.c:151: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:162: Test failed: IMediaDet_get_StreamMediaType mediadet.c:214: Test failed: IMediaDet_get_StreamMediaType mediadet.c:222: Test failed: IMediaDet_get_FrameRate mediadet.c:223: Test failed: IMediaDet_get_FrameRate mediadet.c:238: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:243: Test failed: IMediaDet_get_OutputStreams mediadet.c:259: Test failed: IMediaDet_put_CurrentStream mediadet.c:264: Test failed: IMediaDet_get_CurrentStream mediadet.c:283: Test failed: IMediaDet_get_StreamMediaType mediadet.c:291: Test failed: IMediaDet_get_CurrentStream make: *** [mediadet.ok] Error 11 -- Alexandre Julliard julliard(a)winehq.org

1 0

WineAPI wiki progress
by Max TenEyck Woodbury Oct. 28, 2010

Oct. 28, 2010

The repository summary pages exist but in most cases are incomplete. These pages can serve as a map of the repository contents. There are categories for translations. The category indexes should provide complete lists of identifiable translations for each language. There are summaries of all .spec files with sortable tables. There is a top level index for the APIs with seperate indexes for each initial letter. These are in alphabetical order so it should be possible to determine if Wine knows about a particular API. Indexes for C++ name spaces are scheduled to the next phase of implementation. There is ONE API description page at this point. If any of you would care to look at it and send me comments, I will read them. I will be setting up analytic scripts for the individual API pages after the name space indexes are in place. Max

1 0

Re: ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel
by testbot＠testbot.winehq.org Oct. 28, 2010

Oct. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6564 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: ddraw [try 2]: Add tests for the foreground window set by SetCooperativeLevel
by Alexandre Julliard Oct. 28, 2010

Oct. 28, 2010

David Adam <david.adam.cnrs(a)gmail.com> writes: > + hwnd2=createwindow(); > + hwnd=createwindow(); > + > + if (hwnd) > + { > + skip("Failed to create the main window\n"); > + return; > + } I don't think that's quite what you intended... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] msxml3: fix XSLPattern namespace handling
by Alexandre Julliard Oct. 28, 2010

Oct. 28, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > #define U(str) BAD_CAST str > -#define DBG(str) wine_dbgstr_a((char const*)str) > +#define DBG(args...) wine_dbg_sprintf((char const*)args) > +#define RULE(name, args...) TRACE("Got "#name": %s\n", DBG(args)) Again, you can't use varargs macros. You have a tendency to abuse macros, please try to avoid them as much as possible. In this case, replacing a standard TRACE by a file-specific macro is not an improvement, even if it saves a little typing. People must be able to understand your code without having to look up a ton of obscure #defines. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: loader: On Mac, reserve the process's original thread for the frameworks.
by Ken Thomases Oct. 28, 2010

Oct. 28, 2010

On Oct 27, 2010, at 5:36 PM, Ken Thomases wrote: > > The frameworks expect the original thread to run its run loop, so input > sources (like distributed notifications) get processed. For example, > Core Audio on Snow Leopard doesn't track changes in the default ouput > device, such as when headphones are plugged in, without this. > --- > libs/wine/Makefile.in | 2 +- > libs/wine/loader.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 115 insertions(+), 1 deletions(-) > > > <0001-loader-On-Mac-reserve-the-process-s-original-thread-.patch> Hold off on this one. I've encountered a strange issue after sending it (that I didn't encounter in earlier testing). err:process:start_wineboot failed to start wineboot, err 1359 Apparently, there's a failure of an execve() system call in a child process. It's getting EFAULT. Artificially avoiding the very top of the available address space for the secondary thread stack works around the problem. Either the fork() alters the address space (perhaps as a consequence of eliminating all but one thread when creating the child from the parent), or execve() is sensitive to the specific layout. Perhaps it needs to use the very top of the address space, but won't if it thinks that's where the thread's stack is. Or something. -Ken

2 1

Re: About the Gallium Direct3D 10/11 work
by abraham vargas moreno Oct. 28, 2010

Oct. 28, 2010

galllund3 how long it takes to have dx 10 and 11 and ubuntu natively, all the world want to have a minimum release date for this wonderful work they are dealing with the DX.

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by Vitaliy Margolen Oct. 28, 2010

Oct. 28, 2010

On 10/27/2010 07:46 PM, Charles Davis wrote: > + sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); Could you please put some spaces after each coma everywhere in your patch? Please use snprintf(). > + GetShortPathNameA(buf,shortbuf,MAX_PATH); Use sizeof(buf) instead of MAX_PATH to guarantee that's what it means. > + hndl = CreateFileA(shortbuf,GENERIC_READ|GENERIC_WRITE,0,NULL,OPEN_EXISTING,0,NULL); > + ok(hndl!=INVALID_HANDLE_VALUE,"CreateFileA failed\n"); It's nice to know LastError and the full filename if it fails. > + for(i=0;i<MAX_PATH&& shortbuf[i];i++) You getting past the filename size in the buffer. > + shortbuf[i]=(rand() % 2) ? tolower(shortbuf[i]) : toupper(shortbuf[i]); Please don't use any sort of random stuff in tests. They should always be the same every time on every platform. > + /* Now try it on mixed case short names */ What's the point of the test anyway? You know that Wine already handles all files as case-insensitive. Short file name isn't any different. Vitaliy.

2 2

Re: [PATCH 1/3] configure: Check for the getattrlist() function and the <sys/attr.h> header (resend).
by Vitaliy Margolen Oct. 28, 2010

Oct. 28, 2010

On 10/27/2010 07:46 PM, Charles Davis wrote: > --- a/configure > +++ b/configure Please exclude changes to configure from your patches. AJ regenerates it himself. > @@ -1866,6 +1867,7 @@ AC_CHECK_FUNCS(\ > ftruncate \ > futimes \ > futimesat \ > + getattrlist \ > getdirentries \ > getopt_long \ > getpagesize \ Incorrect indentation - should be a tab, not 4 spaces. Vitaliy.

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by testbot＠testbot.winehq.org Oct. 28, 2010

Oct. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6562 Your paranoid android. === WINEBUILD (build) === Failure running script in VM: Exceeded timeout limit of 300 sec

2 1

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk Oct. 27, 2010

Oct. 27, 2010

Well, in practice, it's a detail that I don't expect to be very important, so it's probably not worth the trouble. Mostly I just want to elminiate the call fusion makes back into mscoree, since it is so blatantly wrong and causes the change I really want to break the tests. We could probably even get away with a hard-coded path, since our ngen.exe doesn't work anyway, and that's essentially what we're doing now given the semi-stub status of GetCORVersion. If/when we need to use the CLR version in fusion for something other than finding the precompiled assembly cache, this may become more important, but even then I don't think we'll need multiple simultaneous instances to work properly. We'll just need to know the correct version to use when only one instance is loaded. Multiple simultaneous runtimes is a case I'm thinking about and trying to account for, but I don't expect to ever see it used. If you prefer, I can add a test for fusion instead that compares the version we get out of GetCachePath(ASM_CACHE_ZAP) to the one we pass to LoadLibraryShim, in cases where more than one runtime is installed, assuming only one instance will be loaded at once. I can fix that without any changes to the loader, but it will mean adding a wine-specific export to fusion. OR mscoree could lie about which .NET versions are installed when Mono isn't available, until there's a real need to load Mono. -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, October 27, 2010 2:15 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > There is another minor problem highlighted by this test, which is that > I can make up any path and end up with a loaded dll, as long as > there's a builtin dll filename at the end. That's a feature, the idea is that builtin dlls are independent from the actual dll files. That's also why asking for the path name of a builtin doesn't make sense. This could conceivably be changed now that we have the fake dlls mechanism, but it would be a pretty fundamental redesign. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk Oct. 27, 2010

Oct. 27, 2010

Well, I don't think we can do it properly without having multiple instances of a builtin dll. I believe that native fusion.dll is different for each .NET version, and it probably has the version number baked in. If we can't have multiple instances of a builtin dll, I still believe testing the path is the best way to determine which version was given to LoadLibraryShim, if that's possible. If testing the path is not possible, we can have LoadLibraryShim use a wine-specific exported function to inform fusion.dll of the version, but this approach won't work if someone loads fusion.dll directly from a .NET system directory. There is another minor problem highlighted by this test, which is that I can make up any path and end up with a loaded dll, as long as there's a builtin dll filename at the end. -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, October 27, 2010 1:31 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 4)
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat() calls in the fast path, as well as some unnecessary changes. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [3/3] mscoree: Implement LoadLibraryShim.
by testbot＠testbot.winehq.org Oct. 27, 2010

Oct. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6541 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)
by Charles Davis Oct. 27, 2010

Oct. 27, 2010

Any concerns? I've gone over this patch, and I don't see anything major. If it will make you feel any better, I just ran the tests under a WoW64 environment on Linux, and they passed. Chip

2 2

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by testbot＠testbot.winehq.org Oct. 27, 2010

Oct. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6540 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if (access & GENERIC_READ) access |= FILE_GENERIC_READ; > + /* FIXME: we add FILE_READ_PROPERTIES access even in write-only mode. > + * As tested on Windows, this is not correct (ie GetConsoleMode() on with GENERIC_WRITE only > + * access fails). > + * But, this is currently needed as part of kernel32/console.c client side code relies on the > + * fact that it can read properties: lots of 'set' functions like WriteConsole, > + * ScrollConsoleScreenBuffer, SetConsoleCursorPosition (and many others) do call 'get' > + * functions. > + */ These should be fixed then. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdi32: Make AddFontToList skip adding a face into global lists if the font is not supposed to be enumerated, and return a pointer to first loaded face.
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1207,15 +1207,17 @@ static void AddFaceToFamily(Face *face, Family *family) > > #define ADDFONT_EXTERNAL_FONT 0x01 > #define ADDFONT_FORCE_BITMAP 0x02 > -static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, char *fake_family, const WCHAR *target_family, DWORD flags) > +#define ADDFONT_HIDDEN 0x04 > +static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, > + char *fake_family, const WCHAR *target_family, DWORD flags, Face **face_to_return) The face_to_return pointer doesn't seem to be used anywhere. If it's really needed for something else it should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: First contact
by Dan Kegel Oct. 26, 2010

Oct. 26, 2010

On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET <andreas.livet at gmail.com> wrote: > For the patch, I think I understand the concept (I never use git before and > never apply a patch), I have to selection the diff text and save it into a > file (let's say debug.patch) Copy and paste sometimes screws up patches. Better to save the patch to a file some other way. In particular, I usually use wget. For the patch you mentioned, one command to fetch the patch is wget http://repo.or.cz/w/wine/hacks.git/patch/2daf55e8eeca89d5c2bb82381151277b6f… http://marc.info/?l=wine-patches is another good place to search for uncommitted patches; that site does a good job of saving the patches as hyperlinks you can use with wget. See also http://kegel.com/academy/opensource.html and http://kegel.com/wine/qa/ for a few tips. Welcome aboard. I hope you have more than 1 hour / week, it takes a while to come up the learning curve. - Dan

1 0

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

David Adam <david.adam.cnrs(a)gmail.com> writes: > @@ -33,8 +33,9 @@ static LPDIRECTDRAW lpDD = NULL; > static LPDIRECTDRAWSURFACE lpDDSPrimary = NULL; > static LPDIRECTDRAWSURFACE lpDDSBack = NULL; > static WNDCLASS wc; > -static HWND hwnd; > +static HWND hwnd, hwnd2; > static int modes_cnt; > +static BOOL success; That boolean make much sense, especially with this name. If you want to check that you have a valid window you should test the window handle. Same with your createwindow function, it should simply return the handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msxml3: libxml2 error/warning callback functions (try 2)
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > + len = vsnprintf(NULL, 0, msg, ap); > + buf = heap_alloc(len+1); > + vsnprintf(buf, len+1, msg, ap); vsnprintf can also return -1, check how this is done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > + ERR("++++++++++++++++ perform byte seek ------------------\n"); You still have a ton of such debug ERRs in there. > + *buf = NULL; > + TRACE("Requesting %llu %u\n", ofs, len); Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32: Export recent wer functions
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1156,7 +1156,20 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stub WerGetFlags > @ stdcall WerRegisterFile(wstr long long) > +@ stub WerRegisterMemoryBlock > +@ stub WerRegisterRuntimeExceptionModule > +@ stub WerSetFlags > +@ stub WerUnregisterFile > +@ stub WerUnregisterMemoryBlock > +@ stub WerUnregisterRuntimeExceptionModule > +@ stub WerpCleanupMessageMapping > +@ stub WerpInitiateRemoteRecovery > +@ stub WerpNotifyLoadStringResource > +@ stub WerpNotifyLoadStringResourceEx > +@ stub WerpNotifyUseStringResource > +@ stub WerpStringLookup Adding stubs is not a good idea. If you have an app that calls these you need to provide a proper stub function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wer/tests: Add initial tests
by testbot＠testbot.winehq.org Oct. 26, 2010

Oct. 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: comdlg32: Added Hebrew translation.
by Yaron Shahrabani Oct. 26, 2010

Oct. 26, 2010

What is wrong with the patch? Yaron Shahrabani <Hebrew translator> 2010/10/23 Yaron Shahrabani <sh.yaron(a)gmail.com> > Verified by Paul Vriens >

2 1

ddraw: Add tests for the foreground window set by SetCooperativeLevel
by David Adam Oct. 26, 2010

Oct. 26, 2010

Any problems with patch? A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2010/10/24 Subject: ddraw: Add tests for the foreground window set by SetCooperativeLevel To: wine-patches <wine-patches(a)winehq.org>

2 2

comdlg32/cdlg: removed 16 bit dependency
by CJ Oct. 26, 2010

Oct. 26, 2010

Removed wownt32.h from the includes of cdlg32.h and modified fontdlg.c so that it no longer relies on the 16 bit dependency. -- Carl J. Raffaele

2 1

Re: msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()
by Jacek Caban Oct. 25, 2010

Oct. 25, 2010

On 10/25/10 10:38 PM, Nikolay Sivov wrote: > Should help with http://bugs.winehq.org/show_bug.cgi?id=22607 > > > + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = SysAllocString(data); - hr = node_put_value(node_obj,&v_data); Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here? Jacek

2 1

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Vitaliy Margolen Oct. 25, 2010

Oct. 25, 2010

On 10/25/2010 07:45 AM, Aric Stewart wrote: > --- > + ERR("++++++++++++++++ perform byte seek ------------------\n"); > + if (1 || This->initial) { > + ERR("Relinked\n"); > + FIXME("Seeking %i %i\n", format, GST_FORMAT_BYTES); > + FIXME("using \"%s\"\n", name); Some debug leftovers? > + AM_MEDIA_TYPE amt = { }; > .. > + ZeroMemory(&amt, sizeof(amt)); This is redundant. > sizeof(piOutput.achName) / sizeof(*piOutput.achName) The more common construct in Wine is sizeof(array)/sizeof(array[0]). IMHO it's better to stick with one Also could you please put an empty line in each function after variable declarations? Your patches look inconsistent. Vitaliy.

2 1

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation. Take 2.
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch makes sure that "Shell_TrayWnd" window doesn't have a caption > since some apps depend on it being empty. The bug #20129 lists one of such > applications. It does FindWindow("Shell_TrayWnd", "") and expects that it > returns a valid tray window handle. This looks ugly when moving the window. The real systray should most likely be kept off-screen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > server/console.c | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) It's not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so console.c && touch console.ok console.c:789: Test failed: Shouldn't succeed console.c:790: Test failed: GetLastError: expecting 6 got 0 make: *** [console.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: added one missing buffersize check in URLCache_CopyEntry (Coverity)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > CID 831, indirectly spotted by Coverity, one missing > check for (*lpdwBufferSize >= dwRequiredSize) added. It doesn't work: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so urlcache.c && touch urlcache.ok urlcache.c:219: Test failed: RetrieveUrlCacheEntryFile failed with error 122 wine: Unhandled page fault on read access to 0x00000000 at address 0x6820cb08 (thread 0028), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [Kernel32]: don't force winedbg startup when no AeDebug key is present (#24524)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > - cmdline = HeapAlloc(GetProcessHeap(), 0, 80); > - snprintf(cmdline, 80, "winedbg --auto %ld %ld", /* as in tools/wine.inf */ > - (long)GetCurrentProcessId(), (long)HandleToLong(hEvent)); > + /* no AeDebug key present, just kill the program */ > + return FALSE; This means you don't get a backtrace if there's a crash before the initial registry creation is complete. I don't think that's a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] [Msvcrt]: put in place the full scheme for paramter validation (the _s family of functions)
by Piotr Caban Oct. 24, 2010

Oct. 24, 2010

Hi, Only debugging version of the dll is passing data to invalid_paramter_handler. I guess it's why we shouldn't do it. There already is a test for it in msvcr90 (see strtoi64 tests). Because it was not strict enough it will not show it very well. Currently it will not show that it was expecting invalid_parameter_handler to be invoked (but will fail checking errno that should not be changed). Of course this behavior may vary between msvcrXX dlls, I have tested it only with msvcr90 and msvcrt on Windows XP. Cheers, Piotr

1 0

Re: [3/4] ddraw: fix DDSCAPS_3DDEVICE surfaces always setting DDSCAPS_VISIBLE
by testbot＠testbot.winehq.org Oct. 24, 2010

Oct. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6460 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [2/4] ddraw/tests: test some more caps combinations
by testbot＠testbot.winehq.org Oct. 24, 2010

Oct. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6459 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

re: disabling FORTIFY_SOURCE
by Dan Kegel Oct. 24, 2010

Oct. 24, 2010

Hi Kees, sure, supporting Fortify in Wine would be great, but it's not clear how long it will take to fix Wine so it works with Fortify. Which would you prefer: 1) have Wine broken for an unknown and possibly long time or 2) have Wine working, but without Fortify, until the bugs are fixed ?

5 6

Test for window messages of a property sheet with custom dialog proc (bug 12104)
by Bernhard Übelacker Oct. 24, 2010

Oct. 24, 2010

Hello, the attached patch consists of a test case for following bug: http://bugs.winehq.org/show_bug.cgi?id=12104 This test shows how cygwin's setup checks if a WM_SIZE message was received (by the custom window proc). In wine only the property page gets such a message - not the sheet. If I got it right, tests which would fail in wine are prefixed with todo_wine? I want to ask if this patch looks right for inclusion and if the location (dlls/comctl32/tests/) is right? Kind regards, Bernhard

2 1

missing tests in test.winehq.org
by paulo lesgaz Oct. 24, 2010

Oct. 24, 2010

Hello, looking at http://test.winehq.org, i remarked that the file ddraw/tests/ddrawmodes does not exist and so it is never tested. Does anyone have an explanation for this fact? A+ David

3 4

disabling FORTIFY_SOURCE
by Kees Cook Oct. 24, 2010

Oct. 24, 2010

Hi, It seems to me that disabling FORTIFY_SOURCE is a mistake. It offers a great many protections, and virtually every distribution has very intentionally turned on this compiler flag by default. Given Wine's size[1], I would argue the benefits[2] outweigh the hassle of rearranging the structures and accessors to not trick the compiler into allocating memory beyond the end of the structure for incoming strings. It has found, at least in other projects, a lot of potential problems, and better yet, has repeatedly turned exploitable vulnerabilities into simple denial of services. I realize it's a bit of a pain to work with given how you're building some of the structures, but I'd like to ask that it not be globally disabled. Thanks, -Kees [1] $ find . -type f -name '*.[ch]' | xargs wc -l | grep total 2678911 total [2] Some details at https://wiki.ubuntu.com/CompilerFlags#-D_FORTIFY_SOURCE=2 but at least the following... Compile time: - static buffer length checks - missed return values - open() checks for missing mode when used with O_CREAT Run time: - dynamic buffer length checks - dynamic format string safety check - dynamic format position safety checks Functions with buffer length (or other) checks: asprintf confstr dprintf fgets fgetws fprintf fread fwprintf getcwd getdomainname getgroups gethostname getlogin_r gets getwd longjmp mbsnrtowcs mbsrtowcs mbstowcs memcpy memmove mempcpy memset pread64 pread printf ptsname_r read readlinkat readlink realpath recv recvfrom snprintf sprintf stpcpy stpncpy strcat strcpy strncat strncpy swprintf syslog ttyname_r vasprintf vdprintf vfprintf vfwprintf vprintf vsnprintf vsprintf vswprintf vsyslog vwprintf wcpcpy wcpncpy wcrtomb wcscat wcscpy wcsncat wcsncpy wcsnrtombs wcsrtombs wcstombs wctomb wmemcpy wmemmove wmempcpy wmemset wprintf -- Kees Cook Ubuntu Security Team

2 1

new
by Michael Sgier Oct. 24, 2010

Oct. 24, 2010

HiI'm new to this but know that MS Flight Simulator would one need little tweak to run flight school etc. (already worked once)So I've downloaded git and would be thankful for hints on how to proceed and find those bugs in FS9. I also would prefer using Eclipse/Linux, but anyway thanks for help.Many thanksMichael

2 2

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by testbot＠testbot.winehq.org Oct. 24, 2010

Oct. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6448 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Between IGF Demo is Unresponsive (Steam Client and Wine 1.3.2)
by Singapore Citizen Mr. Teo En Ming 张恩鸣 Oct. 24, 2010

Oct. 24, 2010

Dear All, When I click on the Play button for Between IGF Demo in Steam client, a window pops up and hangs there. Nothing is displayed in the popped up window. It just hangs there. Anybody know what happens? Please refer to screenshot. [1] http://imgur.com/3Mky4.png [2] http://i55.tinypic.com/dxz6nq.png [3] http://img218.imageshack.us/img218/4595/aa3steamclientwine132.png [4] http://img2.uploadhouse.com/fileuploads/6751/67514722a40f9a6544b45081e58dd0… Please assist in troubleshooting the problem. Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

Alien Swarm Does Not Launch (Steam Client and Wine 1.3.2)
by Singapore Citizen Mr. Teo En Ming 张恩鸣 Oct. 24, 2010

Oct. 24, 2010

Dear All, When I try to click the Play button for Alien Swarm in the Steam client, the game does not launch at all. Do you know what happens? Please assist in troubleshooting the problem. Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

America's Army 3 (AA3Game.exe) Crashes with Steam Client and Wine 1.3.2
by Singapore Citizen Mr. Teo En Ming 张恩鸣 Oct. 24, 2010

Oct. 24, 2010

Dear All, Please refer to attached screenshot of America's Army 3 Program Error. [1] http://imgur.com/3Mky4.png [2] http://i55.tinypic.com/dxz6nq.png [3] http://img218.imageshack.us/img218/4595/aa3steamclientwine132.png [4] http://img2.uploadhouse.com/fileuploads/6751/67514722a40f9a6544b45081e58dd0… Please assist in troubleshooting the problem. I have set the Default Settings in Application Settings in winecfg to "Windows 7". Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

Re: [PATCH 7/7] configure: disable fortify the right way
by Alexandre Julliard Oct. 23, 2010

Oct. 23, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work. > > Also just -U the define. Won't this break if the default is set through a header? Do all distros do this only through CFLAGS? -- Alexandre Julliard julliard(a)winehq.org

3 3

Font config in Desktop Integration broken when switching locales
by cheer_xiao Oct. 23, 2010

Oct. 23, 2010

---------- Forwarded message ---------- From: cheer_xiao <xiaqqaix(a)gmail.com> Date: Fri, Oct 22, 2010 at 5:06 PM Subject: Font config in Desktop Integration broken when switching locales To: wine-users(a)winehq.org As a translator, It is frequent for me to switch between locales (en_US.utf8 and zh_CN.utf8 for me), but the font configurations in winecfg/'Desktop Integration' gets broken under certain circumstances. To demonstrate, I run winecfg with LANG=zh_CN.utf8, and set the 'Menu Text' (菜单文字) font to 'WenQuanYi Zen Hei Sharp' (文泉驿点阵正黑) 10pt (shot00.png). It turns out fine (shot01.png), but with LANG=en_US.utf8 the menu text font is a mess (shot02.png). The configuration under zh_CN.utf8 fails to work under en_US.utf8. However, if I run winecfg with LANG=en_US.utf8, and redo the setting (shot10.png, shot11.png), the configuration works under both locales (shot12.png, shot13.png). The configuration made under en_US.utf8 is more "portable". An interesting phonomenum is that in shot10.png, the font configuration seems to have been "reset", ie. it is the font on the top of the list, with the minimum size. This also happens when you configure the font (menu text font here) for the very first time so it must be some kind of default value. The configuration under zh_CN.utf8 was not recognized by winecfg under en_US.utf8, thus falling back to the default. However, during font rendering such fallbacks are not functioning properly (the fallback itself shouldn't be happening though), resulting in the boxes in shot02.png. I guess this issue is due to a bug of how winecfg saves the font configurations and/or how these configurations are used during font rendering. Could anyone explain and/or fix this? I have been looking up the registry but the configurations appear to be stored somewhere else. BTW: Another problem is also observed. Every time I run wine programs (like winecfg, notepad) with LANG=zh_CN.utf8 I get lots of: fixme:msvcrt:_setmbcp trail bytes data not available for DBCS codepage 0 - assuming all bytes I run Wine compiled from the git repo (just a day or two ago) on Ubuntu 10.10. Default locale is en_US.utf8.

1 0

winegstreamer error with 'make install'
by Paul Vriens Oct. 22, 2010

Oct. 22, 2010

Hi, Current Git (Fedora 13) gives me: /usr/bin/install -c winegstreamer.so /usr/local/lib64/wine/winegstreamer.so /usr/bin/install: cannot stat `winegstreamer.so': No such file or directory There is a winegstreamer.dll.so in this directory. Anyone? -- Cheers, Paul.

2 2

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation. Take 2.
by testbot＠testbot.winehq.org Oct. 22, 2010

Oct. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6432 Your paranoid android. === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [3/3] msxml3: implement domdoc schema validation
by Nikolay Sivov Oct. 22, 2010

Oct. 22, 2010

On 10/22/2010 01:27, Adam Martinson wrote: > --- > dlls/msxml3/domdoc.c | 127 > ++++++++++++++++++++++++++++++++------------ > dlls/msxml3/tests/domdoc.c | 4 +- > 2 files changed, 94 insertions(+), 37 deletions(-) > + TRACE("doc not well-formed, returning error 0xC00CE223\n"); > if (err) > - *err = create_parseError(0, NULL, NULL, NULL, 0, 0, 0); > + *err = create_parseError(0xC00CE223, NULL, NULL, NULL, 0, 0, 0); You should add corresponding error code defines for that. This one is E_XML_NOTWF.

1 0

Re: [1/3] msxml3: libxml2 error/warning callback functions
by Alexandre Julliard Oct. 22, 2010

Oct. 22, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define LIBXML2_OUTPUT_CALLBACK void __WINE_PRINTF_ATTR(2,3) > +#define LIBXML2_OUTPUT_CALLBACK_BODY(caller, dbcl, msg) \ > + do { \ > + va_list ap; \ > + char* buf; \ > + int len; \ > + va_start(ap, msg); \ > + len = vsnprintf(NULL, 0, msg, ap); \ > + buf = heap_alloc(len+1); \ > + vsnprintf(buf, len+1, msg, ap); \ > + va_end(ap); \ > + wine_dbg_log(__WINE_DBCL##dbcl, __wine_dbch___default, #caller, buf); \ > + heap_free(buf); \ > + } while (0) > + > +#define LIBXML2_XMLERROR_CALLBACK void > +#define LIBXML2_XMLERROR_CALLBACK_BODY(caller, err) \ > + do { \ > + enum __wine_debug_class dbcl = __WINE_DBCL_ERR; \ > + switch (err->level) \ > + { \ > + case XML_ERR_NONE: \ > + dbcl = __WINE_DBCL_TRACE; \ > + break; \ > + case XML_ERR_WARNING: \ > + dbcl = __WINE_DBCL_WARN; \ > + break; \ > + default: \ > + break; \ > + } \ > + wine_dbg_log(dbcl, __wine_dbch___default, #caller, err->message); \ > + } while (0) That's ugly, please write the code explicitly instead of using macros, it's not that much code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: Invitation: Apply to be a Mentoring Organization for GCI
by Dan Kegel Oct. 22, 2010

Oct. 22, 2010

This looks interesting... ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Oct 18, 2010 at 3:10 PM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, Starting today we are accepting applications from organizations who have participated in a previous Google Summer of Code (you!) to get involved with our contest for 13-18 year olds, Google Code-in [0]. If you haven’t read up about Google Code-in, you can check out our announcement [1] to this list from a couple weeks ago or read our blog post [2] about the contest. If your org has decided it would like to apply to participate in the contest, you can fill out the application [3] on Melange now. The deadline for applications is 29 October at 23:00 UTC. Also, if you want to look over the rules for the contest before applying to participate they can be found on the organization application [3] at the bottom. They will also be posted on the Google Code-in website [0] in the next couple days in other languages. We hope your org will consider participating. [0] - http://code.google.com/gci [1] - http://groups.google.com/group/google-summer-of-code-mentors-list/msg/0985e… [2] - http://google-opensource.blogspot.com/2010/10/google-code-in-schools-out-co… [3] - http://socghop.appspot.com/gci/org_app/take/gci_program/google/gci2010/orga… Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en.

1 0

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation.
by Alexandre Julliard Oct. 22, 2010

Oct. 22, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch makes sure that "Shell_TrayWnd" window doesn't have a caption > since some apps depend on it being empty. The bug #20129 lists one of such > applications. It does FindWindow("Shell_TrayWnd", "") and expects that it > returns a valid tray window handle. It can't work the way you are doing it, FindWindow won't find a child window. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by TranslateBitmapBits
by Hans Leidekker Oct. 22, 2010

Oct. 22, 2010

On Thu, 2010-10-21 at 17:52 +0200, Tomasz Michno wrote: Please mark your patches with something like (try X) and comment on the changes you made in the same e-mail. Use (resend) when you resend a patch without making any changes. > +/* defines copied from lcms.h: > + */ > +#define INTENT_PERCEPTUAL 0 > +#define INTENT_RELATIVE_COLORIMETRIC 1 > +#define INTENT_SATURATION 2 > +#define INTENT_ABSOLUTE_COLORIMETRIC 3 These should be added to icm.h. I'll send a patch. > + ret=pTranslateBitmapBits(transform, (void*)bitmapBits, > + ok( ret, "BGR: TranslateBitmapBits() succeeded (%d)\n", There's no need to cast to void *. The sense of that error message is wrong. It's displayed when the condition evaluates to false, so it should be 'failed'. And it happens to fail on Windows: transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87)

1 0