October 2010 - Wine-Devel - list.winehq.org

Re: ddraw [patch 2/2 | RESEND]: SETFOCUSWINDOW lives independently of other flags
by testbot＠testbot.winehq.org Oct. 22, 2010

Oct. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6427 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: ddraw [patch 2/2]: SETFOCUSWINDOW lives independently of other flags
by testbot＠testbot.winehq.org Oct. 21, 2010

Oct. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6424 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: (resend) [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by Translat
by testbot＠testbot.winehq.org Oct. 21, 2010

Oct. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6423 Your paranoid android. === W98SE (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2KPROSP4 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === WXPPROSP3 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2K3R2SESP2 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === WVISTAADM (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2K8SE (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PRO (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PROX64 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PROX64 (64 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87)

1 0

Re: ddraw [patch 1/2]: Remove a useless else
by Henri Verbeet Oct. 21, 2010

Oct. 21, 2010

On 21 October 2010 22:28, David Adam <david.adam.cnrs(a)gmail.com> wrote: > Trailing spaces.

1 0

Reflection interfaces
by Rico Schüller Oct. 21, 2010

Oct. 21, 2010

Hi, I've a question concerning d3dcompiler, d3d10 and d3dx10 dlls in combination with the shader reflection interfaces. It seems there are 4 different known interfaces: IID_ID3D10ShaderReflection -> d3d10.dll (D3D10ReflectShader()) IID_ID3D10ShaderReflection1 -> d3dx10_xx.dll (D3DX10ReflectShader()) IID_ID3D11ShaderReflection_42 -> d3dcompiler_(40-42).dll (D3DReflect()) IID_ID3D11ShaderReflection -> d3dcompiler_(43).dll (D3DReflect()) The IID_ID3D11ShaderReflection_42 is just a new name for a IID_ID3D11ShaderReflection interface for version 40-42. In d3dcompiler 43 the interface changed and now has a new IID. What's the preferred way to implement the different interfaces? 1. Implement a parser which parses the shader (RDEF, STAT), and implement 4 independent interfaces (each in its own dll). Only reuse the parser. 2. Like 1, but all 4 implementations have there own parser, which leads to a lot of duplicated code. But it is the most flexible way. It could easily parse all possible shader blobs (theoretically they could differ from version to version, I have no test for that, yet). 3. Forward all interfaces to d3dcompiler_43.dll and this will contain all interfaces and the parser. This way the codebase is the smallest possible one, but it will offer all interfaces, which isn't what native does. Also all further interfaces would go to d3dcompiler_43.dll. This could get tricky. Attached is a test program and the output. The programm is compiled with "i686-pc-mingw32-gcc -I./wine/build/include -I./wine/git/include compilertest.c". The test for D3DReflectCode() doesn't work, so please ignore that part. Cheers Rico

2 2

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by TranslateBitmapBits
by Hans Leidekker Oct. 21, 2010

Oct. 21, 2010

On Wed, 2010-10-20 at 12:45 +0200, Tomasz Michno wrote: > C_SRCS = \ > - profile.c > + profile.c \ > + transform.c You are copying quite a bit a infrastructure from profile.c, so it would be better to add the tests to that file. We can always split them up later. > +#include "mscms_priv.h" This is not needed. > +void test_TranslateBitmapBits(void){ > + BOOL ret=TRUE; > + COLOR bitmapBits[bitmapSize]; > + COLOR bitmapBitsResult[bitmapSize]; > + #ifdef HAVE_LCMS You can't use that define in tests. > + HPROFILE hProfile; > ... > + transform = pCreateMultiProfileTransform(&hProfile, 2, &intent, 1, > + // test already handled BMFORMATs: This won't work, you say you have 2 profiles but pass only one. Don't use // for comments.

2 1

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.
by Rolf Kalbermatter Oct. 21, 2010

Oct. 21, 2010

On Tue, Oct 13, 2010 at 16:30 PM, Erich Hoover <ehoover(a)mines.edu> wrote: >> ... >> + int newsize = (int)*maxsize; >> + >> + /* Make sure there is at least enough room for this entry */ >> + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); >> + if (newsize < 0) >> + return 0; >> + *maxsize = (ULONG)newsize; >> Just declare it as a ULONG/size_t so you don't have to cast. > >I can obviously change this around a little bit, but the reason for this conversion is that as a >ULONG the "if (newsize < 0)" comparison is not going to work. Then following code would work better: ULONG newsize = sizeof(WSACMSGHDR) + CMSG_ALIGN(len); /* Make sure there is at least enough room for this entry */ if (newsize > *maxsize) return 0; /* else */ *maxsize -= newsize; Rolf Kalbermatter

3 5

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 21, 2010

Oct. 21, 2010

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Re: About: d3dx9: Store transform matrix per-sprite.
by Joris Huizer Oct. 20, 2010

Oct. 20, 2010

--- On Tue, 10/19/10, Austin English <austinenglish(a)gmail.com> wrote: > While these emails are very helpful, can you please do a > reply to the > original thread? It makes it easier for those of us using > clients with > threaded mode to follow. > > Thanks! > > -- > -Austin > I can understand that's easier, less messy - I didn't do so up until now as it is quite a number of emails per day (especially if tracking both wine-devel and wine-patch) -- and my contributions/'contributions' are rare; Is there a way to do this other than registering to get the emails daily sent to me? I usually browse through the updates via the web (the mail archive and the patch watcher at http://source.winehq.org/patches/) and as far as I know there is no way of replying on either ? I think I will register to receive emails from the wine-devel and wine-patch mailing lists unless there's an other way to reply to thread. Best regards, Joris

2 1

Re: Translation of the AppDB
by James Mckenzie Oct. 20, 2010

Oct. 20, 2010

Yaron Shahrabani <sh.yaron(a)gmail.com> wrote: > >On Wed, Oct 20, 2010 at 6:48 AM, James McKenzie ><jjmckenzie51(a)earthlink.net>wrote: > [snip] >So you mean you have got to get some input and there's no other way of >getting input from the users without typing... >Do you feel like you get enough feedback or that automating parts of the >reporting system would make it more widely used. >I'm maintaining lots of translations in the open source world, I never feel >like I get enough feedback and I truly think that if the input was at the >user's fingertips it would help a lot, just my way of looking at it... > Correct. There is quite a wide variation of what can and cannot work that having a bunch of selections would be tedious at best, confusing at worst. >> >> There are many 'drop down' menus that it would be nice to input Hebrew and >> have English populate them. Would this be a good idea? >> >The drop down boxes would be great, the simplest way of interaction is what >needed, no ways of typing Hebrew... > Again, the existing drop downs could be translated into Hebrew and then used to select the English equivilent. However, the text boxes will have to remain due to wide variations in 'What works' and 'What does not work'. Too many selections can be confusing and makes the web site appear to be slow (I work with a web application that has 35,000+ selections, it takes about two minutes for the menu to load on a high speed connection and not all Wine users have that luxury.) >(I was thinking of a small Javascript code that will check for foreign >scripts and if the script is different than the Latin script, a Red message >will appear on top of the box and after clicking the button a message will >pop up saying that this message contains non-universal characters and ask >the user if he is sure about sending this report). > I would just block it. Again, English, for now, is the world's universal language. If someone does not know English, there are sites like Babblefish that cover just about all languages, including (but not limited to) Hebrew, Farsi, Persian, Arabic, Simplified and Traditional Chinese. Users can avail themselves of them and copy/paste into the boxes. I can understand quite a bit of 'translated' English. James McKenzie

2 1

Re: [1/2] msvcrt: Implement _mbsnbcat_s.
by Piotr Caban Oct. 20, 2010

Oct. 20, 2010

Hi, On 10/20/10 08:49, Andrew Nguyen wrote: + * a lead byte and move the pointer back by one for later overwrite. */ + if (get_locale()->locinfo->mb_cur_max > 1 && MSVCRT_isleadbyte(*(ptr - 1))) + size++, ptr--; You may access dst-1. + ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", ret); Printing ret here may be misleading. Cheers, Piotr

1 0

Re: [3/4]strmbase: implement OLE registration in AMovieDllRegisterServer2
by Alexandre Julliard Oct. 20, 2010

Oct. 20, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > HRESULT WINAPI AMovieDllRegisterServer2(BOOL bRegister) > { > HRESULT hr; > int i; > IFilterMapper2 *pIFM2 = NULL; > + HMODULE psapi; > + fnGetModuleFileNameExW pFunc; > + WCHAR szFileName[MAX_PATH]; > + > + psapi = LoadLibraryA("psapi.dll"); > + if (psapi) > + { > + pFunc = (fnGetModuleFileNameExW)GetProcAddress(psapi, "GetModuleFileNameExW"); > + if (pFunc) > + { > + if (!pFunc(GetCurrentProcess(), g_hInst, szFileName, MAX_PATH)) > + { > + ERR("Failed to get module file name for registration\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to get get function GetModuleFileNameExW\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to load psapi.dll\n"); > + return E_FAIL; > + } > + FreeLibrary(psapi); There's no reason to use psapi for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32/tests: Better reflect the naming scheme
by Alexandre Julliard Oct. 20, 2010

Oct. 20, 2010

André Hentschel <webmaster(a)dawncrow.de> writes: > @@ -10,7 +10,7 @@ C_SRCS = \ > typelib.c \ > usrmarshal.c \ > varformat.c \ > - vartest.c \ > + variant.c \ > vartype.c Renaming tests should be avoided, it makes it hard to follow the history on test.winehq.org. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msxml3/tests: internal schema doc storage tests (resend)
by Alexandre Julliard Oct. 20, 2010

Oct. 20, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define _create(cls) cls, #cls > + > +#define _obj(cls, ...) &_create(cls ## __VA_ARGS__) You can't do that, varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Translation of the AppDB
by Yaron Shahrabani Oct. 20, 2010

Oct. 20, 2010

Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. Kind regards, Yaron Shahrabani <Hebrew translator>

4 6

Re: msxml3/domdoc: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org Oct. 20, 2010

Oct. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6343 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
by Vincent Povirk Oct. 20, 2010

Oct. 20, 2010

+1 + if (!prc) + { + UINT width, height; + hr = IWICBitmapSource_GetSize(This->source, &width, &height); + if (FAILED(hr)) return hr; + rc.X = 0; + rc.Y = 0; + rc.Width = width; + rc.Height = height; + prc = &rc; + } Any reason you didn't use this approach in the other functions?

5 6

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
by Alexandre Julliard Oct. 19, 2010

Oct. 19, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/tests/schema.c | 438 > +++++++++++++++++++++++++++++++++----------- > 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
by Hans Leidekker Oct. 19, 2010

Oct. 19, 2010

On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote: > +/* unfortunately GetProcAddress cannot return proper pointer to > from_bmformat() function, but for this function it's not a problem, > using copy from ../transform.c */ That's not how it's done in Wine, you will need to go through the API. In this case that means you need to define a bitmap in the appropriate format, create a color transform and then call TranslateBitmapBits. Note that Wine doesn't bundle a color profile, so you need to install one, or configure your X server to use one and retrieve it via GetICMProfile.

2 2

Re: [1/2] windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle (try 2).
by Alexandre Julliard Oct. 19, 2010

Oct. 19, 2010

Krzysztof Nowicki <krissn(a)op.pl> writes: > I've decided to keep the optimisation in copy_pixels() that checks if the source > and dest rectangles + strides matches and if yes, does a straight memcpy of the > whole bitmap. Please do this as a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Surprise surprise, "Tmax Window OS" was a complete hoax
by James Mckenzie Oct. 19, 2010

Oct. 19, 2010

Scott Ritchie <scott(a)open-vote.org> wrote: > >About a year or so ago a Korean company called Tmax was claiming to have >developed a new operating system that was 100% fully Windows compatible. > They also claimed to have their own office suite, web browser, and >more, all developed with their own special Korean engineering to keep >the license proprietary. > And they would be 'busted' anyway as Korea is one of the signaturs to the World Digital Copyright agreement. Thanks for seeing them for what they were: False. James McKenzie

1 0

About: d3dx9: Store transform matrix per-sprite.
by Joris Huizer Oct. 19, 2010

Oct. 19, 2010

Hello, In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like: int i, count, start; /* ... */ for(start=0;start<This->sprite_count;start+=count,count=0) { i=start; while(i<This->sprite_count && (count==0 || This->sprites[i].texture==This->sprites[i-1].texture)) { /* filling in array */ } /* rest of the outer loop, using array and count */ } It seems count is used uninitialised here on the first iteration ? HTH, Joris

2 1

Re: [PATCH 3/3] jscript: Add index, input and lastIndex properties to regexp funtions results
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6322 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: user32: FindWindow() should treat an empty title same way as NULL. (Resend)
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6315 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Surprise surprise, "Tmax Window OS" was a complete hoax
by Scott Ritchie Oct. 19, 2010

Oct. 19, 2010

About a year or so ago a Korean company called Tmax was claiming to have developed a new operating system that was 100% fully Windows compatible. They also claimed to have their own office suite, web browser, and more, all developed with their own special Korean engineering to keep the license proprietary. This lead some here to justifiably worry that they were using Wine code without permission, as well as dozens of other free software projects. At the time I called it an obvious fraud. Anyway I check backed in on it and, no surprise, Tmax Soft has disavowed all knowledge of the project -- the website is dead, no news about it has appeared since the "launch", and although there are several quicksearches on their main website for the product they return no results. Fortunately, with the exception of a few particularly bad tech journalists, no one seems to have been actually fooled. -Scott Ritchie

1 0

Re: [PATCH 6/8] jscript: Added VBArray.getItem() implementation
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6284 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 8/8] jscript: Added VBArray handling to to_object()
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6286 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Fwd: Invitation: Apply to be a Mentoring Organization for GCI
by Austin English Oct. 19, 2010

Oct. 19, 2010

I hadn't see any talk about this, so passing this along from Google: -- -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Oct 18, 2010 at 8:10 AM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, Starting today we are accepting applications from organizations who have participated in a previous Google Summer of Code (you!) to get involved with our contest for 13-18 year olds, Google Code-in [0]. If you haven’t read up about Google Code-in, you can check out our announcement [1] to this list from a couple weeks ago or read our blog post [2] about the contest. If your org has decided it would like to apply to participate in the contest, you can fill out the application [3] on Melange now. The deadline for applications is 29 October at 23:00 UTC. Also, if you want to look over the rules for the contest before applying to participate they can be found on the organization application [3] at the bottom. They will also be posted on the Google Code-in website [0] in the next couple days in other languages. We hope your org will consider participating. [0] - http://code.google.com/gci [1] - http://groups.google.com/group/google-summer-of-code-mentors-list/msg/0985e… [2] - http://google-opensource.blogspot.com/2010/10/google-code-in-schools-out-co… [3] - http://socghop.appspot.com/gci/org_app/take/gci_program/google/gci2010/orga… Cheers, Carol

1 0

Apps for Wine on ARM
by Detlef Riekenberg Oct. 18, 2010

Oct. 18, 2010

Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef

1 0

Re: [PATCH 7/8] jscript: Added VBArray.toArray() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6285 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/bindprot.c | 343 +++++++++++++++++++++++++++++------------------ > 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/8] jscript: Added VBArray.dimensions() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6283 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/8] jscript: Implement VBArray constructor
by Jacek Caban Oct. 18, 2010

Oct. 18, 2010

Hi Piotr, +(tmp = new VBArray(createArray())).f = Object.prototype.toString; +ok(tmp.f() === "[object Object]", "tmp.f() = " + tmp.f()); We have Function.call implemented now, you can use String.prototype.toString.call(new VBArray ...). + case DISPATCH_METHOD: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + VariantCopy(retv, arg); Please add error handling. Also a test would be nice, at least something like getVT(createArray()). + case DISPATCH_CONSTRUCT: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + hres = alloc_vbarray(ctx, NULL,&vbarray); + if(FAILED(hres)) + return hres; + SafeArrayCopy(V_ARRAY(arg),&vbarray->safearray); Error handling. (From 'PATCH 4/8] jscript: Added VBArray.ubound() implementation'): + if(retv) + num_set_val(retv, dim); num_set_val is for DOUBLE and eventually abused for integers out of VT_I4 range. You can set value directly here to avoid conversions. It might be a good idea to introduce something like var_set_int helper given that we could use it in quite a few places. (From '[PATCH 6/8] jscript: Added VBArray.getItem() implementation'): + size = arg_cnt(dp); + if(size< SafeArrayGetDim(vbarray->safearray)) + return throw_range_error(ctx, ei, IDS_SUBSCRIPT_OUT_OF_RANGE, NULL); + + indexes = heap_alloc(sizeof(int)*size); Error handling. (From '[PATCH 8/8] jscript: Added VBArray handling to to_object()'): -exception_test(function() {(new VBArray(createArray())).lbound("aaa");}, "RangeError", -2146828279); -exception_test(function() {(new VBArray(createArray())).lbound(3);}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound("aaa");}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound(3);}, "RangeError", -2146828279); There is no reason to change these tests, esp. that they were better before the change. Please add proper to_object tests, for example by calling Object() function or doing proper call on explicitly converted object. + SafeArrayCopy(sa,&vbarray->safearray); Error handling. Jacek

1 0

Re: [PATCH 4/8] jscript: Added VBArray.ubound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6282 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/8] jscrpt: Added VBScript.lbound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6281 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i > if (ret >= 0 && !used_default) > { > unix_name[pos + ret] = 0; > - if (!stat( unix_name, &st )) > + /* when checking case on a case insensitive but case preserving > + * fs, don't even bother doing the stat(), so we don't match the > + * file case-insensitively. > + */ > + if ((case_sensitive || !check_case) && !stat( unix_name, &st )) > { > if (is_win_dir) *is_win_dir = is_same_file( &windir, &st ); > return STATUS_SUCCESS; > } This still doesn't make sense. There's no reason to ever skip the stat. > @@ -2455,6 +2713,10 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer > const WCHAR *end, *next; > int is_win_dir = 0; > > + unix_name[pos] = 0; > + stat( unix_name, &st ); > + unix_name[pos] = '/'; You can't add extra stat calls to the normal path. This is supposed to be an optimization. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/8] jscript: Added VBArray stub
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6279 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In the proposed patch "[PATCH 2/2] ntdll: Check for case-insensitive volumes.", I found this piece: + /* Add a new entry */ + for (i = 0; i < sizeof(fs_cache)/sizeof(fs_cache[0]); i++) + if (fs_cache[i].dev == 0) + { + /* This entry is empty, use it */ + fs_cache[i].dev = dev; + fs_cache[i].fsid = fsid; + fs_cache[i].case_sensitive = case_sensitive; + } Maybe I'm missing something, but shouldn't you return from the function when finding a cache entry to fill? This seems to be filling every empty cache entry? HTH, Joris

2 1

About: msxml3: Partially implement ::setAttributeNode()
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: + name = xmlChar_from_wchar(nameW); + value = xmlChar_from_wchar(V_BSTR(&valueW)); + + if (!name || !value) + { + SysFreeString(nameW); + VariantClear(&valueW); + return E_OUTOFMEMORY; + } Wouldn't you need to free memory allocated for both name and value, in case one of the allocations succeeded ? HTH, Joris

2 1

Re: [1/4]winegstreamer: add wine gstreamer parser filter
by Damjan Jovanovic Oct. 18, 2010

Oct. 18, 2010

On Mon, Oct 18, 2010 at 3:26 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/winegstreamer/regsvr.c | 951 +++++++++++++++++++ Please consider IRegistrar or inf file based registration instead, regsvr.c is the worst way to support DLL registration, especially if you have to customize it the way you have. Damjan

1 0

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface
by Jacek Caban Oct. 18, 2010

Oct. 18, 2010

Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: > Get rid of ::get_dataType() forward to IXMLDOMNode interface > switch ( This->node->type ) { case XML_ELEMENT_NODE: On of points of such patches is to get rid of such switches. In this case it seems like introducing new helper return_null_var, adding FIXME to extityref implementation and moving element-specific part to element.c is way to go. Also it would be nice to have consistent TRACEs, so moving them to node-specific objects would be nice. Jacek

2 3

Re: [PATCH 3/3] winspool: Use UNICODE for CUPS printer names [fixes bug 6437]
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > or do we have to remove all related "const" from the strings? Yes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try4]
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > I was looking for a forbidden char in batch files but just I found accentuated chars whereas I wanted a single (not wide) char. > Finally, I found it in the ASCII table. > The \x1a character name is SUBSTITUTE and is exactly what we need. It means end of file on Windows, so it's not a good choice. Please don't add magic control chars, do a @space@ style of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] msxml3: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Hans Leidekker Oct. 18, 2010

Oct. 18, 2010

Hi Tomasz, Please use a more specific subject such as "mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in TranslateBitmapBits".

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Nikolay Sivov Oct. 17, 2010

Oct. 17, 2010

On 10/17/2010 22:46, Tomasz Michno wrote: > --- > dlls/mscms/tests/Makefile.in | 3 ++- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > > You forgot to add new file to a patch.

1 0

[PATCH] Compiling Wine at Ubuntu 10.10
by Gerold Jens Wucherpfennig Oct. 17, 2010

Oct. 17, 2010

You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. If you still get a compilation error in dlls/winex11.drv you will need to add the flag "-lXxf86vm". With kind regards, Gerold Jens Wucherpfennnig

4 5

Re: Set base direction of web site to RTL language for Hebrew
by Yaron Shahrabani Oct. 17, 2010

Oct. 17, 2010

Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...

2 4

Ubuntu Package Archive is back!
by Scott Ritchie Oct. 17, 2010

Oct. 17, 2010

When I switched Ubuntu package hosting to a launchpad PPA (away from manual .deb hosting), one thing lost was the ease of archiving old versions, since Launchpad doesn't provide this. I've written some scripts to manually copy the packages from the PPA to form a new archive and am hosting it at the old location http://wine.budgetdedicated.com/archive/ -- currently it carries all the Wine packages that have been on the Ubuntu Wine PPA since 1.3.3 or so. The main use of the archive is to aid in regression testing - installing from packages is much easier/quicker than recompiling from source, and will help you narrow down the last working/nonworking wine version before doing a proper git bisect. All I have to do is run the script every time I update the PPA with new Wine packages, and it's good. Due to server space issues, I don't plan to archive daily package builds (which is my next project). Thanks, Scott Ritchie

2 1

RTL in console windows
by Yaron Shahrabani Oct. 17, 2010

Oct. 17, 2010

Hi there guys, My name is Yaron Shahrabani and I'm an active translator of Wine to Hebrew. As probably some of you may know Hebrew is written from right-to-left meaning that the GUI and text rendering should work in a reversed/mirror order as opposed to Latin text. Due to some recent work doen by Alexander (Thanks! AJ, great work!), Hebrew is better supported now by wine GUI mechanism but as a translator I ran into some dillemas about the translation of strings that appear in console window, well apparently this is a tough question. Paul (Vriens) sent me 2 screenshots the other day that showed the way Hebrew is handled by the different command line platforms: The first one is the VTE (Virtual Terminal Emulator) which most of us know as gnome-vte or gnome-terminal, this app emulates a command line interface for X11. As opposed to Konsole (The same app only for KDE) gnome's vte cannot handle Hebrew correctly (is there any need to attach bugs or you'll just believe me?). gnome-terminal can show the Hebrew glyphs but they all appear in reversed order, same thing happens for wine apps that present a command line output (such as reg, ipconfig, etc.) when running via gnome-terminal. The other option to display and work with a CLI app is via wineconsole, since wineconsole does not support Hebrew our of the box we have to install the msttcorefonts package in order to do so. At the second screenshot that Paul sent me with the wineconsole screenshot of reg (I translated the app but since I'm not sure how it will work I haven't submitted it to wine-patches yet but I will send it here if needed) Ive seen some blanks with ":" at the end meaning that the glyphs were missing, few minutes later Paul sent me an updated screenshot after installing the missing glyphs, the Hebrew looked absolutely perfect, the only problem was that the semicolon still appeared to the right of the text instead of to the left (where the sentence ends in Hebrew). So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... I would love to clarify any misclarifications. Thank you all, Kind regards, Yaron Shahrabani <Hebrew translator>

2 2

Website: Change language string
by Yaron Shahrabani Oct. 17, 2010

Oct. 17, 2010

Where does the translation of "Change Language" string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani <Hebrew translator>

2 2

Packagers: cups-bsd/cupsys-bsd (lpr and friends) no longer needed
by Detlef Riekenberg Oct. 16, 2010

Oct. 16, 2010

Hi Wine packing Team. Cups has a compatibility package for the BSD style printing system (lpr, lpq, lprm, lpc and related files). The package is named cups-bsd on ubuntu and cupsys-bsd on debian. This compatibility package is no longer needed since Wine-1.3.5, when cups is installed: http://source.winehq.org/git/wine.git/?a=commit;h=f69a4ef07f7b1b0017e1bf335… Thanks for updating the Wine dependency. -- By by ... Detlef

2 1

Re: user32: Update last active popup for all parents
by testbot＠testbot.winehq.org Oct. 16, 2010

Oct. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] problem with color management with mscms and gdi
by Detlef Riekenberg Oct. 16, 2010

Oct. 16, 2010

Hi Tomasz. Welcome to Wine. You already fixed your missing real name in your first patch. That is good, but there are more suggestions. > For applications which uses EnumICMProfiles to detect monitor icc profile, > there should be a copy of monitor profile in > windows\system32\spool\drivers\color\monitor.icc. If there is no monitor.icc > in this directory, application works the same as if there were no color > management enabled (but image is displayed ok). A description for the issue is a good idea. > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } What you wrote in your patch is a hack and hacks are missing the code quality to be accepted in Wine. Wine development is test driven. You should add some tests for this function and try to invent a real implementation, which match the tests. - Does this function handle a NULL parameter for hdc and/or for func? (If a NULL produce a crash on Windows, there is no need to check for a NULL in the implementation in Wine) - What does the function return, when the directory does not exist or when there are no icc profiles in the directory? - A HDC for a window on the monitor is not the only type for an HDC. (memory, printers, metafiles) Implementing all possible types is not a requirement (as long, as an app does not need it), but the usual way in Wine is at least printing a FIXME for the unimplemented part of the API. - There are usable API functions, to get the icc profile path. - Reading the directory and calling the user func for every file is not very difficult, as wine has examples in the source. You can ask for help for the implementation or for the tests on wine-devel or use #winehackers on freenode. There is has also http://testbot.winehq.org and later http://tests.winehq.org > INT WINAPI EnumICMProfilesW(HDC hdc, ICMENUMPROCW func, LPARAM ... > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); Providing an ANSI Path to a UNICODE callback will never work. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c This is a separate Patch I know, that the starting step is not easy, but once you contributed successfully to Wine, your Development results (patches) are much better. Did you read http://wiki.winehq.org/DeveloperFaq and http://wiki.winehq.org/SubmittingPatches ? Overview: http://wiki.winehq.org/Developers -- By by ... Detlef

1 0

Re: [PATCH] problem with color management with mscms and gdi
by André Hentschel Oct. 16, 2010

Oct. 16, 2010

Hi and welcome to wine development, your patch is wrapped. see the gdi part of it at http://source.winehq.org/patches/. so you should check your mailclient. Further you might want to split it per module (gdi and mscms, one patch each) -- Best Regards, André Hentschel

2 1

Re: [PATCH] problem with color management with mscms and gdi
by Hans Leidekker Oct. 16, 2010

Oct. 16, 2010

Hi Tomasz, This patch is wrapped, unlike your first attempt were you attached the patch. > dlls/gdi32/icm.c | 8 ++++++-- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdi32/icm.c b/dlls/gdi32/icm.c > index 0e346ee..d75c528 100644 > --- a/dlls/gdi32/icm.c > +++ b/dlls/gdi32/icm.c > @@ -44,7 +44,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(icm); > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } You can't hardcode the filename like that. EnumICMProfiles should call down into the driver and probably enumerate a registry key. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c > index a795386..e7a3faa 100644 > --- a/dlls/mscms/transform.c > +++ b/dlls/mscms/transform.c > @@ -65,6 +65,8 @@ static DWORD from_bmformat( BMFORMAT format ) > { > case BM_RGBTRIPLETS: return TYPE_RGB_8; > case BM_BGRTRIPLETS: return TYPE_BGR_8; > + case BM_xRGBQUADS: return TYPE_RGBA_8; > + case BM_xBGRQUADS: return TYPE_ABGR_8; > case BM_GRAY: return TYPE_GRAY_8; > default: > if (quietfixme == 0) You should send this as a separate patch.

1 0

Re: [Website] Foundation of the Hebrew website
by James McKenzie Oct. 16, 2010

Oct. 16, 2010

On 10/11/10 9:28 AM, Yaron Shahrabani wrote: > Started some translation work, there is still much more RTLing work to > do so we will settle for an LTR for now and I will handle it soon. > Yaron Shahrabani > > <Hebrew translator> > > > > Yaron: Since the web site works runs on a Web Server, should you not be building the work RTL rather than LTR? Just a thought, mind you and it might save work later. James McKenzie

2 4

Re: [2/6] msxml3: IXMLDOMSchemaCollection/XMLSchemaCache backend
by Nikolay Sivov Oct. 16, 2010

Oct. 16, 2010

On 10/15/2010 18:25, Adam Martinson wrote: > > Implemented on top of libxml's hash table. > --- > dlls/msxml3/schema.c | 376 > +++++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 326 insertions(+), 50 deletions(-) > +static LONG cache_entry_release(cache_entry* entry) > { > - schema_t *This = impl_from_IXMLDOMSchemaCollection( iface ); > + LONG ref = InterlockedDecrement(&entry->ref); > + TRACE("%p new ref %d\n", entry, ref); > > - TRACE("(%p)->(%s %p)\n", This, debugstr_guid( riid ), ppvObject ); > + if (ref == 0) > + { > + if (entry->type == SCHEMA_TYPE_XSD) > + { > + xmldoc_release(entry->doc); > + entry->schema->doc = NULL; > + xmlSchemaFree(entry->schema); > + heap_free(entry); > + } > + else /* SCHEMA_TYPE_XDR */ > + { > + xmldoc_release(entry->doc); > + heap_free(entry); > + } > + } > + return ref; > +} Looks a but redundant. xmldoc_release() and heap_free(entry) are always used, so only xmlSchemaFree() and doc reset before it should be under condition. > + xmlNodePtr root; > + if (schema) > + root = xmlDocGetRootElement(schema); > + if (root&& root->ns) > + { root uninitialized? If this never happens practically then remove if (schema) condition. > - IXMLDOMSchemaCollection_AddRef( iface ); > + IXMLDOMSchemaCollection_AddRef(iface); > > return S_OK; > } > > -static ULONG WINAPI schema_cache_AddRef( IXMLDOMSchemaCollection *iface ) > +static ULONG WINAPI schema_cache_AddRef(IXMLDOMSchemaCollection *iface) No need for such changes here and later in this patch, even some new added lines use white-spaces in such cases. > + IXMLDOMNode* domnode = NULL; > + IDispatch_QueryInterface(V_DISPATCH(&var),&IID_IXMLDOMNode, (void**)&domnode); > + > + if (domnode) > + doc = xmlNodePtr_from_domnode(domnode, XML_DOCUMENT_NODE)->doc; Not sure about that, I'd say it's better to test for hr == S_OK and return value from QueryInterface, is this branch tested?

1 0

Re: [1/6] msxml3: add a function to initialize xmlDoc->_private data
by Nikolay Sivov Oct. 16, 2010

Oct. 16, 2010

On 10/15/2010 18:25, Adam Martinson wrote: > > Needed to associate an internal ref count, etc with a xmlDoc > outside of domdoc.c, without creating the whole domdoc struct. > --- > dlls/msxml3/domdoc.c | 6 ++++++ > dlls/msxml3/msxml_private.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Why not use this helper in DOMDocument_create() ?

1 0

Re: [6/6] msxml3: implement schema_cache_addCollection()
by testbot＠testbot.winehq.org Oct. 16, 2010

Oct. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [5/6] msxml3: implement schema_cache_remove()
by testbot＠testbot.winehq.org Oct. 16, 2010

Oct. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [4/6] msxml3: implement schema_cache_get_length()
by testbot＠testbot.winehq.org Oct. 16, 2010

Oct. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6211 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [3/6] msxml3/tests: internal schema doc storage tests
by testbot＠testbot.winehq.org Oct. 16, 2010

Oct. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6210 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: Updated Norwegian translation.
by Austin English Oct. 15, 2010

Oct. 15, 2010

2010/10/14 Trygve Vea <trygve.vea(a)gmail.com>: > Hello, > > This is my first patch to Wine - this one fixes some translation > errors - and adds some new translations. > I hope this is not the last patch I will send to Wine. > > Any feedback is welcome. Hello Trygve, Thanks for the translations. However, patches should be split, 1 patch per module. In other words, one patch for dlls/crypt32, one for dlls/jscript, and so on. I can't judge the rest, I don't speak Norweigan :-). Cheers, -Austin

3 2

Re: oleaut32: Updated Norwegian translation.
by Alexander Nicolaysen Sørnes Oct. 15, 2010

Oct. 15, 2010

Fredag 15 oktober 2010 07:48:17 skrev Trygve Vea : > What is being changed here? Alexander N. Sørnes

1 0

Re: jscript: Updated Norwegian translation.
by Alexander Nicolaysen Sørnes Oct. 15, 2010

Oct. 15, 2010

Fredag 15 oktober 2010 07:46:51 skrev Trygve Vea : > This should be discarded. I've made some comments to the patch that contained all the translations in one, and the overall quality of the patches is good. Alexander N. Sørnes

1 0

Accessibility in wine
by Seth Shelnutt Oct. 14, 2010

Oct. 14, 2010

I can't seem to find much info on this. What is wine's support for MSAA or the newer UIAutomation? I see that there is the oleacc dll which is the main dll for MSAA. According to the API site, is seems there are still 10 stubs. Looking at the source code there hasn't been any updates in over a year. We don't have the UIAutomation dll yet. Does anyone know the status of MSAA/UIAutomation support in wine? I'm trying to get NVDA working and still running into some issues with it requiring UIAutomation.dll, when according to them, that dll is optional. After I get that worked out I'm hoping to see what needs to be done to get MSAA supported under wine. Thanks, Seth Shelnutt

2 2

Re: msi/tests: Move test coverage for standard actions to a separate module.
by Greg Geldorp Oct. 14, 2010

Oct. 14, 2010

> From: Hans Leidekker <hans(a)codeweavers.com> > > This is to get rid of the remaining timeouts on testbot. We now have > a clean test run: > > http://testbot.winehq.org/JobDetails.pl?Key=6167 > > On platforms where we need to create a restore point the install tests > still take over two minutes, so depending on the load on testbot we > might still see some timeouts. This is great! If needed, I can probably turn off System Restore, which disables creation of restore points altogether. Greg.

1 0

Re: msi/tests: Move test coverage for standard actions to a separate module.
by Hans Leidekker Oct. 14, 2010

Oct. 14, 2010

This is to get rid of the remaining timeouts on testbot. We now have a clean test run: http://testbot.winehq.org/JobDetails.pl?Key=6167 On platforms where we need to create a restore point the install tests still take over two minutes, so depending on the load on testbot we might still see some timeouts.

2 2

Re: [PATCH 4/5] d3d10core: Add a stub ID3D10Texture3D implementation.
by testbot＠testbot.winehq.org Oct. 14, 2010

Oct. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6168 Your paranoid android. === WINEBUILD (build) === Patch failed

3 2

Google Summer of Code Mentors?
by Jeremy White Oct. 14, 2010

Oct. 14, 2010

Did we have an 'official' leader for GSOC this past year? If not, could I ask someone (*cough* Kai *cough*) to nominate themselves? We need to coordinate getting some information to the SFC so that we can collect the mentor stipend from Google. Cheers, Jeremy

3 2

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.
by Mike Kaplinskiy Oct. 14, 2010

Oct. 14, 2010

On Tue, Oct 12, 2010 at 8:01 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > While searching for something else I discovered a bug relevant to the > interface-bound UDP broadcast patches I've been working on. Apparently, > IP_PKTINFO does work on Windows when used with the special WSARecvMsg > function (Bug #19493). The attached patch addresses this issue by > implementing WSARecvMsg through WS2_recvfrom and by converting the Unix > IP_PKTINFO response to the Windows equivalent. > ChangeLog: > ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO. > > > > Sorry I must have missed the RFC when reading my mail. These comments are purely mine, and may not have any value for getting your patch in :). +static inline WSACMSGHDR *create_control_message(int level, int type, WSACMSGHDR *current, ULONG *maxsize, void *data, int len) This doesn't seem like a "create", more like a "fill" or "write". + int newsize = (int)*maxsize; + + /* Make sure there is at least enough room for this entry */ + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); + if (newsize < 0) + return 0; + *maxsize = (ULONG)newsize; Just declare it as a ULONG/size_t so you don't have to cast. +static inline int convert_control_headers(struct msghdr *hdr, ULONG *maxsize) You shouldn't mix using memory as unix-style CMSGs and windows-style CMSGs. Just allocate something to store the unix messages, read them in and convert them into the user-passed buffer. This seems similar to what we do for address conversion. + memset(cmsg_win, 0x00, sizeof(WSACMSGHDR)); /* Don't use garbage data if no headers are found */ I think in general that is discouraged at wine (don't quote me on that). You should just initialize the values manually. + if (wsa->control && !convert_control_headers(&hdr, wsa->controllen)) + { + /* Insufficient room for control headers */ + errno = EINVAL; + return -1; + } This should probably be in an #ifdef of some sort. + msg->dwFlags |= WINE_MSG_HASCTRL; + memcpy(buftmp, msg->lpBuffers, msg->dwBufferCount * sizeof(WSABUF)); + buftmp[msg->dwBufferCount] = msg->Control; + ret = WS2_recvfrom( s, buftmp, msg->dwBufferCount, lpNumberOfBytesRecvd, + &msg->dwFlags, msg->name, &msg->namelen, + lpOverlapped, lpCompletionRoutine ); You shouldn't add internal flags like that. Just rewrite WS2_recvfrom to allow returning message headers instead of hacking around it. +static int (WINAPI *pWSARecvMsg)(SOCKET,LPWSAMSG,LPDWORD,LPWSAOVERLAPPED,LPWSAOVERLAPPED_COMPLETION_ROUTINE) = 0; +GUID WSARecvMsg_GUID = WSAID_WSARECVMSG; For one reason or another the convention is to get it during your test function (see AcceptEx & ConnectEx). (This does have some merit as SIO_GET_EXTENSION_FUNCTION_POINTER can vary with the socket that's passed) + s1addr.sin_family = AF_INET; + s1addr.sin_port = htons(9375); + s2addr.sin_family = AF_INET; + s2addr.sin_port = htons(9375); You should probably bind to 0 and then use getsockname to get the actual port you bound to. + s1=socket(AF_INET, SOCK_DGRAM, 0); + ok(s1!=INVALID_SOCKET, "socket() failed error: %d\n", WSAGetLastError()); Spaces around = & != would make me happy (and below). Also you don't error out correctly if socket creation fails. diff --git a/include/mswsock.h b/include/mswsock.h index 322ab20..5749e59 100644 --- a/include/mswsock.h +++ b/include/mswsock.h This should be a separate patch. diff --git a/include/ws2ipdef.h b/include/ws2ipdef.h index 11b3689..ec0b85a 100644 --- a/include/ws2ipdef.h +++ b/include/ws2ipdef.h Same here. Mike.

2 2

Ongoing Debian package maintenance.
by Ben Klein Oct. 14, 2010

Oct. 14, 2010

Hello everyone, My health has not improved at all since my last call for help with the Debian package management. I really need someone to take over from me, or at least some help to devise a new set of (semi-)automated build scripts. Any volunteers? Kind regards, Ben

5 11

Removal of very very old versions from bugzilla?
by Scott Ritchie Oct. 13, 2010

Oct. 13, 2010

Wise idea or no? If not is there at least a way to hide them from the report bug page? I'm talking about the 2001-era version numbers, before 0.9 even. -Scott Ritchie

2 1

Re: [PATCH] jscript/tests: add tests for ActiveScriptSite_OnScriptError and IActiveScriptError. [try 3]
by Reece Dunn Oct. 13, 2010

Oct. 13, 2010

On 9 October 2010 15:51, Reece Dunn <msclrhd(a)googlemail.com> wrote: > try 1 -- initial series (1-3) > try 2 -- revised test infrastructure based on Jacek's comments > try 3 -- fleshed out the tests to complete the test coverage for > IActiveScriptError Any reason this has not been committed yet? Thanks, - Reece

1 0

Re: [5/5] msi/tests: Don't create a nested restore point on recent versions of MSI.
by testbot＠testbot.winehq.org Oct. 13, 2010

Oct. 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6155 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout === W2K3R2SESP2 (32 bit install) === Timeout

1 0

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory. (try 2)
by Alexandre Julliard Oct. 13, 2010

Oct. 13, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This shouldn't introduce a failure if Mono is missing. I'm afraid it does: ../../../tools/runtest -q -P wine -M fusion.dll -T ../../.. -p fusion_test.exe.so fusion.c && touch fusion.ok wine: Install the Windows version of Mono to run .NET executables fusion.c:193: Test failed: Expected S_OK, got 80131700 fusion.c:194: Test failed: Expected "C:\windows\assembly\NativeImages_el32.dll_32", got "nochange" make: *** [fusion.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Fixing imagelist control tests for 16bpp
by Austin Lund Oct. 13, 2010

Oct. 13, 2010

It seems that the imagelist control on XP has some strange device dependence even though the tests use device independent bitmaps. Attached is a patch to try and correct the test for what is broken. Is this the right approach?

1 0

Re: [transl] Deal with WS_EX_LAYOUTRTL for RTL languages
by Yaron Shahrabani Oct. 12, 2010

Oct. 12, 2010

On Tue, Oct 12, 2010 at 11:08 AM, Paul Vriens <paul.vriens.wine(a)gmail.com>wrote: > Hi, > > This patch makes sure that a missing WS_EX_LAYOUTRTL for EXSTYLE is flagged > for RTL languages and that it's ignored if present. > > It's not ideal yet as the potential errors shown on the webpage do not > fully explain the issue/error. More changes are needed to get that into > place but this patch at least makes sure that the real errors are catched > and don't get lost in the multitude of errors we have now (for Hebrew for > example). > > Changelog > Deal with WS_EX_LAYOUTRTL for RTL languages > Hey Paul, I think these should apply to several other languages: Divehi Syriac Urdu (There are several other languages but I took the following out of the following list: http://source.winehq.org/transl/) Another language which I'm not sure about is Pujabi since it has 3 popular scripts: Gurmukhi and Devanagari are RTL written while Shahmukhi is RTL, Wikipedia in written in the RTL script while Ubuntu is translated using the LTR scripts (can't determine which though). Its all about location, Pakistanies are writing in RTL whille all others write with the LTR scripts, It all depends on who you ask :) Your patch to the translation check is working great, thanks alot! Yaron Shahrabani <Hebrew translator> > > -- > Cheers, > > Paul. > > > >

1 0

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory.
by Vincent Povirk Oct. 12, 2010

Oct. 12, 2010

Hang on, this one will also introduce a failure. On Tue, Oct 12, 2010 at 12:51 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: [PATCH 5/5] shlwapi/tests: Add more tests
by testbot＠testbot.winehq.org Oct. 12, 2010

Oct. 12, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6118 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1793: Test failed: got 29 ordinal.c:1843: Test failed: got 29 ordinal.c:1851: Test failed: got 29 ordinal.c:1859: Test failed: got 40, length 41 ordinal.c:1870: Test failed: got 43 === W7PROX64 (64 bit ordinal) === ordinal.c:1787: Test failed: got 10 ordinal.c:1808: Test failed: got 7 ordinal.c:1821: Test failed: got 10 ordinal.c:1829: Test failed: got 10 ordinal.c:1859: Test failed: got 36, length 37 ordinal.c:1870: Test failed: got 39 ordinal.c:1881: Test failed: got 21 ordinal.c:1892: Test failed: got 24

2 1

Re: [PATCH 1/5] shlwapi: Improved SHGetShellKey implementation
by testbot＠testbot.winehq.org Oct. 12, 2010

Oct. 12, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6117 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1789: Test failed: got 29 ordinal.c:1839: Test failed: got 29 ordinal.c:1847: Test failed: got 29 ordinal.c:1855: Test failed: got 40, length 41 ordinal.c:1866: Test failed: got 43 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 10 ordinal.c:1804: Test failed: got 7 ordinal.c:1817: Test failed: got 10 ordinal.c:1825: Test failed: got 10 ordinal.c:1855: Test failed: got 36, length 37 ordinal.c:1866: Test failed: got 39 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24

1 0

Re: [PATCH 1/5] ddraw: Use a linear filter in ddraw_surface7_Blt().
by Stefan Dösinger Oct. 12, 2010

Oct. 12, 2010

Am 12.10.2010 um 13:40 schrieb Henri Verbeet: > + hr = IWineD3DSurface_Blt(This->WineD3DSurface, DestRect, Src ? Src->WineD3DSurface : NULL, > + SrcRect, Flags, (WINEDDBLTFX *)DDBltFx, WINED3DTEXF_LINEAR); Why do you think a linear filter is correct? I was under the impression that ddraw only uses point filters.

2 2

Re: setupapi/tests: Fix wow64 failures
by Alexandre Julliard Oct. 12, 2010

Oct. 12, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > This removes problems on wow64 on windows platforms (wine can't even handle the normal case yet) > See http://test.winehq.org/data/tests/setupapi:devinst.html > --- > dlls/setupapi/tests/devinst.c | 44 +++++++++++++++++++++++++++-------------- > 1 files changed, 29 insertions(+), 15 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M setupapi.dll -T ../../.. -p setupapi_test.exe.so devinst.c && touch devinst.ok devinst.c:1120: Test succeeded inside todo block: Unexpected path \\?\ROOT#LEGACY_BOGUS#0001#{6A55B5A4-3F65-11DB-B704-0011955C2BDB} make[1]: *** [devinst.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] d3dx9/tests: Fix a failure on 64 bits.
by Alexandre Julliard Oct. 12, 2010

Oct. 12, 2010

Matteo Bruni <matteo.mystral(a)gmail.com> writes: > @@ -131,7 +131,9 @@ static void test_get_shader_constant_table_ex(void) > > /* With invalid CTAB data */ > hr = D3DXGetShaderConstantTableEx(shader_with_invalid_ctab, 0, &constant_table); > - ok(hr == D3DXERR_INVALIDDATA, "Got result %x, expected %x (D3DXERR_INVALIDDATA)\n", hr, D3DXERR_INVALIDDATA); > + /* Native on 64 bit doesn't check for invalid data */ > + ok(hr == D3DXERR_INVALIDDATA || (hr == D3D_OK && sizeof(DWORD) != sizeof(DWORD_PTR)), > + "Got result %x, expected %x (D3DXERR_INVALIDDATA)\n", hr, D3DXERR_INVALIDDATA); This doesn't seem to have much to do with 64-bit, it looks more like a broken implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: libs/wine: make lack of LDT support an #error
by Alexandre Julliard Oct. 12, 2010

Oct. 12, 2010

Austin English <austinenglish(a)gmail.com> writes: > Nothing runs without it. The error is pretty obvious, I don't think there's a need to break the build. Besides, you don't need LDT for 32-bit apps if you have GDT support. -- Alexandre Julliard julliard(a)winehq.org

1 0

LLVM compilation
by Jeff Cook Oct. 11, 2010

Oct. 11, 2010

Just wondering if anyone has experimented building WINE with LLVM instead of GCC. For those who haven't been following it closely, LLVM/Clang is fairly mature now and can now build some really mammoth projects. Has anyone experimented in building WINE with LLVM/Clang? If so, what results were gotten? My understanding is that WINE tries hard to be pretty portable and non-GCC-specific, so I would expect good results... Thanks From Jeff

6 5

IDE for Wine Development?
by Evil Jay Oct. 11, 2010

Oct. 11, 2010

The small patches I've submitted previously have been very minor code changes that I put together in a text editor. But today I've been perusing the available bug list, and see a couple of more ambitious things I would like to try to tackle. My question is: Which IDE/editors do you "real" devs prefer for your work on Wine? This topic doesn't seem to be mentioned in the dev faq/guides on WineHQ. I googled to see if others had asked before, but if they did I must have not phrased my searches very well. I've been playing with KDevelop 4.0.2 for the last hour. It's beautiful, but I haven't had the best experience with it: It randomly crashed 3 times within a short period of first using it. Oddly, it's not crashed since I restarted it from the command line so that I could attempt to figure out what the problem is. -J

5 4

Re: [1/2] kernel32: Implement GetSystemRegistryQuota as a semi-stub.
by testbot＠testbot.winehq.org Oct. 11, 2010

Oct. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6079 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: [6/6] msi/tests: Reduce the UI level for a couple of tests.
by testbot＠testbot.winehq.org Oct. 11, 2010

Oct. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6078 Your paranoid android. === W2K8SE (32 bit install) === Timeout

1 0

Re: [2/3] msxml3/httprequest: Implement POST support with supplied body data
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Implement POST support with supplied body data It crashes here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok wine: Unhandled page fault on read access to 0x00610054 at address 0x556c7d55 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00610054 in 32-bit code (0x556c7d55). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:556c7d55 ESP:0032fad0 EBP:0032fb28 EFLAGS:00010202( R- -- I - - - ) EAX:00130f98 EBX:5570b4ec ECX:0061004c EDX:000401e8 ESI:68f31924 EDI:0032fbd4 Stack dump: 0x0032fad0: 00130f98 001259d8 00000000 68f31924 0x0032fae0: 0032fb0c 0012b0a4 0032fb08 687e878b 0x0032faf0: 68894798 00000000 7bc49ceb 000401e8 0x0032fb00: 001329b8 00000000 0032fb68 00130f98 0x0032fb10: 001329b8 55704230 0032fbd8 5570b4ec 0x0032fb20: 68f31924 001329b8 0032fb88 556de570 Backtrace: =>0 0x556c7d55 bind_to_storage+0x145(url="http://crossover.codeweavers.com/xmltest.xml", pbc=0x1259d8, riid=0x68f31924, ppv=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon (0x0032fb88) 1 0x556de570 URLMoniker_BindToStorage+0x7f(iface=0x1329b8, pbc=0x1259d8, pmkToLeft=(nil), riid=0x68f31924, ppvObject=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/umon.c:226] in urlmon (0x0032fbf8) 2 0x68f0ac2f httprequest_send+0x29e(iface=0x132560, body={n1={n2={vt=0, wReserved1=0, wReserved2=0x549f, wReserved3=0x7bc3, n3={cVal=-92, uiVal=0x25a4, ulVal=0x1325a4, intVal=0x1325a4, uintVal=0x1325a4, bVal=-92, iVal=0x25a4, lVal=0x1325a4, fltVal=0.000000, dblVal=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, boolVal=0x25a4, scode=0x1325a4, date=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, bstrVal="GET", cyVal={={Lo=0x1325a4, Hi=0x7b88577c}, int64=0x7b88577c001325a4}, punkVal=0x1325a4, pdispVal=0x1325a4, parray=0x1325a4, llVal=0x7b88577c001325a4, ullVal=0x7b88577c001325a4, pcVal="G", puiVal="GET", pulVal=0x1325a4, pintVal=0x1325a4, puintVal=0x1325a4, pbVal="G", piVal=0x1325a4, plVal=0x1325a4, pfltVal=0x1325a4, pdblVal=0x1325a4, pboolVal=0x1325a4, pscode=0x1325a4, pdate=0x1325a4, pbstrVal=0x1325a4, pvarVal=0x1325a4, byref=0x1325a4, pcyVal=0x1325a4, pdecVal=0x1325a4, ppunkVal=0x1325a4, ppdispVal=0x1325a4, pparray=0x1325a4, pllVal=0x1325a4, pullVal=0x1325a4, brecVal={pvRecord=0x1325a4, pRecInfo=0x7b88577c}}}, decVal={wReserved=0, u={={scale=0, sign=0}, signscale=0}, Hi32=0x7bc3549f, u1={={Lo32=0x1325a4, Mid32=0x7b88577c}, Lo64=0x7b88577c001325a4}}}}) [/home/julliard/wine/wine/dlls/msxml3/httprequest.c:472] in msxml3 (0x0032fd38) 3 0x6868d935 func_domdoc+0x1104() [/home/julliard/wine/wine/dlls/msxml3/tests/domdoc.c:3370] in msxml3_test (0x0032fd88) 4 0x6869e92e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:556] in msxml3_test (0x0032fe48) 5 0x6869eb27 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:624] in msxml3_test (0x0032fe90) 6 0x6869f6ac __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msxml3_test (0x0032fea8) 7 0x7b856cfc call_process_entry+0xb() in kernel32 (0x0032fee8) 8 0x7b8591fb start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 9 0x7bc72d30 call_thread_func+0xb() in ntdll (0x0032ffc8) 10 0x7bc72f00 call_thread_entry_point+0x6f(entry=0x7b8591a0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 11 0x7bc4db1a start_process+0x29(kernel_start=0x7b8591a0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x556c7d55 bind_to_storage+0x145 [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon: call *0x8(%ecx) 1623 IBinding_Release(BINDING(binding)); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Fix D3DXPlaneNormalize on 64 bits.
by Henri Verbeet Oct. 11, 2010

Oct. 11, 2010

On 8 October 2010 16:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > This patch changes D3DXPlaneNormalize to behave as native on 64 bits, > returning infinity in the fourth plane component when the norm is 0. > If this is not appropriate, I can resend without the implementation > changes, just fixing the tests. > I can't say this is necessarily wrong, but I do think it looks suspicious.

3 2

Re: [5/6] msi/tests: Set the MSIFASTINSTALL property.
by testbot＠testbot.winehq.org Oct. 11, 2010

Oct. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6077 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [1/6] msi/tests: Determine Wow64 mode just once.
by testbot＠testbot.winehq.org Oct. 11, 2010

Oct. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6073 Your paranoid android. === W2K8SE (32 bit install) === Timeout === W7PROX64 (64 bit install) === install.c:10489: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet Oct. 11, 2010

Oct. 11, 2010

On 7 October 2010 19:49, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Draw a full screen quad */ > +static void draw_quad_with_shader9(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geometry) > +{ > + HRESULT hr; > + D3DXMATRIX projection_matrix; > + > + D3DXMatrixOrthoLH(&projection_matrix, 2.0f, 2.0f, 0.0f, 1.0f); > + IDirect3DDevice9_SetTransform(device, D3DTS_PROJECTION, &projection_matrix); > + > + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, D3DCOLOR_XRGB(0, 0, 0), 1.0f, 0); > + ok(hr == D3D_OK, "IDirect3DDevice9_Clear returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_BeginScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_BeginScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_SetStreamSource(device, 0, quad_geometry, 0, sizeof(struct vertex)); > + ok(hr == D3D_OK, "IDirect3DDevice9_SetStreamSource returned: %08x\n", hr); > + hr = IDirect3DDevice9_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 2); > + ok(hr == D3D_OK, "IDirect3DDevice9_DrawPrimitive returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_EndScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_EndScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); > + ok(hr == D3D_OK, "IDirect3DDevice9_Present returned: %08x\n", hr); > +} > + Backbuffer contents are undefined after present.

1 0

Re: ddraw/test: Add more combinaison tests for SetCooperativeLevels
by testbot＠testbot.winehq.org Oct. 11, 2010

Oct. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6071 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: cabinet/tests: Reformated output in case of test failure (try 3)
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Marko Nikolic <grkoma(a)gmail.com> writes: > @@ -109,9 +109,9 @@ static void test_FDICreate(void) > ok(hfdi != NULL, "Expected non-NULL context\n"); > ok(GetLastError() == 0xdeadbeef, > "Expected 0xdeadbeef, got %d\n", GetLastError()); > - ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %d\n", erf.erfOper); > - ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %d\n", erf.erfType); > - ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %d\n", erf.fError); > + ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %x\n", erf.erfOper); > + ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %x\n", erf.erfType); > + ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %x\n", erf.fError); Most of these are error codes too, they should be in decimal. I don't see why you want to change this at all. If you think having the expected value printed in hex is confusing just get rid of it, it's useless anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try3]
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -11,6 +25,8 @@ echo. > echo . > echo.word > echo .word > +echo word > +echo word You need some escaping mechanism for these trailing spaces too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: toolhelp: Document InterruptRegister16
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Thomas Bleher <ThomasBleher(a)gmx.de> writes: > @@ -593,6 +593,29 @@ BOOL16 WINAPI StackTraceNext16(STACKTRACEENTRY *ste) > > /*********************************************************************** > * InterruptRegister (TOOLHELP.75) > + * > + * Registers a callback to intercept certain special events from any process. > + * > + * The special events are (TODO: There may be other events not listed here; > + * these are the ones documented in the patent mentioned below): These are standard x86 traps, they don't need special constants or documentation. Besides, if there's really a patent about this we can't implement it anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > } > > /* Add master channel, uncounted channels and an extra for capture */ > - mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > + /* Do not add the extra channel needed for capture on half-duplex capture cards > + like snd_usb_audio mics */ > + if (micelem && !mastelem && !captelem) > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem; > + else > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem + 1; This statement wasn't exactly clear before, but now it's really impossible to follow. Please rewrite this in a way that makes sense to a casual reader. -- Alexandre Julliard julliard(a)winehq.org

4 3