October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] riched20/tests: Cleaned up ITextServices::TxGetNaturalSize test and fixed test failures. (try 2)
by Austin Lund Oct. 11, 2010

Oct. 11, 2010

On 11 October 2010 13:46, Austin Lund <austin.lund(a)gmail.com> wrote: > > + todo_wine ok(result == S_OK || broken(result == E_FAIL), /* WINXP Arabic Language */ > + "TxGetNaturalSize gave unexpected return value (result = %x)\n", result); I know it's slightly unorthodox to reply to your own patch, but if anyone can throw any light on why this fails for this version of windows it would be much appreciated. My guess is a problem with RTL fonts, but I'm not sure.

1 0

Re: iphlpapi: Use Windows rather than Unix values to determine family
by André Hentschel Oct. 11, 2010

Oct. 11, 2010

Hi "lats", you should please provide your real name in your mail, otherwise your patch has bad chances to get in. Normally you can configure git, so that it reports your name in the "From:" field. -- Best Regards, André Hentschel

2 1

RFC: Patch to implement WSARecvMsg and IP_PKTINFO
by Erich Hoover Oct. 11, 2010

Oct. 11, 2010

While searching for something else I discovered a bug relevant to the interface-bound UDP broadcast patches I've been working on. Apparently, IP_PKTINFO does work on Windows when used with the WSARecvMsg function (Bug #19493). I've attached a patch to address this issue (including tests), and I would appreciate any comments on it. This patch approaches the problem by: 1) Implementing WSARecvMsg through WS2_recvfrom 2) Passing the control buffer as an additional WSABUF with an internal flag (cleared internally to prevent confusing applications) 3) Converting the returned Unix IP_PKTINFO data to the equivalent Windows version in WS2_recv() by utilizing a temporary buffer Thanks in advance for your feedback. Erich Hoover ehoover(a)mines.edu

1 0

Re: urlmon: Added ProtocolStream_Stat implementation.
by testbot＠testbot.winehq.org Oct. 10, 2010

Oct. 10, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6022 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Test FindWindowEx for empty window title (try 3)
by testbot＠testbot.winehq.org Oct. 10, 2010

Oct. 10, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6017 Your paranoid android. === W98SE (32 bit win) === win.c:2970: Test failed: message 000f available win.c:2982: Test failed: message 000f available win.c:2991: Test failed: message 000f available win.c:3000: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 6)
by Vitaliy Margolen Oct. 10, 2010

Oct. 10, 2010

On 10/08/2010 12:22 PM, Rudolf Mayerhofer wrote: > +static SYSTEM_LOGICAL_PROCESSOR_INFORMATION cached_lpi[1024]; You think there are systems with that many CPUs running Wine? > + for (i = 0; i < (sizeof(cached_lpi) / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION)); i++) To make it easier to understand what you doing here please calculate number of elements in cached_lpi array with: sizeof(cached_lpi) / sizeof(cached_lpi[0]); This way people don't need to look up what type cached_lpi is. > @@ -1069,6 +1193,160 @@ void fill_cpu_info(void) > } > } > fclose(f); > + > + /* Parse Logical Processor Information in SysFS */ > + { > + int coreflags = (cached_sci.FeatureSet & CPU_FEATURE_HTT) ? 1 : 0; > + int cpucount = 0, cachecount, nodecount, i; > + ULONG_PTR fullprocessormask = 0, processormask; > + Please don't do this. Don't create a block just so you can declare variables. Put variable declaration at the top of the outer block. > + while ((processormask = sysfs_cpu_topology_getmap(cpucount, "thread_siblings")) > 0) > + { > + /* Core information */ > + { > + /* Unique cores are found multiple times during iteration, add only once */ > + for (i = 0; i < (sizeof(cached_lpi) / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION)); i++) > + { ... > + } > + } ... > + } Same thing here. > +static int sysfs_cpucache_getint(int cpu, int cache, const char *type) > + /* Cache information */ > + cachecount = 0; > + while ((processormask = sysfs_cpucache_cpumap(cpucount, cachecount)) > 0) > + { > + /* Empty Processormasks are invalid, ignore them */ What does this comment refers too? If it's for the above while() condition, then please put comment above it, not inside the block. > + BYTE level = sysfs_cpucache_getint(cpucount, cachecount, "level"); > + BYTE associativity = sysfs_cpucache_getint(cpucount, cachecount, "ways_of_associativity"); > + WORD linesize = sysfs_cpucache_getint(cpucount, cachecount, "coherency_line_size"); > + DWORD size = sysfs_cpucache_getint(cpucount, cachecount, "size"); I've already told you before - do not mix signed and unsigned. If result of sysfs_cpucache_getint is always assigned to an unsigned variable then change it's return type to unsigned type too. > + /* Determine Cachetype */ > + if (typestring[0] == 'D') > + { > + type = CacheData; > + } > + else if (typestring[0] == 'I') > + { > + type = CacheInstruction; > + } > + else if (typestring[0] == 'U') > + { > + type = CacheUnified; > + } > + else if (typestring[0] == 'T') > + { > + type = CacheTrace; > + } Either use swith case construct here or use complete words and stricmp. > + if ((processormask = sysfs_numanode_cpumap(nodecount)) > 0) > + { > + /* Numa Nodes are already unique. just add them */ > + do > + { > + } > + while ((processormask = sysfs_numanode_cpumap(nodecount)) > 0); > + } > + else > + { > + } People already asked you not to do this. From looking at the code it appears that there is always one node. So get rid of everything except do{} while() block. It will do exactly what you want with extra if()s. Vitaliy.

2 5

Re: shlwapi: Skip more tests on too old shlwapi.dll.
by testbot＠testbot.winehq.org Oct. 10, 2010

Oct. 10, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6009 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1796: Test failed: got 13 ordinal.c:1832: Test failed: got 13 ordinal.c:1877: Test failed: got 23 ordinal.c:1888: Test failed: got 26 === W7PROX64 (32 bit ordinal) === ordinal.c:1796: Test failed: got 13 ordinal.c:1832: Test failed: got 13 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 10 ordinal.c:1789: Test failed: got 26 ordinal.c:1796: Test failed: got 13 ordinal.c:1804: Test failed: got 7 ordinal.c:1817: Test failed: got 10 ordinal.c:1825: Test failed: got 10 ordinal.c:1832: Test failed: got 13 ordinal.c:1839: Test failed: got 26 ordinal.c:1847: Test failed: got 26 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24

1 0

Re: cabinet/tests: Reformated output in case of test failure (try 2)
by Alexandre Julliard Oct. 9, 2010

Oct. 9, 2010

Marko Nikolic <grkoma(a)gmail.com> writes: > In case of test failure, expected and received values are traced. > Format for the two values was different, corrected so both values > are traced as hex. Error values are in general more useful in decimal. -- Alexandre Julliard julliard(a)winehq.org

2 1

Debugging 64-bit Wine Apps with winedbg
by Tom Grubbe Oct. 9, 2010

Oct. 9, 2010

Hello, we're the developers of a large 64-bit Windows application that uses Wine 1.3.0 64-bit on Linux. When testing began we discovered several crashes inside our windows code on startup and needed to debug them. But the problem seems to be getting any kind of stack trace information from the 64-bit winedbg. This used to work with the 32-bit version of winedbg. Even if I write a 64-bit "hello world" app that intentionally crashes I still can't get a clean stack trace from winedbg. We get a register dump and a stack dump but no back trace. So in our app, we have to resort to calculating the address of the crash in our DLLs using a MAP file and adding a bunch of printfs to try and locate the source of the SEGV. This is awkward, slow and just a bad way to debug. So here's my question - Has anyone had any luck getting a debugger stack trace using the 64-bit winedbg? Some relevant info: * We build wine 64-bit 1.3.0 ourselves * We're running on RHEL 5.5 (Tikanga) 2.6.18-194.el5 64-bit * We get the same non-results from both release and debug windows binaries * Using winedbg --gdb crashes gdb * We tried using msvsmon.exe to attach to and debug the wine process using Visual Studio but it hasn't been helpful * Setting WINEDEBUG to several debug channels has helped some but is difficult to sift through all the noise So any info on strategies to debug 64-bit Wine applications is welcome, or if you need more info I'll be glad to supply it. Thanks for your help! --Tom Grubbe ESRI

4 6

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 5)
by Alexandre Julliard Oct. 8, 2010

Oct. 8, 2010

Rudolf Mayerhofer <rm(a)eightyfive.net> writes: > +/*********************************************************************** > + * Several methods to retrieve data from SysFS (/sys) > + * used to retrieve cached_lpi in fill_cpu_info() > + */ > +static int sysfs_cpu_exists(int cpu) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d", cpu); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_cpucache_exists(int cpu, int cache) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/cache/index%d", cpu, cache); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_numanode_exists(int node) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/node/node%d", node); > + return access(buf, F_OK) == 0; > +} Don't do that sort of thing. You should handle failures to open the files at the point where you need them instead of doing redundant checks. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2 (try2)] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize
by Alexandre Julliard Oct. 8, 2010

Oct. 8, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > try2: Rebase on top of [1/2]. > > dlls/shlwapi/tests/url.c | 4 ++++ > dlls/shlwapi/url.c | 6 ++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok cryptnet.c:353: Test failed: File URLs not supported make: *** [cryptnet.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32: Avoid relying on PATH_MAX in import_certs_from_dir helper.
by Austin English Oct. 8, 2010

Oct. 8, 2010

On Thu, Oct 7, 2010 at 6:56 PM, Andrew Nguyen <anguyen(a)codeweavers.com> wrote: > > PATH_MAX is not guaranteed to be available on all platforms, and it is > inadequate as a hardcoded buffer size anyway. Also fixes the first compiler error on GNU Hurd. Thanks Andrew! -- -Austin

1 0

New winetricks 20101008: new verbs abiword, dsound, nvidiasdk9, vd, xinput
by Dan Kegel Oct. 8, 2010

Oct. 8, 2010

Another fortnight-and-a-half, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20100917: Austin English: - add dsound verb. (Issue 175) - add xinput verb - dxsdk_nov2006, add support for quiet install. - fix dotnet installs for wine 1.2 (broken in recent winetricks release) - introduce $appdata_win/$appdata_unix variables, use it for Safari - refuse to run in 64-bit WINEPREFIX's - remove deprecated pbuffer option - update eadm sha1sum - update flash sha1sums - update kde to 0.9.7-0 - update utorrent sha1sum/url Dan Kegel: - add nvidiasdk9 - remove bogus msvcr80 installed by dotnet20; fixes issue 164. - use symbolic variable uniformly in set_videomemorysize - add abiword, ie6_full - fix two spots WINETRICKS_TMP wasn't quoted; this broke WINEPREFIXes containing spaces. Reported by Roberto Neri. - add vd=1024x768, vd=off options. Fixes bug 172. Scott Ritchie: - new verb cjkfonts (individual verb names may still change) - Add Quicktime 7.6, update quicktimes to depend on vcrun2005 Erik Inge Bolsø - reenable mscoree after directx9 install; fixes issue 25.

3 2

Re: [4/4] msxml3/httprequest: Implement ::get_responseBody()
by testbot＠testbot.winehq.org Oct. 8, 2010

Oct. 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5972 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1

1 0

Re: [2/4] msxml3/httprequest: Implement ::abort()
by testbot＠testbot.winehq.org Oct. 8, 2010

Oct. 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5971 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1

1 0

Re: [PATCH 1/3] jscript: test that ActiveScriptSite_OnScriptError is called on script failure. (resend)
by Reece Dunn Oct. 7, 2010

Oct. 7, 2010

On 7 October 2010 14:35, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Reece, > > These tests need more thoughts. They should show how jscript exceptions are > translated into IActiveScriptError. Your code doesn't provide mechanism to > do so, so I would suggest to wait with sending patches that don't move us > any forward until you have a clue how it should work. Otherwise you will > have to deal with eventually bad decisions for no good reason. Ok, so if I keep the current tests/ActiveScriptSite as they are and have something like: test_script_error(source, scode, description, lineno, charpos, linesource) { EXPECT CALL ActiveScriptSite_OnScriptError hres = parse_script_with_error(source); ok(hres == 0x8012345, ...) CHECK CALL ActiveScriptSite_OnScriptError ok(script_excep.scode == scode, ...) ok(script_excep.bstrDescription == description, ...) ok(script_lineno == lineno, ...) ok(script_charpos == charpos, ...) ok(script_linesource == linesource, ...) } test_script_errors() { test_script_error("var foo = new Object();\nfoo.bar;", 0x8012345, "Object does not support this property", 20, 11, "foo.bar;") test_script_error("new <>%^^;", 0x8012322, "Syntax error", 0, 0, "new <>%^^;") ... } where parse_script_with_error does the same thing as parse_script, but uses an ActiveScriptSite implementation that checks OnScriptError calls and stores the IActiveScriptError object for testing within test_script_error (like with my 3rd patch, but checking specific values). 1/ Does this look like a sensible approach to you? 2/ Do we care about the tests working on non-English locales (not sure how to get the above working on other languages -- specifically the description text)? 3/ Are we ok with making wine match the error description strings exactly, given the above tests? NOTE: 2 and 3 can be avoided by just checking the scode and checking that the description is set and non-NULL (as per my 3rd patch). > Also merging parsing_htmlscript is not a good idea. Its purpose is different > than parse_script. Ok, I'll keep them separate. - Reece

2 1

Re: [PATCH 1/2] shlwapi/tests: Mark Win98 failures as broken
by Jacek Caban Oct. 7, 2010

Oct. 7, 2010

Hi Andrew, Can we please find a way to detect such old (broken) shlwapi and just skip the whole test (preferable all tests in the file)? Failing UrlGetPart would do the trick, hopefully there is better way. This will result in cleaner code and will save us time in future. Jacek

1 0

Re: ntdll: fix compile on systems without termios.port.c_ispeed/termios.port.c_ospeed structs
by Alexandre Julliard Oct. 7, 2010

Oct. 7, 2010

Austin English <austinenglish(a)gmail.com> writes: > @@ -498,7 +498,7 @@ static NTSTATUS set_baud_rate(int fd, const SERIAL_BAUD_RATE* sbr) > return STATUS_NOT_SUPPORTED; > #endif /* Don't have linux/serial.h or lack TIOCSSERIAL */ > } > -#elif !defined(__EMX__) > +#elif !defined(__EMX__) && defined (_HAVE_STRUCT_TERMIOS_C_ISPEED) && defined (_HAVE_STRUCT_TERMIOS_C_OSPEED) > switch (sbr->BaudRate) > { > case 0: port.c_ospeed = B0; break; You'd want to use the cflag method in this case. Which platform needs this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Mentor summit for Google Summer of Code - time sensitive
by Jeremy White Oct. 7, 2010

Oct. 7, 2010

As a heads up, Bradley reminds me that the Mentor summit for GSOC: http://gsoc-wiki.osuosl.org/index.php/2010 is coming up; the registration deadline is tomorrow. Google may reimburse travel expenses, so if cost is an issue, we may be able to help with that. If you need such help, let me know, and I'll connect you with Bradley. Cheers, Jeremy

1 0

Re: [6/6]strmbase: Implement BaseFilter in strmbase
by Alexandre Julliard Oct. 7, 2010

Oct. 7, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/vfwcapture.c | 134 +++++-------------------- > dlls/quartz/acmwrapper.c | 20 ++-- > dlls/quartz/avidec.c | 12 +- > dlls/quartz/avisplit.c | 6 +- > dlls/quartz/dsoundrender.c | 223 > ++++++++++++------------------------------- > dlls/quartz/filesource.c | 129 +++++-------------------- > dlls/quartz/mpegsplit.c | 4 +- > dlls/quartz/nullrenderer.c | 177 ++++++++-------------------------- > dlls/quartz/parser.c | 156 ++++++++++-------------------- > dlls/quartz/parser.h | 9 +-- > dlls/quartz/transform.c | 201 ++++++++------------------------------- > dlls/quartz/transform.h | 10 +-- > dlls/quartz/videorenderer.c | 226 > +++++++++++++------------------------------ > dlls/quartz/waveparser.c | 4 +- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/filter.c | 158 ++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 23 +++++ > 17 files changed, 517 insertions(+), 976 deletions(-) > create mode 100644 dlls/strmbase/filter.c I'm seeing occasional crashes in the qedit:mediadet test with this patch. Unfortunately the debugger fails to get a backtrace. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wine_call_on_stack Sparc Edition
by André Hentschel Oct. 7, 2010

Oct. 7, 2010

Oops, wrong address, sry for the noise -- Best Regards, André Hentschel

1 0

Re: psapi/tests: get rid of an ugly test macro
by testbot＠testbot.winehq.org Oct. 7, 2010

Oct. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=108

1 0

Re: [PATCH] d3d9/tests: Fix test failure for IDirect3D9::CreateDevice in test_set_stream_source
by testbot＠testbot.winehq.org Oct. 7, 2010

Oct. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === W2K8SE (32 bit device) === device.c:2474: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2612: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (32 bit device) === device.c:2474: Test failed: Expected foreground window 0002019A, got 00010092. device.c:2612: Test failed: Expected foreground window 0003019A, got 00010092.

1 0

Re: usp10: when checking font for shaping the font needs at least 1 of the features but does not need all.
by Dmitry Timoshkov Oct. 7, 2010

Oct. 7, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > - while (ShapingData[psa->eScript].requiredFeatures[i]) > + while (ShapingData[psa->eScript].requiredFeatures[i] && !found) > { > feature = load_GSUB_feature(hdc, psa, psc, ShapingData[psa->eScript].requiredFeatures[i]); > - if (!feature) > - return USP_E_SCRIPT_NOT_IN_FONT; > + if (feature) > + found = TRUE; Why not return S_OK right away here, and return USP_E_SCRIPT_NOT_IN_FONT right after the while loop? That would eliminate a need for an intermediate variable and simplify the code. -- Dmitry.

1 0

Test failures on Windows XP Japanese due to fonts selection differences
by Austin Lund Oct. 7, 2010

Oct. 7, 2010

There are a number of test failures due to hardcoded sizes in test which fail for particular platforms, e.g. http://test.winehq.org/data/6e89a61446088dbe029913896dfae467bb8d37a1/xp_wtb… It seems the reason for this is that it is impossible to select the system font with height 16 on this platform. (No idea why, any ideas?) Should these tests be written so that a particular font selection is forced across platforms (e.g. ANSI, 16 point, System), or should the hardcoded values instead be computed for each particular instance?

1 0

New version of exe-thumbnailer (0.7)
by Scott Ritchie Oct. 7, 2010

Oct. 7, 2010

Includes much prettier icons, support for Vista icons (with icoutils 0.29.1) and more. Screenshots and a description are at: http://wiki.winehq.org/exe-thumbnailer -Scott Ritchie

4 6

Re: [PATCH 06/10] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org Oct. 7, 2010

Oct. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5914 Your paranoid android. === W2K8SE (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL === W7PROX64 (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL

1 0

Translation patches for wine-1.2.1
by Michael Stefaniuc Oct. 6, 2010

Oct. 6, 2010

Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't produce conflicts. Though the removal of the unneeded "Remove the ignored common resource attributes" patches makes "wrc --verify-translation" produce DIFF lines for resources that were added at a later time as those don't have the ignored common resource attributes. bye michael

2 2

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 20 +++++++++++++++++--- > 1 files changed, 17 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmllocation.c && touch htmllocation.ok wine: Unhandled page fault on read access to 0x00000110 at address 0x555d325a (thread 001f), starting debugger... Unhandled exception: page fault on read access to 0x00000110 in 32-bit code (0x555d325a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555d325a ESP:0032dfd0 EBP:0032e038 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00ed2bf4 EBX:5561bc84 ECX:002078c0 EDX:555d31c0 ESI:0126f400 EDI:00000000 Stack dump: 0x0032dfd0: 00ed2b98 0032e3a8 0032e008 6ad698bc 0x0032dfe0: 002078b0 00000001 00000001 0032e078 0x0032dff0: 6adbe4f5 002078b0 0032e018 00000000 0x0032e000: 002078b0 6b127f9c 0032e028 6ad697d8 0x0032e010: 002078b0 0032e074 00000001 00000000 0x0032e020: 002078a8 0032e074 0032e068 012ad758 Backtrace: =>0 0x555d325a handle_load+0x9a(iface=0x126f5c0, event=0x12ad758) [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml (0x0032e158) 1 0x6a02f1db in xul (+0x3ef1da) (0x0032e1d8) 2 0x6aca1e00 in xul (+0x1061dff) (0x0032e208) 3 0x6aca1fe1 in xul (+0x1061fe0) (0x0032e258) 4 0x6a047958 in xul (+0x407957) (0x0032e2a8) 5 0x6a04819c in xul (+0x40819b) (0x0032e378) 6 0x69dc9c12 in xul (+0x189c11) (0x0032e408) 7 0x6a53d3a0 in xul (+0x8fd39f) (0x0032e698) 8 0x6a53ced6 in xul (+0x8fced5) (0x0032e718) 9 0x6a5574c8 in xul (+0x9174c7) (0x0032e768) 10 0x6a556567 in xul (+0x916566) (0x0032e798) 11 0x6a556371 in xul (+0x916370) (0x0032e7e8) 12 0x6a555fa2 in xul (+0x915fa1) (0x0032e858) 13 0x69c66091 in xul (+0x26090) (0x0032e898) 14 0x555cbc1b on_stop_nsrequest+0x8a(This=0xed4da0, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8d8) 15 0x555cbc1b on_stop_nsrequest+0x8a(This=0x10, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8e8) 16 0x555cca5f nsChannelBSC_stop_binding+0x1e(bsc=0x126fe08, result=0x555d31c0) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1184] in mshtml (0x0032e928) 17 0x555cb126 BindStatusCallback_OnStopBinding+0x35(iface=0x126fe08, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:360] in mshtml (0x0032e968) 18 0x68f3f838 BindStatusCallback_OnStopBinding+0x87(iface=0x129b090, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindctx.c:178] in urlmon (0x0032e988) 19 0x68f40c5d stop_binding+0x3c(binding=0x129b118, hres=0xffffffff80004004, str=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:221] in urlmon (0x0032e9d8) 20 0x68f41dde InternetProtocolSink_ReportResult+0x8d(iface=0x129b11c, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1149] in urlmon (0x0032ea28) 21 0x68f47abd BPInternetProtocolSink_ReportResult+0xec(iface=0x129b578, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:1184] in urlmon (0x0032ea48) 22 0x68f50b5d report_result+0x3c() in urlmon (0x0032ea58) 23 0x68f50c1d protocol_abort+0x2c(protocol=0x2078c0, reason=0xffffffff80004004) [/home/julliard/wine/wine/dlls/urlmon/protocol.c:439] in urlmon (0x0032ea98) 24 0x68f4cbd4 HttpProtocol_Abort+0x73(iface=0x129b764, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/http.c:445] in urlmon (0x0032eae8) 25 0x68f452b0 ProtocolHandler_Abort+0x5f(iface=0x129b580, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:662] in urlmon (0x0032eb38) 26 0x68f459db BindProtocol_Abort+0x7a(iface=0x129b568, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:429] in urlmon (0x0032eb68) 27 0x68f4140b Binding_Abort+0x5a(iface=0x129b118) [/home/julliard/wine/wine/dlls/urlmon/binding.c:892] in urlmon (0x0032eb88) 28 0x555ca834 set_window_bscallback+0x23(window=0xed2b98, callback=(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1349] in mshtml (0x0032ebd8) 29 0x555c54a1 HTMLWindow2_Release+0x70(iface=0xed2ba8) [/home/julliard/wine/wine/dlls/mshtml/htmlwindow.c:228] in mshtml (0x0032ec18) 30 0x55580881 CustomDoc_Release+0x80(iface=0x129db0) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2021] in mshtml (0x0032ec38) 31 0x5557ea04 HTMLDocument_Release+0x13(iface=0x129ca8) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:376] in mshtml (0x0032fd08) 32 0x686a82f5 perform_test+0xd34(test=0x686c24c3) [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:348] in mshtml_test (0x0032fd38) 33 0x686a838e func_htmllocation+0x3d() [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:360] in mshtml_test (0x0032fd88) 34 0x686b535e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe48) 35 0x686b5557 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:624] in mshtml_test (0x0032fe90) 36 0x686b60dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fea8) 37 0x7b856c4c call_process_entry+0xb() in kernel32 (0x0032fee8) 38 0x7b85914b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 39 0x7bc72b80 call_thread_func+0xb() in ntdll (0x0032ffc8) 40 0x7bc72d50 call_thread_entry_point+0x6f(entry=0x7b8590f0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 41 0x7bc4da6a start_process+0x29(kernel_start=0x7b8590f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x555d325a handle_load+0x9a [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml: movl 0x110(%edi),%eax 226 if(doc_obj->nscontainer->editor_controller) { -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cryptui: Fix a crash with certification path (resend)
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) > */ > tvis.u.item.iImage = 2; > } > - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. > - dwErrorStatus == 0) > + else if (i > 1 && > + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) What is this change for? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The bug #20129 lists one of such applications. > > It does FindWindow("Shell_TrayWnd", "") and expects that it returns a valid > tray window handle. Currently FindWindow() is broken, but my next patch makes > the above call succeed. This will cause the stand-alone tray window to not have a title, that doesn't look nice. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: cryptui: Fix a crash with certification path
by Juan Lang Oct. 6, 2010

Oct. 6, 2010

Hi André, I see your patch didn't get committed. In case it's waiting for a comment from me, it looks fine: I assume you've imported a certificate that isn't otherwise trusted, and viewing it results in a crash? I don't see the crash here. Thanks, --Juan

2 1

Re: [7/7] msi/tests: Fix some test failures on 64-bit.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5900 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10500: Test failed: key not created

1 0

Re: [2/6]strmbase: move enumpins from quartz to strmbase
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/Makefile.in | 1 - > dlls/qcap/enumpins.c | 186 ------------------------------------- > dlls/qcap/qcap_main.h | 8 -- > dlls/qcap/vfwcapture.c | 28 +++++- > dlls/quartz/Makefile.in | 1 - > dlls/quartz/dsoundrender.c | 26 ++++-- > dlls/quartz/enumpins.c | 211 > ------------------------------------------ > dlls/quartz/filesource.c | 32 +++++-- > dlls/quartz/nullrenderer.c | 25 +++-- > dlls/quartz/parser.c | 29 ++++-- > dlls/quartz/quartz_private.h | 3 - > dlls/quartz/transform.c | 27 ++++-- > dlls/quartz/videorenderer.c | 25 +++-- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/enumpins.c | 207 > +++++++++++++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 6 + > 16 files changed, 346 insertions(+), 470 deletions(-) > delete mode 100644 dlls/qcap/enumpins.c > delete mode 100644 dlls/quartz/enumpins.c > create mode 100644 dlls/strmbase/enumpins.c It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so avisplitter.c && touch avisplitter.ok avisplitter.c:164: Test failed: pins[1] = (nil) avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test make: *** [avisplitter.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/7] msi: Use strcmpW instead of lstrcmpW to compare database strings.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Hans Leidekker <hans(a)codeweavers.com> writes: > An installer I have here uses \1 and \2 as delimiters in property strings. > It turns out that on Wine lstrcmp("\1", "\2") returns 0, not -1, which causes > the string table implementation to return the wrong value. This should be fixed, > but it's better if database string comparisons do not depend on thread locale. Yes, but isn't it supposed to follow Unicode sorting rules instead of simply comparing code point values? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/7] msi: Add package validation tests.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5898 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10164: Test failed: key not removed install.c:10174: Test failed: key not removed install.c:10185: Test failed: key not removed install.c:10476: Test failed: key not created

1 0

Re: [PATCH 9/9] urlmon: Added IInternetProtocolEx support to http protocol handler.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5895 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:977: Test failed: hrResult = 800c0005, expected: 00000000 Timeout

1 0

Re: [PATCH 6/9] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5893 Your paranoid android. === WXPPROSP3 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K3R2SESP2 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === WVISTAADM (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K8SE (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PRO (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (64 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable

1 0

Re: [PATCH 1/9] urlmon: Return correct error in get_protocol_handler for unknown protocol types.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5892 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:459: Test failed: expected ReportProgress_SENDINGREQUEST

1 0

Re: [PATCH 3/3] d3d9/tests: Add window proc tests for switching between fullscreen and windowed.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5888 Your paranoid android. === W2K8SE (32 bit device) === device.c:2473: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2611: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (64 bit device) === device.c:2473: Test failed: Expected foreground window 0000000000020198, got 0000000000010092. device.c:2611: Test failed: Expected foreground window 0000000000030198, got 0000000000010092.

1 0

Re: [1/5] mscoree: Implement ICLRMetaHost_GetRuntime.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This will cause the tests to fail if Mono is not available. We'll have to start providing a Mono package then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32(10/10): Set correct error when encountering unsupported critical extensions in the base and SSL policy
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5874 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)
by Mike Kaplinskiy Oct. 6, 2010

Oct. 6, 2010

There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }". More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <rm(a)eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >

1 0

Re: crypt32/tests(8/10): Add macros to declare tests
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5873 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(7/10): Add name to test to help identify test failures
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5872 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32(6/10): Set CERT_TRUST_HAS_NOT_SUPPORTED_CRITICAL_EXT when appropriate
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5871 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(5/10): Test the base and SSL policies against a certificate with an invalid critical extension
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5870 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(4/10): Test invalid critical extension in intermediate cert
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5869 Your paranoid android. === W98SE (32 bit chain) === chain.c:4108: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2

1 0

Re: crypt32(2/10): Improve error checking for the base policy
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5868 Your paranoid android. === W98SE (32 bit chain) === chain.c:4015: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0

Re: crypt32/tests(1/10): Add more tests of verifying the base policy, including flags to ignore certain errors
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5867 Your paranoid android. === W98SE (32 bit chain) === chain.c:4012: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0

Re: (6th try) winhlp32: Added Hebrew translation
by Paul Vriens Oct. 5, 2010

Oct. 5, 2010

Hi Yaron, I'm see this one is still not applied. Maybe because there are still some small issues? See below. On 10/03/2010 11:12 PM, Yaron Shahrabani wrote: > +LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT This line should go, it's redundant (it's already stated at the beginning). This line was present in the English resources because there is a difference between SUBLANG_DEFAULT and SUBLANG_NEUTRAL in that resource file. For example 'colors' vs. 'colours'. > + > +IDD_INDEX DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU | WS_EX_LAYOUTRTL You should move the WS_EX_LAYOUTRTL to an EXSTYLE like the IDD_SEARCH_DIALOG below. Adding it to the STYLE has no effect. > +FONT 8, "MS Shell Dlg" > +CAPTION "מפתח" > +{ > + LISTBOX IDC_INDEXLIST, 10, 10, 180, 150, LBS_NOINTEGRALHEIGHT | WS_VSCROLL | WS_BORDER > +} > + > +IDD_SEARCH DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" -- Cheers, Paul.

1 0

Re: user32/tests: Test FindWindowEx for empty window title (try 2)
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5829 Your paranoid android. === W98SE (32 bit win) === win.c:2970: Test failed: message 000f available win.c:2982: Test failed: message 000f available win.c:2991: Test failed: message 000f available win.c:3000: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5828 Your paranoid android. === W98SE (32 bit url) === url.c:746: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 46

1 0

winmm/tests: Don't test the non-default Midi devices if the 'PreferredOnly' Windows setting is set.
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 5, 2010

Oct. 5, 2010

Hi, a few month ago when the discussion about "PreferredOnly" registry setting came up, I queried Google and found that many more users use this setting than one may believe - i.e. it is not exotic. Therefore, I don't think it's that great an idea to reduce the number of devices that the tests stress using that method: we'll get less feedback from a number of real machines. OTOH, I have no solution to the vmware MIDI trouble on Francois' machines. Regards, Jörg Höhle

1 0

Re: msi: Put the uninstall key for 32-bit packages under Wow6432Node on 64-bit.
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5824 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10427: Test failed: key not created

2 1

Re: [2/3] kernel32/process: Implement GetLogicalProcessorInformation using NtQuerySystemInformation
by Vitaliy Margolen Oct. 5, 2010

Oct. 5, 2010

On 10/05/2010 04:46 AM, Rudolf Mayerhofer wrote: > --- > dlls/kernel32/process.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > Please exchange patches 2 and 3. And everywhere in your patches, please stick to _THE SAME_ formatting as the rest of the file you editing. Examples: > + if (status != STATUS_SUCCESS) > + { > + if( status == STATUS_INFO_LENGTH_MISMATCH ) Here you adding 2 differently formatted if () statements. > +static ULONG_PTR sysfs_cpu_topology_getmap(int cpu, const char *type) > +{ > + char buf[256]; > + FILE *fd; > + ULONG_PTR result; > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/topology/%s",cpu,type); Please add empty line between variable declarations and the rest of the code. All commas should always be followed by a space. > + fd = fopen(buf,"r"); > + if(fscanf(fd,"%lx",&result) != 1) You are not checking if fopen() succeeded. > +static int sysfs_cpucache_getint(int cpu, int cache, const char *type) > +{ > + }else{ > + val = -1; > + } > + fclose(fd); > + return val; > +} > ... > + BYTE level = sysfs_cpucache_getint(cpucount,cachecount,"level"); Don't mix signed and unsigned integers. Especially that you return -1 in case of error. In that entire file curly braces go on a separate line. Vitaliy.

1 0

[1/2] user32: fix FindWindowEx behavior if window name is an empty charachter
by Louis Lenders Oct. 5, 2010

Oct. 5, 2010

>It would be better to avoid duplicate GetWindowTextW() calls. I thought a long time how to fix this, but i couldn't find another way than this one, because we need to find out whether or not the window title is empty, and afaik we can only do that by calling GetWindowText (again). If you have another way that i overlooked, please let me know Regards Louis

3 2

Re: winex11: Add support for animated cursors in X11 driver (try 5).
by Alexandre Julliard Oct. 5, 2010

Oct. 5, 2010

Erich Hoover <ehoover(a)mines.edu> writes: > + imgs[nFrames++] = image; > + if (!(imgstmp = HeapReAlloc( GetProcessHeap(), 0, imgs, nFrames*sizeof(XcursorImage*) ))) goto cleanup; > + imgs = imgstmp; This is still broken. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ImmReleaseContext() function implementation
by Aric Stewart Oct. 5, 2010

Oct. 5, 2010

I do not believe this is correct. You would be destroying the context every time it is released and that is clearly not what we want to be doing ass ImmGetContext and ImmReleaseContext as a pair are called over and over again in a typical application. -aric On 10/4/10 1:25 PM, Mikhail Gorbunov wrote: > This patch implements (with a basic sanity check) a behaviour of > ImmReleaseContext() > function as described in msdn and in the way ImmGetContext() has already been > impleneted. > > From 56f78bcd9584350b456ca0b0514a357b7ee8cdfd Mon Sep 17 00:00:00 2001 > From: Mikhail Gorbunov<mikhail.gorbunov(a)gmail.com> > Date: Mon, 4 Oct 2010 21:47:17 +0400 > Subject: [PATCH] ImmReleaseContext() function implementation > > --- > dlls/imm32/imm.c | 24 ++++++++++++++++++------ > 1 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 28f482c..87b4c14 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -2009,13 +2009,25 @@ BOOL WINAPI ImmRegisterWordW( > */ > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { > - static int shown = 0; > + TRACE("(%p, %p)\n", hWnd, hIMC); > > - if (!shown) { > - FIXME("(%p, %p): stub\n", hWnd, hIMC); > - shown = 1; > - } > - return TRUE; > + if (hIMC) > + { > + InputContextData *data = hIMC; > + > + if (data->IMC.hWnd != hWnd) > + { > + FIXME("(%p, %p): data->IMC.hWnd = %p :: err\n", > + hWnd, hIMC, data->IMC.hWnd); > + return TRUE; > + } > + else > + { > + return ImmDestroyContext(hIMC); > + } > + } > + else > + return TRUE; > } > > /***********************************************************************

1 0

Re: [PATCH 1/6] urlmon: Report error on synchronous bindings that don't have a cache file and are not read in callback.
by Alexandre Julliard Oct. 5, 2010

Oct. 5, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) This breaks the gameux tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)
by Rudolf Mayerhofer Oct. 5, 2010

Oct. 5, 2010

>I don't know much about kernel32/ntdll, but I'm pretty sure that you >could get this to work through ntdll. NtQuerySystemInformation with >SystemProcessorInformation/SystemLogicalProcessorInformation (see >http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Syste…) >should help. http://native-nt-toolkit.googlecode.com/svn/trunk/ndk/extypes.h >(read, don't copy) seems to have a pretty exhaustive set of >definitions, but even that's not complete. Some tests for the NT >version would be useful. > >Mike. SystemLogicalProcessorInformation seems to be the right SystemClass for NtQuerySystemInformation. But here's the Problem. I don't have any idea how i could any information about the struct returned by calling NtQuerySystemInformation with SystemLogicalProcessorInformation (= 73). The only windows machine i have access to a the moment keeps throwing status 0xC0000005 (ACCESS_VIOLATION) at me which doesn't help at all and i'm pretty much stuck right now. If i could get my hands on the struct returned by NtQuerySystemInformation it should be easy to change the patch to do the parsing in ntdll and just call that from kernel32.

2 2

Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter
by Dmitry Timoshkov Oct. 5, 2010

Oct. 5, 2010

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -1756,6 +1756,10 @@ HWND WINAPI FindWindowExW( HWND parent, HWND child, LPCWSTR className, LPCWSTR t > { > while (list[i]) > { > + /* Handle special case where empty title bar or no title bar exists, so GetWindowsText would return NULL > + but if title is also an empty char we still have a match */ > + if (!GetWindowTextW( list[i], buffer, len + 1 ) && !title[0]) break; > + > if (GetWindowTextW( list[i], buffer, len + 1 ) && !strcmpiW( buffer, title )) break; > i++; > } It would be better to avoid duplicate GetWindowTextW() calls. -- Dmitry.

1 0

Re: psapi/tests: macro cleanup
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5813 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=108

1 0

Re: [PATCH] comctl32/tests: Add tests for negative subitems independent of local settings
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5811 Your paranoid android. === W7PROX64 (64 bit listview) === listview.c:4449: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4454: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: [2/2] user32/tests: Test FindWindowEx for empty window title
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5803 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH 2/3] urlmon: Added Abort tests.
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:824: Test failed: hrResult = 800c0005, expected: 00000000 Timeout === WVISTAADM (32 bit protocol) === protocol.c:509: Test failed: unexpected call Switch

1 0

Re: [PATCH 3/3] urlmon: Added Abort support to BindProtocol.
by testbot＠testbot.winehq.org Oct. 5, 2010

Oct. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5783 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: include: Added d3d10_1.idl.
by Rico Schüller Oct. 4, 2010

Oct. 4, 2010

Am 02.10.2010 15:29, schrieb Jacek Caban: +typedef enum D3D10_SRV_DIMENSION1 +{ + D3D10_1_SRV_DIMENSION_UNKNOWN = 0, ... + D3D10_1_SRV_DIMENSION_TEXTURECUBE = 9, + D3D10_1_SRV_DIMENSION_TEXTURECUBEARRAY = 10 +} D3D10_SRV_DIMENSION1; You probably might add those to d3dcommon.h and only add a typedef. It was changed in one of the sdks. Cheers Rico

2 2

Re: winspool.drv: return maximum possible size of the buffer when no buffer specified
by Alexandre Julliard Oct. 4, 2010

Oct. 4, 2010

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -1398,7 +1398,7 @@ static void convert_printerinfo_W_to_A(LPBYTE out, LPBYTE pPrintersW, > dmA = DEVMODEdupWtoA(piW->pDevMode); > if (dmA) { > /* align DEVMODEA to a DWORD boundary */ > - len = (4 - ( (DWORD_PTR) ptr & 3)) & 3; > + len = ptr ? (4 - ( (DWORD_PTR) ptr & 3)) & 3 : 3; That doesn't make any sense. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: psapi/tests: remove an ugly macro
by testbot＠testbot.winehq.org Oct. 4, 2010

Oct. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=108

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try2]
by Alexandre Julliard Oct. 4, 2010

Oct. 4, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > -(a)pwd@>echo Tests for cmd's builtin commands(a)todo_space@ > +(a)pwd@>echo Tests for cmd's builtin commands You'll need to define a @space@ symbol, normal trailing spaces will get mangled. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: choose header exclusiv
by Alexandre Julliard Oct. 4, 2010

Oct. 4, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -29,8 +29,7 @@ > > #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H > #include <X11/extensions/xf86vmode.h> > -#endif > -#ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H) > #include <X11/extensions/xf86vmproto.h> > #endif This doesn't make sense, all it will most likely achieve is to disable the gamma support. -- Alexandre Julliard julliard(a)winehq.org

1 0

mono packaging, for wine packagers or anyone else who wants to follow along
by Vincent Povirk Oct. 4, 2010

Oct. 4, 2010

Buried in the 1.3.4 announcement is a tiny, insignificant little change that makes it possible for distributors to package Mono for Wine: mscoree: Search for Mono in some predefined paths before using the registry. As happy as I am to have sneaked this in under the radar, as it were, I guess I'm going to have to tell someone if it's ever going to be useful. I have no plans to make an official Wine Mono distribution. It should be easy enough for anyone to build. We currently do not require any changes in Mono for use with Wine. When we do (and it will be soon), I will try very hard to get the things we need merged upstream. Any managed libraries we need instead of or in addition to those shipped with Mono will have to go in Wine. We don't need a fork yet, and I hope we can keep it that way. Mono installs are generally self-contained and do not interfere with each other. Mono does not have to be installed into a bottle before it can be used. Therefore, I have not programmed any sort of install process into Wine. It will simply search for Mono as needed. If you are a distributor, here is how I recommend you distribute Mono for use with Wine: Download and extract the mono 2.6.7 source tarball from http://ftp.novell.com/pub/mono/sources/mono/mono-2.6.7.tar.bz2 Use the instructions at http://wiki.winehq.org/Mono to cross-compile Mono 2.6.7 using mingw32. Tweak the script if you have to (or just want to), but consider contributing any fixes you have to make back to winezeug. This will create a directory named mono-2.6.7. The contents of that directory should be installed to /usr/share/mono/mono-1.0. To make sure this worked, you should try a simple "Hello World" .NET application in Wine. Wikipedia has an example at https://secure.wikimedia.org/wikipedia/en/wiki/C_sharp_programming_language… that you should be able to save as a .cs file and compile to a .exe file using gmcs. If all is well, you should be able to run that exe file in a clean Wine prefix. In the future, we'll need a mono-2.0 directory as well, so we can keep using newer versions of Mono and get .NET 4.0 support. But we're not there yet. In case all these numbers have not confused you yet, the current version of Mono is 2.6.7. This version uses the Mono Embedding API version 1.0, which is why it needs to be placed in a directory named mono-1.0. It normally includes .NET 1.1 and 2.0 runtimes. It can optionally be compiled with a 4.0 runtime as well, but I don't recommend it. I'm expecting to see Mono 2.8 released "soon". That version will use the Embedding API version 2.0, which Wine can't support yet, but when the time comes it will need to be in a directory named mono-2.0. It will include .NET 2.0 and 4.0 runtimes. .NET 3.0 and 3.5 are not runtimes, which is why they were not included in that list. They use the .NET 2.0 runtime. While Mono 2.8 (and eventually 3.0) is the way forward for .NET 2.0 and 4.0 support, we'll need to also have the 2.6 series available so that we can have a .NET 1.1 runtime. Wine will detect which versions are available and what runtimes they have using a system that I'm working on and hope to have ready "soon", and it will select the correct runtime for whatever it's trying to run, or whatever the program selects using the .NET embedding API. (Also coming soon: the .NET embedding API.) I'm treating Mono as an optional dependency, much like the many native libraries Wine already uses. If it's not there, Wine will gracefully report failure to applications that try to use it, which probably won't work, and print some things to the console. I plan to send some changes soon that happen to cause a Wine without Mono to fail some tests, so I do consider an install that's missing Mono to be broken. But for the most part, the user experience will remain the same as it was before if Mono is missing.

2 1

Question on use of TextMetricsW
by James McKenzie Oct. 4, 2010

Oct. 4, 2010

All: I am running code like the following in a richedit control to set the font to Courier 12 point font: + static const WCHAR courier[] = {'C','o','u','r','i','e','r',0}; + testFont1 = CreateFontW (12,0,0,0,FW_LIGHT, 0, 0, 0, ANSI_CHARSET, + OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH | + FF_DONTCARE, courier); + + /*Set test font to be Courier font */ + SendMessageW(hwndRichEdit, WM_SETFONT, (WPARAM)testFont1, MAKELPARAM(TRUE, 0)); + /*Verify font is set */ + SendMessageW(hwndRichEdit, EM_GETCHARFORMAT, SCF_DEFAULT, (LPARAM) &CharFont1Unicode); + GetObjectW(testFont1, sizeof(LOGFONTW), &sentLogFont); + ok (!lstrcmpW(sentLogFont.lfFaceName, CharFont1Unicode.szFaceName), "WM_SETFONT set wrong font. " \ + "Font was set to %s or %s, was supposed to be \"Courier\".\n", wine_dbgstr_w(CharFont1Unicode.szFaceName), wine_dbgstr_w(sentLogFont.lfFaceName)); + + ret = GetTextMetricsW (hdc, &tmw); + ok (ret, "GetTextMetricsW failed\n"); + + ok (7 == tmw.tmAveCharWidth, "Average Character Width for Courier 12 is %d\n", tmw.tmAveCharWidth); I also set the font to MS Sans Serif, and two different font sizes for Arial. However, the tmAveCharWidth value remains at 7 and I am of the opinion that this should change for each font change and also for the font size change. Am I doing something improper? Should I clear the tmw structure between calls to GetTextMetricsW? When I run this on native WindowsXP (which I have access to) the average character width changes to 9, but remains the same for all four font types. TTIA. James McKenzie

2 3

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)
by Mike Kaplinskiy Oct. 3, 2010

Oct. 3, 2010

On Sun, Oct 3, 2010 at 10:25 AM, Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: >>A rewrite of my previously sent patches in order to avoid changing >>SYSTEM_CPU_INFORMATION. > >>This patch supersedes my previously sent patches: >>[PATCH1/3] include/winternl: Add Logical Processor Information to >>SYSTEM_CPU_INFORMATION (try 3) >>[PATCH2/3] kernel32/process: Implement GetLogicalProcessorInformation() (try > 2) >>[PATCH3/3] ntdll: Retrieve Logical Processor Information from SysFS (try 4) > > Try 2 removes a FIXME which is not needed. > Try 3 changes a FIXME to a WARN when an unknown cache type is found > > > --- > dlls/kernel32/process.c | 272 > ++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 270 insertions(+), 2 deletions(-) > > > > > I don't know much about kernel32/ntdll, but I'm pretty sure that you could get this to work through ntdll. NtQuerySystemInformation with SystemProcessorInformation/SystemLogicalProcessorInformation (see http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Syste…) should help. http://native-nt-toolkit.googlecode.com/svn/trunk/ndk/extypes.h (read, don't copy) seems to have a pretty exhaustive set of definitions, but even that's not complete. Some tests for the NT version would be useful. Mike.

1 0

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by Greg Geldorp Oct. 3, 2010

Oct. 3, 2010

> While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=5753 > > Your paranoid android. > > === WINEBUILD (build) === > Make in include dir failed Caused by a problem in TestBot, should be fixed now. Greg.

1 0

Re: [5/5] mscoree: Add a test that enumerates .NET runtimes.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5754 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5753 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: (5th try) winhlp32: Added Hebrew translation
by Paul Vriens Oct. 3, 2010

Oct. 3, 2010

On 10/03/2010 05:04 PM, Yaron Shahrabani wrote: > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + Hi Yaron, This piece should go. And I still have an apply warning for your Makefile.in patch. -- Cheers, Paul.

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line
by Jacek Caban Oct. 3, 2010

Oct. 3, 2010

On 10/3/10 1:18 PM, Alexandre Goujon wrote: > --- > programs/cmd/tests/batch.c | 2 +- > programs/cmd/wcmdmain.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batch.c > index cc8c020..d7a5e84 100644 > --- a/programs/cmd/tests/batch.c > +++ b/programs/cmd/tests/batch.c > @@ -131,7 +131,7 @@ static const char *compare_line(const char *out_line, const char *out_end, const > }else if(exp_ptr+sizeof(todo_space_cmd)<= exp_end > && !memcmp(exp_ptr, todo_space_cmd, sizeof(todo_space_cmd))) { > exp_ptr += sizeof(todo_space_cmd); > - todo_wine ok(*out_ptr == ' ', "expected space\n"); > + ok(*out_ptr == ' ', "expected space\n"); @todo_space@ is meant to do tests in todo_wine block. You should change @todo_space@ to spec in .exp file instead. If we're convinced that the whole keyword is not useful anymore, the whole handling code should be removed (although I think we'd better keep it). > if(out_ptr< out_end&& *out_ptr == ' ') > out_ptr++; > continue; > diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c > index b50512e..247457a 100644 > --- a/programs/cmd/wcmdmain.c > +++ b/programs/cmd/wcmdmain.c > @@ -1779,8 +1779,11 @@ WCHAR *WCMD_ReadAndParseLine(WCHAR *optionalcmd, CMD_LIST **output, HANDLE readF > if (context) handleExpansion(extraSpace, FALSE, NULL, NULL); > /* Show prompt before batch line IF echo is on and in batch program */ > if (context&& echo_mode&& extraSpace[0]&& (extraSpace[0] != '@')) { > + const WCHAR spc[] = {' ','\0'}; > WCMD_show_prompt(); > WCMD_output_asis(extraSpace); > + /* I don't know why Windows puts a space here but it does */ > + WCMD_output_asis(spc); More tests would be nice. Jacek

2 1

Re: [PATCH1/3] include/winternl: Add Logical Processor Information to SYSTEM_CPU_INFORMATION
by Dmitry Timoshkov Oct. 3, 2010

Oct. 3, 2010

Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: > /* System Information Class 0x01 */ > +typedef struct _SYSTEM_CPU_CACHE_INFORMATION { > + ULONG ProcessorMask; > + CACHE_DESCRIPTOR CacheInformation; > +} SYSTEM_CPU_CACHE_INFORMATION, *PSYSTEM_CPU_CACHE_INFORMATION; > > typedef struct _SYSTEM_CPU_INFORMATION { > WORD Architecture; > @@ -1100,6 +1104,10 @@ typedef struct _SYSTEM_CPU_INFORMATION { > WORD Revision; /* combination of CPU model and stepping */ > WORD Reserved; /* always zero */ > DWORD FeatureSet; /* see bit flags below */ > + ULONG Cores[64]; /* Contains a Processormask for each physical core. Index is CoreID*/ > + ULONG ProcessorPackages[64]; /* Contains a Processormask for each processorpackage. Index is ProcessorPackage ID*/ > + ULONG NumaNodes[64]; /* Contains a Processormask for each numa node. Index is NumaNodeNumber */ > + SYSTEM_CPU_CACHE_INFORMATION Caches[256]; /* Contains all cpu cache entries found */ > } SYSTEM_CPU_INFORMATION, *PSYSTEM_CPU_INFORMATION; Where does this come from? At least the processor mask is supposed to be an ULONG_PTR. -- Dmitry.

4 8

Re: [PATCH 1/2] mshtml: add support for the HTMLWindow.onunload event.
by Jacek Caban Oct. 3, 2010

Oct. 3, 2010

On 10/3/10 2:24 PM, Reece Dunn wrote: > Implements HTMLWindow_get/put_onunload. + {unloadW, onunloadW, EVENTT_NONE, DISPID_EVMETH_ONUNLOAD, + EVENT_DEFAULTLISTENER|EVENT_FORWARDBODY} EVENT_DEFAULTLISTENER won't work well here. Same for your onerror patch. Jacek

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5729 Your paranoid android. === W98SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WNT4WSSP6 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2KPROSP4 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WXPPROSP3 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K3R2SESP2 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WVISTAADM (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K8SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PRO (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (64 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926

3 3

Git server down?
by Joel Holdsworth Oct. 2, 2010

Oct. 2, 2010

"nmap source.winehq.org" shows no git port. Any ideas?

3 2

Re: cabinet/tests: Reformated output in case of test failure
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5725 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] winmm/tests: Set a struct member to 0 is obsolete, after adding a memset
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === W7PRO (32 bit midi) === midi.c:238: Test failed: bad message 1e/0 from midiOutOpen, expect 3c7/0 midi.c:295: Test failed: bad message 1e/0 from midiOutLong unprepared, expect 0/feedf00d midi.c:321: Test failed: bad message 1e/0 from midiOutClose, expect 3c8/0 midi.c:322: Test failed: bad message 3c7/0 from midiOut over, expect 0/feedf00d midi.c:398: Test failed: bad message 3c8/0 from midiStreamOpen, expect 3c7/0 midi.c:419: Test failed: bad message 3c7/0 from midiOutLong unprepared, expect 0/feedf00d

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 3]
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5709 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml.inf: Add default GeckoCabDir
by Austin English Oct. 2, 2010

Oct. 2, 2010

On Fri, Oct 1, 2010 at 4:29 AM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf > index d7d2428..dea1712 100644 > --- a/dlls/mshtml/mshtml.inf > +++ b/dlls/mshtml/mshtml.inf > @@ -273,6 +273,7 @@ HKLM,"Software\Microsoft\Internet Explorer\Default Behaviors","TIME",, "CLSID:47 > > [WineGecko.Reg] > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Software\Wine\MSHTML,"GeckoCabDir",,"/usr/share/wine/gecko/" The directory isn't always /usr/share, it's relative to where wine is installed -- -Austin

6 10

Re: ntdll: Fix 64 bit issue within NTDLL_mergesort().
by Marcus Meissner Oct. 2, 2010

Oct. 2, 2010

On Sat, Oct 02, 2010 at 12:31:03AM +0200, Stefan Oberhumer wrote: > --- > dlls/ntdll/misc.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > What is the alleged 64bit problem here? left and right are indexes, not sizes actually. Ciao, Marcus > diff --git a/dlls/ntdll/misc.c b/dlls/ntdll/misc.c > index 2d7c0a7..39b0ad3 100644 > --- a/dlls/ntdll/misc.c > +++ b/dlls/ntdll/misc.c > @@ -255,11 +255,11 @@ double CDECL NTDLL_tan( double d ) > > /* Merge Sort. Algorithm taken from http://www.linux-related.de/index.html?/coding/sort/sort_merge.htm */ > static void > -NTDLL_mergesort( void *arr, void *barr, int elemsize, int(__cdecl *compar)(const void *, const void *), > - int left, int right ) > +NTDLL_mergesort( void *arr, void *barr, size_t elemsize, int(__cdecl *compar)(const void *, const void *), > + size_t left, size_t right ) > { > if(right>left) { > - int i, j, k, m; > + size_t i, j, k, m; > m=(right+left)/2; > NTDLL_mergesort( arr, barr, elemsize, compar, left, m); > NTDLL_mergesort( arr, barr, elemsize, compar, m+1, right); > >

1 0

Re: msxml3: Use the existing READYSTAT type instead of creating our own enum READYSTAT (and mixing the two).
by Nikolay Sivov Oct. 2, 2010

Oct. 2, 2010

> If there_is_ a reason to keep the two separate, I strongly suggest to > use different names (having a typedef READYSTAT as well as an enum by > that name is tricky) and someone needs to look in the mixing of types > that happens in line 277. Makes sense, yes. Honestly I didn't check for this type to be defined already, and it just happens to use the same name.

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by Jeremy Drake Oct. 2, 2010

Oct. 2, 2010

Oops, those empty parens () were intended to cite the URL for the article. Unfortunately, I can't seem to find it now. However, I found an MSDN page that describes the behavior I am testing here: http://msdn.microsoft.com/en-us/library/system.datetime.fromoadate.aspx This is actually documentation of a .NET method, but see the Remarks section for a description of the format. On Fri, 1 Oct 2010, Jeremy Drake wrote: > I recently read an article () mentioning some of the oddities that show up > in negative variant dates with non-zero (midnight) times, and I noticed > that wine had no test coverage for these cases. Until now. > > > > --- > dlls/oleaut32/tests/vartest.c | 32 +++++++++++++++++++++++--------- > 1 files changed, 23 insertions(+), 9 deletions(-) -- Egotist, n.: A person of low taste, more interested in himself than me. -- Ambrose Bierce, "The Devil's Dictionary"

1 0

Re: wininet(4/5): Support querying the cipher strength of an SSL connection
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5670 Your paranoid android. === W98SE (32 bit http) === No test summary line found === W2K8SE (32 bit http) === http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:771: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:774: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:775: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:776: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:777: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:780: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:899: Test failed: failed to read any of the document http.c:2893: Test failed: InternetQueryOption failed: 12018 http.c:2894: Test failed: expected INTERNET_HANDLE_TYPE_HTTP_REQUEST, got 0 http.c:2899: Test failed: HttpQueryInfo failed http.c:2900: Test failed: expected size > 0 http.c:2974: Test failed: 3062: expected status 11 got 100 http.c:3074: Test failed: expected ERROR_INTERNET_INCORRECT_HANDLE_STATE got 12150 http.c:3081: Test failed: InternetWriteFile failed 12019 http.c:3082: Test failed: expected 0 got 21 http.c:2974: Test failed: 3093: expected status 20 got 100 http.c:2975: Test failed: 3093: expected function 3 got 5 http.c:2974: Test failed: 3101: expected status 21 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:2974: Test failed: 3101: expected status 30 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:1136: Test failed: file size = 0 http.c:1144: Test failed: file size = 100

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by Andrew Eikum Oct. 1, 2010

Oct. 1, 2010

On 09/24/2010 02:59 PM, Andrew Eikum wrote: > Likely fixes bug 18776. > > This patch is based heavily on a patch from Rein Klazes which was > rejected last summer. According to comments on the bug, Rein's patch > appears abandoned. > <http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html> > > The style has been cleaned up, as well as some minor improvements to the > tests to pass on more platforms. These tests don't fail for me. What failures are you seeing?

2 2

Re: [2/2] msi: Set more 64-bit properties.
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5687 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10040: Test failed: key not removed install.c:10050: Test failed: key not removed install.c:10061: Test failed: key not removed install.c:10352: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet Oct. 1, 2010

Oct. 1, 2010

I think this is going in the right direction, but I still have a couple of comments. On 1 October 2010 00:43, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Macro to compare two floating point numbers */ > +#define F_EQ(a, b, epsilon) (fabs(a - b) <= epsilon) There's no reason this can't be an inline function. > +/* Color macro to simplify handling of D3DXCOLOR */ > +#define COLOR(r, g, b, a) {r, g, b, a} This looks pretty pointless. > +/* Signals the end of a probe list */ > +#define PROBE_END {-1, 0, {0.0f, 0.0f, 0.0f, 0.0f}, 0.0f, ""} You'll probably want to just pass a count to compute_shader_probe9(). > + /* The x and y coordinate, the width and the height of the region to check. > + When x < 0, this is the last probe */ > + int x, y; There's no width and height here. > + setup_device9(device, &render_target, &readback, D3DFMT_A32B32G32R32F, > + width, height, vshader, pshader); You can't use D3DFMT_A32B32G32R32F without checking if it's available using CheckDeviceFormat() first. > + /* Now go through the probes and check each one */ > + for(;probes->x >= 0;probes++) { > + int index = probes->x + (probes->y * lr.Pitch); > + ok(F_EQ(probes->c.a, pbits_data[index].a, probes->epsilon), > + "In alpha component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.a, pbits_data[index].a); > + ok(F_EQ(probes->c.b, pbits_data[index].b, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.b, pbits_data[index].b); > + ok(F_EQ(probes->c.g, pbits_data[index].g, probes->epsilon), > + "In green component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.g, pbits_data[index].g); > + ok(F_EQ(probes->c.r, pbits_data[index].r, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.r, pbits_data[index].r); > + } You'll probably want to have a function to compare two D3DXCOLORs. Also, please include the line number of the caller of compute_shader_probe9() somewhere. > + if (caps.PixelShaderVersion >= 0xffff0200) You can still just use D3DPS_VERSION(2, 0) here.

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Jacek Caban Oct. 1, 2010

Oct. 1, 2010

On 10/1/10 9:59 AM, Reece Dunn wrote: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). We most likely should use to_object here. Please add a comment about it. - return E_FAIL; + return throw_type_error(ctx->parser->script, ei, V_DISPATCH(&constr) ? IDS_OBJECT_EXPECTED : IDS_NO_PROPERTY, NULL); You can't access V_DISPATCH(&constr) here as you don't know if constr is of VT_DISPATCH type. Jacek

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Ricardo Filipe Oct. 1, 2010

Oct. 1, 2010

2010/10/1 Reece Dunn <msclrhd(a)googlemail.com>: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). > > - Reece > > > > wouldn't this be more readable in separate lines? one less condition, just repeating the VariantClear...

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5679 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: wininet(3/5): Returned certificate strings are always ASCII
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5669 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0

Re: wininet(2/5): Add some secure connection tests
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5668 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0