October 2010 - Wine-Devel - list.winehq.org

New version of exe-thumbnailer (0.7)
by Scott Ritchie Oct. 7, 2010

Oct. 7, 2010

Includes much prettier icons, support for Vista icons (with icoutils 0.29.1) and more. Screenshots and a description are at: http://wiki.winehq.org/exe-thumbnailer -Scott Ritchie

4 6

Re: [PATCH 06/10] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org Oct. 7, 2010

Oct. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5914 Your paranoid android. === W2K8SE (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL === W7PROX64 (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL

1 0

Translation patches for wine-1.2.1
by Michael Stefaniuc Oct. 6, 2010

Oct. 6, 2010

Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't produce conflicts. Though the removal of the unneeded "Remove the ignored common resource attributes" patches makes "wrc --verify-translation" produce DIFF lines for resources that were added at a later time as those don't have the ignored common resource attributes. bye michael

2 2

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 20 +++++++++++++++++--- > 1 files changed, 17 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmllocation.c && touch htmllocation.ok wine: Unhandled page fault on read access to 0x00000110 at address 0x555d325a (thread 001f), starting debugger... Unhandled exception: page fault on read access to 0x00000110 in 32-bit code (0x555d325a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555d325a ESP:0032dfd0 EBP:0032e038 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00ed2bf4 EBX:5561bc84 ECX:002078c0 EDX:555d31c0 ESI:0126f400 EDI:00000000 Stack dump: 0x0032dfd0: 00ed2b98 0032e3a8 0032e008 6ad698bc 0x0032dfe0: 002078b0 00000001 00000001 0032e078 0x0032dff0: 6adbe4f5 002078b0 0032e018 00000000 0x0032e000: 002078b0 6b127f9c 0032e028 6ad697d8 0x0032e010: 002078b0 0032e074 00000001 00000000 0x0032e020: 002078a8 0032e074 0032e068 012ad758 Backtrace: =>0 0x555d325a handle_load+0x9a(iface=0x126f5c0, event=0x12ad758) [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml (0x0032e158) 1 0x6a02f1db in xul (+0x3ef1da) (0x0032e1d8) 2 0x6aca1e00 in xul (+0x1061dff) (0x0032e208) 3 0x6aca1fe1 in xul (+0x1061fe0) (0x0032e258) 4 0x6a047958 in xul (+0x407957) (0x0032e2a8) 5 0x6a04819c in xul (+0x40819b) (0x0032e378) 6 0x69dc9c12 in xul (+0x189c11) (0x0032e408) 7 0x6a53d3a0 in xul (+0x8fd39f) (0x0032e698) 8 0x6a53ced6 in xul (+0x8fced5) (0x0032e718) 9 0x6a5574c8 in xul (+0x9174c7) (0x0032e768) 10 0x6a556567 in xul (+0x916566) (0x0032e798) 11 0x6a556371 in xul (+0x916370) (0x0032e7e8) 12 0x6a555fa2 in xul (+0x915fa1) (0x0032e858) 13 0x69c66091 in xul (+0x26090) (0x0032e898) 14 0x555cbc1b on_stop_nsrequest+0x8a(This=0xed4da0, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8d8) 15 0x555cbc1b on_stop_nsrequest+0x8a(This=0x10, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8e8) 16 0x555cca5f nsChannelBSC_stop_binding+0x1e(bsc=0x126fe08, result=0x555d31c0) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1184] in mshtml (0x0032e928) 17 0x555cb126 BindStatusCallback_OnStopBinding+0x35(iface=0x126fe08, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:360] in mshtml (0x0032e968) 18 0x68f3f838 BindStatusCallback_OnStopBinding+0x87(iface=0x129b090, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindctx.c:178] in urlmon (0x0032e988) 19 0x68f40c5d stop_binding+0x3c(binding=0x129b118, hres=0xffffffff80004004, str=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:221] in urlmon (0x0032e9d8) 20 0x68f41dde InternetProtocolSink_ReportResult+0x8d(iface=0x129b11c, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1149] in urlmon (0x0032ea28) 21 0x68f47abd BPInternetProtocolSink_ReportResult+0xec(iface=0x129b578, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:1184] in urlmon (0x0032ea48) 22 0x68f50b5d report_result+0x3c() in urlmon (0x0032ea58) 23 0x68f50c1d protocol_abort+0x2c(protocol=0x2078c0, reason=0xffffffff80004004) [/home/julliard/wine/wine/dlls/urlmon/protocol.c:439] in urlmon (0x0032ea98) 24 0x68f4cbd4 HttpProtocol_Abort+0x73(iface=0x129b764, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/http.c:445] in urlmon (0x0032eae8) 25 0x68f452b0 ProtocolHandler_Abort+0x5f(iface=0x129b580, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:662] in urlmon (0x0032eb38) 26 0x68f459db BindProtocol_Abort+0x7a(iface=0x129b568, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:429] in urlmon (0x0032eb68) 27 0x68f4140b Binding_Abort+0x5a(iface=0x129b118) [/home/julliard/wine/wine/dlls/urlmon/binding.c:892] in urlmon (0x0032eb88) 28 0x555ca834 set_window_bscallback+0x23(window=0xed2b98, callback=(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1349] in mshtml (0x0032ebd8) 29 0x555c54a1 HTMLWindow2_Release+0x70(iface=0xed2ba8) [/home/julliard/wine/wine/dlls/mshtml/htmlwindow.c:228] in mshtml (0x0032ec18) 30 0x55580881 CustomDoc_Release+0x80(iface=0x129db0) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2021] in mshtml (0x0032ec38) 31 0x5557ea04 HTMLDocument_Release+0x13(iface=0x129ca8) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:376] in mshtml (0x0032fd08) 32 0x686a82f5 perform_test+0xd34(test=0x686c24c3) [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:348] in mshtml_test (0x0032fd38) 33 0x686a838e func_htmllocation+0x3d() [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:360] in mshtml_test (0x0032fd88) 34 0x686b535e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe48) 35 0x686b5557 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:624] in mshtml_test (0x0032fe90) 36 0x686b60dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fea8) 37 0x7b856c4c call_process_entry+0xb() in kernel32 (0x0032fee8) 38 0x7b85914b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 39 0x7bc72b80 call_thread_func+0xb() in ntdll (0x0032ffc8) 40 0x7bc72d50 call_thread_entry_point+0x6f(entry=0x7b8590f0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 41 0x7bc4da6a start_process+0x29(kernel_start=0x7b8590f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x555d325a handle_load+0x9a [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml: movl 0x110(%edi),%eax 226 if(doc_obj->nscontainer->editor_controller) { -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cryptui: Fix a crash with certification path (resend)
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) > */ > tvis.u.item.iImage = 2; > } > - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. > - dwErrorStatus == 0) > + else if (i > 1 && > + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) What is this change for? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The bug #20129 lists one of such applications. > > It does FindWindow("Shell_TrayWnd", "") and expects that it returns a valid > tray window handle. Currently FindWindow() is broken, but my next patch makes > the above call succeed. This will cause the stand-alone tray window to not have a title, that doesn't look nice. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: cryptui: Fix a crash with certification path
by Juan Lang Oct. 6, 2010

Oct. 6, 2010

Hi André, I see your patch didn't get committed. In case it's waiting for a comment from me, it looks fine: I assume you've imported a certificate that isn't otherwise trusted, and viewing it results in a crash? I don't see the crash here. Thanks, --Juan

2 1

Re: [7/7] msi/tests: Fix some test failures on 64-bit.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5900 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10500: Test failed: key not created

1 0

Re: [2/6]strmbase: move enumpins from quartz to strmbase
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/Makefile.in | 1 - > dlls/qcap/enumpins.c | 186 ------------------------------------- > dlls/qcap/qcap_main.h | 8 -- > dlls/qcap/vfwcapture.c | 28 +++++- > dlls/quartz/Makefile.in | 1 - > dlls/quartz/dsoundrender.c | 26 ++++-- > dlls/quartz/enumpins.c | 211 > ------------------------------------------ > dlls/quartz/filesource.c | 32 +++++-- > dlls/quartz/nullrenderer.c | 25 +++-- > dlls/quartz/parser.c | 29 ++++-- > dlls/quartz/quartz_private.h | 3 - > dlls/quartz/transform.c | 27 ++++-- > dlls/quartz/videorenderer.c | 25 +++-- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/enumpins.c | 207 > +++++++++++++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 6 + > 16 files changed, 346 insertions(+), 470 deletions(-) > delete mode 100644 dlls/qcap/enumpins.c > delete mode 100644 dlls/quartz/enumpins.c > create mode 100644 dlls/strmbase/enumpins.c It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so avisplitter.c && touch avisplitter.ok avisplitter.c:164: Test failed: pins[1] = (nil) avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test make: *** [avisplitter.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/7] msi: Use strcmpW instead of lstrcmpW to compare database strings.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

Hans Leidekker <hans(a)codeweavers.com> writes: > An installer I have here uses \1 and \2 as delimiters in property strings. > It turns out that on Wine lstrcmp("\1", "\2") returns 0, not -1, which causes > the string table implementation to return the wrong value. This should be fixed, > but it's better if database string comparisons do not depend on thread locale. Yes, but isn't it supposed to follow Unicode sorting rules instead of simply comparing code point values? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/7] msi: Add package validation tests.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5898 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10164: Test failed: key not removed install.c:10174: Test failed: key not removed install.c:10185: Test failed: key not removed install.c:10476: Test failed: key not created

1 0

Re: [PATCH 9/9] urlmon: Added IInternetProtocolEx support to http protocol handler.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5895 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:977: Test failed: hrResult = 800c0005, expected: 00000000 Timeout

1 0

Re: [PATCH 6/9] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5893 Your paranoid android. === WXPPROSP3 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K3R2SESP2 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === WVISTAADM (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K8SE (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PRO (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (64 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable

1 0

Re: [PATCH 1/9] urlmon: Return correct error in get_protocol_handler for unknown protocol types.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5892 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:459: Test failed: expected ReportProgress_SENDINGREQUEST

1 0

Re: [PATCH 3/3] d3d9/tests: Add window proc tests for switching between fullscreen and windowed.
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5888 Your paranoid android. === W2K8SE (32 bit device) === device.c:2473: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2611: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (64 bit device) === device.c:2473: Test failed: Expected foreground window 0000000000020198, got 0000000000010092. device.c:2611: Test failed: Expected foreground window 0000000000030198, got 0000000000010092.

1 0

Re: [1/5] mscoree: Implement ICLRMetaHost_GetRuntime.
by Alexandre Julliard Oct. 6, 2010

Oct. 6, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This will cause the tests to fail if Mono is not available. We'll have to start providing a Mono package then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32(10/10): Set correct error when encountering unsupported critical extensions in the base and SSL policy
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5874 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)
by Mike Kaplinskiy Oct. 6, 2010

Oct. 6, 2010

There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }". More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <rm(a)eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >

1 0

Re: crypt32/tests(8/10): Add macros to declare tests
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5873 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(7/10): Add name to test to help identify test failures
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5872 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32(6/10): Set CERT_TRUST_HAS_NOT_SUPPORTED_CRITICAL_EXT when appropriate
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5871 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(5/10): Test the base and SSL policies against a certificate with an invalid critical extension
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5870 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(4/10): Test invalid critical extension in intermediate cert
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5869 Your paranoid android. === W98SE (32 bit chain) === chain.c:4108: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2

1 0

Re: crypt32(2/10): Improve error checking for the base policy
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5868 Your paranoid android. === W98SE (32 bit chain) === chain.c:4015: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0

Re: crypt32/tests(1/10): Add more tests of verifying the base policy, including flags to ignore certain errors
by testbot＠testbot.winehq.org Oct. 6, 2010

Oct. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5867 Your paranoid android. === W98SE (32 bit chain) === chain.c:4012: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0