October 2010 - Wine-Devel - list.winehq.org

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by Greg Geldorp Oct. 3, 2010

Oct. 3, 2010

> While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=5753 > > Your paranoid android. > > === WINEBUILD (build) === > Make in include dir failed Caused by a problem in TestBot, should be fixed now. Greg.

1 0

Re: [5/5] mscoree: Add a test that enumerates .NET runtimes.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5754 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5753 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: (5th try) winhlp32: Added Hebrew translation
by Paul Vriens Oct. 3, 2010

Oct. 3, 2010

On 10/03/2010 05:04 PM, Yaron Shahrabani wrote: > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + Hi Yaron, This piece should go. And I still have an apply warning for your Makefile.in patch. -- Cheers, Paul.

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line
by Jacek Caban Oct. 3, 2010

Oct. 3, 2010

On 10/3/10 1:18 PM, Alexandre Goujon wrote: > --- > programs/cmd/tests/batch.c | 2 +- > programs/cmd/wcmdmain.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batch.c > index cc8c020..d7a5e84 100644 > --- a/programs/cmd/tests/batch.c > +++ b/programs/cmd/tests/batch.c > @@ -131,7 +131,7 @@ static const char *compare_line(const char *out_line, const char *out_end, const > }else if(exp_ptr+sizeof(todo_space_cmd)<= exp_end > && !memcmp(exp_ptr, todo_space_cmd, sizeof(todo_space_cmd))) { > exp_ptr += sizeof(todo_space_cmd); > - todo_wine ok(*out_ptr == ' ', "expected space\n"); > + ok(*out_ptr == ' ', "expected space\n"); @todo_space@ is meant to do tests in todo_wine block. You should change @todo_space@ to spec in .exp file instead. If we're convinced that the whole keyword is not useful anymore, the whole handling code should be removed (although I think we'd better keep it). > if(out_ptr< out_end&& *out_ptr == ' ') > out_ptr++; > continue; > diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c > index b50512e..247457a 100644 > --- a/programs/cmd/wcmdmain.c > +++ b/programs/cmd/wcmdmain.c > @@ -1779,8 +1779,11 @@ WCHAR *WCMD_ReadAndParseLine(WCHAR *optionalcmd, CMD_LIST **output, HANDLE readF > if (context) handleExpansion(extraSpace, FALSE, NULL, NULL); > /* Show prompt before batch line IF echo is on and in batch program */ > if (context&& echo_mode&& extraSpace[0]&& (extraSpace[0] != '@')) { > + const WCHAR spc[] = {' ','\0'}; > WCMD_show_prompt(); > WCMD_output_asis(extraSpace); > + /* I don't know why Windows puts a space here but it does */ > + WCMD_output_asis(spc); More tests would be nice. Jacek

2 1

Re: [PATCH1/3] include/winternl: Add Logical Processor Information to SYSTEM_CPU_INFORMATION
by Dmitry Timoshkov Oct. 3, 2010

Oct. 3, 2010

Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: > /* System Information Class 0x01 */ > +typedef struct _SYSTEM_CPU_CACHE_INFORMATION { > + ULONG ProcessorMask; > + CACHE_DESCRIPTOR CacheInformation; > +} SYSTEM_CPU_CACHE_INFORMATION, *PSYSTEM_CPU_CACHE_INFORMATION; > > typedef struct _SYSTEM_CPU_INFORMATION { > WORD Architecture; > @@ -1100,6 +1104,10 @@ typedef struct _SYSTEM_CPU_INFORMATION { > WORD Revision; /* combination of CPU model and stepping */ > WORD Reserved; /* always zero */ > DWORD FeatureSet; /* see bit flags below */ > + ULONG Cores[64]; /* Contains a Processormask for each physical core. Index is CoreID*/ > + ULONG ProcessorPackages[64]; /* Contains a Processormask for each processorpackage. Index is ProcessorPackage ID*/ > + ULONG NumaNodes[64]; /* Contains a Processormask for each numa node. Index is NumaNodeNumber */ > + SYSTEM_CPU_CACHE_INFORMATION Caches[256]; /* Contains all cpu cache entries found */ > } SYSTEM_CPU_INFORMATION, *PSYSTEM_CPU_INFORMATION; Where does this come from? At least the processor mask is supposed to be an ULONG_PTR. -- Dmitry.

4 8

Re: [PATCH 1/2] mshtml: add support for the HTMLWindow.onunload event.
by Jacek Caban Oct. 3, 2010

Oct. 3, 2010

On 10/3/10 2:24 PM, Reece Dunn wrote: > Implements HTMLWindow_get/put_onunload. + {unloadW, onunloadW, EVENTT_NONE, DISPID_EVMETH_ONUNLOAD, + EVENT_DEFAULTLISTENER|EVENT_FORWARDBODY} EVENT_DEFAULTLISTENER won't work well here. Same for your onerror patch. Jacek

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by testbot＠testbot.winehq.org Oct. 3, 2010

Oct. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5729 Your paranoid android. === W98SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WNT4WSSP6 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2KPROSP4 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WXPPROSP3 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K3R2SESP2 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WVISTAADM (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K8SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PRO (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (64 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926

3 3

Git server down?
by Joel Holdsworth Oct. 2, 2010

Oct. 2, 2010

"nmap source.winehq.org" shows no git port. Any ideas?

3 2

Re: cabinet/tests: Reformated output in case of test failure
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5725 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] winmm/tests: Set a struct member to 0 is obsolete, after adding a memset
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === W7PRO (32 bit midi) === midi.c:238: Test failed: bad message 1e/0 from midiOutOpen, expect 3c7/0 midi.c:295: Test failed: bad message 1e/0 from midiOutLong unprepared, expect 0/feedf00d midi.c:321: Test failed: bad message 1e/0 from midiOutClose, expect 3c8/0 midi.c:322: Test failed: bad message 3c7/0 from midiOut over, expect 0/feedf00d midi.c:398: Test failed: bad message 3c8/0 from midiStreamOpen, expect 3c7/0 midi.c:419: Test failed: bad message 3c7/0 from midiOutLong unprepared, expect 0/feedf00d

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 3]
by testbot＠testbot.winehq.org Oct. 2, 2010

Oct. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5709 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml.inf: Add default GeckoCabDir
by Austin English Oct. 2, 2010

Oct. 2, 2010

On Fri, Oct 1, 2010 at 4:29 AM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf > index d7d2428..dea1712 100644 > --- a/dlls/mshtml/mshtml.inf > +++ b/dlls/mshtml/mshtml.inf > @@ -273,6 +273,7 @@ HKLM,"Software\Microsoft\Internet Explorer\Default Behaviors","TIME",, "CLSID:47 > > [WineGecko.Reg] > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Software\Wine\MSHTML,"GeckoCabDir",,"/usr/share/wine/gecko/" The directory isn't always /usr/share, it's relative to where wine is installed -- -Austin

6 10

Re: ntdll: Fix 64 bit issue within NTDLL_mergesort().
by Marcus Meissner Oct. 2, 2010

Oct. 2, 2010

On Sat, Oct 02, 2010 at 12:31:03AM +0200, Stefan Oberhumer wrote: > --- > dlls/ntdll/misc.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > What is the alleged 64bit problem here? left and right are indexes, not sizes actually. Ciao, Marcus > diff --git a/dlls/ntdll/misc.c b/dlls/ntdll/misc.c > index 2d7c0a7..39b0ad3 100644 > --- a/dlls/ntdll/misc.c > +++ b/dlls/ntdll/misc.c > @@ -255,11 +255,11 @@ double CDECL NTDLL_tan( double d ) > > /* Merge Sort. Algorithm taken from http://www.linux-related.de/index.html?/coding/sort/sort_merge.htm */ > static void > -NTDLL_mergesort( void *arr, void *barr, int elemsize, int(__cdecl *compar)(const void *, const void *), > - int left, int right ) > +NTDLL_mergesort( void *arr, void *barr, size_t elemsize, int(__cdecl *compar)(const void *, const void *), > + size_t left, size_t right ) > { > if(right>left) { > - int i, j, k, m; > + size_t i, j, k, m; > m=(right+left)/2; > NTDLL_mergesort( arr, barr, elemsize, compar, left, m); > NTDLL_mergesort( arr, barr, elemsize, compar, m+1, right); > >

1 0

Re: msxml3: Use the existing READYSTAT type instead of creating our own enum READYSTAT (and mixing the two).
by Nikolay Sivov Oct. 2, 2010

Oct. 2, 2010

> If there_is_ a reason to keep the two separate, I strongly suggest to > use different names (having a typedef READYSTAT as well as an enum by > that name is tricky) and someone needs to look in the mixing of types > that happens in line 277. Makes sense, yes. Honestly I didn't check for this type to be defined already, and it just happens to use the same name.

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by Jeremy Drake Oct. 2, 2010

Oct. 2, 2010

Oops, those empty parens () were intended to cite the URL for the article. Unfortunately, I can't seem to find it now. However, I found an MSDN page that describes the behavior I am testing here: http://msdn.microsoft.com/en-us/library/system.datetime.fromoadate.aspx This is actually documentation of a .NET method, but see the Remarks section for a description of the format. On Fri, 1 Oct 2010, Jeremy Drake wrote: > I recently read an article () mentioning some of the oddities that show up > in negative variant dates with non-zero (midnight) times, and I noticed > that wine had no test coverage for these cases. Until now. > > > > --- > dlls/oleaut32/tests/vartest.c | 32 +++++++++++++++++++++++--------- > 1 files changed, 23 insertions(+), 9 deletions(-) -- Egotist, n.: A person of low taste, more interested in himself than me. -- Ambrose Bierce, "The Devil's Dictionary"

1 0

Re: wininet(4/5): Support querying the cipher strength of an SSL connection
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5670 Your paranoid android. === W98SE (32 bit http) === No test summary line found === W2K8SE (32 bit http) === http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:771: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:774: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:775: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:776: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:777: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:780: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:899: Test failed: failed to read any of the document http.c:2893: Test failed: InternetQueryOption failed: 12018 http.c:2894: Test failed: expected INTERNET_HANDLE_TYPE_HTTP_REQUEST, got 0 http.c:2899: Test failed: HttpQueryInfo failed http.c:2900: Test failed: expected size > 0 http.c:2974: Test failed: 3062: expected status 11 got 100 http.c:3074: Test failed: expected ERROR_INTERNET_INCORRECT_HANDLE_STATE got 12150 http.c:3081: Test failed: InternetWriteFile failed 12019 http.c:3082: Test failed: expected 0 got 21 http.c:2974: Test failed: 3093: expected status 20 got 100 http.c:2975: Test failed: 3093: expected function 3 got 5 http.c:2974: Test failed: 3101: expected status 21 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:2974: Test failed: 3101: expected status 30 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:1136: Test failed: file size = 0 http.c:1144: Test failed: file size = 100

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by Andrew Eikum Oct. 1, 2010

Oct. 1, 2010

On 09/24/2010 02:59 PM, Andrew Eikum wrote: > Likely fixes bug 18776. > > This patch is based heavily on a patch from Rein Klazes which was > rejected last summer. According to comments on the bug, Rein's patch > appears abandoned. > <http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html> > > The style has been cleaned up, as well as some minor improvements to the > tests to pass on more platforms. These tests don't fail for me. What failures are you seeing?

2 2

Re: [2/2] msi: Set more 64-bit properties.
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5687 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10040: Test failed: key not removed install.c:10050: Test failed: key not removed install.c:10061: Test failed: key not removed install.c:10352: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet Oct. 1, 2010

Oct. 1, 2010

I think this is going in the right direction, but I still have a couple of comments. On 1 October 2010 00:43, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Macro to compare two floating point numbers */ > +#define F_EQ(a, b, epsilon) (fabs(a - b) <= epsilon) There's no reason this can't be an inline function. > +/* Color macro to simplify handling of D3DXCOLOR */ > +#define COLOR(r, g, b, a) {r, g, b, a} This looks pretty pointless. > +/* Signals the end of a probe list */ > +#define PROBE_END {-1, 0, {0.0f, 0.0f, 0.0f, 0.0f}, 0.0f, ""} You'll probably want to just pass a count to compute_shader_probe9(). > + /* The x and y coordinate, the width and the height of the region to check. > + When x < 0, this is the last probe */ > + int x, y; There's no width and height here. > + setup_device9(device, &render_target, &readback, D3DFMT_A32B32G32R32F, > + width, height, vshader, pshader); You can't use D3DFMT_A32B32G32R32F without checking if it's available using CheckDeviceFormat() first. > + /* Now go through the probes and check each one */ > + for(;probes->x >= 0;probes++) { > + int index = probes->x + (probes->y * lr.Pitch); > + ok(F_EQ(probes->c.a, pbits_data[index].a, probes->epsilon), > + "In alpha component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.a, pbits_data[index].a); > + ok(F_EQ(probes->c.b, pbits_data[index].b, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.b, pbits_data[index].b); > + ok(F_EQ(probes->c.g, pbits_data[index].g, probes->epsilon), > + "In green component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.g, pbits_data[index].g); > + ok(F_EQ(probes->c.r, pbits_data[index].r, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.r, pbits_data[index].r); > + } You'll probably want to have a function to compare two D3DXCOLORs. Also, please include the line number of the caller of compute_shader_probe9() somewhere. > + if (caps.PixelShaderVersion >= 0xffff0200) You can still just use D3DPS_VERSION(2, 0) here.

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Jacek Caban Oct. 1, 2010

Oct. 1, 2010

On 10/1/10 9:59 AM, Reece Dunn wrote: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). We most likely should use to_object here. Please add a comment about it. - return E_FAIL; + return throw_type_error(ctx->parser->script, ei, V_DISPATCH(&constr) ? IDS_OBJECT_EXPECTED : IDS_NO_PROPERTY, NULL); You can't access V_DISPATCH(&constr) here as you don't know if constr is of VT_DISPATCH type. Jacek

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Ricardo Filipe Oct. 1, 2010

Oct. 1, 2010

2010/10/1 Reece Dunn <msclrhd(a)googlemail.com>: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). > > - Reece > > > > wouldn't this be more readable in separate lines? one less condition, just repeating the VariantClear...

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5679 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: wininet(3/5): Returned certificate strings are always ASCII
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5669 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0

Re: wininet(2/5): Add some secure connection tests
by testbot＠testbot.winehq.org Oct. 1, 2010

Oct. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5668 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0