October 2010 - Wine-Devel - list.winehq.org

Re: loader: On Mac, reserve the process's original thread for the frameworks.
by Ken Thomases Oct. 28, 2010

Oct. 28, 2010

On Oct 27, 2010, at 5:36 PM, Ken Thomases wrote: > > The frameworks expect the original thread to run its run loop, so input > sources (like distributed notifications) get processed. For example, > Core Audio on Snow Leopard doesn't track changes in the default ouput > device, such as when headphones are plugged in, without this. > --- > libs/wine/Makefile.in | 2 +- > libs/wine/loader.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 115 insertions(+), 1 deletions(-) > > > <0001-loader-On-Mac-reserve-the-process-s-original-thread-.patch> Hold off on this one. I've encountered a strange issue after sending it (that I didn't encounter in earlier testing). err:process:start_wineboot failed to start wineboot, err 1359 Apparently, there's a failure of an execve() system call in a child process. It's getting EFAULT. Artificially avoiding the very top of the available address space for the secondary thread stack works around the problem. Either the fork() alters the address space (perhaps as a consequence of eliminating all but one thread when creating the child from the parent), or execve() is sensitive to the specific layout. Perhaps it needs to use the very top of the address space, but won't if it thinks that's where the thread's stack is. Or something. -Ken

2 1

Re: About the Gallium Direct3D 10/11 work
by abraham vargas moreno Oct. 28, 2010

Oct. 28, 2010

galllund3 how long it takes to have dx 10 and 11 and ubuntu natively, all the world want to have a minimum release date for this wonderful work they are dealing with the DX.

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by Vitaliy Margolen Oct. 28, 2010

Oct. 28, 2010

On 10/27/2010 07:46 PM, Charles Davis wrote: > + sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); Could you please put some spaces after each coma everywhere in your patch? Please use snprintf(). > + GetShortPathNameA(buf,shortbuf,MAX_PATH); Use sizeof(buf) instead of MAX_PATH to guarantee that's what it means. > + hndl = CreateFileA(shortbuf,GENERIC_READ|GENERIC_WRITE,0,NULL,OPEN_EXISTING,0,NULL); > + ok(hndl!=INVALID_HANDLE_VALUE,"CreateFileA failed\n"); It's nice to know LastError and the full filename if it fails. > + for(i=0;i<MAX_PATH&& shortbuf[i];i++) You getting past the filename size in the buffer. > + shortbuf[i]=(rand() % 2) ? tolower(shortbuf[i]) : toupper(shortbuf[i]); Please don't use any sort of random stuff in tests. They should always be the same every time on every platform. > + /* Now try it on mixed case short names */ What's the point of the test anyway? You know that Wine already handles all files as case-insensitive. Short file name isn't any different. Vitaliy.

2 2

Re: [PATCH 1/3] configure: Check for the getattrlist() function and the <sys/attr.h> header (resend).
by Vitaliy Margolen Oct. 28, 2010

Oct. 28, 2010

On 10/27/2010 07:46 PM, Charles Davis wrote: > --- a/configure > +++ b/configure Please exclude changes to configure from your patches. AJ regenerates it himself. > @@ -1866,6 +1867,7 @@ AC_CHECK_FUNCS(\ > ftruncate \ > futimes \ > futimesat \ > + getattrlist \ > getdirentries \ > getopt_long \ > getpagesize \ Incorrect indentation - should be a tab, not 4 spaces. Vitaliy.

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by testbot＠testbot.winehq.org Oct. 28, 2010

Oct. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6562 Your paranoid android. === WINEBUILD (build) === Failure running script in VM: Exceeded timeout limit of 300 sec

2 1

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk Oct. 27, 2010

Oct. 27, 2010

Well, in practice, it's a detail that I don't expect to be very important, so it's probably not worth the trouble. Mostly I just want to elminiate the call fusion makes back into mscoree, since it is so blatantly wrong and causes the change I really want to break the tests. We could probably even get away with a hard-coded path, since our ngen.exe doesn't work anyway, and that's essentially what we're doing now given the semi-stub status of GetCORVersion. If/when we need to use the CLR version in fusion for something other than finding the precompiled assembly cache, this may become more important, but even then I don't think we'll need multiple simultaneous instances to work properly. We'll just need to know the correct version to use when only one instance is loaded. Multiple simultaneous runtimes is a case I'm thinking about and trying to account for, but I don't expect to ever see it used. If you prefer, I can add a test for fusion instead that compares the version we get out of GetCachePath(ASM_CACHE_ZAP) to the one we pass to LoadLibraryShim, in cases where more than one runtime is installed, assuming only one instance will be loaded at once. I can fix that without any changes to the loader, but it will mean adding a wine-specific export to fusion. OR mscoree could lie about which .NET versions are installed when Mono isn't available, until there's a real need to load Mono. -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, October 27, 2010 2:15 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > There is another minor problem highlighted by this test, which is that > I can make up any path and end up with a loaded dll, as long as > there's a builtin dll filename at the end. That's a feature, the idea is that builtin dlls are independent from the actual dll files. That's also why asking for the path name of a builtin doesn't make sense. This could conceivably be changed now that we have the fake dlls mechanism, but it would be a pretty fundamental redesign. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk Oct. 27, 2010

Oct. 27, 2010

Well, I don't think we can do it properly without having multiple instances of a builtin dll. I believe that native fusion.dll is different for each .NET version, and it probably has the version number baked in. If we can't have multiple instances of a builtin dll, I still believe testing the path is the best way to determine which version was given to LoadLibraryShim, if that's possible. If testing the path is not possible, we can have LoadLibraryShim use a wine-specific exported function to inform fusion.dll of the version, but this approach won't work if someone loads fusion.dll directly from a .NET system directory. There is another minor problem highlighted by this test, which is that I can make up any path and end up with a loaded dll, as long as there's a builtin dll filename at the end. -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, October 27, 2010 1:31 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 4)
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat() calls in the fast path, as well as some unnecessary changes. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [3/3] mscoree: Implement LoadLibraryShim.
by testbot＠testbot.winehq.org Oct. 27, 2010

Oct. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6541 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)
by Charles Davis Oct. 27, 2010

Oct. 27, 2010

Any concerns? I've gone over this patch, and I don't see anything major. If it will make you feel any better, I just ran the tests under a WoW64 environment on Linux, and they passed. Chip

2 2

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by testbot＠testbot.winehq.org Oct. 27, 2010

Oct. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6540 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if (access & GENERIC_READ) access |= FILE_GENERIC_READ; > + /* FIXME: we add FILE_READ_PROPERTIES access even in write-only mode. > + * As tested on Windows, this is not correct (ie GetConsoleMode() on with GENERIC_WRITE only > + * access fails). > + * But, this is currently needed as part of kernel32/console.c client side code relies on the > + * fact that it can read properties: lots of 'set' functions like WriteConsole, > + * ScrollConsoleScreenBuffer, SetConsoleCursorPosition (and many others) do call 'get' > + * functions. > + */ These should be fixed then. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdi32: Make AddFontToList skip adding a face into global lists if the font is not supposed to be enumerated, and return a pointer to first loaded face.
by Alexandre Julliard Oct. 27, 2010

Oct. 27, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1207,15 +1207,17 @@ static void AddFaceToFamily(Face *face, Family *family) > > #define ADDFONT_EXTERNAL_FONT 0x01 > #define ADDFONT_FORCE_BITMAP 0x02 > -static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, char *fake_family, const WCHAR *target_family, DWORD flags) > +#define ADDFONT_HIDDEN 0x04 > +static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, > + char *fake_family, const WCHAR *target_family, DWORD flags, Face **face_to_return) The face_to_return pointer doesn't seem to be used anywhere. If it's really needed for something else it should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: First contact
by Dan Kegel Oct. 26, 2010

Oct. 26, 2010

On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET <andreas.livet at gmail.com> wrote: > For the patch, I think I understand the concept (I never use git before and > never apply a patch), I have to selection the diff text and save it into a > file (let's say debug.patch) Copy and paste sometimes screws up patches. Better to save the patch to a file some other way. In particular, I usually use wget. For the patch you mentioned, one command to fetch the patch is wget http://repo.or.cz/w/wine/hacks.git/patch/2daf55e8eeca89d5c2bb82381151277b6f… http://marc.info/?l=wine-patches is another good place to search for uncommitted patches; that site does a good job of saving the patches as hyperlinks you can use with wget. See also http://kegel.com/academy/opensource.html and http://kegel.com/wine/qa/ for a few tips. Welcome aboard. I hope you have more than 1 hour / week, it takes a while to come up the learning curve. - Dan

1 0

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

David Adam <david.adam.cnrs(a)gmail.com> writes: > @@ -33,8 +33,9 @@ static LPDIRECTDRAW lpDD = NULL; > static LPDIRECTDRAWSURFACE lpDDSPrimary = NULL; > static LPDIRECTDRAWSURFACE lpDDSBack = NULL; > static WNDCLASS wc; > -static HWND hwnd; > +static HWND hwnd, hwnd2; > static int modes_cnt; > +static BOOL success; That boolean make much sense, especially with this name. If you want to check that you have a valid window you should test the window handle. Same with your createwindow function, it should simply return the handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msxml3: libxml2 error/warning callback functions (try 2)
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > + len = vsnprintf(NULL, 0, msg, ap); > + buf = heap_alloc(len+1); > + vsnprintf(buf, len+1, msg, ap); vsnprintf can also return -1, check how this is done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > + ERR("++++++++++++++++ perform byte seek ------------------\n"); You still have a ton of such debug ERRs in there. > + *buf = NULL; > + TRACE("Requesting %llu %u\n", ofs, len); Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32: Export recent wer functions
by Alexandre Julliard Oct. 26, 2010

Oct. 26, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1156,7 +1156,20 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stub WerGetFlags > @ stdcall WerRegisterFile(wstr long long) > +@ stub WerRegisterMemoryBlock > +@ stub WerRegisterRuntimeExceptionModule > +@ stub WerSetFlags > +@ stub WerUnregisterFile > +@ stub WerUnregisterMemoryBlock > +@ stub WerUnregisterRuntimeExceptionModule > +@ stub WerpCleanupMessageMapping > +@ stub WerpInitiateRemoteRecovery > +@ stub WerpNotifyLoadStringResource > +@ stub WerpNotifyLoadStringResourceEx > +@ stub WerpNotifyUseStringResource > +@ stub WerpStringLookup Adding stubs is not a good idea. If you have an app that calls these you need to provide a proper stub function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wer/tests: Add initial tests
by testbot＠testbot.winehq.org Oct. 26, 2010

Oct. 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: comdlg32: Added Hebrew translation.
by Yaron Shahrabani Oct. 26, 2010

Oct. 26, 2010

What is wrong with the patch? Yaron Shahrabani <Hebrew translator> 2010/10/23 Yaron Shahrabani <sh.yaron(a)gmail.com> > Verified by Paul Vriens >

2 1

ddraw: Add tests for the foreground window set by SetCooperativeLevel
by David Adam Oct. 26, 2010

Oct. 26, 2010

Any problems with patch? A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2010/10/24 Subject: ddraw: Add tests for the foreground window set by SetCooperativeLevel To: wine-patches <wine-patches(a)winehq.org>

2 2

comdlg32/cdlg: removed 16 bit dependency
by CJ Oct. 26, 2010

Oct. 26, 2010

Removed wownt32.h from the includes of cdlg32.h and modified fontdlg.c so that it no longer relies on the 16 bit dependency. -- Carl J. Raffaele

2 1

Re: msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()
by Jacek Caban Oct. 25, 2010

Oct. 25, 2010

On 10/25/10 10:38 PM, Nikolay Sivov wrote: > Should help with http://bugs.winehq.org/show_bug.cgi?id=22607 > > > + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = SysAllocString(data); - hr = node_put_value(node_obj,&v_data); Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here? Jacek

2 1

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Vitaliy Margolen Oct. 25, 2010

Oct. 25, 2010

On 10/25/2010 07:45 AM, Aric Stewart wrote: > --- > + ERR("++++++++++++++++ perform byte seek ------------------\n"); > + if (1 || This->initial) { > + ERR("Relinked\n"); > + FIXME("Seeking %i %i\n", format, GST_FORMAT_BYTES); > + FIXME("using \"%s\"\n", name); Some debug leftovers? > + AM_MEDIA_TYPE amt = { }; > .. > + ZeroMemory(&amt, sizeof(amt)); This is redundant. > sizeof(piOutput.achName) / sizeof(*piOutput.achName) The more common construct in Wine is sizeof(array)/sizeof(array[0]). IMHO it's better to stick with one Also could you please put an empty line in each function after variable declarations? Your patches look inconsistent. Vitaliy.

2 1