October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 6/8] jscript: Added VBArray.getItem() implementation
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6284 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 8/8] jscript: Added VBArray handling to to_object()
by testbot＠testbot.winehq.org Oct. 19, 2010

Oct. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6286 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Fwd: Invitation: Apply to be a Mentoring Organization for GCI
by Austin English Oct. 19, 2010

Oct. 19, 2010

I hadn't see any talk about this, so passing this along from Google: -- -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Oct 18, 2010 at 8:10 AM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, Starting today we are accepting applications from organizations who have participated in a previous Google Summer of Code (you!) to get involved with our contest for 13-18 year olds, Google Code-in [0]. If you haven’t read up about Google Code-in, you can check out our announcement [1] to this list from a couple weeks ago or read our blog post [2] about the contest. If your org has decided it would like to apply to participate in the contest, you can fill out the application [3] on Melange now. The deadline for applications is 29 October at 23:00 UTC. Also, if you want to look over the rules for the contest before applying to participate they can be found on the organization application [3] at the bottom. They will also be posted on the Google Code-in website [0] in the next couple days in other languages. We hope your org will consider participating. [0] - http://code.google.com/gci [1] - http://groups.google.com/group/google-summer-of-code-mentors-list/msg/0985e… [2] - http://google-opensource.blogspot.com/2010/10/google-code-in-schools-out-co… [3] - http://socghop.appspot.com/gci/org_app/take/gci_program/google/gci2010/orga… Cheers, Carol

1 0

Apps for Wine on ARM
by Detlef Riekenberg Oct. 18, 2010

Oct. 18, 2010

Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef

1 0

Re: [PATCH 7/8] jscript: Added VBArray.toArray() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6285 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/bindprot.c | 343 +++++++++++++++++++++++++++++------------------ > 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/8] jscript: Added VBArray.dimensions() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6283 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/8] jscript: Implement VBArray constructor
by Jacek Caban Oct. 18, 2010

Oct. 18, 2010

Hi Piotr, +(tmp = new VBArray(createArray())).f = Object.prototype.toString; +ok(tmp.f() === "[object Object]", "tmp.f() = " + tmp.f()); We have Function.call implemented now, you can use String.prototype.toString.call(new VBArray ...). + case DISPATCH_METHOD: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + VariantCopy(retv, arg); Please add error handling. Also a test would be nice, at least something like getVT(createArray()). + case DISPATCH_CONSTRUCT: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + hres = alloc_vbarray(ctx, NULL,&vbarray); + if(FAILED(hres)) + return hres; + SafeArrayCopy(V_ARRAY(arg),&vbarray->safearray); Error handling. (From 'PATCH 4/8] jscript: Added VBArray.ubound() implementation'): + if(retv) + num_set_val(retv, dim); num_set_val is for DOUBLE and eventually abused for integers out of VT_I4 range. You can set value directly here to avoid conversions. It might be a good idea to introduce something like var_set_int helper given that we could use it in quite a few places. (From '[PATCH 6/8] jscript: Added VBArray.getItem() implementation'): + size = arg_cnt(dp); + if(size< SafeArrayGetDim(vbarray->safearray)) + return throw_range_error(ctx, ei, IDS_SUBSCRIPT_OUT_OF_RANGE, NULL); + + indexes = heap_alloc(sizeof(int)*size); Error handling. (From '[PATCH 8/8] jscript: Added VBArray handling to to_object()'): -exception_test(function() {(new VBArray(createArray())).lbound("aaa");}, "RangeError", -2146828279); -exception_test(function() {(new VBArray(createArray())).lbound(3);}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound("aaa");}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound(3);}, "RangeError", -2146828279); There is no reason to change these tests, esp. that they were better before the change. Please add proper to_object tests, for example by calling Object() function or doing proper call on explicitly converted object. + SafeArrayCopy(sa,&vbarray->safearray); Error handling. Jacek

1 0

Re: [PATCH 4/8] jscript: Added VBArray.ubound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6282 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/8] jscrpt: Added VBScript.lbound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6281 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i > if (ret >= 0 && !used_default) > { > unix_name[pos + ret] = 0; > - if (!stat( unix_name, &st )) > + /* when checking case on a case insensitive but case preserving > + * fs, don't even bother doing the stat(), so we don't match the > + * file case-insensitively. > + */ > + if ((case_sensitive || !check_case) && !stat( unix_name, &st )) > { > if (is_win_dir) *is_win_dir = is_same_file( &windir, &st ); > return STATUS_SUCCESS; > } This still doesn't make sense. There's no reason to ever skip the stat. > @@ -2455,6 +2713,10 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer > const WCHAR *end, *next; > int is_win_dir = 0; > > + unix_name[pos] = 0; > + stat( unix_name, &st ); > + unix_name[pos] = '/'; You can't add extra stat calls to the normal path. This is supposed to be an optimization. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/8] jscript: Added VBArray stub
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6279 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In the proposed patch "[PATCH 2/2] ntdll: Check for case-insensitive volumes.", I found this piece: + /* Add a new entry */ + for (i = 0; i < sizeof(fs_cache)/sizeof(fs_cache[0]); i++) + if (fs_cache[i].dev == 0) + { + /* This entry is empty, use it */ + fs_cache[i].dev = dev; + fs_cache[i].fsid = fsid; + fs_cache[i].case_sensitive = case_sensitive; + } Maybe I'm missing something, but shouldn't you return from the function when finding a cache entry to fill? This seems to be filling every empty cache entry? HTH, Joris

2 1

About: msxml3: Partially implement ::setAttributeNode()
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: + name = xmlChar_from_wchar(nameW); + value = xmlChar_from_wchar(V_BSTR(&valueW)); + + if (!name || !value) + { + SysFreeString(nameW); + VariantClear(&valueW); + return E_OUTOFMEMORY; + } Wouldn't you need to free memory allocated for both name and value, in case one of the allocations succeeded ? HTH, Joris

2 1

Re: [1/4]winegstreamer: add wine gstreamer parser filter
by Damjan Jovanovic Oct. 18, 2010

Oct. 18, 2010

On Mon, Oct 18, 2010 at 3:26 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/winegstreamer/regsvr.c | 951 +++++++++++++++++++ Please consider IRegistrar or inf file based registration instead, regsvr.c is the worst way to support DLL registration, especially if you have to customize it the way you have. Damjan

1 0

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface
by Jacek Caban Oct. 18, 2010

Oct. 18, 2010

Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: > Get rid of ::get_dataType() forward to IXMLDOMNode interface > switch ( This->node->type ) { case XML_ELEMENT_NODE: On of points of such patches is to get rid of such switches. In this case it seems like introducing new helper return_null_var, adding FIXME to extityref implementation and moving element-specific part to element.c is way to go. Also it would be nice to have consistent TRACEs, so moving them to node-specific objects would be nice. Jacek

2 3

Re: [PATCH 3/3] winspool: Use UNICODE for CUPS printer names [fixes bug 6437]
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > or do we have to remove all related "const" from the strings? Yes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try4]
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > I was looking for a forbidden char in batch files but just I found accentuated chars whereas I wanted a single (not wide) char. > Finally, I found it in the ASCII table. > The \x1a character name is SUBSTITUTE and is exactly what we need. It means end of file on Windows, so it's not a good choice. Please don't add magic control chars, do a @space@ style of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] msxml3: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Hans Leidekker Oct. 18, 2010

Oct. 18, 2010

Hi Tomasz, Please use a more specific subject such as "mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in TranslateBitmapBits".

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Nikolay Sivov Oct. 17, 2010

Oct. 17, 2010

On 10/17/2010 22:46, Tomasz Michno wrote: > --- > dlls/mscms/tests/Makefile.in | 3 ++- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > > You forgot to add new file to a patch.

1 0

[PATCH] Compiling Wine at Ubuntu 10.10
by Gerold Jens Wucherpfennig Oct. 17, 2010

Oct. 17, 2010

You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. If you still get a compilation error in dlls/winex11.drv you will need to add the flag "-lXxf86vm". With kind regards, Gerold Jens Wucherpfennnig

4 5

Re: Set base direction of web site to RTL language for Hebrew
by Yaron Shahrabani Oct. 17, 2010

Oct. 17, 2010

Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...

2 4

Ubuntu Package Archive is back!
by Scott Ritchie Oct. 17, 2010

Oct. 17, 2010

When I switched Ubuntu package hosting to a launchpad PPA (away from manual .deb hosting), one thing lost was the ease of archiving old versions, since Launchpad doesn't provide this. I've written some scripts to manually copy the packages from the PPA to form a new archive and am hosting it at the old location http://wine.budgetdedicated.com/archive/ -- currently it carries all the Wine packages that have been on the Ubuntu Wine PPA since 1.3.3 or so. The main use of the archive is to aid in regression testing - installing from packages is much easier/quicker than recompiling from source, and will help you narrow down the last working/nonworking wine version before doing a proper git bisect. All I have to do is run the script every time I update the PPA with new Wine packages, and it's good. Due to server space issues, I don't plan to archive daily package builds (which is my next project). Thanks, Scott Ritchie

2 1

RTL in console windows
by Yaron Shahrabani Oct. 17, 2010

Oct. 17, 2010

Hi there guys, My name is Yaron Shahrabani and I'm an active translator of Wine to Hebrew. As probably some of you may know Hebrew is written from right-to-left meaning that the GUI and text rendering should work in a reversed/mirror order as opposed to Latin text. Due to some recent work doen by Alexander (Thanks! AJ, great work!), Hebrew is better supported now by wine GUI mechanism but as a translator I ran into some dillemas about the translation of strings that appear in console window, well apparently this is a tough question. Paul (Vriens) sent me 2 screenshots the other day that showed the way Hebrew is handled by the different command line platforms: The first one is the VTE (Virtual Terminal Emulator) which most of us know as gnome-vte or gnome-terminal, this app emulates a command line interface for X11. As opposed to Konsole (The same app only for KDE) gnome's vte cannot handle Hebrew correctly (is there any need to attach bugs or you'll just believe me?). gnome-terminal can show the Hebrew glyphs but they all appear in reversed order, same thing happens for wine apps that present a command line output (such as reg, ipconfig, etc.) when running via gnome-terminal. The other option to display and work with a CLI app is via wineconsole, since wineconsole does not support Hebrew our of the box we have to install the msttcorefonts package in order to do so. At the second screenshot that Paul sent me with the wineconsole screenshot of reg (I translated the app but since I'm not sure how it will work I haven't submitted it to wine-patches yet but I will send it here if needed) Ive seen some blanks with ":" at the end meaning that the glyphs were missing, few minutes later Paul sent me an updated screenshot after installing the missing glyphs, the Hebrew looked absolutely perfect, the only problem was that the semicolon still appeared to the right of the text instead of to the left (where the sentence ends in Hebrew). So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... I would love to clarify any misclarifications. Thank you all, Kind regards, Yaron Shahrabani <Hebrew translator>

2 2