October 2010 - Wine-Devel - list.winehq.org

Re: comdlg32: Added Hebrew translation.
by Yaron Shahrabani Oct. 26, 2010

Oct. 26, 2010

What is wrong with the patch? Yaron Shahrabani <Hebrew translator> 2010/10/23 Yaron Shahrabani <sh.yaron(a)gmail.com> > Verified by Paul Vriens >

2 1

ddraw: Add tests for the foreground window set by SetCooperativeLevel
by David Adam Oct. 26, 2010

Oct. 26, 2010

Any problems with patch? A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2010/10/24 Subject: ddraw: Add tests for the foreground window set by SetCooperativeLevel To: wine-patches <wine-patches(a)winehq.org>

2 2

comdlg32/cdlg: removed 16 bit dependency
by CJ Oct. 25, 2010

Oct. 25, 2010

Removed wownt32.h from the includes of cdlg32.h and modified fontdlg.c so that it no longer relies on the 16 bit dependency. -- Carl J. Raffaele

2 1

Re: msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()
by Jacek Caban Oct. 25, 2010

Oct. 25, 2010

On 10/25/10 10:38 PM, Nikolay Sivov wrote: > Should help with http://bugs.winehq.org/show_bug.cgi?id=22607 > > > + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = SysAllocString(data); - hr = node_put_value(node_obj,&v_data); Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here? Jacek

2 1

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Vitaliy Margolen Oct. 25, 2010

Oct. 25, 2010

On 10/25/2010 07:45 AM, Aric Stewart wrote: > --- > + ERR("++++++++++++++++ perform byte seek ------------------\n"); > + if (1 || This->initial) { > + ERR("Relinked\n"); > + FIXME("Seeking %i %i\n", format, GST_FORMAT_BYTES); > + FIXME("using \"%s\"\n", name); Some debug leftovers? > + AM_MEDIA_TYPE amt = { }; > .. > + ZeroMemory(&amt, sizeof(amt)); This is redundant. > sizeof(piOutput.achName) / sizeof(*piOutput.achName) The more common construct in Wine is sizeof(array)/sizeof(array[0]). IMHO it's better to stick with one Also could you please put an empty line in each function after variable declarations? Your patches look inconsistent. Vitaliy.

2 1

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation. Take 2.
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch makes sure that "Shell_TrayWnd" window doesn't have a caption > since some apps depend on it being empty. The bug #20129 lists one of such > applications. It does FindWindow("Shell_TrayWnd", "") and expects that it > returns a valid tray window handle. This looks ugly when moving the window. The real systray should most likely be kept off-screen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > server/console.c | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) It's not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so console.c && touch console.ok console.c:789: Test failed: Shouldn't succeed console.c:790: Test failed: GetLastError: expecting 6 got 0 make: *** [console.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: added one missing buffersize check in URLCache_CopyEntry (Coverity)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > CID 831, indirectly spotted by Coverity, one missing > check for (*lpdwBufferSize >= dwRequiredSize) added. It doesn't work: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so urlcache.c && touch urlcache.ok urlcache.c:219: Test failed: RetrieveUrlCacheEntryFile failed with error 122 wine: Unhandled page fault on read access to 0x00000000 at address 0x6820cb08 (thread 0028), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [Kernel32]: don't force winedbg startup when no AeDebug key is present (#24524)
by Alexandre Julliard Oct. 25, 2010

Oct. 25, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > - cmdline = HeapAlloc(GetProcessHeap(), 0, 80); > - snprintf(cmdline, 80, "winedbg --auto %ld %ld", /* as in tools/wine.inf */ > - (long)GetCurrentProcessId(), (long)HandleToLong(hEvent)); > + /* no AeDebug key present, just kill the program */ > + return FALSE; This means you don't get a backtrace if there's a crash before the initial registry creation is complete. I don't think that's a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] [Msvcrt]: put in place the full scheme for paramter validation (the _s family of functions)
by Piotr Caban Oct. 24, 2010

Oct. 24, 2010

Hi, Only debugging version of the dll is passing data to invalid_paramter_handler. I guess it's why we shouldn't do it. There already is a test for it in msvcr90 (see strtoi64 tests). Because it was not strict enough it will not show it very well. Currently it will not show that it was expecting invalid_parameter_handler to be invoked (but will fail checking errno that should not be changed). Of course this behavior may vary between msvcrXX dlls, I have tested it only with msvcr90 and msvcrt on Windows XP. Cheers, Piotr

1 0