November 2010 - Wine-Devel - list.winehq.org

Re: [try 2] crypt32/tests: Add tests for enveloped messages.
by Marvin Nov. 1, 2010

Nov. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6658 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg: unhandled exception c0000005 at 5CF308F4

1 0

[do not apply] Re: crypt32/tests: Add tests for enveloped messages.
by Alexander Morozov Nov. 1, 2010

Nov. 1, 2010

Please do not apply this patch. Use [try 2]

1 0

Re: [PATCH 2/2] comdlg32/tests: Add GetSaveFileName extension tests.
by Marvin Nov. 1, 2010

Nov. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6657 Your paranoid android. === W98SE (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WNT4WSSP6 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2KPROSP4 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WXPPROSP3 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2K3R2SESP2 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WVISTAADM (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2K8SE (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W7PRO (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W7PROX64 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 750B4C19 === W7PROX64 (64 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef

1 0

Re: [4/4] d3d9: Add a sRGB format test
by Henri Verbeet Nov. 1, 2010

Nov. 1, 2010

On 1 November 2010 11:41, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > Am 01.11.2010 um 10:41 schrieb Henri Verbeet: > >> On 31 October 2010 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >>> + static const struct >>> + { >>> + float x, y, z; >>> + float u, v; >>> + } >>> + quad[] = >>> + { >>> + {-1.0, -1.0, 0.1, 0.0, 0.0}, >>> + {-1.0, 1.0, 0.1, 1.0, 0.0}, >>> + { 1.0, -1.0, 0.1, 0.0, 1.0}, >>> + { 1.0, 1.0, 0.1, 1.0, 1.0} >>> + }; >> Not that I care all that much, but notice that those literals are >> actually doubles. > Now that I've fixed a number of those I guess we should stick to caring about that. You should probably do the Clear()'s too then.

1 0

Re: [PATCH 2/4] include: Add macros for retrieving control message headers.
by Alexandre Julliard Nov. 1, 2010

Nov. 1, 2010

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -185,6 +185,25 @@ VOID WINAPI GetAcceptExSockaddrs(PVOID, DWORD, DWORD, DWORD, struct WS(sockaddr) > BOOL WINAPI TransmitFile(SOCKET, HANDLE, DWORD, DWORD, LPOVERLAPPED, LPTRANSMIT_FILE_BUFFERS, DWORD); > INT WINAPI WSARecvEx(SOCKET, char *, INT, INT *); > > +/* > + * Macros for retrieving control message data returned by WSARecvMsg() > + */ > +#define WSA_CMSG_DATA(cmsg) ((UCHAR*)((WSACMSGHDR*)(cmsg)+1)) > +#define WSA_CMSG_FIRSTHDR(mhdr) \ > + ((size_t) (mhdr)->Control.len >= sizeof(WSACMSGHDR) \ > + ? (WSACMSGHDR *) (mhdr)->Control.buf : (WSACMSGHDR *) 0) > +#define WSA_CMSG_ALIGN(len) (((len) + sizeof (size_t) - 1) \ > + & (size_t) ~(sizeof (size_t) - 1)) > +static inline WSACMSGHDR *WSA_CMSG_NXTHDR(WSAMSG *msg, WSACMSGHDR *cmsg) > +{ > + if ((size_t)(msg)->Control.len<sizeof(WSACMSGHDR)) return 0; > + cmsg = (WSACMSGHDR*)((unsigned char*)cmsg + WSA_CMSG_ALIGN(cmsg->cmsg_len)); > + if ((unsigned char*)(cmsg+1) > ((unsigned char*)msg->Control.buf + msg->Control.len) > + || ((unsigned char*)cmsg + WSA_CMSG_ALIGN(cmsg->cmsg_len) > ((unsigned char *)msg->Control.buf + msg->Control.len)) ) > + return 0; > + return cmsg; > +} This should go into ws2def.h. Also WSA_CMSG_NXTHDR is supposed to be a macro, not an inline function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] d3d9: Add a sRGB format test
by Henri Verbeet Nov. 1, 2010

Nov. 1, 2010

On 31 October 2010 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + static const struct > + { > + float x, y, z; > + float u, v; > + } > + quad[] = > + { > + {-1.0, -1.0, 0.1, 0.0, 0.0}, > + {-1.0, 1.0, 0.1, 1.0, 0.0}, > + { 1.0, -1.0, 0.1, 0.0, 1.0}, > + { 1.0, 1.0, 0.1, 1.0, 1.0} > + }; Not that I care all that much, but notice that those literals are actually doubles. > + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, quad, sizeof(float) * 5); Now that you're using a proper structure for "quad", "sizeof(float) * 5" is really just the same as "sizeof(*quad)".

1 0

Problems with Test
by James McKenzie Nov. 1, 2010

Nov. 1, 2010

All: I'm trying to convert one integer number using a float number factor. Here is the code: int ry = 125; double ryf; ryf = ry/1440; The result is 0 and should be 0.06666666667 (or even more sixes.) BTW, if I change ry to 1440 the result is 1.00000. What am I doing 'incorrectly'? James McKenzie

2 1