November 2010 - Wine-Devel - list.winehq.org

how to use wcslen() in wine?
by 飞翔 Nov. 15, 2010

Nov. 15, 2010

hello, I'm developing under Wine environment. I'm using Unicode and I want to be able to use standard library call wcslen, but I don't know how to change my C library from the native glibc C library to the msvcrt C library. As it is described in "Winelib_User's_Guide":"In these cases you should use msvcrt to provide your C runtime calls. import msvcrt.dll to your applications .spec file." I'm using wineg++ to compile the .cpp & .h files, there is no .spec file, how can I import the DLL? May you please help me? Thanks very much! ------------------ Where there is a will, there is a way! ------------------ 丁耿佳 Gavin-Ding Computer Science and Technology， South China University of Technology Email: gj.ding(a)mail.scut.edu.cn gengjia.ding(a)gmail.com gengjia.ding(a)qq.com Mailing Address: 339, Building C12, SCUT, Guangzhou Higher Education Mega Center, Guangzhou, China Postcode:510006

2 1

Kernel APC in Wine?
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 15, 2010

Nov. 15, 2010

Hi, my WINMM callback tests (cf. bug #3930, comments 37+38) showed that most MOM_ callbacks were executed in my own thread! The only way I know how to achieve this is to use an APC as in QueueUserAPC(). However, reading MSDN again, it seems like user-mode APC are never invoked unless the app uses the Wait*Ex() functions instead of the regular ones likes WaitForMultipleObjects() or Sleep(). As I can't expect a random app to use these, I assume that either - something confused me and I'm on the wrong track, or - native's winmm uses kernel APC, not user ones, and kernel APC are invoked even with plain Wait* calls, or - user APC are executed with plain Sleep/Wait*() (non ~Ex) too. Does Wine have something like kernel APC? What other mechanism exist that could allow a player loop inside WINMM to invoke callbacks in the application's thread context? BTW, I find it's a good idea from MS to execute callbacks in the caller's thread. This avoids common pitfalls and nasty bugs. Is there potential trouble with APC in Wine on 64 bit? MSDN recommends against posting an APC to a thread in another process. Thank you for your help, Jörg Höhle

1 0

Re: winecoreaudio: OSStatus is not necessarily a FOURCC.
by Michael Stefaniuc Nov. 15, 2010

Nov. 15, 2010

Hi! Joerg-Cyril.Hoehle(a)t-systems.com wrote: > This fixes the string from midi.ok mentioned in bug #21589 > err:wave:AudioUnit_GetVolume > AudioUnitGetParameter return an error "\xff\xff\xd5\x8e" > Now it will print a signed integer instead: > -10866 aka. kAudioUnitErr_InvalidScope > > As to whether that function should stay "inline", I don't know. Doesn't really matter as "inline" is just a hint to the compiler and the compiler is free to ignore it. bye michael

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::swap implementation.
by Piotr Caban Nov. 15, 2010

Nov. 15, 2010

On 11/11/10 18:55, Vincas Miliūnas wrote: > This implementation handles cases when basic_strings are allocated using different allocators, however WINE's implementation seems to ignore allocators. It's not ignoring allocators (but it's not setting allocator field). There's no legal way of accessing it by end user, so there's no point of setting it, unless it's needed internally (and it's not needed for correct implementation of basic_string_char_swap function). +/* Helper function for MSVCP_basic_string_char_swap */ +void basic_string_char_swap_bufxptr_same_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char * const ptr = rhs->data.ptr; + const size_t size = rhs->size; + const size_t res = rhs->res; + + memcpy(rhs->data.buf, lhs->data.buf, lhs->size * sizeof(char)); This function should work in constant time. It should only swap pointers and lengths. +/* Helper function for MSVCP_basic_string_char_swap */ +MSVCP_BOOL basic_string_char_swap_bufxptr_diff_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char tmp[BUF_SIZE_CHAR]; + const size_t size = lhs->size; + const size_t res = lhs->res; + memcpy(tmp, lhs->data.buf, lhs->size * sizeof(char)); + + char * const ptr = MSVCP_allocator_char_allocate(lhs->allocator, rhs->res); You can't pass unknown data to MSVCP_allocator_char_allocate, this is the implementation of default char allocator. When other allocators are in use compiler will use templates. The function you're implementing is only used when two basic_string_char are swapped, because there's no legal way of modifying allocator field there's only one case - the same allocators are used. Cheers, Piotr

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by James McKenzie Nov. 14, 2010

Nov. 14, 2010

On 11/5/10 8:17 AM, Charles Davis wrote: > Changes since try 5: > o All case-sensitivity logic has been absorbed into find_file_in_dir(). > o Eliminated one more stat(2) that I missed last time. > o Eliminated a statfs(2) call on Linux. > > This is a far as I think I can take it without gutting it completely. If > any of you have better ideas, I'd like to hear them. > --- > dlls/ntdll/directory.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 229 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c > index 865c2fa..2891792 100644 > --- a/dlls/ntdll/directory.c > +++ b/dlls/ntdll/directory.c > @@ -41,6 +41,9 @@ > #ifdef HAVE_SYS_STAT_H > # include<sys/stat.h> > #endif > +#ifdef HAVE_SYS_ATTR_H > +#include<sys/attr.h> > +#endif > #ifdef HAVE_SYS_IOCTL_H > #include<sys/ioctl.h> > #endif > @@ -56,6 +59,9 @@ > #ifdef HAVE_SYS_MOUNT_H > #include<sys/mount.h> > #endif > +#ifdef HAVE_SYS_STATFS_H > +#include<sys/statfs.h> > +#endif > #include<time.h> > #ifdef HAVE_UNISTD_H > # include<unistd.h> > @@ -130,6 +136,35 @@ static inline int getdents64( int fd, char *de, unsigned int size ) > > #endif /* linux */ > > +#if defined(HAVE_GETATTRLIST) > + > +struct get_fsid > +{ > + ULONG size; > + dev_t dev; > + fsid_t fsid; > +}; > + > +struct fs_cache > +{ > + dev_t dev; > + fsid_t fsid; > + BOOLEAN case_sensitive; > +} fs_cache[64]; > + > +#if defined(ATTR_VOL_CAPABILITIES)&& defined(VOL_CAPABILITIES_FORMAT)&& \ > + defined(VOL_CAP_FMT_CASE_SENSITIVE) > + > +struct vol_caps > +{ > + ULONG size; > + vol_capabilities_attr_t caps; > +}; > + > +#endif /* ATTR_VOL_CAPABILITIES */ > + > +#endif /* HAVE_GETATTRLIST */ > + > #define IS_OPTION_TRUE(ch) ((ch) == 'y' || (ch) == 'Y' || (ch) == 't' || (ch) == 'T' || (ch) == '1') > #define IS_SEPARATOR(ch) ((ch) == '\\' || (ch) == '/') > > @@ -783,6 +818,192 @@ static char *get_device_mount_point( dev_t dev ) > } > > > + > +#ifdef HAVE_GETATTRLIST > +/*********************************************************************** > + * look_up_fs_cache > + * > + * Checks if the specified file system is in the cache. > + */ > +static struct fs_cache *look_up_fs_cache( dev_t dev ) > +{ > + int i; > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == dev) > + return fs_cache+i; > + return NULL; > +} > + > +/*********************************************************************** > + * add_fs_cache > + * > + * Adds the specified file system to the cache. > + */ > +static void add_fs_cache( dev_t dev, fsid_t fsid, BOOLEAN case_sensitive ) > +{ > + int i; > + struct fs_cache *entry = look_up_fs_cache( dev ); > + static int once = 0; > + if (entry) > + { > + /* Update the cache */ > + entry->fsid = fsid; > + entry->case_sensitive = case_sensitive; > + return; > + } > + > + /* Add a new entry */ > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == 0) > + { > + /* This entry is empty, use it */ > + fs_cache[i].dev = dev; > + fs_cache[i].fsid = fsid; > + fs_cache[i].case_sensitive = case_sensitive; > + return; > + } > + > + /* Cache is out of space, warn */ > + if (once++) > + WARN( "FS cache is out of space, expect performance problems\n" ); > +} > +#endif > + > +/*********************************************************************** > + * get_dir_case_sensitivity > + * > + * Checks if the volume containing the specified directory is case > + * sensitive or not. > + */ > +static BOOLEAN get_dir_case_sensitivity( const char *dir ) > +{ > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + struct statfs stfs; > +#elif defined(__NetBSD__) > + struct statvfs stfs; > +#elif defined(__linux__) > + struct stat st; > + char *cifile; > +#endif > + > +#if defined(HAVE_GETATTRLIST)&& defined(ATTR_VOL_CAPABILITIES)&& \ > + defined(VOL_CAPABILITIES_FORMAT)&& defined(VOL_CAP_FMT_CASE_SENSITIVE) > + char *mntpoint = NULL; > + struct attrlist attr; > + struct vol_caps caps; > + struct get_fsid get_fsid; > + struct fs_cache *entry; > + > + /* First get the FS ID of the volume */ > + attr.bitmapcount = ATTR_BIT_MAP_COUNT; > + attr.reserved = 0; > + attr.commonattr = ATTR_CMN_DEVID|ATTR_CMN_FSID; > + attr.volattr = attr.dirattr = attr.fileattr = attr.forkattr = 0; > + get_fsid.size = 0; > + if (getattrlist( dir,&attr,&get_fsid, sizeof(get_fsid), 0 ) != 0 || > + get_fsid.size != sizeof(get_fsid)) > + return TRUE; > + /* Try to look it up in the cache */ > + entry = look_up_fs_cache( get_fsid.dev ); > + if (entry&& !memcmp(&entry->fsid,&get_fsid.fsid, sizeof(fsid_t) )) > + /* Cache lookup succeeded */ > + return entry->case_sensitive; > + /* Cache is stale at this point, we have to update it */ > + > + mntpoint = get_device_mount_point( get_fsid.dev ); > + /* Now look up the case-sensitivity */ > + attr.commonattr = 0; > + attr.volattr = ATTR_VOL_INFO|ATTR_VOL_CAPABILITIES; > + if (getattrlist( mntpoint,&attr,&caps, sizeof(caps), 0 ) == 0) > + { > + if (caps.size == sizeof(caps)&& > + (caps.caps.valid[VOL_CAPABILITIES_FORMAT]& > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) == > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) > + { > + BOOLEAN ret; > + > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + if ((caps.caps.capabilities[VOL_CAPABILITIES_FORMAT]& > + VOL_CAP_FMT_CASE_SENSITIVE) != VOL_CAP_FMT_CASE_SENSITIVE) > + ret = FALSE; > + ret = TRUE; > + /* Update the cache */ > + add_fs_cache( get_fsid.dev, get_fsid.fsid, ret ); > + return ret; > + } > + } > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + /* Fall through */ > +#endif > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + statfs( dir,&stfs ); > + /* Assume these file systems are always case insensitive on Mac OS. Don't do this. Quake2 and quake2 turn out to be different (and I tried to move to a directory called Quake2 using cd $HOME/wine.../drive_c/quake2 and received an error this morning [Yes, I'm playing Quake2 on my Mac, I really, really need the stress relief, it is really hard to explain.}) > + * For FreeBSD, only assume CIOPFS is case insensitive (AFAIK, Mac OS > + * is the only UNIX that supports case-insensitive lookup). > + */

2 1

Haiku talking about wine
by Dan Kegel Nov. 14, 2010

Nov. 14, 2010

Seems to have been a long thread recently about restarting a port of Wine to Haiku, see http://haikuware.com/bounty-discussion/1533-wine-bounty I don't think there was anything really happening, though.

1 0

Re: [PATCH] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet Nov. 14, 2010

Nov. 14, 2010

2010/11/14 Rico Schüller <kgbricola(a)web.de>: > +HRESULT d3dcompiler_shader_reflection_init(const void *data, SIZE_T data_size, void **reflector) Allocation and initialization are different things. Either way, it's unnecessary to make "reflector" void **. > + if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection)) > { > - ERR("Failed to allocate D3D compiler shader reflection object memory\n"); > - return E_OUTOFMEMORY; > + WARN("Wrong riid %s, accept only %s!\n", debugstr_guid(riid), debugstr_guid(&IID_ID3D11ShaderReflection)); > + return E_FAIL; > } I'm not sure if you have tests for this returning E_FAIL, but typically you'd expect E_NOINTERFACE for something like that.

1 0

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet Nov. 14, 2010

Nov. 14, 2010

On 12 November 2010 21:08, Travis Athougies <iammisc(a)gmail.com> wrote: > + static struct hlsl_probe_info sin_probes[] = This should be const. As a general rule, try to pay attention to at least other patches to the same module. I fixed a couple of these about two weeks ago. Same goes for calculating the probe count. > + { > + {0, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {1, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {2, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {3, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {4, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {5, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {6, 0, {0.9620f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {7, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {8, 0, {1.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {9, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {10, 0, {0.9619f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {11, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {12, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {13, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {14, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {15, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {16, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {17, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {18, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {19, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {20, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {21, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {22, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {23, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {24, 0, {0.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {25, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {26, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {27, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {28, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {29, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {30, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {31, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + }; > + 32 probes is probably a bit excessive, but I guess it's not a major problem. Note that you can easily return the cosine results in the .y component though, instead of duplicating the complete test.

1 0

Re: wined3d: remove a useless variable
by Nikolay Sivov Nov. 14, 2010

Nov. 14, 2010

On 11/14/2010 22:17, David Adam wrote: > if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > return; > } Why is it useless?

2 3

Re: wined3d: remove a useless variable
by André Hentschel Nov. 14, 2010

Nov. 14, 2010

> > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > Why is that useless? It supresses console flooding. -- Best Regards, André Hentschel

1 0

Re: [msi/tests] Cleanup properly on Win9x
by Marvin Nov. 14, 2010

Nov. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7053 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [PATCH 10/10] mshtml: Added document fragment cloneNode implementation.
by Marvin Nov. 14, 2010

Nov. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7048 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/10] mshtml: Correctly handle DOCUMENT_FRAGMENT_NODE in IHTMLDOMNode::get_nodeType.
by Marvin Nov. 14, 2010

Nov. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7045 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [5/5] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin Nov. 14, 2010

Nov. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7042 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [4/4] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin Nov. 14, 2010

Nov. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Compilation error with latest wine
by Luca Bennati Nov. 14, 2010

Nov. 14, 2010

I get this: registrar.c: In function ‘DllGetClassObject’: registrar.c:747:18: error: ‘CLSID_Registrar’ undeclared (first use in this function) registrar.c:747:18: note: each undeclared identifier is reported only once for each function it appears in registrar.c: In function ‘do_register_server’: registrar.c:796:22: error: ‘CLSID_Registrar’ undeclared (first use in this function) make[1]: *** [registrar.o] Error 1 make[1]: Leaving directory `/home/luca/wine-git/dlls/atl' make: *** [dlls/atl] Error 2 make: *** Waiting for unfinished jobs.... I'm compiling with "CFLAGS=' -g -O0 -pipe' CXXFLAGS=' -g -O0 -pipe' ./configure --prefix=/usr --sysconfdir=/etc --with-x --without-capi --without-gsm --without-icns" after a make distclean What's wrong here?

6 8

Re: widl: Fix for typelib generation when unaligned access to memory is not allowed
by Marcus Meissner Nov. 13, 2010

Nov. 13, 2010

On Sat, Nov 13, 2010 at 07:02:02PM +0100, André Hentschel wrote: > caused a "Bus error" on sparc > --- > tools/widl/write_msft.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index da4eb25..5175b73 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -1208,7 +1208,11 @@ static void write_value(msft_typelib_t* typelib, int *out, int vt, const void *v > int len = strlen(s), seg_len = (len + 6 + 3) & ~0x3; > int offset = ctl2_alloc_segment(typelib, MSFT_SEG_CUSTDATA, seg_len, 0); > *((unsigned short *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset]) = vt; > - *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#ifdef ALLOW_UNALIGNED_ACCESS > + *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#else > + memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2], &len, sizeof(len)); > +#endif > memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+6], value, len); Just do the memcpy unconditional. Ciao, Marcus

1 0

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify
by Marvin Nov. 13, 2010

Nov. 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7032 Your paranoid android. === W98SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called === WNT4WSSP6 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2KPROSP4 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === WVISTAADM (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2K8SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PRO (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (64 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called

2 1

Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)
by Paul Vriens Nov. 13, 2010

Nov. 13, 2010

On 11/06/2010 11:16 AM, Bernhard Übelacker wrote: > Hello, > this patch checks for correct arrival of messages to a subclassed property page. > > For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically > the first WM_SIZE message is interesting which is not sent in wine. > > I have changed the patch based on the feedback I got on my first mail. > (http://www.winehq.org/pipermail/wine-devel/2010-October/087474.html) > > Now I am using the msg.h facilities for checking the messages. > > Kind regards, > Bernhard > Hi, Ever since this patch the shell32:shlexec tests fail on NT4 and W2K: http://test.winehq.org/data/tests/shell32:shlexec.html I can reproduce easily by running (on a clean Windows box): winetest-latest.exe comctl32:propsheet shell32:shlexec This will throw some error dialog boxes and I'm also unable to double-click items in the "Windows Explorer". Thoughts/Ideas/Suggestions? -- Cheers, Paul.

2 2

Re: regedit: add a manpage
by Alexandre Julliard Nov. 13, 2010

Nov. 13, 2010

Austin English <austinenglish(a)gmail.com> writes: > While looking at the Debian Wine sources, I found they have manpages > for several of our bulitin programs :-) Then you should ask them to submit patches. You can't just grab the manpages and submit under your name. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: loader: On Mac, reserve the process's original thread for the frameworks. (try 2)
by Alexandre Julliard Nov. 13, 2010

Nov. 13, 2010

Ken Thomases <ken(a)codeweavers.com> writes: > + { > + CFRunLoopAddSource( CFRunLoopGetMain(), source, kCFRunLoopCommonModes ); > + CFRunLoopSourceSignal( source ); > + CFRunLoopWakeUp( CFRunLoopGetMain() ); > + CFRelease( source ); > + > + /* This is a hack. We want to wait until the main thread has > + * really exited in response to our signal. However, Mac OS X > + * doesn't let us join the main thread for whatever reason. > + * It results in a SIGBUS. So, we just sleep for a bit and hope > + * it got enough time. */ > + usleep(100); We need something more reliable than this. (The pthread_join crash is a bug in libsystem, I filed a bug a while back but haven't heard anything). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] ntdll/tests: Added qsort_s tests. (try 5)
by Marvin Nov. 13, 2010

Nov. 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7037 Your paranoid android. === WVISTAADM (32 bit string) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Help with 'WineAPI' wiki
by Max TenEyck Woodbury Nov. 12, 2010

Nov. 12, 2010

As I mentioned before, I am trying to establish a place where the Windows API can be discussed that is not under the control of Microsoft. While the name I have chosen is debatable, it is not beyond reason and conveys enough about its intended contents that it should not be too hard to find. It currently consists of two major pieces: * The Wine piece follows the distribution directory structure with pages for each directory and many of the files. * The API piece currently consists of an index of all the APIs I found in the .spec files. * Other projects that use the windows API can put the information specific to their project in directory trees similar to the one I have set up for Wine. I am having a few specific problems: * Some of the .spec files contain more information than can be displayed on a single Wiki page. This information has to be split up into a reasonable number of sub-pages and organized so the information needed can be found fairly easily. I can handle the technical aspects of setting up the pages, and have some idea of where the splits should be, but I am uncertain enough that I want advice. * This is the first Wiki I have had administrative responsibility for and I frankly do not know what I am doing. Advice and help with the administration of the Wiki and the project would help. * Some of the technical choices have been based on my technical limits. I am simply ignorant of possible alternatives. Again, I think advice would help. * I know some of the sections are just plain ugly. I am mostly concerned with getting accurate and current information into the Wiki at this point, but the presentation does need improvement and again, I think some advice would be helpful. * My dyslexia has bitten me more than once. Someone to review what I am doing might help. - Max

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by Charles Davis Nov. 12, 2010

Nov. 12, 2010

What's wrong now? Chip

1 1

re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7
by Dan Kegel Nov. 12, 2010

Nov. 12, 2010

I think that's a clue that you need a better name than 'i'. Maybe 'fixme_shown'.

1 0