November 2010 - Wine-Devel - list.winehq.org

PGP key signing party at WineConf
by Shachar Shemesh Nov. 8, 2010

Nov. 8, 2010

Hi all, During WineConf we will be holding a key signing party, organized by your truly. The wiki page for WineConf has been updated with details on how to participate, and I have set up a page explaining the process for people who have never participated before. Please email your keys to me, with the subject "WineConf key signing" (so that my spam filters don't eat it up). The wineconf wiki page, in case you are not up to date, is at http://wiki.winehq.org/WineConf2010 The key signing page is at http://wiki.winehq.org/KeySigningParty Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

2 2

Strange test bot results
by Eric Pouech Nov. 7, 2010

Nov. 7, 2010

Hi Ge, how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [PATCH 2/6] [Msvcrt*]: now using the macros for parameter checking for wcsncat_s (and fixed the test)
by Marvin Nov. 7, 2010

Nov. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6861 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9

1 0

Re: [PATCH 1/6] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Marvin Nov. 7, 2010

Nov. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6859 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9

1 0

Re: [PATCH 2/4] quartz: Fix PullPin_EnumMediaTypes
by Erich Hoover Nov. 7, 2010

Nov. 7, 2010

Is there some reason you chose to add an additional function for this, rather than fill in pPinImpl->pin.pFuncsTable? I ask because I was working on this issue last night and submitted an attachment to Bug #24782 for people to try: http://bugs2.winehq.org/attachment.cgi?id=31770 Erich Hoover ehoover(a)mines.edu

2 1

Re: [PATCH 3/4] mshtml: Added IDispatchEx support to HTMLStyleSheetsCollection object.
by Marvin Nov. 7, 2010

Nov. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6856 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PRO (32 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (32 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (64 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}

1 0

Re: [PATCH 2/4] mshtml: Added IOmNavigator::get_plugins implementation.
by Marvin Nov. 7, 2010

Nov. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6855 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PRO (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (64 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}

1 0

Re: [PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.
by Alexandre Julliard Nov. 7, 2010

Nov. 7, 2010

Austin Lund <austin.lund(a)gmail.com> writes: > +static void init_tbsize_results(void) { > + tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t)); > + tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, { > + { 0, 2, 23, 24}, { 23, 2, 46, 24}, { 46, 2, 54, 24}, > + { 54, 2, 77, 24}, { 77, 2, 100, 24} } }; That syntax is not portable, please avoid it. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet Nov. 7, 2010

Nov. 7, 2010

On 2 November 2010 07:20, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Repeatedly call a shader 32 times with linearly varying values and test the results against > + an array of floats using the given epsilon */ Why can't this just use the existing framework?

2 1

Re: jscript: Added Date.setYear stub implementation.
by Marvin Nov. 6, 2010

Nov. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6844 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

New winetricks 20101106: mostly just bugfixes and updates
by Dan Kegel Nov. 6, 2010

Nov. 6, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English - add amstream verb - bump firefox to 3.6.12 - fix dotnet11 install on recent wine - if user is using a 64-bit prefix, tell them how to create a 32-bit one instead. - initial 64-bit cleanup - update eadm sha1sum - update flash sha1sum - update utorrent sha1sum - don't initialize wine just to show the help menu. (Issue 182) - version shouldn't initialize Wine either (part 2 of Issue 182). Dan Kegel - update shockwave, utorrent sha1sum - added verbs l3codecx and dmsynth, and added devenum to directmusic; for winehq bug 24911 - allow continuing partial downloads if WINETRICKS_CONTINUE_DOWNLOAD is set

2 2

Re: Voting for bugs (Was: Re: [Bug 20969])
by James Mckenzie Nov. 6, 2010

Nov. 6, 2010

Tom Spear <speeddymon(a)gmail.com> wrote: [Message arranged in top to bottom posting order to comply with mailing list rules/guidelines] >On Tue, Nov 2, 2010 at 12:01 PM, <wine-bugs(a)winehq.org> wrote: > >> http://bugs.winehq.org/show_bug.cgi?id=20969 >> >> --- Comment #19 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-11-02 >> 12:01:23 CDT --- >> (In reply to comment #18) >> > Those of you with this issue, make sure you vote for this in bugzilla so >> that >> > it can be confirmed, if you haven't already. >> >> Voting for bugs in Wine bugzilla is useless and does nothing except adding >> noise. >> > >Can/should voting for bugs be disabled if it is 'useless and does nothing >except adding noise'? > >Thanks > >Tom > > Tom: Voting for bugs does two things, and I don't think Dmitry wants to do the first: 1. It confirms that a bug does exists and possibly on multiple platforms. 2. It advises developers that more than one system/configuration is affected by a bug. I agree that adding thousands of votes to a long standing bug is 'noise'. Given that we have a limited resource of developers, having users verify bugs and to vote for them to give an idea of how severe a bug is might be helpful. Just my .02 USD here. James McKenzie

6 8

re: Function strstr and MinGW
by Dan Kegel Nov. 5, 2010

Nov. 5, 2010

You forgot to null-terminate escaped_space[].

1 0

Re: Function strstr and MinGW
by GOUJON Alexandre Nov. 5, 2010

Nov. 5, 2010

On 11/05/2010 09:11 PM, Ozan Türkyılmaz wrote: > \0 ending? > I think you're right. I forgot '\0' at the end of escaped_space. That's so stupid ! Well, sorry for the noise and thanks for your help. It remember me a sentence a teacher told me: "When there are errors, we know a program doesn't work but when he runs fine, we're not sure it doesn't contains any error" So thanks again !

1 0

Function strstr and MinGW
by GOUJON Alexandre Nov. 5, 2010

Nov. 5, 2010

Hi everyone, I'm still trying to improve wine cmd but I'm stuck with my patch making tests failing. After some investigations, I've found that my function which replace all @space@ by real spaces does not always work. So I've written a test_case (attached code). It runs perfectly on Ubuntu (compiled with gcc) but does nothing on Windows (compiled with i586-mingw32msvc-gcc). In fact, on windows, strstr fails and so never goes into the while{ } loop. Is MinGW the culprit ? Should I use another function ? Any idea ? [Why *standard* function don't even work on Windows ?] Thanks in advance !

2 1

Re: [PATCH 2/2] slc/tests: Add tests for SLGetWindowsInformationDWORD [try 2]
by Marvin Nov. 5, 2010

Nov. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6829 Your paranoid android. === WVISTAADM (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W2K8SE (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PRO (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PROX64 (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PROX64 (64 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED)

1 0

Re: [PATCH 5/5] quartz: Remove position from filtergraph
by Alexandre Julliard Nov. 5, 2010

Nov. 5, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > --- > dlls/quartz/filtergraph.c | 59 +++++++++++++++++++------------------------- > 1 files changed, 26 insertions(+), 33 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok filtergraph.c:272: Test failed: GetCurrentPosition failed: 80004001 filtergraph.c:283: Test failed: GetCurrentPosition failed: 80004001 make: *** [filtergraph.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: raise ulimit -n if possible, warn if very low
by Alexandre Julliard Nov. 5, 2010

Nov. 5, 2010

Dan Kegel <dank(a)kegel.com> writes: > void sock_init(void) > { > + struct rlimit lim; > + > + if (!getrlimit(RLIMIT_NOFILE, &lim) && lim.rlim_cur < lim.rlim_max) { > + lim.rlim_cur = lim.rlim_max; > + setrlimit(RLIMIT_NOFILE, &lim); > + } This is already done in the Wine loader, there's no need to do it twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Transparent windows
by Vassilis Virvilis Nov. 5, 2010

Nov. 5, 2010

Hi everybody, I am trying to run a pretty complex dotnet (3.5) app which renders flash contents via flash in a box http://www.f-in-box.com/ I have to say that congratulations are in order to everybody involved because the whole thing works remarkably well for such a complex amalgam of technologies and platforms. The problem I am trying to debug right now is that transparent windows comes out black in wine. So the question is: 1) What are the wine debug channels I have to turn on in order to understand what's happening? 2) Any ideas where the code responsible might be located (gdi, user32, wineserver)? 2a) Is it some window creation flag responsible for this? 2b) Is it X-Window dependent? Does it require OpenGL and 3D effects enabled? Thanks in advance .bill

4 6

banning spammer from the forum
by Rosanne DiMesio Nov. 4, 2010

Nov. 4, 2010

Jeremy, Please ban ebook1210 from the forum. I've had to delete multiple spam posts from him/her over the past couple of days. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: msvcrt: Implement _asctime_s and _wasctime_s.
by Alexandre Julliard Nov. 4, 2010

Nov. 4, 2010

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > +MSVCRT_long CDECL MSVCRT_asctime_s(char *output, MSVCRT_size_t max, const struct MSVCRT_tm *mstm) > +{ > + char *buffer; > + MSVCRT_size_t bufflen; > + > + if (output && max > 0) > + output[0] = '\0'; > + if (!output) > + { > + *MSVCRT__errno() = MSVCRT_EINVAL; > + return MSVCRT_EINVAL; > + } You probably want to use the new parameter checking macros. Also the first check is redundant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] slc: Implement SLGetWindowsInformationDWORD
by Alexandre Julliard Nov. 4, 2010

Nov. 4, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > +HRESULT WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > +{ > + FIXME("(%s, %p): semi-stub\n", debugstr_w(lpszValueName), pdwValue); > + > + if (!lpszValueName || !pdwValue) > + return E_INVALIDARG; > + > + if (!*lpszValueName) > + return SL_E_RIGHT_NOT_GRANTED; > + > + /* We have always a genuine Wine */ > + *pdwValue = 1; > + return S_OK; There's no reason that this dword would represent the genuine flag, it can be just about anything. Returning value not found would probably be preferable, or else do a real attempt at determining what value would be expected for the specified name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 5)
by Alexandre Julliard Nov. 4, 2010

Nov. 4, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat calls. You should stop trying to pass a case_sensitive flag to find_file_in_dir and have it take care of everything internally, if and only if a case insensitive search seems to be required. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: msvcrt: Implement _get_tzname.
by Eryk Wieliczko Nov. 4, 2010

Nov. 4, 2010

http://msdn.microsoft.com/en-us/library/4ssfs1ya.aspx _get_tzname should simply copy the contents of _tzname. In my opinion it should be ok. According to this document it's the default value. In my Polish XP it's also "PST" and "PDT", which is of course irracional ( Poland is in Europe ). So I would assume static char tzname_std[64] = ""; static char tzname_dst[64] = ""; more of a hack. 2010/11/3 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > This is not an implementation, this is a quick and dirty hack. > > -- > Dmitry. >

2 1

RFC: Fixing comctl32 toolbar tests for different system font heights
by Austin Lund Nov. 4, 2010

Nov. 4, 2010

I'm trying to fix these test failures: http://test.winehq.org/data/d4f64121e83671ac10ed6ead04f1c19eb5586cb0/xp_wtb… These failures occur because the system font metrics are different to what is assumed for the hard-coded numbers. Attached is my go at fixing these (in a three part patch set). Is this approach even close to being the right way to do this?

1 0