December 2010 - Wine-Devel - list.winehq.org

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus.
by James Mckenzie Dec. 20, 2010

Dec. 20, 2010

Damian Dixon <damian.dixon(a)gmail.com> wrote: >Sent: Dec 20, 2010 1:28 PM >To: wine-patches(a)winehq.org >Cc: damian.dixon(a)gmail.com >Subject: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus. > Please rebase to current git. James McKenzie

1 0

Re: jscript: Exception tests clean up.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Nikolay Sivov Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 20:29, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) You can't split this in two patches, cause tests should run without failures after each patch. So in your case remove todo_wine in the same patch.

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Andrew Nguyen Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 11:29 AM, Damian Dixon wrote: > + if (!lpservicestatus) > + { > + OSVERSIONINFOW osVi; > + /* Get windows version emulating */ > + osVi.dwOSVersionInfoSize = sizeof(osVi); > + GetVersionExW(&osVi); > + if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT) > + { > + if (osVi.dwMajorVersion > 4) > + { > + SetLastError(ERROR_INVALID_ADDRESS); > + } > + else > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + } > + } > + return FALSE; > + } > + You shouldn't need to check the Windows version. Setting the last error to a reasonable value for a particular platform is sufficient.

1 0

Re: [2/2] advapi32/tests: Remove todo_wine so change made in QueryServiceStatus does not cause a failure
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7718 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Mark Win7 behaviour as broken
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/shell32/tests/shlview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll/tests: Remove tests for overlong instructions
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

"Greg Geldorp" <ggeldorp(a)vmware.com> writes: > The "overlong instruction" test produces different results on different > test machines. Since it fails on other machines besides the TestBot VMs I > don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATH try2] widl: Added support for registering alternative progids.
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > This will be needed for jscript registration. This seems very ad-hoc. Unless there are many other places that need it, I think it should be handled manually in jscript. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Added Date.setYear implementation.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: libs/wine: check for empty string in WINEPREFIX
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > see http://bugs.winehq.org/show_bug.cgi?id=25554 I don't think that's necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by cheer_xiao Dec. 20, 2010

Dec. 20, 2010

Hi Susan, On Dec 19, 2010 8:59 PM, "Susan Cragin" <susancragin(a)earthlink.net> wrote: > > I'm compiling from git onto 64-bit Natty, which is in Alpha. > > Wine's apt-get build-dep script seems to be missing the following. > > configure: OpenCL 32-bit development files not found, OpenCL won't be supported. > configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled > > I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: > python-pyopencl > but still got the warning. > > I know it's too early to mention this, since Natty's still in Alpha. I'm running Ubuntu Lucid and have this problem too. As with Natty, Lucid's repo has development files for gstreamer, but installing them doesn't eliminate the warning about gstreamer. Lucid's repo doesn't contain dev files for OpenCL, either. If I'm not mistaken support for OpenCL was added recently, as I didn't get that warning several weeks ago. I guess this problem could be solved simply by compiling some packages and passing some arguments to ./configure, but as a newbie I'm too looking forward to an answer.

3 2

Wine and serial port AGAIN
by Pavel Troller Dec. 20, 2010

Dec. 20, 2010

Hi! As a technician, I need often to use some form of serial port communication. My recent experience is with a program for programming TYT radios from China. They supply a simple windows app, which allows to program all the features of the radio, which cannot be accomplished using the radio keyboard only. The program works perfectly in wine, with one exception - a physical comms with the radio. It complains that it doesn't receive a response from the radio, while the radio crashes - it stops working, when a programming attempt is made, and has to be power-cycled. The radio is connected using a USB cable, which contains just a regular PL-2303 USB to serial converter, which is perfectly supported in Linux. Port assignment for wine is also done, proof of which is, that the radio crashes upon the programming request. The data volume to be programmed is small, just a few hundreds of bytes. It's really stupid that I can prepare my data in the program only, and then I need to ask my colleague with real windows to perform a programming job :-(. The program can be freely downloaded from the TYT pages: http://www.tyt888.com/WebEditor/UploadFile/201096144939483.rar but a real radio is needed to debug the comms problem. I've captured the console output with WINEDEBUG=+comm, which is attached. It contains a log of three consecutive attempts to program the radio. I'm ready to do more debugging, but I don't know, how to proceed now. With regards, Pavel.

5 15

64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by Susan Cragin Dec. 20, 2010

Dec. 20, 2010

I'm compiling from git onto 64-bit Natty, which is in Alpha. Wine's apt-get build-dep script seems to be missing the following. configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: python-pyopencl but still got the warning. I know it's too early to mention this, since Natty's still in Alpha.

2 1

Re: secur32/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7712 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PROX64 (32 bit schannel) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: qmgr/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7710 Your paranoid android. === W7PROX64 (64 bit qmgr) === No test summary line found

1 0

Re: schannel/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7711 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

TestBot changes
by Greg Geldorp Dec. 19, 2010

Dec. 19, 2010

I've made some changes to TestBot over the last week. The most important change is the addition of an extra physical server. About half of the VMs have been moved over to this new server. This should speed up testing a bit. Other changes include upgrading the hypervisor to ESX 4.1, applying Windows Update patches to various VMs and fixing some problems in the TestBot scripts. I'll probably continue tweaking things for the next week or so, which means there can be unexpected failures. For those interested in the setup of TestBot, it currently consists of 3 physical machines: 1) Dell PowerEdge SC1435, quad-core AMD Opteron 2.2GHz, 16GB memory, 1.4TB storage, running VMware ESX 4.1. Hosts about half of the NT4+ VMs plus the website/engine VM. 2) Dell PowerEdge R310, quad-core Intel Xeon X3430 2.4GHz, 16GB memory, 550GB storage, running VMware ESX 4.1. Hosts the other half of the NT4+ VMs. This is the new machine. 3) Whitebox, quad-core Intel Core i7 975 3.33GHz, 6GB memory, 450GB storage, running VMware Server on top of openSuSE 11.3. Hosts the Win9x VMs. Greg.

1 0

Re: programs/notepad/Nl.rc and programs/winecfg/Nl.rc: patch for Dutch translation (resend)
by Austin English Dec. 19, 2010

Dec. 19, 2010

On Sat, Dec 18, 2010 at 9:15 AM, Albert Pool <albertpool(a)solcon.nl> wrote: > Hello, > > I have fixed some English texts which had appeared in the Dutch > translation of notepad and winecfg. The previous mail with these patch > seems not to be arrived at you, so I've resent it. You forgot the patch :-). -- -Austin

1 0

Re: [advapi32] Added check for NULL pointer being passed to QueryServiceStatus as lpservicesstatus parameter.
by Nikolay Sivov Dec. 18, 2010

Dec. 18, 2010

On 12/18/2010 18:46, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c > index 7fea937..f8d329f 100644 > --- a/dlls/advapi32/service.c > +++ b/dlls/advapi32/service.c > @@ -1130,6 +1130,7 @@ BOOL WINAPI QueryServiceStatus(SC_HANDLE hService, > > TRACE("%p %p\n", hService, lpservicestatus); > > + if (!lpservicestatus) return FALSE; > ret = QueryServiceStatusEx(hService, SC_STATUS_PROCESS_INFO, > (LPBYTE)&SvcStatusData, > sizeof(SERVICE_STATUS_PROCESS),&dummy); > if (ret) memcpy(lpservicestatus,&SvcStatusData, sizeof(SERVICE_STATUS)) > ; Add a test for that please. Also last error is probably affected by this.

1 0

Full path to wine executable in generated .desktop files
by Ilya Basin Dec. 18, 2010

Dec. 18, 2010

When you install a program, some desktop files are put here: ~/.local/share/applications/wine/ ~/Desktop/ [Desktop Entry] Name=Microsoft Office Access 2003 Exec=env WINEPREFIX="/home/leniviy/.wine" wine ... I have 2 wine instances: official in /usr and patched in /opt/wine-csshack . Because of that I would like to have "/opt/wine-csshack/bin/wine", not just "wine" in the generated .desktop files. What can go wrong if we do so?

1 0

Removal of dcom98 from winetricks?
by Scott Ritchie Dec. 18, 2010

Dec. 18, 2010

I remember discussing this at wineconf as something we should do, but it seems there's at least one situation I've found where it still helps: http://bugs.winehq.org/show_bug.cgi?id=8780 Is it possible this is a hidden issue bleeding into other apps as well? Thanks, Scott Ritchie

1 0

socks & wine, patching wininet to use winsock
by Gabriele Greco Dec. 18, 2010

Dec. 18, 2010

I'm trying to make programs that need a socks proxy to work on wine. They work with freecaps or similar winsock patches as long as they don't use wininet or other indirect winsocks APIs to make their stuff, if they use wininet those patches could not work since wininet bypasses winsocks and use linux sockets directly. In the head of the wininet.dll sources there is this comment: /* FIXME!!!!!! * This should use winsock - To use winsock the functions will have to change a bit * as they are designed for unix sockets. * SSL stuff should use crypt32.dll */ I tried to change netconnection.c to use winsock functions WSAConnect, WSASend & WSARecv since WS_send, WS_recv and WS_connect are not exposed by ws2_32 instead of direct linux socket functions (connect/send/recv), but I had no way to check the problems with unix sockets vs inet sockets cause the library crashes wine before hitting anything related with my CODE patches. It crashes simply because I've added in Makefile.in ws2_32 module IMPORTS, doing so what I've observed is that standard linux sockets calls are "wrapped" and points now to NULL (because ws2_32 is not loaded?). In this specific case "getaddrinfo" is NULL and HTTP_ResolveName crashes when calling it. Anyone can suggest me the correct approach to implement this? I have to load manually ws2_32 in the wininet initialization? -- Bye, Gabry

2 1

Re: widl: Added support for registering alternative progids.
by Huw Davies Dec. 17, 2010

Dec. 17, 2010

On Fri, Dec 17, 2010 at 04:14:24PM +0100, Jacek Caban wrote: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c924a66..28cb1da 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -190,7 +190,7 @@ static statement_list_t *append_statement(statement_list_t *list, statement_t *s > -%token tAGGREGATABLE tALLOCATE tANNOTATION tAPPOBJECT tASYNC tASYNCUUID > +%token tAGGREGATABLE tALLOCATE tANNOTATION tAPPOBJECT tASYNC tASYNCUUID tALTPROGID Hi Jacek, This breaks alphabetical order in this line. Cheers, Huw.

1 0

Re: [PATCH 5/7] mshtml: Added IHTMLScriptElement::get_scr implementation.
by Marvin Dec. 17, 2010

Dec. 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7657 Your paranoid android. === W7PRO (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/5] server: Handle more inotify mask values
by Alexandre Julliard Dec. 16, 2010

Dec. 16, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > -static int inode_check_dir( struct inode *parent, const char *name ) > -{ > - char *path; > - unsigned int filter; > - struct inode *inode; > - struct stat st; > - int wd = -1, r = -1; > - > - path = inode_get_path( parent, strlen(name) ); > - if (!path) > - return r; > - > - strcat( path, name ); > - > - r = stat( path, &st ); > - if (r < 0) goto end; > - > - if (!S_ISDIR(st.st_mode)) > - { > - r = 0; > - goto end; > - } > - > - r = 1; > - > - filter = filter_from_inode( parent, 1 ); > - if (!filter) > - goto end; > - > - inode = inode_add( parent, st.st_dev, st.st_ino, name ); > - if (!inode || inode->wd != -1) > - goto end; > - > - wd = inotify_add_dir( path, filter ); > - if (wd != -1) > - inode_set_wd( inode, wd ); > - else > - free_inode( inode ); > - > -end: > - free( path ); > - return r; > -} You can't remove all this, you still need to add a watch for newly created directories. -- Alexandre Julliard julliard(a)winehq.org

1 0

Testbot: User not logged in Problem with WVISTAADM
by André Hentschel Dec. 15, 2010

Dec. 15, 2010

Hi Greg, there is a noisy problem with the WVISTAADM, which causes much tests to be shown as "Failed" in the patchtracker. should we blacklist the Message returned by WVISTAADM or can you fix the underlying problem? -- Best Regards, André Hentschel

3 4

Thread-safety in winmm?
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 15, 2010

Dec. 15, 2010

Hi, I'm thankful for any kind of information regarding thread-safety and re-entrancy involving WINMM. I found little on the net. Basically, I'm wondering what kind of guarantees must code in winmm (which includes the MCI) provide w.r.t. multiple application threads using the winmm API. Use cases for the MCI: A) Thread 1: MCI_PLAY, thread 2: MCI_STOP B) Thread 1: MCI_PLAY, 2: MCI_PAUSE, 3: MCI_STOP C) Thread 1: MCI_PLAY, 2: MCI_STOP, 3: WINMM shutdown via ^C D) Any 2 MCI commands from 2 threads, excl. MCI_CLOSE E) Including MCI_CLOSE For instance, the following construct that is used in some Wine MCI drivers is not fully thread safe: WINE_MCI* wmw = (WINE_MCI*)mciGetDriverData(wDevID); /* oops */ if (wmw) { /* oops */ EnterCriticalSection(wmw->cs); The thread may be preempted at oops time, another one may close the device meanwhile; crash follows. Note that the MCI is easier to deal with than the rest of WINMM, because it has no CALLBACK_FUNCTION. Function callbacks create an additional burden via re-entrant code. Often enough, they are invoked within a critical section (e.g. lookup xyzNotifiyClient() in wine*.drv/). However, a CS is not a MUTEX, and callback code will happily enter any critical section already hold within the same thread! One could say that critical sections give a wrong feeling of security. Presumably CS are used over mutexes all over the place because a) they are said to be more efficient b) using mutexes to protect against re-entrant code is no solution either, as dead-locks would occur. The above example shows that it would be tough to make a driver thread-safe without the help of the central WINMM component. So I'm left wondering what are adequate levels of protection that I should design into code while I'm rewriting some of the MCI. - Should I care about robustness against driver shutdown as a consequence of ^C? (a particular case of close while playing) - One may argue that re-entrancy is not an issue for WINMM. Bug #3930, comment #37 explains that function callbacks should be invoked from another thread... - What is the worst that I should expect? (We already know that apps call winmm functions from within callbacks even though MSDN says it may deadlock...) - What should WINMM guarantee? - Will DRV_CLOSE ever be called once only? - Should a closing driver kill player threads or patiently wait? I've been thinking about supporting a graduated scenario similar to: E: robustness against any sequence of commands from a single thread; Bug #22978 shows mciseq does not satisfy that condition. D: asynchronous player + thread-safe stop/reset command; C: ... A: fully thread- and re-entrancy-safe One thing I've learned already is that innocent looking code such as PostThreadMessage() may cause the currently running thread to be preempted, even though it did not yet set all state variables correctly. E.g., the app may process a notification earlier that you'd believe it does! Thanks for any pointers, Jörg Höhle

1 0

Re: ntdll: use off_t instead of long
by Alexandre Julliard Dec. 15, 2010

Dec. 15, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > This is more correct and prevents a crash on sparc (at least what > Austin and me acutally reached) It's not more correct, it's just moving the problem around... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] cmd: Add CHOICE builtin with DOS6 to XP commandline parameter
by Alexandre Julliard Dec. 15, 2010

Dec. 15, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > + while (!errorlevel) { > + count = 0; > + while (!count){ > + /* FIXME: Add support for option /T */ > + WCMD_ReadFile(GetStdHandle(STD_INPUT_HANDLE), answer, 1, &count, NULL); > + if (!count) { > + WINE_TRACE("no more data from stdin\n"); > + if (have_console) > + SetConsoleMode(GetStdHandle(STD_INPUT_HANDLE), oldmode); > + > + HeapFree(GetProcessHeap(), 0, my_command); > + return; > + } > + } > + if (!opt_s) > + answer[0] = toupperW(answer[0]); > + > + ptr = strchrW(opt_c, answer[0]); > + if (ptr) { > + WCMD_output_asis(answer); > + WCMD_output(newline); > + if (have_console) > + SetConsoleMode(GetStdHandle(STD_INPUT_HANDLE), oldmode); > + > + errorlevel = (ptr - opt_c) + 1; > + WINE_TRACE("answer: %d\n", errorlevel); > + HeapFree(GetProcessHeap(), 0, my_command); > + return; > + } > + else > + { > + /* key not allowed: play a bell */ > + WINE_TRACE("key not allowed: %s\n", wine_dbgstr_w(answer)); > + WCMD_output_asis(bellW); > + } > + } > + /* This location is never reached */ It doesn't make sense to have a loop condition that never happens. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Dutch translation for notepad and winecfg changed
by James Mckenzie Dec. 15, 2010

Dec. 15, 2010

Albert Pool <albertpool(a)solcon.nl> wrote: One patch per message, please. Please see the Submitting Patches page on the Wiki. > >--- > programs/notepad/Nl.rc | 5 +++-- > programs/winecfg/Nl.rc | 15 ++++++++------- > 2 files changed, 11 insertions(+), 9 deletions(-) > >diff --git a/programs/notepad/Nl.rc b/programs/notepad/Nl.rc >index f5eeaab..31178a6 100644 >--- a/programs/notepad/Nl.rc >+++ b/programs/notepad/Nl.rc >@@ -1,7 +1,8 @@ > /* > * Notepad (Dutch resources) > * >- * Copyright 2003 Hans Leidekker >+ * Copyright 2003 Hans Leidekker Please follow the existing spacing in the file, this type of change is not needed. >+ * Copyright 2010 Albert Pool James McKenzie

1 0

Re: [PATCH 4/5] mshtml: Forward PluginHost's QueryService calls to window object
by Marvin Dec. 15, 2010

Dec. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7602 Your paranoid android. === W2K8SE (32 bit activex) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

re: winetricks IE6 installer not downloading
by Dan Kegel Dec. 14, 2010

Dec. 14, 2010

This is fixed in svn, try http://winezeug.googlecode.com/svn-history/r2031/trunk/winetricks

1 0

Re: shlwapi/tests: Standardize the COM usage in ordinal.c.
by Marvin Dec. 14, 2010

Dec. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7586 Your paranoid android. === W7PRO (32 bit ordinal) === ordinal.c:1824: Test failed: got 30 ordinal.c:1839: Test failed: got 10 ordinal.c:1852: Test failed: got 13 ordinal.c:1860: Test failed: got 13 ordinal.c:1867: Test failed: got 13 ordinal.c:1874: Test failed: got 30 ordinal.c:1882: Test failed: got 30 ordinal.c:1890: Test failed: got 42, length 43 ordinal.c:1901: Test failed: got 45 ordinal.c:1912: Test failed: got 24 ordinal.c:1923: Test failed: got 27

2 1

Re: ole32/tests: Standardize the COM usage in clipboard.c.
by Marvin Dec. 14, 2010

Dec. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7585 Your paranoid android. === W2K8SE (32 bit clipboard) === clipboard: unhandled exception c0000005 at 769B7E6D === W7PRO (32 bit clipboard) === clipboard.c:1215: Test failed: got 80040064 clipboard.c:1216: Test failed: got 0 === W7PROX64 (64 bit clipboard) === clipboard.c:1215: Test failed: got 80040064 clipboard.c:1216: Test failed: got 0

2 1

Re: shell32: Fix shelllink test to not crash on NT4
by Marvin Dec. 14, 2010

Dec. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7589 Your paranoid android. === WVISTAADM (32 bit shelllink) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

winetricks IE6 installer not downloading
by Jevgeni Burtin Dec. 14, 2010

Dec. 14, 2010

Hi, When I try to install IE6 using winetricks it pops up installer wizard and when I press I accept installer tells me following error: "Setup was unable to download required components". (Internet connection is working well) Screenshot of error: http://ubuntuone.com/p/Tbs/ Thanks.

1 0

Re: oleaut32/tests: Use an iface instead of an vtbl pointer in IRecordInfoImpl
by Marvin Dec. 14, 2010

Dec. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7587 Your paranoid android. === WVISTAADM (32 bit safearray) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

RFC: Pass ReadFile and WriteFile requests on sockets to ws2_32.dll
by Erich Hoover Dec. 14, 2010

Dec. 14, 2010

Attached is a patch to take kernel32/ntdll ReadFile and WriteFile requests on sockets and pass them to WSARecv and WSASend. This patch is part of a series I'm working on for the infamous C&C networking bug (Bug #7929). The functionality added by this patch was requested by a previous RFC response so that ReadFile and WriteFile requests will have all the same filtering as WSARecv and WSASend. Any and all feedback is greatly appreciated. Erich Hoover ehoover(a)mines.edu

2 1

Re: msctf/tests: Standardize the COM usage in inputprocessor.c.msctf/tests.
by Marvin Dec. 14, 2010

Dec. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7584 Your paranoid android. === W7PRO (32 bit inputprocessor) === inputprocessor.c:749: Test failed: Activation came unexpectedly inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:757: Test failed: Deactivation came unexpectedly === W7PROX64 (32 bit inputprocessor) === inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:515: Test failed: Sink reports wrong previous focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus inputprocessor.c:511: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:513: Test failed: Sink reports wrong focus === W7PROX64 (64 bit inputprocessor) === inputprocessor.c:749: Test failed: Activation came unexpectedly inputprocessor.c:757: Test failed: Deactivation came unexpectedly

2 1

Re: winealsa.drv: use ERR() for fatal errors instead of WARN()
by Alexandre Julliard Dec. 14, 2010

Dec. 14, 2010

Austin English <austinenglish(a)gmail.com> writes: > See http://bugs.winehq.org/show_bug.cgi?id=22034 If the errors are properly handled, there's no reason to have an ERR. If they aren't, that should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6 resend)
by Alexandre Julliard Dec. 14, 2010

Dec. 14, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > +#if defined(HAVE_GETATTRLIST) && defined(ATTR_VOL_CAPABILITIES) && \ > + defined(VOL_CAPABILITIES_FORMAT) && defined(VOL_CAP_FMT_CASE_SENSITIVE) > + char *mntpoint = NULL; > + struct attrlist attr; > + struct vol_caps caps; > + struct get_fsid get_fsid; > + struct fs_cache *entry; > + > + /* First get the FS ID of the volume */ > + attr.bitmapcount = ATTR_BIT_MAP_COUNT; > + attr.reserved = 0; > + attr.commonattr = ATTR_CMN_DEVID|ATTR_CMN_FSID; > + attr.volattr = attr.dirattr = attr.fileattr = attr.forkattr = 0; > + get_fsid.size = 0; > + if (getattrlist( dir, &attr, &get_fsid, sizeof(get_fsid), 0 ) != 0 || > + get_fsid.size != sizeof(get_fsid)) > + return TRUE; > + /* Try to look it up in the cache */ > + entry = look_up_fs_cache( get_fsid.dev ); > + if (entry && !memcmp( &entry->fsid, &get_fsid.fsid, sizeof(fsid_t) )) > + /* Cache lookup succeeded */ > + return entry->case_sensitive; > + /* Cache is stale at this point, we have to update it */ > + > + mntpoint = get_device_mount_point( get_fsid.dev ); > + /* Now look up the case-sensitivity */ > + attr.commonattr = 0; > + attr.volattr = ATTR_VOL_INFO|ATTR_VOL_CAPABILITIES; > + if (getattrlist( mntpoint, &attr, &caps, sizeof(caps), 0 ) == 0) > + { If that can fail then you need to structure this differently, otherwise you'll end up looking up the mount point on every call. Also please put that chunk in a separate function, it's totally different from the statfs code path. > +#elif defined(__linux__) > + /* Only assume CIOPFS is case insensitive. */ > + /* Normally, we'd have to parse the mtab to find out exactly what > + * kind of FUSE FS this is. But, someone on wine-devel suggested > + * a shortcut. We'll stat a special file in the directory. If it's > + * there, we'll assume it's a CIOPFS, else not. > + * This will break if somebody puts a file named ".ciopfs" in a non- > + * CIOPFS directory. > + */ > + cifile = RtlAllocateHeap( GetProcessHeap(), 0, strlen( dir )+sizeof("/.ciopfs") ); > + if (!cifile) return TRUE; > + strcpy( cifile, dir ); > + strcat( cifile, "/.ciopfs" ); > + if (stat( cifile, &st ) == 0) > + { > + RtlFreeHeap( GetProcessHeap(), 0, cifile ); > + return FALSE; > + } You lost the statfs here. > @@ -1872,7 +2097,7 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i > { > ret = ntdll_umbstowcs( 0, de[1].d_name, strlen(de[1].d_name), > buffer, MAX_DIR_ENTRY_LEN ); > - if (ret == length && !memicmpW( buffer, name, length)) > + if (ret == length && !memicmpW( buffer, name, length )) Please avoid gratuitous whitespace changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] amstream: Be more verbose when whe can't test
by Marvin Dec. 13, 2010

Dec. 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7579 Your paranoid android. === WVISTAADM (32 bit amstream) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list
by Alexandre Julliard Dec. 13, 2010

Dec. 13, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > - /* search element n in list */ > - for(i=0; i < index; i++) > + i = 0; > + LIST_FOR_EACH_ENTRY (pTypeInfo, &This->typeinfo_list, ITypeInfoImpl, entry) > + { > + if(i >= index) > + break; > + ++i; > + } It looks like an array would be more appropriate than a list. -- Alexandre Julliard julliard(a)winehq.org

2 4

Removal of wineaudioio.drv
by Michael Stefaniuc Dec. 13, 2010

Dec. 13, 2010

Hello guys, I have just submitted a patch to remove wineaudioio.drv from Wine. It was used by Solaris but the Solaris versions 9 and 10 that are "supported" by Wine do not have it any more. Solaris is using ESD at the moment and newer version will move to OSS4. If anybody has a reason why wineaudioio.drv should stay in please speak up *now*. This is your chance. Of course if you do speak up you volunteer to maintain wineaudioio.drv ;) bye michael

1 1

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 4)
by Chris Robinson Dec. 13, 2010

Dec. 13, 2010

On Sunday, December 12, 2010 2:19:42 pm Louis Lenders wrote: > +#define USER_HZ_TO_TICKSPERSEC(x,y) (ULONGLONG)10000000 * x / y I'd recommend adding proper parenthesis, to avoid potential problems with order-of-operations. #define USER_HZ_TO_TICKSPERSEC(x,y) ((ULONGLONG)10000000 * (x) / (y)) That way it won't break if you do math in the argument for some reason, like with USER_HZ_TO_TICKSPERSEC(val+1, user_hz) or USER_HZ_TO_TICKSPERSEC(val, user_hz*2) > + static long user_hz; > + > + user_hz = sysconf(_SC_CLK_TCK); There's no real point to making it static if you're always going to (re)set the variable. It would be better to just make the call once: static long user_hz; i(user_hz == 0) user_hz = sysconf(_SC_CLK_TCK); You could also make it an inline function to avoid making user_hz a parameter: /* Convert system clock to 100ns tics */ static long user_hz; static inline ULONGLONG ClockToTics(ULONGLONG val) { i(user_hz == 0) user_hz = sysconf(_SC_CLK_TCK); return val * 10000000 / user_hz; } ... sppi->IdleTime.QuadPart = ClockToTics(idle); sppi->KernelTime.QuadPart = ClockToTics(sys); ...etc... Though I'll defer judgement to others as to what's better.

2 1

Re: msi: Fix testfailure on some 2k3 machines (try 2)
by Marvin Dec. 13, 2010

Dec. 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7572 Your paranoid android. === WVISTAADM (32 bit msi) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: msi: Fix testfailure on some 2k3 machines
by Hans Leidekker Dec. 13, 2010

Dec. 13, 2010

On Sun, 2010-12-12 at 22:44 +0100, André Hentschel wrote: > r = MsiOpenProductA(prodcode, &hprod); > - ok(r == ERROR_INSTALL_PACKAGE_OPEN_FAILED || r == ERROR_SUCCESS, > - "Expected ERROR_INSTALL_PACKAGE_OPEN_FAILED or ERROR_SUCCESS, got %d\n", r); > + ok(r == ERROR_INSTALL_PACKAGE_OPEN_FAILED || ERROR_INSTALL_PACKAGE_REJECTED || r == ERROR_SUCCESS, > + "Expected ERROR_INSTALL_PACKAGE_OPEN_FAILED, ERROR_INSTALL_PACKAGE_REJECTED or ERROR_SUCCESS, got %d\n", r); ERROR_INSTALL_PACKAGE_REJECTED means the user has insufficient rights. Look at how action.c handles this error, for example.

2 1

Re: [PATCH] cmd: Allow GOTO to a label, which has a following whitespace, with test
by Marvin Dec. 12, 2010

Dec. 12, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7571 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 4)
by Nikolay Sivov Dec. 12, 2010

Dec. 12, 2010

On 12/13/2010 01:19, Louis Lenders wrote: > Change from try 3: improved macro as per Juan's suggestion, and made user_hz a static variable > > /proc/stat measures the times > in units of USER_HZ, whereas Windows uses 100ns ticks. > This should fix http://bugs.winehq.org/show_bug.cgi?id=23847 > @@ -1591,6 +1593,9 @@ NTSTATUS WINAPI NtQuerySystemInformation( > int count; > char name[10]; > char line[255]; > + static long user_hz; > + > + user_hz = sysconf(_SC_CLK_TCK); This change doesn't make any difference, I think the idea was to make it global.

1 0

wine's configure says "gst/gstpad.h usability... No"
by wylda＠volny.cz Dec. 12, 2010

Dec. 12, 2010

Hi guys, i'm overworked so wanted to relax a bit with wine :-D and noticed that Debian Squeeze says: gstreamer-0.10 development files not found, gstreamer support disabled but "dpkg -l | grep -i gst": ii libgstreamer-plugins-base0.10-0 0.10.30-1 ii libgstreamer0.10-0 0.10.30-1 ii libgstreamer0.10-0-dbg 0.10.30-1 ii libgstreamer0.10-dev 0.10.30-1 also "find / -iname gstpad.h": /usr/include/gstreamer-0.10/gst/gstpad.h Thanks for any tips to enjoy your new release. Adding config.log if that helps somehow. W.

5 5

Re: shdocvw: Fix testfailure on some NT4 machines
by Marvin Dec. 12, 2010

Dec. 12, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7562 Your paranoid android. === WVISTAADM (32 bit shdocvw) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 5/6] mshtml: Added IHTMLWindow2::open test.
by Paul Vriens Dec. 12, 2010

Dec. 12, 2010

Hi Jacek, On 06/14/2010 02:20 AM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 100 > ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 98 insertions(+), 2 deletions(-) > Some of these tests fail on IE6 SP1: http://test.winehq.org/data/tests/mshtml:htmldoc.html What would be the best approach to fix these? We can add a broken() for the 3577 todo_wine 3578 ok(new_window == NULL, "new_window != NULL\n"); but what about the 3582 todo_wine 3583 CHECK_CALLED(EvaluateNewWindow); introduce a CHECK_CALLED_BROKEN also in this file? -- Cheers, Paul.

2 1

Please ban spammer from the forum
by Rosanne DiMesio Dec. 12, 2010

Dec. 12, 2010

Dan or Jeremy-- Please ban user hary from the forum. Right now he's posting spam as fast as I'm deleting it. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard Dec. 11, 2010

Dec. 11, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 3)
by Juan Lang Dec. 11, 2010

Dec. 11, 2010

Hi Louis, +#define USER_HZ_TO_TICKSPERSEC(x) (ULONGLONG)10000000 * x / user_hz It's poor style to assume in a macro that user_hz exists. Pass it as a macro parameter instead. Also, this is a question rather than a suggestion for a fix: + long user_hz = sysconf(_SC_CLK_TCK); Can this value change during the lifetime of a program? I expect not, but I could be mistaken. If not, why not make it static and initialize it only once? --Juan

1 0

wine-1.3.8 regression for the curses backend to wineconsole
by Alan W. Irwin Dec. 11, 2010

Dec. 11, 2010

The command wineconsole --backend=curses cmd hangs with the following error message for 1.3.8: err:ntdll:RtlpWaitForCriticalSection section 0x7ee17dec "?" wait timed out in thread 0065, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7ee17dec "?" wait timed out in thread 004d, blocked by 0000, retrying (60 sec) There are no such issues for the default wineconsole backend, but I have always preferred using the curses backend because cut and paste was available for it. That backend worked fine (according to my notes) for wine-1.1.41. I built wine-1.3.8 on my Debian testing box a week ago, but saved the output of all build steps. The configure stage had the following curses-related messages: software(a)raven> grep curses configure.out checking curses.h usability... yes checking curses.h presence... yes checking for curses.h... yes checking ncurses.h usability... yes checking ncurses.h presence... yes checking for ncurses.h... yes checking for -lncurses... libncurses.so.5 These seem fine, and all curses-related output of the "make depend", "make", and "make install" steps seem fine as well. I am generally pretty happy with wine-1.3.8 except for this one curses backend regression. Can others confirm this issue? Is there some workaround such as using a different version of ncurses? Here are the curses-related packages I have installed at the moment on Debian testing: irwin(a)raven> dpkg --list |grep curse ii lib32ncurses5 5.7+20100313-4 shared libraries for terminal handling (32-bit) ii lib32ncurses5-dev 5.7+20100313-4 developer's libraries for ncurses (32-bit) ii libncurses5 5.7+20100313-4 shared libraries for terminal handling ii libncurses5-dev 5.7+20100313-4 developer's libraries and docs for ncurses ii libncursesw5 5.7+20100313-4 shared libraries for terminal handling (wide character support) ii ncurses-base 5.7+20100313-4 basic terminal type definitions ii ncurses-bin 5.7+20100313-4 terminal-related programs and man pages Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 4

Re: [PATCH] ntdll: Handle executable file mappings from noexec filesystems
by Alexandre Julliard Dec. 11, 2010

Dec. 11, 2010

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > regression from my previous patch, which forced EXEC permissions on > some mappings, which in turn gets EPERM when the filesystem is > "noexec" mounted. I don't think that's a good idea. If the filesystem is no exec we should report it and fail. -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: msi/tests: Fix some test failures on Wow64.
by Marvin Dec. 11, 2010

Dec. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7542 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/10] mshtml: Added QueryService(SID_SBindHost) implementation
by Marvin Dec. 10, 2010

Dec. 10, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7538 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

winedbg --gdb shows multiple segfaults during any app startup
by Ilya Basin Dec. 10, 2010

Dec. 10, 2010

In both 1.3.8 and git winedbg --gdb or plain gdb catches several segfaults, but if I ignore them, the program works. $ CC="ccache gcc" ./configure CFLAGS="-g -O0" make ./wine winedbg.exe --gdb notepad Wine-gdb> cont Continuing. Program received signal SIGSEGV, Segmentation fault. 0x7e942cf4 in create_alpha_bitmap (color=0x33c, mask=0x338, src_info=0x1319a8, color_bits=0x7ebf411c) at cursoricon.c:664 664 ptr[0] = ptr[0] * alpha / 255; Wine-gdb> Continuing. ... Program exited normally. Wine-gdb> quit

2 1

None
by paulo lesgaz Dec. 10, 2010

Dec. 10, 2010

http://webpage.lv/page.php

1 0

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 2)
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c > index 7ad56e4..d9f0398 100644 > --- a/dlls/ntdll/nt.c > +++ b/dlls/ntdll/nt.c > @@ -64,6 +64,8 @@ > #include <mach/vm_map.h> > #endif > > +#define USER_HZ_TO_TICKSPERSEC(x) (ULONGLONG)10000000 * x / sysconf(_SC_CLK_TCK) Don't hide sysconf in a macro, call it just once where needed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Cross-DLL toolbar bitmaps
by Erich Hoover Dec. 10, 2010

Dec. 10, 2010

I was looking into adding better bitmaps for the toolbar controls in hhctrl.ocx (now that we have fancy alpha transparency support) and I wanted to make sure that the bitmaps used matched everywhere else in Wine. Looking into how this works currently, I noticed that keeping all the toolbar bitmaps in sync is currently done manually. For example, dlls/shell32/idb_tb_large.bmp uses older icons for backward and forward where dlls/shdocvw/ietoolbar.bmp and dlls/comctl32/idb_std_large.bmp use the new icons. So, my thought was that it might be desirable to split apart the individual icons, move them all to one centralized location, and then institute a makefile rule for chaining the icons together into toolbar bitmaps. Any other thoughts? Does this sound reasonable and worth pursuing? Erich Hoover ehoover(a)mines.edu

2 3

64-bit down to 11 failures !!
by Austin English Dec. 10, 2010

Dec. 10, 2010

2 2

Re: riched20/tests: Mark behaviour at 120 dpi as broken
by Marvin Dec. 9, 2010

Dec. 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7522 Your paranoid android. === W7PROX64 (32 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8 === W7PROX64 (64 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8

1 0

Re: riched20/tests: Mark behaviour at 120 dpi as broken
by James Mckenzie Dec. 9, 2010

Dec. 9, 2010

Andre: My computer is set up for 125 dpi (Large Fonts on WindowsXP). Should we be testing for this as well? This should give different results than what is stated here. Maybe there is a better way to test this than using a fixed value of 39 in the ok comparision. James McKenzie -----Original Message----- >From: André Hentschel <nerv(a)dawncrow.de> >Sent: Dec 9, 2010 11:38 AM >To: wine-patches <wine-patches(a)winehq.org> >Subject: riched20/tests: Mark behaviour at 120 dpi as broken > >comparison to 96 dpi can be found at http://test.winehq.org/data/23906816d87795c363f0199f33ff70f2732c6ab5/index_… >--- > dlls/riched20/tests/editor.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c >index efd2023..5321d07 100644 >--- a/dlls/riched20/tests/editor.c >+++ b/dlls/riched20/tests/editor.c >@@ -6082,7 +6082,9 @@ static void test_EM_CHARFROMPOS(void) > point.x = 1000; > point.y = 40; > result = SendMessage(hwnd, EM_CHARFROMPOS, 0, (LPARAM)&point); >- todo_wine ok(result == 39, "expected character index of 39 but got %d\n", result); >+ todo_wine ok(result == 39, >+ broken(result == 34) /* 120 dpi */, >+ "expected character index of 39 but got %d\n", result); > > point.x = 1000; > point.y = -1; >-- > >Best Regards, André Hentschel > >

1 0

Trace/breakpoint trap using VS2008 remote debugger
by Joe Dluzen Dec. 9, 2010

Dec. 9, 2010

Hi all, I've got the Visual Studio Remote Debugger working with breakpoints, but not with forcing the process to pause. It immediately exits with "Trace/breakpoint trap." I've tried looking up the error, but it seems that no one has this specific set of circumstances. Any ideas? Thanks, Joe

2 2

Re: [1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.
by Joris Huizer Dec. 9, 2010

Dec. 9, 2010

Hello, I noticed in this patch, exactly the same lines are added in all the functions; wouldn't it be better to add a(n) (inline) function isComponentEnabled(rec,package) to reduce the repetition? HTH, Joris

2 1

Re: [1/2] winetest: Add a trace in the log when skipping a subtest.
by Alexandre Julliard Dec. 9, 2010

Dec. 9, 2010

Francois Gouget <fgouget(a)free.fr> writes: > I'm not happy with the situation when we skip a whole test executable. > One issue is that in such a case we don't even extract the executable > right now, thus making it impossible to print the subtest name. So we'd > need a different skip line format for that case. Or we could decide to > extract all the files and query their subtest names anyway and only > disable actually running the tests. The problem with this is that one of the reasons for skipping a test is that loading the test binary crashes the system, so loading it to get the subtest names wouldn't help. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] mshtml: Added GUID_CUSTOM_CONFIRMOBJECTSAFETY with CONFIRMSAFETYACTION_LOADOBJECT flag tests
by Marvin Dec. 9, 2010

Dec. 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7515 Your paranoid android. === WXPPROSP3 (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3 === WVISTAADM (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3

1 0

Re: [2/2] ntdll: Implement missing 64 bit shifts (try 2)
by Alexandre Julliard Dec. 9, 2010

Dec. 9, 2010

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > @@ -144,8 +144,23 @@ LONGLONG WINAPI RtlLargeIntegerShiftRight( LONGLONG a, INT count ) > */ > LONGLONG WINAPI RtlLargeIntegerArithmeticShift( LONGLONG a, INT count ) > { > - /* FIXME: gcc does arithmetic shift here, but it may not be true on all platforms */ > - return a >> count; > +#ifdef HAVE_SIMPLE_ARITHMETIC_RIGHT_SHIFT > + return a >> count; > +#else > + /* create mask to extend the sign bit */ > + LONGLONG mask; > + mask = ( LONGLONG ) 1 << 63; > + mask &= a; > + mask >>= count; That's an arithmetic shift, you are only moving the problem. Also your calling convention for the _allsh* functions isn't correct, as a simple test case demonstrates. Do you really have an app that uses this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dsound: Standardize the COM usage in duplex.c.
by Alexandre Julliard Dec. 9, 2010

Dec. 9, 2010

Michael Stefaniuc <mstefani(a)redhat.de> writes: > --- > dlls/dsound/duplex.c | 86 ++++++++++++++++++++++++++++++------------------- > 1 files changed, 53 insertions(+), 33 deletions(-) > > diff --git a/dlls/dsound/duplex.c b/dlls/dsound/duplex.c > index 4a1fbd2..2fcf64c 100644 > --- a/dlls/dsound/duplex.c > +++ b/dlls/dsound/duplex.c > @@ -44,7 +44,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dsound); > typedef struct IDirectSoundFullDuplexImpl > { > /* IUnknown fields */ > - const IDirectSoundFullDuplexVtbl *lpVtbl; > + IDirectSoundFullDuplex IDirectSoundFullDuplex_iface; > LONG ref; > > /* IDirectSoundFullDuplexImpl fields */ > @@ -57,23 +57,43 @@ typedef struct IDirectSoundFullDuplexImpl > } IDirectSoundFullDuplexImpl; > > typedef struct IDirectSoundFullDuplex_IUnknown { > - const IUnknownVtbl *lpVtbl; > + IUnknown IUnknown_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IUnknown; > > typedef struct IDirectSoundFullDuplex_IDirectSound8 { > - const IDirectSound8Vtbl *lpVtbl; > + IDirectSound8 IDirectSound8_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSound8; > > typedef struct IDirectSoundFullDuplex_IDirectSoundCapture { > - const IDirectSoundCaptureVtbl *lpVtbl; > + IDirectSoundCapture IDirectSoundCapture_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSoundCapture; All these objects are redundant, they should be merged. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by James Mckenzie Dec. 8, 2010

Dec. 8, 2010

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > >Tab characters fixed. You need to resubmit as [Try 2] if you make a correction in the future in a new message, please. James McKenzie

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by Dmitry Timoshkov Dec. 8, 2010

Dec. 8, 2010

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > + if (!InitializeSecurityDescriptor(*NewDescriptor, SECURITY_DESCRIPTOR_REVISION)) { > + HeapFree(GetProcessHeap(), 0, *NewDescriptor); > + return FALSE; > + } You are mixing tabs and spaces. -- Dmitry.

1 0

CreatePrivateObjectSecurity implementation
by Nick Sukharev Dec. 8, 2010

Dec. 8, 2010

I found that stub implementation for CreatePrivateObjectSecurity / DestroyPrivateObjectSecurity prevents Microsoft Exchange client from working properly. After changing these stubs to return an empty security descriptor and destroy it Exchange works much better. It can now read mail and calendar. I'm looking for suggestions what minimal implementation for these functions would be acceptable as a patch. Thank you PS. Sorry for double-post. It looks like I shouldn't be using nabble to post to wine-devel

1 0

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.
by Alexandre Julliard Dec. 8, 2010

Dec. 8, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > The following series of patches is a first step towards Wine Add-ons > tool. These patches move Gecko installation to wineaddon.cpl. They do > nothing about making install code generic nor provide any new GUI yet. > They only place the code in the right place so that it can be improved > further. Is a separate control panel really the right place? It seems to me that it would be preferable if add-ons were treated more like normal packages, and in particular registered in the installed packages list. This would make it possible to manage them from the appwiz control panel, and from other tools that use install information like uninstaller. -- Alexandre Julliard julliard(a)winehq.org

9 18

Re: ntdll: Implement missing 64 bit shifts
by Alexandre Julliard Dec. 8, 2010

Dec. 8, 2010

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > +/****************************************************************************** > + * _allshr (NTDLL.@) > + * > + * Right arithmetic shift a 64 bit integer > + * > + * PARAMS > + * a [I] Initial number. > + * count [I] Number of bits to shift by. > + * > + * RETURNS > + * The value of a following the shift. > + */ > +LONGLONG WINAPI _allshr( LONGLONG a, INT count ) > +{ > + return a >> count; > +} There's no guarantee that this would be an arithmetic shift, it's compiler-dependent. -- Alexandre Julliard julliard(a)winehq.org

3 2

winetricks dotnet30 install seems to be working again
by Dan Kegel Dec. 7, 2010

Dec. 7, 2010

For me, with today's winetricks from svn and wine from git, winetricks dotnet30 seems to work well. It appears to hang at the end because of http://bugs.winehq.org/show_bug.cgi?id=25059 but that's cosmetic; if you look for the icon hiding on the taskbar, you'll see the installer completed. Don't know if the resulting package works, but at least it installed for me just now once. Ship it! :-)

1 0

Re: winemenubuilder: Include icons in .url menus
by Paul Vriens Dec. 7, 2010

Dec. 7, 2010

On 12/07/2010 06:45 PM, Andrew Bogott wrote: > > This should supersede the previous version of this patch. This one plugs > a memory leak present in the last version. > Hi Andrew, The previous patch has already been committed. -- Cheers, Paul.

2 1

re: [SOLVED] Cannot install Python on wine
by Alan W. Irwin Dec. 7, 2010

Dec. 7, 2010

On 2010-12-06 18:49-0800 Dan Kegel wrote: > Does > winetricks python26 > work for you? The answer to your question (for wine-1.3.8, at least) is yes it does, and that lead to a complete solution! I am CCing to the list as well because others will be interested in that solution to my original question. The command above essentially downloads python-2.6.2.msi then executes wine msiexec /i python-2.6.2.msi ALLUSERS=1 which worked and is very similar to what I tried independently with python-2.7.1, i.e., wine msiexec /i python-2.7.1.amd64.msi which returned with no GUI and error message at all. I then realized from that name this was likely a 64-bit issue. I then downloaded the 32-bit MSI version, (from http://www.python.org/download/releases/2.7.1/) After that download wine msiexec /i python-2.7.1.msi worked like a charm! (I don't understand the significance of ALLUSERS=1 so I left it off.) So problem solved for python-2.7.1. Thanks for your helpful winetricks suggestion which gave me an excellent start on the road to finding the solution for the latest python2. One issue is you will likely want to incorporate the latest version of python2 in winetricks as well as python3 from http://www.python.org/download/releases/3.1.3/. The remaining issue is the complete lack of any error messages when executing the 64-bit MSI file. Shall I file a msiexec bug report about that? There is also no mention of 64-bit versus 32-bit MSI files at http://wiki.jswindle.com/index.php/Wine_MSI. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

1 0

How to deal with variables where the size differs for 32 and 64bit
by Paul Vriens Dec. 7, 2010

Dec. 7, 2010

Hi, Just found the fix for the oledb32:convert tests on 64bit. We need to adjust our oledb.idl (see patch attached). How should I deal with the ok() messages where we currently specify the 32bit variant? I mean this will of course introduce warnings on the 64bit side. Do I need to create a wrapper for the ok() messages, with a _WIN64 check somewhere? Or use a different printf format identifier? The same is also true for the TRACE() messages in our implementation. -- Cheers, Paul.

4 3

Cannot install Python on wine
by Alan W. Irwin Dec. 7, 2010

Dec. 7, 2010

Here is what I have tried to install Python under wine so far following what is recommended in http://wiki.jswindle.com/index.php/Wine_MSI. This was done using wine-1.3.8 with WINEDEBUG set to nothing (i.e., "WINEDEBUG=") so that all warning/error messages would be output. wine(a)raven> wine msiexec /i python-2.7.1.amd64.msi fixme:storage:create_storagefile Storage share mode not implemented. fixme:advapi:LookupAccountNameW (null) L"wine" (nil) 0x32f130 (nil) 0x32f134 0x32f128 - stub fixme:advapi:LookupAccountNameW (null) L"wine" 0x179f10 0x32f130 0x176bf8 0x32f134 0x32f128 - stub The lack of err: messages is encouraging. In particular notice these results have no err:msi:call_script Could not find CLSID for Windows Script which seemed to be an issue for another wine user that has attempted this with prior wine versions. So I had some hope that the above command actually worked, but it returned very quickly with no other response than above, and "find -name python.exe found nothing created by it in the whole wine account area I have set up to deal with wine matters. Thus, I don't think it worked. Is there some clue in the above fixme messages that indicates something fatal happened with msiexec? Is there anything else I should be doing? Another thread about a prior unsuccessful attempt to install Python under wine had this quote: "I have downloaded http://www.dll-files.com/dllindex/dll-files.shtml?msvcirt and placed it in the .wine/drive_c/windows/system directory." I don't have a clue about the significance of that step since I have no Windows experience and little wine experience. Is that step important or is it no longer necessary with wine-1.3.8? Anyhow, my test above was without that step since I didn't understand its necessity/significance. To give you some background about my use case, my development environment has been exclusively Linux since 1996, and I have no Microsoft Windows experience at all. Nevertheless, I help with developing the PLplot package which works on all of Linux, Mac OS X, and Windows so I try to help out the PLplot Windows developers by attempting to build PLplot under wine to follow/confirm what they do and any errors they find. As part of that work, I would like to test the optional PLplot Python bindings under wine which motivates my interest in installing the Windows version of Python under wine. Any help with the proper procedure for installing Python under wine would be much appreciated. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

2 1

CreatePrivateObjectSecurity implementation
by nicksukharev Dec. 6, 2010

Dec. 6, 2010

I found that stub implementation for CreatePrivateObjectSecurity / DestroyPrivateObjectSecurity prevents Microsoft Exchange client from working properly. After changing these stubs to return an empty security descriptor and destroy it Exchange works much better. It can now read mail and calendar. I'm looking for suggestions what minimal implementation for these functions would be acceptable as a patch. -- View this message in context: http://wine.1045685.n5.nabble.com/CreatePrivateObjectSecurity-implementatio… Sent from the Wine - Devel mailing list archive at Nabble.com.

1 0

Re: [PATCH 2/7] quartz: Add support for filtermapper3 to filtergraph, try 2
by Alexandre Julliard Dec. 6, 2010

Dec. 6, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -177,7 +177,7 @@ typedef struct _IFilterGraphImpl { > > LONG ref; > IUnknown *punkFilterMapper2; > - IFilterMapper2 * pFilterMapper2; > + IFilterMapper3 * pFilterMapper2; You should rename it then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/11] mshtml: Added IOleControl calls test.
by Marvin Dec. 5, 2010

Dec. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7457 Your paranoid android. === WXPPROSP3 (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === WVISTAADM (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PRO (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PROX64 (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PROX64 (64 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE

1 0

Re: [1/4] shdocvw: skip some tests if a modern IE is not present
by Paul Vriens Dec. 5, 2010

Dec. 5, 2010

On 12/02/2010 04:38 AM, Andrew Bogott wrote: > As suggested by Jacek. > Hi Andrew, Even IE6 does things differently as can be seen: http://test.winehq.org/data/tests/shdocvw:intshcut.html Just a matter of adding a broken() statement and bailing out (with cleanup) if the IPropertyStorage_ReadMultiple() fails? -- Cheers, Paul.

1 0

Use of the L prefix for wide strings in resource files
by Paul Vriens Dec. 5, 2010

Dec. 5, 2010

Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Cancel", IDCANCEL, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Yes", IDYES, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&No", IDNO, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP There doesn't seem to be an issue with most of the languages as our resource compiler seem to do things just right. I did however see strangeness for some languages and also the not yet submitted Hebrew translation (maybe more?): http://source.winehq.org/transl/resource.php?branch=master&lang=011%3A01&re… http://source.winehq.org/transl/resource.php?branch=master&lang=022%3A01&re… ResHacker shows the same strangeness so it appears not only to be the translation site. Any idea where to start looking? -- Cheers, Paul.

3 3

Hebrew website issues
by Yaron Shahrabani Dec. 4, 2010

Dec. 4, 2010

The following picture demonstrates the issues: http://lh3.ggpht.com/_QXJR6RTu0qE/TPpTZnza_wI/AAAAAAAADak/yGzX7y8sQI8/winew… <http://lh3.ggpht.com/_QXJR6RTu0qE/TPpTZnza_wI/AAAAAAAADak/yGzX7y8sQI8/winew…>1. The flags are left aligned instead of right aligned (All browsers) 2. The search box is right aligned instead of left aligned (Chromium mostly, sometimes also happens in Firefox) Kind regards, Yaron Shahrabani <Hebrew translator>

1 0

Re: Death to win9x?
by K.King Dec. 4, 2010

Dec. 4, 2010

<<< A majority of that effort is rewriting tests to make win9x happy, not rewriting behavior to fix win9x applications. >>> Understood <<< Few people (if any) want to intentionally break win9x applications, but spending a large amount of developer effort to maintain the tests there isn't really the best investment, when it could instead be spent fixing real bugs. >>> Regressions are a normal part of large scale development. Regressions are real bugs. Unless you are becoming what you imitate:-) <<< I could drop the Win9x tests and concentrate on Windows 2000 and higher. Would this be a good course of action? >>> Drop seems harsh, prioritize seems reasonable. If you are 199% confident nothing you do would affect Win9x (famous developer last words) Or AJ says put the Win9x users in the lifeboat then it's a good course for you And a not so good one for Win9x users.

5 4

Re: [try 2] msvcrt: Implement wcsnicoll
by Andrew Nguyen Dec. 4, 2010

Dec. 4, 2010

On Fri, Dec 3, 2010 at 11:21 AM, Mike Gibson <mike.gibson(a)storagecraft.com> wrote: > Had a typo in the first try. > --- > dlls/msvcr100/msvcr100.spec | 2 +- > dlls/msvcr70/msvcr70.spec | 2 +- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/wcs.c | 9 +++++++++ > include/msvcrt/string.h | 1 + > include/msvcrt/wchar.h | 1 + > 8 files changed, 16 insertions(+), 5 deletions(-) > > > You forgot to attach the patch.

1 0

Re: [PATCH 2/6] quartz: Add support for filtermapper3 to filtergraph
by Alexandre Julliard Dec. 3, 2010

Dec. 3, 2010

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -269,6 +269,9 @@ static HRESULT WINAPI FilterGraphInner_QueryInterface(IUnknown * iface, > } else if (IsEqualGUID(&IID_IFilterMapper2, riid)) { > *ppvObj = This->pFilterMapper2; > TRACE(" returning IFilterMapper2 interface from aggregated filtermapper (%p)\n", *ppvObj); > + } else if (IsEqualGUID(&IID_IFilterMapper3, riid)) { > + *ppvObj = This->pFilterMapper2; > + TRACE(" returning IFilterMapper3 interface from aggregated filtermapper (%p)\n", *ppvObj); You have to query that interface first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Disable IME for msg tests.
by Marvin Dec. 3, 2010

Dec. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7434 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH] user32/tests: Close second window in DBCS WM_CHAR tests.
by Marvin Dec. 3, 2010

Dec. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7432 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/7] urlmon: Standardize COM implementation of IUri
by Alexandre Julliard Dec. 3, 2010

Dec. 3, 2010

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > @@ -3567,7 +3567,7 @@ static HRESULT set_builder_component(LPWSTR *component, DWORD *component_len, LP > return S_OK; > } > > -#define URI(x) ((IUri*) &(x)->lpIUriVtbl) > +#define URI(x) ((IUri*) &(x)->IUri_iface.lpVtbl) > #define URIBUILDER(x) ((IUriBuilder*) &(x)->lpIUriBuilderVtbl) You should also get rid of these macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Death to win9x?
by James Mckenzie Dec. 3, 2010

Dec. 3, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Dec 2, 2010 6:30 AM >To: Joerg-Cyril.Hoehle(a)t-systems.com >Cc: wine-devel(a)winehq.org >Subject: Re: Death to win9x? > ><Joerg-Cyril.Hoehle(a)t-systems.com> writes: > >> However, this only allows to run one test at a time, i.e. the big picture is missing. >> Therefore I'd suggest running winetest.exe on all testbot machines once a week >> or some such, e.g. only for releases. > >That's not useful. The whole point is that we don't want to spend the >effort required to keep the tests error-free on platforms that we don't >care about. That makes it easier to write tests for platforms that >actually matter, which is a more productive use of everybody's time. > YOU might not care about them AJ, but we have Wine users that are still using Windows95 programs with Wine on Linux and there are NO suitable replacements for them. Several recent user reports have asked how do I get program X (released for Windows95) to work on Wine. One of my test programs is dOOmII, released in 1996 and I use Wine to run it. Should I just go out and find a copy of Windows98SE and VirtualBox to run this on? Your reply makes it sound like the Wine program just does not care if Windows9x functionality does not matter, it does. I do agree that not much effort should be expended to incorporate more 'A' functionality, but breaking what does work is not reflect well on this project. Remember the original purpose and I think it is still the purpose is to build out the ENTIRE Windows64/32 API, not just a portion of it. If I'm wrong, feel free to chastise me. James McKenzie

3 3

Re: ddeml: More calling convention fixes
by Dmitry Timoshkov Dec. 3, 2010

Dec. 3, 2010

Tristan Schmelcher <tristan_schmelcher(a)alumni.uwaterloo.ca> wrote: > + if (cbData != (DWORD)-1) > + { > + /* pData is not a pointer if cbData is -1, so we linearize the address > + * here rather than in the calling code. */ > + pData = MapSL((SEGPTR)pData); > + } -1 here should be replaced by CBR_BLOCK, and this piece of the patch should be sent separately from .spec file fixes. -- Dmitry.

2 2

Re: msvcrt: Implement wcsnicoll
by Juan Lang Dec. 3, 2010

Dec. 3, 2010

Hi Mike, --- a/dlls/msvcr70/msvcr70.spec +++ b/dlls/msvcr70/msvcr70.spec @@ -601,7 +601,7 @@ @ cdecl _wcslwr(wstr) msvcrt._wcslwr @ stub _wcsncoll @ cdecl _wcsnicmp(wstr wstr long) msvcrt._wcsnicmp -@ stub _wcsnicoll +@ cdecl _wcsnicoll(wstr wstr long) msvcrt._wcsnicmp Typo?

1 0

Re: [3/7] urlmon: Implemented PARSE_PATH_FROM_URL for CoInternetParseIUri
by Marvin Dec. 3, 2010

Dec. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7419 Your paranoid android. === WVISTAADM (32 bit uri) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework
by C.W. Betts Dec. 3, 2010

Dec. 3, 2010

The main problem when using the QuickTime C APIs is that the majority, if not all of it, is deprecated and not available on 64-bit code. I would suggest using the Objective-C QTKit, but apparently Objective-C code is a no-no in Wine. On Nov 29, 2010, at 10:31 AM, Aric Stewart wrote: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec > > > <89fa3b1cdaca45ec01cde9e2350010b82c985666.diff>

3 3