December 2010 - Wine-Devel - list.winehq.org

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 29, 2010

Dec. 29, 2010

-----Original Message----- >From: Austin Lund <austin.lund(a)gmail.com> >Sent: Dec 28, 2010 6:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: Wine Developers <wine-devel(a)winehq.org> >Subject: Re: 64-bit Notepad2 crashes > >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> Stack dump: >> 0x000000000022b470: 0000000000000000 0000000000000000 >> 0x000000000022b480: 0000000000000000 0000000000000000 >> 0x000000000022b490: 0000000000000000 0000000000000000 >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >[snip] >> Backtrace: >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) > >The stack has been blitzed? Or is this local variables (even though >PathIsUNCW doesn't have any)? It's hard to know what's going on >without a proper stack trace. PathIsUNCW is such a small function, the >problem is almost certainly further up the call chain. Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? There used to be a place to post log files so people could look at them... but I've forgotten where it is.

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (msvcr80, 90 and 100 benefits from this) (resend)
by Alexandre Julliard Dec. 29, 2010

Dec. 29, 2010

Arno Teigseth <arnotixe(a)gmail.com> writes: > @@ -47,9 +76,16 @@ static void __cdecl test_invalid_parameter_handler(const wchar_t *expression, > const wchar_t *function, const wchar_t *file, > unsigned line, uintptr_t arg) > { > - /* we just ignore handler calls */ > + /* we USED TO just ignore handler calls */ > + CHECK_EXPECT(invalid_parameter_handler); > + ok(expression == NULL, "expression is not NULL\n"); > + ok(function == NULL, "function is not NULL\n"); > + ok(file == NULL, "file is not NULL\n"); > + ok(line == 0, "line = %u\n", line); > + ok(arg == 0, "arg = %lx\n", (UINT_PTR)arg); msvcrt doesn't allow changing the handler. Invalid parameter tests have to be in msvcr90. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite/tests: Use an iface instead of a vtbl pointer in testinput.
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7894 Your paranoid android. === WVISTAADM (32 bit reader) === No test summary line found === W7PRO (32 bit reader) === No test summary line found

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt take 4 Can't believe I forgot to commit before creating the patch...
by James Mckenzie Dec. 29, 2010

Dec. 29, 2010

Arno Teigseth <arnotixe(a)gmail.com> wrote: > You'll have to resend both parts of the patch for the testbot to recognize them. Use (resend) in the subject line for us humans. James McKenzie

1 0

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (The function was moved from msvcr90 to msvcrt so that msvcr80, 90 and 100
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7897 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: ntdll/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7877 Your paranoid android. === W7PROX64 (32 bit exception) === No test summary line found === WVISTAADM (32 bit directory) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\ntdll_test.exe, error 32

1 0

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value [try 2]
by Alexandre Julliard Dec. 28, 2010

Dec. 28, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -49,6 +49,7 @@ echo %UNKNOWN%S > echo P%UNKNOWN% > echo P%UNKNOWN%S > echo %ERRORLEVEL > +cmd /c exit 0 > echo %ERRORLEVEL% > echo %ERRORLEVEL%%ERRORLEVEL% > echo %ERRORLEVEL%ERRORLEVEL% It already has a defined value. What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implement _fcvt_s. (resend)
by Alexandre Julliard Dec. 28, 2010

Dec. 28, 2010

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > @@ -1127,9 +1127,9 @@ int CDECL _ecvt_s( char *buffer, MSVCRT_size_t length, double number, int ndigit > /* special case - inf */ > if(number == HUGE_VAL || number == -HUGE_VAL) > { > - memset(buffer, '0', ndigits); > + memset(buffer, '0', max(ndigits, 0)); > memcpy(buffer, infret, min(ndigits, sizeof(infret) - 1 ) ); > - buffer[ndigits] = '\0'; > + buffer[max(ndigits, 0)] = '\0'; You'd have to fix the memcpy too, though the whole thing doesn't make much sense if ndigits is negative. Probably needs to be rethought, with some test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/8] jscript: Ensure that the whole script is parsed
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7868 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] jscript: Better syntax error tests
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7867 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox
by Henri Verbeet Dec. 28, 2010

Dec. 28, 2010

On 28 December 2010 11:25, David Adam <david.adam.cnrs(a)gmail.com> wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) > +/************************************************************************* > + * D3DXCreateMeshFVF > + */ > +HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 pDevice, FLOAT fWidth, FLOAT fHeight, FLOAT fDepth, LPD3DXMESH *ppMesh, LPD3DXBUFFER *ppAdjacency) Seriously.

1 0

Re: 64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin Dec. 28, 2010

Dec. 28, 2010

>On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: >> I maybe should have filed this as a bug. >> I know Wine had a regression in 64-bit, and that such regression received a patch. >> I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. >> wine-1.3.10-48-g1288078 > > >Was the the first try or the second? >wineboot after a new version might take a bit. >It takes nearly no time here. > >Could you bisect to the slow down? Perhaps some printer stuff? > >Ciao, Marcus I think I've solved what is probably my problem. Notepad when started with the command "wine64" runs quickly. Notepad started with "wine" ran very slowly on one 64-bit partition that I've fiddled with a lot, and not at all on a cleaner 64-bit partition. Sorry for the confusion.

1 0

Re: [PATCH 1/2] mshtml: COM cleanup for the nsIWebBrowserChrome iface.
by Michael Stefaniuc Dec. 27, 2010

Dec. 27, 2010

Forgot to mention that this patch applies on top of Jacek's "mshtml: Fixed unsafe cast in CreateChromeWindow2 implementation" patch. On 12/27/2010 11:27 PM, Michael Stefaniuc wrote: > --- > dlls/mshtml/mshtml_private.h | 3 +- > dlls/mshtml/nsembed.c | 97 +++++++++++++++++++++-------------------- > dlls/mshtml/nsio.c | 8 ++-- > 3 files changed, 55 insertions(+), 53 deletions(-) bye michael

1 0

64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin Dec. 27, 2010

Dec. 27, 2010

I maybe should have filed this as a bug. I know Wine had a regression in 64-bit, and that such regression received a patch. I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. wine-1.3.10-48-g1288078

2 1

Re: spoolss/tests: Skip tests on Win7
by Paul Vriens Dec. 27, 2010

Dec. 27, 2010

On 12/27/2010 12:35 PM, Greg Geldorp wrote: > --- > dlls/spoolss/tests/spoolss.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > But that means we will skip on Wine as well (when/if implemented). Is that OK? -- Cheers, Paul.

2 2

Re: [PATCH 2/2] jscript: Added ScriptEngine*Version functions implementation
by Marvin Dec. 27, 2010

Dec. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7836 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added ScriptEngine() implementation
by Marvin Dec. 27, 2010

Dec. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7835 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml: COM cleanup for the IHTMLWindow2 iface.
by Jacek Caban Dec. 27, 2010

Dec. 27, 2010

On 12/27/10 12:50 PM, Michael Stefaniuc wrote: > --- > Jacek, I don't like the usage of impl_from_IHTMLWindow2() in > HTMLWindow_invoke() as that isn't a method of the IHTMLWindow2 vtbl. Can > you please cross check that and clean it up if necessary? That's fine itself, the IUnknown passed there is defined by HTMLWindow object and it's IHTMLWindow2 iface in this case. However it can be done better and we can avoid this particular impl_from_IHTMLWindow2 call. I will send a patch after your patch will be in Git. Thanks, Jacek

1 0

Hebrew version of Wine History
by Yaron Shahrabani Dec. 27, 2010

Dec. 27, 2010

Hey, I translated the Wine History into Hebrew several weeks ago and I noticed that although the patches are in, when I click on Wine's History on the Hebrew website I'm being taken to the English version of the document in Wine's wiki. Wine's history is pretty important to the Israeli community in various aspects, can it be fixed? Kind regards, Yaron Shahrabani <Hebrew translator>

2 1

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value
by Marvin Dec. 26, 2010

Dec. 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7830 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 73 (got '0', wanted '5') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2KPROSP4 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WXPPROSP3 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K3R2SESP2 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WVISTAADM (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K8SE (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PRO (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (64 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55')

1 0

Feature Request: winefile: some way to open terminal in current folder
by Ilya Basin Dec. 26, 2010

Dec. 26, 2010

A typical scenario: - download a file with uTorrent - select "Open containing folder" - ??? - use a native program to work with the downloaded file I think, it would be convenient to add a button to start a terminal or do "xdg-open ."

1 0

None
by paulo lesgaz Dec. 25, 2010

Dec. 25, 2010

http://2nax.awardspace.com/page.php

3 2

d3dxcreatebox
by David Adam Dec. 25, 2010

Dec. 25, 2010

Hello, is there any problem with the patch for D3DXCreateBox? I think it was not commited. Thanks in advance for any feedback? A+ David

2 1

Re: [2/2]setupapi/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 24, 2010

Dec. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7825 Your paranoid android. === WNT4WSSP6 (32 bit misc) === No test summary line found

1 0

Re: Eryk Wieliczko : msvcrt/tests: Add _fcvt_s tests.
by Eryk Wieliczko Dec. 24, 2010

Dec. 24, 2010

Quick question: why todo_wine? Respectfully, Eryk Wieliczko 2010/12/23 Alexandre Julliard <julliard(a)winehq.org>: > Module: wine > Branch: master > Commit: b74ef16d99f3c2f7e4a0a7e453c71b6da2c70310 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b74ef16d99f3c2f7e4a0a7e45… > > Author: Eryk Wieliczko <ewdevel(a)gmail.com> > Date: Wed Dec 22 23:10:56 2010 +0100 > > msvcrt/tests: Add _fcvt_s tests. > > --- > > dlls/msvcrt/tests/printf.c | 29 +++++++++++++++++++++++++++-- > 1 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c > index 87efd16..d32ef73 100644 > --- a/dlls/msvcrt/tests/printf.c > +++ b/dlls/msvcrt/tests/printf.c > @@ -40,6 +40,8 @@ static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, > __ms_va_list valist); > static int (__cdecl *p__ecvt_s)(char *buffer, size_t length, double number, > int ndigits, int *decpt, int *sign); > +static int (__cdecl *p__fcvt_s)(char *buffer, size_t length, double number, > + int ndigits, int *decpt, int *sign); > > static void init( void ) > { > @@ -49,6 +51,7 @@ static void init( void ) > p__vscwprintf = (void *)GetProcAddress(hmod, "_vscwprintf"); > p__vsnwprintf_s = (void *)GetProcAddress(hmod, "_vsnwprintf_s"); > p__ecvt_s = (void *)GetProcAddress(hmod, "_ecvt_s"); > + p__fcvt_s = (void *)GetProcAddress(hmod, "_fcvt_s"); > } > > static void test_sprintf( void ) > @@ -799,7 +802,7 @@ static void test_xcvt(void) > "_fcvt() decimal point wrong, got %d expected %d\n", decpt, > test_cvt_testcases[i].expdecpt_f); > ok( sign == test_cvt_testcases[i].expsign, > - "_ecvt() sign wrong, got %d expected %d\n", sign, > + "_fcvt() sign wrong, got %d expected %d\n", sign, > test_cvt_testcases[i].expsign); > } > > @@ -823,7 +826,29 @@ static void test_xcvt(void) > free(str); > } > else > - win_skip("_ecvt_s not available\n"); > + win_skip("_ecvt_s not available\n"); > + > + if (p__fcvt_s) > + { > + str = malloc(1024); > + for( i = 0; strcmp( test_cvt_testcases[i].expstr_e, "END"); i++){ > + decpt = sign = 100; > + err = p__fcvt_s(str, 1024, test_cvt_testcases[i].value, test_cvt_testcases[i].nrdigits, &decpt, &sign); > + ok(err == 0, "_fcvt_s() failed with error code %d", err); > + ok( 0 == strncmp( str, test_cvt_testcases[i].expstr_f, 15), > + "_fcvt_s() bad return, got \n'%s' expected \n'%s'\n", str, > + test_cvt_testcases[i].expstr_e); > + ok( decpt == test_cvt_testcases[i].expdecpt_f, > + "_fcvt_s() decimal point wrong, got %d expected %d\n", decpt, > + test_cvt_testcases[i].expdecpt_e); > + ok( sign == test_cvt_testcases[i].expsign, > + "_fcvt_s() sign wrong, got %d expected %d\n", sign, > + test_cvt_testcases[i].expsign); > + } > + free(str); > + } > + else > + todo_wine win_skip("_fcvt_s not available\n"); > } > > static int __cdecl _vsnwprintf_wrapper(wchar_t *str, size_t len, const wchar_t *format, ...) > > > >

2 1