December 2010 - Wine-Devel - list.winehq.org

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus.
by James Mckenzie Dec. 20, 2010

Dec. 20, 2010

Damian Dixon <damian.dixon(a)gmail.com> wrote: >Sent: Dec 20, 2010 1:28 PM >To: wine-patches(a)winehq.org >Cc: damian.dixon(a)gmail.com >Subject: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus. > Please rebase to current git. James McKenzie

1 0

Re: jscript: Exception tests clean up.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Nikolay Sivov Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 20:29, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) You can't split this in two patches, cause tests should run without failures after each patch. So in your case remove todo_wine in the same patch.

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Andrew Nguyen Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 11:29 AM, Damian Dixon wrote: > + if (!lpservicestatus) > + { > + OSVERSIONINFOW osVi; > + /* Get windows version emulating */ > + osVi.dwOSVersionInfoSize = sizeof(osVi); > + GetVersionExW(&osVi); > + if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT) > + { > + if (osVi.dwMajorVersion > 4) > + { > + SetLastError(ERROR_INVALID_ADDRESS); > + } > + else > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + } > + } > + return FALSE; > + } > + You shouldn't need to check the Windows version. Setting the last error to a reasonable value for a particular platform is sufficient.

1 0

Re: [2/2] advapi32/tests: Remove todo_wine so change made in QueryServiceStatus does not cause a failure
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7718 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Mark Win7 behaviour as broken
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/shell32/tests/shlview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll/tests: Remove tests for overlong instructions
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

"Greg Geldorp" <ggeldorp(a)vmware.com> writes: > The "overlong instruction" test produces different results on different > test machines. Since it fails on other machines besides the TestBot VMs I > don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATH try2] widl: Added support for registering alternative progids.
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > This will be needed for jscript registration. This seems very ad-hoc. Unless there are many other places that need it, I think it should be handled manually in jscript. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Added Date.setYear implementation.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: libs/wine: check for empty string in WINEPREFIX
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > see http://bugs.winehq.org/show_bug.cgi?id=25554 I don't think that's necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by cheer_xiao Dec. 20, 2010

Dec. 20, 2010

Hi Susan, On Dec 19, 2010 8:59 PM, "Susan Cragin" <susancragin(a)earthlink.net> wrote: > > I'm compiling from git onto 64-bit Natty, which is in Alpha. > > Wine's apt-get build-dep script seems to be missing the following. > > configure: OpenCL 32-bit development files not found, OpenCL won't be supported. > configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled > > I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: > python-pyopencl > but still got the warning. > > I know it's too early to mention this, since Natty's still in Alpha. I'm running Ubuntu Lucid and have this problem too. As with Natty, Lucid's repo has development files for gstreamer, but installing them doesn't eliminate the warning about gstreamer. Lucid's repo doesn't contain dev files for OpenCL, either. If I'm not mistaken support for OpenCL was added recently, as I didn't get that warning several weeks ago. I guess this problem could be solved simply by compiling some packages and passing some arguments to ./configure, but as a newbie I'm too looking forward to an answer.

3 2

Wine and serial port AGAIN
by Pavel Troller Dec. 20, 2010

Dec. 20, 2010

Hi! As a technician, I need often to use some form of serial port communication. My recent experience is with a program for programming TYT radios from China. They supply a simple windows app, which allows to program all the features of the radio, which cannot be accomplished using the radio keyboard only. The program works perfectly in wine, with one exception - a physical comms with the radio. It complains that it doesn't receive a response from the radio, while the radio crashes - it stops working, when a programming attempt is made, and has to be power-cycled. The radio is connected using a USB cable, which contains just a regular PL-2303 USB to serial converter, which is perfectly supported in Linux. Port assignment for wine is also done, proof of which is, that the radio crashes upon the programming request. The data volume to be programmed is small, just a few hundreds of bytes. It's really stupid that I can prepare my data in the program only, and then I need to ask my colleague with real windows to perform a programming job :-(. The program can be freely downloaded from the TYT pages: http://www.tyt888.com/WebEditor/UploadFile/201096144939483.rar but a real radio is needed to debug the comms problem. I've captured the console output with WINEDEBUG=+comm, which is attached. It contains a log of three consecutive attempts to program the radio. I'm ready to do more debugging, but I don't know, how to proceed now. With regards, Pavel.

5 15

64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by Susan Cragin Dec. 20, 2010

Dec. 20, 2010

I'm compiling from git onto 64-bit Natty, which is in Alpha. Wine's apt-get build-dep script seems to be missing the following. configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: python-pyopencl but still got the warning. I know it's too early to mention this, since Natty's still in Alpha.

2 1

Re: secur32/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7712 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PROX64 (32 bit schannel) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: qmgr/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7710 Your paranoid android. === W7PROX64 (64 bit qmgr) === No test summary line found

1 0

Re: schannel/tests: Fix tests for some 2k machines
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7711 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

TestBot changes
by Greg Geldorp Dec. 19, 2010

Dec. 19, 2010

I've made some changes to TestBot over the last week. The most important change is the addition of an extra physical server. About half of the VMs have been moved over to this new server. This should speed up testing a bit. Other changes include upgrading the hypervisor to ESX 4.1, applying Windows Update patches to various VMs and fixing some problems in the TestBot scripts. I'll probably continue tweaking things for the next week or so, which means there can be unexpected failures. For those interested in the setup of TestBot, it currently consists of 3 physical machines: 1) Dell PowerEdge SC1435, quad-core AMD Opteron 2.2GHz, 16GB memory, 1.4TB storage, running VMware ESX 4.1. Hosts about half of the NT4+ VMs plus the website/engine VM. 2) Dell PowerEdge R310, quad-core Intel Xeon X3430 2.4GHz, 16GB memory, 550GB storage, running VMware ESX 4.1. Hosts the other half of the NT4+ VMs. This is the new machine. 3) Whitebox, quad-core Intel Core i7 975 3.33GHz, 6GB memory, 450GB storage, running VMware Server on top of openSuSE 11.3. Hosts the Win9x VMs. Greg.

1 0

Re: programs/notepad/Nl.rc and programs/winecfg/Nl.rc: patch for Dutch translation (resend)
by Austin English Dec. 19, 2010

Dec. 19, 2010

On Sat, Dec 18, 2010 at 9:15 AM, Albert Pool <albertpool(a)solcon.nl> wrote: > Hello, > > I have fixed some English texts which had appeared in the Dutch > translation of notepad and winecfg. The previous mail with these patch > seems not to be arrived at you, so I've resent it. You forgot the patch :-). -- -Austin

1 0

Re: [advapi32] Added check for NULL pointer being passed to QueryServiceStatus as lpservicesstatus parameter.
by Nikolay Sivov Dec. 18, 2010

Dec. 18, 2010

On 12/18/2010 18:46, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c > index 7fea937..f8d329f 100644 > --- a/dlls/advapi32/service.c > +++ b/dlls/advapi32/service.c > @@ -1130,6 +1130,7 @@ BOOL WINAPI QueryServiceStatus(SC_HANDLE hService, > > TRACE("%p %p\n", hService, lpservicestatus); > > + if (!lpservicestatus) return FALSE; > ret = QueryServiceStatusEx(hService, SC_STATUS_PROCESS_INFO, > (LPBYTE)&SvcStatusData, > sizeof(SERVICE_STATUS_PROCESS),&dummy); > if (ret) memcpy(lpservicestatus,&SvcStatusData, sizeof(SERVICE_STATUS)) > ; Add a test for that please. Also last error is probably affected by this.

1 0

Full path to wine executable in generated .desktop files
by Ilya Basin Dec. 18, 2010

Dec. 18, 2010

When you install a program, some desktop files are put here: ~/.local/share/applications/wine/ ~/Desktop/ [Desktop Entry] Name=Microsoft Office Access 2003 Exec=env WINEPREFIX="/home/leniviy/.wine" wine ... I have 2 wine instances: official in /usr and patched in /opt/wine-csshack . Because of that I would like to have "/opt/wine-csshack/bin/wine", not just "wine" in the generated .desktop files. What can go wrong if we do so?

1 0

Removal of dcom98 from winetricks?
by Scott Ritchie Dec. 18, 2010

Dec. 18, 2010

I remember discussing this at wineconf as something we should do, but it seems there's at least one situation I've found where it still helps: http://bugs.winehq.org/show_bug.cgi?id=8780 Is it possible this is a hidden issue bleeding into other apps as well? Thanks, Scott Ritchie

1 0

socks & wine, patching wininet to use winsock
by Gabriele Greco Dec. 18, 2010

Dec. 18, 2010

I'm trying to make programs that need a socks proxy to work on wine. They work with freecaps or similar winsock patches as long as they don't use wininet or other indirect winsocks APIs to make their stuff, if they use wininet those patches could not work since wininet bypasses winsocks and use linux sockets directly. In the head of the wininet.dll sources there is this comment: /* FIXME!!!!!! * This should use winsock - To use winsock the functions will have to change a bit * as they are designed for unix sockets. * SSL stuff should use crypt32.dll */ I tried to change netconnection.c to use winsock functions WSAConnect, WSASend & WSARecv since WS_send, WS_recv and WS_connect are not exposed by ws2_32 instead of direct linux socket functions (connect/send/recv), but I had no way to check the problems with unix sockets vs inet sockets cause the library crashes wine before hitting anything related with my CODE patches. It crashes simply because I've added in Makefile.in ws2_32 module IMPORTS, doing so what I've observed is that standard linux sockets calls are "wrapped" and points now to NULL (because ws2_32 is not loaded?). In this specific case "getaddrinfo" is NULL and HTTP_ResolveName crashes when calling it. Anyone can suggest me the correct approach to implement this? I have to load manually ws2_32 in the wininet initialization? -- Bye, Gabry

2 1

Re: widl: Added support for registering alternative progids.
by Huw Davies Dec. 17, 2010

Dec. 17, 2010

On Fri, Dec 17, 2010 at 04:14:24PM +0100, Jacek Caban wrote: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c924a66..28cb1da 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -190,7 +190,7 @@ static statement_list_t *append_statement(statement_list_t *list, statement_t *s > -%token tAGGREGATABLE tALLOCATE tANNOTATION tAPPOBJECT tASYNC tASYNCUUID > +%token tAGGREGATABLE tALLOCATE tANNOTATION tAPPOBJECT tASYNC tASYNCUUID tALTPROGID Hi Jacek, This breaks alphabetical order in this line. Cheers, Huw.

1 0

Re: [PATCH 5/7] mshtml: Added IHTMLScriptElement::get_scr implementation.
by Marvin Dec. 17, 2010

Dec. 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7657 Your paranoid android. === W7PRO (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0