December 2010 - Wine-Devel - list.winehq.org

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus.
by James Mckenzie Dec. 20, 2010

Dec. 20, 2010

Damian Dixon <damian.dixon(a)gmail.com> wrote: >Sent: Dec 20, 2010 1:28 PM >To: wine-patches(a)winehq.org >Cc: damian.dixon(a)gmail.com >Subject: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus. > Please rebase to current git. James McKenzie

1 0

Re: jscript: Exception tests clean up.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Nikolay Sivov Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 20:29, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) You can't split this in two patches, cause tests should run without failures after each patch. So in your case remove todo_wine in the same patch.

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Andrew Nguyen Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 11:29 AM, Damian Dixon wrote: > + if (!lpservicestatus) > + { > + OSVERSIONINFOW osVi; > + /* Get windows version emulating */ > + osVi.dwOSVersionInfoSize = sizeof(osVi); > + GetVersionExW(&osVi); > + if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT) > + { > + if (osVi.dwMajorVersion > 4) > + { > + SetLastError(ERROR_INVALID_ADDRESS); > + } > + else > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + } > + } > + return FALSE; > + } > + You shouldn't need to check the Windows version. Setting the last error to a reasonable value for a particular platform is sufficient.

1 0

Re: [2/2] advapi32/tests: Remove todo_wine so change made in QueryServiceStatus does not cause a failure
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7718 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Mark Win7 behaviour as broken
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/shell32/tests/shlview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll/tests: Remove tests for overlong instructions
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

"Greg Geldorp" <ggeldorp(a)vmware.com> writes: > The "overlong instruction" test produces different results on different > test machines. Since it fails on other machines besides the TestBot VMs I > don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATH try2] widl: Added support for registering alternative progids.
by Alexandre Julliard Dec. 20, 2010

Dec. 20, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > This will be needed for jscript registration. This seems very ad-hoc. Unless there are many other places that need it, I think it should be handled manually in jscript. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Added Date.setYear implementation.
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0