February 2010 - Wine-Devel - list.winehq.org

Re: idea: display drivers
by James McKenzie Feb. 7, 2010

Feb. 7, 2010

Roderick Colenbrander wrote: > On Sun, Feb 7, 2010 at 6:41 PM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: > >> Correct. But why keep the old stuff around? It might be confusing to >> the Wine beginner. >> >> > > The new style driver would only work on modern hardware like windows7 does. > > That makes sense. However, how long are we going to support 'older' hardware? Most manufacturers give up after two years. James McKenzie

1 0

Re: [4/6] wininet: Clean up locks after closing libssl and libcrypto.
by Paul Vriens Feb. 7, 2010

Feb. 7, 2010

On 02/07/2010 04:56 PM, Paul Vriens wrote: > On 02/07/2010 04:46 PM, Hans Leidekker wrote: >> On Sunday 07 February 2010 16:24:11 Paul Vriens wrote: >> >>>> if (OpenSSL_ssl_handle) >>>> @@ -305,6 +297,12 @@ void NETCON_unload(void) >>>> pSSL_CTX_free(ctx); >>>> wine_dlclose(OpenSSL_ssl_handle, NULL, 0); >>>> } >>>> + if (ssl_locks) >>>> + { >>>> + int i; >>>> + for (i = 0; i< pCRYPTO_num_locks(); i++) >>>> DeleteCriticalSection(&ssl_locks[i]); >>>> + HeapFree(GetProcessHeap(), 0, ssl_locks); >>>> + } >>>> #endif >>>> } >>>> >>> Hi Hans, >>> >>> I was checking a crash in an installer (the AkamaiDownloadManager to >>> download CS4 for example) and it looks like we are accessing a ssl >>> function CRYPTO_num_locks() after we've closed the library? >>> >>> Can you confirm this? >> >> Yes, looks like I fixed this in winhttp but forgot to send the same >> patch for >> wininet. Try this patch. >> >> -Hans > > Yup, crash is gone, thanks. > Forgot to include wine-devel. -- Cheers, Paul.

1 0

Re: [4/6] wininet: Clean up locks after closing libssl and libcrypto.
by Paul Vriens Feb. 7, 2010

Feb. 7, 2010

On 10/27/2009 10:04 AM, Hans Leidekker wrote: > Found by valgrind. > --- > dlls/wininet/netconnection.c | 14 ++++++-------- > 1 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index 97c764f..16cce40 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c > @@ -289,14 +289,6 @@ void NETCON_unload(void) > #if defined(SONAME_LIBSSL)&& defined(SONAME_LIBCRYPTO) > if (OpenSSL_crypto_handle) > { > - if (ssl_locks) > - { > - int i; > - > - for (i = 0; i< pCRYPTO_num_locks(); i++) > - DeleteCriticalSection(&ssl_locks[i]); > - HeapFree(GetProcessHeap(), 0, ssl_locks); > - } > wine_dlclose(OpenSSL_crypto_handle, NULL, 0); > } > if (OpenSSL_ssl_handle) > @@ -305,6 +297,12 @@ void NETCON_unload(void) > pSSL_CTX_free(ctx); > wine_dlclose(OpenSSL_ssl_handle, NULL, 0); > } > + if (ssl_locks) > + { > + int i; > + for (i = 0; i< pCRYPTO_num_locks(); i++) DeleteCriticalSection(&ssl_locks[i]); > + HeapFree(GetProcessHeap(), 0, ssl_locks); > + } > #endif > } > Hi Hans, I was checking a crash in an installer (the AkamaiDownloadManager to download CS4 for example) and it looks like we are accessing a ssl function CRYPTO_num_locks() after we've closed the library? Can you confirm this? -- Cheers, Paul.

2 1

re: Forward SHLocalAlloc to kernel32 LocalAlloc
by Dan Kegel Feb. 7, 2010

Feb. 7, 2010

What app needs this? It's been discussed before a bit; Win 98 explorer used it, http://www.winehq.org/pipermail/wine-devel/2005-August/039487.html but http://www.geoffchappell.com/viewer.htm?doc=studies/windows/shell/shell32/a… says that ordinal 200 was later taken over by SHCreateDesktop. Unless we have a real good reason, we probably want to go with the later scheme. - Dan

1 0

Participate to GSoC
by Warren Dumortier Feb. 7, 2010

Feb. 7, 2010

Hello everybody! First i'll present myself. So my name's Warren Dumortier and i live in Belgium, i've been using Wine for 4 years and i've always been interrested on how it works Also i'm quite active on AppDB for submitting apps. I actively program in C on Linux since 3 years as Gfire (our program) developer. As i actively program in C and would like to develop for WINE, i had a look at the GSoC wiki page. This year i could finally participate as i'm legally allowed now. Are there any specific things to know in order to be accepted as a GSoC student for WINE? These are the two ideas i'd like to implement: Theming - Implement Wine GTK/QT theming support Vista Game Explorer API - Implement the core functionality of this dll I don't know which one i would choose yet, but how are ideas assigned to students, are there requirements needed for each idea? Then i could for example get familiar with the idea before the GSoC starts... When can i ask to be GSoC student? Thanks in advance, kind regards.

2 1

Re: [ mshtml missing function ]
by lementec fabien Feb. 6, 2010

Feb. 6, 2010

2010/2/6 lementec fabien <fabien.lementec(a)gmail.com>: > hi, > > thanks for the patch but it doesnot make > solidwork works actually, even if it solves > the previous issue. The error is now: > fixme:mshtml:HTMLBodyElement_put_leftMargin > > I will file a bug, > > Regards, > > Fabien. > > 2010/2/6 Jacek Caban <jacek(a)codeweavers.com>: >> On 2/6/10 10:11 PM, lementec fabien wrote: >>> >>> Hi, >>> >>> I have mostly managed to make solidworks2010 work >>> under the latest version of wine. The following function >>> has a missing feature when called with the variant set to >>> 3: >>> dlls/mshtml.c::HTMLStyle_put_width >>> >> >> You may try the attached patch (compile tested only). >> >>> I dont know anything related to mshtml, >> >> Then please file a bug instead of writing to wine-devel. >> >>> so it would be >>> great if anyone is interested in implementing it... would >>> make this great software works with wine. >>> >> >> I'd be skeptical about this, it's probably more work. >> >> >> Jacek >> >> >> >> > > > > -- > the number of UNIX installations has grown to 10, with more expected. > The unix programmer's manual, June, 1972 > -- the number of UNIX installations has grown to 10, with more expected. The unix programmer's manual, June, 1972

1 0

[ mshtml missing function ]
by lementec fabien Feb. 6, 2010

Feb. 6, 2010

Hi, I have mostly managed to make solidworks2010 work under the latest version of wine. The following function has a missing feature when called with the variant set to 3: dlls/mshtml.c::HTMLStyle_put_width I dont know anything related to mshtml, so it would be great if anyone is interested in implementing it... would make this great software works with wine. Regards, Fabien. -- the number of UNIX installations has grown to 10, with more expected. The unix programmer's manual, June, 1972

3 2

winedbg: output of the bt command misses sometimes a frame
by Bernhard Übelacker Feb. 6, 2010

Feb. 6, 2010

Hello, as I was debugging in wine I wondered if following behaviour is intended or could be considered a bug (and should be filed in bugtracker?). When the debugger's current position is on the opening curly bracket of a function a "bt" command writes a different stack as if the current position is on the next instruction in this function. What me makes wonder is the frame 0 is always correct but the calling function is not in the stack at all in the first bt: Wine-dbg>bt Backtrace: =>0 0x7ebe3622 IsWindow(hwnd=0x20060) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:2503] in user32 (0x0033b500) 1 0x7e25429d create_window16+0x5c(cs=0x33b53c, className="QWidget", instance=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user.exe16/message.c:2670] in user.exe16 (0x0033b520) 2 0x7ebe0f91 CreateWindowExW+0x7e(exStyle=1024, className="QWidget", windowName="pica", style=114032640, x=-2147483648, y=-2147483648, width=-2147483648, height=-2147483648, parent=(nil), menu=(nil), instance=0x400000, data=0x0(nil)) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1500] in user32 (0x0033b570) 3 0x650778f3 in qtgui4 (+0x778f3) (0x80000000) Wine-dbg>next 2507 if (!(ptr = WIN_GetPtr( hwnd ))) return FALSE; Wine-dbg>bt Backtrace: =>0 0x7ebe3637 IsWindow+0x15(hwnd=0x20060) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:2507] in user32 (0x0033b2b0) 1 0x7ebe0bda WIN_CreateWindowEx+0x1201(cs=0x33b53c, className="QWidget", module=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1406] in user32 (0x0033b500) 2 0x7e25429d create_window16+0x5c(cs=0x33b53c, className="QWidget", instance=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user.exe16/message.c:2670] in user.exe16 (0x0033b520) 3 0x7ebe0f91 CreateWindowExW+0x7e(exStyle=1024, className="QWidget", windowName="pica", style=114032640, x=-2147483648, y=-2147483648, width=-2147483648, height=-2147483648, parent=(nil), menu=(nil), instance=0x400000, data=0x0(nil)) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1500] in user32 (0x0033b570) 4 0x650778f3 in qtgui4 (+0x778f3) (0x80000000) Wine-dbg> Kind regards Bernhard

3 2

Re: msxml3: implement-domtext_replaceData
by Nikolay Sivov Feb. 6, 2010

Feb. 6, 2010

On 2/6/2010 04:36, jose rostagno wrote: > implement domtext_replaceData function > <http://www.descubrewindowslive.com/hotmail/anti-spam.asp> > + if(offset == 0){ > + IXMLDOMText_substringData(iface, count, len - count,&str); > + hr = IXMLDOMText_put_data(iface, str); > + if(hr == S_OK) > + hr = IXMLDOMText_put_data(iface, p); > This is obviously wrong. As a result just p will be stored as new data. Let's deal with previous patch first, next patch should most likely just duplicate it.

1 0

libpng dependency issue
by Luca Bennati Feb. 6, 2010

Feb. 6, 2010

First: should i open a bug for this? The problem is from the new libpng 1.4.0: this evening i just updated this lib, and now i get compile error in dlls/windowscodecs/pngformat.c I'm still investigating the issue to find a solution, but the change that introduced this is clear, directly from their README: Removed deprecated functions png_read_init, png_write_init, png_info_init, png_permit_empty_plte, png_set_gray_1_2_4_to_8, and removed the deprecated macro PNG_MAX_UINT. So, what should WINE do? I see two actions that need to be performed: 1- check the libpng version in configure 2- adjust pngformat.c to work with the new lib. For a short term solution, needed also in the long term one (in the beginning), configure should give error if libpng isn't < 1.4.0 In the long term, while distros begin to ship libpng 1.4.0, the main developers of windowscodecs should work out a code solution. What is that i cannot say, since i don't really know the code, but i think it won't be a few minutes of work... This could apply also to libjpeg since it bumped to 8.0, but i didn't try that part yet.

4 16