March 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] oleaut32/tests: Make tests working on older systems, prevent crash on some wine boxes
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 10:05 PM, Piotr Caban wrote: > hres = ICreateTypeInfo_AddRefTypeInfo(createti, unknown,&hreftype); > ok(hres == S_OK, "got %08x\n", hres); > + if(hres != S_OK) { > + skip("Skipping some tests\n"); > + return; > + } Hi Piotr, If it's acceptable to get something else besides S_OK you should change the ok() and add a broken() (still bail out of course). A skip() usually means that something valid happened and we need to bail out. -- Cheers, Paul.

3 7

lstrcmpW on Windows ignores some special unicode characters
by Paul Vriens March 18, 2010

March 18, 2010

Hi, I already mentioned this in my last shlwapi patch. lstrcmpW (and CompareStringW for that matter) ignore some special unicode characters like 0x200e (and also loads of others). Do we care? I.o.w. is there a need for implementing this? I only tested these characters at the start of the strings btw. -- Cheers, Paul.

2 1

Re: [1/3] winex11: Add implementation of Triangle Inequality Nearest Neighbour algorithm.
by Paul Vriens March 18, 2010

March 18, 2010

On 03/18/2010 09:57 AM, Vitaly Budovski wrote: > /* > - Some of the following helper functions are duplicated in > +_ Somf of the following helper functions are duplicated in > dlls/gdi/dib.c > */ Hi Vitaly, I can't comment on the rest of the code but this piece doesn't look like it's intended. -- Cheers, Paul.

1 0

New winetricks 20100316: new verbs steam, adobeair, 7zip, d3dxof, win7
by Dan Kegel March 18, 2010

March 18, 2010

Today's winetricks was brought to you by the letters W and S, and the number 7. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel Don't detect desktop environment, detect individual programs. Make warnings more obvious on console. flash: updated gecko: updated ie6: improved prerequisite checking psdkwin7: requires native gdiplus for the moment, so make that a prerequisite for now psdkwin7: some important registry keys (kludge) steam: added win7: added Austin English Don't consider missing cabextract fatal, unless it's actually being used Don't use cabextract directly, use the wrapper for all uses (issue 95) Use a more sane path for C:. Patch from 'arielco'. Issue 96. adobeair: add to winetrickstest, add missing decorations dotnet20: Check for mscorlib.dll rather than l_intl.nls icodec: remove, it's no longer online mpc: Update Andrew Nguyen Suppress STDERR messages from which command 7zip: added adobeair: added d3dxof: added msxml4/msxml6: add override before installing vc2005trial: Use 7-zip to extract the UDF image rather than mounting it (so we can avoid sudo/root) Pavel Zinin directx9: update to February 2010 version

1 1

re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays
by Dan Kegel March 18, 2010

March 18, 2010

Can you write a test for that?

1 0

Re: cmd: Add skeleton ping command (try 2)
by Alexandre Julliard March 18, 2010

March 18, 2010

Trey Hunner <treyhunner(a)gmail.com> writes: > +int main(int argc, char** argv) > +{ > + int n = 0; > + int optc; > + > + while ((optc = getopt( argc, argv, "n:w:" )) != -1) > + { > + switch(optc) > + { > + case 'n': > + n = atoi( optarg ); > + break; > + case '?': > + usage(); > + exit(1); > + } > + } You should at least print a FIXME for other options that it's supposed to support, instead of silently succeeding and doing nothing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 04:21 PM, Ilya Basin wrote: > @@ -1013,7 +1011,7 @@ static void test_filename(void) > "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); > } > - else todo_wine > + else > { > ok(rc==test->rc, "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); Hi Ilya, If this is no longer a todo_wine you should change the filename_tests struct: /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x1, 33}, to /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x0, 33}, You can even consider removing the "if ((test->todo & 0x1)==0)" as now there are no more of those tests. On the one hand it's nice to have these todo constructs, removing them however is a greater incentive to get the implementation right ;) -- Cheers, Paul.

3 2

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride
by Henri Verbeet March 18, 2010

March 18, 2010

On 17 March 2010 14:48, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This first patch disables hardware accelerated 8-bit blitting. This > code will completely use the shader backend later on and won't require > hacks like 'paletteOverride'. > I'm not sure breaking things is the right approach?

3 3

Measuring game FPS in wine/windows?
by Austin English March 18, 2010

March 18, 2010

Howdy, I've been testing some games lately on Windows/Wine, and wanted to see the difference in framerates. On windows, I've been using Fraps, which works decently well, but not under wine (and it doesn't work for Assassin's creed). I found D3DGears online, which supposedly works for Assassin's creed on Windows (haven't checked), but doesn't work under wine. Does anyone know of a standalone application that works under wine? Thanks! -Austin

3 2

Re: [1/3] winex11: Add implementation of Triangle Inequality Nearest Neighbour algorithm.
by Roderick Colenbrander March 18, 2010

March 18, 2010

Hi Vitaly, In case of Age of Empires the performance is certainly affected by the DIB code. As you have seen, right now we perform all rendering (except when XRender is around but that's typically for >8-bit) at the depth of the Xserver and perform conversions back and forth. Alexandre mentioned some time that we should avoid doing these conversions altogether (they caused issues at <8-bit but I don't remember him saying what the issues were) and that instead we should provide X11 with 8-bit data if we are dealing with 8-bit data. I guess that's how he wants this to continue but I have no idea how easy it is to change all this. Roderick On Thu, Mar 18, 2010 at 9:57 AM, Vitaly Budovski <> wrote: > This will allow faster palette lookups for 8 bit palettes. > > This may come up in a reply, so I'll address it now. Float must be used > since an int doesn't provide enough range for the numbers we are dealing > with. > > > >

1 0

Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 02:22 PM, Jacek Caban wrote: > --- a/programs/cmd/tests/test_builtins.cmd.exp > +++ b/programs/cmd/tests/test_builtins.cmd.exp > @@ -16,6 +16,7 @@ bar > ~dp0 should be directory containing batch file > @pwd@\ > @pwd@\ > +(a)pwd@@or_broken(a)ECHO is off. Won't this fail on non English locales? In this case it will only fail on non English NT4 boxes, but still. -- Cheers, Paul.

2 1

Winsock event patches - review and test please
by Mike Kaplinskiy March 18, 2010

March 18, 2010

Hello all, I've been working on fixing some of the winsock event handling issues in wine, so I'm looking for someone to give these patches a review and test them on some apps that use that kind of stuff, i.e. apps that call WSAEventSelect or WSAAsyncSelect. I'm not quite certain on the portability of all the code, so if anyone on a non-linux-2.6 can give the tests a run that would be great. The tests pass on windows ignoring failure after line 3259 (the tests below are wine-specific). Thanks, Mike.

1 0

Re: [1/2] urlmon: Add stub IUriBuilder interface (try2)
by Nikolay Sivov March 18, 2010

March 18, 2010

On 3/18/2010 04:16, Nikolay Sivov wrote: > I know comdlg32 doesn't seem to be very close to urlmon, but stub I added shows a problems in included headers order. > SetPort method from IUriBuilder collides with SetPort define from winspool.h and a build error comes up saying I'm using > unprefixed call (without A or W). > Hm, next conflict is in programs/clock. Chain is windows.h -> ole2.h -> objbase.h -> urlmon.h In windows.h there's include winspool.h before ole2.h, and this causes conflict. Not sure how to fix it now, any comments are welcome. > Second patch should apply cleanly. >

1 0

Re: Small spelling fixes.
by Vincent Povirk March 17, 2010

March 17, 2010

Thanks for sending a patch for this. It seems it was not committed, probably because your mailer added line-breaks, making it difficult to apply. Could you resend as an attachment, or without the line breaks if you can configure your mailer to do that? Or, if you prefer, I can send this with fixed formatting on your behalf. 2010/3/12 Julian Rüger <jr98(a)gmx.net>: > --- > dlls/windowscodecs/pngformat.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c > b/dlls/windowscodecs/pngformat.c > index 22b37b0..5af680e 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -1320,13 +1320,13 @@ HRESULT PngEncoder_CreateInstance(IUnknown > *pUnkOuter, REFIID iid, void** ppv) > > HRESULT PngDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to load PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to load PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > HRESULT PngEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to save PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to save PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > -- > 1.5.6.3 > > > > > >

1 0

Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in
by jgilik＠ucla.edu March 17, 2010

March 17, 2010

Alright--I'll update and resubmit when I get home from work. The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead. Should I be worried about that submission guideline? ------Original Message------ From: Dan Kegel Sender: daniel.r.kegel(a)gmail.com To: wine-devel(a)winehq.org Cc: John Gilik Subject: Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in Sent: Mar 16, 2010 5:51 PM Each patch in a series must compile and pass all tests, so if you need shlwapi for patch 1, then you have to include it in patch 1 (and then you just have one patch, not a series).

2 1

Re: winemp3.acm: support mp3 decoding on Mac OS/X systems
by Alexandre Julliard March 17, 2010

March 17, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > uses CoreAudio's AudioConverter, AudioFile and AudioFileStream. > uses prefered systems for either (Snow) Leopard or Tiger deciding at > runtime. I don't think we have to care about Tiger compatibility here, especially since it involves so much extra code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline
by Alexandre Julliard March 17, 2010

March 17, 2010

Clemens Fruhwirth <clemens(a)endorphin.org> writes: > @@ -3090,8 +3090,10 @@ typedef struct tagCBTACTIVATESTRUCT > #define FE_FONTSMOOTHINGCLEARTYPE 0x0002 > #define FE_FONTSMOOTHINGDOCKING 0x8000 > > -#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > -#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > +#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONVBGR 0x0002 > +#define FE_FONTSMOOTHINGORIENTATIONVRGB 0x0003 These don't seem to exist in the PSDK. Where do they come from? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: 2/3 wined3d: add a helper function for drawing a textured quad
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 14:53, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch introduces a helper function for drawing a textured quad. A > future patch will also make use of it for the quad drawing part of > 'offscreen surface -> render target' in BltOverride (actually that > part will become two functions later on: one for color keying to be > called from Blt/BltFast and one without any color keying) > The idea of making this a separate function is probably ok, but that function has more GL state dependencies than just locking and context activation, and also invalidates some GL states. Ultimately drawing a quad is something that should be internal to a blitter implementation. A shader based blitter for example wouldn't have to invalidate lots of fixed function state because it simply replaces those parts of the GL pipeline. A FBO blit based implementation doesn't have to draw a quad at all. Perhaps this is an acceptable step in that direction, but it's probably a good idea to think about what the blitter interface should look like first. Also, const correctness.

1 0

Re: cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens March 17, 2010

March 17, 2010

On 03/17/2010 02:10 PM, Jacek Caban wrote: > --- > programs/cmd/tests/batch.c | 39 ++++++++++++++++++++++++----- > programs/cmd/tests/test_builtins.cmd.exp | 2 +- > 2 files changed, 33 insertions(+), 8 deletions(-) > > Hi Jacek, Wasn't this test removed (for NT4 btw)? -- Cheers, Paul.

2 1

Re: [PATCH] cmd: removed %CD% test.
by Austin English March 17, 2010

March 17, 2010

On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud <yann(a)droneaud.fr> wrote: > %CD% seems not supported on Windows NT 4. > > The patch which introduce this test was based on MSDN documentation > and only tested on Windows XP Instead of removing it, perhaps the cmd test framework needs to understand the broken() macro... -- -Austin

3 2

Re: [PATCH 09/13] shdocvw: Added more navigation tests.
by Paul Vriens March 17, 2010

March 17, 2010

On 03/13/2010 04:44 PM, Jacek Caban wrote: > --- > dlls/shdocvw/tests/webbrowser.c | 293 > +++++++++++++++++++++++++++++---------- > 1 files changed, 218 insertions(+), 75 deletions(-) > Hi Jacek, This one has introduced several test failures on a variety of platforms (or IE versions): http://test.winehq.org/data/tests/shdocvw:webbrowser.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH] d3dx9_36: Add stub for D3DXCreateTextureFromFileInMemoryE
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:21, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + FIXME("(%p, %p, %d, %d, %d, %d, %x, %x, %x, %d, %d, %x, %p, %p, %p): stub\n", device, srcdata, srcdatasize, width, > + height, miplevels, usage, format, pool, filter, mipfilter, colorkey, srcinfo, palette, texture); Those integers are all unsigned.

1 0

Re: [PATCH 2/3] d3dx9_36: Add missing GetSamplerIndex method to ID3DXConstantTable
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->lpVtbl->GetConstantDesc(p,a) > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->GetConstantDesc(p,a) Looks wrong.

1 0

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXConstantTableImpl_GetDesc + tests (try 2)
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +error: > + > + if (object) > + HeapFree(GetProcessHeap(), 0, object->ctab); > + HeapFree(GetProcessHeap(), 0, object); "object" should never be NULL, all jumps to "error" are after the NULL check.

1 0

Re: usbd.sys: add usbd.sys (try 4)
by Alexandre Julliard March 17, 2010

March 17, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * usbd.sys: add usbd.sys > > Try 4 is the shortest possible patch. > > Copyright assigned to both me and Alexandre Morozov, since his patch > is the basis of this one. The proper way to assign credit is not by adding copyright lines in the source, but by making sure every commit is credited to the right author. If a patch was not written by you it needs a From: line specifying the real author, and preferably it needs to be submitted by the original author himself. -- Alexandre Julliard julliard(a)winehq.org

2 1