March 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 01/11] ws2_32: use ntstatus in overlapped functions (try 3)
by Alexandre Julliard March 22, 2010

March 22, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > Make get_sock_events return error codes in unix format. Also some > style fixes. Sorry for the fuss over this :) The server should not be returning errno values directly. It should return NT status codes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/8] [Include]: added a wine/dwarf.h to share dwarf2 debug information data where needed
by Alexandre Julliard March 22, 2010

March 22, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > A+ > --- > > dlls/dbghelp/dwarf.c | 2 > dlls/dbghelp/dwarf.h | 420 ---------------------------------------- > dlls/ntdll/signal_x86_64.c | 207 -------------------- > include/wine/dwarf.h | 465 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 467 insertions(+), 627 deletions(-) > delete mode 100644 dlls/dbghelp/dwarf.h > create mode 100644 include/wine/dwarf.h I don't think we need a Wine global header for this. It's OK to keep it in dbghelp and copy only the few necessary defines in ntdll. That's even more true for the unwind info. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: makefiles: Use the standard C_SRCS variable as the list of test files
by Ilya Basin March 22, 2010

March 22, 2010

Looks like after this commit: http://source.winehq.org/git/wine.git/?a=commit;h=6164ce2d820546ae5b26eb504… the command ./tools/winapi/msvcmaker --no-wine silently fails: only 'winetest.dsp' created

1 0

Re: shell32: Add IPersistFile::GetCurFile implementation for IShellLink
by Paul Vriens March 21, 2010

March 21, 2010

On 03/18/2010 10:55 PM, Nikolay Sivov wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=19627 from 1.2 list. > Hi Nikolay, This introduces some test failures on Win9x (not WinMe) and NT4 in the shlexec tests. Could you agree with the attached patch? -- Cheers, Paul.

2 1

Re: winegcc: Link with msvcrt on windows because of __wargv
by James McKenzie March 21, 2010

March 21, 2010

Alexandre Goujon wrote: > --- > tools/winegcc/winegcc.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index c2e7876..a929214 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -555,6 +555,10 @@ static const char *mingw_unicode_hack( struct options *opts ) > { > char *main_stub = get_temp_file( opts->output_name, ".c" ); > > + /* we need to link with msvcrt because of __wargv */ > + if (!opts->use_msvcrt) > + opts->use_msvcrt = 1; > + > create_file( main_stub, 0644, > "#include <stdlib.h>\n" > "extern int wmain(int,wchar_t**);\n" > Please use [try 2] for any second send. Keeps things in order and lets others know that you have responded to errors. Also, put comments in the same message as the patch they apply to at the top of the message. Thank you. James McKenzie

2 2

Wanted: Summer of Code Mentors
by Maarten Lankhorst March 20, 2010

March 20, 2010

Hi all, Any contributing wine members wishing to mentor for summer of code, or help out with ranking proposals, please sign up as mentor for wine at http://socghop.appspot.com/gsoc Of course if you want to apply as student, you can't be a mentor. More feedback on the proposals is appreciated as well. :) Cheers, Maarten

2 1

Re: FIXME: shader trailing '\n's.
by Henri Verbeet March 20, 2010

March 20, 2010

On 20 March 2010 15:27, Francois Gouget <fgouget(a)free.fr> wrote: > On Sat, 20 Mar 2010, Francois Gouget wrote: > >> --- >> dlls/wined3d/shader.c | 132 ++++++++++++++++++++++++------------------------ >> 1 files changed, 66 insertions(+), 66 deletions(-) > > Argh! > > Ignore this one. I need to check it out and did not mean to send it > (hence the FIXME). > I didn't check all of them, but the majority of those are intentional. There are probably nicer ways to trace the D3D shader assembly though.

1 0

Re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays
by Alexandre Julliard March 20, 2010

March 20, 2010

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Both FADF_HAVEVARTYPE and FADF_RECORD both store information at > negative 4 in the safearray, and ODBC(native MDAC) can attempt to copy > an array with both of these flags set. A test case would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]
by Piotr Caban March 20, 2010

March 20, 2010

Hi, You forgot to attach changes to configure.ac. Regards, Piotr

2 1

winetricks bug?
by Igor Zakharoff March 20, 2010

March 20, 2010

Hi. I am using WINE 1.1.40 on Arch Linux. When I run winetricks (version 20100317) and try to install anything from the list I get the error ------------------------------------------------------ winepath -u C:\Program Files "" returned empty string ------------------------------------------------------ $ ls -l /home/igor/.wine/drive_c/ итого 16 drwxr-xr-x 4 igor users 4096 Мар 19 23:06 Program Files drwxr-xr-x 4 igor users 4096 Мар 19 23:06 users drwxr-xr-x 10 igor users 4096 Мар 19 23:06 windows drwxr-xr-x 2 igor users 4096 Мар 19 23:06 winetrickstmp I've tried removing ~/.wine directory but it doesn't help.

2 1

Re: Updated game checklist - columns now sortable
by Dan Kegel March 20, 2010

March 20, 2010

On Thu, Mar 18, 2010 at 10:31 PM, Edward Savage <epssyis(a)gmail.com> wrote: > I would think a logical extension to this sort of work would be a > triage list of important bugs and regressions to be dealt with in > quick order. Well... that's kind of what bugzilla and the appdb are for. > I'm raising this as it seems very few gamers who use wine seem to > report bugs or do regression tests. At most they seem to report that > there is a problem on the forums or on the app page comments and leave > it at that. Yeah, historically, a few people (me included) have spent time watching the forums for that kind of report, and turned them into real bug reports. > If there was a centralised method of telling other gamers who are > prepared to do tests and reports that there is a specific problem with > xyz games it may improve the quality of information bug fixers have to > work with and get problems sorted out in a timely fashion. I suppose a way to make it really easy to test one's favorite set of games on the latest wine (as well as on any earlier release), and just click a big red 'Regression' button the moment one found one, might help. > Games are probably the biggest single application instance usage of > wine so having a specific case for this genre of application make > sense to me. Agreed. > As another suggestion I'd be prepared to write a WWN style monthly > report on the state of games running in wine. Including which ones no > longer work, what new ones work, and what major efforts need to be > undertaken for new games to work. I did a journalism elective last > semester so it probably wouldn't suck as bad as my last attempt at > writing a WWN. I would assume it would be totally independent of WWN > releases. Nah, just add it in to WWN, no reason to do anything separate. Start small! Just write a little section in http://wiki.winehq.org/RecentNewsQueue Heck, it is about time for another WWN, isn't it? - Dan [resending to list with permission]

1 0

Re: [PATCH 4/7] [Include]: created a wine only unwind.h include file for CPU specific unwind information
by Charles Davis March 19, 2010

March 19, 2010

On 3/19/10 3:02 PM, Eric Pouech wrote: > > (and maps the definition to what MSDN states as field names) > > A+ > --- > > dlls/ntdll/signal_x86_64.c | 144 ++++++++++++++++++-------------------------- > 1 files changed, 58 insertions(+), 86 deletions(-) You forgot unwind.h. Chip

1 0

Re: [PATCH 1/2] d3d8/tests: Add some message processing to test_wndproc().
by Alexandre Julliard March 19, 2010

March 19, 2010

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/d3d8/tests/device.c | 22 ++++++++++++++++++---- > 1 files changed, 18 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok device.c:1616: Test failed: Expected focus 0x60100, got (nil). device.c:1618: Test failed: Expected foreground window 0x60100, got (nil). make[1]: *** [device.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

GSoC proposal: Implement the Explorer
by David Hedberg March 19, 2010

March 19, 2010

Hi everyone, I too thought I'd see what my current thinking might be worth and therefore submit what you might call a rough (and perhaps somewhat too short) draft of my current "main proposal" for your tearing-apart pleasure. This is based on the idea with the same name available on the wine wiki, and is I guess sent to get some feedback on whether it would be considered useful and worthy of further refinement or not. ---------------------- Proposal for GSoC 2010: Implement the Explorer ---- The proposal is, in short, to implement the Windows Explorer as a replacement (or a complement) to winefile to browse the shell namespace, and also as an easily accessed test bed for the wine implementation of the windows shell components. It will also as a design decision involve implementing the new IExplorerBrowser interface available since Windows Vista which allows applications to host the explorer ( [1], [2] ). If there is time available after this I would also like to make explorer able to optionally show the task bar and start menu as noted in the wiki entry for GSoC ( [3] ) and in an enhancement request on wine bugzilla ( [4] ) . Very Rough Design Description: ---- This would, logically at least, involve mainly two parts: An implementation of IExplorerBrowser and IShellBrowser that uses the current implementation of the shell in wine, and an Explorer.exe that would be able to host IExplorerBrowser objects, interact with them and possibly handle showing the task bar and start menu. This should all be done in a way that is as compatible as possible with currently available shell extensions for the Explorer like custom toolbars, desk bands, and the like. If a choice have to made regarding what version of the Explorer to be compatible with, the current thought is to prefer the design decisions of the latter windows versions. For example, in Windows 7 (and Vista I assume), the explorer folder bar (showing the folder hierarchy) is replaced by a "navigation pane" that is available to all applications hosting the explorer through the IExplorerBrowser interface. As users of IExplorerBrowser would conceivably expect this pane to be available, making this a part of IExplorerBrowser would seem to make sense. Main goals --- * A functional implementation of explorer that can browse the shell namespace and be used for both file management tasks and manual testing of features of the wine shell implementation. * A working implementation of IExplorerBrowser. * Compatibility with shell extensions where it makes sense. Secondary goals ---- * An optional start menu/taskbar mode, mainly for use when running wine in virtual desktop mode. * Chances are that implementing the Explorer will turn up bugs in the wine shell implementation. Some of these bugs might hinder the main goal of implementing the Explorer in which case they would need to be investigated and fixed, and I suggest that those bugs (if any) that are not show-stoppers should be documented and - if there is time after finishing the main goals - investigated and (hopefully) fixed. Thoughts on the User Interface ---- The primary concern when it comes to the UI is that it should be functional. It would be loosely modeled after the Explorer in Windows, especially where needed for compatibility reasons (e.g. the navigation pane), but there might also be room for wine-specific features, look and behavior. On this point, it would perhaps make sense to seek some comments from other "heavy" explorer users and/or wine users. Quick summary of steps suggested ---- 1. Implement a simple initial container for IExplorerBrowser (explorer.exe) with basic support for navigating. Make sure it works with native IExplorerBrowser in windows Vista/7, and also write tests for the interface (if possible). 2. Implement IExplorerBrowser (and other necessary interfaces), test with new explorer.exe from step 1. 3. Refine explorer.exe as needed Optional: 4. Give explorer the ability to show the task bar/start menu, and/or 5. Fix bugs in the wine shell components found during the course of development. References: [1]. http://msdn.microsoft.com/en-us/library/bb761909(VS.85).aspx [2]. http://www.codeproject.com/KB/vista/ExplorerBrowser.aspx [3]. http://wiki.winehq.org/SummerOfCode#head-18241c95194e4e1c597bd2923cf296084f… [4]. http://bugs.winehq.org/show_bug.cgi?id=11629 ------------ Some notes and questions: In the above I am assuming that the Explorer and Internet Explorer should be regarded as separate applications as that seems to be the current state of affairs in the windows world. Is this assumption correct? I can also note that I am guessing (from visual inspection alone) that Vista/Win 7 uses IExplorerBrowser to implement IFileDialog (one of the GSoC ideas on the wiki). I might be wrong though, and I guess that it either way strictly speaking is an implementation detail that doesn't really matter to wine. Any thoughts, comments or questions on the above are very welcome. :-) I'm also idling in #winehackers with the nick sk atteola. Thanks, David Hedberg

1 0

Kernel mode tests?
by Damjan Jovanovic March 19, 2010

March 19, 2010

Hi We've already got ntoskrnl.exe, hal.dll, mountmgr.sys and usbd.sys, with at least usbhub.sys hopefully coming soon, and I've been thinking it's a good idea to have some regressions tests for these. The problem, of course, is that on Windows these all run in kernel mode. So what would be a good way to structure these regression tests? We could cross-compile each test to a .sys file, install and load that, call it from user-space to run the tests, then unload and uninstall. This would work, but has the problem that a lot of complexity is necessary to set up the tests (driver signing, administrator access, UAC, etc.), and any bugs that would crash a user-space application would now crash Windows instead (we all know how easy that is :-). Another possibility might be to use a custom program loader to load the Windows .sys file being tested into user-space, the way we do now on Wine, and test it like that. This seems to preclude us from testing ntoskrnl.exe and hal.dll though. Any thoughts/ideas/suggestions? Thank you Damjan Jovanovic

3 2

Re: [PATCH 2/2] d3d9/tests: Add some message processing to test_wndproc().
by Henri Verbeet March 19, 2010

March 19, 2010

On 19 March 2010 14:33, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > For some reason Windows XP allows device creation to be blocked by the lack of > message processing in wndproc_thread(). Also, many thanks to Wylda for helping debug this.

1 0

GSoC '10 Project Proposal: Buildbot Automated Testing System
by Arjun Comar March 19, 2010

March 19, 2010

Hey all, I wanted to run my proposal for GSoC by everybody for some feedback and commentary, especially since student apps start in just 10 days. Any advice is greatly appreciated. GSoC 2010 Proposal: Buildbot Automated Testing System For those who aren't aware, http://buildbot.net/ provides an automated testing suite. I propose to set up a Buildbot system for Wine, using both a periodic scheduler, and a try scheduler. I also intend to create an easy configuration scheme that should keep maintenance fairly simple. In addition the test suite should be modular and easily extensible, ideally building on AppInstall and the existing test suite, as well as providing a means for new tests to be hooked in. --Buildbot-- To keep from seeming pedantic, I'll be brief with this one. Automating testing suites are awesome and help keep down the number of bugs/regressions that pop up. It'd be really cool if Wine had something like this. --Schedulers-- The periodic scheduler's purpose is to run the full test suite at particular time intervals. The timing on this one would need to be decided by the project. For example, it could be set up to run the full test suite half a week or so prior to the bi-weekly releases, or perhaps once a night if people care to read the logs that often. The try scheduler serves a slightly different purpose, namely to test on a patch by patch basis. Initially, this means that the patch would have to be directly uploaded to the test machine, though perhaps integration with patchwatcher may be possible (though I'm told that patchwatcher is fragile at best). Naturally, the full gamut of tests is probably not required for every single patch, and so a more selective (and fast) subset of the test suite can be run on the codebase after each patch, perhaps as limited as a compilation check. --Configuration-- Currently, one of the downsides of buildbot is that setup and configuration is all done by editing a python script that initializes all the various variables. This is clunky and adds a dependency to the person maintaining the system. Since the configuration script is full python, configuration can be moved out to a simple sh file (like most other Linux programs), and parsing done in the current configuration script. --Test Suite-- I would like to break apart the test suite into several, modular, components that can then be strung together in some order for a particular test run. Naturally, I intend to take advantage of the current test suite, and make use of AppInstall, integrating the two together to provide a comprehensive test suite. The conformance tests are also something that could potentially be included. Tying into the previous section, I'd also like to make it easy to attach new tests / test suites as people come up with new and better ways to stress test various things. This is the portion that may wind up being too much for a single person to do over the summer, though I doubt it. Buildbot appears to have decent support for this kind of thing, so it may just be wrestling it into doing what we need. Also, I should have a sample buildbot system ready to showcase soon. I'm currently testing it on a machine other than mine, but due to time constraints this weekend, I probably won't be able to send it out until early next week. Thanks for taking the time to read this. Once again, any advice is greatly appreciated. If you'd like any more detail or information, feel free to ask. It's entirely possible I forgot to include something. I look forward to working with all of you in the months to come. -- Arjun Comar, Rose-Hulman '12

5 7

ANGLE: wined3d in reverse?
by Dan Kegel March 19, 2010

March 19, 2010

http://blog.chromium.org/2010/03/introducing-angle-project.html "We're happy to announce a new open source project called Almost Native Graphics Layer Engine, or ANGLE for short. The goal of ANGLE is to layer WebGL's subset of the OpenGL ES 2.0 API over DirectX 9.0c API calls. We're open-sourcing ANGLE under the BSD license as an early work-in-progress, but when complete, it will enable browsers like Google Chrome to run WebGL content on Windows computers without having to rely on OpenGL drivers. Current browser implementations of WebGL need to be able to issue graphics commands to desktop OpenGL to render content. This requirement isn't a problem on computers running OS X or Linux, where OpenGL is the primary 3D API and therefore enjoys solid support. On Windows, however, most graphics-intensive apps use Microsoft Direct3D APIs instead of OpenGL, so OpenGL drivers are not always available. Unfortunately, this situation means that even if they have powerful graphics hardware, many Windows machines can't render WebGL content because they don't have the necessary OpenGL drivers installed. ANGLE will allow Windows users to run WebGL content without having to find and install new drivers for their system. Because ANGLE aims to implement most of the OpenGL ES 2.0 API, the project may also be useful for developers who are working on applications for mobile and embedded devices. ANGLE should make it simpler to prototype these applications on Windows, and also gives developers new options for deploying production versions of their code to the desktop. We hope that other WebGL implementors and others in the graphics community will join us to make ANGLE successful! For more info on ANGLE and to access the code repository, visit the new project on Google Code or join our discussion group." So, it'd be interesting to see if it runs on Wine. I love stacking them blocks as high as I can :-)

3 2

Re: [PATCH 03/10] d3d9/tests: Extend the window proc / focus window tests.
by Paul Vriens March 19, 2010

March 19, 2010

On 03/17/2010 09:59 PM, Henri Verbeet wrote: > --- > dlls/d3d9/tests/device.c | 103 +++++++++++++++++++++++++++++++++++++++------ > 1 files changed, 89 insertions(+), 14 deletions(-) > Hi Henry, These new tests (and also the d3d8 ones) introduce some timeouts on boxes. Mostly real boxes btw. Could you have a look? -- Cheers, Paul.

2 2

Re: [PATCH 1/2] d3dx9: Add d3dx9effect.h include file
by Henri Verbeet March 19, 2010

March 19, 2010

On 17 March 2010 12:21, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > +typedef struct _D3DXPASS_DESC { > + LPCSTR Name; > + UINT Annotations; > + DWORD VSVersion; > + DWORD PSVersion; > + UINT VSSemanticsUsed; > + D3DXSEMANTIC VSSemantics[MAXD3DDECLLENGTH]; > + UINT PSSemanticsUsed; > + D3DXSEMANTIC PSSemantics[MAXD3DDECLLENGTH]; > + UINT PSSamplersUsed; > + LPCSTR PSSamplers[16]; > +} D3DXPASS_DESC; Which version of the SDK is this supposed to match? It doesn't match mine or MSDN. > +#define ID3DXBaseEffect_GetDesc(p,a) (p)->GetDesc(p,a) ... > +#define ID3DXBaseEffect_SetArrayRange(p,a,b,c) (p)->SetArrayRange(p,a,b,c) Those don't like right for C++. The other interfaces have similar issues, including: > +#define ID3DXEffect_CommitChanges() (p)->lpVtbl->CommitChanges(p) and > +#define ID3DXEffect_GetVertexShader(p,a,b) (p)->>GetVertexShader(p,a,b) However, my SDK doesn't have C object macros for any of the interfaces in d3dx9effect.h.

2 3

Re: midimap: Allow GetVolume by device identifier
by Paul Vriens March 19, 2010

March 19, 2010

On 03/19/2010 10:52 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > this patch does not include a work-around for Paul Vriens' real XP box > which returns INVALPARAM for both variants of midiOutGetVolume on > the Creative driver. I'd like to sample test.winehq first to see how > common this error is first. > Paul, did you isolate the exact reason for the BSOD on winme? Not yet. That BSOD was only in the CALLBACK_FUNCTION case (not the current default in the tests). -- Cheers, Paul.

1 0

Updated game checklist - columns now sortable
by Dan Kegel March 19, 2010

March 19, 2010

Austin and I updated the pages http://kegel.com/wine/good-games.html http://kegel.com/wine/bad-games.html As before, they list the games from the last ten or so years with the highest gamerankings.com scores, along with their appdb scores. The games with platinum or gold are considered 'good', and the games with any lower appdb ratings are considered 'bad'. Clicking on a column title now sorts the table by that column. We also added 1999 to the list, and added a bunch of games that were previously missing. According to this count, the top 570 or so games since 1999, Wine handles 227 well, and 237 poorly. http://kegel.com/wine/missing-games.html is the list of games we haven't been able to put into one of the above two pages yet. Mostly this is because they're expansion packs, and my script can't handle that yet, but some of them *simply don't have appdb entries* (gasp). (Slightly) more at http://wiki.winehq.org/GameChecklist - Dan

2 1

Re: [PATCH] attrib.exe: Add stubbed command
by Detlef Riekenberg March 18, 2010

March 18, 2010

On Mi, 2010-03-17 at 12:22 +0100, Christian Costa wrote: > + printf("attrib.exe is currently only a stub command\n"); > + printf("cmdline:"); UNICODE would be better, even for a stub. -- By by ... Detlef

3 4

Re: winegcc: Link with msvcrt on windows because of __wargv
by Austin English March 18, 2010

March 18, 2010

On Thu, Mar 18, 2010 at 9:21 AM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > --- > tools/winegcc/winegcc.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index c2e7876..a929214 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -555,6 +555,10 @@ static const char *mingw_unicode_hack( struct options *opts ) > { > char *main_stub = get_temp_file( opts->output_name, ".c" ); > > + //we need to link with msvcrt because of __wargv > + if (!opts->use_msvcrt) > + opts->use_msvcrt = 1; > + > create_file( main_stub, 0644, > "#include <stdlib.h>\n" > "extern int wmain(int,wchar_t**);\n" > -- > 1.6.3.3 Please avoid C++ comments, use /* comments */ instead. -- -Austin

1 0

Summer of code 2010 -- wine accepted as organization
by Maarten Lankhorst March 18, 2010

March 18, 2010

Topic says it all, Here's to an awesome start of summer of code 2010 for wine! Let the proposals begin! Cheers, Maarten

1 0

Re: [PATCH 2/5] oleaut32/tests: Make tests working on older systems, prevent crash on some wine boxes
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 10:05 PM, Piotr Caban wrote: > hres = ICreateTypeInfo_AddRefTypeInfo(createti, unknown,&hreftype); > ok(hres == S_OK, "got %08x\n", hres); > + if(hres != S_OK) { > + skip("Skipping some tests\n"); > + return; > + } Hi Piotr, If it's acceptable to get something else besides S_OK you should change the ok() and add a broken() (still bail out of course). A skip() usually means that something valid happened and we need to bail out. -- Cheers, Paul.

3 7

lstrcmpW on Windows ignores some special unicode characters
by Paul Vriens March 18, 2010

March 18, 2010

Hi, I already mentioned this in my last shlwapi patch. lstrcmpW (and CompareStringW for that matter) ignore some special unicode characters like 0x200e (and also loads of others). Do we care? I.o.w. is there a need for implementing this? I only tested these characters at the start of the strings btw. -- Cheers, Paul.

2 1

Re: [1/3] winex11: Add implementation of Triangle Inequality Nearest Neighbour algorithm.
by Paul Vriens March 18, 2010

March 18, 2010

On 03/18/2010 09:57 AM, Vitaly Budovski wrote: > /* > - Some of the following helper functions are duplicated in > +_ Somf of the following helper functions are duplicated in > dlls/gdi/dib.c > */ Hi Vitaly, I can't comment on the rest of the code but this piece doesn't look like it's intended. -- Cheers, Paul.

1 0

New winetricks 20100316: new verbs steam, adobeair, 7zip, d3dxof, win7
by Dan Kegel March 18, 2010

March 18, 2010

Today's winetricks was brought to you by the letters W and S, and the number 7. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel Don't detect desktop environment, detect individual programs. Make warnings more obvious on console. flash: updated gecko: updated ie6: improved prerequisite checking psdkwin7: requires native gdiplus for the moment, so make that a prerequisite for now psdkwin7: some important registry keys (kludge) steam: added win7: added Austin English Don't consider missing cabextract fatal, unless it's actually being used Don't use cabextract directly, use the wrapper for all uses (issue 95) Use a more sane path for C:. Patch from 'arielco'. Issue 96. adobeair: add to winetrickstest, add missing decorations dotnet20: Check for mscorlib.dll rather than l_intl.nls icodec: remove, it's no longer online mpc: Update Andrew Nguyen Suppress STDERR messages from which command 7zip: added adobeair: added d3dxof: added msxml4/msxml6: add override before installing vc2005trial: Use 7-zip to extract the UDF image rather than mounting it (so we can avoid sudo/root) Pavel Zinin directx9: update to February 2010 version

1 1

re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays
by Dan Kegel March 18, 2010

March 18, 2010

Can you write a test for that?

1 0

Re: cmd: Add skeleton ping command (try 2)
by Alexandre Julliard March 18, 2010

March 18, 2010

Trey Hunner <treyhunner(a)gmail.com> writes: > +int main(int argc, char** argv) > +{ > + int n = 0; > + int optc; > + > + while ((optc = getopt( argc, argv, "n:w:" )) != -1) > + { > + switch(optc) > + { > + case 'n': > + n = atoi( optarg ); > + break; > + case '?': > + usage(); > + exit(1); > + } > + } You should at least print a FIXME for other options that it's supposed to support, instead of silently succeeding and doing nothing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 04:21 PM, Ilya Basin wrote: > @@ -1013,7 +1011,7 @@ static void test_filename(void) > "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); > } > - else todo_wine > + else > { > ok(rc==test->rc, "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); Hi Ilya, If this is no longer a todo_wine you should change the filename_tests struct: /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x1, 33}, to /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x0, 33}, You can even consider removing the "if ((test->todo & 0x1)==0)" as now there are no more of those tests. On the one hand it's nice to have these todo constructs, removing them however is a greater incentive to get the implementation right ;) -- Cheers, Paul.

3 2

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride
by Henri Verbeet March 18, 2010

March 18, 2010

On 17 March 2010 14:48, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This first patch disables hardware accelerated 8-bit blitting. This > code will completely use the shader backend later on and won't require > hacks like 'paletteOverride'. > I'm not sure breaking things is the right approach?

3 3

Measuring game FPS in wine/windows?
by Austin English March 18, 2010

March 18, 2010

Howdy, I've been testing some games lately on Windows/Wine, and wanted to see the difference in framerates. On windows, I've been using Fraps, which works decently well, but not under wine (and it doesn't work for Assassin's creed). I found D3DGears online, which supposedly works for Assassin's creed on Windows (haven't checked), but doesn't work under wine. Does anyone know of a standalone application that works under wine? Thanks! -Austin

3 2

Re: [1/3] winex11: Add implementation of Triangle Inequality Nearest Neighbour algorithm.
by Roderick Colenbrander March 18, 2010

March 18, 2010

Hi Vitaly, In case of Age of Empires the performance is certainly affected by the DIB code. As you have seen, right now we perform all rendering (except when XRender is around but that's typically for >8-bit) at the depth of the Xserver and perform conversions back and forth. Alexandre mentioned some time that we should avoid doing these conversions altogether (they caused issues at <8-bit but I don't remember him saying what the issues were) and that instead we should provide X11 with 8-bit data if we are dealing with 8-bit data. I guess that's how he wants this to continue but I have no idea how easy it is to change all this. Roderick On Thu, Mar 18, 2010 at 9:57 AM, Vitaly Budovski <> wrote: > This will allow faster palette lookups for 8 bit palettes. > > This may come up in a reply, so I'll address it now. Float must be used > since an int doesn't provide enough range for the numbers we are dealing > with. > > > >

1 0

Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens March 18, 2010

March 18, 2010

On 03/17/2010 02:22 PM, Jacek Caban wrote: > --- a/programs/cmd/tests/test_builtins.cmd.exp > +++ b/programs/cmd/tests/test_builtins.cmd.exp > @@ -16,6 +16,7 @@ bar > ~dp0 should be directory containing batch file > @pwd@\ > @pwd@\ > +(a)pwd@@or_broken(a)ECHO is off. Won't this fail on non English locales? In this case it will only fail on non English NT4 boxes, but still. -- Cheers, Paul.

2 1

Winsock event patches - review and test please
by Mike Kaplinskiy March 18, 2010

March 18, 2010

Hello all, I've been working on fixing some of the winsock event handling issues in wine, so I'm looking for someone to give these patches a review and test them on some apps that use that kind of stuff, i.e. apps that call WSAEventSelect or WSAAsyncSelect. I'm not quite certain on the portability of all the code, so if anyone on a non-linux-2.6 can give the tests a run that would be great. The tests pass on windows ignoring failure after line 3259 (the tests below are wine-specific). Thanks, Mike.

1 0

Re: [1/2] urlmon: Add stub IUriBuilder interface (try2)
by Nikolay Sivov March 18, 2010

March 18, 2010

On 3/18/2010 04:16, Nikolay Sivov wrote: > I know comdlg32 doesn't seem to be very close to urlmon, but stub I added shows a problems in included headers order. > SetPort method from IUriBuilder collides with SetPort define from winspool.h and a build error comes up saying I'm using > unprefixed call (without A or W). > Hm, next conflict is in programs/clock. Chain is windows.h -> ole2.h -> objbase.h -> urlmon.h In windows.h there's include winspool.h before ole2.h, and this causes conflict. Not sure how to fix it now, any comments are welcome. > Second patch should apply cleanly. >

1 0

Re: Small spelling fixes.
by Vincent Povirk March 17, 2010

March 17, 2010

Thanks for sending a patch for this. It seems it was not committed, probably because your mailer added line-breaks, making it difficult to apply. Could you resend as an attachment, or without the line breaks if you can configure your mailer to do that? Or, if you prefer, I can send this with fixed formatting on your behalf. 2010/3/12 Julian Rüger <jr98(a)gmx.net>: > --- > dlls/windowscodecs/pngformat.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c > b/dlls/windowscodecs/pngformat.c > index 22b37b0..5af680e 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -1320,13 +1320,13 @@ HRESULT PngEncoder_CreateInstance(IUnknown > *pUnkOuter, REFIID iid, void** ppv) > > HRESULT PngDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to load PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to load PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > HRESULT PngEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to save PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to save PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > -- > 1.5.6.3 > > > > > >

1 0

Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in
by jgilik＠ucla.edu March 17, 2010

March 17, 2010

Alright--I'll update and resubmit when I get home from work. The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead. Should I be worried about that submission guideline? ------Original Message------ From: Dan Kegel Sender: daniel.r.kegel(a)gmail.com To: wine-devel(a)winehq.org Cc: John Gilik Subject: Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in Sent: Mar 16, 2010 5:51 PM Each patch in a series must compile and pass all tests, so if you need shlwapi for patch 1, then you have to include it in patch 1 (and then you just have one patch, not a series).

2 1

Re: winemp3.acm: support mp3 decoding on Mac OS/X systems
by Alexandre Julliard March 17, 2010

March 17, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > uses CoreAudio's AudioConverter, AudioFile and AudioFileStream. > uses prefered systems for either (Snow) Leopard or Tiger deciding at > runtime. I don't think we have to care about Tiger compatibility here, especially since it involves so much extra code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline
by Alexandre Julliard March 17, 2010

March 17, 2010

Clemens Fruhwirth <clemens(a)endorphin.org> writes: > @@ -3090,8 +3090,10 @@ typedef struct tagCBTACTIVATESTRUCT > #define FE_FONTSMOOTHINGCLEARTYPE 0x0002 > #define FE_FONTSMOOTHINGDOCKING 0x8000 > > -#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > -#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > +#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONVBGR 0x0002 > +#define FE_FONTSMOOTHINGORIENTATIONVRGB 0x0003 These don't seem to exist in the PSDK. Where do they come from? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: 2/3 wined3d: add a helper function for drawing a textured quad
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 14:53, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch introduces a helper function for drawing a textured quad. A > future patch will also make use of it for the quad drawing part of > 'offscreen surface -> render target' in BltOverride (actually that > part will become two functions later on: one for color keying to be > called from Blt/BltFast and one without any color keying) > The idea of making this a separate function is probably ok, but that function has more GL state dependencies than just locking and context activation, and also invalidates some GL states. Ultimately drawing a quad is something that should be internal to a blitter implementation. A shader based blitter for example wouldn't have to invalidate lots of fixed function state because it simply replaces those parts of the GL pipeline. A FBO blit based implementation doesn't have to draw a quad at all. Perhaps this is an acceptable step in that direction, but it's probably a good idea to think about what the blitter interface should look like first. Also, const correctness.

1 0

Re: cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens March 17, 2010

March 17, 2010

On 03/17/2010 02:10 PM, Jacek Caban wrote: > --- > programs/cmd/tests/batch.c | 39 ++++++++++++++++++++++++----- > programs/cmd/tests/test_builtins.cmd.exp | 2 +- > 2 files changed, 33 insertions(+), 8 deletions(-) > > Hi Jacek, Wasn't this test removed (for NT4 btw)? -- Cheers, Paul.

2 1

Re: [PATCH] cmd: removed %CD% test.
by Austin English March 17, 2010

March 17, 2010

On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud <yann(a)droneaud.fr> wrote: > %CD% seems not supported on Windows NT 4. > > The patch which introduce this test was based on MSDN documentation > and only tested on Windows XP Instead of removing it, perhaps the cmd test framework needs to understand the broken() macro... -- -Austin

3 2

Re: [PATCH 09/13] shdocvw: Added more navigation tests.
by Paul Vriens March 17, 2010

March 17, 2010

On 03/13/2010 04:44 PM, Jacek Caban wrote: > --- > dlls/shdocvw/tests/webbrowser.c | 293 > +++++++++++++++++++++++++++++---------- > 1 files changed, 218 insertions(+), 75 deletions(-) > Hi Jacek, This one has introduced several test failures on a variety of platforms (or IE versions): http://test.winehq.org/data/tests/shdocvw:webbrowser.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH] d3dx9_36: Add stub for D3DXCreateTextureFromFileInMemoryE
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:21, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + FIXME("(%p, %p, %d, %d, %d, %d, %x, %x, %x, %d, %d, %x, %p, %p, %p): stub\n", device, srcdata, srcdatasize, width, > + height, miplevels, usage, format, pool, filter, mipfilter, colorkey, srcinfo, palette, texture); Those integers are all unsigned.

1 0

Re: [PATCH 2/3] d3dx9_36: Add missing GetSamplerIndex method to ID3DXConstantTable
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->lpVtbl->GetConstantDesc(p,a) > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->GetConstantDesc(p,a) Looks wrong.

1 0

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXConstantTableImpl_GetDesc + tests (try 2)
by Henri Verbeet March 17, 2010

March 17, 2010

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +error: > + > + if (object) > + HeapFree(GetProcessHeap(), 0, object->ctab); > + HeapFree(GetProcessHeap(), 0, object); "object" should never be NULL, all jumps to "error" are after the NULL check.

1 0

Re: usbd.sys: add usbd.sys (try 4)
by Alexandre Julliard March 17, 2010

March 17, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * usbd.sys: add usbd.sys > > Try 4 is the shortest possible patch. > > Copyright assigned to both me and Alexandre Morozov, since his patch > is the basis of this one. The proper way to assign credit is not by adding copyright lines in the source, but by making sure every commit is credited to the right author. If a patch was not written by you it needs a From: line specifying the real author, and preferably it needs to be submitted by the original author himself. -- Alexandre Julliard julliard(a)winehq.org

2 1