March 2010 - Wine-Devel - list.winehq.org

Change Journal and VSS analog in Wine
by Dmitry Konnov March 3, 2010

March 3, 2010

Hi All, I'm doing backup software. Can somebody advise on weather Wine has functionality of ChangeJournal NTFS and Shadow Copy mechanism. I understand that ChangeJournal NTFS is NTFS file system feature and Shadow Copy perhaps heavily dependent on Windows system. But I wonder weather these features can be simulated on Mac under Wine/Crossover. Please advise. -- Faithfully yours, Dmitry Konnov mailto:konnov_d(a)mail.ru

2 1

Re: [PATCH 1/2] kernel32/tests: Add a test case for calling TlsFree on a freed index.
by Nikolay Sivov March 2, 2010

March 2, 2010

On 3/2/2010 23:04, Reece Dunn wrote: > Hi, > > TlsFree should return FALSE if there wasn't a TLS slot of the > specified index allocated, as well as returning > ERROR_INVALID_PARAMETER. > > - Reece > > - ok(TlsFree(tlsIndex)!=0,"TlsFree failed\n"); > + ok(TlsFree(tlsIndex)!=0,"TlsFree failed: %08x\n", GetLastError()); > + /* Test freeing an already freed TLS index */ > + ok(TlsFree(tlsIndex)==0,"TlsFree succeeded\n"); > + ok(GetLastError()==ERROR_INVALID_PARAMETER, > + "GetLastError: expected ERROR_INVALID_PARAMETER, got %08x\n", GetLastError()); > You need reset last error to something before test.

1 0

Re: oleaut32: Add a VT_INT_PTR case for VARIANT_UserSize
by Alexandre Julliard March 2, 2010

March 2, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -239,6 +239,8 @@ static unsigned int get_type_size(ULONG *pFlags, VARTYPE vt) > case VT_DISPATCH: > case VT_RECORD: > return 0; > + case VT_INT_PTR: > + return sizeof(INT_PTR); This won't do the right thing on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: Improve Cygwin compatibility
by John Klehm March 2, 2010

March 2, 2010

On Mon, Mar 1, 2010 at 2:39 PM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > /* > * __ A bit off topic __ > * > * Replying "You need to give your real name in addition to the patch." > * > * I hope this time all's ok. > * You now know who I am but I think it shouldn't be mandatory. > * I'm not here to become famous. > * "For a better world" and 'cause I love what I do. > * > */ > > Whatever, this patch should (finally) makes ./configure script work as expected. > > My understanding is that the real names are required so Wine can legally prove where all it's code came. This way it's provable that no code is from someone that mightve been influenced by MS code. Regards, --John Klehm

1 0

Re: [PATCH 2/5] wined3d: refactoring - add a real gl vendor detection
by Henri Verbeet March 2, 2010

March 2, 2010

On 1 March 2010 19:27, PAUL ANDREW PANON <ppanon(a)shaw.ca> wrote: > + gl_vendor = wined3d_guess_gl_vendor(gl_info, gl_string, gl_renderer); > card_vendor = wined3d_guess_card_vendor(gl_string, gl_renderer); > - TRACE_(d3d_caps)("found GL_VENDOR (%s)->(0x%04x)\n", debugstr_a(gl_string), card_vendor); > + TRACE_(d3d_caps)("found GL_VENDOR (%s)->(0x%04x/0x%04x)\n", debugstr_a(gl_string), gl_vendor, card_vendor); Sorry for not noticing this earlier, but you can't do that there. The Apple detection uses the list of supported extensions, but that list isn't initialized until further below. If there's no code that depends on the gl_vendor before, you can probably just move it down a bit to the same place that calls wined3d_guess_card(), possibly moving wined3d_guess_card_vendor() as well.

1 0

Re: [PATCH] ole32: fix composite moniker behaviour.
by Alexandre Julliard March 2, 2010

March 2, 2010

Reece Dunn <msclrhd(a)googlemail.com> writes: > @@ -365,8 +365,7 @@ CompositeMonikerImpl_BindToObject(IMoniker* iface, IBindCtx* pbc, > /* if the requested class was loaded before ! we don't need to reload it */ > res = IRunningObjectTable_GetObject(prot,iface,(IUnknown**)ppvResult); > > - if (res==S_OK) > - return res; > + return res==S_OK ? S_OK : E_INVALIDARG; This doesn't look right. Just because the test wants E_INVALIDARG doesn't mean it's the correct error for all possible failures. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msvcrt: Add more exports as stubs (alphabetic sorted) [try 2]
by Alexandre Julliard March 2, 2010

March 2, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > stubs, which are used in the cpp tests are now commented out In general the others should be commented out too, for the same reason. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3dxof: Turn some TRACEs into WARNs in case of parsing error
by Paul Vriens March 2, 2010

March 2, 2010

On 03/02/2010 08:37 AM, Christian Costa wrote: > > --- > > dlls/d3dxof/d3dxof.c | 8 ++++---- I guess you only meant to sent this piece in this email? > dlls/wined3d/shader.c | 22 +++++++++++++++++++++- > 2 files changed, 25 insertions(+), 5 deletions(-) -- Cheers, Paul.

2 1

Re: [PATCH] wined3d: Display correctly TEXT comments by printing lines separately
by Henri Verbeet March 2, 2010

March 2, 2010

On 1 March 2010 09:39, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > Still not quite right, I'm afraid. For example, the following doesn't work: > + while (i < size) > + { > + /* Find end of line */ > + while ((str[i] != 0) && (str[i] != 0x0a)) > + i++; How does something like the attached patch work (untested)?

2 3

Re: shdocvw: return success code in ITaskBarList::HrInit
by Henri Verbeet March 1, 2010

March 1, 2010

On 1 March 2010 21:20, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > - FIXME("iface %p stub!\n", iface); > - > - return E_NOTIMPL; > + return S_OK; I think you'll want to at least keep a TRACE.

1 0

Re: [PATCH 3/3] d3dx9_36: Find, store and enable retreival of CTAB comment data in shader (based on code from Luis Busquets)
by Henri Verbeet March 1, 2010

March 1, 2010

On 1 March 2010 09:39, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + object->ctab = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); ... > + object->size = size; > + memcpy(object->ctab, data, object->size); The HEAP_ZERO_MEMORY flag is pretty useless here.

1 0

Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff
by Chris Robinson March 1, 2010

March 1, 2010

On Sunday 28 February 2010 1:13:44 pm Marcus Meissner wrote: > Hi, > > Copy in the mpg123.h header from the library so we do not need it for > building. (it is also LPGL) > > Dynamically link from libmpg123.so.0. > (Chances are very good that ABI stays stable.) > > This allows me providing a MP3 capable Wine build for openSUSE without > actually having libmpg123 in the openSUSE buildservice for building. > > > I was not able to test it though, anyone have a working winemp3.acm > using testcase :( This won't work, unfortunately. The mpg123.h header does some evil macro hacks to forward certain functions (eg. mpg123_seek, mpg123_feedseek) to 64-bit variants when _FILE_OFFSET_BITS is 64 due to using off_t. The functions the lib has depends on whether it was built with _FILE_OFFSET_BITS=64 or not, and the macros won't affect the strings passed to wine_dlsym. It also looks like the lib isn't unloaded with the acm.

2 2

Re: ntdll: use SIGSTKSZ in sigaltstack instead of depending on size_t
by Austin English March 1, 2010

March 1, 2010

On Sun, Feb 28, 2010 at 7:04 PM, Austin English <austinenglish(a)gmail.com> wrote: > OpenBSD complains about this, giving 'sigaltstack: invalid argument' > on every run (4 times). This cuts out 3 of them. Still chasing down > the last one... > > Tested on Linux as well, and google seems to indicate this should work > on the BSD's and Solaris, so should be pretty portable. > > If an #ifdef is preferred, please let me know and I'll resend. Please ignore this patch. Seems the failures are sporadic, so I'm not sure this is helping. -- -Austin

1 0