March 2010 - Wine-Devel - list.winehq.org

Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames.
by Paul Vriens March 14, 2010

March 14, 2010

On 03/13/2010 05:19 PM, Andrew Nguyen wrote: > + /* Test the conditions in which the output buffer can be modified. */ > + lstrcpyW(container, testW); > + hr = IDxDiagContainer_EnumChildContainerNames(pddc, 0, container, 0); > + ok(hr == E_INVALIDARG, > + "Expected IDxDiagContainer::EnumChildContainerNames to return E_INVALIDARG, got 0x%08x\n", hr); > + ok(!lstrcmpW(container, testW), > + "Expected the container buffer to be untouched, got %s\n", wine_dbgstr_w(container)); Hi Andrew, This won't work on Win9x/WinMe as most of these W-functions are not available. lstrcpyW will fail and I don't know what that would mean for the Enum-call (with an unitialized 'container'). lstrcmpW will always return 0 on Win9x/WinMe and thus these tests will always succeed. There is a generic winetest_strcmpW now btw (include/wine/test.h) -- Cheers, Paul.

3 4

Wiki - 3D driver issues
by Roderick Colenbrander March 14, 2010

March 14, 2010

Hi, Multiple times a day you encounter people who can't get 3D working in Wine. I'm getting so sick of these questions, that I decided to start a new page on the Wiki. http://wiki.winehq.org/3DDriverIssues Feel free to add more information to it. I don't want it to give detailed instructions on how to install drivers but more a page which gives hints on what is wrong and which points people in the right direction to solve the problems. In case there is a distribution specific issue like LIBGL_DRIVERS_PATH on Ubuntu, such a thing could be described there in short. Roderick

4 5

Re: [Try 2] WCMD_run_program overflow fix
by James McKenzie March 14, 2010

March 14, 2010

Eric Ho wrote: > Sorry Ive accidentally attached the patch for the expected test > outputs in the first patch, please replace the previous 1/4 and 4/4 > patch with these new ones, thanks > -Eric > ------------------------------------------------------------------------ > > Eric: Please resend the entire patchset marking patches 1/4 and 4/4 as [Try 2] and 2/4 and 3/4 as [resend]. AJ will just reject your patches as they are now. James McKenzie

1 0

Re: usbd.sys: add usbd.sys (try 2)
by André Hentschel March 13, 2010

March 13, 2010

> + * Copyright (C) 2010 Damjan Jovanovic > + * Copyright (C) 2009 Alexander Morozov Hi Damjan, I would rotate theese lines to be ordered by Year like: > + * Copyright (C) 2009 Alexander Morozov > + * Copyright (C) 2010 Damjan Jovanovic -- Best Regards, André Hentschel

3 2

Re: windowscodecs: Make component enumerators thread-safe.
by Vincent Povirk March 13, 2010

March 13, 2010

I'm told I need to unset DebugInfo->Spare[0] before deleting the critical section. Which makes this wrong. On Sat, Mar 13, 2010 at 12:37 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: [1/2] usbd.sys: add usbd.sys to configure.ac
by Nikolay Sivov March 13, 2010

March 13, 2010

On 3/13/2010 15:28, Damjan Jovanovic wrote: > Changelog: > * usbd.sys: add usbd.sys to configure.ac > > Damjan Jovanovic > That makes no sense to separate this from next patch.

1 0

Re: wineaudiofile.acm: Initial commit
by Henri Verbeet March 13, 2010

March 13, 2010

Not claiming to know a whole lot about OS X or audio, but these are some general things I noticed: On 12 March 2010 16:41, Aric Stewart <aric(a)codeweavers.com> wrote: > +/* leopad functions */ Typo. > +static tAudioFileStreamOpen pAudioFileStreamOpen = NULL; > +static tAudioFileStreamSeek pAudioFileStreamSeek = NULL; > +static tAudioFileStreamParseBytes pAudioFileStreamParseBytes = NULL; > +static tAudioFileStreamClose pAudioFileStreamClose = NULL; Explicitly initializing these to NULL is superfluous. > +typedef struct > +{ > + int nChannels; > + int nBits; > + int rate; > +} Format; You have some stray tabs (not just here). > + TRACE("ndst %i %p <- %i %p\n",*ndst,dst,*nsrc, src); *ndst and *nsrc are unsigned. > + ERR("Feed Error %c%c%c%c\n", (char) (ret>> 24), > + (char) (ret>> 16), > + (char) (ret>> 8), > + (char) ret); debugstr_an((const char *)&ret, 4); may be easier / nicer. > +OSStatus Mp3AudioConverterComplexInputDataProc ( > +void Mp3PropertyListenerProc ( void *inClientData, void* inAudioFileStream, > +void Mp3PacketsProc ( These should probably be static.

3 2

Re: oleaut32: Return type mismatch errors in ITypeLibComp_fnBind.
by Nikolay Sivov March 12, 2010

March 12, 2010

On 3/12/2010 23:56, Vincent Povirk wrote: > ITypeLibImpl *This = impl_from_ITypeComp(iface); > ITypeInfoImpl *pTypeInfo; > + int typemismatch=0; > Do you really need this one? Looks like it's enough to move hr at top level and use it.

2 1

mciavi: Prevent deadlock when closing while playing or when paused.
by Joerg-Cyril.Hoehle＠t-systems.com March 12, 2010

March 12, 2010

Hi, Maarten Lankhorst wrote: >Using a winmm timer there would remove the >need for that thread altogether Please explain the idea. >as part of my sound rewrite I will write a new winmm driver My understanding is that there will be a new winmm, but all MCI* drivers operate on top of that and are not changed. Thus the question still remains what "Quality of Implementation" to implement there w.r.t. multiple threads sending MCI commands to the same device: - ignore the issue; - make each device/unit robust against concurrent use; - make only MCI_Close robust; - ...? This can perhaps be considered independently on the same questions w.r.t. winmm:midi/waveXyz functions. The winmm MUST deal with concurrency IMHO because of the callback practice. There's nothing like this in the MCI. Regards, Jörg Höhle.

2 1

Re: [PATCH] msvcr80: Add msvcr80.dll with forwards to msvcrt.dll
by Paul Chitescu March 12, 2010

March 12, 2010

On Friday 12 March 2010 04:52:53 pm Detlef Riekenberg wrote: > Installing VC2008 runtime is no longer needed > for some apps. > > [...] Which applications are you talking about? All applications I've seen that use MSVCR80 or MSVCR90 need a proper assembly install (with manifest and possibly policy) to resolve version dependencies.

1 0