March 2010 - Wine-Devel - list.winehq.org

i7 920 not quite twice as fast as Q9300 at building wine
by Dan Kegel March 24, 2010

March 24, 2010

Not as exciting an improvement as I'd hoped: 4 GB RAM Intel(R) Core(TM)2 Quad CPU Q9300 @ 2.50GHz make -j5 real 7m35.985s user 24m54.741s sys 3m15.628s 6 GB RAM model name : Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz make -j9 real 4m39.577s user 30m43.651s sys 2m30.109s

2 3

Re: crypt32: Don't dereference a potentially NULL pointer without checking it (Coverity)
by Alexandre Julliard March 24, 2010

March 24, 2010

Juan Lang <juan.lang(a)gmail.com> writes: > Fixes Coverity ids 1046 and 1047. Thanks to Paul Vriens for bringing > it to my attention. Setting sep to an empty string would probably make the whole thing a lot cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/8] msvcrt: Update msvcrt.spec (try3)
by Alexandre Julliard March 24, 2010

March 24, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -826,3 +826,579 @@ > @ cdecl wctomb(ptr long) MSVCRT_wctomb > @ varargs wprintf(wstr) MSVCRT_wprintf > @ varargs wscanf(wstr) MSVCRT_wscanf > +@ stub ??0bad_cast@@AAE(a)PBQBD@Z > +@ stub ??0bad_cast@@QAE(a)PBD@Z > +@ stub ??0exception@@QAE(a)ABQBDH@Z The added functions should be properly sorted with the rest of the spec file, and they should be commented out. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add some multimedia defines not present in win9x.
by Dmitry Timoshkov March 24, 2010

March 24, 2010

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > +#define MOD_WAVETABLE 6 /* hardware watetable internal synth */ A typo? -- Dmitry.

1 0

steam regressed?
by Dan Kegel March 24, 2010

March 24, 2010

Hmm. I can't start steam anymore. This worked until quite recently...?

5 7

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition
by Paul Vriens March 23, 2010

March 23, 2010

On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: > + > + bret = GetOverlappedResult((HANDLE)dest,&ov,&bytesReturned, FALSE); > + todo_wine ok(!bret&& GetLastError() == ERROR_NETNAME_DELETED, "Did not get disconnect event: %d, error %d\n", bret, GetLastError()); Hi Mike, This one fails on Win98 and WinMe with what appears just a different last error: http://test.winehq.org/data/tests/ws2_32:sock.html Could you have a look? Maybe it also makes sense to add a SetLastError(0xdeadbeef) before the actual call as we are testing the last error afterwards. That way we are sure that the last error is indeed set to the expected. -- Cheers, Paul.

2 1

Re: [PATCH 4/5] mmdevapi: Use OpenAL for finding devices
by Chris Robinson March 23, 2010

March 23, 2010

FWIW, you can query ALC_DEFAULT_ALL_DEVICES_SPECIFIER (with ENUMERATE_ALL), ALC_DEFAULT_DEVICE_SPECIFIER (standard playback), and ALC_CAPTURE_DEVICE_SPECIFIER (record) to get the default device as seen by OpenAL, instead of taking the first as the default. Just make sure to query the default after the device list, since querying the device list can invoke a re-probing of available devices/backends.

1 0

Re: includes: Add private alext header for OpenAL
by Chris Robinson March 23, 2010

March 23, 2010

It may be a good idea to remove the experimental extensions from the file: AL_EXT_buffer_sub_data AL_EXT_sample_buffer_object ALC_EXT_thread_local_context until they're finalized. I'm hoping ALC_EXT_thread_local_context will be done in time for OpenAL Soft 1.12, but there could still be changes to it (namely, changing a function name).

1 0

Re: [1/2] wdm.h: fix IoGetCurrentIrpStackLocation
by Alexandre Julliard March 23, 2010

March 23, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -1021,7 +1021,7 @@ typedef enum _MM_SYSTEM_SIZE > > NTSTATUS WINAPI ObCloseHandle(IN HANDLE handle); > > -#define IoGetCurrentIrpStackLocation(_Irp) ((_Irp)->Tail.Overlay.CurrentStackLocation) > +#define IoGetCurrentIrpStackLocation(_Irp) ((_Irp)->Tail.Overlay.s.u2.CurrentStackLocation) This would have to depend on the NONAMELESSUNION etc defines. -- Alexandre Julliard julliard(a)winehq.org

1 0

msvcrt and co.
by André Hentschel March 23, 2010

March 23, 2010

Hi Folks, We have actually some dlls like msvcr80 that forward to msvcrt or msvcr90. The question is, should we test these forwarding dlls for the case they behave different? If yes, how? We would have to cherrypick the tests from e.g. msvcrt which tests those functions... -- Best Regards, André Hentschel

1 0