June 2010 - Wine-Devel - list.winehq.org

wordpad: Remove untranslated resources from the Chinese translation.
by Dylan Smith June 23, 2010

June 23, 2010

--- programs/wordpad/Zh.rc | 24 ------------------------ 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a/programs/wordpad/Zh.rc b/programs/wordpad/Zh.rc index 135f00c..bae40a7 100644 --- a/programs/wordpad/Zh.rc +++ b/programs/wordpad/Zh.rc @@ -111,30 +111,6 @@ BEGIN END END -IDM_COLOR_POPUP MENU DISCARDABLE -BEGIN - POPUP "" - BEGIN - MENUITEM "Black", ID_COLOR_BLACK - MENUITEM "Maroon", ID_COLOR_MAROON - MENUITEM "Green", ID_COLOR_GREEN - MENUITEM "Olive" ID_COLOR_OLIVE - MENUITEM "Navy" ID_COLOR_NAVY - MENUITEM "Purple" ID_COLOR_PURPLE - MENUITEM "Teal" ID_COLOR_TEAL - MENUITEM "Gray" ID_COLOR_GRAY - MENUITEM "Silver" ID_COLOR_SILVER - MENUITEM "Red" ID_COLOR_RED - MENUITEM "Lime" ID_COLOR_LIME - MENUITEM "Yellow" ID_COLOR_YELLOW - MENUITEM "Blue" ID_COLOR_BLUE - MENUITEM "Fuchsia" ID_COLOR_FUCHSIA - MENUITEM "Aqua" ID_COLOR_AQUA - MENUITEM "White" ID_COLOR_WHITE - MENUITEM "Automatic" ID_COLOR_AUTOMATIC - END -END - IDD_DATETIME DIALOG DISCARDABLE 30, 20, 130, 80 STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "日期和时间" -- 1.7.0.4

2 1

Re: oledlg: Add the Romanian translation.
by Alexandru Băluț June 23, 2010

June 23, 2010

2010/6/23 Michael Stefaniuc <mstefani(a)redhat.com>: > + CONTROL "Creează un nou",IDC_CREATENEW,"Button",BS_AUTORADIOBUTTON | > + WS_GROUP,7,20,67,10 "Creează nou" seems better, the original is "Create New", not "Create a New". I don't really get what "Create New" is supposed to mean, or what is the difference between the "Create New" and "Create Control", since for both you press the same button "Add Control...", so both actually create a Control. I might be wrong. > + PUSHBUTTON "&Adăugare control...",IDC_ADDCONTROL,81,88,67,14,NOT WS_VISIBLE This is a button, "&Adaugă [...]" seems more appropriate. "&Adaugă un control" would be consistent with "Creează un control" which is used for a radio button. > +CAPTION "Paste Special" It should say "Inserare specială", to be consistent with: > + CONTROL "I&nserează", IDC_PS_PASTE, "Button", BS_AUTORADIOBUTTON | WS_TABSTOP | WS_GROUP | WS_VISIBLE, > + CONTROL "Inserează &linkul", IDC_PS_PASTELINK, "Button", BS_AUTORADIOBUTTON | WS_VISIBLE, Is "Inserează &legătura" wrong? > + IDS_PS_PASTE_DATA "Inserează conținutul din clipboard în document ca %s." > + IDS_PS_PASTE_OBJECT "Inserează conținutul din clipboard în document astfel încât să îl puteți activa utilizând %s." > + IDS_PS_PASTE_OBJECT_AS_ICON "Inserează conținutul din clipboard în document astfel încât să îl puteți activa utilizând %s. Va fi afișat ca o pictogramă." > + IDS_PS_PASTE_LINK_DATA "Inserează conținutul din clipboard în document ca %s. Datele sunt legate de fișierul sursă, astfel încât modificările aduse fișierului vor fi reflectate în document." > + IDS_PS_PASTE_LINK_OBJECT "Inserați o imagine a conținutului din clipboard în document. Imaginea este legată de fișierul sursă, astfel încât modificările aduse fișierului vor fi reflectate în document." > + IDS_PS_PASTE_LINK_OBJECT_AS_ICON "Inserați o scurtătură care conduce la locația conținutului din clipboard. Scurtătura este legată de fișierul sursă, astfel încât modificările aduse fișierului vor fi reflectate în document." > + IDS_PS_NON_OLE "Inserează conținutul din clipboard în document." All the English messages for these start with "Inserts [...]" - We should be consistent, and use "Inserează [...]" for all of them. Thanks, Alex

2 2

Re: [PATCH] user32: check for valid pointer in CURSORICON_CreateIconFromBMI
by Alexandre Julliard June 23, 2010

June 23, 2010

Wolfram Sang <wolfram(a)the-dreams.de> writes: > @@ -884,6 +884,10 @@ static HICON CURSORICON_CreateIconFromBMI( BITMAPINFO *bmi, > return 0; > } > > + /* A few Windows versions crash getting NULL, but most simply return it */ > + if (!bmi) > + return 0; That's not the right place for it, this is an internal function. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Porting WIne to D
by Stephen Eilert June 23, 2010

June 23, 2010

On Wed, Jun 23, 2010 at 3:06 PM, Christopher Selph <cds.wine(a)gmail.com> wrote: > Well, being a garbage collected language, it would help with the memory > leaks in Wine. Being OOP it could extend the design of the code to make it > cleaner and reusable. The assertions above are opinions, not facts. Also, it requires a full rewrite. Wine Initial release(per Wikipedia): 4 July 1993 Good luck. --Stephen Sent from my Emacs

2 1

Re: wordpad: Update Portuguese translation
by Gustavo June 23, 2010

June 23, 2010

Yes, that's what I did. I just tested wordpad with the wrong order and noticed that choosing to create a new file showed a window with blank entries, and when trying to open a file the drowpdown file type menu was also blank. In the right order everything worked. In other words, I introduced a bug in Portuguese Wine :/ Cheers, Gustavo. 2010/6/23 Paul Vriens <paul.vriens.wine(a)gmail.com> > On 06/23/2010 09:19 PM, Gustavo wrote: > >> I found out the problem. It was the order of the definition of strings >> that >> was wrong. Committing a new patch. >> > > you mean you did it now like in the En.rc file? Tried that but that's not > the issue, although it's probably better to have the same list as the > English one just for consistency. > > -- > Cheers, > > Paul. >

2 2

Re: wordpad: Update Portuguese translation
by Paul Vriens June 23, 2010

June 23, 2010

On 06/23/2010 03:12 PM, Gustavo wrote: > One more translation :) > This somehow messed up the stats: http://source.winehq.org/transl/resource.php?lang=016%3A02&resfile=programs… and http://source.winehq.org/transl/resource.php?lang=016%3A01&resfile=programs… It looks like we have two (sub)languages in one STRINGTABLE. Now, I'm not sure if that's allowed (I think it is because ResHacker doesn't have an issue with it) or if it's a wrc/transl bug/issue. -- Cheers, Paul.

2 1

Re: Add files generated by "make depend", PGO and gcov to .gitignore
by Peter Davies June 23, 2010

June 23, 2010

Does this mean that "make depend" should be removed from README and ./tools/wineinstall? It generates /conf* files. Peter

2 2

Re: msvcrt: Implement getenv_s and _wgetenv_s, forwards from msvcr80, 90 and 100
by Piotr Caban June 23, 2010

June 23, 2010

On 06/23/10 15:26, Paul Chitescu wrote: > /********************************************************************* > + * getenv_s - not exported in native msvcrt > + */ > +int CDECL getenv_s(size_t *size, char *buffer, size_t bufLen, const char *name Both getenv_s and _wgetenv_s are exported in native msvcrt. > + unsigned int len = strlen(var) + 1; > + *size = len; > + if (len > bufLen) > + return MSVCRT_ERANGE; If bufLen is set to 0 the function is used for obtaining output size. No ERANGE error is returned in this case. Cheers, Piotr

1 0

[PATCH 2/2] d3dx9: Add stub and basic test for D3DXCreateSphere.
by Misha Koshelev June 23, 2010

June 23, 2010

FYI, I am following the current definition of D3DXCreateBox, which is in the mesh.c file. If you think I should start a separate (shape.c) file for these functions, please let me know. Prior patch fixed an #include which should have been present in d3dx9.h Starting work on http://bugs.winehq.org/show_bug.cgi?id=22918 implementing D3DXCreateSphere Thank you Misha p.s. Actually I remember I used to be quite into game programming many years ago - "Tricks of the Game Programming Gurus", even wrote my own Mode X library at one point ;) - not 3D though --- dlls/d3dx9_36/d3dx9_36.spec | 2 +- dlls/d3dx9_36/mesh.c | 8 ++++++++ dlls/d3dx9_36/tests/mesh.c | 9 +++++++++ include/d3dx9shape.h | 7 +++++++ 4 files changed, 25 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/d3dx9_36.spec b/dlls/d3dx9_36/d3dx9_36.spec index 19406e7..b9a00da 100644 --- a/dlls/d3dx9_36/d3dx9_36.spec +++ b/dlls/d3dx9_36/d3dx9_36.spec @@ -87,7 +87,7 @@ @ stub D3DXCreateSkinInfo @ stub D3DXCreateSkinInfoFromBlendedMesh @ stub D3DXCreateSkinInfoFVF -@ stub D3DXCreateSphere +@ stdcall D3DXCreateSphere(ptr long long long ptr ptr) @ stdcall D3DXCreateSprite(ptr ptr) @ stub D3DXCreateTeapot @ stub D3DXCreateTextA diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index 9691eed..5611030 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -335,3 +335,11 @@ HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height return E_NOTIMPL; } + +HRESULT WINAPI D3DXCreateSphere(LPDIRECT3DDEVICE9 device, FLOAT radius, UINT slices, + UINT stacks, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) +{ + FIXME("(%p, %f, %d, %d, %p, %p): stub\n", device, radius, slices, stacks, mesh, adjacency); + + return E_NOTIMPL; +} diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c index 8e4e26d..0086bb3 100644 --- a/dlls/d3dx9_36/tests/mesh.c +++ b/dlls/d3dx9_36/tests/mesh.c @@ -476,6 +476,14 @@ static void D3DXIntersectTriTest(void) ok( got_res == exp_res, "Expected result = %d, got %d\n",exp_res,got_res); } +static void D3DXCreateSphereTest(void) +{ + HRESULT hr; + + hr = D3DXCreateSphere(NULL, 0.0, 0, 0, NULL, NULL); + todo_wine ok( hr == D3DERR_INVALIDCALL, "Got result %x, expected %x (D3D_INVALIDCALL)\n",hr,D3DERR_INVALIDCALL); +} + static void test_get_decl_vertex_size(void) { static const D3DVERTEXELEMENT9 declaration1[] = @@ -556,5 +564,6 @@ START_TEST(mesh) D3DXDeclaratorFromFVFTest(); D3DXGetFVFVertexSizeTest(); D3DXIntersectTriTest(); + D3DXCreateSphereTest(); test_get_decl_vertex_size(); } diff --git a/include/d3dx9shape.h b/include/d3dx9shape.h index e1bf231..36bca6b 100644 --- a/include/d3dx9shape.h +++ b/include/d3dx9shape.h @@ -32,6 +32,13 @@ HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency); +HRESULT WINAPI D3DXCreateSphere(LPDIRECT3DDEVICE9 device, + FLOAT radius, + UINT slices, + UINT stacks, + LPD3DXMESH* mesh, + LPD3DXBUFFER* adjacency); + #ifdef __cplusplus } #endif -- 1.7.1

3 5

Re: avifil32: Update Portuguese (Brazilian) translation
by Ricardo Filipe June 23, 2010

June 23, 2010

2010/6/23 Gustavo <gugamilare(a)gmail.com>: > Updated Brazilian Portuguese translation and changed codification of > resource file to UTF-8 > > > > hi gustavo! thanks for doing the .br translations, and fixing sizes i overlooked in the .pt translation. :) however, you need to add the following line to the beginning of the file when you change encoding to UTF-8: #pragma code_page(65001) there are several resources where you can see that example. keep up the good work, ricardo

2 1

Re: [PATCH] winedevice: Use 64-bit wide delta when relocating
by Dmitry Timoshkov June 23, 2010

June 23, 2010

Alessandro Pignotti <a.pignotti(a)sssup.it> wrote: > @@ -67,7 +67,8 @@ static HMODULE load_driver_module( const WCHAR *name ) > IMAGE_NT_HEADERS *nt; > const IMAGE_IMPORT_DESCRIPTOR *imports; > size_t page_size = getpagesize(); > - int i, delta; > + int i; > + intptr_t delta; You need to use SDK types, INT_PTR in this case. -- Dmitry.

1 0

Re: avifil32: Update Portuguese (Brazilian) translation
by Paul Vriens June 23, 2010

June 23, 2010

On 06/23/2010 04:28 PM, Gustavo wrote: > Updated Brazilian Portuguese translation and changed codification of > resource file to UTF-8 > Hi Gustavo, If you change the encoding to UTF-8 you also need to add a "#pragma code_page(65001)", otherwise we'll end up with compile warnings like: Warning: string "Opções de compressão" seems to be UTF-8 but codepage 1252 is in use. Same is true for your other patches where you change the encoding. -- Cheers, Paul.

1 0

Re: [PATCH 4/4] wined3d: use stretch_rect_fbo for swapchainless blits
by Henri Verbeet June 23, 2010

June 23, 2010

On 28 April 2010 14:29, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + /* Early sort out of cases where no render target is used */ > + if (!dstSwapchain && !srcSwapchain > + && src_surface != device->render_targets[0] > + && dst_surface != device->render_targets[0]) > + { > + if (fbo_blit_supported(&device->adapter->gl_info, BLIT_OP_BLIT, > + &src_rect, src_surface->resource.usage, src_surface->resource.pool, src_surface->resource.format_desc, > + &dst_rect, dst_surface->resource.usage, dst_surface->resource.pool, dst_surface->resource.format_desc)) > + { > + stretch_rect_fbo(device, src_surface, &src_rect, dst_surface, &dst_rect, Filter); > + return WINED3D_OK; > + } > + > + TRACE("No surface is render target, not using hardware blit.\n"); > + return WINED3DERR_INVALIDCALL; > + } > + You might as well try FBO blits first, before doing most of the other checks. That's how it's eventually supposed to work anyway, and you could remove the other strecth_rect_fbo() calls in that case. That does depend on fbo_blit_supported() working properly, of course.

2 4

Re: msvcrt/tests: Make test_dup2() static.
by testbot＠testbot.winehq.org June 23, 2010

June 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2829 Your paranoid android. === W98SE (32 bit file) === file.c:988: Test failed: smaller size block: Wrong error data () file.c:996: Test failed: smaller size block: Stdout file shouldn't contain data

2 1

Re: msvcr90/tests: Make test_invalid_parameter_handler() static.
by testbot＠testbot.winehq.org June 23, 2010

June 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2832 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === No test summary line found === W2K3R2SESP2 (32 bit msvcr90) === No test summary line found === WVISTAADM (32 bit msvcr90) === No test summary line found === W2K8SE (32 bit msvcr90) === No test summary line found

2 1

Re: shlwapi/tests: Make the XXX_Construct() functions static.
by testbot＠testbot.winehq.org June 23, 2010

June 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2830 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:593: Test failed: GetShellSecurityDescriptor should fail ordinal.c:616: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1759: Test failed: got 13 ordinal.c:1765: Test failed: got 28 ordinal.c:1780: Test failed: got 10 ordinal.c:1793: Test failed: got 13 ordinal.c:1801: Test failed: got 13 ordinal.c:1815: Test failed: got 28 ordinal.c:1823: Test failed: got 28 ordinal.c:1831: Test failed: got 40, length 41 ordinal.c:1842: Test failed: got 43 ordinal.c:1853: Test failed: got 23 === W7PROX64 (32 bit ordinal) === ordinal.c:1759: Test failed: got 9 ordinal.c:1765: Test failed: got 25 ordinal.c:1780: Test failed: got 6 ordinal.c:1793: Test failed: got 9 ordinal.c:1801: Test failed: got 9 ordinal.c:1815: Test failed: got 25 ordinal.c:1823: Test failed: got 25 ordinal.c:1853: Test failed: got 19 ordinal.c:1864: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1759: Test failed: got 9 ordinal.c:1765: Test failed: got 25 ordinal.c:1780: Test failed: got 6 ordinal.c:1793: Test failed: got 9 ordinal.c:1801: Test failed: got 9 ordinal.c:1815: Test failed: got 25 ordinal.c:1823: Test failed: got 25 ordinal.c:1853: Test failed: got 19 ordinal.c:1864: Test failed: got 22

2 1

Re: [PATCH 2/2] d3dx9: Add stub and basic test for D3DXCreateSphere.
by testbot＠testbot.winehq.org June 23, 2010

June 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2859 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msvfw32: Add the Romanian translation.
by Alexandru Băluț June 23, 2010

June 23, 2010

On Wed, Jun 23, 2010 at 01:14, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > + CONTROL "&Toate cadre cheie",887,"Button",BS_AUTOCHECKBOX|WS_TABSTOP,9,60,70,12 > + EDITTEXT 888,82,60,22,12 > + LTEXT "Cadre",889,106,62,22,10 This will look like "Toate cadre cheie X Cadre" and it does not make sense. The original message is "Key Frame Every X frames" - it could be translated as "Cadru cheie la fiecare X cadre". Thanks, Alex

2 1

Re: wined3d: Better validation of BltFast destination
by Stefan Dösinger June 23, 2010

June 23, 2010

Am Dienstag 22 Juni 2010 23:37:20 schrieb Iain Arnell: > --- a/dlls/wined3d/surface_base.c > +++ b/dlls/wined3d/surface_base.c > @@ -1657,6 +1657,11 @@ HRESULT WINAPI > IWineD3DBaseSurfaceImpl_BltFast(IWineD3DSurface *iface, DWORD dst > lock_dst.right = dstx + w; > lock_dst.bottom = dsty + h; > > + if ( lock_dst.left < 0 || lock_dst.top < 0 ) { > + WARN("Application gave us bad desitination offset for > BltFast.\n"); + return WINEDDERR_INVALIDRECT; > + } You're catching only the GDI surface case here since opengl surfaces don't use IWineD3DBaseSurfaceImpl_BltFast. I recommend to put this check into ddraw, like in your previous attempts(but keep checking for < 0, don't do any bit testing magic like in your old patches)

4 5

[PATCH] winedevice: Use 64-bit wide delta when relocating
by alex.pigna＠inventati.org June 23, 2010

June 23, 2010

Hi Everyone, when using Wine64 relocations should use 64-bit wide deltas, winedevice was not compliant with this. Patch follows Regards, Alessandro Pignotti --- programs/winedevice/device.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/programs/winedevice/device.c b/programs/winedevice/device.c index e0cd07b..1b5b87a 100644 --- a/programs/winedevice/device.c +++ b/programs/winedevice/device.c @@ -67,7 +67,8 @@ static HMODULE load_driver_module( const WCHAR *name ) IMAGE_NT_HEADERS *nt; const IMAGE_IMPORT_DESCRIPTOR *imports; size_t page_size = getpagesize(); - int i, delta; + int i; + intptr_t delta; ULONG size; HMODULE module = LoadLibraryW( name ); -- 1.7.1

2 1

Porting Applications
by Alistair Leslie-Hughes June 23, 2010

June 23, 2010

Hi, Check out this ability to debug your windows in WINE. Sparx Systems Enterprise Architect allows you to debug Windows applications under WINE. http://www.sparxsystems.com/support/faq/enterprise-architect-WINE.html#nine The limitations are you need to use the native dbghelp.dll. You need the PDB's of the application you want to debug, and the source if want to set breakpoints. Features 1. Allows debugging of a windows application. 2. Allows sampling (profiling) of you application. What it doesn't do 1. Allow Debugging of application you have the PDB's. 2. Assembly level debugging, all breakpoints are at the source level only. This feature has been extremely useful in working out issues with running Enterprise Architect in the WINE environment. Best Regards Alistair Leslie-Hughes

2 1

Re: shell32/tests: SHELL_ArgifyW(%2|%*|%~3, ...) tests
by testbot＠testbot.winehq.org June 22, 2010

June 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2839 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtA1D5.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtA1D5.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtA1D5.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtA1D5.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtA1D5.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

Re: Getting into the spirit of things... crosstest
by Misha Koshelev June 22, 2010

June 22, 2010

> On 6/22/2010 23:30, Misha Koshelev wrote: > > Dear All: > > > > As I am waiting for my wine GIT to compile, I have noticed that the > > following link no longer works: > > http://mirzam.it.vu.nl/mingw/ > > > > (from > > http://www.winehq.org/docs/winedev-guide/cross-compiling-tests > > for the MINGW WIN32API RPMS) > > > > I am running Ubuntu 10.04 and will first: > > i) try stock MINGW > > ii) then try to figure it out myself from sources if necessary > > > Page info is outdated probably. I don't have any problems with Debian 5 > package, as well as I didn't while was using Debian 4. > One problem I got was a libuuid a test was linked to. Now there's no > tests which import it, and newly added tests should go in without linking > to this lib. > > but if there are any other tips much appreciated. > > > > Thank you > > Misha > > > Thank you so much. Stock Ubuntu 10.04 amd64 mingw does indeed seem to be working! :) Misha p.s. :) misha(a)misha-d630:dpkg -l | grep mingw ii mingw32 4.2.1.dfsg-1ubuntu2 Minimalist GNU win32 (cross) compiler ii mingw32-binutils 2.20-0.1 Minimalist GNU win32 (cross) binutils ii mingw32-runtime 3.15.2-0ubuntu1 Minimalist GNU win32 (cross) runtime misha(a)misha-d630:~/src/wine/dlls/d3dx9_36$ uname -a Linux misha-d630 2.6.32-22-generic #36-Ubuntu SMP Thu Jun 3 19:31:57 UTC 2010 x86_64 GNU/Linux

1 0

Re: ddraw: Better validation of IDirectDrawSurface::BltFast parameters (2nd try)
by Iain Arnell June 22, 2010

June 22, 2010

On Sat, Jun 19, 2010 at 9:02 AM, Iain Arnell <iarnell(a)gmail.com> wrote: > fixes #23238 - Repton 3: crashes when viewing map. > --- > dlls/ddraw/surface.c | 6 ++++++ > dlls/ddraw/tests/dsurface.c | 4 ++++ > 2 files changed, 10 insertions(+), 0 deletions(-) Scratch this - after thinking again about Henri's hint, I've moved the fix to wined3d. -- Iain.

1 0

Getting into the spirit of things... crosstest
by Misha Koshelev June 22, 2010

June 22, 2010

Dear All: As I am waiting for my wine GIT to compile, I have noticed that the following link no longer works: http://mirzam.it.vu.nl/mingw/ (from http://www.winehq.org/docs/winedev-guide/cross-compiling-tests for the MINGW WIN32API RPMS) I am running Ubuntu 10.04 and will first: i) try stock MINGW ii) then try to figure it out myself from sources if necessary but if there are any other tips much appreciated. Thank you Misha

3 2

I'm back
by Misha Koshelev June 22, 2010

June 22, 2010

Dear All: Just wanted to let you know that after a long hiatus working on "big important" things, I now have time once again to contribute to the Wine project. I am going to have to take some time to get my feet wet, but the current plan, per suggestions of senior important Wine members :) is to work on DirectX and d3dx. Thus, I will focus on this. I look forward to our new and continued interactions. Misha Koshelev

2 2

Yagmark and localized Windows
by Francois Gouget June 22, 2010

June 22, 2010

I tested Yagmark on a Windows XP computer but I hit a snag with the 3dmark 2000 and 2001 tests: they hang on the 'Save As' dialog because on my French Windows XP it is called 'Enregistrer Sous'. I checked out the AutoHotKey documentation but they don't seem to have a way to deal with this. Having a gettext-like function in AHK with a built-in library of translations would have been nice. But maybe I am missing something. Is this something to handle outside AHK? Did it get solved somewhere else already? (appinstall?) Should we be using some other way of identifying these dialogs? Like some resource id or the id of a control it contains? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 1

Re: [hhctrl.ocx] Null pointer fix, new patch
by Andrew Nguyen June 22, 2010

June 22, 2010

On Tue, Jun 22, 2010 at 5:56 AM, Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle); > + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ? > info->pCHMInfo->defTitle : null); Perhaps I am missing something obvious, but isn't the new statement practically the same as the one you removed? Adding a conditional doesn't seem to change what strdupW receives, and thus what it ultimately returns. > - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic); > + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ? > info->pCHMInfo->defTopic : null); Same thing. Also, did you actually compile and test this patch? I would think that writing "null" wouldn't compile.

3 3

Re: winex11.drv: warn and return when UploadGlyph fails in X11DRV_XRender_ExtTextOut
by Alexandre Julliard June 22, 2010

June 22, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > commit 082bc5ccbcc35e2058f1a3cd5c52345edf760631 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Tue Jun 22 16:58:38 2010 +0900 > > winex11.drv: warn and return when UploadGlyph fails in X11DRV_XRender_ExtTextOut > > this prevents crashing later when we are assuming that all the glyphs in the string have been realized and have valid data. Missing glyphs should be replaced by the font default char or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Allow HTTPREQ_ReadFileEx read more then one data chunk
by Alexandre Julliard June 22, 2010

June 22, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > + read = 0; > + size = buffers->dwBufferLength; > + > + EnterCriticalSection( &req->read_section ); > + while(1) { > + res = HTTPREQ_Read(req, (char*)buffers->lpvBuffer+read, size-read, > + &buffers->dwBufferLength, !(flags & IRF_NO_WAIT)); > + if(res == ERROR_SUCCESS) > + read += buffers->dwBufferLength; > + else > + break; > + > + if(!req->read_chunked || read==size || req->dwContentLength!=req->dwContentRead > + || !req->dwContentLength || (req->gzip_stream && req->gzip_stream->end_of_data)) > + break; > + > + INTERNET_SendCallback(&req->hdr, req->hdr.dwContext, INTERNET_STATUS_RESPONSE_RECEIVED, > + &buffers->dwBufferLength, sizeof(buffers->dwBufferLength)); > + INTERNET_SendCallback(&req->hdr, req->hdr.dwContext, > + INTERNET_STATUS_RECEIVING_RESPONSE, NULL, 0); Calling the callbacks while holding the critical section is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ddraw: Grow indexbuffer as needed
by Henri Verbeet June 22, 2010

June 22, 2010

On 22 June 2010 09:15, Mikko Rasa <tdb(a)tdb.fi> wrote: > --- > dlls/ddraw/device.c | 27 ++++++++++++++++++++++++++- > 1 files changed, 26 insertions(+), 1 deletions(-) > This looks mostly ok, except for two things: - We'll probably want to grow the buffer by doubling the size until it's large enough (but be careful not to overflow the maximum value of an UINT) - The "child" pointer of "parent" will still be set to the old index buffer, so the relevant code in IDirect3DDeviceImpl_7_Release() / IParentImpl_Release() is going to try to release the old index buffer again.

1 0

damnit, X is crashing *every* time I run 3dmark2000
by Dan Kegel June 22, 2010

June 22, 2010

And always after test 17 of 20, I think. I updated to the latest nvidia driver supported by Ubuntu 10.04, no change. The crash persists even with WINEDEBUG=+d3d,+d3d7,+synchronous. I guess my next move is to drop 3dmark2000.

4 4

Re: winecfg: Update Portuguese translation
by Frédéric Delanoy June 22, 2010

June 22, 2010

2010/6/22 Gustavo <gugamilare(a)gmail.com> > Second try. > > Gustavo Henrique Milaré > gugamilare(a)gmail.com If you resend the same patch, append (resend), if it was changed, append (try N). Cf. http://wiki.winehq.org/SubmittingPatches#head-2753aa29adcd5dfc10a88d4370973… Frédéric Delanoy

1 0

Re: Patches for Hebrew and Arabic
by Austin English June 21, 2010

June 21, 2010

On Mon, Jun 21, 2010 at 4:00 PM, Yaron Shahrabani <sh.yaron(a)gmail.com> wrote: > > Yaron Shahrabani There's a few problems... A) Please send one patch per email. B) The patches are incorrect: 0002-Arabic-Patch.patch: --- programs/notepad/Makefile.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in index 6b1fcdd..a0598e7 100644 --- a/programs/notepad/Makefile.in +++ b/programs/notepad/Makefile.in @@ -24,7 +24,6 @@ RC_SRCS = \ Es.rc \ Fi.rc \ Fr.rc \ - He.rc Hu.rc \ It.rc \ Ja.rc \ -- 1.7.0.4 You're removing the Hebrew rc file, but nothing else. 0003-Hebrew-Patch.patch: --- programs/notepad/Makefile.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in index a0598e7..372390e 100644 --- a/programs/notepad/Makefile.in +++ b/programs/notepad/Makefile.in @@ -14,7 +14,6 @@ C_SRCS = \ main.c RC_SRCS = \ - Ar.rc \ Bg.rc \ Cs.rc \ Da.rc \ @@ -24,6 +23,7 @@ RC_SRCS = \ Es.rc \ Fi.rc \ Fr.rc \ + He.rc \ Hu.rc \ It.rc \ Ja.rc \ -- 1.7.0.4 You're adding Hebrew back and removing Arabic. Neither patch actually adds a translation. You probably forgot to use 'git add' to tell git to add the file in your commit. You should also use a more helpful commit message. For example: notepad: add Hebrew translation Thanks for helping Wine! -- -Austin

1 0

Re: kernel32: Fix test output
by testbot＠testbot.winehq.org June 21, 2010

June 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2813 Your paranoid android. === W7PRO (32 bit thread) === thread.c:443: Test failed: threadFunc2 did not exit during 100 ms === W7PROX64 (64 bit thread) === thread.c:1394: Test failed: Expected FPU control word 0x27f, got 0x37f.

1 0

Re: [APPDB] Updated test_appData
by Alexander Nicolaysen Sørnes June 21, 2010

June 21, 2010

Mandag 21. juni 2010 20.52.20 skrev Alexandru Băluț : > Updated test_appData, because using downloadurl objects does not work > anymore, because appData.listSubmittedBy() ignores queued downloadurls. > I also fixed a bug in url.php: after creating an Url, the create function > does not update the object properly. > Hello, It's great that you're submitting patches! You could split this patch in two, since it contains two separate changes. Also, I see that you're using GIT to generate the patches. Could you do that with 'git format-patch -o out' and send the files generated in out/? Alexander N. Sørnes

2 2

Fwd: Italian translation of Wine at 100%
by Luca Bennati June 21, 2010

June 21, 2010

---------- Forwarded message ---------- From: Luca Bennati <lucak3(a)gmail.com> Date: 2010/6/21 Subject: Re: Italian translation of Wine at 100% To: Paul Vriens <paul.vriens.wine(a)gmail.com> 2010/6/21 Paul Vriens <paul.vriens.wine(a)gmail.com> Hi, > > And another one at a 100% !!! > > Many thanks to Luca for his efforts to get us this far. > > -- > Cheers, > > Paul. > Having completed this target before 1.2 release, i'm very happy, but surely the best is that now it won't be as strenous to keep it up to date. :) good luck to all the others translators.

1 0

Italian translation of Wine at 100%
by Paul Vriens June 21, 2010

June 21, 2010

Hi, And another one at a 100% !!! Many thanks to Luca for his efforts to get us this far. -- Cheers, Paul.

1 0

Re: Richedit: Initial tests for EM_FINDWORDBREAK
by testbot＠testbot.winehq.org June 21, 2010

June 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2806 Your paranoid android. === W7PRO (32 bit editor) === editor.c:4696: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4714: Test failed: test paste: strcmp = 1 editor.c:4726: Test failed: test paste: strcmp = -1 editor.c:4756: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5971: Test failed: Cursor is at 0 instead of 4 editor.c:5977: Test failed: Cursor is at 0 instead of 9 editor.c:5983: Test failed: Cursor is at 0 instead of 4 editor.c:5997: Test failed: Cursor is at 8 instead of 9 editor.c:6005: Test failed: Cursor is at 11 instead of 9 editor.c:6016: Test failed: Cursor is at 0 instead of 8 editor.c:6041: Test failed: Cursor is at 0 instead of 8

2 1

Re: [2/2] kernel32/tests: add test for CT_TYPE1 of GetStringTypeW
by James McKenzie June 21, 2010

June 21, 2010

Aric Stewart wrote: > ------------------------------------------------------------------------ > > Aric: Where did you find the new values for C1_TYPE? James McKenzie

2 1

Re: ntdll: fix race in NtRead/WriteFile
by Eric Pouech June 21, 2010

June 21, 2010

why not simply setting send_completion to cvalue instead of TRUE, and remove the now unneeded test to cvalue ? - send_completion = TRUE; + send_completion = cvalue != 0; .... - if (send_completion && cvalue) .... + if (send_completion) .... A+ 2010/6/21 Andrey Turkin <andrey.turkin(a)gmail.com> > Long overdue patch to fix bug 11188 - make sure to send i/o completions > after all interactions with i/o status block are performed. > --- > dlls/ntdll/file.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) > > > > > -- -- Eric Pouech

1 0

Is the appData table still holding bug links?
by Alexandru Băluț June 21, 2010

June 21, 2010

Hi, I see the "type" column in the appData table is an enum('screenshot','url','bug','downloadurl'), and I noticed that when linking a bug to a Version, a row is added in the buglinks table, not in appData. Is it ok to change the type of that column to enum('screenshot','url','downloadurl') - or shall I add a comment and say that it's obsolete, and that buglinks should be used instead? Thanks, Alex

1 0

Speed/latency issues for development in a Wine environment
by Alan W. Irwin June 21, 2010

June 21, 2010

To introduce myself to this list, I am a complete Wine newbie with no Windows experience at all, but I do have years of experience developing software on Linux, and in the interests of testing that software on a free Windows platform, I have recently been using the combination of Windows native versions of MinGW and CMake to build and test applications and libraries under Wine. That is, I run a Windows version of cmake under wine to configure Makefiles followed by running a Windows version of MinGW make under Wine (which in turn runs MinGW gcc and other applications under Wine to build and test the software). So far this idea is going rather well, but I have run into some issues which I have been reporting on the wine-users mailing list. I find such preliminary discussion useful to help prepare a good bug report, but following a suggestion from Alexandre Julliard, I am moving the discussion of these issues here. Since at least some of you have already seen my posts on wine-users, I will only summarize the issues as I currently see them. The rest of this post concerns a slow software build issue I have discovered under Wine, and I will deal with a second issue in a later post. The issue is that Wine builds of software take roughly a factor of 5 longer than the equivalent Linux builds. This issue appears to be caused mostly by command startup latency. What I mean by that phrase is wine cmake --version (and the "--version" option for many commands you can run under wine) take roughly 150 ms (with wine-1.2-rc3 built with the -O3 option and running that wine version with WINEDEBUG='-all' and wineserver -p) to complete while Linux versions of the same commands require 1 ms to complete. It is a startup latency in the commands run under wine rather than a startup latency issue with the wine command itself because that command returns much faster than 150 ms if you give it an unknown command. Because many thousands of commands (e.g., "gcc"; several "cmake -E" variants per gcc command to help report progress; figure out dependencies, etc.; and various further make commands generated by the initial make command) are used to complete a typical build (say of cmake itself or PLplot), the startup latency for each of those commands accumulates and is a major factor which slows down the build (by roughly a factor of 5) compared to the equivalent Linux build. So a reduction of the command startup latency under Wine by an order of magnitude should largely solve the problem. I find the command startup latency depends very much on what X server I am using. Of course, the actual commands I am using (cmake, MinGW make, MinGW gcc, etc.) to build software under wine have nothing to do with X. So I am hoping if I build a stripped down version of wine configured to ignore X and all other systems (sound, etc.) that are not required for builds, then I might achieve the reduced command startup latency that I need. Before I try that, however, is there some less brute-force way to reduce command startup latency? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________ ---------- Forwarded message ---------- Date: Sat, 12 Jun 2010 14:10:31 -0700 (PDT) From: Alan W. Irwin <irwin(a)beluga.phys.uvic.ca> To: wine-users(a)winehq.org Subject: Re: [Wine] Speed/latency issues for development in a Wine environment On 2010-06-11 18:09-0700 Alan W. Irwin wrote: The previous timing numbers were done with wine-1.1.42. Following a suggestion made off-list to me, I have built wine-1.2-rc3 today (with CFLAG=-O3) and immediately noticed the start-up latency for simple commands (e.g., cmake --version) was reduced from about 0.25 s to about 0.15 s. I don't know how the previous Debian wine-1.1.42 packages were optimized so that difference may just be due to an optimization difference or an actual improvement in the Wine code from 1.1.42 to 1.2-rc3. However, to see how -O3 optimized wine-1.2-rc3 does with the full tests, I have redone my timing tests for I. (cmake), II (make install), and III (make install latency) and the following reductions have been observed. > Wine I. > wine(a)raven> time wine cmake -G "MinGW Makefiles" \ > "-DCMAKE_INSTALL_PREFIX=z:/home/wine/cmake/install1" \ > z:/home/software/cmake/cmake-2.8.1_patched/ >& cmake.out > > real 14m17.124s ==> real 8m18.041s > Wine II. > > wine(a)raven> time wine mingw32-make install >& make_install.out > > real 20m13.421s ==> real 12m4.198s > Wine III. > wine(a)raven> time wine mingw32-make install >& make_install.out1 > > real 1m39.018s ==> real 0m51.045s For reference here are the corresponding Linux numbers which are still much better than the corresponding Wine-1.2-rc3 results. > Linux I. > > wine(a)raven> time cmake -G "Unix Makefiles" \ > "-DCMAKE_INSTALL_PREFIX=/home/wine/cmake/install_linux" \ > /home/software/cmake/cmake-2.8.1_patched/ >& cmake.out > > real 0m34.015s > Linux II. > > wine(a)raven> time make install >& make_install.out > > real 2m12.805s > Linux III. > > wine(a)raven> time make install >& make_install.out1 > > real 0m0.869s To summarize these findings, it appears that changes in startup latency for simple commands strongly correlates with timing results for build steps I, II, and III on Wine. This makes sense since we know that several thousand commands are run for, e.g., build step II so startup latency of hundreds of milliseconds per command must be a real build performance killer. So what can be done to reduce the simple startup latency from the current ~150 ms on Wine down much closer to the Linux startup latency for the same commands which is typically 1 ms? Simple commands requiring 150 ms to start must have an awful lot of extra start baggage. Is all that baggage really needed for command-line commands such as cmake, mingw32-make, gcc, etc.? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

5 10

RFC: Patch to add EM_FINDWORDBREAK tests
by James McKenzie June 21, 2010

June 21, 2010

All: While working on a problem with The Sword (a bible program), I noticed that an empty yellow box kept appearing. I then ran the program from the terminal and up popped what looked like a never ending stream of EM_FINDWORDBREAK stub entries. A further investigation (with Google's help) reveals that Brian Chang submitted implementation of this function with tests. I then found Dan's reply that one of the tests needed. I attempted to add this test and am requesting assistance, and if possible crosstest file so I can run it on XP. Thank you. James McKenzie

1 0

*_queue.php files in AppDB
by Alexandru Băluț June 20, 2010

June 20, 2010

Hi, Why exactly are these AppDB files needed? ./include/testData_queue.php ./include/version_queue.php ./include/application_queue.php Thanks, Alex

2 1

Re: richedit: Add WB_ISDELIMITER value to richedit.h
by Dylan Smith June 20, 2010

June 20, 2010

On Sun, Jun 20, 2010 at 6:00 PM, James McKenzie <jjmckenzie51(a)earthlink.net>wrote: > While looking for implementation guidance at google.com, came across the > value for WB_ISDELIMITER which was not in richedit.h. This patch adds this > value which will be necessary for full implementation of this function. > > WB_LEFT, WB_RIGHT, and WB_ISDELIMITER are defined in winuser.h because they are used by the normal edit control. The other WB_* constants are used by the richedit control, so are defined in richedit.h. Just include winuser.h.

2 1

Help wanted for bug#3023
by Eliot Blennerhassett June 20, 2010

June 20, 2010

Greetings, I'm hoping to get some with disposing of http://bugs.winehq.org/show_bug.cgi?id=3023 Short summary: Commenting line 934 of dlls/user32/dialog.c in EndDialog makes OrCad (electronic schematic cad package) usable (otherwise several essential functions don't work) EndDialog( HWND hwnd, INT_PTR retval ) { ... // comment the following line if (hwnd == GetActiveWindow()) WINPOS_ActivateOtherWindow( hwnd ); ... } MSDN says "HWND A handle to the dialog box to be destroyed. Dialog boxes created by the DialogBox, DialogBoxParam, DialogBoxIndirect, and DialogBoxIndirectParam functions must be destroyed using the EndDialog function. An application calls EndDialog from within the dialog box procedure; the function must not be used for any other purpose. " Now, can anybody explain what the purpose of the suspect line is? or what possible bad things might happen if it was removed? I have run Wine for several years with this one line patch, and seen no ill effects AFAIK. If removing the line completely is not an option, is there a way to conditinally avoid executing it based on environment or registry? eg if (!ALLOW_ORCAD_TO_WORK) { original code } thanks -- Eliot Blennerhassett 5 years of recompiling wine from source with a 1 line patch...

1 0

Help wanted re Bugzilla#3023 (one line fix for Orcad add new elements)
by Eliot Blennerhassett June 20, 2010

June 20, 2010

Greetings, Help wanted Re: http://bugs.winehq.org/show_bug.cgi?id=3023 Short summary: Commenting line 934 of dlls/user32/dialog.c in EndDialog makes OrCad usable. EndDialog( HWND hwnd, INT_PTR retval ) { ... // comment the following line if (hwnd == GetActiveWindow()) WINPOS_ActivateOtherWindow( hwnd ); ... } MSDN says "HWND A handle to the dialog box to be destroyed. Dialog boxes created by the DialogBox, DialogBoxParam, DialogBoxIndirect, and DialogBoxIndirectParam functions must be destroyed using the EndDialog function. An application calls EndDialog from within the dialog box procedure; the function must not be used for any other purpose. " Now, can anybody explain what the purpose of the suspect line is? or what possible bad things might happen if it was removed. I have run Wine for several years with this one line patch, and seen no ill effects AFAIK. If removing the line completely is not an option, is there a way to conditinally avoid executing it based on environment or registry? eg if (!ALLOW_ORCAD_TO_WORK) { original code } thanks -- Eliot Blennerhassett

1 0

WineSkin v0.01
by Joel Holdsworth June 20, 2010

June 20, 2010

Hi All, I just wanted to highlight my new project - WineSkin http://www.airwebreathe.org.uk/wineskin/ WineSkin is an attempt to create a set of scripts that auto-generate the necessary themes, visual styles and registry keys to visually integrate wine with the host desktop environment. At the moment I only support integrating 5 icons with the host, when the DE is Gnome. I'm hoping that the project will grow and eventually I'll be able to integrate with KDE and MacOS. For now I'm just focussing on trying to get any kind of good integration going. If anyone has any thoughts or comments, let me know; I'd love to hear them. All the best Joel

4 3

New flags in LoadLibraryEx
by Mariusz Pluciński June 20, 2010

June 20, 2010

Hello, wine-devel It seems, that Microsoft introduced new flags for kernel32.LoadLibraryEx function, which are not yet available in Wine. Those flags are: LOAD_IGNORE_CODE_AUTHZ_LEVEL, LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE, LOAD_LIBRARY_AS_IMAGE_RESOURCE and LOAD_LIBRARY_REQUIRE_SIGNED_TARGET. Most of them were added with Vista introduction, and the last one is not documented in MSDN. I don't want to implement them (at least, not now), but want to add some "stubby" support. So, I added flags into winuser.h and the following code on the beginning of kernel32.load_library routine: if( flags & LOAD_IGNORE_CODE_AUTHZ_LEVEL ) FIXME("unsupported flag: LOAD_IGNORE_CODE_AUTHZ_LEVEL\n"); if( flags & LOAD_LIBRARY_AS_IMAGE_RESOURCE ) FIXME("unsupported flag: LOAD_LIBRARY_AS_IMAGE_RESOURCE\n"); if( flags & LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE ) { FIXME("unsupported flag: LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE\n"); /* temporary solution which should let some application working */ flags |= LOAD_LIBRARY_AS_DATAFILE; } if( flags & LOAD_LIBRARY_REQUIRE_SIGNED_TARGET ) FIXME("unsupported flag: LOAD_LIBRARY_REQUIRE_SIGNED_TARGET\n"); Of course it works, but is it acceptable by Wine project?

2 1

DIBEngine and gdi32/user32 controls drawing loop performance
by Amico Amico June 20, 2010

June 20, 2010

Hello, since I had a poor performance in drawing many buttons and text input fields at the same time into a window with wine, I applied the DIBEngine patch (http://wiki.winehq.org/DIBEngine) that is available for wine 1.1.44 (http://bugs.winehq.org/attachment.cgi?id=27879) to the 1.1.44 version of wine and started my application program that needs to draw many button and text input fields in a single window with the enviroment variable "WINEDIB=ON wine ./App.exe". Now that the DIBEngine patch is applied a little speedup in the drawing of the buttons and the text input fields is shown, but now the problem is that they are still drawn in blocks of a subset of the total number and then wine waits a little bit, then it draws another block of text input fields and buttons and then wine still waits, then it draws, and so on. The result is that my App.exe application window that is full of buttons and text input fields is drawn in subsequent times, and groups of buttons and input fields are drawn in blocks with a delay between the drawing of a group of controls and the others. The fact that not all the controls are drawn at a time but in more times is frustrating, since the CPU is a core2duo, and I think that it is powerful enough to draw all of the controls in the window at a time, specially with the DIBEngine patch applied and the DIBEngine activated. So I thought that the problem could be in the main event loop that manages the App.exe application window, and in particular the problem could be that the loop yields the drawing of the controls after a certain number of controls have been drawn in order to avoid CPU high load and then the loop starts again to draw other controls after a while and then it stops and yields and waits again, and so on. Where can I modify such a behaviour? In particular my App.exe program use many gdi32 drawing commands for drawing buttons and text input fields, so the files dlls/user32/button.c and dlls/user32/edit.c are involved. I think that the dlls/user32/winproc.c file, where the Code: LRESULT WINAPI EditWndProcA( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { return wow_handlers.edit_proc( hwnd, msg, wParam, lParam, FALSE ); } function is defined is the file where I should do some changes; this function calls Code: LRESULT EditWndProc_common( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, BOOL unicode ) that is implemented in the dlls/user32/edit.c file, but the fact is that in the EditWndProc_common function there are many cases like this one that manages the various edit messages and window messages sent Code: switch (msg) { case EM_GETSEL: result = EDIT_EM_GetSel(es, (PUINT)wParam, (PUINT)lParam); break; .... and I don't know how to modify the fact that the main loop of the window should handle more messages in order to draw all of the controls at a time and that it should not yield for waiting and then starting drawing again after some time. What can I do? Thanks in advance, AmoxT _________________________________________________________________ Taglia i costi. Chiama e videochiama da Messenger http://www.messenger.it/videoconversazioni.aspx

2 1

[RFC] gameux.dll implementation stub [try 2]
by Mariusz Pluciński June 20, 2010

June 20, 2010

Hi I fixed noted problems with my initial implementation of gameux.dll. The code freeze is still the fact, but I hope for some feedback. Thanks

3 2

new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Dan Kegel June 20, 2010

June 20, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel Add dxsdk_nov2006, document how to use it etc. at http://kegel.com/wine/cl-howto-win7sdk.html directx9: override dxdiag.exe, too Update divx sha1sum Andrew Nguyen Add windowscodecs Jeff Zaroyko Fix vjrun20 path in non-quiet mode Austin English Update OpenWatcom to version 1.9

6 7

gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
by Scott Ritchie June 20, 2010

June 20, 2010

Screenshot/blog here: http://yokozar.org/blog/archives/225 A bug was fixed recently in Gnome that allows thumbnailers to not be 96x96 pixels. Combine this with a standard Wine icon, icoutils for extracting an exe/dll's embedded icon, and a bit of magic and you can get icons like those above. The version numbers come from the .exe metadata. I think it's really slick, and will try and have it installed by default with Wine 1.2. At the moment it exists as thumbnailer code for Gnome, which means other desktops won't benefit, however provided they can be told to run a script to generate an icon it should be fairly easy to port. Code is available in the gnome-exe-thumbnailer source package here: https://edge.launchpad.net/~ubuntu-wine/+archive/ppa Please note that this is an updated version of the proof of concept gnome-exe-thumbnailer package I put in Lucid (which is ugly and uses the overly large 96x96 icons, and is thus not default and has so far gone unnoticed). Thanks, Scott Ritchie

3 4

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org June 19, 2010

June 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2780 Your paranoid android. === WXPPROSP3 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K3R2SESP2 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === WVISTAADM (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K8SE (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PRO (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (64 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex

1 0

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org June 19, 2010

June 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2779 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [PATCH] [Mmsystem.drv]: always map parameters for all callback kinds
by Juan Lang June 19, 2010

June 19, 2010

Hi Eric, minor comment on this patch: + case CALLBACK_FUNCTION: + TRACE("Function (32 bit) !\n"); + /* 16 bit func, call it */ + TRACE("Function (16 bit) %x!\n", thunk->callback); The back-to-back traces look a little strange. So does the indenting here. --Juan

1 0

Apologies for the marketing message
by Jeremy White June 19, 2010

June 19, 2010

It's not clear how it happened; it was not intended. These are direct emails James sends periodically to customers reaching the end of their support period. We speculate that someone signed up with the mailing list address as 'their' address. At any rate, by way of apology I'd like to remind everyone that all contributors to Wine are entitled to VIP status with CodeWeavers, which gets you free lifetime subscriptions to CrossOver. (This way, there is no chance James could ever sell you anything <grin>). Write to me if you'd like me to set you up. We are deeply grateful for everyones contributions to Wine, and very sorry for the off topic emails. Cheers, Jeremy

1 0

Re: new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Vincent Povirk June 19, 2010

June 19, 2010

On Sat, Jun 19, 2010 at 9:31 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 6/19/2010 18:25, Vincent Povirk wrote: >>> >>> Is it possible to add this in existing target d3dx dll that will be using >>> new decoder? >>> >> >> Yes, but they'll have to share the decoder for the DDS format somehow. >> It doesn't make much sense for d3dx9 to load d3dx11 for this. >> > > If native d3dx11 uses d3dx9 for that it's not a problem, cause this will be > still separated and both overrides will work. > If not - it's sad, additional winetricks re-registration will be needed, > etc. And if our windowscodecs is complete enough > we should probably forget about all of that and never use its override. Well, we need to register a decoder coclass to do this most cleanly, using WIC's built-in image format detection. These classes aren't present on any native dll's. Even if we didn't use a coclass, we'd need some sort of extension to a builtin dll. Most of the extra formats are only needed by d3dx9 (it seems native d3dx10 and d3dx11 use WIC, so they mostly support the WIC formats). DDS, however, can be loaded in d3dx9, d3dx10, and d3dx11. If we put a coclass for DDS in one of these dll's, the other two will have to load it when a program needs to read a DDS file.

1 0

kernel32 translation question
by Luca Bennati June 19, 2010

June 19, 2010

I found out why it didn't build: a numeric code in the first lines was in a wrong format. But now i need help to know what exactly i need to put there, because i don't know anymore. The lines are these (example got from french file): LanguageNames=(FRA=0x0c:winerr) CodePages=(FRA=65001:0) The problem is only the hexadecimal code in the first line: where i find the right value for ITA? The one i put (incorrectly) was from ita.nls ...

3 2

Re: hhctrl.ocx - null pointer bug
by Dmitry Timoshkov June 19, 2010

June 19, 2010

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html > sent by Dmitry Timoshkov contains bug resulting in wine crash due to > possible null pointer dereference. Please, see bug report at > http://bugs.winehq.org/show_bug.cgi?id=23247 for more information. You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults in all cases instead. Is that a real or just "possible" crash? From your description and the bug report it sounds like a theoretical issue. -- Dmitry.

2 1

Re: hhctrl.ocx - null pointer bug
by Juan Lang June 18, 2010

June 18, 2010

Hi Jaroslav, - if (!*caption) caption = info->pCHMInfo->defTitle; + if (!caption) caption = info->pCHMInfo->defTitle; I suspect a better fix would be: + if (!caption || !*caption) caption = info->pCHMInfo->defTitle; That is, either a NULL caption or an empty one results in info->pCHMInfo->defTitle getting used. --Juan

2 1

New wisotool 20100618: 19 new verbs (blur, spore, photoshop cs5, ...), and 75 old ones
by Dan Kegel June 18, 2010

June 18, 2010

wisotool is a handy winetricks-like script for automatically installing games from .iso or .mds files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for your password so it can mount the .iso file). Wisotool currently supports about 95 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. I'm especially interested in recent or beta games; ideally wisotool would support good games or betas on or near their day of release. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100530: Austin English: New verbs proevolution2010_demo pscs5 pscs5_pickle pscs5_unpickle Dan Kegel: New verbs bioshock_demo blur rom Various bugfixes Eleazar Galano: New verbs avatar_demo braid braid_demo darknesswithin2_demo hegemonypom_demo hphbp_demo nfsps_demo popsot spore Travis Athougies: New verbs 7million msaoe_demo Vincent Pelletier: New verb beneath_a_steel_sky_gog Here's the current help message: Script to install games automatically. Usage: wisotool [options] package [package] ... Options: -q quieter -v verbose -V display Version Packages: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] 7million 7Million (Deep Silver, 2009) [download] [broken on wine] abes_exoddus_gog Abes Exoddus (GOG.com) abes_oddysee_gog Abes Oddysee (GOG.com) assassinscreed Assassins Creed (Ubisoft, 2008) avatar_demo James Camerons Avatar The Game Demo (Ubisoft, 2009) [download] baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) battle_chess_gog Battle Chess (GOG.com) beneath_a_steel_sky_gog Beneath a Steel Sky (GOG.com, free) beyond_good_and_evil_gog Beyond Good and Evil (GOG.com) bfbc2 Battlefield Bad Company 2 (EA, 2010) bioshock Bioshock (2K Games, 2007) bioshock_demo Bioshock Demo (2K Games, 2007) blur Blur (Activision, 2010) braid Braid (Number None, 2009) [download] braid_demo Braid Demo (Number None, 2009) [download] codmw2 Call of Duty Modern Warfare 2 (Activision, 2009) [broken] darknesswithin2_demo Darkness Within 2 Demo (Zoetrope Interactive, 2010) [download] descent_1_2_gog Descent and Descent 2 (GOG.com) descent_3_gog Descent 3 (GOG.com) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) dukenukem3d_gog Duke Nukem 3D (GOG.com) dukenukemmp_gog Duke Nukem Manhattan Project (GOG.com) earth_2150_trilogy_gog Earth 2150 trilogy (GOG.com) earth_2160_gog Earth 2160 (GOG.com) earthworm_jim_1_2_gog Earthworm Jim 1 & 2 (GOG.com) earthworm_jim_3d_gog Earthworm Jim 3D (GOG.com) empire_earth_gold_gog Empire Earth Gold (GOG.com) evil_genius_gog Evil Genius (GOG.com) fallout_2_gog Fallout 2 (GOG.com) fallout_gog Fallout (GOG.com) fallout_tactics_gog Fallout Tactics (GOG.com) far_cry_gog Far Cry (GOG.com) flatout_gog FlatOut (GOG.com) freespace_2_gog Freespace 2 (GOG.com) freespace_gog Freespace (GOG.com) ghost_master_gog Ghost Master (GOG.com) ground_control_2_gog Ground Control 2 (GOG.com) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) half_life_goty Half Life: Game of the Year Edition (Sierra, 2000) hegemonypom_demo Hegemony: Philip of Macedon Demo (Longbow Games, 2010) [download] help How to use this tool hon Heroes of Newerth (S2 Games, 2010) [download] hphbp_demo Harry Potter & The Half Blood Prince Demo (EA, 2009) [download] lswcs Lego Star Wars Complete Saga (Lucasarts, 2009) manhole The Manhole Masterpiece Edition (Cyan, 1994) masseffect2 Mass Effect 2 (BioWare, 2010) mdk2_gog MDK 2 (GOG.com) mdk_gog MDK (GOG.com) mnbw_demo Mount & Blade Warband Demo (Taleworlds, 2010) [download] morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) msaoe_demo Age of Empires Demo (Microsoft, 1997) [download] neighbours_from_hell_compilation_gog Neighbours From Hell 1 & 2 (GOG.com) nfsps_demo Need For Speed: Pro Street Demo (EA, 2007) operation_flashpoint_goty_gog Operation Flashpoint GOTY (GOG.com) orangebox Orange Box (Valve, 2007) painkiller_black_gog Painkiller Black (GOG.com) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] perimeter_gog Perimeter (GOG.com) plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] popsot Prince of Persia Sands of Time (Ubisoft, 2003) popsot_demo Prince of Persia Sands of Time Demo (Ubisoft, 2003) praetorians_gog Praetorians (GOG.com) procycling08_demo Pro Cycling Manager 2008 Demo (Cyanide, 2008) [download, broken in wine] procycling09_nda Pro Cycling Manager 2009 (Cyanide, 2009) proevolution2010_demo Pro Evolution Soccer 2010 Demo (Konami, 2009) [download] pscs5 Photoshop CS5 Demo (Adobe, 2010) pscs5_pickle save Photoshop CS5 Demo to tarball pscs5_unpickle restore Photoshop CS5 Demo from tarball psychonauts_gog Psychonauts (GOG.com) quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] redneck_rampage_gog Redneck Rampage (GOG.com) robinson_requiem_collection_gog Robinson Requiem & Deus (GOG.com) rom Runes of Magic (Frogster Interactive, 2009) [download] settlers_2_gold_gog The Settlers 2 Gold (GOG.com) shogo_gog Shogo Mobile Armor Division (GOG.com) sims3 The Sims 3 (EA, 2009) splitsecond Split Second (Black Rock Studios, 2010) [wine bug 22865] splitsecond_demo Split Second Demo (Black Rock Studios, 2010) [wine bug 22865] spore Spore (EA, 2008) starcraft Starcraft Battle Chest (Blizzard, 1998) starcraft2 Starcraft II beta (Blizzard, 2010) stfu Starwars: The Force Unleashed (Aspyr, 2009) sto Star Trek Online (Cryptic, 2010) tex_murphy_1_and_2_gog Tex Murphy 1 & 2 (GOG.com) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] unreal_2_se_gog Unreal 2: The awakening Special Edition (GOG.com) unreal_gold_gog Unreal Gold Edition (GOG.com) ut2004_gog Unreal Tournament 2004 (GOG.com) ut_goty_gog Unreal Tournament GOTY (GOG.com) wog World of Goo demo (2D Boy, 2008) [download] wowbc World of Warcraft: Battle Chest (Blizzard, 2008) Pseudopackages: load Load a disc into the iso cache load=KEY Load a disc with given key; only works from commandline at moment ------------------------------------------------------ If the game is not marked with {download} or {loaded} in the menu, you have to insert its disc and give the 'load' command before you can choose that game in the menu. If the game has multiple discs, you have to do this for each disc. ------------------------------------------------------ ------------------------------------------------------ If the game has an install key, you have to enter that when loading the first disc. (You have to do that from the commandline, e.g. sh wisotool load=XXXX-YYYY-ZZZZ.) ------------------------------------------------------

1 0

Happy Father's Day From CodeWeavers: Get CrossOver Mac for 60% Off (This Weekend Only)
by James Ramey June 18, 2010

June 18, 2010

Thank you for your past patronage of CrossOver Mac. We appreciate your business, and I was hoping to tempt you with an enticing offer to continue supporting our software. For this weekend only, you can purchase CrossOver (any version) for 60% off the list price. All you need to do is enter SPECIAL DEAL CODE: FATHERSDAY in the Special Deal Box in the cart screen (has to be the cart screen) of the order process. You'll see the discount applied before you complete your transaction. It's a quick and easy way to save money on your purchase of CrossOver. · A couple of factoids you might want to consider in making this purchase: · CrossOver 9.1 is due out within the next 45 days. CrossOver 9.1 should be an especially good release of CrossOver, and the upgrade to this version is included in your purchase. · CrossOver Mac Professional includes a license for CrossOver Mac Games. CrossOver Mac Games is now playing many new titles including Star Trek On-line. If you have an interest in playing games, you may want to consider purchasing CrossOver Mac Professional using the SPECIAL DEAL CODE. · All volume and educational discounts are still valid with this promotion. If you have an educational entitlement, you'll get your educational discount in addition to the SPECIAL DEAL CODE. Likewise if you purchase more than one license, you'll also get volume discounts. Again, this SPECIAL DEAL CODE is easy to use and will save you money!! · The SPECIAL DEAL CODE expires on Monday, June 21. Don't wait to buy. If you're interested, make your purchase now as this special deal is limited to only past customers and only to this weekend. · If this SPECIAL DEAL CODE isn't your cup of tea, I understand. This is the only e-mail that you will receive from me about renewing your support. You'll receive a nag e-mail or two from our system reminding you to renew your maintenance. Once those have past, we will not contact you again (ever) unless you have signed up for one of our many mailing lists. Finally, everyone at CodeWeavers appreciates your business. We appreciate your patience as we work to make our software ever better. We understand that it's not always easy to use our software and that our software doesn't always provide the support you want or need. We want you to know this and that we are making efforts to make the software better. Again, thank you. We sincerely appreciate your support of our software and our efforts to make our software better. With my best regards, James B. Ramey Vice President, Sales CodeWeavers, Inc. jramey(a)codeweavers.com

1 0

The __WINE__ macro does not identify the Wine platform
by Alan W. Irwin June 18, 2010

June 18, 2010

According to some old discussion (http://www.mail-archive.com/wine-devel(a)winehq.com/msg15669.html) on wine-devel it appears that __WINE__ was going to be the macro used to identify the Wine platform, However, that doesn't appear to work for Windows native MinGW on wine. To show this, I attach results from running wine gcc -E -dM foo.c >| /tmp/wine_gcc_dM.out where foo.c is an empty file, and gcc is the MinGW 4.5.0-1 version. The equivalent command under Linux gcc shows several macros, (e.g., __linux__) are defined to identify that platform, but I cannot find anything in the attached file that similarly identifies the Wine platform. Furthermore, I have compiled and run a simple test code under Wine that shows that __WINE__ is not available (see previous post on wine-users for details). An excellent general motivation for such an identifying macro for wine is given in the above older wine-devel discussion, and I understand the CMake developers have an immediate use for such a macro within the CMake code itself. Is the lack of a macro to identify the wine platform a bug I should report or am I missing something? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 11

Re: user32: Lock user32 in alloc_user_handle to fix races with get_user_handle_ptr
by Dan Kegel June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 9:18 AM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > On Friday 18 June 2010 07:04:14 pm Dan Kegel wrote: >> Say, that sounds like a kind of test we should have in our test suite. >> >> What apps does this fix? > > Sysinternal's autoruns.exe which populates a number of list/tree views with a > large number of icons extracted them the exes. It seems to do so from > different threads and it doesn't stop if one thread crashes (I wonder - > intentionally?) > > Unfortunately it's a race condition that doesn't always happen. Adding just a > TRACE suppressed the error. Adding if (...) ERR(...) showed that only 1-2 out > of about 150 icon creations would crash. Thanks for the info.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests (try 2)
by Alexandre Julliard June 18, 2010

June 18, 2010

Marko Nikolic <grkoma(a)gmail.com> writes: > Fixed test failures in 64-bit build. It would be better to choose a more appropriate invalid value for a BOOL variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Force a minimum character size of 1x1 to prevent divisions by zero if setting the font failed
by Alexandre Julliard June 18, 2010

June 18, 2010

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > user32: Force a minimum character size of 1x1 to prevent divisions by zero if > setting the font failed > > Failing to set any font is unusual but can happen - for example: > DISPLAY= wine notepad It sounds like a gdi bug. It should be able to provide metrics even without a display. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by Alexandre Julliard June 18, 2010

June 18, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Fri Jun 18 13:21:56 2010 +0900 > > comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons It would probably be better to not disable buttons that don't need it. What is this fixing? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by James Mckenzie June 18, 2010

June 18, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > >Alexandre Julliard wrote: >> Aric Stewart <aric(a)codeweavers.com> writes: >> >>> commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 >>> Author: Aric Stewart <aric(a)codeweavers.com> >>> Date: Fri Jun 18 13:21:56 2010 +0900 >>> >>> comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons >> >> It would probably be better to not disable buttons that don't need >> it. What is this fixing? >> > >I can modify the patch to do that. > >This is triggering a bug on the mac that causes the window manager to >loose track of where to send messages causing the resulting dialog to be >unable to get mouse events. > Thank you for taking time to fix this. What is the bug report number so that I can go out and vote for it. I've experienced this lately while running some regression tests and I thought that it was just my system messing up (I've had to reboot it several times in the last week or so.) BTW, 10.6.4 has been released, 700MB download :( James McKenzie

1 0

Re: ddraw: Better validation of IDirectDrawSurface::BltFast parameters.
by Henri Verbeet June 18, 2010

June 18, 2010

On 18 June 2010 15:52, Iain Arnell <iarnell(a)gmail.com> wrote: > - dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight) > + dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight || > + (dstx | dsty) & (1<<(sizeof(DWORD)*8-1)) /* dstx or dsty negative */ ) That's not very pretty. This looks like it's just an integer overflow, so that's probably also how you should handle it.

1 0

Re: Michael Stefaniuc : notepad: Fix an error in the Bulgarian translation.
by Eric Ahn June 18, 2010

June 18, 2010

unsubscribe

1 0

Re: notepad: substitute the page number in the footer
by Alexandre Julliard June 18, 2010

June 18, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * notepad: substitute the page number in the footer This needs to be more generic, there are other possible substitutions. At the very least it should handle escaped ampersands. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_INVALID_CALL_ARG "Apel de procedură sau argument nevalid" > + IDS_SEMICOLON "„;” presupus" > + IDS_LBRACKET "„(” presupus" > + IDS_RBRACKET "„)” presupus" > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" > + IDS_NOT_FUNC "Funcție presupusă" > + IDS_NOT_NUM "Număr presupus" > + IDS_OBJECT_EXPECTED "Obiect presupus" > + IDS_NOT_BOOL "Obiect boolean presupus" > + IDS_JSCRIPT_EXPECTED "Obiect JScript presupus" > + IDS_REGEXP_SYNTAX_ERROR "Eroare de sintaxă în expresie rațională" > + IDS_URI_INVALID_CHAR "URI care trebuie codificat conține caractere nevalide" > + IDS_ARRAY_EXPECTED "Obiect matrice presupus" "expresie rațională" should be translated as "expresie regulată" (I've also seen "regulară", but never "rațională") [1] "nevalid" sounds really odd and it's almost never used; imho "invalid" should be used instead [2] "presupus" sounds really confusing; something in the lines of "Se aștepta un obiect" sounds better to me and seems more standard [3] I really think we should try to make translations a bit standard, especially when it comes to technical terms. Octavian [1] http://ro.wikipedia.org/wiki/Expresie_regulat%C4%83 [2] http://ro.wikipedia.org/wiki/Special:C%C4%83utare/Invalid [3] http://translationproject.org/latest/coreutils/ro.po

2 2

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" Forgot about this one, maybe try "Constantă șir neterminată" [1]. When not sure how to translate a term, maybe this will help: google for "UNKNOWN TERM ro.po site:http://translationproject.org/". Octavian [1] http://translationproject.org/PO-files/ro/indent-2.2.8.ro.po

1 0

Xinput / DirectInput xbox360 controller support
by Roderick Colenbrander June 18, 2010

June 18, 2010

Hi all, I'm interested in adding Xbox 360 controller support to Wine. For people who don't know how this works and what's so special I will first give a small introduction. The Xbox 360 controller is a normal USB device which you can use from 'xinput*.dll' (typically xinput1_3.dll is used). The xinput API is very easy (and it is the same what is used on the Xbox360) and in total it exports a handful of functions. Basically there is a call to query the capabilities, a call to poll which button was pressed and a call to 'set the controller to a certain state' (rumble stuff) and a few other not so important calls. The dll can ONLY be used for xbox 360 compatible controllers and other controllers should use dinput. In Wine we have a stubbed xinput implementation. Last year Michael Gruber submitted a number of patches which added implementations for most calls but the code wasn't added. I tested his XInput code on current Wine and it actually works well in DirectX SDK examples including force feedback! After he submitted the code there was a short discussion on wine-devel but then it stopped. Michael his xinput code directly interfaces with the Linux input event interface. It was asked whether XInput can't be layered on top of DirectInput but that's not possible since DirectInput doesn't expose all the needed functionality (it doesn't support the Xbox360 force feedback). The other way around is also not possible because XInput is only for Xbox 360 controllers/joysticks while DirectInput also supports keyboard and mouse. I'm wondering how to proceed with XInput. My main issue is the 'joystick access part'. Would it be fine to directly access the controller from Xinput (so we would need multiple hardware backends later on). Code size won't be a problem though since XInput doesn't support much functionality at all (the current mostly working version is less than 500 lines of code; half of that is for the Linux backend). One small issue is though that DirectInput and XInput might have to cooperate since typically games use DirectInput to enumerate all joysticks, see for instance http://msdn.microsoft.com/en-us/library/ee417014%28VS.85%29.aspx Roderick

4 6

Help with simple winelib dll
by Seth Burleigh June 18, 2010

June 18, 2010

Im attempting to build a dll which a windows program running under wine can dynamically load. The dll will be a wrapper around a linux library. In preparation ive tried to follow the instructions here http://www.winehq.org/docs/winelib-guide/bindlls with a simple example but have not succeeded. Below is the contents of the files in my directory and the commands i executed. Can anyone help out? Thanks! MyLinuxFunc.c int MyLinuxFunc(int a,int b) { return a+b; } ----------------------------- MyLinuxFunc.h int MyLinuxFunc(int,int); ----------------------------- libMyLinuxFunc.so ----------------------------- MyWin.dll.spec 2 stdcall MyWinFunc (long long) MyProxyWinFunc ----------------------------- MyWin.c #include <MyLinuxFunc.h> #include <windef.h> int WINAPI MyProxyWinFunc (int a,int b) { return MyLinuxFunc(a,b); } ----------------------------- winemaker . --nosource-fix --dll --single-target MyWin --nomfc -I"." -L"." -iMyLinuxFunc make winegcc -o MyWin.so MyLinuxFunc.o MyWin.o -L. -lMyLinuxFunc MyWin.o: In function `MyProxyWinFunc': MyWin.c:(.text+0x20): undefined reference to `MyLinuxFunc' /usr/lib/wine/libwinecrt0.a(exe_main.o): In function `main': (.text+0xa0): undefined reference to `WinMain' collect2: ld returned 1 exit status winegcc: i486-linux-gnu-gcc failed make: *** [MyWin.so] Error 2

4 7

Brazilian Portuguese translation of winecfg
by Gustavo June 18, 2010

June 18, 2010

Hello, I've updated the translation of winecfg in Brazilian Portuguese. Making comparisons, I also noted that the "Windows Version" (Versão do Windows) drop-down menu disappeared and the Browse... (Localização:) text in the Drives was cut to half when you execute wine with LANG="pt_PT.UTF-8" (the Portuguese from Portugal). I've managed to fix that as well. So I sent two separate patches: one with the Brazilian translation and another with the Portuguese fixes. Let me know if I did anything wrong. Gustavo Henrique Milaré

1 1

Re: comctl32: Update English resource
by Juan Lang June 17, 2010

June 17, 2010

Hi Ken, +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_CAN + +IDD_TBCUSTOMIZE DIALOG DISCARDABLE 10, 20, 357, 125 +STYLE DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU +CAPTION "Customize Toolbar" +FONT 8, "MS Shell Dlg" +BEGIN + DEFPUSHBUTTON "&Close", IDCANCEL,308,6,44,14 + PUSHBUTTON "R&eset", IDC_RESET_BTN,308,23,44,14 + PUSHBUTTON "&Help", IDC_HELP_BTN,308,40,44,14 + PUSHBUTTON "Move &Up", IDC_MOVEUP_BTN,308,74,44,14 + PUSHBUTTON "Move &Down", IDC_MOVEDN_BTN,308,91,44,14 + LTEXT "A&vailable buttons:", -1,4,5,84,10 + LISTBOX IDC_AVAILBTN_LBOX,4,17,120,100, LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP + PUSHBUTTON "&Add ->", IDOK, 131, 42, 44, 14 + PUSHBUTTON "<- &Remove", IDC_REMOVE_BTN,131,62,44,14 + LTEXT "&Toolbar buttons:", -1,182,5,78,10 + LISTBOX IDC_TOOLBARBTN_LBOX, 182,17,120,100,LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP +END I don't understand why you would want to create multiple "translations" when their content is identical. If it's because the statistics you're generating claim a particular variant of English is incomplete, then you should fix the tool you're using to generate the statistics: unless there's an actual difference between American English and the variant, there's no need for a translation. --Juan

3 3

Brazilian Portuguese translation
by Gustavo June 17, 2010

June 17, 2010

Hello, I can see that the Brazilian translation is bad, so I'm translating winecfg. I followed the instruction in the wiki [1] to create a .po file. At first I tried to recover from the file Pt.rc rc2po -t En.rc Pt.rc Pt.po but I didn't have much luck, no existing translations are shown. Adding the options --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN or even just --lang=LANG_PORTUGUESE fails to create the file. Not much of a problem, I started from scratch. The problem is, when I use the .po file to create the .rc file po2rc --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN -t En.rc Pt.po Pt.rc only Brazilian Portuguese entries are created, and the Pt.rc file had "Portuguese Portuguese" entries as well. What should I do? Gustavo. [1] http://wiki.winehq.org/Translating

3 4

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by lats June 17, 2010

June 17, 2010

When does this unpredictability occur? The tests have always run ok for me.

2 1

wined3d: Add NPOT quirk for GeforceFX 5200
by Roderick Colenbrander June 17, 2010

June 17, 2010

1 0

Re: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. (try 2)
by Alexandre Julliard June 17, 2010

June 17, 2010

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> writes: > Try 2: Re-order function bodies as well. > > From a51f6b7f855ccb1d9252a3d5e2698cdbe73ad053 Mon Sep 17 00:00:00 2001 > From: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> > Date: Fri, 11 Jun 2010 14:13:52 +0100 > Subject: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. > > Paul Vriens found which test caused the breakage. There's no need to reorder the functions, but there's a need to understand why that test is breaking win_skip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2]kernel32/tests: Test the collation table much more
by Alexandre Julliard June 17, 2010

June 17, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > I added some ranges to test, so it is easy extensible That's still not a very convincing test... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2742 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2739 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: [PATCH] winspool/tests: Handle the Windows bug in GetPrinterDataEx
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2720 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: PGO and wine
by Peter Davies June 17, 2010

June 17, 2010

On 16 June 2010 02:37, Dan Kegel <dank(a)kegel.com> wrote: > But does PGO improve performance measurably? > Probably, to test it I need a program that runs wine like a typical program, that I can run autonomously. Anyone have any ideas? Peter

5 4

wrong link between bug and AppDB
by wylda＠volny.cz June 16, 2010

June 16, 2010

Hi, i just made a mistake and linked bug 9264 with http://appdb.winehq.org/objectManager.php?sClass=version&iId=20179. But i wanted to link 19264 instead of 9264. What are the correct steps to fix this mistake? -- Kaspersky Internet Security 2010 + Kaspersky Mobile Security jen za 1199,-Kč. Ochraňte svůj počítač i mobil před zneužitím či ztrátou dat. Kupte si 2 produkty za cenu jednoho. www.kaspersky.cz

2 1

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Alexandre Julliard June 16, 2010

June 16, 2010

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 36f1499..0d383bd 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -384,6 +384,7 @@ static void start_thread( struct startup_info *info ) > thread_data->pthread_id = pthread_self(); > > signal_init_thread( teb ); > + signal_init_thread_fpu(); > server_init_thread( func ); > pthread_sigmask( SIG_UNBLOCK, &server_block_set, NULL ); This should be done inside signal_init_thread(), that's already meant for platform-specific setup, there's no need to add a separate entry point. Also you may want to do an fninit if new threads are not supposed to inherit FPU state. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Henri Verbeet June 16, 2010

June 16, 2010

I forgot to mention this, but this fixes a regression introduced by commit e6611e22fb037a879205f1330d1a3485f9f18705.

1 0

Re: [RESEND 2] Changes to enable the use of gcov and PGO
by Alexandre Julliard June 16, 2010

June 16, 2010

Peter Davies <ultratwo(a)gmail.com> writes: > @@ -72,7 +72,7 @@ MAKECTESTS = $(TOOLSDIR)/tools/make_ctests$(TOOLSEXT) > WRC = $(TOOLSDIR)/tools/wrc/wrc$(TOOLSEXT) > WMC = $(TOOLSDIR)/tools/wmc/wmc$(TOOLSEXT) > WIDL = $(TOOLSDIR)/tools/widl/widl$(TOOLSEXT) > -WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ > +WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ $(LDFLAGS) LDFLAGS are already passed to winegcc where appropriate. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Anotated 'make test' log
by Max TenEyck Woodbury June 16, 2010

June 16, 2010

Dan wrote: > OK. I'd suggest starting by looking at > http://bugs.winehq.org/show_bug.cgi?id=15435 > "Wine logs too verbose, quieter fixme's needed" and sending > in a patch to make one of the overly-verbose fixme's a bit > quieter. Thanks. I'll look at it. > Also, check your mail system; I can't email to you directly, > it bounces. And that's going to be a problem communicating > with other developers. A system disk failed this past weekend and I've been trying to get everything back up. I got test messages through starting about two hours ago. I've been checking the mailing list archive. (Yes, messages do not get properly threaded that way.) I'm also in the process of reinstalling much software. That machine is not very fast... - Max

1 1

Re: [2/9] setupapi: Validate the cabinet filename parameter in SetupIterateCabinetA.
by Alexandre Julliard June 16, 2010

June 16, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/setupapi/setupcab.c | 7 ++- > dlls/setupapi/tests/Makefile.in | 1 + > dlls/setupapi/tests/setupcab.c | 121 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 128 insertions(+), 1 deletions(-) > create mode 100644 dlls/setupapi/tests/setupcab.c It doesn't work here: wine: Unhandled page fault on write access to 0x6864dd7b at address 0x686a1c89 (thread 003a), starting debugger... Unhandled exception: page fault on write access to 0x6864dd7b in 32-bit code (0x686a1c89). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686a1c89 ESP:0032f6e0 EBP:0032fa68 EFLAGS:00010246( R- -- I Z- -P- ) EAX:6864dd7b EBX:686b2cfc ECX:00000000 EDX:00000024 ESI:6865d68f EDI:0032f838 Stack dump: 0x0032f6e0: 0032f93c 6864dd7b 0032f838 0032fa4c 0x0032f6f0: 686a14e0 00000000 0032f724 ffffffff 0x0032f700: 0032fa40 0032f9e4 0032f768 7bc70be0 0x0032f710: 0000000e 00000002 00000001 0032f93c 0x0032f720: 00110060 acabfeed 00121100 00000000 0x0032f730: 00000000 00038080 2e366338 00706d74 Backtrace: =>0 0x686a1c89 SetupIterateCabinetA+0xc9(CabinetFile="", Reserved=0, MsgHandler=0x6864b9a0, Context=0x0(nil)) [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi (0x0032fd38) 1 0x6864bd95 test_invalid_parametersA+0x384() [/home/julliard/wine/wine/dlls/setupapi/tests/setupcab.c:108] in setupapi_test (0x0032fd88) 2 0x6864df0e run_test+0x14d(name=<is not available>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:557] in setupapi_test (0x0032fe48) 3 0x6864e0e2 main+0x131(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:607] in setupapi_test (0x0032fe90) 4 0x6864e27c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in setupapi_test (0x0032fea8) 5 0x7b854ebc call_process_entry+0xb() in kernel32 (0x0032fee8) 6 0x7b85756b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:996] in kernel32 (0x0032fef8) 7 0x7bc71a40 call_thread_func+0xb() in ntdll (0x0032ffc8) 8 0x7bc71c10 call_thread_entry_point+0x6f(entry=0x7b857510, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2466] in ntdll (0x0032ffe8) 9 0x7bc4d5ca start_process+0x29(kernel_start=0x7b857510) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x00000000) 0x686a1c89 SetupIterateCabinetA+0xc9 [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi: movb $0x0,0x0(%eax) 588 *p = '\0'; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: try to not raise exceptions when checking for atl thunks
by Alexandre Julliard June 16, 2010

June 16, 2010

Markus Amsler <markus.amsler(a)oribi.org> writes: > + * Windows checks the following conditions before emulating an ATL thunk: > + * - DEP policy allows emulating > + * - thunk has memory type MEM_PRIVATE and is readable > + * - jmp func is executable > + * - thunk signature (movl, jmp) matches > + * - a "secret" flag is set: > + * The flag gets set before calling WndProc and cleared after WndProc > + * or a thunk was emulated. > + * In Windows XP SP 3 this flag is located at TEB+0xfb4. > */ Where does that information come from? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: kernel32: stop CopyFile from overwriting a file with itself
by Alexandre Julliard June 16, 2010

June 16, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > + if (h2 != INVALID_HANDLE_VALUE) > + { > + BY_HANDLE_FILE_INFORMATION info2; > + if (GetFileInformationByHandle( h2, &info2 )) > + { > + if (info.dwVolumeSerialNumber == info2.dwVolumeSerialNumber && > + info.nFileIndexLow == info2.nFileIndexLow && > + info.nFileIndexHigh == info2.nFileIndexHigh) The volume serial number is not the appropriate check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by testbot＠testbot.winehq.org June 16, 2010

June 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2695 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W7PROX64 (64 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to close a window
by Vitaliy Margolen June 16, 2010

June 16, 2010

On 06/15/2010 05:36 AM, Paul Chitescu wrote: > Changelog: > winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to > close a window > + GetCursorPos( &pt ); > + PostMessageW( hwnd, WM_SYSCOMMAND, SC_CLOSE, MAKELPARAM( pt.x, pt.y ) ); You can't do that. Cursor can be anywhere, even outside Wine when WM decides to remove Wine's window. According to MSDN (which means it requires validation) you can pass either -1 or 0 for lparam here. Otherwise I think WM_SYSCOMMAN should be the correct behavior. Vitaliy.

1 0

Re: [PATCH] winspool: Return ERROR_MORE_DATA, when the app probe for the needed buffersize [BUG 19624]
by testbot＠testbot.winehq.org June 16, 2010

June 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2686 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: propsys: mention that the functions are stubs
by James Mckenzie June 15, 2010

June 15, 2010

Hans Leidekker <hans(a)codeweavers.com> wrote: > >On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > >> Just to confirm what André said, if the FIXME does not contain the word >> 'stub', then apistats has no way to know it's a (pseudo-)stub. > >Wouldn't it be sufficient for our purposes to just count every first >fixme in a WINAPI function as a stub? As it is now there's a large >percentage of fixmes that don't include the 'stub' keyword. > I tend to disagree. Stubs should be identified, if possible, for each call. Some calls will not activate a specific sequence of FIXMEs and in some cases, users have become confused as they don't have the technical knowledge to determine why their program is failing. > >> I would further argue that even a human reading the log would have no >> way to know as quite a few implemented functions still dump their parameters. >> So even for humans it's better to add 'stub' to the FIXME message. > >I'd say we need turn those into traces and add fixmes for the >unimplemented parts, if needed. > This actually might be better, but don't TRACES only appear if you are running in debug mode? We do want to inform our user base that a failure happened due to partially implemented code rather than give them the impression that we don't care or only implement code to make certain programs work (hacky code...) Note: This is only a statement of opinion, not a request for direction within the project. If a fixme had 'stub' that means that we have implemented code to 'fake' windows functionality, whereas a real fixme means there is a problem with the code and it needs to be corrected. James McKenzie

2 1