June 2010 - Wine-Devel - list.winehq.org

Re: avifil32: Update English resource
by Alexandre Julliard June 15, 2010

June 15, 2010

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE > IDS_AVIFILETYPE "Wine AVI-default-filehandler" > IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate them. Also you should never submit 60 patches in one go; 10-15 is the maximum for a patch series, and that's only if you are absolutely confident that they are correct. Otherwise send only a couple until you are sure to get it right on the first try. -- Alexandre Julliard julliard(a)winehq.org

5 9

Gcov and PGO
by Peter Davies June 15, 2010

June 15, 2010

After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRACFLAGS=-fprofile-generate LDFLAGS=-fprofile-generate" Run sample program (test suite is inappropriate because it doesn't represent normal usage). Run "make clean" Run "make EXTRACFLAGS=-fprofile-use LDFLAGS=-fprofile-use" Peter

1 0

Re: propsys: mention that the functions are stubs
by Hans Leidekker June 15, 2010

June 15, 2010

On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > Hans might have missed that No, to me a fixme that prints a parameter list without further explanation implies that the function is a stub.

5 8

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler
by testbot＠testbot.winehq.org June 15, 2010

June 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.
by Alexandre Julliard June 15, 2010

June 15, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT notification, UINT_PTR param1, UINT_PTR param2 ) > { > + static int has_extracted; > + This is not reentrant. Also you need to point out which bugs these patches are fixing that justifies putting them in during code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Changes to enable the use of gcov
by James McKenzie June 15, 2010

June 15, 2010

Peter Davies wrote: > To use gcov you must pass --coverage at both compile and link time. > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test", > "gcov file.c" is sufficient generate .gcov files. > > Peter: Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? James McKenzie

3 2

New Wine stuff in FreeWear.org
by Ismael Barros² June 15, 2010

June 15, 2010

Hello, We have decided to renew our offer of Wine T-shirts, as the current T-shirt has had mostly no success at all, probably because users don't feel identified nor appealed with the design. I'm attaching the pdf with our new proposals (we hope you like them!). We decided to offer the design in black garment, as in our experience it works much better. We want to be transparent, so I'm attaching also a spreadsheet with our expenses, donations and profits for each model. We usually collaborate with FOSS events, sending them stuff from our catalogue for its sale on the event. In these cases, we make a double donation: one to the organization of the event (higher, as they are in charge of the sales) and another one to the corresponding FOSS organization for the sold article. You can see the details in the spreadsheet. If you have no objection, we'll send Wine stuff to the event that require it. Currently, almost all organizations we work with have us linked from their website. This helps boosting the sales, and therefore the donations, so that everybody wins. We would be very glad if we could get a link somewhere at winehq.org, or alternatively a news item, which for us has the downside of having a limited front-page life-span, but works nonetheless. We hope you like and approve the design. Suggestions are welcome. When the design is approved, we'll upload it to our website. Kind regards, Ismael

2 2

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it
by Alexandre Julliard June 15, 2010

June 15, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is, it doesn't really prove anything. Also please use sizeof and friends instead of hardcoded numbers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Updating the 1.2 release announcement text
by Dan Kegel June 15, 2010

June 15, 2010

http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

4 4

Re:Anotated 'make test' log
by Max TenEyck Woodbury June 15, 2010

June 15, 2010

Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to start, so I started at the top of the log. I expect that to change once I become more sure that I have the mechanics correct. There are several things I'm trying to do. First is to find the place where each 'bit of noise' is generated. I seem to be doing that right. Then I look at why the noise was generated and to show that I've understood why, I wrote a note on how the 'noise' could be turned off without changing the test. I labelled these 'fixup:'. I then looked at the test code and added 'Note:'s where I thought the test could be improved. > While that's a noble quest, and I'd like to encourage people > to improve the tests, it might be more productive to do so > around areas of pain for users. > For instance, you could look at bugs in bugzilla that have > patches attached that aren't committed yet because tests are > needed, and write those tests. > - Dan That sounds useful. I also have a few issues I'd like fixed too. However, it's been more than five years since I've done serious coding; things happened that destroyed my self-confidence. A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

1 0

Inviting users to look for regressions in wine-1.2rc3?
by Dan Kegel June 15, 2010

June 15, 2010

How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. The thread about Wylda's statistics reminded me about http://wiki.winehq.org/PlatinumRegressionHunt We mentioned that in the first 1.0 rc announcement: http://www.winehq.org/announce/1.0-rc1 but not in http://www.winehq.org/announce/1.2-rc1 How 'bout we mention it in the rc4 release announcement and/or blogs?

8 10

Re: Two enhancement requests for winetricks
by James Mckenzie June 15, 2010

June 15, 2010

Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >OK. New version of the script: it also finds uppercase filename matches. >It also removed: > > 131072 1999-01-15 04:37 system32/MAPISTUB.DLL > 70656 2008-10-06 23:30 system32/MSVCIRT.DLL > 326656 2008-10-06 23:30 system32/MSVCRT40.DLL > 492304 2008-10-06 23:30 system32/OLEAUT32.DLL These are the files that Wine creates. You may have broken your Wine install now. OLEAUT32.DLL contains partial code that links to a file OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) James McKenzie

2 2

Re: msvcrt: Add _wmakepath_s implementation
by testbot＠testbot.winehq.org June 15, 2010

June 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2647 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

RFC: Standardize paths in shell32.SHChangeNotify [Bug 18606]
by Andrew Eikum June 14, 2010

June 14, 2010

Hey folks, I have a fix here for bug 18606. I think it's decent, but I could use another few sets of eyes to make sure I didn't miss anything, or even that I'm not way on the wrong track. The problem and solution are described in patch 3. In brief, SHChangeNotify notifies windows when a change to the filesystem occurs that the window asked to be notified about. For example, a window might tell SHChangeNotifyRegister "Inform me about changes to C:\". Bug 18606 occurs because the new directory is passed to SHChangeNotify as '/home/user/.wine/drive_c/New Directory', which doesn't match the IDList created for 'C:\'. This patchset fixes that by converting all paths in SHChangeNotify to UNIX paths, resolving symlinks etc, and comparing the ID lists created from those paths. That way, the paths being compared are standardized and compared fairly. Unfortunately, this is hard to write tests for. You'd have to make an ID list that is significantly different from the one SHChangeNotifyRegister will create, but that actually refers to the same directory. This is easy in Wine, but less obvious in Windows. Suggestions for how to accomplish this are welcome. Logically, though, I think the problem and solution make sense. Please take a look. Any feedback is appreciated. Andrew

1 0

Portuguese translations of Wine back at 100%
by Paul Vriens June 14, 2010

June 14, 2010

Hi, Just a note to thank Ricardo for getting the Portuguese translations back to 100%. -- Cheers, Paul.

1 0

Polish translations of Wine at 100%
by Paul Vriens June 14, 2010

June 14, 2010

Hi, Łukasz did it, Polish translations of Wine reached the 100% mark !!! Great job done. -- Cheers, Paul.

1 0

Make depend
by Peter Davies June 14, 2010

June 14, 2010

How often do I need to run "make depend"? Peter

4 4

Re: mshtml: Check if event_table entry is allocated before using it in remove_event_handler.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2632 Your paranoid android. === W2K3R2SESP2 (32 bit events) === events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 === W7PRO (32 bit events) === events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 === W7PROX64 (32 bit events) === events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 === W7PROX64 (64 bit events) === events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0

1 0

Re: [2/2] msi: Add tests for MsiLocateComponent and make them pass.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2626 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:1622: Test failed: Expected C:\imapath, got msi.c:1629: Test failed: Expected C:\imapath, got msi.c:1648: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1649: Test failed: Expected C:\imapath, got msi.c:1650: Test failed: Expected 10, got 260 msi.c:1655: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1656: Test failed: Expected C:\imapath, got msi.c:1657: Test failed: Expected 10, got 260 msi.c:1666: Test failed: Expected C:\imapath, got msi.c:1672: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1673: Test failed: Expected C:\imapath, got msi.c:1674: Test failed: Expected 10, got 260 msi.c:1712: Test failed: Expected C:\imapath, got msi.c:1719: Test failed: Expected C:\imapath, got msi.c:1738: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1739: Test failed: Expected C:\imapath, got msi.c:1740: Test failed: Expected 10, got 260 msi.c:1745: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1746: Test failed: Expected C:\imapath, got msi.c:1747: Test failed: Expected 10, got 260 msi.c:1756: Test failed: Expected C:\imapath, got msi.c:1762: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1763: Test failed: Expected C:\imapath, got msi.c:1764: Test failed: Expected 10, got 260 msi.c:1822: Test failed: Expected C:\imapath, got msi.c:1829: Test failed: Expected C:\imapath, got msi.c:1848: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1849: Test failed: Expected C:\imapath, got msi.c:1850: Test failed: Expected 10, got 260 msi.c:1855: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1856: Test failed: Expected C:\imapath, got msi.c:1857: Test failed: Expected 10, got 260 msi.c:1866: Test failed: Expected C:\imapath, got msi.c:1872: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1873: Test failed: Expected C:\imapath, got msi.c:1874: Test failed: Expected 10, got 260 msi.c:1931: Test failed: Expected C:\imapath, got msi.c:1937: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1938: Test failed: Expected C:\imapath, got msi.c:1939: Test failed: Expected 10, got 260 msi.c:1948: Test failed: Expected C:\imapath, got msi.c:1954: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1955: Test failed: Expected C:\imapath, got msi.c:1956: Test failed: Expected 10, got 260 msi.c:2008: Test failed: Expected C:\imapath, got msi.c:2014: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:2015: Test failed: Expected C:\imapath, got msi.c:2016: Test failed: Expected 10, got 260 msi.c:2025: Test failed: Expected C:\imapath, got msi.c:2031: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:2032: Test failed: Expected C:\imapath, got msi.c:2033: Test failed: Expected 10, got 260 msi.c:2129: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2147: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2162: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2177: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2195: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2224: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2242: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2257: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2272: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2290: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2371: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2377: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2401: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2408: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2442: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2471: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2478: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:7467: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7536: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7603: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7827: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7829: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7888: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7906: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7924: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7926: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7942: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7944: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7961: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7963: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7982: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7984: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8001: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8003: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8119: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8121: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8166: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8168: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8192: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8194: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7827: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7829: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7888: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7906: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7924: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7926: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7942: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7944: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7961: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7963: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7982: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7984: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8001: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8003: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8119: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8121: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8166: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8168: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8192: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8194: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7827: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7829: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7888: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7906: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7924: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7926: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7942: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7944: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7961: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7963: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7982: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7984: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8001: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8003: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8119: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8121: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8166: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8168: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8192: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8194: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8445: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8447: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8567: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8569: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8614: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8616: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8640: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8642: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8445: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8447: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8567: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8569: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8614: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8616: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8640: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8642: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8937: Test failed: Expected patchcode to be unchanged, got {2B8A9453-54F5-4090-A3A4-951258440C67} msi.c:8939: Test failed: Expected targetprod to be unchanged, got {A549CAF1-986B-4834-AD1A-3744EFAB33EC} msi.c:9008: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9010: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9053: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9055: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9599: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9642: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9819: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple"

1 0

Re: [PATCH] atl: Do not fail on Wine64
by Maarten Lankhorst June 14, 2010

June 14, 2010

Hi Marcus, 2010/6/13 Marcus Meissner <marcus(a)jet.franken.de>: > Hi, > > The size is 248 on Wine64 ... (expected 240), so we miss > perhaps a pointer or some alignment. > > Its not fully clear what. > > It at least does not crash when ignoring the size change. Seems wrong to me, does it allow size 240 on 64-bits, or does it allow 248 only? ~Maarten

3 2

RE: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by Greg Geldorp June 14, 2010

June 14, 2010

> From: Reece Dunn <msclrhd(a)googlemail.com> > > msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not > registered. This does not fail on the test page, as the msxml3 tests > are skipped when msxml3.dll is not present. > > It would probably be better to issue a win_skip in this instance, but > it is not relevant to your change. TestBot uses a different algorithm to check if a test should be skipped. Winetest.exe checks the name of the test and obtains the name of the DLL being tested from that (msxml3_test.exe => msxml3.dll). If that DLL is not present, winetest.exe skips the test. TestBot checks the import table of the test executable, and if any of the statically imported DLLs are missing it skips the test. In this case, msxml3.dll is not statically linked, so it will not be skipped by TestBot on NT4. TestBot should probably check the test name too. Ge.

1 0

Two enhancement requests for winetricks
by Joerg-Cyril.Hoehle＠t-systems.com June 14, 2010

June 14, 2010

Hi, Jan Hoogenraad wrote: >Each debugging request for wine states that I should remove all winetricks. AppDB should request something similar: minimal use of winetricks. >However I have no way to tell, and no way to safely remove them. IMHO one solution to your problem is to learn to use different .wine prefixes. Both developers and AppDB users want a repeatable process to make the app run (or crash). If you install all your software into a single .wine hierarchy (like you'd do on MS-Windows), then you cannot tell anyone what you did to make the app work in Wine. All you have is "I started with Wine-0.9.48, upgraded to wine-1.1.6 at some time, now to wine-1.2rc2, used "winetricks X" and Y, perhaps I used "winetricks directx" but I can't remember for sure, I installed apps A, B and C (they may have installed more components) and I edited the registry a few times. Given all that, app Z works fine in on my machine." This is a mess much like a typical MS-Windows installation. With Wine, you can do better than that. What people want to hear from you is as follows: - Create a fresh .wine prefix with wine-X.Y; - Install Indeo Video codecs via "winetricks indeo" because I found out that the app expects them but does not install them itself; - Install the app from CD; - From a DirectX install into a separate .wine-* prefix, solely copy d3dx9_36.dll into system32/ (or the app's directory) - Change setting Y in winecfg, e.g. native d3dx9_36; - App Z works (or crashes like that ...). That is a minimal instruction set. I have like a dozen .wine-* directory hierarchies. I never use .wine itself except for regression testing, such that I can rm -rf ~/.wine and create a fresh one at any time. That's why I don't need an uninstaller. rm -rf ~/.wine-xyz or rm -rf ~/wineapps/... *is* the uninstaller (.wine-xyz/drive_c/Programs/Apps/ symlinks to $HOME/wineapps such that the apps live independently on a particular .wine prefix). Regards, Jörg Höhle

3 2

Re: [PATCH 4/6] shdocvw: Silence QueryService traces in non-interactive runs.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2620 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === Timeout === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:295: Test failed: unexpected nsCmdID 28

1 0

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by testbot＠testbot.winehq.org June 13, 2010

June 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid android. === WNT4WSSP6 (32 bit domdoc) === domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should have succeeded instead of failing with 0x80040154

3 2

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph
by Austin English June 13, 2010

June 13, 2010

On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change > any of the code but moves code from ME_WrapMarkedParagraphs to > ME_WrapTextParagraph. > > The bug report #6254, which this is a solution to is marked as needed for > Wine 1.2 > > Thanks to Dylan Smith who helped segegrate and clean up the original code > proposed by Tony Rollo and further worked on by Lei Zhang and myself. You forgot the patch. -- -Austin

2 1

Re: msi: Print more information on error
by Alexandre Julliard June 13, 2010

June 13, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > i had that case with > err:msi:ACTION_CallDllFunction GetProcAddress for function L"findApplications" in dll L"C:\\users\\dawncrow\\Temp\\msi94eb.tmp" failed > so you see that just the function is not info enough. I don't see that. The name of the temp file is not meaningful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Anotated 'make test' log
by Max TenEyck Woodbury June 13, 2010

June 13, 2010

I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A few reservations: * I started from the top of the log. If I continue, I will be selecting sections that I find interesting. * I am not going to produce patches until someone says that the annotations are going in the right direction. This will change when I become more familiar with the community's opinion of my efforts. ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so cred.c && touch cred.ok Note: This test is expected to produce 2 error reports call is pCredReadA(TEST_TARGET_NAME, -1, 0, &cred) implementation at dll/advavi32/cred.c - CredReadA parameter names: TargetName, Type, Flags, *Credentials conversion to CreadReadW implementation at same - CredReadW fixme:cred:CredReadW unhandled type -1 Fixup: Convert 'if (Type != CRED_TYPE_GENERIC && Type != CRED_TYPE_DOMAIN_PASSWORD)' to a switch(case?) with all known types enumerated. Put unimplemented types at the end with a 'fixup' then fall through to the default case which sets the error code and fails. Note: In other words, don't request fixup for improper type codes. call is pCredReadA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef, &cred) see above for details fixme:cred:CredReadW unhandled flags 0xdeadbeef Fixup: Get a list of all known flags. Build a mask for all of them. Check for any unknown flags set and issue a warning if there are any. Build a mask of all implemented flags (currently none) and issue a fixme if any of those are set. Note: In other words, don't request fixup for undefined flags set. Question: Should this be an failure exit? Alternatively, should there be a list of flags that, if set trigger a failure exit? Note: Only fail if the flags indicate an option that can not be ignored. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredWriteA(&new_cred, 0) implementation at same - CredWriteA parameter names: Credential, Flags new_cred.UserName = 'winetest' new_cred.TargetName = TEST_TARGET_NAME conversion to CredWriteW implementation at same - CredWriteW err:cred:CredWriteW bad username L"winetest" Note: This is an expected error. Note: Should it mention 'syntax' since it is checking for \ and @? Note: No bad flags test - Fixup per CredReadW above. Note: No bad type test - Fixup per CredReadW above. call is pCredWriteA(&new_cred, 0) see above for details. new_cred.UserName = NULL err:cred:CredWriteW bad username (null) Note: This is an expected error. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredDeleteA(TEST_TARGET_NAME, -1, 0) implementation at same - CredDeleteA parameter names: TargetName, Type, Flags conversion to CredDeleteW fixme:cred:CredDeleteW unhandled type -1 Fixup: see CredReadA above call is pCredDeleteA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef) se above for details. fixme:cred:CredDeleteW unhandled flags 0xdeadbeef fixup: see CreadReadA above Note: No sucess tests. Note: Test order is questionable. A better order would be Write, Read then Delete with tests that are expected to succeed added. call is pCredReadDomainCredentialsA(&info, 0, &count, &creds implementation at same - CredReadDomainCredentialsA parameter names: TargetInformation, Flags, *Size, **Credentials conversion to CredReadDomainCredentialsW fixme:cred:CredReadDomainCredentialsW (0x15ddf8, 0x0, 0x33fd18, 0x33fc4c) stub Fixup: No suggestion

1 0

re: WINE and demoscene products
by Dan Kegel June 12, 2010

June 12, 2010

Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks last year, it was very convincing. (Although, frankly, running retail DVD-ROM games on day of beta or release is an even more convincing feat if we can pull it off.) As somebody else pointed out, there are already appdb entries for quite a few demos: http://appdb.winehq.org/objectManager.php?sClass=category&iId=95 It'd be nice if someone filled in any missing ones there. (I'm not sure how much overlap there is between demos and real games, but the idea of a really small graphical app is appealing, one would expect they'd be easier to diagnose?) - Dan

2 1

Three year sever outstanding bug requiring minor fix
by velociraptor Genjix June 12, 2010

June 12, 2010

Hey, Please look into this issue, http://bugs.winehq.org/show_bug.cgi?id=15118 It seems like a fairly trivial fix which renders this application useless. A detailed description of the implementation needed is provided in that ticket. Thank you _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ Do you have a story that started on Hotmail? Tell us now

5 4

snoop,relay,trace
by Hin-Tak Leung June 12, 2010

June 12, 2010

I am thinking of going barbaric and doing WINEDEBUG=+relay,+snoop,+trace to see how mt.exe get the wrong image size in http://bugs.winehq.org/show_bug.cgi?id=22812 and just grep for the wrong/right sizes (0x "2b000", "176128", 0x "2b200", "176640" ) to see where mt gets it from but none turn up. Since it is a relatively simple command line I thought that would work. or is there any other WINEDEBUG= is worth trying? Also I am thinking since the image size is normally padded to 0x1000, (and it says so), so a PE with an image size that looks like NNNNN200 is automatically wrong, is that correct?

1 0

WINE and demoscene products
by Wolfram Sang June 12, 2010

June 12, 2010

Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine 1.2-rc2 was recently posted here [2]. Out of 25, 14 are flawless and 4 OK - pretty good numbers IMO. (BTW the demos can be downloaded using the search function of the website.) Regards, Wolfram [1] http://en.wikipedia.org/wiki/Demo_%28computer_programming%29 [2] http://pouet.net/topic.php?which=7400

1 0

Test suite success rate
by Peter Davies June 11, 2010

June 11, 2010

How do I get the test suite to report it success rate (as a whole) in a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. Peter

3 2

Re: gdi32: Add CreateFontIndirectEx implementation (try2)
by Alexandre Julliard June 11, 2010

June 11, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try2: function body moved to *Ex call, and CreateFontIndirect use it. You should also print FIXMEs if the ignored data is used by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

No test summary line found
by GOUJON Alexandre June 11, 2010

June 11, 2010

Hi, I'm wondering if my patch (62325) hasn't been reviewed yet or if you expect a strict error-free patch. Indeed, http://source.winehq.org/patches/data/62325.testfail shows a "No test summary line found" for WNT4WSSP6. If it's an issue, how to fix it ? Thanks

2 6

Re: [PATCH 2/5] include: Add IEnumShellItems interface declaration.
by Huw Davies June 11, 2010

June 11, 2010

On 11 Jun 2010, at 12:17, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/actxprxy/usrmarshal.c | 21 +++++++++++++++++++++ > include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/dlls/actxprxy/usrmarshal.c b/dlls/actxprxy/usrmarshal.c > index f2aacf8..85e534c 100644 > --- a/dlls/actxprxy/usrmarshal.c > +++ b/dlls/actxprxy/usrmarshal.c > + > +HRESULT CALLBACK IEnumShellItems_Next_Proxy( > + IEnumShellItems *This, > + ULONG celt, > + IShellItem **rgelt, > + ULONG *pceltFetched) > +{ > + TRACE("(%p)\n", This); > + return IEnumShellItems_RemoteNext_Proxy( This, celt, rgelt, > pceltFetched ); > +} pceltFetched could be a NULL ptr here, so you should pass the address of a local variable in that case. See ole32/usrmarshal.c for examples on how to marshal IEnum*_Next Huw.

1 0

Re: Updating Ukrainian translations to kernel32
by Dmitry Timoshkov June 11, 2010

June 11, 2010

Igor Paliychuk <igor-hkr(a)mail.ru> wrote: > Updating Ukrainian translations to kernel32(ukr.nls). > file : ukrainian-kernel32-ukr-nls.patch You forgot to mention what's wrong with current ukr.nls. -- Dmitry.

2 1

Re: gdi32: CreateFontIndirectEx implementation on top of CreateFontIndirect
by Alexandre Julliard June 11, 2010

June 11, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From fb4317a2a39475c225fe04946795892c4891cd26 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Fri, 11 Jun 2010 01:42:06 +0400 > Subject: [PATCH] CreateFontIndirectEx implementation on top of CreateFontIndirect It should of course be the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()
by Andrew Nguyen June 11, 2010

June 11, 2010

On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23003 > > -- > -Austin > > > > You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.

3 5

IDL trouble (patch: adding IEnumShellItems interface declaration.)
by David Hedberg June 11, 2010

June 11, 2010

Hello everyone, I'm having some trouble with this simple patch. Specifically, it breaks compiling of dlls/actxprxy, producing the message: ***** ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./actxprxy.spec usrmarshal.o actxprxy_activscp_p.o actxprxy_comcat_p.o actxprxy_docobj_p.o actxprxy_hlink_p.o actxprxy_htiframe_p.o actxprxy_objsafe_p.o actxprxy_ocmm_p.o actxprxy_servprov_p.o actxprxy_shobjidl_p.o actxprxy_urlhist_p.o dlldata.o -o actxprxy.dll.so -luuid -loleaut32 -lole32 -lrpcrt4 -lkernel32 -lntdll ../../libs/port/libwine_port.a -L/usr/local/valgrind-svn/lib actxprxy_shobjidl_p.o: In function `IEnumShellItems_RemoteNext_Stub': /home/david/Projects/wine/git/dlls/actxprxy/actxprxy_shobjidl_p.c:6507: undefined reference to `IEnumShellItems_Next_Stub' actxprxy_shobjidl_p.o:(.data.rel.ro+0xf0): undefined reference to `IEnumShellItems_Next_Proxy' ***** It compiles if I remove the [call_as] attribute, but I guess that would kind of break the interface. Any obvious mistakes in the patch, or grammar not supported by widl? Thanks, David --- include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 6bd0244..97cd82f 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -385,6 +385,36 @@ typedef enum tagNWMF { } NWMF; /***************************************************************************** + * IEnumShellItems interface + */ +[ + object, + uuid(70629033-E363-4A28-A567-0DB78006E6D7), + pointer_default(unique) +] +interface IEnumShellItems : IUnknown +{ + [local] HRESULT Next( + [in, annotation("__in")] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched), annotation("__out_ecount_part(celt, *pceltFetched)")] + IShellItem **rgelt, + [out, annotation("__out_opt __deref_out_range(0, celt)")] ULONG *pceltFetched); + + [call_as(Next)] HRESULT RemoteNext( + [in] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched)] IShellItem **rgelt, + [out] ULONG *pceltFetched); + + HRESULT Skip( + [in] ULONG celt); + + HRESULT Reset(); + + HRESULT Clone( + [out] IEnumShellItems **ppenum); +} + +/***************************************************************************** * FOLDERSETTINGS */ typedef char *LPVIEWSETTINGS; -- 1.7.1

2 1

Re: Three year sever outstanding bug requiring minor fix
by James Mckenzie June 11, 2010

June 11, 2010

velociraptor Genjix <aphidia(a)hotmail.com> wrote at Jun 9, 2010 8:52 AM > >Hey, >Please look into this issue, >http://bugs.winehq.org/show_bug.cgi?id=15118 >It seems like a fairly trivial fix which renders this application useless. A detailed >description of the implementation needed is provided in that ticket. If it were a 'trival' fix, it would have been a long time ago. Something that looks, on the surface, to be simple, maybe very complex. For instance, I have been working on a fix for one function in the richedit area has taken over four years. Now as to your concern, tough. This project, for the most part is volunteer. So, if you want it fixed, do it yourself or find someone who can. Otherwise, you'll have to wait for someone to come by, find this interesting and then fix it. There is a part of the project that is paid, and they work for a company called CodeWeavers. Maybe they have found a fix and incorporated it into their product line. That you'll have to pay for. Remember, we fix things as WE find the time and the incorporation process is very strict. This takes time and some folks will pick up a project, only to set it down because they become busy with other things in life or they just don't have the tenancity to see it through. James McKenzie

2 1

Re: [1/3] d3dx9: Allow sampler declaration without sampler type.
by Stefan Dösinger June 11, 2010

June 11, 2010

Am 10.06.2010 um 16:06 schrieb Matteo Bruni: > <0001-d3dx9-Allow-sampler-declaration-without-sampler-type.txt> The patch looks ok, but I am wondering if the validator complains about typeless samplers. And if not, I guess the interesting question is how those declarations are treated at shader runtime...

3 4

Re: resources: Convert Polish resources to UTF8.
by Frédéric Delanoy June 11, 2010

June 11, 2010

Hi. I see this patch has been "Rejected" in http://source.winehq.org/patches/, but I just wondered why: - are the UTF8 resources not preferred over custom codepages? - or is the patch simply too big to review? Splitting into many tiny patches seemed a bit overkill for such a simple change, no? Or maybe is it simply because Polish translations is still in progress, and it can/will cause conflict? I'm a bit confused here... Frédéric NB: I didn't touch any nls file in this patch so it shouldn't cause regressions (and had a subset of it tested by Łukasz Wojniłowicz, a native Polish speaker)

5 5

Tests crash
by Peter Davies June 11, 2010

June 11, 2010

Some tests crash for me (eg. http://bugs.winehq.org/show_bug.cgi?id=22903 segfaults). This means I can't run the entire test suite with "make test", what should I do? Peter

3 2

Re: [PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.
by Octavian Voicu June 11, 2010

June 11, 2010

Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861. Octavian

2 3

size_t usage in wine
by Marko Nikolic June 11, 2010

June 11, 2010

Hi, I have found in wine documentation that it is recommended to avoid long data type, since it is different in Win64 and Unix64. This is reasonable, however, is there some similar policy regarding size_t/ssize_t usage? Those types are often defined as long type, so they could produce the same problem with 64 bit. On the other hand, many standard functions expect or return size_t values, so I guess it could be ok to use it in such cases. Is there any advice/position on this? Thanks, Marko

2 1

"IWineGDISurfaceImpl_UnLoad: Please report to wine-devel"
by Marcin Baczyński June 10, 2010

June 10, 2010

Hi, running a simple game on wine-1.2-rc2-250-g950919e fails with "Interface not supported" message box and following messages in the terminal: $ ./wine ~/.wine/drive_c/Program\ Files/MarBit/Clicks/clicks.exe fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x146740,0x146b78): stub fixme:win:EnumDisplayDevicesW ((null),0,0x32f480,0x00000000), stub! fixme:d3d:swapchain_init Add OpenGL context recreation support to context_validate_onscreen_formats err:d3drm:IDirect3DRMImpl_QueryInterface (0x135678)->({4516ecc8-8f20-11d0-9b6d-0000c0781bc3},0x5a2e90),not found err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Please report to wine-devel fixme:d3d:IWineD3DDeviceImpl_Release (0x1e7a20) Device released with resources still bound, acceptable but unexpected fixme:d3d:IWineD3DDeviceImpl_Release Leftover resource 0x137d70 with type WINED3DRTYPE_SURFACE (0x1). The game can be downloaded here: http://marbit.com.pl/index.php?name=Downloads&req=getit&lid=1 Installation fails saying that it cannot create a shortcut, but the files get copied to the destination directory. Thanks, Marcin

1 0

Re: winefile: Update English resource for AUS, NZ and UK
by Michael Stefaniuc June 10, 2010

June 10, 2010

Hello Ken, Ken Sharp wrote: > Australian, British and New Zealand English prefers -ise over -ize > (strongly so in Aus and NZ). > > http://en.wikipedia.org/wiki/En-AU#Spelling > http://en.wikipedia.org/wiki/New_Zealand_English#Spelling if the translation is the same for UK, AU and NZ then please add only one copy of it and mark it as LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL That will do as the LANG_ENGLISH family will inherit first from SUBLANG_NEUTRAL and only if that doesn't exist from SUBLANG_DEFAULT. thanks bye michael

1 0

A Handle Cache?
by Max TenEyck Woodbury June 10, 2010

June 10, 2010

While Reading the developer's guide, I noticed that it said that translating windows' handles was always done by the server. I may have misunderstood this. Since interaction between the client and server requires at least two context switches and context switches are fairly heavy duty operations, would it make sense to cache handle lookups on the client?

2 1

gameux.dll implementation stub
by Mariusz Pluciński June 9, 2010

June 9, 2010

Hello As you maybe know, I'm working on implementation of Game Explorer in the Google Summer of Code. Main part of my work is now implementing gaming APIs stored in gameux.dll library. I already sent patches with headers, and I'm currently in the stage when stubs are ready to start real implementation. Unfortunately (for me) Wine is now in freeze stage, so I can't send patches with new library to wine-patches. Instead, Vincent Povirk suggested me to send them here to get feedback. It's very important to me to know is my way of implementation valid, cause changing something now is probably easier than modifying it in future. Attached patches creates initial implementation of gameux library, adds implementation of IClassFactory interface and stubs of four interfaces' implementations: IGameExplorer, IGameExplorer2, IGameStatistics and IGameStatisticsMgr. They also add initial tests for each interface. Each test now checks behavior of CoCreateInstance function while trying to create given interface. To create library, I used parts of code created by Alistair Leslie-Hughes, attached by him to bug 21261. Thanks in advance

3 2

Call for translators
by Paul Vriens June 9, 2010

June 9, 2010

Hi, The code freeze for Wine-1.2 has started and we are now in a weekly release candidate cycle. This is an ideal moment for translation work. The current translations status page http://source.winehq.org/transl/index.php shows four (4) languages at a 100%. Please help us have more fully translated languages for Wine-1.2. Also fixing the errors in the translations (21 languages affected) would be greatly appreciated. Most translators are not programmers and are probably intimidated by Wine's translation system. If you are comfortable editing resource file than please go ahead, create patches and sent them to wine-patches. The wiki-page http://wiki.winehq.org/Translating gives some more background information if needed. If you like to help out Wine but don't want to touch any of these resource files we can help you out. Please sent us an email with the language you'd like to translate Wine into and we will sent you the more familiar po files. These files show all the translatable strings from a resource file but in a less intriguing format. Once translated, you can sent these files back and we will turn them into the proper resource files. 'We' for now are Michael Stefaniuc and Paul Vriens but I guess others will chime in if needed. -- Cheers, Paul.

7 21

Re: Change a malloc() to a HeapAlloc()
by Peter Davies June 9, 2010

June 9, 2010

> We use real names here. This patch probably will not be committed until it > is resubmitted. Ops! I've mis-configured my mail client > The patch is also wrong. Why? What difference does malloc() over HeapAlloc() make? (this is arguably a case for not sending the patch in the first place) There is nothing that bugs me more than not being told why I'm wrong. Peter

3 2

Re: [PATCH] [WinHelp]: implemented ExecFile macro (fix for #23054)
by Alexandre Julliard June 9, 2010

June 9, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > +static void CALLBACK MACRO_ExecFile(LPCSTR pgm, LPCSTR args, LONG cmd_show, LPCSTR topic) > { > - WINE_FIXME("(\"%s\", \"%s\", %u, \"%s\")\n", str1, str2, u, str3); > + static HINSTANCE (WINAPI *shell_exec)(HWND, LPCSTR, LPCSTR, LPCSTR, LPCSTR, INT); > + HINSTANCE ret = 0; > + > + WINE_TRACE("(\"%s\", \"%s\", %u, \"%s\")\n", pgm, args, cmd_show, topic); > + if (!shell_exec) > + { > + HANDLE h; > + > + if ((!(h = GetModuleHandle("shell32.dll")) && !(h = LoadLibraryA("shell32.dll"))) || > + !(shell_exec = (void*)GetProcAddress(h, "ShellExecuteA"))) > + { > + WINE_ERR("Couldn't load shell32.ShellExecute\n"); > + } > + } Why not call ShellExecuteA directly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by Marco Meijer June 9, 2010

June 9, 2010

Hi WineDevs, I made the patch to change the text on winehq and sent it to wine-patches but still no change. Do I have to do something else ? link to patch: http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html kind regards, Marco Meijer http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html Op 6-5-10 17:57, James Mckenzie schreef: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

2 1

Re: [1/3] msi: Create directories right before installing files.
by testbot＠testbot.winehq.org June 9, 2010

June 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2538 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5408: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5427: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5452: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5471: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8261: Test failed: RegQueryValueExA failed 2 (0) install.c:9173: Test failed: got 6 expected 0 install.c:9179: Test failed: got 6 expected 0 install.c:9182: Test failed: got 6 expected 0 install.c:9184: Test failed: file removed install.c:9329: Test failed: key not created

1 0

wine in the news in spain
by Dan Kegel June 9, 2010

June 9, 2010

Saw this just now: http://www.osor.eu/news/es-zaragozas-move-to-complete-open-source-desktop-g… "Zaragoza's move to complete open source desktop going to plan by Gijs Hillenius — published on Jun 08, 2010 The move by the city of Zaragoza to an open source desktop is making good progress. All of the city's civil servants now use open source tools including Thunderbird, VLC, Firefox and OpenOffice. And this year some seven hundred of the city's 2800 desktop PCs will have seen their proprietary operating system replaced by the Linux open source alternative. ... "It is not possible to move all applications to the open source platform. For example tools for Computer Aided Design and Optical Character Recognition, can't be replaced by open source alternatives. But proprietary and open source software can live together. And if we really can't find an open source option, we resort to Virtualbox and Wine to provide users their proprietary application." ... Their web site does mention a bit about wine, too: http://zaragozaciudad.net/azlinux/2009/septiembre.php (autotranslated): "24/09/2009 How we use WINE ... Microsoft Access: Access we have hundreds of applications that lack of time and means we can not migrate to an Open Source environment. WINE can emulate many of them even though the code should be reviewed, compiled and compacted again. A particular case is still unresolved are the Access applications that generate a mail merge with Word documents. OCR: for now we have not found an efficient alternative to the use of OCR software that "emulate" Windows OCR software with WINE Transactional environment: the client for our transactional environment is old and only works for Windows environments so that the use of WINE has been indispensable In contrast we must also say that some applications could not be emulated with WINE as Presto or Nokia PC Suite. So far WINE has not been useful to emulate CAD applications. In conclusion we can say that WINE is a useful tool in some cases and allows us to move forward in the migration to Open Source environment as alternatives to proprietary software are available and the height of these." Hmm, I wonder what "Presto" is, and which CAD suites they use. - Dan

2 1

Re: Change a malloc() to a HeapAlloc()
by James McKenzie June 9, 2010

June 9, 2010

Ultra two wrote: > --- > We use real names here. This patch probably will not be committed until it is resubmitted. James McKenzie

2 1

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel
by Joel Holdsworth June 8, 2010

June 8, 2010

On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > programs/winecfg/Bg.rc | 19 +++++---- > programs/winecfg/Cs.rc | 19 +++++---- > programs/winecfg/Da.rc | 19 +++++---- > programs/winecfg/De.rc | 19 +++++---- > programs/winecfg/En.rc | 19 +++++---- > programs/winecfg/Es.rc | 19 +++++---- > programs/winecfg/Fi.rc | 19 +++++---- > programs/winecfg/Fr.rc | 19 +++++---- > programs/winecfg/Hu.rc | 19 +++++---- > programs/winecfg/It.rc | 19 +++++---- > programs/winecfg/Ja.rc | 19 +++++---- > programs/winecfg/Ko.rc | 19 +++++---- > programs/winecfg/Lt.rc | 19 +++++---- > programs/winecfg/Nl.rc | 19 +++++---- > programs/winecfg/No.rc | 19 +++++---- > programs/winecfg/Pl.rc | 19 +++++---- > programs/winecfg/Pt.rc | 32 +++++++------- > programs/winecfg/Ro.rc | 19 +++++---- > programs/winecfg/Ru.rc | 19 +++++---- > programs/winecfg/Si.rc | 19 +++++---- > programs/winecfg/Sv.rc | 19 +++++---- > programs/winecfg/Tr.rc | 19 +++++---- > programs/winecfg/Zh.rc | 38 +++++++++-------- > programs/winecfg/about.c | 88 +++++++++++++++++++++++++++++++++++++++++ > programs/winecfg/idb_wine.bmp | Bin 14614 -> 0 bytes > programs/winecfg/resource.h | 7 +++- > programs/winecfg/winecfg.rc | 4 +- > 27 files changed, 342 insertions(+), 226 deletions(-) > delete mode 100644 programs/winecfg/idb_wine.bmp Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?

4 5

Two enhancement requests for winetricks
by Jan Hoogenraad June 8, 2010

June 8, 2010

I cannot access the login to Google (Google won't let me for some technical reason) , into http://code.google.com/p/winezeug/issues/list so I use this mail list to report 2 enhancement requests 1) Can winetricks also include a REMOVE script for each of the tricks ? It seems that a user is now advised to remove some (for the user often illogical) files in the windows directories. This is error prone, and lags the nice installation interface. 2) Can winetricks also include a status check for each of the tricks ? This could be as simple as checking if the files provided by wine have the latest wine time stamp and/or version signature. Alternately, a list of installed (by the UI selected) tricks can be provided. Each debugging request for wine states that I should remove all winetricks. However I have no way to tell, and no way to safely remove them. For example, my ~/.wine/drive_c/windows/sys*/* contains the files below, for which I suspect a wine trick, based on the time stamp. However, they may also be installed by some piece of windows software that I have installed. Thus, simply removing them does not make sense to me. Could somebody file this request in the issue database for me ? ------------------- 1032 2010-04-25 12:00 system32/ngen.exe 10204 2010-04-25 12:00 system32/view.exe 210420 2010-04-25 12:00 system32/cmdlgtst.exe 924432 2008-10-06 23:30 system32/MFC40.DLL 499712 2008-10-06 23:30 system32/msvcp71.dll 348160 2008-10-06 23:30 system32/msvcr71.dll 326656 2008-10-06 23:30 system32/MSVCRT40.DLL 492304 2008-10-06 23:30 system32/OLEAUT32.DLL 258352 2008-10-06 23:30 system32/unicows.dll 21936 2008-10-06 23:30 system32/help.exe 995383 2008-10-06 23:30 system32/MFC42.DLL 70656 2008-10-06 23:30 system32/MSVCIRT.DLL 195124 2008-10-06 23:30 system32/wcmd.exe 322832 2008-10-06 23:30 system/mfc30.dll 921872 2008-10-06 23:30 system/mfc40.dll 696 2003-12-04 16:07 system32/jetodbc.rsp 60224 2003-12-03 09:56 system32/odbcji32.dll 621104 2003-12-02 15:00 system32/mswstr10.dll 158256 2003-12-02 14:59 system32/msjint40.dll 354864 2003-11-12 13:17 system32/msjetoledb40.dll 559656 2003-11-12 13:17 system32/msrepl40.dll 326184 2003-11-12 13:16 system32/msexcl40.dll 1514024 2003-11-12 13:16 system32/msjet40.dll 354856 2003-11-12 13:16 system32/mspbde40.dll 285224 2003-11-12 13:16 system32/odbcjt32.dll 248360 2003-11-12 13:16 system32/msjtes40.dll 354856 2003-11-12 13:16 system32/msxbde40.dll 264744 2003-11-12 13:16 system32/mstext40.dll 27464 2003-11-12 13:15 system32/odexl32.dll 27464 2003-11-12 13:15 system32/odtext32.dll 27464 2003-11-12 13:15 system32/oddbse32.dll 27464 2003-11-12 13:15 system32/odfox32.dll 27464 2003-11-12 13:15 system32/odpdx32.dll 838240 2003-06-02 10:15 system32/mswdat10.dll 518752 2003-06-02 10:15 system32/msexch40.dll 428640 2003-06-02 10:15 system32/msrd2x40.dll 387680 2003-06-02 10:14 system32/expsrv.dll 322144 2003-06-02 10:14 system32/msrd3x40.dll 219744 2003-06-02 10:14 system32/msltus40.dll 60000 2003-06-02 10:14 system32/msjter40.dll 37472 2003-06-02 10:14 system32/vbajet32.dll 322832 2000-02-29 02:39 system32/MFC30.DLL -- Jan Hoogenraad

1 0

Re: gameux.dll implementation stub
by James Mckenzie June 8, 2010

June 8, 2010

Mariusz Pluciński <vshader(a)gmail.com> wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm currently in the stage when stubs are ready to >start real implementation. > To prevent some of us out here from thinking you sent your patches to the wrong place, could you preface the subject of your messages like this one with RFC: That will allow us to run the patches and look closely at them to give them a critical review. Also, you can still submit your patches, it looks like Alexandre committed the first two and might commit the remaining three you submitted. Lastly, it looks like Release Candidate three for Wine 1.2 will be out on Friday and this may be the last one before the final release. James McKenzie

1 0

Re: Implement ID3DXConstantTable::GetConstantDesc
by testbot＠testbot.winehq.org June 8, 2010

June 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2526 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

msvcrt printf test failed on NT4,win95
by Thomas Heckel June 8, 2010

June 8, 2010

Hi Alexander, I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d "Proberly skip if functions are not available" made test errors on NT4 and Win95 test instead of a skip while it works on newer windows platforms as expected. Could this be the case because GetModuleHandle and these failing platforms are not widechar compatible? So maybe it needs using GetModuleHandleA? kind regards Thomas

3 3

Re: kernel32: CopyFile cannot overwrite a file with itself (try 2)
by Alexandre Julliard June 8, 2010

June 8, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * kernel32: CopyFile cannot overwrite a file with itself This breaks a number of things, particularly msi. It would need much more detailed tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regedit: use binary mode when doing file import/export (try 2)
by Alexandre Julliard June 8, 2010

June 8, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * regedit: use binary mode when doing file import/export I don't think it will work properly for output. -- Alexandre Julliard julliard(a)winehq.org

1 0

Making AppDB look nice
by Alexandru Băluț June 8, 2010

June 8, 2010

Hi, I think the AppDB pages look bad, and I want to spend some time to make them look better. For example: - In the page that shows a version of an application, the background color in the list of test results depends on the rating of each test result, and it looks very messy, that rating color should be used somehow only in the Rating column. - More generally, get rid of the colored gray background colors, and eventually use discrete alternate colors like Bugzilla when listing bugs. - Get rid of the whole-row clicking, for example in the Top-10 tables in the first page, because it works weird when you middle-click. (This is more than improving looks, but still, it's on my TODO list) If you have specific suggestions on how to make the AppDB pages look better, and consistent with the rest of the winehq sites, please tell me. Thanks, Alex

1 0

Re: Track the number of audio bytes played as a 64 bit number
by Maarten Lankhorst June 7, 2010

June 7, 2010

Hello Dmitry, 2010/6/7 Dmitry Baryshev <ksquirrel.iv(a)gmail.com>: > Make wine-1.1.43 track the number of audio bytes played as a 64 bit number > rather than a 32 bit number to avoid overflows. It may happen happen on > constantly used audio content, possibly causing inbound voice to stop > working > in some voice applications. Please send patches in the format "module: Description", and your patch mangled the tabs in winealsa :) Likely other patches are affected too. Cheers, Maarten

1 0

Gecko64 status
by Jacek Caban June 7, 2010

June 7, 2010

Hi all, I'd like to share with you progress on gecko64. First of all, I think that it was never said in public, although I've been asked about it: there won't be gecko64 for 1.2 release. I think we will have Gecko release in the second half of this year it will support 64-bit, but it's not yet clear when exactly. We may try to do it near the next Firefox release, but time will show how it will work. However, it doesn't mean that nothing is going on around Wine Gecko. I've recently switched to mingw-w64 for 32-bit builds. I've very pleased with it. They are far better in co-operation, don't have senseless politics like mingw and their quality of headers and libraries is far better. We won't need to maintain fixes to build envinonment anymore. (I've been even talking about better co-operation between our projects, but that's OT here and I will report progress when there will be more to say). We're much nearer to allow packagers to build their own Gecko now. Back to gecko64, I've completed the first step. I have a working 64-bit Firefox crosscompiled with mingw-w64. See: https://bugzilla.mozilla.org/show_bug.cgi?id=570342 for details. It starts and runs on Windows. Now I wait for patches to be committed to Mozilla. It may take awhile :/ Before we may think about support for gecko64 in MSHTML, we have to fix its issues in Wine. Firefox is a good Gecko test and it needs to be fixed first. Unfortunately it currently doesn't even start. I've put a build on server in case anyone would like to try it: http://gerwazy.lo3.wroc.pl/~jcaban/wine/firefox-mingw-w64.tar.bz2 Volunteers on working on Wine side are very welcomed. There are also some other tests from Mozilla code. Note that before fixing any more sophisticated bug, it's worth to make sure on Windows, that the bug is in Wine, not in the build. All I verified is that Firefox should start and basic functionality works (and doesn't work on Wine). Any comments and suggestions are welcomed. Cheers, Jacek

6 9

Re: [3/5] gameux: Add declaration of IGameStatistics interface (try 2)
by Alexandre Julliard June 7, 2010

June 7, 2010

Mariusz Pluciński <vshader(a)gmail.com> writes: > [ > + object, > + uuid(3887C9CA-04A0-42ae-BC4C-5FA6C7721145) > + ] > + interface IGameStatistics : IUnknown > + { > + HRESULT GetCategoryTitle([in] WORD categoryIndex, > + [out, optional] LPWSTR* pTitle); > + > + HRESULT GetLastPlayedCategory([out] UINT* pCategoryIndex); > + > + HRESULT GetMaxCategories([out] WORD* pMax); > + > + HRESULT GetMaxCategoryLength([out] UINT* cch); > + > + HRESULT GetMaxNameLength([out] UINT* cch); > + > + HRESULT GetMaxStatsPerCategory([out] WORD* pMax); > + > + HRESULT GetMaxValueLength([out] UINT* cch); > + > + HRESULT GetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [out, optional] LPWSTR* pName, > + [out, optional] LPWSTR* pValue); > + > + HRESULT Save([in] BOOL trackChanges); > + > + HRESULT SetCategoryTitle([in] WORD categoryIndex, > + [in] LPCWSTR title); > + > + HRESULT SetLastPlayedCategory([in] UINT categoryIndex); > + > + HRESULT SetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [in, optional] LPCWSTR name, > + [in, optional] LPCWSTR value); This doesn't match the PSDK. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 3)
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2512 Your paranoid android. === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 2)
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2510 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: kernel32: CopyFile cannot overwrite a file with itself
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2509 Your paranoid android. === W98SE (32 bit file) === file.c:603: Test failed: copying a file to itself didn't fail (ret=0, err=80)

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2508 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 registry.c:2009: Test failed: could not create guid key, error 6 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: [7/7] msvcrt/test: Add some simple _vsnwprintf_s tests. (try 2)
by Austin English June 7, 2010

June 7, 2010

On Sun, Jun 6, 2010 at 11:36 PM, Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> wrote: > try 2: todo_wines removed since _vsnwprintf_s is fixed by patch 5. The todo_wine's need to be removed in the same patch in which they are fixed, otherwise, the tests will "fail". -- -Austin

2 2

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Andrew Nguyen June 6, 2010

June 6, 2010

I hate to nitpick once more, but there are a few things I noticed. My alsa-lib tells me: include/pcm.h:int snd_pcm_recover(snd_pcm_t *pcm, int err, int silent); Therefore, the statement "int ret = snd_pcm_recover(NULL, NULL, NULL);" is somewhat incorrect. Secondly, I think it should be sufficient to drop the AC_COMPILE_IFELSE macro entirely. The purpose in the original test was to distinguish between the version supplied in ALSA 0.9.x and ALSA 1.x, so, while I don't feel strongly about the matter either way, just checking for the existence of the function should be sufficient, as is done in other tests.

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Marcus Meissner June 6, 2010

June 6, 2010

On Sun, Jun 06, 2010 at 02:21:33PM -0500, Austin English wrote: > -- > -Austin > diff --git a/configure.ac b/configure.ac > index 21c0203..46ac100 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1,4 +1,4 @@ > -dnl Process this file with autoconf to produce a configure script. > +/dnl Process this file with autoconf to produce a configure script. Bad. Ciao, Marcus

1 0

Running tests on wine
by GOUJON Alexandre June 6, 2010

June 6, 2010

Hi, I would like to do some (typelib) tests on wine. So I followed the instructions at http://www.winehq.org/docs/winedev-guide/testing-wine ( cd dlls/oleaut32/tests/ ; rm typelib.ok && make typelib.ok in my case) but I have err's and fixme's whereas the output on wineTestBot is quite different (http://test.winehq.org/data/9aa9a1229f2195a8b3ac575645a10242ae6e9bc8/wine_n…) I tried WINETEST_DEBUG=1 make typelib.ok but it's the same output. Am I missing something ? Thanks

3 3

Re: [PATCH 3/3] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org June 6, 2010

June 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2490 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 36, length 37 ordinal.c:1853: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1776: Test failed: got 22 ordinal.c:1826: Test failed: got 22 ordinal.c:1834: Test failed: got 22 ordinal.c:1842: Test failed: got 31, length 32 ordinal.c:1853: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1776: Test failed: got 22 ordinal.c:1826: Test failed: got 22 ordinal.c:1834: Test failed: got 22 ordinal.c:1842: Test failed: got 31, length 32 ordinal.c:1853: Test failed: got 34

1 0

Re: [PATCH 2/3] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org June 6, 2010

June 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2489 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 36, length 37 ordinal.c:1852: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1775: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 22 ordinal.c:1841: Test failed: got 31, length 32 ordinal.c:1852: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1775: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 22 ordinal.c:1841: Test failed: got 31, length 32 ordinal.c:1852: Test failed: got 34

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by testbot＠testbot.winehq.org June 6, 2010

June 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2488 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 36, length 37 ordinal.c:1844: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1767: Test failed: got 22 ordinal.c:1817: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 31, length 32 ordinal.c:1844: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1767: Test failed: got 22 ordinal.c:1817: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 31, length 32 ordinal.c:1844: Test failed: got 34

1 0

Re: appwiz: Add the Polish translation
by Sven Baars June 6, 2010

June 6, 2010

Hey Łukasz, all your translations are written in UTF-8, but to actually use UTF-8, you also have to include a #pragma code_page(65001) on top of the file. In this case for example +#include "res.h" + +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT + +#pragma code_page(65001) Atm, if you compile wine with this patch applied you see: sven(a)sven-desktop:~/wine-git/dlls/appwiz.cpl$ make LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foPl.res Pl.rc Warning: string "Aby doda� program z dysku, p�yty CD-ROM lub dyskietki, kliknij przycisk Zainstaluj" seems to be UTF-8 but codepage 1250 is in use. Warning: string "To oprogramowanie mo�e by� usuni�te automatycznie. Aby usun�� program lub zmieni� jego zainstalowane komponenty, zaznacz go z listy i naci�nij Zmie�/Usu�." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Zmie�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Usu�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "Podane informacje mog� by� przydatne przy otrzymaniu pomocy technicznej dla %s:" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Dodaj/Usu� programy" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Pozwala na instalacj� nowego lub usuni�cie ju� istniej�cego oprogramowania z twojego komputera." seems to be UTF-8 but codepage 1250 is in use. Warning: string "Nie mo�na uruchomi� programu odinstalowuj�cego, '%s'. Czy chcesz usun�� wpis o tym programie z rejestru?" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Nie okre�lone" seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Usu�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Zmie�/Usu�..." seems to be UTF-8 but codepage 1250 is in use. You get warnings like this for every patch that you sent in. You can check it yourself by running "make depend" from the git directory and then "make" from the directory that contains the program or dll. This is at least how I got them. Regards, Sven P.S. You're not the only one making this mistake. I also made it the first time ;) Łukasz Wojniłowicz wrote: > --- > dlls/appwiz.cpl/Makefile.in | 1 + > dlls/appwiz.cpl/Pl.rc | 84 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 0 deletions(-) > create mode 100644 dlls/appwiz.cpl/Pl.rc >

1 0

Release plans
by Alexandre Julliard June 6, 2010

June 6, 2010

Folks, The 64-bit support is now more or less complete, and we have most of the fancy new icons, so it's time to think about the next stable release. Unless some major problems come up, 1.1.44 will be the last of the 1.1.x series. The next release will be 1.2-rc1, which will mark the beginning of the code freeze. This should result in a 1.2 final sometime in June. As usual the code freeze will become more and more drastic as we get closer to release, so if you have major changes to make, now is pretty much the last minute. I'd encourage everyone to look through the list of nominated 1.2 bugs, and also to check the regression reports for anything that might be in your area. We should strive to have as few regressions from 1.0 as possible, so regressions fixes will have priority during code freeze. And of course changes that don't impact the code, like translations or test fixes, can go in until quite late. -- Alexandre Julliard julliard(a)winehq.org

14 26

re: Advice about a new project, and similarity to Wine's start
by Dan Kegel June 6, 2010

June 6, 2010

Alessandro Pignotti wrote: > how did Wine choose the feature set to support first? Pragmatically - by trying to get particular popular apps running. (Starting with solitaire :-) > Did people use the early releases of Wine, even if they were missing features? Yes, as soon as they ran their favorite app. So in your case, as soon as your flash player can handle youtube.com (or whatever free software afficianados can't live without), a few people will start using it. > Is the AppDB software available for use on other projects? Should be. > Any misc advice? The Wine project started moving faster when we switched to test-driven development. I highly recommend it. Do you have a test suite? And/or can you share existing test suites ( e.g. http://wiki.gnashdev.org/Testcases ) ? That said, visual stuff is hard to test automatically, so mostly our automated tests only test the API level. Visual tests are done manually and much less often (say, only when changing directly affected code). Automated performance benchmarks are a good idea, though we haven't done as much of that. Good luck! - Dan

2 1

Advice about a new project, and similarity to Wine's start
by Alessandro Pignotti June 6, 2010

June 6, 2010

Hi everyone, first of all congratulations. The current maturity of Wine is really, really impressive. Thanks for your work. Let's introduce myself, I'm the author of the Lightspark project (http://lightspark.sf.net) a modern, open source, flash player implementation. The project is currently in a very good shape, featuring scripting support, a JIT compiler and OpenGL accelerated rendering. But, although the core VM is mostly complete, a huge part of the runtime library is still missing. I'm asking advice here because this is probably a condition similar to the one faced by early Wine developers. I'm currently pretty confused about the roadmap of my project. Although some interest gathered after the announcement of the 0.3.0 release and some bug reports appeared I've not yet managed to gather the needed community feedback. Moreover, beside supporting the most popular flash applications (e.g. YouTube, which is mostly supported), I've no idea about what to do later and how to prioritize features. So my question is: how did Wine choose the feature set to support first? Did people use the early releases of Wine, even if they were missing features? Is the AppDB software available for use on other projects? Any misc advice? Thanks a lot for your help. and sorry for the quite OT message, Alessandro Pignotti

2 1

Wine code comments
by John Voltz June 5, 2010

June 5, 2010

Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are using the block comment marker /*. This is a royal pain when trying to comment out large sections of code where there are a bunch of /* foo */ comments. Why is this allowed? Is there are way around it without having to change them all to //? Regards, John Voltz

6 8

Re: shdoclc: Add the Polish translation (try 2)
by Paul Vriens June 5, 2010

June 5, 2010

On 06/05/2010 01:38 PM, Łukasz Wojniłowicz wrote: > + MENUITEM "&Odœwie¿ > +", _IDM_REFRESH Hi Łukasz, Something went wrong here. -- Cheers, Paul.

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by Nikolay Sivov June 5, 2010

June 5, 2010

On 6/3/2010 23:35, Andrew Eikum wrote: > > This fixes a bug with Internet Explorer 6's Favorites menu. > > This function used to be named IUnknown_EnumObjects, so my guess is > that the original implementor thought it'd be wise to verify the type > of the object before executing IShellFolder's methods on it. Since > it's now called IShellFolder_EnumObjects and explicitly takes an > LPSHELLFOLDER parameter, I see no reason to do the typecheck. And where is a test for that? > > --- > dlls/shlwapi/ordinal.c | 19 +------------------ > dlls/shlwapi/tests/Makefile.in | 2 +- > dlls/shlwapi/tests/ordinal.c | 32 ++++++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+), 19 deletions(-)

2 9

Re: shdoclc: Add the Polish translation
by Paul Vriens June 5, 2010

June 5, 2010

On 06/04/2010 04:33 PM, Łukasz Wojniłowicz wrote: > + > +LANGUAGE LANG_POLISH, SUBLANG_NEUTRAL > + > +IDR_BROWSE_CONTEXT_MENU MENU Hi Łukasz, Sorry if I wasn't clearer before. You are having effectively two blocks with the same translations now. The reason the English resource file has two blocks is because it has effectively two translations (one for SUBLANG_DEFAULT and one for SUBLANG_NEUTRAL). There is no need to do that in most of the other resource files like Polish as there is only one Polish language (as far as resource files are concerned). Could you also add something to the Subject when resending? So for example "(Resend)" when sending the same patch again or "(Try x)" when you sent a new version of the patch. -- Cheers, Paul.

1 0

Wine on MIPS?
by André Hentschel June 5, 2010

June 5, 2010

Hi, i just read that MIPS is planning to get on the mobil market. It will be available in 4G Smartphones with Android. Wine has a MIPS port which should also run those obsolete Win32 MIPS Apps, so i guess the winelib side is more interesting. So here my question: did anyone recently tried to compile Wine on MIPS and did it worked? If not, is anybody able to? -- Best Regards, André Hentschel

1 0

Re: [1/2]wineps.drv: make use of MAKEINTRESOURCEW
by Dmitry Timoshkov June 4, 2010

June 4, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > +#define PAPER 99 > #define IDD_PAPERS 100 > #define IDD_ORIENT_PORTRAIT 101 > #define IDD_ORIENT_LANDSCAPE 102 You could try to find a less generic name for this. -- Dmitry.

1 0

Re: [2/2]wineps.drv: Import comctl32 instead of loading it
by Dmitry Timoshkov June 4, 2010

June 4, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > -IMPORTS = user32 gdi32 winspool advapi32 kernel32 > +IMPORTS = user32 gdi32 winspool advapi32 kernel32 comctl32 It's being loaded for a reason. You can make it delay loaded though. -- Dmitry.

1 0

Re: [PATCH] msi/tests: Fix install tests for Win9x
by testbot＠testbot.winehq.org June 4, 2010

June 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2470 Your paranoid android. === WNT4WSSP6 (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5411: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5430: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5455: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5474: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:3534: Test failed: Expected 314, got 1 install.c:8264: Test failed: RegQueryValueExA failed 2 (0)

1 0

Re: shdoclc: Add the Polish translation
by Paul Vriens June 4, 2010

June 4, 2010

On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL This doesn't look correct for Polish ;) -- Cheers, Paul.

1 0

Re: appwiz: Add the Polish translation
by Paul Vriens June 4, 2010

June 4, 2010

On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: > dlls/appwiz.cpl/Makefile.in | 1 + > dlls/appwiz.cpl/Pl.rc | 84 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 0 deletions(-) > create mode 100755 dlls/appwiz.cpl/Pl.rc Hi Łukasz, Wrong mode here. Should be the normal 100644 (like you other recent patches). -- Cheers, Paul.

1 0

Re: [PATCH 2/2] cmd: Update Dutch translation
by Frédéric Delanoy June 4, 2010

June 4, 2010

2010/6/2 Sven Baars <sven.wine(a)gmail.com> > --- > programs/cmd/Nl.rc | 194 > ++++++++++++++++++++++++++++----------------------- > 1 files changed, 106 insertions(+), 88 deletions(-) > Hi Sven, Some remarks: - You shouldn't change the line length as it makes the patch unnecessarily big, for no change in text (for the affected hunks) - "bestaat keert de controle terug naar het bestand dat het aanriep. DE CALL\n\" => "DE" should be "De" Frédéric

3 2

[RFC] advapi32 -- GetNamedSecurityInfo
by GOUJON Alexandre June 4, 2010

June 4, 2010

Hi, I'm trying to fix bug 18071 but I don't know anything about ACLs. I wrote some tests (see attached patch and https://testbot.winehq.org/JobDetails.pl?Key=2442) and I modified the source according to my understanding of the issue (wich may be totally wrong). But as I'm not familiar with ACLs and because my changes are quite important, I'm sending here my patches hoping a advapi32 coder could have a look at it. Thanks in advance

2 2

CUDA Wrapper err:module:import_dl
by Seth Shelnutt June 4, 2010

June 4, 2010

Alright, I'm stumped and everyone else is too. Few years ago we did everything we are doing now and it all worked fine. Now using wine 1.2rc2 we can't get a wrapper I compiled to work. What this wrapper does is it translates/wraps the calls made to the cuda runtime dll (cudart.dll or nvcuda.dll, same file different names) and sends it to the linux library. The linux library and windows are identical except for some missing dx functions in the linux library. My sources can be found here. http://shelnutt2.host56.com/cudart/ and http://shelnutt2.host56.com/cufft/(However we aren't even getting to the second dll yet). Anytime we try to run folding at home in wine, we are getting the following. FAH checks for nvcuda.dll first because that comes with the driver installs on windows, if it doesn't find it, it defaults to cudart.dll which is packaged with fah, or can be installed separately. We have replaced all the cuda dlls with the compiled wrapper or sum linked to the compiled wrapper, just like we use to with the original cuda wrapper that we came up with. err:module:import_dll Loading library nvcuda.dll (which is needed by L"Z:\\home\\sidicas\\.FAHGPU3\\FahCore_11.exe") failed (error c0000020). err:module:import_dll Loading library cudart.dll (which is needed by L"Z:\\home\\sidicas\\.FAHGPU3\\FahCore_11.exe") failed (error c0000020). sidicas(a)Belldandy:~/.FAHGPU3$ ls -al *.dll -rw-r--r-- 1 sidicas sidicas 1617920 2010-06-03 01:48 amdcalcl.dll -rw-r--r-- 1 sidicas sidicas 2486272 2010-06-03 01:48 amdcalrt.dll -rw-r--r-- 1 sidicas sidicas 124540 2010-06-02 07:50 cudart32_30_14.dll -rw-r--r-- 1 sidicas sidicas 124540 2010-06-02 07:50 cudart.dll -rw-r--r-- 1 sidicas sidicas 82699 2010-06-01 21:39 cufft32_30_14.dll -rw-r--r-- 1 sidicas sidicas 82699 2010-06-01 21:39 cufft.dll lrwxrwxrwx 1 sidicas sidicas 10 2010-06-03 02:12 nvcuda.dll -> cudart.dll sidicas(a)Belldandy:~/.FAHGPU3$ sidicas(a)Belldandy:~/.FAHGPU3$ uname -a Linux Belldandy 2.6.26-2-amd64 #1 SMP Sun Jun 21 04:47:08 UTC 2009 x86_64 GNU/Linux sidicas(a)Belldandy:~/.FAHGPU3$ nvcc --version nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2009 NVIDIA Corporation Built on Fri_Feb_19_18:18:31_PST_2010 Cuda compilation tools, release 3.0, V0.2.1221 sidicas(a)Belldandy:~/.FAHGPU3$ ldd ./cudart.dll linux-gate.so.1 => (0xf7ee3000) libcudart.so.3 => /usr/local/cuda/lib/libcudart.so.3 (0xf7e83000) libwine.so.1 => /usr/lib/libwine.so.1 (0xf7d2d000) libm.so.6 => /lib32/libm.so.6 (0xf7d09000) libc.so.6 => /lib32/libc.so.6 (0xf7bb6000) libdl.so.2 => /lib32/libdl.so.2 (0xf7bb2000) libpthread.so.0 => /lib32/libpthread.so.0 (0xf7b9b000) librt.so.1 => /lib32/librt.so.1 (0xf7b92000) libstdc++.so.6 => /usr/lib32/libstdc++.so.6 (0xf7aa4000) libgcc_s.so.1 => /usr/lib32/libgcc_s.so.1 (0xf7a97000) /lib/ld-linux.so.2 (0xf7ee4000) sidicas(a)Belldandy:~/.FAHGPU3$ sidicas(a)Belldandy:~/.FAHGPU3$ ldd ./cufft.dll linux-gate.so.1 => (0xf7f29000) libcufft.so.3 => /usr/local/cuda/lib/libcufft.so.3 (0xf7308000) libwine.so.1 => /usr/lib/libwine.so.1 (0xf71b2000) libm.so.6 => /lib32/libm.so.6 (0xf718e000) libc.so.6 => /lib32/libc.so.6 (0xf703b000) libdl.so.2 => /lib32/libdl.so.2 (0xf7037000) libpthread.so.0 => /lib32/libpthread.so.0 (0xf7020000) libcudart.so.3 => /usr/local/cuda/lib/libcudart.so.3 (0xf6fdf000) libstdc++.so.6 => /usr/lib32/libstdc++.so.6 (0xf6ef1000) libgcc_s.so.1 => /usr/lib32/libgcc_s.so.1 (0xf6ee4000) /lib/ld-linux.so.2 (0xf7f2a000) librt.so.1 => /lib32/librt.so.1 (0xf6eda000) sidicas(a)Belldandy:~/.FAHGPU3$ sidicas(a)Belldandy:~/.FAHGPU3$ More thorugh testing has been done, http://foldingforum.org/viewtopic.php?f=54&t=14673&start=105#p146177 . When we makes reference to gpu2 wrapper, that is our original cuda wrapper designed for cuda 2.0-2.2 built couple years ago. The GPU3 wrapper is what we are having problems with. It is our cuda 3.0 wrapper. The .dll files are in the folder (we even tried in system32), ldd shows they are properly linked, yet it does not work. If we use the old wrapper compile before it works fine with cuda 2.x or with cuda 3.0 we just have to sym link the cuda lib to the old name it's expecting. I've tried compiling the old wrapper and linking it to cuda 2.3 however this fails. So I am thinking that if when I compile the old wrapper which is shown to work (when an old compiled version is used) but does not work when I compile on my funtoo box it must be some weird compiling issue. I have wine installed (without 64bit support), and I installed cuda runtime from nvidia's site as the one in portage installs to /opt/ and I wanted to make sure there wasn't any weird issues linking with that. I do get a few warnings when I compile but they aren't anything that would effect this. s.shelnutt(a)funtoo-64 ~/gpu3/wrapper/cudart $ make winegcc -c -mno-cygwin -m32 -I/usr/local/cuda/include/ -o cudart.o cudart.c In file included from /usr/local/cuda/include/cuda_runtime_api.h:53, from /usr/local/cuda/include/crt/host_runtime.h:108, from cudart.c:7: /usr/local/cuda/include/host_defines.h:57:1: warning: "__cdecl" redefined <command-line>: warning: this is the location of the previous definition cudart.c: In function 'wine_cudaGetTextureReference': cudart.c:430: warning: passing argument 1 of 'cudaGetTextureReference' from incompatible pointer type /usr/local/cuda/include/cuda_runtime_api.h:189: note: expected 'const struct textureReference **' but argument is of type 'struct textureReference **' cudart.c: In function 'wine_cudaRegisterFatBinary': cudart.c:800: warning: return makes pointer from integer without a cast cudart.c: In function 'wine_cudaUnregisterFatBinary': cudart.c:805: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterVar': cudart.c:810: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterTexture': cudart.c:815: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterShared': cudart.c:820: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterSharedVar': cudart.c:825: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterFunction': cudart.c:831: warning: 'return' with a value, in function returning void winegcc -shared cudart.dll.spec -mno-cygwin -o cudart.dll.so cudart.o -L/usr/local/cuda/lib/ -lcudart -lodbc32 -lole32 -loleaut32 -lwinspool -lodbccp32 -luuid If anyone has any ideas about why this doesn't work, that would be great. I've exhausted everything I could think of. Thanks, Seth Shelnutt

2 1

Re: advapi32: Fix GetSecurityInfo with NULL descriptor
by testbot＠testbot.winehq.org June 4, 2010

June 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2467 Your paranoid android. === WNT4WSSP6 (32 bit security) === No test summary line found

1 0

Re: advapi32: Fix GetSecurityInfo with NULL descriptor (try2:typo)
by testbot＠testbot.winehq.org June 4, 2010

June 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2466 Your paranoid android. === WNT4WSSP6 (32 bit security) === No test summary line found

1 0

Re: [PATCH 3/3] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org June 3, 2010

June 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2454 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1770: Test failed: got 13 ordinal.c:1776: Test failed: got 27 ordinal.c:1791: Test failed: got 10 ordinal.c:1804: Test failed: got 13 ordinal.c:1812: Test failed: got 13 ordinal.c:1826: Test failed: got 27 ordinal.c:1834: Test failed: got 27 ordinal.c:1864: Test failed: got 22 ordinal.c:1875: Test failed: got 25 === W7PROX64 (32 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 34, length 35 ordinal.c:1853: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 34, length 35 ordinal.c:1853: Test failed: got 37

1 0

Re: [PATCH 2/3] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org June 3, 2010

June 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2453 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1769: Test failed: got 13 ordinal.c:1775: Test failed: got 27 ordinal.c:1790: Test failed: got 10 ordinal.c:1803: Test failed: got 13 ordinal.c:1811: Test failed: got 13 ordinal.c:1825: Test failed: got 27 ordinal.c:1833: Test failed: got 27 ordinal.c:1863: Test failed: got 22 ordinal.c:1874: Test failed: got 25 === W7PROX64 (32 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 34, length 35 ordinal.c:1852: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 34, length 35 ordinal.c:1852: Test failed: got 37

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by testbot＠testbot.winehq.org June 3, 2010

June 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2452 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1767: Test failed: got 27 ordinal.c:1817: Test failed: got 27 ordinal.c:1825: Test failed: got 27 ordinal.c:1833: Test failed: got 38, length 39 ordinal.c:1844: Test failed: got 41 === W7PROX64 (32 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 34, length 35 ordinal.c:1844: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 34, length 35 ordinal.c:1844: Test failed: got 37

1 0