June 2010 - Wine-Devel - list.winehq.org

Re: msi: Print more information on error
by Alexandre Julliard June 13, 2010

June 13, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > i had that case with > err:msi:ACTION_CallDllFunction GetProcAddress for function L"findApplications" in dll L"C:\\users\\dawncrow\\Temp\\msi94eb.tmp" failed > so you see that just the function is not info enough. I don't see that. The name of the temp file is not meaningful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Anotated 'make test' log
by Max TenEyck Woodbury June 13, 2010

June 13, 2010

I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A few reservations: * I started from the top of the log. If I continue, I will be selecting sections that I find interesting. * I am not going to produce patches until someone says that the annotations are going in the right direction. This will change when I become more familiar with the community's opinion of my efforts. ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so cred.c && touch cred.ok Note: This test is expected to produce 2 error reports call is pCredReadA(TEST_TARGET_NAME, -1, 0, &cred) implementation at dll/advavi32/cred.c - CredReadA parameter names: TargetName, Type, Flags, *Credentials conversion to CreadReadW implementation at same - CredReadW fixme:cred:CredReadW unhandled type -1 Fixup: Convert 'if (Type != CRED_TYPE_GENERIC && Type != CRED_TYPE_DOMAIN_PASSWORD)' to a switch(case?) with all known types enumerated. Put unimplemented types at the end with a 'fixup' then fall through to the default case which sets the error code and fails. Note: In other words, don't request fixup for improper type codes. call is pCredReadA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef, &cred) see above for details fixme:cred:CredReadW unhandled flags 0xdeadbeef Fixup: Get a list of all known flags. Build a mask for all of them. Check for any unknown flags set and issue a warning if there are any. Build a mask of all implemented flags (currently none) and issue a fixme if any of those are set. Note: In other words, don't request fixup for undefined flags set. Question: Should this be an failure exit? Alternatively, should there be a list of flags that, if set trigger a failure exit? Note: Only fail if the flags indicate an option that can not be ignored. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredWriteA(&new_cred, 0) implementation at same - CredWriteA parameter names: Credential, Flags new_cred.UserName = 'winetest' new_cred.TargetName = TEST_TARGET_NAME conversion to CredWriteW implementation at same - CredWriteW err:cred:CredWriteW bad username L"winetest" Note: This is an expected error. Note: Should it mention 'syntax' since it is checking for \ and @? Note: No bad flags test - Fixup per CredReadW above. Note: No bad type test - Fixup per CredReadW above. call is pCredWriteA(&new_cred, 0) see above for details. new_cred.UserName = NULL err:cred:CredWriteW bad username (null) Note: This is an expected error. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredDeleteA(TEST_TARGET_NAME, -1, 0) implementation at same - CredDeleteA parameter names: TargetName, Type, Flags conversion to CredDeleteW fixme:cred:CredDeleteW unhandled type -1 Fixup: see CredReadA above call is pCredDeleteA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef) se above for details. fixme:cred:CredDeleteW unhandled flags 0xdeadbeef fixup: see CreadReadA above Note: No sucess tests. Note: Test order is questionable. A better order would be Write, Read then Delete with tests that are expected to succeed added. call is pCredReadDomainCredentialsA(&info, 0, &count, &creds implementation at same - CredReadDomainCredentialsA parameter names: TargetInformation, Flags, *Size, **Credentials conversion to CredReadDomainCredentialsW fixme:cred:CredReadDomainCredentialsW (0x15ddf8, 0x0, 0x33fd18, 0x33fc4c) stub Fixup: No suggestion

1 0

re: WINE and demoscene products
by Dan Kegel June 12, 2010

June 12, 2010

Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks last year, it was very convincing. (Although, frankly, running retail DVD-ROM games on day of beta or release is an even more convincing feat if we can pull it off.) As somebody else pointed out, there are already appdb entries for quite a few demos: http://appdb.winehq.org/objectManager.php?sClass=category&iId=95 It'd be nice if someone filled in any missing ones there. (I'm not sure how much overlap there is between demos and real games, but the idea of a really small graphical app is appealing, one would expect they'd be easier to diagnose?) - Dan

2 1

Three year sever outstanding bug requiring minor fix
by velociraptor Genjix June 12, 2010

June 12, 2010

Hey, Please look into this issue, http://bugs.winehq.org/show_bug.cgi?id=15118 It seems like a fairly trivial fix which renders this application useless. A detailed description of the implementation needed is provided in that ticket. Thank you _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ Do you have a story that started on Hotmail? Tell us now

5 4

snoop,relay,trace
by Hin-Tak Leung June 12, 2010

June 12, 2010

I am thinking of going barbaric and doing WINEDEBUG=+relay,+snoop,+trace to see how mt.exe get the wrong image size in http://bugs.winehq.org/show_bug.cgi?id=22812 and just grep for the wrong/right sizes (0x "2b000", "176128", 0x "2b200", "176640" ) to see where mt gets it from but none turn up. Since it is a relatively simple command line I thought that would work. or is there any other WINEDEBUG= is worth trying? Also I am thinking since the image size is normally padded to 0x1000, (and it says so), so a PE with an image size that looks like NNNNN200 is automatically wrong, is that correct?

1 0

WINE and demoscene products
by Wolfram Sang June 12, 2010

June 12, 2010

Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine 1.2-rc2 was recently posted here [2]. Out of 25, 14 are flawless and 4 OK - pretty good numbers IMO. (BTW the demos can be downloaded using the search function of the website.) Regards, Wolfram [1] http://en.wikipedia.org/wiki/Demo_%28computer_programming%29 [2] http://pouet.net/topic.php?which=7400

1 0

Test suite success rate
by Peter Davies June 11, 2010

June 11, 2010

How do I get the test suite to report it success rate (as a whole) in a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. Peter

3 2

Re: gdi32: Add CreateFontIndirectEx implementation (try2)
by Alexandre Julliard June 11, 2010

June 11, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try2: function body moved to *Ex call, and CreateFontIndirect use it. You should also print FIXMEs if the ignored data is used by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

No test summary line found
by GOUJON Alexandre June 11, 2010

June 11, 2010

Hi, I'm wondering if my patch (62325) hasn't been reviewed yet or if you expect a strict error-free patch. Indeed, http://source.winehq.org/patches/data/62325.testfail shows a "No test summary line found" for WNT4WSSP6. If it's an issue, how to fix it ? Thanks

2 6

Re: [PATCH 2/5] include: Add IEnumShellItems interface declaration.
by Huw Davies June 11, 2010

June 11, 2010

On 11 Jun 2010, at 12:17, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/actxprxy/usrmarshal.c | 21 +++++++++++++++++++++ > include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/dlls/actxprxy/usrmarshal.c b/dlls/actxprxy/usrmarshal.c > index f2aacf8..85e534c 100644 > --- a/dlls/actxprxy/usrmarshal.c > +++ b/dlls/actxprxy/usrmarshal.c > + > +HRESULT CALLBACK IEnumShellItems_Next_Proxy( > + IEnumShellItems *This, > + ULONG celt, > + IShellItem **rgelt, > + ULONG *pceltFetched) > +{ > + TRACE("(%p)\n", This); > + return IEnumShellItems_RemoteNext_Proxy( This, celt, rgelt, > pceltFetched ); > +} pceltFetched could be a NULL ptr here, so you should pass the address of a local variable in that case. See ole32/usrmarshal.c for examples on how to marshal IEnum*_Next Huw.

1 0

Re: Updating Ukrainian translations to kernel32
by Dmitry Timoshkov June 11, 2010

June 11, 2010

Igor Paliychuk <igor-hkr(a)mail.ru> wrote: > Updating Ukrainian translations to kernel32(ukr.nls). > file : ukrainian-kernel32-ukr-nls.patch You forgot to mention what's wrong with current ukr.nls. -- Dmitry.

2 1

Re: gdi32: CreateFontIndirectEx implementation on top of CreateFontIndirect
by Alexandre Julliard June 11, 2010

June 11, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From fb4317a2a39475c225fe04946795892c4891cd26 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Fri, 11 Jun 2010 01:42:06 +0400 > Subject: [PATCH] CreateFontIndirectEx implementation on top of CreateFontIndirect It should of course be the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()
by Andrew Nguyen June 11, 2010

June 11, 2010

On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23003 > > -- > -Austin > > > > You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.

3 5

IDL trouble (patch: adding IEnumShellItems interface declaration.)
by David Hedberg June 11, 2010

June 11, 2010

Hello everyone, I'm having some trouble with this simple patch. Specifically, it breaks compiling of dlls/actxprxy, producing the message: ***** ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./actxprxy.spec usrmarshal.o actxprxy_activscp_p.o actxprxy_comcat_p.o actxprxy_docobj_p.o actxprxy_hlink_p.o actxprxy_htiframe_p.o actxprxy_objsafe_p.o actxprxy_ocmm_p.o actxprxy_servprov_p.o actxprxy_shobjidl_p.o actxprxy_urlhist_p.o dlldata.o -o actxprxy.dll.so -luuid -loleaut32 -lole32 -lrpcrt4 -lkernel32 -lntdll ../../libs/port/libwine_port.a -L/usr/local/valgrind-svn/lib actxprxy_shobjidl_p.o: In function `IEnumShellItems_RemoteNext_Stub': /home/david/Projects/wine/git/dlls/actxprxy/actxprxy_shobjidl_p.c:6507: undefined reference to `IEnumShellItems_Next_Stub' actxprxy_shobjidl_p.o:(.data.rel.ro+0xf0): undefined reference to `IEnumShellItems_Next_Proxy' ***** It compiles if I remove the [call_as] attribute, but I guess that would kind of break the interface. Any obvious mistakes in the patch, or grammar not supported by widl? Thanks, David --- include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 6bd0244..97cd82f 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -385,6 +385,36 @@ typedef enum tagNWMF { } NWMF; /***************************************************************************** + * IEnumShellItems interface + */ +[ + object, + uuid(70629033-E363-4A28-A567-0DB78006E6D7), + pointer_default(unique) +] +interface IEnumShellItems : IUnknown +{ + [local] HRESULT Next( + [in, annotation("__in")] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched), annotation("__out_ecount_part(celt, *pceltFetched)")] + IShellItem **rgelt, + [out, annotation("__out_opt __deref_out_range(0, celt)")] ULONG *pceltFetched); + + [call_as(Next)] HRESULT RemoteNext( + [in] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched)] IShellItem **rgelt, + [out] ULONG *pceltFetched); + + HRESULT Skip( + [in] ULONG celt); + + HRESULT Reset(); + + HRESULT Clone( + [out] IEnumShellItems **ppenum); +} + +/***************************************************************************** * FOLDERSETTINGS */ typedef char *LPVIEWSETTINGS; -- 1.7.1

2 1

Re: Three year sever outstanding bug requiring minor fix
by James Mckenzie June 11, 2010

June 11, 2010

velociraptor Genjix <aphidia(a)hotmail.com> wrote at Jun 9, 2010 8:52 AM > >Hey, >Please look into this issue, >http://bugs.winehq.org/show_bug.cgi?id=15118 >It seems like a fairly trivial fix which renders this application useless. A detailed >description of the implementation needed is provided in that ticket. If it were a 'trival' fix, it would have been a long time ago. Something that looks, on the surface, to be simple, maybe very complex. For instance, I have been working on a fix for one function in the richedit area has taken over four years. Now as to your concern, tough. This project, for the most part is volunteer. So, if you want it fixed, do it yourself or find someone who can. Otherwise, you'll have to wait for someone to come by, find this interesting and then fix it. There is a part of the project that is paid, and they work for a company called CodeWeavers. Maybe they have found a fix and incorporated it into their product line. That you'll have to pay for. Remember, we fix things as WE find the time and the incorporation process is very strict. This takes time and some folks will pick up a project, only to set it down because they become busy with other things in life or they just don't have the tenancity to see it through. James McKenzie

2 1

Re: [1/3] d3dx9: Allow sampler declaration without sampler type.
by Stefan Dösinger June 11, 2010

June 11, 2010

Am 10.06.2010 um 16:06 schrieb Matteo Bruni: > <0001-d3dx9-Allow-sampler-declaration-without-sampler-type.txt> The patch looks ok, but I am wondering if the validator complains about typeless samplers. And if not, I guess the interesting question is how those declarations are treated at shader runtime...

3 4

Re: resources: Convert Polish resources to UTF8.
by Frédéric Delanoy June 11, 2010

June 11, 2010

Hi. I see this patch has been "Rejected" in http://source.winehq.org/patches/, but I just wondered why: - are the UTF8 resources not preferred over custom codepages? - or is the patch simply too big to review? Splitting into many tiny patches seemed a bit overkill for such a simple change, no? Or maybe is it simply because Polish translations is still in progress, and it can/will cause conflict? I'm a bit confused here... Frédéric NB: I didn't touch any nls file in this patch so it shouldn't cause regressions (and had a subset of it tested by Łukasz Wojniłowicz, a native Polish speaker)

5 5

Tests crash
by Peter Davies June 11, 2010

June 11, 2010

Some tests crash for me (eg. http://bugs.winehq.org/show_bug.cgi?id=22903 segfaults). This means I can't run the entire test suite with "make test", what should I do? Peter

3 2

Re: [PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.
by Octavian Voicu June 11, 2010

June 11, 2010

Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861. Octavian

2 3

size_t usage in wine
by Marko Nikolic June 11, 2010

June 11, 2010

Hi, I have found in wine documentation that it is recommended to avoid long data type, since it is different in Win64 and Unix64. This is reasonable, however, is there some similar policy regarding size_t/ssize_t usage? Those types are often defined as long type, so they could produce the same problem with 64 bit. On the other hand, many standard functions expect or return size_t values, so I guess it could be ok to use it in such cases. Is there any advice/position on this? Thanks, Marko

2 1

"IWineGDISurfaceImpl_UnLoad: Please report to wine-devel"
by Marcin Baczyński June 10, 2010

June 10, 2010

Hi, running a simple game on wine-1.2-rc2-250-g950919e fails with "Interface not supported" message box and following messages in the terminal: $ ./wine ~/.wine/drive_c/Program\ Files/MarBit/Clicks/clicks.exe fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x146740,0x146b78): stub fixme:win:EnumDisplayDevicesW ((null),0,0x32f480,0x00000000), stub! fixme:d3d:swapchain_init Add OpenGL context recreation support to context_validate_onscreen_formats err:d3drm:IDirect3DRMImpl_QueryInterface (0x135678)->({4516ecc8-8f20-11d0-9b6d-0000c0781bc3},0x5a2e90),not found err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Please report to wine-devel fixme:d3d:IWineD3DDeviceImpl_Release (0x1e7a20) Device released with resources still bound, acceptable but unexpected fixme:d3d:IWineD3DDeviceImpl_Release Leftover resource 0x137d70 with type WINED3DRTYPE_SURFACE (0x1). The game can be downloaded here: http://marbit.com.pl/index.php?name=Downloads&req=getit&lid=1 Installation fails saying that it cannot create a shortcut, but the files get copied to the destination directory. Thanks, Marcin

1 0

Re: winefile: Update English resource for AUS, NZ and UK
by Michael Stefaniuc June 10, 2010

June 10, 2010

Hello Ken, Ken Sharp wrote: > Australian, British and New Zealand English prefers -ise over -ize > (strongly so in Aus and NZ). > > http://en.wikipedia.org/wiki/En-AU#Spelling > http://en.wikipedia.org/wiki/New_Zealand_English#Spelling if the translation is the same for UK, AU and NZ then please add only one copy of it and mark it as LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL That will do as the LANG_ENGLISH family will inherit first from SUBLANG_NEUTRAL and only if that doesn't exist from SUBLANG_DEFAULT. thanks bye michael

1 0

A Handle Cache?
by Max TenEyck Woodbury June 10, 2010

June 10, 2010

While Reading the developer's guide, I noticed that it said that translating windows' handles was always done by the server. I may have misunderstood this. Since interaction between the client and server requires at least two context switches and context switches are fairly heavy duty operations, would it make sense to cache handle lookups on the client?

2 1

gameux.dll implementation stub
by Mariusz Pluciński June 9, 2010

June 9, 2010

Hello As you maybe know, I'm working on implementation of Game Explorer in the Google Summer of Code. Main part of my work is now implementing gaming APIs stored in gameux.dll library. I already sent patches with headers, and I'm currently in the stage when stubs are ready to start real implementation. Unfortunately (for me) Wine is now in freeze stage, so I can't send patches with new library to wine-patches. Instead, Vincent Povirk suggested me to send them here to get feedback. It's very important to me to know is my way of implementation valid, cause changing something now is probably easier than modifying it in future. Attached patches creates initial implementation of gameux library, adds implementation of IClassFactory interface and stubs of four interfaces' implementations: IGameExplorer, IGameExplorer2, IGameStatistics and IGameStatisticsMgr. They also add initial tests for each interface. Each test now checks behavior of CoCreateInstance function while trying to create given interface. To create library, I used parts of code created by Alistair Leslie-Hughes, attached by him to bug 21261. Thanks in advance

3 2

Call for translators
by Paul Vriens June 9, 2010

June 9, 2010

Hi, The code freeze for Wine-1.2 has started and we are now in a weekly release candidate cycle. This is an ideal moment for translation work. The current translations status page http://source.winehq.org/transl/index.php shows four (4) languages at a 100%. Please help us have more fully translated languages for Wine-1.2. Also fixing the errors in the translations (21 languages affected) would be greatly appreciated. Most translators are not programmers and are probably intimidated by Wine's translation system. If you are comfortable editing resource file than please go ahead, create patches and sent them to wine-patches. The wiki-page http://wiki.winehq.org/Translating gives some more background information if needed. If you like to help out Wine but don't want to touch any of these resource files we can help you out. Please sent us an email with the language you'd like to translate Wine into and we will sent you the more familiar po files. These files show all the translatable strings from a resource file but in a less intriguing format. Once translated, you can sent these files back and we will turn them into the proper resource files. 'We' for now are Michael Stefaniuc and Paul Vriens but I guess others will chime in if needed. -- Cheers, Paul.

7 21