June 2010 - Wine-Devel - list.winehq.org

Re: Change a malloc() to a HeapAlloc()
by Peter Davies June 9, 2010

June 9, 2010

> We use real names here. This patch probably will not be committed until it > is resubmitted. Ops! I've mis-configured my mail client > The patch is also wrong. Why? What difference does malloc() over HeapAlloc() make? (this is arguably a case for not sending the patch in the first place) There is nothing that bugs me more than not being told why I'm wrong. Peter

3 2

Re: [PATCH] [WinHelp]: implemented ExecFile macro (fix for #23054)
by Alexandre Julliard June 9, 2010

June 9, 2010

Eric Pouech <eric.pouech(a)orange.fr> writes: > +static void CALLBACK MACRO_ExecFile(LPCSTR pgm, LPCSTR args, LONG cmd_show, LPCSTR topic) > { > - WINE_FIXME("(\"%s\", \"%s\", %u, \"%s\")\n", str1, str2, u, str3); > + static HINSTANCE (WINAPI *shell_exec)(HWND, LPCSTR, LPCSTR, LPCSTR, LPCSTR, INT); > + HINSTANCE ret = 0; > + > + WINE_TRACE("(\"%s\", \"%s\", %u, \"%s\")\n", pgm, args, cmd_show, topic); > + if (!shell_exec) > + { > + HANDLE h; > + > + if ((!(h = GetModuleHandle("shell32.dll")) && !(h = LoadLibraryA("shell32.dll"))) || > + !(shell_exec = (void*)GetProcAddress(h, "ShellExecuteA"))) > + { > + WINE_ERR("Couldn't load shell32.ShellExecute\n"); > + } > + } Why not call ShellExecuteA directly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by Marco Meijer June 9, 2010

June 9, 2010

Hi WineDevs, I made the patch to change the text on winehq and sent it to wine-patches but still no change. Do I have to do something else ? link to patch: http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html kind regards, Marco Meijer http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html Op 6-5-10 17:57, James Mckenzie schreef: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

2 1

Re: [1/3] msi: Create directories right before installing files.
by testbot＠testbot.winehq.org June 9, 2010

June 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2538 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5408: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5427: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5452: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5471: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8261: Test failed: RegQueryValueExA failed 2 (0) install.c:9173: Test failed: got 6 expected 0 install.c:9179: Test failed: got 6 expected 0 install.c:9182: Test failed: got 6 expected 0 install.c:9184: Test failed: file removed install.c:9329: Test failed: key not created

1 0

wine in the news in spain
by Dan Kegel June 9, 2010

June 9, 2010

Saw this just now: http://www.osor.eu/news/es-zaragozas-move-to-complete-open-source-desktop-g… "Zaragoza's move to complete open source desktop going to plan by Gijs Hillenius — published on Jun 08, 2010 The move by the city of Zaragoza to an open source desktop is making good progress. All of the city's civil servants now use open source tools including Thunderbird, VLC, Firefox and OpenOffice. And this year some seven hundred of the city's 2800 desktop PCs will have seen their proprietary operating system replaced by the Linux open source alternative. ... "It is not possible to move all applications to the open source platform. For example tools for Computer Aided Design and Optical Character Recognition, can't be replaced by open source alternatives. But proprietary and open source software can live together. And if we really can't find an open source option, we resort to Virtualbox and Wine to provide users their proprietary application." ... Their web site does mention a bit about wine, too: http://zaragozaciudad.net/azlinux/2009/septiembre.php (autotranslated): "24/09/2009 How we use WINE ... Microsoft Access: Access we have hundreds of applications that lack of time and means we can not migrate to an Open Source environment. WINE can emulate many of them even though the code should be reviewed, compiled and compacted again. A particular case is still unresolved are the Access applications that generate a mail merge with Word documents. OCR: for now we have not found an efficient alternative to the use of OCR software that "emulate" Windows OCR software with WINE Transactional environment: the client for our transactional environment is old and only works for Windows environments so that the use of WINE has been indispensable In contrast we must also say that some applications could not be emulated with WINE as Presto or Nokia PC Suite. So far WINE has not been useful to emulate CAD applications. In conclusion we can say that WINE is a useful tool in some cases and allows us to move forward in the migration to Open Source environment as alternatives to proprietary software are available and the height of these." Hmm, I wonder what "Presto" is, and which CAD suites they use. - Dan

2 1

Re: Change a malloc() to a HeapAlloc()
by James McKenzie June 9, 2010

June 9, 2010

Ultra two wrote: > --- > We use real names here. This patch probably will not be committed until it is resubmitted. James McKenzie

2 1

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel
by Joel Holdsworth June 8, 2010

June 8, 2010

On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > programs/winecfg/Bg.rc | 19 +++++---- > programs/winecfg/Cs.rc | 19 +++++---- > programs/winecfg/Da.rc | 19 +++++---- > programs/winecfg/De.rc | 19 +++++---- > programs/winecfg/En.rc | 19 +++++---- > programs/winecfg/Es.rc | 19 +++++---- > programs/winecfg/Fi.rc | 19 +++++---- > programs/winecfg/Fr.rc | 19 +++++---- > programs/winecfg/Hu.rc | 19 +++++---- > programs/winecfg/It.rc | 19 +++++---- > programs/winecfg/Ja.rc | 19 +++++---- > programs/winecfg/Ko.rc | 19 +++++---- > programs/winecfg/Lt.rc | 19 +++++---- > programs/winecfg/Nl.rc | 19 +++++---- > programs/winecfg/No.rc | 19 +++++---- > programs/winecfg/Pl.rc | 19 +++++---- > programs/winecfg/Pt.rc | 32 +++++++------- > programs/winecfg/Ro.rc | 19 +++++---- > programs/winecfg/Ru.rc | 19 +++++---- > programs/winecfg/Si.rc | 19 +++++---- > programs/winecfg/Sv.rc | 19 +++++---- > programs/winecfg/Tr.rc | 19 +++++---- > programs/winecfg/Zh.rc | 38 +++++++++-------- > programs/winecfg/about.c | 88 +++++++++++++++++++++++++++++++++++++++++ > programs/winecfg/idb_wine.bmp | Bin 14614 -> 0 bytes > programs/winecfg/resource.h | 7 +++- > programs/winecfg/winecfg.rc | 4 +- > 27 files changed, 342 insertions(+), 226 deletions(-) > delete mode 100644 programs/winecfg/idb_wine.bmp Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?

4 5

Two enhancement requests for winetricks
by Jan Hoogenraad June 8, 2010

June 8, 2010

I cannot access the login to Google (Google won't let me for some technical reason) , into http://code.google.com/p/winezeug/issues/list so I use this mail list to report 2 enhancement requests 1) Can winetricks also include a REMOVE script for each of the tricks ? It seems that a user is now advised to remove some (for the user often illogical) files in the windows directories. This is error prone, and lags the nice installation interface. 2) Can winetricks also include a status check for each of the tricks ? This could be as simple as checking if the files provided by wine have the latest wine time stamp and/or version signature. Alternately, a list of installed (by the UI selected) tricks can be provided. Each debugging request for wine states that I should remove all winetricks. However I have no way to tell, and no way to safely remove them. For example, my ~/.wine/drive_c/windows/sys*/* contains the files below, for which I suspect a wine trick, based on the time stamp. However, they may also be installed by some piece of windows software that I have installed. Thus, simply removing them does not make sense to me. Could somebody file this request in the issue database for me ? ------------------- 1032 2010-04-25 12:00 system32/ngen.exe 10204 2010-04-25 12:00 system32/view.exe 210420 2010-04-25 12:00 system32/cmdlgtst.exe 924432 2008-10-06 23:30 system32/MFC40.DLL 499712 2008-10-06 23:30 system32/msvcp71.dll 348160 2008-10-06 23:30 system32/msvcr71.dll 326656 2008-10-06 23:30 system32/MSVCRT40.DLL 492304 2008-10-06 23:30 system32/OLEAUT32.DLL 258352 2008-10-06 23:30 system32/unicows.dll 21936 2008-10-06 23:30 system32/help.exe 995383 2008-10-06 23:30 system32/MFC42.DLL 70656 2008-10-06 23:30 system32/MSVCIRT.DLL 195124 2008-10-06 23:30 system32/wcmd.exe 322832 2008-10-06 23:30 system/mfc30.dll 921872 2008-10-06 23:30 system/mfc40.dll 696 2003-12-04 16:07 system32/jetodbc.rsp 60224 2003-12-03 09:56 system32/odbcji32.dll 621104 2003-12-02 15:00 system32/mswstr10.dll 158256 2003-12-02 14:59 system32/msjint40.dll 354864 2003-11-12 13:17 system32/msjetoledb40.dll 559656 2003-11-12 13:17 system32/msrepl40.dll 326184 2003-11-12 13:16 system32/msexcl40.dll 1514024 2003-11-12 13:16 system32/msjet40.dll 354856 2003-11-12 13:16 system32/mspbde40.dll 285224 2003-11-12 13:16 system32/odbcjt32.dll 248360 2003-11-12 13:16 system32/msjtes40.dll 354856 2003-11-12 13:16 system32/msxbde40.dll 264744 2003-11-12 13:16 system32/mstext40.dll 27464 2003-11-12 13:15 system32/odexl32.dll 27464 2003-11-12 13:15 system32/odtext32.dll 27464 2003-11-12 13:15 system32/oddbse32.dll 27464 2003-11-12 13:15 system32/odfox32.dll 27464 2003-11-12 13:15 system32/odpdx32.dll 838240 2003-06-02 10:15 system32/mswdat10.dll 518752 2003-06-02 10:15 system32/msexch40.dll 428640 2003-06-02 10:15 system32/msrd2x40.dll 387680 2003-06-02 10:14 system32/expsrv.dll 322144 2003-06-02 10:14 system32/msrd3x40.dll 219744 2003-06-02 10:14 system32/msltus40.dll 60000 2003-06-02 10:14 system32/msjter40.dll 37472 2003-06-02 10:14 system32/vbajet32.dll 322832 2000-02-29 02:39 system32/MFC30.DLL -- Jan Hoogenraad

1 0

Re: gameux.dll implementation stub
by James Mckenzie June 8, 2010

June 8, 2010

Mariusz Pluciński <vshader(a)gmail.com> wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm currently in the stage when stubs are ready to >start real implementation. > To prevent some of us out here from thinking you sent your patches to the wrong place, could you preface the subject of your messages like this one with RFC: That will allow us to run the patches and look closely at them to give them a critical review. Also, you can still submit your patches, it looks like Alexandre committed the first two and might commit the remaining three you submitted. Lastly, it looks like Release Candidate three for Wine 1.2 will be out on Friday and this may be the last one before the final release. James McKenzie

1 0

Re: Implement ID3DXConstantTable::GetConstantDesc
by testbot＠testbot.winehq.org June 8, 2010

June 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2526 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

msvcrt printf test failed on NT4,win95
by Thomas Heckel June 8, 2010

June 8, 2010

Hi Alexander, I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d "Proberly skip if functions are not available" made test errors on NT4 and Win95 test instead of a skip while it works on newer windows platforms as expected. Could this be the case because GetModuleHandle and these failing platforms are not widechar compatible? So maybe it needs using GetModuleHandleA? kind regards Thomas

3 3

Re: kernel32: CopyFile cannot overwrite a file with itself (try 2)
by Alexandre Julliard June 8, 2010

June 8, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * kernel32: CopyFile cannot overwrite a file with itself This breaks a number of things, particularly msi. It would need much more detailed tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regedit: use binary mode when doing file import/export (try 2)
by Alexandre Julliard June 8, 2010

June 8, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * regedit: use binary mode when doing file import/export I don't think it will work properly for output. -- Alexandre Julliard julliard(a)winehq.org

1 0

Making AppDB look nice
by Alexandru Băluț June 8, 2010

June 8, 2010

Hi, I think the AppDB pages look bad, and I want to spend some time to make them look better. For example: - In the page that shows a version of an application, the background color in the list of test results depends on the rating of each test result, and it looks very messy, that rating color should be used somehow only in the Rating column. - More generally, get rid of the colored gray background colors, and eventually use discrete alternate colors like Bugzilla when listing bugs. - Get rid of the whole-row clicking, for example in the Top-10 tables in the first page, because it works weird when you middle-click. (This is more than improving looks, but still, it's on my TODO list) If you have specific suggestions on how to make the AppDB pages look better, and consistent with the rest of the winehq sites, please tell me. Thanks, Alex

1 0

Re: Track the number of audio bytes played as a 64 bit number
by Maarten Lankhorst June 7, 2010

June 7, 2010

Hello Dmitry, 2010/6/7 Dmitry Baryshev <ksquirrel.iv(a)gmail.com>: > Make wine-1.1.43 track the number of audio bytes played as a 64 bit number > rather than a 32 bit number to avoid overflows. It may happen happen on > constantly used audio content, possibly causing inbound voice to stop > working > in some voice applications. Please send patches in the format "module: Description", and your patch mangled the tabs in winealsa :) Likely other patches are affected too. Cheers, Maarten

1 0

Gecko64 status
by Jacek Caban June 7, 2010

June 7, 2010

Hi all, I'd like to share with you progress on gecko64. First of all, I think that it was never said in public, although I've been asked about it: there won't be gecko64 for 1.2 release. I think we will have Gecko release in the second half of this year it will support 64-bit, but it's not yet clear when exactly. We may try to do it near the next Firefox release, but time will show how it will work. However, it doesn't mean that nothing is going on around Wine Gecko. I've recently switched to mingw-w64 for 32-bit builds. I've very pleased with it. They are far better in co-operation, don't have senseless politics like mingw and their quality of headers and libraries is far better. We won't need to maintain fixes to build envinonment anymore. (I've been even talking about better co-operation between our projects, but that's OT here and I will report progress when there will be more to say). We're much nearer to allow packagers to build their own Gecko now. Back to gecko64, I've completed the first step. I have a working 64-bit Firefox crosscompiled with mingw-w64. See: https://bugzilla.mozilla.org/show_bug.cgi?id=570342 for details. It starts and runs on Windows. Now I wait for patches to be committed to Mozilla. It may take awhile :/ Before we may think about support for gecko64 in MSHTML, we have to fix its issues in Wine. Firefox is a good Gecko test and it needs to be fixed first. Unfortunately it currently doesn't even start. I've put a build on server in case anyone would like to try it: http://gerwazy.lo3.wroc.pl/~jcaban/wine/firefox-mingw-w64.tar.bz2 Volunteers on working on Wine side are very welcomed. There are also some other tests from Mozilla code. Note that before fixing any more sophisticated bug, it's worth to make sure on Windows, that the bug is in Wine, not in the build. All I verified is that Firefox should start and basic functionality works (and doesn't work on Wine). Any comments and suggestions are welcomed. Cheers, Jacek

6 9

Re: [3/5] gameux: Add declaration of IGameStatistics interface (try 2)
by Alexandre Julliard June 7, 2010

June 7, 2010

Mariusz Pluciński <vshader(a)gmail.com> writes: > [ > + object, > + uuid(3887C9CA-04A0-42ae-BC4C-5FA6C7721145) > + ] > + interface IGameStatistics : IUnknown > + { > + HRESULT GetCategoryTitle([in] WORD categoryIndex, > + [out, optional] LPWSTR* pTitle); > + > + HRESULT GetLastPlayedCategory([out] UINT* pCategoryIndex); > + > + HRESULT GetMaxCategories([out] WORD* pMax); > + > + HRESULT GetMaxCategoryLength([out] UINT* cch); > + > + HRESULT GetMaxNameLength([out] UINT* cch); > + > + HRESULT GetMaxStatsPerCategory([out] WORD* pMax); > + > + HRESULT GetMaxValueLength([out] UINT* cch); > + > + HRESULT GetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [out, optional] LPWSTR* pName, > + [out, optional] LPWSTR* pValue); > + > + HRESULT Save([in] BOOL trackChanges); > + > + HRESULT SetCategoryTitle([in] WORD categoryIndex, > + [in] LPCWSTR title); > + > + HRESULT SetLastPlayedCategory([in] UINT categoryIndex); > + > + HRESULT SetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [in, optional] LPCWSTR name, > + [in, optional] LPCWSTR value); This doesn't match the PSDK. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 3)
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2512 Your paranoid android. === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 2)
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2510 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: kernel32: CopyFile cannot overwrite a file with itself
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2509 Your paranoid android. === W98SE (32 bit file) === file.c:603: Test failed: copying a file to itself didn't fail (ret=0, err=80)

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests
by testbot＠testbot.winehq.org June 7, 2010

June 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2508 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 registry.c:2009: Test failed: could not create guid key, error 6 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: [7/7] msvcrt/test: Add some simple _vsnwprintf_s tests. (try 2)
by Austin English June 7, 2010

June 7, 2010

On Sun, Jun 6, 2010 at 11:36 PM, Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> wrote: > try 2: todo_wines removed since _vsnwprintf_s is fixed by patch 5. The todo_wine's need to be removed in the same patch in which they are fixed, otherwise, the tests will "fail". -- -Austin

2 2

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Andrew Nguyen June 6, 2010

June 6, 2010

I hate to nitpick once more, but there are a few things I noticed. My alsa-lib tells me: include/pcm.h:int snd_pcm_recover(snd_pcm_t *pcm, int err, int silent); Therefore, the statement "int ret = snd_pcm_recover(NULL, NULL, NULL);" is somewhat incorrect. Secondly, I think it should be sufficient to drop the AC_COMPILE_IFELSE macro entirely. The purpose in the original test was to distinguish between the version supplied in ALSA 0.9.x and ALSA 1.x, so, while I don't feel strongly about the matter either way, just checking for the existence of the function should be sufficient, as is done in other tests.

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Marcus Meissner June 6, 2010

June 6, 2010

On Sun, Jun 06, 2010 at 02:21:33PM -0500, Austin English wrote: > -- > -Austin > diff --git a/configure.ac b/configure.ac > index 21c0203..46ac100 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1,4 +1,4 @@ > -dnl Process this file with autoconf to produce a configure script. > +/dnl Process this file with autoconf to produce a configure script. Bad. Ciao, Marcus

1 0

Running tests on wine
by GOUJON Alexandre June 6, 2010

June 6, 2010

Hi, I would like to do some (typelib) tests on wine. So I followed the instructions at http://www.winehq.org/docs/winedev-guide/testing-wine ( cd dlls/oleaut32/tests/ ; rm typelib.ok && make typelib.ok in my case) but I have err's and fixme's whereas the output on wineTestBot is quite different (http://test.winehq.org/data/9aa9a1229f2195a8b3ac575645a10242ae6e9bc8/wine_n…) I tried WINETEST_DEBUG=1 make typelib.ok but it's the same output. Am I missing something ? Thanks

3 3