June 2010 - Wine-Devel - list.winehq.org

Addition of En resources to non-En resources
by Frédéric Delanoy July 2, 2010

July 2, 2010

Sometimes, when a developer adds a string to En resource file, (s)he adds it as well to all other non-En resource files. Isn't that unnecessary? http://wiki.winehq.org/SublangNeutral says the search order is 1. LANG_NEUTRAL, SUBLANG_NEUTRAL 2. LANG_FRENCH, SUBLANG_FRENCH_BELGIAN 3. LANG_FRENCH, SUBLANG_NEUTRAL 4. LANG_ENGLISH, SUBLANG_ENGLISH_US Would a patch removing En resources in non En rc files be accepted? This would allow for more accurate translation stats. Or doesn't a fallback mechanism always apply? Frédéric

8 25

Re: (Resent) Documentation - Reference to MSDN?
by James Mckenzie July 2, 2010

July 2, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: > >Erich Hoover <ehoover(a)mines.edu> writes: > >> Alright, well then I won't do it. Is the existing documentation going >> to be stripped at some point? It seems to me like we would benefit >> from more-detailed function descriptions in the auto-generated API >> documentation. I think it would save a lot of time for new developers >> to get their feet wet if they were able to see directly in the source >> what the different functions are supposed to do (as best as we know) >> and exactly what applications will trigger known edge cases (or if >> there's a test for a given situation). > >That's what the source code and test cases are for. If you rely on the >function documentation you are in trouble anyway, nobody bothers to >update it when new behaviors are discovered. > >If you really want to write good API documentation, as opposed to the >current useless one-sentence-per-parameter description, you'd need >probably a text 10 times the size of the source code for each >function. That can't go in the source files. > How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedit tests) as well. This would help greatly in our progress towards current and future implementations of the Windows API. And I agree, adding all of this to the source would make it unwieldy. James McKenzie

5 7

Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 2, 2010

July 2, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

3 2

(Resent) Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 1, 2010

July 1, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

9 17

Creating tests with additional binary modules
by Mariusz Pluciński July 1, 2010

July 1, 2010

Hi, wine-devel I'm working on implementation of Windows Game Explorer interfaces for Wine. The work is in advanced stage now, but I have problem with implementation of conformance tests. Thing I want to test is loading and parsing so-called Game Definition Files. GDF are not separate files, but stored as resources in binary modules (usually in game's main executable). Using GE interfaces, programmer only needs to pass path to binary, and GE automatically loads and process embedded GDF(s). Checking results of routines execution is not problem for me. But thing I test is parser, so I need to pass various GDF files to routine. And, as GDFs are stored in binaries, I will need to create many binaries. They should be created in compile time and available for test's executable while running it. The problem is that I don't know how to do this using wine's mechanisms. How should Makefile.in file look to build additional executable files properly (they should be probably always native win32 executables, even if parameter "crosstest" wasn't specified)? How should I guarantee that these additional executables will be copied into winetest directory (to make them accessible while executing tests)? Thanks in advance Mariusz Pluciński

5 8

updating spec files - which windows version to use?
by Austin English July 1, 2010

July 1, 2010

Howdy, I was looking at http://bugs.winehq.org/show_bug.cgi?id=23421, and wanted to add a stub for it. Using winedump on a Windows 7 shlwapi.dll gives different exports than Windows XP SP3 shlwapi.dll. Which dll should the spec file be updated to match? I'm assuming the latest and greatest, since eventually applications will head that direction. An additional related question. Some of the functions that are ordinals in previous Windows versions are now exported (e.g., ParseUrlA/W seems to have been documented/exported since Vista). Should the spec file be adjusted to match the newer behavior? I'm assuming this will have to wait until after 1.2 to be applied... Thanks! Austin

2 1

Re: [tools/wine.desktop] Add czech translation
by Nikolay Sivov June 30, 2010

June 30, 2010

On 7/1/2010 02:20, Scott Ritchie wrote: > Translation by Sven Augustin > @@ -20,7 +21,12 @@ Name[sr]=Wine - аДаИаЗаАб� Windows аПб�аОаГб�аАаМаА > Name[sr(a)latin]=Wine - dizaФ� Windows programa > Name[hr]=Wine - dizaФ� Windows programa > Exec=wine start /unix %f > +<<<<<<< HEAD > MimeType=application/x-ms-dos-executable;application/x-msi;application/x-win-lnk;application/x-ms-shortcut > +======= > +MimeType=application/x-ms-dos-executable;application/x-msi;application/x-win-lnk; > +>>>>>>> tools/wine.desktop: add Icon=wine to support systems with an icon theme > Icon=wine > NoDisplay=true > StartupNotify=true > + Conflicts?

2 1

Re: (Resent) Documentation - Reference to MSDN?
by James Mckenzie June 30, 2010

June 30, 2010

Erich Hoover <ehoover(a)mines.edu> wrote: >Sent: Jun 30, 2010 12:43 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Alexandre Julliard <julliard(a)winehq.org>, Max TenEyck Woodbury <max(a)mtew.isa-geek.net>, wine-devel(a)winehq.org >Subject: Re: (Resent) Documentation - Reference to MSDN? > >On Wed, Jun 30, 2010 at 1:36 PM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> ... >> How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedit tests) as well. This would help greatly in our progress towards current and future implementations of the Windows API. >> >> And I agree, adding all of this to the source would make it unwieldy. >> > >So something like "http://wiki.winehq.org/WineAPI/<DLL>/<Function>" ? >If that's acceptable I would not mind a system like that, especially >if the links of documented functions are provided in the source. >Documenting these things is a lot of work, so I'm not about to run off >and do all that work if no-one is ever going to take advantage of it. > +1 Acceptable variables should be listed in an order other than the one on MSDN. We don't want a direct copy, but rather OUR findings using the old 'black box' method. James McKenzie

1 0

Re: add russian translation for winerrs messages [try2]
by Dmitry Timoshkov June 30, 2010

June 30, 2010

Vitaly Lipatov <lav(a)etersoft.ru> wrote: > +LanguageNames=(RUS=0x19:winerr) > +CodePages=(FRA=65001:0) 'FRA'? This doesn't look correct. -- Dmitry.

3 3

Re: user32: Recurse into WS_EX_CONTROLPARENT controls in GetDlgItem
by Dmitry Timoshkov June 30, 2010

June 30, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > This fixes bug 22862 which blocks bug 12804 (1.2) > We already do a similar recursion in DEFDLG_FindDefButton and GetNextDlgGroupItem > > I didnt found any other changes in the tests... i expected some more "Test succeeded inside todo block" You need to add explicit tests for GetDlgItem() inside of user32/tests. -- Dmitry.

1 0

Re: user32/tests: Use if(0) instead of a comment to make sure code still compiles
by testbot＠testbot.winehq.org June 29, 2010

June 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3023 Your paranoid android. === W7PRO (32 bit msg) === msg.c:9516: Test failed: wrong qstatus 00110011 msg.c:9523: Test failed: wrong qstatus 00190008 msg.c:9529: Test failed: wrong qstatus 00390020 msg.c:9538: Test failed: wrong qstatus 00790040 msg.c:9559: Test failed: wrong qstatus 00390000 msg.c:9567: Test failed: wrong qstatus 00790040 msg.c:9578: Test failed: wrong qstatus 00390000 msg.c:9589: Test failed: wrong qstatus 00310000 msg.c:9594: Test failed: PeekMessageA should have returned FALSE instead of msg 0113 === W7PROX64 (64 bit msg) === Timeout

1 0

Re: wininet: fix the handling of insufficient buffers in InternetGetCookie*()
by testbot＠testbot.winehq.org June 29, 2010

June 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3020 Your paranoid android. === W98SE (32 bit internet) === internet.c:440: Test failed: A=B present internet.c:442: Test failed: E=F present internet.c:444: Test failed: I=J present internet.c:445: Test failed: K=L present internet.c:452: Test failed: A=B present internet.c:454: Test failed: E=F present internet.c:456: Test failed: I=J present internet.c:457: Test failed: K=L present internet.c:1158: Test failed: Retrieved proxy server should've been L"proxy.example", was: L"\0001\a000\2684X\0fb4h\0200" internet.c:1164: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1192: Test failed: Retrieved flags should've been PROXY_TYPE_DIRECT, was: 5767180 internet.c:1195: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1222: Test failed: Retrieved flags should've been PROXY_TYPE_PROXY | PROXY_TYPE_DIRECT, was: 5767180 internet.c:1225: Test failed: Expected regtype to be REG_DWORD, was: 3 === W2KPROSP4 (32 bit internet) === internet.c:440: Test failed: A=B present internet.c:442: Test failed: E=F present internet.c:444: Test failed: I=J present internet.c:445: Test failed: K=L present internet.c:452: Test failed: A=B present internet.c:454: Test failed: E=F present internet.c:456: Test failed: I=J present internet.c:457: Test failed: K=L present === WXPPROSP3 (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === WVISTAADM (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W2K8SE (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PRO (32 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PROX64 (32 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PROX64 (64 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122}

1 0

Using string resources in conformance tests.
by Michael Mc Donnell June 29, 2010

June 29, 2010

Hi wine developers! I've written a conformance test (my first) for bug 17986: BrsFolder_OnCommand make new folder not implemented. The conformance test tests if clicking on the "Make New Folder" button in a SHBrowseForFolder dialog box results in creation of a new folder. I want the test to be localized and work across all newer versions of Windows, but I'm having trouble with it. I use the LoadString function to get the "New folder" string from shell32.dll that is used for creating a new folder. The problem is that the location where it is stored in shell32.dll varies between the different versions of Windows. I can only make the test work on one version at a time. Even the capitalization varies between the different versions of Windows, i.e. "New Folder" vs. "New folder". My question is how should we handle a problem like the one mentioned above? Should we avoid using string resources in conformance test, or should we try to handle the version issues? One solution would be to hard code the string instead of loading it from a resource. This would, however, mean that the test would be skipped on all non-English versions of windows, and it would additionally have to ignore the capitalization differences. Another solution would be to get the string according to the version of Windows. This would, however, pose a problem in wine because it does not emulate any specific Windows version. The location of the string in wine's shell32.dll does not match any version of Windows, and we would therefore also have to detect if the test is running on wine. Has anyone bumped into the same problem, or does anyone know a thread about this on wine-devel? Do you have any comments on what to do? Thanks, Michael Mc Donnell

2 2

Re: [2/2] urlmon: implement HlinkSimpleNavigateToMoniker
by Jacek Caban June 29, 2010

June 29, 2010

On 6/28/10 9:17 PM, André Hentschel wrote: > --- > dlls/urlmon/umon.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c > index e122e07..12b1b0c 100644 > --- a/dlls/urlmon/umon.c > +++ b/dlls/urlmon/umon.c > @@ -734,8 +734,12 @@ HRESULT WINAPI HlinkSimpleNavigateToMoniker(IMoniker *pmkTarget, > LPCWSTR szLocation, LPCWSTR szTargetFrameName, IUnknown *pUnk, > IBindCtx *pbc, IBindStatusCallback *pbsc, DWORD grfHLNF, DWORD dwReserved) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + URLMoniker *This = MONIKER_THIS(iface); You can't do this. There is no guaranty that the moniker is URL moniker. Jacek

1 0

The WINE Project should solicit grants to hire professional developers
by Richard Yao June 29, 2010

June 29, 2010

Dear All: I am a senior undergraduate applied mathematics/computer science student and this year, I migrated from Windows 7 to Gentoo Linux on my computers. I tried using Linux alternatives to many applications I used on Windows, but not all software has good alternatives, so I have been using WINE for certain things. The WINE project's accomplishments so far have been extremely impressive, but at the same time, WINE's implementation of the Windows API is deficient in many ways and I think that the WINE project will need to improve its own organization before progress toward true API parity with Windows can be made. I can divide WINE's development resources into two groups, volunteer and professional. The volunteer group is predominantly focused on games.The professional group is comprised of CodeWeavers and Google. CodeWeavers does what its customers want it to do, and as such, it has a large focus on games. Google on the other hand, paid CodeWeavers to make some improvements to WINE, mostly for Picasa, but also for Adobe Photoshop CS2, the reason for which I cannot imagine. Google also has its annual Summer of Code program. Each source of manpower has its own special interest and I do not believe that WINE will ever obtain any kind of API parity with Windows as long as this remains the case. With these things in mind, I would like to propose that the WINE project solicit grants from charitable organizations so that it could hire professional developers to augment its existing resources, specifically in the areas for which special interests could care less. If the Wine project could solicit sufficient funding to hire a few dozen developers for a period of several years, then I think that having WINE become as good as Windows would enter the realm of possibility. I know that many people will laugh at my suggestion (especially when they read the organization I suggest that the WINE project contact), but as far as I can tell, the WINE project has not solicited grants to be able to hire professional developers and I think that failing to solicit such grants places a handicap on the WINE project. There exist charitable organizations that seek to fund solutions to "global problems that are ignored by governments and other organizations" (as stated in Wikipedia). Because enabling Windows programs to run on free UNIX operating systems would reduce the cost of computing for all people, including those in third world countries, I am certain that such organizations that would be willing to fund WINE, provided that the WINE project inform them of its existence. The specific organization from which I think that the WINE project should attempt to solicit grant money is the Bill and Melinda Gates Foundation. In consideration of their guiding principles and the fact that they must spend $1.5 billion a year, it seems only logical to me that they would provide funding for the WINE project if asked: http://www.gatesfoundation.org/about/Pages/guiding-principles.aspx http://en.wikipedia.org/wiki/Bill_%26_Melinda_Gates_Foundation#Activities The Bill and Melinda Gates Foundation is not the only organization for which the WINE project could solicit funding, but I think that it is a good place to start. Please consider the possibility of soliciting grants so that the WINE project could hire professional developers. Also, I am not registered on the mailing list, so please CC me any responses made either directly or indirectly to this email, even if it ridicules my suggestion. Yours truly, Richard Yao

3 2

Re: ntdll: add stub for NtSystemDebugControl (try 2)
by Andrew Nguyen June 29, 2010

June 29, 2010

2010/6/28 Austin English <austinenglish(a)gmail.com>: > with correct spec file this time > > -- > -Austin > > > > The spec argument that corresponds to the PULONG prototype argument should also be ptr.

1 0

Re: ntdll: add stub for NtSystemDebugControl
by Andrew Nguyen June 29, 2010

June 29, 2010

On Mon, Jun 28, 2010 at 8:16 PM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23431 > > -- > -Austin > > > > The NtSystemDebugControl spec types don't match the prototype arguments.

1 0

Re: configure.ac: Don't try to rm dirs.
by Alexandre Julliard June 28, 2010

June 28, 2010

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > Hi, > > This patch allows to do a make clean in a wine tree configured with > with-wine64 option and fix following errors : > rm: cannot remove `fonts': Is a directory > rm: cannot remove `server': Is a directory These should be symlinks in a wow64 tree. Probably you didn't start from a fresh tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource
by Alexandre Julliard June 28, 2010

June 28, 2010

Wolfram Sang <wolfram(a)the-dreams.de> writes: > According to TestBot (#2851), all non-crashing Windows versions return 0. > > Found while working on Bug 21012. Although this patch doesn't cure this > bug, I think it is still worth adding the check because the pointer > may come from the (always evil ;)) user-application. Do you have an actual application that does this, or is this just hiding a Wine bug? -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: ddraw: Move complex surface destruction into its own function
by Luke Benstead June 28, 2010

June 28, 2010

Ok I wasn't sure as it's pretty trivial. I'll resend along with the others after 1.2. On Jun 28, 2010 8:36 PM, "Henri Verbeet" <hverbeet(a)gmail.com> wrote: On 28 June 2010 20:03, Luke Benstead <kazade(a)gmail.com> wrote: > Needed to properly fix ddraw surfac... That's of course not appropriate during code freeze.

2 1

Re: ddraw: Move complex surface destruction into its own function
by Henri Verbeet June 28, 2010

June 28, 2010

On 28 June 2010 20:03, Luke Benstead <kazade(a)gmail.com> wrote: > Needed to properly fix ddraw surface refcounting as it must be called from > the surface thunks. > That's of course not appropriate during code freeze.

1 0

Re: kernel32: Add NERR_UserNotFound to Norweigan winerr
by Paul Vriens June 28, 2010

June 28, 2010

On 06/28/2010 08:15 PM, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=11168 > Hi Austin, Applying the patch gives: [paul(a)acer wine-git]$ patch -p 1 -i /home/paul/kernel32_nor.txt (Stripping trailing CRs from patch.) patching file dlls/kernel32/nls/winerr_nor.mc Compiling gives: ../../../wine-git/dlls/kernel32/nls/winerr_nor.mc:3737:2: Error: Unexpected EOF make: *** [nls/winerr_nor.mc.rc] Error 1 You need to add a '.' at the end of the mc file (see the others). -- Cheers, Paul.

2 1

Wine on cygwin now compiles!
by Austin English June 28, 2010

June 28, 2010

Thanks to a few recent commits by AJ (and several commits over the past months by others), wine now builds on Cygwin. Not everything works, of course, but still a neat exercise in recursion. I've put a screenshot of wine's notepad running on XP on bugzilla (http://bugs.winehq.org/show_bug.cgi?id=21181) see: http://bugs2.winehq.org/attachment.cgi?id=28896 -- -Austin

6 7

Fwd: Possible patch for #12706
by Jeff Cook June 28, 2010

June 28, 2010

This is a patch that makes WINE detect snd_usb_audio mics and assign them a mixer and working master control. See bug #12706 for more information about this problem: http://bugs.winehq.org/show_bug.cgi?id=12706 I wasn't able to test it completely because I wasn't able to switch my default input device to the USB mic and no one in IRC is helping with this, but it might make things work because theoretically the only problem was that WINE was ignoring devices that looked like snd_usb_audio's microphones. I suggest that someone who CAN get snd_usb_audio mic as their default test it out and confirm, I would really appreciate that. Thanks to all in IRC who helped me get things this far, especially mlankhorst. This patch is based against the current git HEAD, eaa227c12d8bb. I've also posted it at the aforementioned bug. -- Jeff Cook (801) 231-3157 jeff(a)deserettechnology.com

3 2

Re: user32: Make sure the desktop window is created before caps enumeration.
by Alexandre Julliard June 28, 2010

June 28, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch fixes the problem reported in the bug 21709. That's just hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0